Re: [Mesa-dev] Plumbing explicit synchronization through the Linux ecosystem

2020-03-17 Thread Jacob Lifshay
On Tue, Mar 17, 2020 at 7:08 PM Jason Ekstrand wrote: > > On Tue, Mar 17, 2020 at 7:16 PM Jacob Lifshay > wrote: > > > > On Tue, Mar 17, 2020 at 11:14 AM Lucas Stach wrote: > > > > > > Am Dienstag, den 17.03.2020, 10:59 -0700 schrieb Jacob Lifshay: > > > > I think I found a

Re: [GIT PULL] exynos-drm-next

2020-03-17 Thread Inki Dae
Hi Dave, 20. 3. 18. 오전 11:17에 Dave Airlie 이(가) 쓴 글: > This seems to contain a exynos drm fixes backmerge, please don't do > that without a headsup. > > Can you send one without that or do you need a fixes backmerge, if so > please request me to do that first, then rebase this and send it. Sorry

linux-next: manual merge of the drm tree with the omap tree

2020-03-17 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm tree got a conflict in: arch/arm/configs/omap2plus_defconfig between commit: 98c2cc359f8f ("ARM: omap2plus_defconfig: Update for moved and dropped options") from the omap tree and commit: e7e67d9a2f1d ("drm/omap: Switch the HDMI and VENC

Re: [GIT PULL] exynos-drm-next

2020-03-17 Thread Dave Airlie
This seems to contain a exynos drm fixes backmerge, please don't do that without a headsup. Can you send one without that or do you need a fixes backmerge, if so please request me to do that first, then rebase this and send it. Dave. On Mon, 16 Mar 2020 at 11:04, Inki Dae wrote: > >

Re: [Mesa-dev] Plumbing explicit synchronization through the Linux ecosystem

2020-03-17 Thread Jason Ekstrand
On Tue, Mar 17, 2020 at 7:16 PM Jacob Lifshay wrote: > > On Tue, Mar 17, 2020 at 11:14 AM Lucas Stach wrote: > > > > Am Dienstag, den 17.03.2020, 10:59 -0700 schrieb Jacob Lifshay: > > > I think I found a userspace-accessible way to create sync_files and > > > dma_fences that would fulfill the

[PATCH v9 01/11] drm/i915: Use 64-bit division macro

2020-03-17 Thread Guru Das Srinagesh
Since the PWM framework is switching struct pwm_state.duty_cycle's datatype to u64, prepare for this transition by using DIV_ROUND_UP_ULL to handle a 64-bit dividend. Cc: Jani Nikula Cc: Joonas Lahtinen Cc: David Airlie Cc: Daniel Vetter Cc: Chris Wilson Cc: "Ville Syrjälä" Cc:

[PATCH v9 10/11] backlight: pwm_bl: Use 64-bit division function

2020-03-17 Thread Guru Das Srinagesh
Since the PWM framework is switching struct pwm_state.period's datatype to u64, prepare for this transition by using div_u64 to handle a 64-bit dividend instead of a straight division operation. Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han Cc: Bartlomiej Zolnierkiewicz Cc:

Re: Fwd: [PATCH] Staging: drm_gem: Fix a typo in a function comment

2020-03-17 Thread Igor Torrente
Yes, I will do it. On Tue, Mar 17, 2020 at 2:04 PM Daniel Vetter wrote: > On Mon, Mar 16, 2020 at 06:08:30PM -0300, Igor Torrente wrote: > > Ccing dri-devel and linux-kernel. > > git apply-mbox chokes on this, can you pls resubmit? > > Thanks, Daniel > > > > > -- Forwarded message

Re: Plumbing explicit synchronization through the Linux ecosystem

2020-03-17 Thread Nicolas Dufresne
Le mardi 17 mars 2020 à 11:27 -0500, Jason Ekstrand a écrit : > On Tue, Mar 17, 2020 at 10:33 AM Nicolas Dufresne > wrote: > > Le lundi 16 mars 2020 à 23:15 +0200, Laurent Pinchart a écrit : > > > Hi Jason, > > > > > > On Mon, Mar 16, 2020 at 10:06:07AM -0500, Jason Ekstrand wrote: > > > > On

[PATCH v2] drm: Correct a typo in a function comment

2020-03-17 Thread Igor Matheus Andrade Torrente
Replace "pionter" with "pointer" in the drm_gem_handle_create description. Changes in v2: - Change subject text Signed-off-by: Igor Matheus Andrade Torrente --- drivers/gpu/drm/drm_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_gem.c

Re: [PATCH 3/4] mm: simplify device private page handling in hmm_range_fault

2020-03-17 Thread Jason Gunthorpe
On Tue, Mar 17, 2020 at 01:59:55PM +0100, Christoph Hellwig wrote: > On Tue, Mar 17, 2020 at 09:47:55AM -0300, Jason Gunthorpe wrote: > > I've been using v7 of Ralph's tester and it is working well - it has > > DEVICE_PRIVATE support so I think it can test this flow too. Ralph are > > you able? >

[PATCH v9 00/11] Convert PWM period and duty cycle to u64

2020-03-17 Thread Guru Das Srinagesh
Because period and duty cycle are defined in the PWM framework structs as ints with units of nanoseconds, the maximum time duration that can be set is limited to ~2.147 seconds. Consequently, applications desiring to set greater time periods via the PWM framework are not be able to do so - like,

Re: [PATCH RESEND] drm/lease: fix potential race in fill_object_idr

2020-03-17 Thread Qiujun Huang
On Wed, Mar 18, 2020 at 1:02 AM Daniel Vetter wrote: > > On Mon, Mar 16, 2020 at 03:18:23PM +0800, Qiujun Huang wrote: > > We should hold idr_mutex for idr_alloc. > > > > Signed-off-by: Qiujun Huang > > I've not seen the first version of this anywhere in my inbox, not sure > where that got lost.

[PATCH] drm/amdgpu: Initialize shadow to false in gfx_v9_0_rlcg_wreg

2020-03-17 Thread Nathan Chancellor
clang warns: drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c:754:6: warning: variable 'shadow' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] if (offset == grbm_cntl || offset == grbm_idx) ^

Re: [PATCH] drm/lease: fix WARNING in idr_destroy

2020-03-17 Thread Qiujun Huang
On Wed, Mar 18, 2020 at 12:57 AM Daniel Vetter wrote: > > On Mon, Mar 16, 2020 at 11:36:08AM +0800, Qiujun Huang wrote: > > leases has been destroyed: > > drm_master_put > > ->drm_master_destroy > > ->idr_destroy > > > > so the "out_lessee" needn't to call idr_destroy again. > > >

Re: Plumbing explicit synchronization through the Linux ecosystem

2020-03-17 Thread Nicolas Dufresne
Le lundi 16 mars 2020 à 23:15 +0200, Laurent Pinchart a écrit : > Hi Jason, > > On Mon, Mar 16, 2020 at 10:06:07AM -0500, Jason Ekstrand wrote: > > On Mon, Mar 16, 2020 at 5:20 AM Laurent Pinchart wrote: > > > On Wed, Mar 11, 2020 at 04:18:55PM -0400, Nicolas Dufresne wrote: > > > > (I know I'm

[PATCH v2] drm: Alligne a comment block

2020-03-17 Thread Igor Matheus Andrade Torrente
Fix a checkpatch warning caused by a misaligned comment block. Signed-off-by: Igor Matheus Andrade Torrente --- drivers/gpu/drm/drm_gem.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c index

[PATCH v2] drm/nouveau/kms/nvd9-: Add CRC support

2020-03-17 Thread Lyude Paul
This introduces support for CRC readback on gf119+, using the documentation generously provided to us by Nvidia: https://github.com/NVIDIA/open-gpu-doc/blob/master/Display-CRC/display-crc.txt We expose all available CRC sources. SF, SOR, PIOR, and DAC are exposed through a single set of "outp"

[PATCH 9/9] drm/nouveau/kms/nvd9-: Add CRC support

2020-03-17 Thread Lyude Paul
This introduces support for CRC readback on gf119+, using the documentation generously provided to us by Nvidia: https://github.com/NVIDIA/open-gpu-doc/blob/master/Display-CRC/display-crc.txt We expose all available CRC sources. SF, SOR, PIOR, and DAC are exposed through a single set of "outp"

[PATCH 2/9] drm/nouveau/kms/nv50-: Unroll error cleanup in nv50_head_create()

2020-03-17 Thread Lyude Paul
We'll be rolling back more things in this function, and the way it's structured is a bit confusing. So, let's clean this up a bit and just unroll in the event of failure. Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/dispnv50/head.c | 33 + 1 file changed, 23

[PATCH 7/9] drm/nouveau/kms/nv50-: Expose nv50_outp_atom in disp.h

2020-03-17 Thread Lyude Paul
In order to make sure that we flush disable updates at the right time when disabling CRCs, we'll need to be able to look at the outp state to see if we're changing it at the same time that we're disabling CRCs. So, expose the struct in disp.h. Signed-off-by: Lyude Paul ---

[PATCH 8/9] drm/nouveau/kms/nv50-: Move hard-coded object handles into header

2020-03-17 Thread Lyude Paul
While most of the functionality on Nvidia GPUs doesn't require using an explicit handle instead of the main VRAM handle + offset, there are a couple of places that do require explicit handles, such as CRC functionality. Since this means we're about to add another nouveau-chosen handle, let's just

[PATCH 3/9] drm/nouveau/kms/nv140-: Don't modify depth in state during atomic commit

2020-03-17 Thread Lyude Paul
Currently, we modify the depth value stored in the atomic state when performing a commit in order to workaround the fact we haven't implemented support for depths higher then 10 yet. This isn't idempotent though, as it will happen every atomic commit where we modify the OR state even if the head's

[PATCH 4/9] drm/nouveau/kms/nv50-: Fix disabling dithering

2020-03-17 Thread Lyude Paul
While we expose the ability to turn off hardware dithering for nouveau, we actually make the mistake of turning it on anyway, due to dithering_depth containing a non-zero value if our dithering depth isn't also set to 6 bpc. So, fix it by never enabling dithering when it's disabled.

[PATCH 5/9] drm/nouveau/kms/nv50-: s/harm/armh/g

2020-03-17 Thread Lyude Paul
We refer to the armed hardware assembly as armh elsewhere in nouveau, so fix the naming here to make it consistent. This patch contains no functional changes. Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/dispnv50/wndw.c | 12 ++-- 1 file changed, 6 insertions(+), 6

[PATCH 6/9] drm/nouveau/kms/nv140-: Track wndw mappings in nv50_head_atom

2020-03-17 Thread Lyude Paul
While we're not quite ready yet to add support for flexible wndw mappings, we are going to need to at least keep track of the static wndw mappings we're currently using in each head's atomic state. We'll likely use this in the future to implement real flexible window mapping, but the primary

[PATCH 0/9] drm/nouveau: Introduce CRC support for gf119+

2020-03-17 Thread Lyude Paul
Nvidia released some documentation on how CRC support works on their GPUs, hooray! So: this patch series implements said CRC support in nouveau, along with adding some special debugfs interfaces for some relevant igt-gpu-tools tests that we'll be sending in just a short bit. This additionally

[PATCH 1/9] drm/vblank: Add vblank works

2020-03-17 Thread Lyude Paul
From: Ville Syrjälä Add some kind of vblank workers. The interface is similar to regular delayed works, and also allows for re-scheduling. Whatever hardware programming we do in the work must be fast (must at least complete during the vblank, sometimes during the first few scanlines of vblank),

Re: [Mesa-dev] Plumbing explicit synchronization through the Linux ecosystem

2020-03-17 Thread Jacob Lifshay
On Tue, Mar 17, 2020 at 11:14 AM Lucas Stach wrote: > > Am Dienstag, den 17.03.2020, 10:59 -0700 schrieb Jacob Lifshay: > > I think I found a userspace-accessible way to create sync_files and > > dma_fences that would fulfill the requirements: > >

[PATCH 1/2] drm/nouveau/connector: Fix indenting in nouveau_connector_detect()

2020-03-17 Thread Lyude Paul
No functional changes Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/nouveau_connector.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c index 9a9a7f5003d3..0d42a7e5deff

[PATCH 2/2] drm/nouveau/connector: Fix DDC error when probing force-disabled connectors

2020-03-17 Thread Lyude Paul
Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/nouveau_connector.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c index 0d42a7e5deff..9fb00c4b9764 100644 ---

[PATCH] drm/nouveau: Remove nouveau_bios_connector_entry()

2020-03-17 Thread Lyude Paul
This function doesn't exist Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/nouveau_bios.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.h b/drivers/gpu/drm/nouveau/nouveau_bios.h index 18eb061ccafb..5495f004a297 100644 ---

Re: [PATCH 3/4] mm: simplify device private page handling in hmm_range_fault

2020-03-17 Thread Ralph Campbell
On 3/17/20 5:59 AM, Christoph Hellwig wrote: On Tue, Mar 17, 2020 at 09:47:55AM -0300, Jason Gunthorpe wrote: I've been using v7 of Ralph's tester and it is working well - it has DEVICE_PRIVATE support so I think it can test this flow too. Ralph are you able? This hunk seems trivial enough to

Re: [PATCH 2/2] mm: remove device private page support from hmm_range_fault

2020-03-17 Thread Ralph Campbell
On 3/17/20 4:56 AM, Jason Gunthorpe wrote: On Mon, Mar 16, 2020 at 01:24:09PM -0700, Ralph Campbell wrote: The reason for it being backwards is that "normally" a device doesn't want the device private page to be faulted back to system memory, it wants to get the device private struct page so

Re: [PATCH 3/4] mm: simplify device private page handling in hmm_range_fault

2020-03-17 Thread Ralph Campbell
On 3/17/20 12:34 AM, Christoph Hellwig wrote: On Mon, Mar 16, 2020 at 03:49:51PM -0700, Ralph Campbell wrote: On 3/16/20 12:32 PM, Christoph Hellwig wrote: Remove the code to fault device private pages back into system memory that has never been used by any driver. Also replace the usage of

Re: [PATCH 1/3] drm: drm_vm: Use fallthrough;

2020-03-17 Thread Joe Perches
On Tue, 2020-03-17 at 17:48 +0100, Daniel Vetter wrote: > On Thu, Mar 12, 2020 at 12:17:12PM -0700, Joe Perches wrote: > > Convert /* fallthrough */ style comments to fallthrough; > > > > Convert the various uses of fallthrough comments to fallthrough; > > > > Done via script > > Link: > >

Re: [PATCH] drm/msm/dpu: ensure device suspend happens during PM sleep

2020-03-17 Thread Doug Anderson
Hi, On Mon, Mar 16, 2020 at 4:06 AM Kalyan Thota wrote: > > "The PM core always increments the runtime usage counter > before calling the ->suspend() callback and decrements it > after calling the ->resume() callback" > > DPU and DSI are managed as runtime devices. When > suspend is triggered,

[PATCH 3/3] RFC: dma-buf: Add an API for importing and exporting sync files (v5)

2020-03-17 Thread Jason Ekstrand
Explicit synchronization is the future. At least, that seems to be what most userspace APIs are agreeing on at this point. However, most of our Linux APIs (both userspace and kernel UAPI) are currently built around implicit synchronization with dma-buf. While work is ongoing to change many of

Re: [PATCH] drm/lima: add trace point for tasks

2020-03-17 Thread Vasily Khoruzhick
On Mon, Mar 16, 2020 at 6:41 PM Qiang Yu wrote: > Not concrete reason, as the comment, trace point when > dma_fence_signal act as the task completion event, so not add duplicate > one. I see. Patch is: Reviewed-by: Vasily Khoruzhick Regards, Vasily

[PATCH] MAINTAINERS: Better regex for dma_buf|fence|resv

2020-03-17 Thread Daniel Vetter
We're getting some random other stuff that we're not really interested in, so match only word boundaries. Also avoid the capture group while at it. Suggested by Joe Perches. Cc: linux-me...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: linaro-mm-...@lists.linaro.org Cc: Joe Perches

Re: [RFC PATCH 0/8] *** Per context fencing ***

2020-03-17 Thread Chia-I Wu
On Mon, Mar 16, 2020 at 3:44 PM Gerd Hoffmann wrote: > > Hi, > > > >> At virtio level it is pretty simple: The host completes the SUBMIT_3D > > >> virtio command when it finished rendering, period. > > >> > > >> > > >> On the guest side we don't need the fence_id. The completion callback > >

Re: [PATCH v1 3/3] dt-bindings: display: grammar fixes in panel/

2020-03-17 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Sat, Mar 14, 2020 at 04:30:47PM +0100, Sam Ravnborg wrote: > Fix a few grammar/editorial issues spotted by Laurent Pinchart. > > Signed-off-by: Sam Ravnborg > Cc: Laurent Pinchart > Cc: Rob Herring > --- > .../bindings/display/panel/display-timings.yaml

Re: [PATCH v1 2/3] drm/panel-simple: drop use of data-mapping property

2020-03-17 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Sat, Mar 14, 2020 at 04:30:46PM +0100, Sam Ravnborg wrote: > The "data-mapping" property may not be the best way to describe the > interface between panels and display interfaces. > Drop use of in the panel-simple driver, so we have time to find > the right

Re: [PATCH v1 1/3] dt-bindings: display: drop data-mapping from panel-dpi

2020-03-17 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Sat, Mar 14, 2020 at 04:30:45PM +0100, Sam Ravnborg wrote: > data-mapping may not be the best way to describe the > data format used between panels and display interface. > > Drop it from the panel-dpi binding so we do not start to rely on it. > We can then

Re: [PATCH 87/89] drm/vc4: hdmi: Support the BCM2711 HDMI controllers

2020-03-17 Thread Daniel Rodriguez
On 2/24/20 4:07 AM, Maxime Ripard wrote: static void vc4_hdmi_encoder_enable(struct drm_encoder *encoder) { struct drm_display_mode *mode = >crtc->state->adjusted_mode; @@ -1314,6 +1438,92 @@ static int vc4_hdmi_init_resources(struct vc4_hdmi *vc4_hdmi) return 0; }

Re: [Mesa-dev] Plumbing explicit synchronization through the Linux ecosystem

2020-03-17 Thread Lucas Stach
Am Dienstag, den 17.03.2020, 10:59 -0700 schrieb Jacob Lifshay: > On Tue, Mar 17, 2020 at 10:21 AM Lucas Stach wrote: > > Am Dienstag, den 17.03.2020, 10:12 -0700 schrieb Jacob Lifshay: > > > One related issue with explicit sync using sync_file is that combined > > > CPUs/GPUs (the CPU cores

Re: [Mesa-dev] Plumbing explicit synchronization through the Linux ecosystem

2020-03-17 Thread Jacob Lifshay
On Tue, Mar 17, 2020 at 10:21 AM Lucas Stach wrote: > > Am Dienstag, den 17.03.2020, 10:12 -0700 schrieb Jacob Lifshay: > > One related issue with explicit sync using sync_file is that combined > > CPUs/GPUs (the CPU cores *are* the GPU cores) that do all the > > rendering in userspace (like

Re: [Mesa-dev] Plumbing explicit synchronization through the Linux ecosystem

2020-03-17 Thread Lucas Stach
Am Dienstag, den 17.03.2020, 11:33 -0400 schrieb Nicolas Dufresne: > Le lundi 16 mars 2020 à 23:15 +0200, Laurent Pinchart a écrit : > > Hi Jason, > > > > On Mon, Mar 16, 2020 at 10:06:07AM -0500, Jason Ekstrand wrote: > > > On Mon, Mar 16, 2020 at 5:20 AM Laurent Pinchart wrote: > > > > On Wed,

Re: [Mesa-dev] Plumbing explicit synchronization through the Linux ecosystem

2020-03-17 Thread Lucas Stach
Am Dienstag, den 17.03.2020, 10:12 -0700 schrieb Jacob Lifshay: > One related issue with explicit sync using sync_file is that combined > CPUs/GPUs (the CPU cores *are* the GPU cores) that do all the > rendering in userspace (like llvmpipe but for Vulkan and with extra > instructions for GPU

Re: [PATCH] drm/msm: Fix an error handling path 'msm_drm_init()'

2020-03-17 Thread Doug Anderson
Hi, On Sun, Mar 15, 2020 at 12:42 PM Christophe JAILLET wrote: > > If this memory allocation fails, we have to go through the error handling > path to perform some clean-up, as already done in other other paths of > this function. > > Fixes: db735fc4036b ("drm/msm: Set dma maximum segment size

Re: [Mesa-dev] Plumbing explicit synchronization through the Linux ecosystem

2020-03-17 Thread Jason Ekstrand
On Tue, Mar 17, 2020 at 12:13 PM Jacob Lifshay wrote: > > One related issue with explicit sync using sync_file is that combined > CPUs/GPUs (the CPU cores *are* the GPU cores) that do all the > rendering in userspace (like llvmpipe but for Vulkan and with extra > instructions for GPU tasks) but

Re: Plumbing explicit synchronization through the Linux ecosystem

2020-03-17 Thread Marek Olšák
On Tue., Mar. 17, 2020, 06:02 Michel Dänzer, wrote: > On 2020-03-16 7:33 p.m., Marek Olšák wrote: > > On Mon, Mar 16, 2020 at 5:57 AM Michel Dänzer > wrote: > >> On 2020-03-16 4:50 a.m., Marek Olšák wrote: > >>> The synchronization works because the Mesa driver waits for idle > (drains > >>>

Re: [Mesa-dev] Plumbing explicit synchronization through the Linux ecosystem

2020-03-17 Thread Jacob Lifshay
One related issue with explicit sync using sync_file is that combined CPUs/GPUs (the CPU cores *are* the GPU cores) that do all the rendering in userspace (like llvmpipe but for Vulkan and with extra instructions for GPU tasks) but need to synchronize with other drivers/processes is that there

[PATCH] MAINTAINERS: Better regex for dma_buf|fence|resv

2020-03-17 Thread Daniel Vetter
We're getting some random other stuff that we're not relly interested in, so match only word boundaries. Also avoid the capture group while at it. Suggested by Joe Perches. Cc: linux-me...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: linaro-mm-...@lists.linaro.org Cc: Joe Perches Cc:

Re: Fwd: [PATCH] Staging: drm_gem: Fix a typo in a function comment

2020-03-17 Thread Daniel Vetter
On Mon, Mar 16, 2020 at 06:08:30PM -0300, Igor Torrente wrote: > Ccing dri-devel and linux-kernel. git apply-mbox chokes on this, can you pls resubmit? Thanks, Daniel > > -- Forwarded message - > From: Igor Matheus Andrade Torrente > Date: Mon, Mar 16, 2020 at 6:04 PM >

Re: [PATCH RESEND] drm/lease: fix potential race in fill_object_idr

2020-03-17 Thread Daniel Vetter
On Mon, Mar 16, 2020 at 03:18:23PM +0800, Qiujun Huang wrote: > We should hold idr_mutex for idr_alloc. > > Signed-off-by: Qiujun Huang I've not seen the first version of this anywhere in my inbox, not sure where that got lost. Anyway, this seems like a false positive - I'm assuming this was

Re: [PATCH] drm/lease: fix WARNING in idr_destroy

2020-03-17 Thread Daniel Vetter
On Mon, Mar 16, 2020 at 11:36:08AM +0800, Qiujun Huang wrote: > leases has been destroyed: > drm_master_put > ->drm_master_destroy > ->idr_destroy > > so the "out_lessee" needn't to call idr_destroy again. > > Reported-and-tested-by:

Re: [PATCH v3] drm/bochs: downgrade pci_request_region failure from error to warning

2020-03-17 Thread Daniel Vetter
On Fri, Mar 13, 2020 at 09:41:52AM +0100, Gerd Hoffmann wrote: > Shutdown of firmware framebuffer has a bunch of problems. Because > of this the framebuffer region might still be reserved even after > drm_fb_helper_remove_conflicting_pci_framebuffers() returned. Is that still the fbdev lifetime

Re: [PATCH 1/3] drm: drm_vm: Use fallthrough;

2020-03-17 Thread Daniel Vetter
On Thu, Mar 12, 2020 at 12:17:12PM -0700, Joe Perches wrote: > Convert /* fallthrough */ style comments to fallthrough; > > Convert the various uses of fallthrough comments to fallthrough; > > Done via script > Link: >

Re: Plumbing explicit synchronization through the Linux ecosystem

2020-03-17 Thread Jason Ekstrand
On Tue, Mar 17, 2020 at 10:33 AM Nicolas Dufresne wrote: > > Le lundi 16 mars 2020 à 23:15 +0200, Laurent Pinchart a écrit : > > Hi Jason, > > > > On Mon, Mar 16, 2020 at 10:06:07AM -0500, Jason Ekstrand wrote: > > > On Mon, Mar 16, 2020 at 5:20 AM Laurent Pinchart wrote: > > > > On Wed, Mar 11,

Re: [PATCH v2 00/11] new cgroup controller for gpu/drm subsystem

2020-03-17 Thread Kenny Ho
Hi Tejun, What's your thoughts on this latest series? Regards, Kenny On Wed, Feb 26, 2020 at 2:02 PM Kenny Ho wrote: > > This is a submission for the introduction of a new cgroup controller for the > drm subsystem follow a series of RFCs [v1, v2, v3, v4] > > Changes from PR v1 > * changed

Re: Plumbing explicit synchronization through the Linux ecosystem

2020-03-17 Thread Jason Ekstrand
On Tue, Mar 17, 2020 at 3:01 AM Simon Ser wrote: > > On Monday, March 16, 2020 5:04 PM, Jason Ekstrand > wrote: > > > Hopefully, that will provide some motivation for other compositors > > (kwin, gnome-shell, etc.) because they now have a real user of it in > > an upstream driver for a major

[RFC PATCH 5/7] pwm: replace polarity enum with macros

2020-03-17 Thread Oleksandr Suvorov
To avoid duplication of pwm polarity definitions, remove "enum pwm_polarity" and use macros instead. Prepare to use both polarity flags in DTs. Signed-off-by: Oleksandr Suvorov --- drivers/pwm/core.c | 2 +- drivers/pwm/pwm-atmel-tcb.c | 8

[PATCH] Remove stable HAINAN board from max_sclk override check in radeon and amdgpu modules

2020-03-17 Thread Yassine Oudjana
Signed-off-by: Yassine Oudjana --- drivers/gpu/drm/amd/amdgpu/si_dpm.c | 1 - drivers/gpu/drm/radeon/si_dpm.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/si_dpm.c b/drivers/gpu/drm/amd/amdgpu/si_dpm.c index 4cb4c891120b..0860e85a2d35 100644 ---

Re: [PATCH] drm/i915: Cast remain to unsigned long in eb_relocate_vma

2020-03-17 Thread Nick Desaulniers
On Fri, Feb 14, 2020 at 7:36 AM Michel Dänzer wrote: > > On 2020-02-14 12:49 p.m., Jani Nikula wrote: > > On Fri, 14 Feb 2020, Chris Wilson wrote: > >> Quoting Jani Nikula (2020-02-14 06:36:15) > >>> On Thu, 13 Feb 2020, Nathan Chancellor wrote: > A recent commit in clang added

[RFC PATCH 0/7] Rework PWM_POLARITY_* flags

2020-03-17 Thread Oleksandr Suvorov
PWM_POLARITY_* flags were defined in include/linux/pwm.h as a enum and in include/dt-bindings/pwm/pwm.h as macros. This patchset fixes duplication and introduces using PWM_POLARITY_NORMAL flag instead of '0' constant in DT files. Oleksandr Suvorov (7): pwm: rename the PWM_POLARITY_INVERSED

Re: [PATCH 1/2] dt-binding: Add DSI/LVDS tc358775 bridge bindings

2020-03-17 Thread Sam Ravnborg
Hi Vinay. On Tue, Mar 17, 2020 at 12:25:42PM +0530, Vinay Simha B N wrote: > sam, > > i need some inputs on the below error. I had created this file > Documentation/devicetree/bindings/display/bridge/toshiba-tc358775.yaml > by using vim editor. Do we have any tool to create yaml file? I use

[PATCH 1/2] drm: encoder_slave: fix refcouting error for modules

2020-03-17 Thread Wolfram Sang
module_put() balances try_module_get(), not request_module(). Fix the error path to match that. Fixes: 2066facca4c7 ("drm/kms: slave encoder interface.") Signed-off-by: Wolfram Sang --- drivers/gpu/drm/drm_encoder_slave.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 3/4] mm: simplify device private page handling in hmm_range_fault

2020-03-17 Thread Jason Gunthorpe
On Tue, Mar 17, 2020 at 01:28:13PM +0100, Christoph Hellwig wrote: > On Tue, Mar 17, 2020 at 01:24:45PM +0100, Christoph Hellwig wrote: > > On Tue, Mar 17, 2020 at 09:15:36AM -0300, Jason Gunthorpe wrote: > > > > Getting rid of HMM_PFN_DEVICE_PRIVATE seems reasonable to me since a > > > > driver

Re: [PATCH 1/2] dt-binding: Add DSI/LVDS tc358775 bridge bindings

2020-03-17 Thread Vinay Simha B N
sam, i need some inputs on the below error. I had created this file Documentation/devicetree/bindings/display/bridge/toshiba-tc358775.yaml by using vim editor. Do we have any tool to create yaml file? i do not get the error when running 'make dt_binding_check' in my build environment

[PATCH 0/2] drm: encoder_slave: some updates

2020-03-17 Thread Wolfram Sang
While converting I2C users to new APIs, I found a refcounting problem in the encoder_slave implementation. This series fixes it and converts to the new API. Based on linux-next and only build tested. Wolfram Sang (2): drm: encoder_slave: fix refcouting error for modules drm: encoder_slave:

Re: [PATCH 2/2] mm: remove device private page support from hmm_range_fault

2020-03-17 Thread Jason Gunthorpe
On Mon, Mar 16, 2020 at 01:24:09PM -0700, Ralph Campbell wrote: > The reason for it being backwards is that "normally" a device doesn't want > the device private page to be faulted back to system memory, it wants to > get the device private struct page so it can update its page table to point >

Re: [PATCH hmm 8/8] mm/hmm: add missing call to hmm_pte_need_fault in HMM_PFN_SPECIAL handling

2020-03-17 Thread Jason Gunthorpe
On Mon, Mar 16, 2020 at 10:13:47AM +0100, Christoph Hellwig wrote: > On Wed, Mar 11, 2020 at 03:35:06PM -0300, Jason Gunthorpe wrote: > > From: Jason Gunthorpe > > > > Currently if a special PTE is encountered hmm_range_fault() immediately > > returns EFAULT and sets the HMM_PFN_SPECIAL error

Re: [PATCH 1/2] mm: handle multiple owners of device private pages in migrate_vma

2020-03-17 Thread Jason Gunthorpe
On Mon, Mar 16, 2020 at 06:52:58PM +0100, Christoph Hellwig wrote: > Add a new opaque owner field to struct dev_pagemap, which will allow > the hmm and migrate_vma code to identify who owns ZONE_DEVICE memory, > and refuse to work on mappings not owned by the calling entity. Using a pointer seems

Re: [PATCH hmm 8/8] mm/hmm: add missing call to hmm_pte_need_fault in HMM_PFN_SPECIAL handling

2020-03-17 Thread Jason Gunthorpe
On Tue, Mar 17, 2020 at 02:06:08PM +0100, Christoph Hellwig wrote: > On Tue, Mar 17, 2020 at 09:53:17AM -0300, Jason Gunthorpe wrote: > > > Thinking out loud a bit more: > > > > > > - do we really need HMM_PFN_ERROR, or is just a return value from > > >hmm_range_fault enough? > > > > I'm

Re: [PATCH 2/2] mm: remove device private page support from hmm_range_fault

2020-03-17 Thread Jason Gunthorpe
On Mon, Mar 16, 2020 at 07:49:35PM +0100, Christoph Hellwig wrote: > On Mon, Mar 16, 2020 at 11:42:19AM -0700, Ralph Campbell wrote: > > > > On 3/16/20 10:52 AM, Christoph Hellwig wrote: > >> No driver has actually used properly wire up and support this feature. > >> There is various code related

Re: [PATCH v1 02/36] dt-bindings: spi: support non-spi bindings as SPI slaves

2020-03-17 Thread Maxime Ripard
Hi Sam, On Sun, Mar 15, 2020 at 02:43:42PM +0100, Sam Ravnborg wrote: > Independent bindings can be SPI slaves which for example is > the case for several panel bindings. > > Move SPI slave properties to spi-slave.yaml so the independent > SPI slave bindings can include spi-slave.yaml rather than

Re: [PATCH v1 12/36] dt-bindings: display: convert jdi,lt070me05000 to DT Schema

2020-03-17 Thread Vinay Simha B N
sam, Reviewed-by: Vinay Simha BN Thanks. On Sun, Mar 15, 2020 at 7:14 PM Sam Ravnborg wrote: > > Signed-off-by: Sam Ravnborg > Cc: Vinay Simha BN > Cc: Thierry Reding > Cc: Sam Ravnborg > --- > .../display/panel/jdi,lt070me05000.txt| 31 - >

Re: KASAN: vmalloc-out-of-bounds Write in bitfill_aligned

2020-03-17 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:fb33c651 Linux 5.6-rc6 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=17dacd55e0 kernel config: https://syzkaller.appspot.com/x/.config?x=9f894bd92023de02 dashboard link:

Re: Plumbing explicit synchronization through the Linux ecosystem

2020-03-17 Thread Tomek Bury
> vkAcquireNextImageKHR() [...] it's the application's decision whether it > wants a fence, a semaphore, both or none Correction: "or none" is not allowed ___ dri-devel mailing list dri-devel@lists.freedesktop.org

Re: [PATCH 3/4] mm: simplify device private page handling in hmm_range_fault

2020-03-17 Thread Jason Gunthorpe
On Mon, Mar 16, 2020 at 08:32:15PM +0100, Christoph Hellwig wrote: > diff --git a/mm/hmm.c b/mm/hmm.c > index 180e398170b0..cfad65f6a67b 100644 > +++ b/mm/hmm.c > @@ -118,15 +118,6 @@ static inline void hmm_pte_need_fault(const struct > hmm_vma_walk *hmm_vma_walk, > /* We aren't ask to do

Re: [PATCH hmm 8/8] mm/hmm: add missing call to hmm_pte_need_fault in HMM_PFN_SPECIAL handling

2020-03-17 Thread Jason Gunthorpe
On Mon, Mar 16, 2020 at 01:49:53PM +0100, Christoph Hellwig wrote: > On Mon, Mar 16, 2020 at 09:10:53AM -0300, Jason Gunthorpe wrote: > > On Mon, Mar 16, 2020 at 10:13:47AM +0100, Christoph Hellwig wrote: > > > On Wed, Mar 11, 2020 at 03:35:06PM -0300, Jason Gunthorpe wrote: > > > > From: Jason

Re: [PATCH 08/12] docs: fix broken references to text files

2020-03-17 Thread Jason Gunthorpe
On Tue, Mar 17, 2020 at 02:10:47PM +0100, Mauro Carvalho Chehab wrote: > Several references got broken due to txt to ReST conversion. > > Several of them can be automatically fixed with: > > scripts/documentation-file-ref-check --fix > > Signed-off-by: Mauro Carvalho Chehab >

Re: [PATCH v1 02/36] dt-bindings: spi: support non-spi bindings as SPI slaves

2020-03-17 Thread Maxime Ripard
Hi, On Mon, Mar 16, 2020 at 10:43:46PM +0100, Sam Ravnborg wrote: > On Mon, Mar 16, 2020 at 09:48:50PM +0100, Maxime Ripard wrote: > > Hi Sam, > > > > On Sun, Mar 15, 2020 at 02:43:42PM +0100, Sam Ravnborg wrote: > > > Independent bindings can be SPI slaves which for example is > > > the case for

[PATCH libdrm] modetest: set_gamma only if CRTC supports gamma property

2020-03-17 Thread Rohit Visavalia
Current implementation shows error as "failed to set gamma: Function no implemented" if platform specific drm has no gamma property implemented Signed-off-by: Rohit Visavalia --- tests/modetest/modetest.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git

Re: [PATCH v1 13/36] dt-bindings: display: convert kingdisplay,kd035g6-54nt to DT Schema

2020-03-17 Thread Paul Cercueil
Hi Sam, Le dim. 15 mars 2020 à 14:43, Sam Ravnborg a écrit : Signed-off-by: Sam Ravnborg Reviewed-by: Paul Cercueil Cheers, -Paul Cc: Paul Cercueil Cc: Thierry Reding Cc: Sam Ravnborg --- .../panel/kingdisplay,kd035g6-54nt.txt| 42 -

[PATCH v2 5/5] arm64: allwinner: dts: a64: add LCD-related device nodes for PinePhone

2020-03-17 Thread Icenowy Zheng
PinePhone uses PWM backlight and a XBD599 LCD panel over DSI for display. Add its device nodes. Signed-off-by: Icenowy Zheng --- No changes in v2. .../dts/allwinner/sun50i-a64-pinephone.dtsi | 37 +++ 1 file changed, 37 insertions(+) diff --git

Re: [PATCH v1 1/3] dt-bindings: display: drop data-mapping from panel-dpi

2020-03-17 Thread Maxime Ripard
Hi Sam, On Sat, Mar 14, 2020 at 04:30:45PM +0100, Sam Ravnborg wrote: > data-mapping may not be the best way to describe the > data format used between panels and display interface. > > Drop it from the panel-dpi binding so we do not start to rely on it. > We can then work out how to best

[PATCH 00/12] Fix broken references for Documentation/*

2020-03-17 Thread Mauro Carvalho Chehab
This patch series is against next-20200317. It fixes all references to files under Documentation/* that were moved, renamed or removed. After this patch series, this script: ./scripts/documentation-file-ref-check Doesn't complain about any broken reference. Mauro Carvalho Chehab (12

[PATCH v2 3/5] drm: panel: add Xingbangda XBD599 panel

2020-03-17 Thread Icenowy Zheng
Xingbangda XBD599 is a 5.99" 720x1440 MIPI-DSI IPS LCD panel made by Xingbangda, which is used on PinePhone final assembled phones. Add support for it. Signed-off-by: Icenowy Zheng --- Changes in v2: - Raised copyright info to 2020. - Sort panel operation functions. - Sort inclusion.

Fwd: [PATCH] Staging: drm_gem: Fix a typo in a function comment

2020-03-17 Thread Igor Torrente
Ccing dri-devel and linux-kernel. -- Forwarded message - From: Igor Matheus Andrade Torrente Date: Mon, Mar 16, 2020 at 6:04 PM Subject: [PATCH] Staging: drm_gem: Fix a typo in a function comment To: , , , , , < sumit.sem...@linaro.org> Cc: Igor Matheus Andrade Torrente , <

Re: [PATCH hmm 2/8] mm/hmm: don't free the cached pgmap while scanning

2020-03-17 Thread Jason Gunthorpe
On Mon, Mar 16, 2020 at 07:13:24PM +0100, Christoph Hellwig wrote: > On Mon, Mar 16, 2020 at 03:07:13PM -0300, Jason Gunthorpe wrote: > > I chose this to be simple without having to goto unwind it. > > > > So, instead like this: > > As ѕaid, and per the previous discussion: I think just

[PATCH] Staging: drm_gem: Fix a misaligned comment block

2020-03-17 Thread Igor Matheus Andrade Torrente
Fix a checkpatch warning caused by a misaligned comment block. Signed-off-by: Igor Matheus Andrade Torrente --- drivers/gpu/drm/drm_gem.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c index

Re: [PATCH 2/2] mm: remove device private page support from hmm_range_fault

2020-03-17 Thread Jason Gunthorpe
On Mon, Mar 16, 2020 at 11:42:19AM -0700, Ralph Campbell wrote: > > On 3/16/20 10:52 AM, Christoph Hellwig wrote: > > No driver has actually used properly wire up and support this feature. > > There is various code related to it in nouveau, but as far as I can tell > > it never actually got

Re: [PATCH 1/6] lib/scatterlist: add sg_set_dma_addr() function

2020-03-17 Thread Jason Gunthorpe
On Mon, Mar 16, 2020 at 02:52:13AM -0700, Christoph Hellwig wrote: > On Mon, Mar 16, 2020 at 10:41:42AM +0100, Christian König wrote: > > Well I would prefer if the drivers can somehow express their requirements > > and get IOVA structures already in the form they need. > > > > Converting the

[PULL] drm-misc-next

2020-03-17 Thread Maxime Ripard
Hi, Here is what should be the final drm-misc-next PR for 5.7. Maxime drm-misc-next-2020-03-17: drm-misc-next for 5.7: UAPI Changes: Cross-subsystem Changes: Core Changes: - dp-mst: Remove register_connector callback, add drm_dp_destroy_connector - Changes to scnprintf on multiple

Re: Plumbing explicit synchronization through the Linux ecosystem

2020-03-17 Thread Tomek Bury
Hi Jason, I've been wrestling with the sync problems in Wayland some time ago, but only with regards to 3D drivers. The guarantee given by the GL/GLES spec is limited to a single graphics context. If the same buffer is accessed by 2 contexts the outcome is unspecified. The cross-context and

Re: [PATCH hmm 8/8] mm/hmm: add missing call to hmm_pte_need_fault in HMM_PFN_SPECIAL handling

2020-03-17 Thread Jason Gunthorpe
On Tue, Mar 17, 2020 at 01:32:10PM +0100, Christoph Hellwig wrote: > On Mon, Mar 16, 2020 at 02:12:01PM +0100, Christoph Hellwig wrote: > > On Mon, Mar 16, 2020 at 10:04:58AM -0300, Jason Gunthorpe wrote: > > > > Ok. I had some cleanups like this based of older trees, but if you are > > > >

Re: Plumbing explicit synchronization through the Linux ecosystem

2020-03-17 Thread Tomek Bury
> GL and GLES are not relevant. What is relevant is EGL, which defines > interfaces to make things work on the native platform. Yes and no. This is what EGL spec says about sharing a texture between contexts: "OpenGL and OpenGL ES makes no attempt to synchronize access to texture objects. If a

Re: [PATCH 86/89] drm/vc4: hdmi: Adjust HSM clock rate depending on pixel rate

2020-03-17 Thread Nicolas Saenz Julienne
Hi Maxime, On Mon, 2020-02-24 at 10:07 +0100, Maxime Ripard wrote: > @@ -1460,6 +1456,7 @@ static int vc4_hdmi_dev_remove(struct platform_device > *pdev) > } > > struct vc4_hdmi_variant bcm2835_variant = { > + .max_pixel_clock= 14850, Just a reminder this might change in the

  1   2   >