Re: [PATCH v5 13/16] drm/mediatek: add ETHDR support for MT8195

2021-09-23 Thread Nancy . Lin
Hi Chun-Kuang, Thanks for the review. On Wed, 2021-09-22 at 08:09 +0800, Chun-Kuang Hu wrote: > Hi, Nancy: > > Nancy.Lin 於 2021年9月6日 週一 下午3:15寫道: > > > > ETHDR is a part of ovl_adaptor. > > ETHDR is designed for HDR video and graphics conversion in the > > external > > display path. It

[git pull] drm fixes for 5.15-rc3

2021-09-23 Thread Dave Airlie
Hey Linus, quiet week this week, just some i915 and amd fixes, just getting ready for my all nighter maintainer summit! Dave. drm-fixes-2021-09-24: drm fixes for 5.15-rc3 i915: - Fix ADL-P memory bandwidth parameters - Fix memory corruption due to a double free - Fix memory leak in DMC

Re: [PATCH v2 1/9] vfio/ccw: Use functions for alloc/free of the vfio_ccw_private

2021-09-23 Thread Eric Farman
On Thu, 2021-09-09 at 16:38 -0300, Jason Gunthorpe wrote: > Makes the code easier to understand what is memory lifecycle and what > is > other stuff. > > Signed-off-by: Jason Gunthorpe > --- > drivers/s390/cio/vfio_ccw_drv.c | 137 ++-- > > 1 file changed, 78

Re: [PATCH v2 2/9] vfio/ccw: Pass vfio_ccw_private not mdev_device to various functions

2021-09-23 Thread Eric Farman
On Thu, 2021-09-09 at 16:38 -0300, Jason Gunthorpe wrote: > mdev_device should only be used in functions assigned to ops > callbacks, > interior functions should use the struct vfio_ccw_private instead of > repeatedly trying to get it from the mdev. > > Signed-off-by: Jason Gunthorpe > --- >

Re: [PATCH v2 6/9] vfio/mdev: Add mdev available instance checking to the core

2021-09-23 Thread Eric Farman
On Tue, 2021-09-21 at 10:19 -0300, Jason Gunthorpe wrote: > On Mon, Sep 20, 2021 at 08:02:29PM +0200, Cornelia Huck wrote: > > On Thu, Sep 09 2021, Jason Gunthorpe wrote: > > > > > Many of the mdev drivers use a simple counter for keeping track > > > of the > > > available instances. Move this

Re: [PATCH v2 3/3] drm/bridge: ti-sn65dsi86: Add NO_CONNECTOR support

2021-09-23 Thread Laurent Pinchart
Hi Rob, On Thu, Sep 23, 2021 at 10:31:52AM -0700, Rob Clark wrote: > On Wed, Sep 22, 2021 at 5:44 PM Laurent Pinchart wrote: > > On Mon, Sep 20, 2021 at 03:58:00PM -0700, Rob Clark wrote: > > > From: Rob Clark > > > > > > Slightly awkward to fish out the display_info when we aren't creating > >

[PATCH v5 2/2] drm/bridge: ti-sn65dsi86: Implement the pwm_chip

2021-09-23 Thread Bjorn Andersson
The SN65DSI86 provides the ability to supply a PWM signal on GPIO 4, with the primary purpose of controlling the backlight of the attached panel. Add an implementation that exposes this using the standard PWM framework, to allow e.g. pwm-backlight to expose this to the user. Signed-off-by: Bjorn

[PATCH v5 1/2] pwm: Introduce single-PWM of_xlate function

2021-09-23 Thread Bjorn Andersson
The existing pxa driver and the upcoming addition of PWM support in the TI sn565dsi86 DSI/eDP bridge driver both has a single PWM channel and thereby a need for a of_xlate function with the period as its single argument. Introduce a common helper function in the core that can be used as of_xlate

[PATCH v2] drm/amd/display: Fix randomly flicking on overlay with enabled ABM

2021-09-23 Thread yipeng.chen
From: "Yipeng Chen (Jasber)" [Why] Enabled ABM (level != 0) would raise short pulse irq DC_IRQ_SOURCE_HPD1RX randomly with PSR error LINK_CRC_ERROR. Actually there is no hot plugging on EDP panel. After correcting CRC error, there is no need to send drm hotplug event. [How] Returning false

[PATCH 3/3] drm/panel: Delete panel on mipi_dsi_attach() failure

2021-09-23 Thread Brian Norris
Many DSI panel drivers fail to clean up their panel references on mipi_dsi_attach() failure, so we're leaving a dangling drm_panel reference to freed memory. Clean that up on failure. Noticed by inspection, after seeing similar problems on other drivers. Therefore, I'm not marking Fixes/stable.

[PATCH 1/3] drm/panel: kingdisplay-kd097d04: Delete panel on attach() failure

2021-09-23 Thread Brian Norris
If we fail to attach (e.g., because 1 of 2 dual-DSI controllers aren't ready), we leave a dangling drm_panel reference to freed memory. Clean that up on failure. Fixes: 2a994cbed6b2 ("drm/panel: Add Kingdisplay KD097D04 panel driver") Signed-off-by: Brian Norris ---

[PATCH 2/3] drm/panel: innolux-p079zca: Delete panel on attach() failure

2021-09-23 Thread Brian Norris
If we fail to attach (e.g., because 1 of 2 dual-DSI controllers aren't ready), we leave a dangling drm_panel reference to freed memory. Clean that up on failure. This problem exists since the driver's introduction, but is especially relevant after refactored for dual-DSI variants. Fixes:

[PATCH 0/3] drm/panel: Proper cleanup after mipi_dsi_attach()

2021-09-23 Thread Brian Norris
I've tested a few dual-DSI panel drivers which choke if they PROBE_DEFER at the wrong time, so I patched those up in patch 1 and 2. Patch 3 fixes the other drivers that I couldn't test, but seem to have all the same problem. Brian Norris (3): drm/panel: kingdisplay-kd097d04: Delete panel on

Re: [PATCH v2 0/4] CMDQ refinement of Mediatek DRM driver

2021-09-23 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo Serra 於 2021年9月24日 週五 上午12:36寫道: > > Hi Chun-Kuang, > > Missatge de Chun-Kuang Hu del dia dt., 21 de > set. 2021 a les 15:15: > > > > Hi, Enric: > > > > Enric Balletbo Serra 於 2021年9月21日 週二 下午4:36寫道: > > > > > > Hi Chun-Kuang, > > > > > > (again without html format,

Re: BoF at LPC: Documenting the Heterogeneous Memory Model Architecture

2021-09-23 Thread Daniel Stone
Hi, On Thu, 23 Sept 2021 at 21:40, Matthew Wilcox wrote: > On Thu, Sep 23, 2021 at 04:25:08PM -0400, Felix Kuehling wrote: > > Change of plan: Instead of a BoF, this is now a session in the "GPU/media/AI > > buffer management and interop MC" micro conference. Thank you Daniel Stone > > for

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-23 Thread Paul Boddie
On Thursday, 23 September 2021 22:23:28 CEST H. Nikolaus Schaller wrote: > > > Am 23.09.2021 um 21:39 schrieb Paul Cercueil : > > > > Start by wiring things properly, like in my previously linked DTS, and > > *test*. If it fails, tell us where it fails. > > Well, I tell where drm_bridge_attach

Re: [PATCH] DRM/Panel : abt-y030xx067a yellow tint fix

2021-09-23 Thread Paul Cercueil
Hi, Le jeu., sept. 23 2021 at 22:17:51 +0200, Sam Ravnborg a écrit : Hi Christophe, Paul, On Tue, Sep 14, 2021 at 11:27:16AM +0200, Christophe Branchereau wrote: The previous parameters caused an unbalanced yellow tint. Signed-off-by: Christophe Branchereau with the subject fixed the

RE: BoF at LPC: Documenting the Heterogeneous Memory Model Architecture

2021-09-23 Thread Phillips, Daniel
[AMD Official Use Only] Hi Matt, I originally picked the 10 am pdt time slot to avoid those conflicts. But I see the overlap is only partial. I also see Peterz is giving a talk that also overlaps partially. But I think this is survivable. I suggest we just try to make this work as best we

[pull] amdgpu, amdkfd drm-fixes-5.15

2021-09-23 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.15. The following changes since commit e4e737bb5c170df6135a127739a9e6148ee3da82: Linux 5.15-rc2 (2021-09-19 17:28:22 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-5.15-2021-09-23 for you to

Re: [PATCH v12 05/35] dt-bindings: clock: tegra-car: Document new clock sub-nodes

2021-09-23 Thread Rob Herring
On Mon, 20 Sep 2021 21:11:15 +0300, Dmitry Osipenko wrote: > Document sub-nodes which describe Tegra SoC clocks that require a higher > voltage of the core power domain in order to operate properly on a higher > clock rates. Each node contains a phandle to OPP table and power domain. > > The

Re: [PATCH v6 1/2] drm/bridge: parade-ps8640: Use regmap APIs

2021-09-23 Thread Doug Anderson
Hi, On Tue, Sep 21, 2021 at 11:06 AM Philip Chen wrote: > > Replace the direct i2c access (i2c_smbus_* functions) with regmap APIs, > which will simplify the future update on ps8640 driver. > > Reviewed-by: Douglas Anderson > Acked-by: Sam Ravnborg > Signed-off-by: Philip Chen > --- > > (no

Re: BoF at LPC: Documenting the Heterogeneous Memory Model Architecture

2021-09-23 Thread Matthew Wilcox
On Thu, Sep 23, 2021 at 04:25:08PM -0400, Felix Kuehling wrote: > Change of plan: Instead of a BoF, this is now a session in the "GPU/media/AI > buffer management and interop MC" micro conference. Thank you Daniel Stone > for making that happen. >

Re: BoF at LPC: Documenting the Heterogeneous Memory Model Architecture

2021-09-23 Thread Felix Kuehling
Change of plan: Instead of a BoF, this is now a session in the "GPU/media/AI buffer management and interop MC" micro conference. Thank you Daniel Stone for making that happen. https://linuxplumbersconf.org/event/11/contributions/1112/ It is scheduled for tomorrow (Friday) 08:40-10:00 Pacific,

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-23 Thread H. Nikolaus Schaller
Hi Paul, > Am 23.09.2021 um 21:39 schrieb Paul Cercueil : > > > > Le jeu., sept. 23 2021 at 20:52:23 +0200, H. Nikolaus Schaller > a écrit : >> Hi Paul, >>> Am 23.09.2021 um 15:30 schrieb Paul Cercueil : >>> Hi Nikolaus, >>> Le jeu., sept. 23 2021 at 13:41:28 +0200, H. Nikolaus Schaller

Re: [PATCH] DRM/Panel : abt-y030xx067a yellow tint fix

2021-09-23 Thread Sam Ravnborg
Hi Christophe, Paul, On Tue, Sep 14, 2021 at 11:27:16AM +0200, Christophe Branchereau wrote: > The previous parameters caused an unbalanced yellow tint. > > Signed-off-by: Christophe Branchereau with the subject fixed the patch is: Acked-by: Sam Ravnborg Paul - I assume you will apply this as

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-23 Thread Paul Cercueil
Le jeu., sept. 23 2021 at 20:52:23 +0200, H. Nikolaus Schaller a écrit : Hi Paul, Am 23.09.2021 um 15:30 schrieb Paul Cercueil : Hi Nikolaus, Le jeu., sept. 23 2021 at 13:41:28 +0200, H. Nikolaus Schaller a écrit : Hi Laurent, Ah, ok. But then we still have issues. Firstly I

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-23 Thread H . Nikolaus Schaller
Hi Paul, > Am 23.09.2021 um 15:30 schrieb Paul Cercueil : > > Hi Nikolaus, > > Le jeu., sept. 23 2021 at 13:41:28 +0200, H. Nikolaus Schaller > a écrit : >> Hi Laurent, >> Ah, ok. >> But then we still have issues. >> Firstly I would assume that get_edid only works properly if it is

[PATCH] drm/vc4: crtc: Make sure the HDMI controller is powered when disabling

2021-09-23 Thread Maxime Ripard
Since commit 875a4d536842 ("drm/vc4: drv: Disable the CRTC at boot time"), during the initial setup of the driver we call into the VC4 HDMI controller hooks to make sure the controller is properly disabled. However, we were never making sure that the device was properly powered while doing so.

Re: [PATCH 1/1] drm: This patch fixes colour banding caused by wrong information passed by the Lenovo Thinkpad L540 panel.

2021-09-23 Thread Alex Deucher
On Thu, Sep 23, 2021 at 2:15 PM Francesco Paolo Lovergine wrote: > > Hi, The patch title is a little long. How about something like: drm: fix colour banding on Lenovo Thinkpad L540 panel > > there is an issue with Lenovo Thinkpad L540 very similar to those described > here: >

Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has()

2021-09-23 Thread Borislav Petkov
On Thu, Sep 23, 2021 at 12:05:58AM +0300, Kirill A. Shutemov wrote: > Unless we find other way to guarantee RIP-relative access, we must use > fixup_pointer() to access any global variables. Yah, I've asked compiler folks about any guarantees we have wrt rip-relative addresses but it doesn't look

[PATCH 1/1] drm: This patch fixes colour banding caused by wrong information passed by the Lenovo Thinkpad L540 panel.

2021-09-23 Thread Francesco Paolo Lovergine
Hi, there is an issue with Lenovo Thinkpad L540 very similar to those described here: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1749420 or here: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1788308 that is a bad looking color banding with dark colors mainly. It happens with

Re: Multiple DRI card detection in compositor systemd units

2021-09-23 Thread Hoosier, Matt
Hi Pekka, Those are fair answers. In my case, it does happen that the configuration available on the virtual cards includes a way to set distinct names reported by drmGetVersion()->name. It looks like the consensus is that UDev rules probably shouldn't be consulting the name as a

Re: [PATCH v2 3/3] drm/bridge: ti-sn65dsi86: Add NO_CONNECTOR support

2021-09-23 Thread Rob Clark
On Wed, Sep 22, 2021 at 5:44 PM Laurent Pinchart wrote: > > Hi Rob, > > Thank you for the patch. > > On Mon, Sep 20, 2021 at 03:58:00PM -0700, Rob Clark wrote: > > From: Rob Clark > > > > Slightly awkward to fish out the display_info when we aren't creating > > own connector. But I don't see an

[PATCH v2] drm/i915/bdb: Fix version check

2021-09-23 Thread Lukasz Majczak
With patch "drm/i915/vbt: Fix backlight parsing for VBT 234+" the size of bdb_lfp_backlight_data structure has been increased, causing if-statement in the parse_lfp_backlight function that comapres this structure size to the one retrieved from BDB, always to fail for older revisions. This patch

Re: [PATCH v2 0/4] CMDQ refinement of Mediatek DRM driver

2021-09-23 Thread Enric Balletbo Serra
Hi Chun-Kuang, Missatge de Chun-Kuang Hu del dia dt., 21 de set. 2021 a les 15:15: > > Hi, Enric: > > Enric Balletbo Serra 於 2021年9月21日 週二 下午4:36寫道: > > > > Hi Chun-Kuang, > > > > (again without html format, sorry for the noise) > > > > Missatge de Chun-Kuang Hu del dia dj., 12 > > d’ag. 2021

[patch 00/11] hrtimers: Cleanup hrtimer_forward() [ab]use

2021-09-23 Thread Thomas Gleixner
A recent syzbot report unearthed abuse of hrtimer_forward() which can cause runaway timers hogging the CPU in timer expiry context by rearming the timer in the past over and over. This happens when the caller uses timer->expiry for the 'now' argument of hrtimer_forward(). That works as long as

[patch 07/11] drm/i915/pmu: Use hrtimer_forward_now()

2021-09-23 Thread Thomas Gleixner
hrtimer_forward() is about to be removed from the public interfaces. Replace it with hrtimer_forward_now() which provides the same functionality. Signed-off-by: Thomas Gleixner Cc: David Airlie Cc: intel-...@lists.freedesktop.org Cc: Joonas Lahtinen Cc: Jani Nikula Cc:

Re: [PATCH v3 1/6] drm/vc4: select PM (openrisc)

2021-09-23 Thread Maxime Ripard
On Thu, Sep 23, 2021 at 07:55:32AM -0700, Nathan Chancellor wrote: > On Thu, Sep 23, 2021 at 04:52:08PM +0200, Maxime Ripard wrote: > > Hi Nathan, > > > > On Wed, Sep 22, 2021 at 08:49:50AM -0700, Nathan Chancellor wrote: > > > On Wed, Sep 22, 2021 at 10:41:56AM +0200, Maxime Ripard wrote: > > >

Re: [PATCH v2 09/12] lib: test_hmm add module param for zone device type

2021-09-23 Thread Sierra Guiza, Alejandro (Alex)
On 9/21/2021 12:14 AM, Alistair Popple wrote: On Tuesday, 21 September 2021 6:05:30 AM AEST Sierra Guiza, Alejandro (Alex) wrote: On 9/20/2021 3:53 AM, Alistair Popple wrote: On Tuesday, 14 September 2021 2:16:01 AM AEST Alex Sierra wrote: In order to configure device public in test_hmm,

Re: [RFC PATCH v3 1/6] drm/doc: Color Management and HDR10 RFC

2021-09-23 Thread Vitaly Prosyak
On 2021-09-23 9:40 a.m., Harry Wentland wrote: On 2021-09-23 04:01, Pekka Paalanen wrote: On Wed, 22 Sep 2021 11:06:53 -0400 Harry Wentland wrote: On 2021-09-20 20:14, Harry Wentland wrote: On 2021-09-15 10:01, Pekka Paalanen wrote:> On Fri, 30 Jul 2021 16:41:29 -0400 Harry Wentland

Re: [Intel-gfx] [PATCH v6 3/9] drm/i915/gt: Increase suspend timeout

2021-09-23 Thread Thomas Hellström
On 9/23/21 4:33 PM, Tvrtko Ursulin wrote: On 23/09/2021 14:19, Thomas Hellström wrote: On 9/23/21 2:59 PM, Tvrtko Ursulin wrote: On 23/09/2021 12:47, Thomas Hellström wrote: Hi, Tvrtko, On 9/23/21 12:13 PM, Tvrtko Ursulin wrote: On 22/09/2021 07:25, Thomas Hellström wrote: With GuC

Re: [PATCH] drm/i915/guc, docs: Fix pdfdocs build error by removing nested grid

2021-09-23 Thread Jani Nikula
On Mon, 20 Sep 2021, Akira Yokosawa wrote: > Nested grids in grid-table cells are not specified as proper ReST > constructs. > Commit 572f2a5cd974 ("drm/i915/guc: Update firmware to v62.0.0") > added a couple of kerneldoc tables of the form: > >

Re: [PATCH v3 1/6] drm/vc4: select PM (openrisc)

2021-09-23 Thread Nathan Chancellor
On Thu, Sep 23, 2021 at 04:52:08PM +0200, Maxime Ripard wrote: > Hi Nathan, > > On Wed, Sep 22, 2021 at 08:49:50AM -0700, Nathan Chancellor wrote: > > On Wed, Sep 22, 2021 at 10:41:56AM +0200, Maxime Ripard wrote: > > > Hi Randy, > > > > > > On Sun, Sep 19, 2021 at 09:40:44AM -0700, Randy Dunlap

Re: [PATCH v3 1/6] drm/vc4: select PM (openrisc)

2021-09-23 Thread Maxime Ripard
Hi Nathan, On Wed, Sep 22, 2021 at 08:49:50AM -0700, Nathan Chancellor wrote: > On Wed, Sep 22, 2021 at 10:41:56AM +0200, Maxime Ripard wrote: > > Hi Randy, > > > > On Sun, Sep 19, 2021 at 09:40:44AM -0700, Randy Dunlap wrote: > > > On 8/19/21 6:59 AM, Maxime Ripard wrote: > > > > We already

Re: [PATCH] drm/ttm: Don't delete the system manager before the delayed delete

2021-09-23 Thread Christian König
Am 23.09.21 um 15:53 schrieb Zack Rusin: On 9/20/21 10:59 AM, Zack Rusin wrote: On Sep 20, 2021, at 02:30, Christian König wrote: Am 17.09.21 um 19:53 schrieb Zack Rusin: On some hardware, in particular in virtualized environments, the system memory can be shared with the "hardware". In

Re: [Intel-gfx] [PATCH v6 3/9] drm/i915/gt: Increase suspend timeout

2021-09-23 Thread Tvrtko Ursulin
On 23/09/2021 14:19, Thomas Hellström wrote: On 9/23/21 2:59 PM, Tvrtko Ursulin wrote: On 23/09/2021 12:47, Thomas Hellström wrote: Hi, Tvrtko, On 9/23/21 12:13 PM, Tvrtko Ursulin wrote: On 22/09/2021 07:25, Thomas Hellström wrote: With GuC submission on DG1, the execution of the

Re: [PATCH] drm/ttm: Don't delete the system manager before the delayed delete

2021-09-23 Thread Zack Rusin
On 9/20/21 10:59 AM, Zack Rusin wrote: On Sep 20, 2021, at 02:30, Christian König wrote: Am 17.09.21 um 19:53 schrieb Zack Rusin: On some hardware, in particular in virtualized environments, the system memory can be shared with the "hardware". In those cases the BO's allocated through the ttm

Re: [PATCH RESEND] drm/i915: Flush buffer pools on driver remove

2021-09-23 Thread Matt Roper
On Thu, Sep 23, 2021 at 03:07:06PM +0200, Janusz Krzysztofik wrote: > Hi Matt, > > Thanks for review. > > On czwartek, 23 września 2021 00:24:29 CEST Matt Roper wrote: > > On Fri, Sep 03, 2021 at 04:23:20PM +0200, Janusz Krzysztofik wrote: > > > In preparation for clean driver release, attempts

Re: [PATCH v2] backlight: propagate errors from get_brightness()

2021-09-23 Thread Lee Jones
On Thu, 23 Sep 2021, Thomas Weißschuh wrote: > On 2021-09-23T10:48+0100, Lee Jones wrote: > > On Tue, 07 Sep 2021, Thomas Weißschuh wrote: > > > > > backlight.h documents "struct backlight_ops->get_brightness()" to return > > > a negative errno on failure. > > > So far these errors have not been

Re: [RFC PATCH v3 1/6] drm/doc: Color Management and HDR10 RFC

2021-09-23 Thread Harry Wentland
On 2021-09-23 04:01, Pekka Paalanen wrote: > On Wed, 22 Sep 2021 11:06:53 -0400 > Harry Wentland wrote: > >> On 2021-09-20 20:14, Harry Wentland wrote: >>> On 2021-09-15 10:01, Pekka Paalanen wrote:> On Fri, 30 Jul 2021 16:41:29 >>> -0400 Harry Wentland wrote: >> >> >> >

Re: Multiple DRI card detection in compositor systemd units

2021-09-23 Thread Pekka Paalanen
On Wed, 22 Sep 2021 16:16:48 + "Hoosier, Matt" wrote: > > The /dev/dri/by-path idea works, I suppose, if you have different > physical graphics cards. In my case, that's not true. These are > virtualized cards that the silicon vendor's DRM drivers use to expose > different subsets of DRM

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-23 Thread Paul Cercueil
Hi Nikolaus, Le jeu., sept. 23 2021 at 13:41:28 +0200, H. Nikolaus Schaller a écrit : Hi Laurent, Am 23.09.2021 um 12:03 schrieb Laurent Pinchart : Hi Nikolaus, On Thu, Sep 23, 2021 at 11:55:56AM +0200, H. Nikolaus Schaller wrote: Am 23.09.2021 um 11:27 schrieb Laurent Pinchart:

Re: [Intel-gfx] [PATCH v6 3/9] drm/i915/gt: Increase suspend timeout

2021-09-23 Thread Thomas Hellström
On 9/23/21 2:59 PM, Tvrtko Ursulin wrote: On 23/09/2021 12:47, Thomas Hellström wrote: Hi, Tvrtko, On 9/23/21 12:13 PM, Tvrtko Ursulin wrote: On 22/09/2021 07:25, Thomas Hellström wrote: With GuC submission on DG1, the execution of the requests times out for the gem_exec_suspend igt test

Re: [PATCH RESEND] drm/i915: Flush buffer pools on driver remove

2021-09-23 Thread Janusz Krzysztofik
Hi Matt, Thanks for review. On czwartek, 23 września 2021 00:24:29 CEST Matt Roper wrote: > On Fri, Sep 03, 2021 at 04:23:20PM +0200, Janusz Krzysztofik wrote: > > In preparation for clean driver release, attempts to drain work queues > > and release freed objects are taken at driver remove

[PATCH v3.1] dt-bindings: display: renesas, du: Provide bindings for r8a779a0

2021-09-23 Thread Kieran Bingham
From: Kieran Bingham Extend the Renesas DU display bindings to support the r8a779a0 V3U. Reviewed-by: Laurent Pinchart Reviewed-by: Geert Uytterhoeven Signed-off-by: Kieran Bingham --- v2: - Collected Laurent's tag - Remove clock-names requirement - Specify only a single clock v3: -

Re: [Intel-gfx] [PATCH v6 3/9] drm/i915/gt: Increase suspend timeout

2021-09-23 Thread Tvrtko Ursulin
On 23/09/2021 12:47, Thomas Hellström wrote: Hi, Tvrtko, On 9/23/21 12:13 PM, Tvrtko Ursulin wrote: On 22/09/2021 07:25, Thomas Hellström wrote: With GuC submission on DG1, the execution of the requests times out for the gem_exec_suspend igt test case after executing around 800-900 of 1000

Re: [PATCH] drm/amd/display: Fix randomly flicking on overlay with enabled ABM

2021-09-23 Thread Alex Deucher
On Thu, Sep 23, 2021 at 5:03 AM wrote: > > From: "Yipeng Chen (Jasber)" > > [Why] > Enabled ABM (level != 0) would raise short pluse irq DC_IRQ_SOURCE_HPD1RX > randomly with PSR error LINK_CRC_ERROR. Actually there is no hot plugging > on EDP panel. After correcting CRC error, there is no need

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-23 Thread H. Nikolaus Schaller
Hi Laurent, > IMHO it is leaving (mature) dw-hdmi untouched and make attachment of a > connector > in ingenic_drm_bind() depend on some condition. Since I don't know details of the DRM bridge/encoder/connector APIs), let me reformulate the quersion for a condition specifically. How can one

Re: [Intel-gfx] [PATCH v6 3/9] drm/i915/gt: Increase suspend timeout

2021-09-23 Thread Thomas Hellström
Hi, Tvrtko, On 9/23/21 12:13 PM, Tvrtko Ursulin wrote: On 22/09/2021 07:25, Thomas Hellström wrote: With GuC submission on DG1, the execution of the requests times out for the gem_exec_suspend igt test case after executing around 800-900 of 1000 submitted requests. Given the time we allow

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-23 Thread H. Nikolaus Schaller
Hi Laurent, > Am 23.09.2021 um 12:03 schrieb Laurent Pinchart > : > > Hi Nikolaus, > > On Thu, Sep 23, 2021 at 11:55:56AM +0200, H. Nikolaus Schaller wrote: >>> Am 23.09.2021 um 11:27 schrieb Laurent Pinchart: >>> On Thu, Sep 23, 2021 at 11:19:23AM +0200, H. Nikolaus Schaller wrote:

[PULL] drm-intel-fixes

2021-09-23 Thread Jani Nikula
Hi Dave & Daniel - drm-intel-fixes-2021-09-23: drm/i915 fixes for v5.15-rc3: - Fix ADL-P memory bandwidth parameters - Fix memory corruption due to a double free - Fix memory leak in DMC firmware handling BR, Jani. The following changes since commit e4e737bb5c170df6135a127739a9e6148ee3da82:

Re: [PATCH v2] backlight: propagate errors from get_brightness()

2021-09-23 Thread Thomas Weißschuh
On 2021-09-23T10:48+0100, Lee Jones wrote: > On Tue, 07 Sep 2021, Thomas Weißschuh wrote: > > > backlight.h documents "struct backlight_ops->get_brightness()" to return > > a negative errno on failure. > > So far these errors have not been handled in the backlight core. > > This leads to negative

Re: [Intel-gfx] [PATCH v6 3/9] drm/i915/gt: Increase suspend timeout

2021-09-23 Thread Tvrtko Ursulin
On 22/09/2021 07:25, Thomas Hellström wrote: With GuC submission on DG1, the execution of the requests times out for the gem_exec_suspend igt test case after executing around 800-900 of 1000 submitted requests. Given the time we allow elsewhere for fences to signal (in the order of seconds),

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-23 Thread Laurent Pinchart
Hi Nikolaus, On Thu, Sep 23, 2021 at 11:55:56AM +0200, H. Nikolaus Schaller wrote: > > Am 23.09.2021 um 11:27 schrieb Laurent Pinchart: > > On Thu, Sep 23, 2021 at 11:19:23AM +0200, H. Nikolaus Schaller wrote: > >> > > + ret = drm_bridge_attach(encoder, >bridge, NULL, > > +

Re: [PATCH v6 7/9] drm/i915: Reduce the number of objects subject to memcpy recover

2021-09-23 Thread Thomas Hellström
On 9/23/21 11:44 AM, Matthew Auld wrote: On 22/09/2021 07:25, Thomas Hellström wrote: We really only need memcpy restore for objects that affect the operability of the migrate context. That is, primarily the page-table objects of the migrate VM. Add an object flag, I915_BO_ALLOC_PM_EARLY for

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-23 Thread H. Nikolaus Schaller
Hi Laurent, > Am 23.09.2021 um 11:27 schrieb Laurent Pinchart > : > > Hi Nikolaus, > > On Thu, Sep 23, 2021 at 11:19:23AM +0200, H. Nikolaus Schaller wrote: >> > + ret = drm_bridge_attach(encoder, >bridge, NULL, > +

Re: [PATCH v2] backlight: propagate errors from get_brightness()

2021-09-23 Thread Lee Jones
On Tue, 07 Sep 2021, Thomas Weißschuh wrote: > backlight.h documents "struct backlight_ops->get_brightness()" to return > a negative errno on failure. > So far these errors have not been handled in the backlight core. > This leads to negative values being exposed through sysfs although only >

Re: [PATCH v6 7/9] drm/i915: Reduce the number of objects subject to memcpy recover

2021-09-23 Thread Matthew Auld
On 22/09/2021 07:25, Thomas Hellström wrote: We really only need memcpy restore for objects that affect the operability of the migrate context. That is, primarily the page-table objects of the migrate VM. Add an object flag, I915_BO_ALLOC_PM_EARLY for objects that need early restores using

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-23 Thread Laurent Pinchart
Hi Nikolaus, On Thu, Sep 23, 2021 at 11:19:23AM +0200, H. Nikolaus Schaller wrote: > > Am 23.09.2021 um 10:49 schrieb Paul Cercueil: > > Le jeu., sept. 23 2021 at 07:52:08 +0200, H. Nikolaus Schaller a écrit : > >> Hi Paul, > >> thanks for another update. > >> We have been delayed to rework the

Re: [PATCH v6 0/2] Add p2p via dmabuf to habanalabs

2021-09-23 Thread Oded Gabbay
On Sat, Sep 18, 2021 at 11:38 AM Oded Gabbay wrote: > > On Fri, Sep 17, 2021 at 3:30 PM Daniel Vetter wrote: > > > > On Thu, Sep 16, 2021 at 10:10:14AM -0300, Jason Gunthorpe wrote: > > > On Thu, Sep 16, 2021 at 02:31:34PM +0200, Daniel Vetter wrote: > > > > On Wed, Sep 15, 2021 at 10:45:36AM

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-23 Thread Laurent Pinchart
Hello, On Thu, Sep 23, 2021 at 09:49:03AM +0100, Paul Cercueil wrote: > Le jeu., sept. 23 2021 at 07:52:08 +0200, H. Nikolaus Schaller a écrit : > > Hi Paul, > > thanks for another update. > > > > We have been delayed to rework the CI20 HDMI code on top of your series > > but it basically works

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-23 Thread H. Nikolaus Schaller
Hi Paul, > Am 23.09.2021 um 10:49 schrieb Paul Cercueil : > > Hi Nikolaus, > > Le jeu., sept. 23 2021 at 07:52:08 +0200, H. Nikolaus Schaller > a écrit : >> Hi Paul, >> thanks for another update. >> We have been delayed to rework the CI20 HDMI code on top of your series >> but it basically

Re: [PATCH v6 3/9] drm/i915/gt: Increase suspend timeout

2021-09-23 Thread Matthew Auld
On 22/09/2021 07:25, Thomas Hellström wrote: With GuC submission on DG1, the execution of the requests times out for the gem_exec_suspend igt test case after executing around 800-900 of 1000 submitted requests. Given the time we allow elsewhere for fences to signal (in the order of seconds),

[PATCH] drm/amd/display: Fix randomly flicking on overlay with enabled ABM

2021-09-23 Thread yipeng.chen
From: "Yipeng Chen (Jasber)" [Why] Enabled ABM (level != 0) would raise short pluse irq DC_IRQ_SOURCE_HPD1RX randomly with PSR error LINK_CRC_ERROR. Actually there is no hot plugging on EDP panel. After correcting CRC error, there is no need to send drm hotplug event. [How] Returning false

Re: Handling DRM master transitions cooperatively

2021-09-23 Thread Hans de Goede
Hi, On 9/23/21 10:23 AM, Pekka Paalanen wrote: > On Wed, 22 Sep 2021 11:21:16 +0200 > Hans de Goede wrote: > >> Hi, >> >> On 9/22/21 10:56 AM, Pekka Paalanen wrote: >>> On Tue, 14 Sep 2021 15:45:21 +0200 >>> Daniel Vetter wrote: >>> On Thu, Sep 09, 2021 at 10:37:03AM +0300, Pekka

Re: [PATCH v3 6/6] drm/ingenic: Attach bridge chain to encoders

2021-09-23 Thread Paul Cercueil
Hi Nikolaus, Le jeu., sept. 23 2021 at 07:52:08 +0200, H. Nikolaus Schaller a écrit : Hi Paul, thanks for another update. We have been delayed to rework the CI20 HDMI code on top of your series but it basically works in some situations. There is for example a problem if the EDID reports

Re: [PATCH v2 3/3] drm/bridge: ti-sn65dsi86: Add NO_CONNECTOR support

2021-09-23 Thread Maxime Ripard
Hi, On Tue, Sep 21, 2021 at 03:42:05PM -0700, Rob Clark wrote: > On Tue, Sep 21, 2021 at 3:20 PM Doug Anderson wrote: > > > > Hi, > > > > On Mon, Sep 20, 2021 at 3:53 PM Rob Clark wrote: > > > > > > From: Rob Clark > > > > > > Slightly awkward to fish out the display_info when we aren't

Re: Handling DRM master transitions cooperatively

2021-09-23 Thread Pekka Paalanen
On Wed, 22 Sep 2021 11:21:16 +0200 Hans de Goede wrote: > Hi, > > On 9/22/21 10:56 AM, Pekka Paalanen wrote: > > On Tue, 14 Sep 2021 15:45:21 +0200 > > Daniel Vetter wrote: > > > >> On Thu, Sep 09, 2021 at 10:37:03AM +0300, Pekka Paalanen wrote: > >>> On Wed, 8 Sep 2021 18:27:09 +0200 >

Re: [PATCH v4 24/24] drm/exynos: dsi: Adjust probe order

2021-09-23 Thread Marek Szyprowski
Hi Maxime, On 22.09.2021 10:53, Maxime Ripard wrote: > On Fri, Sep 17, 2021 at 02:35:05PM +0200, Marek Szyprowski wrote: >> On 13.09.2021 12:30, Andrzej Hajda wrote: >>> W dniu 10.09.2021 o 12:12, Maxime Ripard pisze: Without proper care and an agreement between how DSI hosts and devices

Re: [RFC PATCH v3 1/6] drm/doc: Color Management and HDR10 RFC

2021-09-23 Thread Pekka Paalanen
On Wed, 22 Sep 2021 11:06:53 -0400 Harry Wentland wrote: > On 2021-09-20 20:14, Harry Wentland wrote: > > On 2021-09-15 10:01, Pekka Paalanen wrote:> On Fri, 30 Jul 2021 16:41:29 > > -0400 > >> Harry Wentland wrote: > >> > > > > >>> +If a display's maximum HDR white level is correctly

Re: [PATCH v8 10/16] i915/gvt: remove spaces in pr_debug "gvt: core:" etc prefixes

2021-09-23 Thread Zhenyu Wang
On 2021.09.15 10:39:51 -0600, Jim Cromie wrote: > Taking embedded spaces out of existing prefixes makes them better > class-prefixes; simplifying the extra quoting needed otherwise: > > $> echo format "^gvt: core:" +p >control > > Dropping the internal spaces means any trailing space in a

[PULL] drm-misc-next

2021-09-23 Thread Maxime Ripard
Hi Dave, Daniel, Here's this week PR for drm-misc-next Maxime drm-misc-next-2021-09-23: drm-misc-next for 5.15: UAPI Changes: Cross-subsystem Changes: Core Changes: Driver Changes: - Conversions to dev_err_probe() helper - rockchip: Various build improvements, Use

Re: [RFC PATCH v3 1/6] drm/doc: Color Management and HDR10 RFC

2021-09-23 Thread Pekka Paalanen
On Wed, 22 Sep 2021 11:28:37 -0400 Harry Wentland wrote: > On 2021-09-22 04:31, Pekka Paalanen wrote: > > On Tue, 21 Sep 2021 14:05:05 -0400 > > Harry Wentland wrote: > > > >> On 2021-09-21 09:31, Pekka Paalanen wrote: > >>> On Mon, 20 Sep 2021 20:14:50 -0400 > >>> Harry Wentland wrote: >

Re: [PATCH v3 1/6] dt-bindings: display: renesas, du: Provide bindings for r8a779a0

2021-09-23 Thread Geert Uytterhoeven
Hi Kieran, On Thu, Sep 23, 2021 at 1:47 AM Kieran Bingham wrote: > From: Kieran Bingham > > Extend the Renesas DU display bindings to support the r8a779a0 V3U. > > Reviewed-by: Laurent Pinchart > Signed-off-by: Kieran Bingham > > --- > v2: > - Collected Laurent's tag > - Remove clock-names

Re: [PATCH] drm/i915/uncore: fwtable read handlers are now used on all forcewake platforms

2021-09-23 Thread Tvrtko Ursulin
On 23/09/2021 01:30, Matt Roper wrote: With the recent refactor of the uncore mmio handling, all forcewake-based platforms (i.e., graphics version 6 and beyond) now use the 'fwtable' read handlers. Let's pull the assignment out of the per-platform if/else ladder to make this more obvious.

[PATCH v12 00/17] drm/i915: Introduce Intel PXP

2021-09-23 Thread Alan Previn
PXP (Protected Xe Path) is an i915 component, available on GEN12 and newer platforms, that helps to establish the hardware protected session and manage the status of the alive software session, as well as its life cycle. changes from v11: - Patch #8: Fix uninitialized variable. - Patch #15:

Re: Multiple DRI card detection in compositor systemd units

2021-09-23 Thread Hoosier, Matt
I get the intuition behind the suggestion to aggregate using logind seats, as far as it goes. But it still seems to me that this just pushes the question back: how do you identify which card is which in order to assign it to a seat? Normally this is done using udev rules, right? Additionally,

Multiple DRI card detection in compositor systemd units

2021-09-23 Thread Hoosier, Matt
I'm trying to find a robust way to handle the phrasing of UDev rules and systemd dependencies about /dev/dri/cardXXX nodes to ensure that several compositor services running on different graphics cards of a device all can reliably start up. First, some basic observations: * The DRM

[PATCH v5 6/8] drm/omap: dynamically assign hw overlays to planes

2021-09-23 Thread Neil Armstrong
From: Benoit Parrot (re)assign the hw overlays to planes based on required caps, and to handle situations where we could not modify an in-use plane. This means all planes advertise the superset of formats and properties. Userspace must (as always) use atomic TEST_ONLY step for atomic updates,

[PATCH v5 7/8] drm/omap: add plane_atomic_print_state support

2021-09-23 Thread Neil Armstrong
From: Benoit Parrot Now that we added specific item to our subclassed drm_plane_state we can add omap_plane_atomic_print_state() helper to dump out our own driver specific plane state. Signed-off-by: Benoit Parrot Signed-off-by: Neil Armstrong --- drivers/gpu/drm/omapdrm/omap_plane.c | 18

[PATCH v5 8/8] drm/omap: Add a 'right overlay' to plane state

2021-09-23 Thread Neil Armstrong
From: Benoit Parrot If the drm_plane has a source width that's greater than the max width supported by a single hw overlay, then we assign a 'r_overlay' to it in omap_plane_atomic_check(). Both overlays should have the capabilities required to handle the source framebuffer. The only parameters

[PATCH v5 5/8] drm/omap: Add global state as a private atomic object

2021-09-23 Thread Neil Armstrong
From: Benoit Parrot Global shared resources (like hw overlays) for omapdrm are implemented as a part of atomic state using the drm_private_obj infrastructure available in the atomic core. omap_global_state is introduced as a drm atomic private object. The two funcs omap_get_global_state() and

[PATCH v5 4/8] drm/omap: omap_plane: subclass drm_plane_state

2021-09-23 Thread Neil Armstrong
From: Benoit Parrot In preparation to add omap plane state specific extensions we need to subclass drm_plane_state and add the relevant helpers. The addition of specific extension will be done separately. Signed-off-by: Benoit Parrot Signed-off-by: Neil Armstrong ---

[PATCH v5 1/8] drm/omap: Add ability to check if requested plane modes can be supported

2021-09-23 Thread Neil Armstrong
From: Benoit Parrot We currently assume that an overlay has the same maximum width and maximum height as the overlay manager. This assumption is incorrect. On some variants the overlay manager maximum width is twice the maximum width that the overlay can handle. We need to add the appropriate

[PATCH v5 3/8] drm/omap: introduce omap_hw_overlay

2021-09-23 Thread Neil Armstrong
From: Benoit Parrot Split out the hardware overlay specifics from omap_plane. To start, the hw overlays are statically assigned to planes. The goal is to eventually assign hw overlays dynamically to planes during plane->atomic_check() based on requested caps (scaling, YUV, etc). And then

[PATCH v5 2/8] drm/omap: Add ovl checking funcs to dispc_ops

2021-09-23 Thread Neil Armstrong
From: Benoit Parrot In order to be able to dynamically assign overlays to planes we need to be able to asses the overlay capabilities. Add a helper function to be able to retrieve the supported capabilities of an overlay. And export the function to check if a fourcc is supported on a given

[PATCH v5 0/8] drm/omap: Add virtual-planes support

2021-09-23 Thread Neil Armstrong
This patchset is the follow-up the v4 patchset from Benoit Parrot at [1]. This patch series adds virtual-plane support to omapdrm driver to allow the use of display wider than 2048 pixels. In order to do so we introduce the concept of hw_overlay which can then be dynamically allocated to a

Re: [RFC PATCH 2/4] DRM: Add support of AI Processor Unit (APU)

2021-09-23 Thread Christian König
Am 23.09.21 um 02:58 schrieb Dave Airlie: On Sat, 18 Sept 2021 at 07:57, Alexandre Bailon wrote: Some Mediatek SoC provides hardware accelerator for AI / ML. This driver provides the infrastructure to manage memory shared between host CPU and the accelerator, and to submit jobs to the