[PULL] drm-misc-fixes

2021-11-17 Thread Maxime Ripard
Hi Daniel, Dave, Here's this week drm-misc-fixes PR Maxime drm-misc-fixes-2021-11-18: A infoframe corruption fix for nouveau, a wrong free function usage fix for GEM CMA helpers, a Kconfig dependency fix for sun4i, two fixes for drm/scheduler refcounting and a probing fix for efifb. The

[PATCH 07/12] dt-bindings: display: rockchip: Add binding for VOP2

2021-11-17 Thread Sascha Hauer
The VOP2 is found on newer Rockchip SoCs like the rk3568 or the rk3566. The binding differs slightly from the existing VOP binding, so add a new binding file for it. Signed-off-by: Sascha Hauer --- .../display/rockchip/rockchip-vop2.yaml | 114 ++ 1 file changed, 114

[PATCH 09/12] arm64: dts: rockchip: rk356x: Add HDMI nodes

2021-11-17 Thread Sascha Hauer
Add support for the HDMI port found on RK3568. Signed-off-by: Sascha Hauer --- arch/arm64/boot/dts/rockchip/rk356x.dtsi | 65 1 file changed, 65 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi index

Re: [PATCH v1 00/12] drm/rockchip: RK356x VOP2 support

2021-11-17 Thread Kever Yang
Hi Sascha Hauer, On 2021/11/17 下午10:33, Sascha Hauer wrote: This series adds initial graphics support for the Rockchip RK356[68] SoCs. Graphics support is based around the VOP2 controller which replaces the VOP controller found on earlier Rockchip SoCs. The driver has been tested with HDMI

[PATCH 10/12] arm64: dts: rockchip: rk3568-evb: Enable VOP2 and hdmi

2021-11-17 Thread Sascha Hauer
This enabled the VOP2 display controller along with hdmi and the required port routes which is enough to get a picture out of the hdmi port of the board. Signed-off-by: Sascha Hauer --- .../boot/dts/rockchip/rk3568-evb1-v10.dts | 24 +++ 1 file changed, 24 insertions(+)

Re: [PATCH 12/12] drm: rockchip: Add VOP2 driver

2021-11-17 Thread Sascha Hauer
On Wed, Nov 17, 2021 at 07:05:33PM +0100, Nicolas Frattaroli wrote: > On Mittwoch, 17. November 2021 15:33:47 CET Sascha Hauer wrote: > > The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568. > > It replaces the VOP unit found in the older Rockchip SoCs. > > > > This driver has

[PATCH 05/12] of: graph: Allow disabled endpoints

2021-11-17 Thread Sascha Hauer
There are cases in which a SoC allows many different routes between components, but not all of them make sense for a board. With this patch we allow standard status = "disabled" properties for ports. With this a SoC level dtsi file can describe all possible ports and only the ones that make sense

[PATCH 01/12] dt-bindings: display: rockchip: Add compatible for rk3568 HDMI

2021-11-17 Thread Sascha Hauer
From: Benjamin Gaignard Define a new compatible for rk3568 HDMI. This version of HDMI hardware block needs two new clocks hclk_vio and hclk to provide phy reference clocks. Signed-off-by: Benjamin Gaignard Reviewed-by: Rob Herring Link:

Re: [PATCH 11/12] drm/rockchip: Make VOP driver optional

2021-11-17 Thread Sascha Hauer
On Wed, Nov 17, 2021 at 03:40:26PM +0100, Heiko Stübner wrote: > Am Mittwoch, 17. November 2021, 15:33:46 CET schrieb Sascha Hauer: > > With upcoming VOP2 support VOP won't be the only choice anymore, so make > > the VOP driver optional. > > > > Signed-off-by: Sascha Hauer > > --- > >

[PATCH 04/12] drm/rockchip: dw_hdmi: add regulator support

2021-11-17 Thread Sascha Hauer
The RK3568 has HDMI_TX_AVDD0V9 and HDMI_TX_AVDD_1V8 supply inputs needed for the HDMI port. add support for these to the driver for boards which have them supplied by switchable regulators. Signed-off-by: Sascha Hauer --- .../display/rockchip/rockchip,dw-hdmi.yaml| 6 ++

[PATCH 03/12] drm/rockchip: dw_hdmi: add rk3568 support

2021-11-17 Thread Sascha Hauer
From: Benjamin Gaignard Add a new dw_hdmi_plat_data struct and new compatible for rk3568. This version of the HDMI hardware block needs a new clock to provide the phy reference clock: hclk. As this is the third clock the driver uses it is switched to devm_clk_bulk_get_optional() to simplify the

[PATCH 08/12] arm64: dts: rockchip: rk356x: Add VOP2 nodes

2021-11-17 Thread Sascha Hauer
The VOP2 is the display output controller on the RK3568. Add the node for it to the dtsi file along with the required display-subsystem node and the iommu node. Signed-off-by: Sascha Hauer --- arch/arm64/boot/dts/rockchip/rk356x.dtsi | 52 1 file changed, 52

[PATCH 11/12] drm/rockchip: Make VOP driver optional

2021-11-17 Thread Sascha Hauer
With upcoming VOP2 support VOP won't be the only choice anymore, so make the VOP driver optional. Signed-off-by: Sascha Hauer --- arch/arm/configs/multi_v7_defconfig | 1 + arch/arm64/configs/defconfig| 1 + drivers/gpu/drm/rockchip/Kconfig| 7 +++

Re: [PATCH v1 00/12] drm/rockchip: RK356x VOP2 support

2021-11-17 Thread Sascha Hauer
On Wed, Nov 17, 2021 at 08:54:37AM -0600, Rob Herring wrote: > On Wed, Nov 17, 2021 at 8:34 AM Sascha Hauer wrote: > > > > This series adds initial graphics support for the Rockchip RK356[68] > > SoCs. Graphics support is based around the VOP2 controller which > > replaces the VOP controller

[PATCH 02/12] drm/rockchip: dw_hdmi: Do not leave clock enabled in error case

2021-11-17 Thread Sascha Hauer
The driver returns an error when devm_phy_optional_get() fails leaving the previously enabled clock turned on. Change order and enable the clock only after the phy has been acquired. Signed-off-by: Sascha Hauer --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 14 +++--- 1 file changed,

RE: [PATCH 00/15] iio: buffer-dma: write() and new DMABUF based API

2021-11-17 Thread Hennerich, Michael
> -Original Message- > From: Paul Cercueil > Sent: Mittwoch, 17. November 2021 13:50 > To: Daniel Vetter > Cc: Jonathan Cameron ; Hennerich, Michael > ; linux-...@vger.kernel.org; linux- > ker...@vger.kernel.org; dri-devel@lists.freedesktop.org; Christian König > ;

[PATCH v1 00/12] drm/rockchip: RK356x VOP2 support

2021-11-17 Thread Sascha Hauer
This series adds initial graphics support for the Rockchip RK356[68] SoCs. Graphics support is based around the VOP2 controller which replaces the VOP controller found on earlier Rockchip SoCs. The driver has been tested with HDMI support included in this series and MIPI-DSI which is not included

[PATCH 06/12] dt-bindings: of: graph: Allow disabled endpoints

2021-11-17 Thread Sascha Hauer
There are cases in which a SoC allows many different routes between components, but not all of them make sense for a board. With this patch we allow standard status = "disabled" properties for ports. With this a SoC level dtsi file can describe all possible ports and only the ones that make sense

Re: [PATCH v1 1/9] mm: add zone device coherent type memory support

2021-11-17 Thread Alistair Popple
On Tuesday, 16 November 2021 6:30:18 AM AEDT Alex Sierra wrote: > Device memory that is cache coherent from device and CPU point of view. > This is used on platforms that have an advanced system bus (like CAPI > or CXL). Any page of a process can be migrated to such memory. However, > no one

Re: [PATCH v1 6/9] lib: test_hmm add module param for zone device type

2021-11-17 Thread Alistair Popple
On Tuesday, 16 November 2021 6:30:23 AM AEDT Alex Sierra wrote: > In order to configure device coherent in test_hmm, two module parameters > should be passed, which correspond to the SP start address of each > device (2) spm_addr_dev0 & spm_addr_dev1. If no parameters are passed, > private device

Re: [PATCH v3 5/6] drm/i915/ttm: Implement asynchronous TTM moves

2021-11-17 Thread Thomas Hellström
Hi, Matthew Finally got some time to look at this more in-depth, please see below. On Mon, 2021-11-15 at 17:16 +, Matthew Auld wrote: > On 14/11/2021 11:12, Thomas Hellström wrote: > > Don't wait sync while migrating, but rather make the GPU blit await > > the > > dependencies and add a

Re: [PATCH] drm/scheduler: fix drm_sched_job_add_implicit_dependencies harder

2021-11-17 Thread Christian König
Am 18.11.21 um 04:09 schrieb Rob Clark: On Wed, Nov 17, 2021 at 5:23 PM Steev Klimaszewski wrote: On 11/17/21 1:27 AM, Christian König wrote: Am 16.11.21 um 19:30 schrieb Amit Pundir: On Tue, 16 Nov 2021 at 21:21, Rob Clark wrote: From: Rob Clark drm_sched_job_add_dependency() could

Re: [PATCH v2 1/6] drm/i915: move the pre_pin earlier

2021-11-17 Thread Thomas Hellström
On Wed, 2021-11-17 at 19:49 +0100, Thomas Hellström wrote: > > On 11/17/21 15:20, Matthew Auld wrote: > > In intel_context_do_pin_ww, when calling into the pre_pin > > hook(which is > > passed the ww context) it could in theory return -EDEADLK(which is > > very > > likely with debug kernels),

Re: [PATCH v1 2/9] mm: add device coherent vma selection for memory migration

2021-11-17 Thread Alistair Popple
On Tuesday, 16 November 2021 6:30:19 AM AEDT Alex Sierra wrote: > This case is used to migrate pages from device memory, back to system > memory. Device coherent type memory is cache coherent from device and CPU > point of view. > > Signed-off-by: Alex Sierra > --- > v2: > condition added when

[Bug 214991] VC4 DRM waiting for flip down makes UI freeze a while with kernel 5.15

2021-11-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214991 --- Comment #2 from Jian-Hong Pan (j...@endlessos.org) --- Created attachment 299625 --> https://bugzilla.kernel.org/attachment.cgi?id=299625=edit Full dmesg log with the v2 patch series "drm/vc4: kms: Misc fixes for HVS commits" Maxime sent

Re: [PATCH v2 0/6] drm/vc4: kms: Misc fixes for HVS commits

2021-11-17 Thread Jian-Hong Pan
Maxime Ripard 於 2021年11月17日 週三 下午5:45寫道: > > Hi, > > The conversion to DRM commit helpers (f3c420fe19f8, "drm/vc4: kms: Convert to > atomic helpers") introduced a number of issues in corner cases, most of them > showing themselves in the form of either a vblank timeout or use-after-free > error.

[PATCH v3] drm/bridge: anx7625: Check GPIO description to avoid crash

2021-11-17 Thread Xin Ji
As GPIO probe function "devm_gpiod_get_optional()" may return error code, driver should identify GPIO desc as NULL to avoid crash. Acked-by: Tzung-Bi Shih Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 9 + 1 file changed, 9 insertions(+) diff --git

[PATCH v2] drm/bridge: anx7625: Check GPIO description to avoid crash

2021-11-17 Thread Xin Ji
As GPIO probe function "devm_gpiod_get_optional()" may return error code, driver should identify GPIO desc as NULL to avoid crash. Acked-by: Tzung-Bi Shih Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 9 + 1 file changed, 9 insertions(+) diff --git

Re: [PATCH] drm/bridge: anx7625: Check GPIO description to avoid crash

2021-11-17 Thread Xin Ji
On Thu, Nov 18, 2021 at 12:52:14PM +0800, Tzung-Bi Shih wrote: > On Thu, Nov 18, 2021 at 11:11 AM Xin Ji wrote: > > @@ -1098,9 +1098,18 @@ static void anx7625_init_gpio(struct anx7625_data > > *platform) > > /* Gpio for chip power enable */ > > platform->pdata.gpio_p_on = > >

[pull] amdgpu, amdkfd drm-fixes-5.16

2021-11-17 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.16. The following changes since commit fa55b7dcdc43c1aa1ba12bca9d2dd4318c2a0dbf: Linux 5.16-rc1 (2021-11-14 13:56:52 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-5.16-2021-11-17 for you to

[PATCH 2/2] drm/amdkfd: Implement DMA buf fd export for RDMA

2021-11-17 Thread Felix Kuehling
Exports a DMA buf fd of a given KFD buffer handle. This is intended for the new upstreamable RDMA solution coming to UCX and libfabric. The corresponding user mode change (Thunk API and kfdtest) is here: https://github.com/RadeonOpenCompute/ROCT-Thunk-Interface/commits/fxkamd/dmabuf

[PATCH 1/2] drm/amdgpu: Generalize KFD dmabuf import

2021-11-17 Thread Felix Kuehling
Use proper amdgpu_gem_prime_import function to handle all kinds of imports. Remember the dmabuf reference to enable proper multi-GPU attachment to multiple VMs without erroneously re-exporting the underlying BO multiple times. Signed-off-by: Felix Kuehling ---

Re: [PATCH] drm: change logs to print connectors in the form CONNECTOR:id:name

2021-11-17 Thread jim . cromie
On Mon, Nov 15, 2021 at 12:40 PM Claudio Suarez wrote: > > On Mon, Nov 15, 2021 at 12:24:26PM +0200, Jani Nikula wrote: > > On Sun, 14 Nov 2021, Claudio Suarez wrote: > > > On Sat, Nov 13, 2021 at 09:39:46PM +0100, Sam Ravnborg wrote: > > >> Hi Claudio, > > >> > > >> On Sat, Nov 13, 2021 at

[PATCH] drm/bridge: anx7625: Check GPIO description to avoid crash

2021-11-17 Thread Xin Ji
As GPIO probe function "devm_gpiod_get_optional()" may return error code, driver should identify GPIO desc as NULL to avoid crash. Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 9 + 1 file changed, 9 insertions(+) diff --git

Re: [PATCH] drm/scheduler: fix drm_sched_job_add_implicit_dependencies harder

2021-11-17 Thread Rob Clark
On Wed, Nov 17, 2021 at 5:23 PM Steev Klimaszewski wrote: > > > On 11/17/21 1:27 AM, Christian König wrote: > > Am 16.11.21 um 19:30 schrieb Amit Pundir: > >> On Tue, 16 Nov 2021 at 21:21, Rob Clark wrote: > >>> From: Rob Clark > >>> > >>> drm_sched_job_add_dependency() could drop the last ref,

Re: [bug report] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP

2021-11-17 Thread Xin Ji
On Wed, Nov 17, 2021 at 04:47:20PM +0300, Dan Carpenter wrote: > Hello Xin Ji, > > The patch 8bdfc5dae4e3: "drm/bridge: anx7625: Add anx7625 MIPI > DSI/DPI to DP" from Sep 18, 2020, leads to the following Smatch > static checker warning: > > drivers/gpu/drm/bridge/analogix/anx7625.c:1050

[PATCH] drm/kmb: fix potential memleak in error branch

2021-11-17 Thread Bernard Zhao
This patch try to fix coccicheck warning: ./drivers/gpu/drm/kmb/kmb_drv.c:519:2-8: ERROR: missing put_device; call of_find_device_by_node on line 506, but without a corresponding object release within this function. ./drivers/gpu/drm/kmb/kmb_drv.c:522:2-8: ERROR: missing put_device; call

RPI 7" display touch controller

2021-11-17 Thread Tim Harvey
Greetings, I'm trying to get a RPI 7" touchscreen display working on an IMX8MM board and while I've been able to get the MIPI DSI display and backlight working I still can't seem to figure out the touch controller. It's supposed to have an FT5406 controller on it without an interrupt so I added

Re: [PATCH] drm/scheduler: fix drm_sched_job_add_implicit_dependencies harder

2021-11-17 Thread Steev Klimaszewski
On 11/17/21 1:27 AM, Christian König wrote: Am 16.11.21 um 19:30 schrieb Amit Pundir: On Tue, 16 Nov 2021 at 21:21, Rob Clark wrote: From: Rob Clark drm_sched_job_add_dependency() could drop the last ref, so we need to do the dma_fence_get() first. It fixed the splats I saw on RB5

Re: [PATCH v6 0/5] CMDQ refinement of Mediatek DRM driver

2021-11-17 Thread Chun-Kuang Hu
Hi, Jason: For this series except [v6,3/6] drm/mediatek: Detect CMDQ execution timeout (I pick v5), applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. jason-jh.lin 於 2021年10月28日 週四

Re: [PATCH v5 3/6] drm/mediatek: Detect CMDQ execution timeout

2021-11-17 Thread Chun-Kuang Hu
Hi, Fei: Fei Shao 於 2021年10月28日 週四 上午11:19寫道: > > Hi Chun-Kuang, > > On Thu, Oct 28, 2021 at 7:47 AM Chun-Kuang Hu wrote: > > > > Hi, Fei: > > > > Fei Shao 於 2021年10月27日 週三 下午5:32寫道: > > > > > > Hi Jason, > > > > > > On Wed, Oct 27, 2021 at 10:19 AM jason-jh.lin > > > wrote: > > > > > > > >

[PATCH 3/3] drm/i915/gt: Improve "race-to-idle" at low frequencies

2021-11-17 Thread Vinay Belgaumkar
From: Chris Wilson While the power consumption is proportional to the frequency, there is also a static draw for active gates. The longer we are able to powergate (rc6), the lower the static draw. Thus there is a sweetspot in the frequency/power curve where we run at higher frequency in order to

[PATCH 2/3] drm/i915/gt: Compare average group occupancy for RPS evaluation

2021-11-17 Thread Vinay Belgaumkar
From: Chris Wilson Currently, we inspect each engine individually and measure the occupancy of that engine over the last evaluation interval. If that exceeds our busyness thresholds, we decide to increase the GPU frequency. However, under a load balancer, we should consider the occupancy of

[PATCH 1/3] drm/i915/gt: Spread virtual engines over idle engines

2021-11-17 Thread Vinay Belgaumkar
From: Chris Wilson Everytime we come to the end of a virtual engine's context, re-randomise it's siblings[]. As we schedule the siblings' tasklets in the order they are in the array, earlier entries are executed first (when idle) and so will be preferred when scheduling the next virtual request.

[PATCH 0/3] drm/i915/gt: RPS tuning for light media playback

2021-11-17 Thread Vinay Belgaumkar
Switch from tgl to adl, sees one particular media decode pipeline fit into a single vcs engine on adl, whereas it took two on tgl. However, it was observed that the power consumtpion for adl remained higher than for tgl. One contibution is that each engine is treated individually for rps

[PATCH v2 1/2] drm/input_helper: Add new input-handling helper

2021-11-17 Thread Brian Norris
A variety of applications have found it useful to listen to user-initiated input events to make decisions within a DRM driver, given that input events are often the first sign that we're going to start doing latency-sensitive activities: * Panel self-refresh: software-directed self-refresh

[PATCH v2 2/2] drm/self_refresh: Disable self-refresh on input events

2021-11-17 Thread Brian Norris
To improve panel self-refresh exit latency, we speculatively start exiting when we receive input events. Occasionally, this may lead to false positives, but most of the time we get a head start on coming out of PSR. Depending on how userspace takes to produce a new frame in response to the event,

[PATCH v2 0/2] drm: Support input-boosted panel self-refresh exit

2021-11-17 Thread Brian Norris
A variety of applications have found it useful to listen to user-initiated input events to make decisions within a DRM driver, given that input events are often the first sign that we're going to start doing latency-sensitive activities: * Panel self-refresh: software-directed self-refresh

Re: [PATCH -next] drm/amd/display: check top_pipe_to_program pointer

2021-11-17 Thread Alex Deucher
Applied. Thanks! On Mon, Nov 15, 2021 at 3:10 AM Yang Li wrote: > > Clang static analysis reports this error > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:2870:7: warning: > Dereference of null pointer [clang-analyzer-core.NullDereference] > if >

Re: [PATCH] drm/amd/display: remove no need NULL check before kfree

2021-11-17 Thread Alex Deucher
Applied. Thanks! On Mon, Nov 15, 2021 at 8:48 PM Bernard Zhao wrote: > > This change is to cleanup the code a bit. > > Signed-off-by: Bernard Zhao > --- > .../drm/amd/display/dc/dcn10/dcn10_resource.c | 18 ++ > 1 file changed, 6 insertions(+), 12 deletions(-) > > diff --git

Re: [PATCH] drm/amd/display: cleanup the code a bit

2021-11-17 Thread Alex Deucher
Applied. Thanks! On Tue, Nov 16, 2021 at 4:19 AM Christian König wrote: > > Am 16.11.21 um 02:34 schrieb Bernard Zhao: > > In function dc_sink_destruct, kfree will check pointer, no need > > to check again. > > This change is to cleanup the code a bit. > > > > Signed-off-by: Bernard Zhao > >

Re: [PATCH] drm/amd/amdgpu: fix potential memleak

2021-11-17 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Nov 15, 2021 at 10:56 AM Felix Kuehling wrote: > > Am 2021-11-14 um 9:58 p.m. schrieb Bernard Zhao: > > In function amdgpu_get_xgmi_hive, when kobject_init_and_add failed > > There is a potential memleak if not call kobject_put. > > > > Signed-off-by: Bernard Zhao

Re: [PATCH v2] drm/amd/amdgpu: cleanup the code style a bit

2021-11-17 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Nov 15, 2021 at 7:09 AM Bernard Zhao wrote: > > This change is to cleanup the code style a bit. > > Signed-off-by: Bernard Zhao > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 21 + > 1 file changed, 13 insertions(+), 8 deletions(-) > >

Re: [PATCH] drm/amd/amdgpu: remove useless break after return

2021-11-17 Thread Alex Deucher
Applied thanks. If you want to make the numbering more sequential, please also update the other dce files if you make that change. Alex On Mon, Nov 15, 2021 at 2:14 AM Bernard Zhao wrote: > > This change is to remove useless break after return. > > Signed-off-by: Bernard Zhao > --- >

Re: [PATCH v3 1/6] drm: move the buddy allocator from i915 into common drm

2021-11-17 Thread kernel test robot
Hi Arunpravin, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm/drm-next] [also build test ERROR on drm-intel/for-linux-next v5.16-rc1] [cannot apply to drm-tip/drm-tip next-2027] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH] drm/panel-edp: modify Kconfig to prevent build error

2021-11-17 Thread Randy Dunlap
On 11/16/21 11:58 PM, Arnd Bergmann wrote: On Wed, Nov 17, 2021 at 7:27 AM Randy Dunlap wrote: When CONFIG_DRM_KMS_HELPER=m and CONFIG_DRM_PANEL_EDP=y, there is a build error in gpu/drm/panel/panel-edp.o: arm-linux-gnueabi-ld: drivers/gpu/drm/panel/panel-edp.o: in function

Re: [PATCH v3 4/6] drm: implement a method to free unused pages

2021-11-17 Thread Matthew Auld
On 16/11/2021 20:18, Arunpravin wrote: On contiguous allocation, we round up the size to the *next* power of 2, implement a function to free the unused pages after the newly allocate block. v2(Matthew Auld): - replace function name 'drm_buddy_free_unused_pages' with drm_buddy_block_trim

Re: [Intel-gfx] [PATCH v3 5/5] drm/i915/dg2: extend Wa_1409120013 to DG2

2021-11-17 Thread Ville Syrjälä
On Wed, Nov 17, 2021 at 10:51:39AM -0800, Matt Roper wrote: > On Wed, Nov 17, 2021 at 08:43:19PM +0200, Ville Syrjälä wrote: > > On Tue, Nov 16, 2021 at 09:48:18AM -0800, Matt Roper wrote: > > > From: Matt Atwood > > > > > > Extend existing workaround 1409120013 to DG2. > > > > I don't see this

Re: [Intel-gfx] [PATCH v3 5/5] drm/i915/dg2: extend Wa_1409120013 to DG2

2021-11-17 Thread Ville Syrjälä
On Wed, Nov 17, 2021 at 08:43:19PM +0200, Ville Syrjälä wrote: > On Tue, Nov 16, 2021 at 09:48:18AM -0800, Matt Roper wrote: > > From: Matt Atwood > > > > Extend existing workaround 1409120013 to DG2. > > I don't see this listed for DG2. > > > > > Cc: José Roberto de Souza > > Signed-off-by:

Re: [Intel-gfx] [PATCH v3 5/5] drm/i915/dg2: extend Wa_1409120013 to DG2

2021-11-17 Thread Matt Roper
On Wed, Nov 17, 2021 at 08:43:19PM +0200, Ville Syrjälä wrote: > On Tue, Nov 16, 2021 at 09:48:18AM -0800, Matt Roper wrote: > > From: Matt Atwood > > > > Extend existing workaround 1409120013 to DG2. > > I don't see this listed for DG2. This seems to be problem with the DG2 query since for

Re: [PATCH v2 1/6] drm/i915: move the pre_pin earlier

2021-11-17 Thread Thomas Hellström
On 11/17/21 15:20, Matthew Auld wrote: In intel_context_do_pin_ww, when calling into the pre_pin hook(which is passed the ww context) it could in theory return -EDEADLK(which is very likely with debug kernels), once we start adding more ww locking in there, like in the next patch. If so then

Re: [Intel-gfx] [PATCH v3 5/5] drm/i915/dg2: extend Wa_1409120013 to DG2

2021-11-17 Thread Ville Syrjälä
On Tue, Nov 16, 2021 at 09:48:18AM -0800, Matt Roper wrote: > From: Matt Atwood > > Extend existing workaround 1409120013 to DG2. I don't see this listed for DG2. > > Cc: José Roberto de Souza > Signed-off-by: Matt Atwood > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/intel_pm.c

Re: [PATCH v3 2/6] drm: improve drm_buddy_alloc function

2021-11-17 Thread Matthew Auld
On 16/11/2021 20:18, Arunpravin wrote: - Make drm_buddy_alloc a single function to handle range allocation and non-range allocation demands - Implemented a new function alloc_range() which allocates the requested power-of-two block comply with range limitations - Moved order computation

Re: [PATCH 12/12] drm: rockchip: Add VOP2 driver

2021-11-17 Thread Nicolas Frattaroli
On Mittwoch, 17. November 2021 15:33:47 CET Sascha Hauer wrote: > The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568. > It replaces the VOP unit found in the older Rockchip SoCs. > > This driver has been derived from the downstream Rockchip Kernel and > heavily modified: > > -

Re: [PATCH v3 1/6] drm: move the buddy allocator from i915 into common drm

2021-11-17 Thread Matthew Auld
On 16/11/2021 20:18, Arunpravin wrote: Move the base i915 buddy allocator code into drm - Move i915_buddy.h to include/drm - Move i915_buddy.c to drm root folder - Rename "i915" string with "drm" string wherever applicable - Rename "I915" string with "DRM" string wherever applicable - Fix header

Re: [PATCH] gpu: drm: panel-edp: Fix edp_panel_entry documentation

2021-11-17 Thread Kieran Bingham
Quoting Doug Anderson (2021-11-17 16:49:43) > Hi, > > On Wed, Nov 17, 2021 at 8:32 AM Kieran Bingham > wrote: > > > > The edp_panel_entry members 'delay' and 'name' are documented, but > > without the correct syntax for kernel doc. > > > > This generates the following warnings: > > > >

Re: [PATCH v3 1/6] drm: move the buddy allocator from i915 into common drm

2021-11-17 Thread Arunpravin
Hi Christian, I will make this a separate module. Thanks, Arun On 17/11/21 1:33 pm, Christian König wrote: > I've looked a bit more into this and I think we should just follow > Thomas Zimmermann's idea to make this a separate module. > > Otherwise we just have the code around all the time

Re: [PATCH] gpu: drm: panel-edp: Fix edp_panel_entry documentation

2021-11-17 Thread Doug Anderson
Hi, On Wed, Nov 17, 2021 at 8:32 AM Kieran Bingham wrote: > > The edp_panel_entry members 'delay' and 'name' are documented, but > without the correct syntax for kernel doc. > > This generates the following warnings: > > drivers/gpu/drm/panel/panel-edp.c:204: warning: Function parameter or

Re: [PATCH 02/10] drm: Add privacy-screen class (v4)

2021-11-17 Thread Hans de Goede
Hi Rajat, On 11/17/21 15:28, Rajat Jain wrote: > +Heikki Krogerus > > Hello Hans, Heikki, > > I have a question below, which isn't really a problem, but more of an > attempt to understand the current code and its limitations. > > On Tue, Oct 5, 2021 at 1:23 PM Hans de Goede wrote: >> >> On

[Bug 214859] drm-amdgpu-init-iommu~fd-device-init.patch introduce bug

2021-11-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214859 spassw...@web.de changed: What|Removed |Added CC||spassw...@web.de --- Comment #8 from

[Bug 214901] amdgpu freezes HP laptop at start up

2021-11-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214901 spassw...@web.de changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 214921] amdgpu hangs HP Laptop on shutdown

2021-11-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214921 spassw...@web.de changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: Backlight control broken on UM325 (OLED) on 5.15 (bisected)

2021-11-17 Thread Samuel Čavoj
Hi Roman, On 17.11.2021 15:26, Li, Roman wrote: > [Public] > > Hi Samuel, > > Can you please try: https://patchwork.freedesktop.org/patch/463485/ ? Yup, that did the trick. Works as before. Thank you very much. Samuel > > Thanks, > Roman > > > -Original Message- > > From: Samuel

Re: [PATCH 03/10] drm/privacy-screen: Add X86 specific arch init code

2021-11-17 Thread Hans de Goede
Hi Rajat, On 11/17/21 15:13, Rajat Jain wrote: > Hello Hans, > > On Tue, Oct 5, 2021 at 1:23 PM Hans de Goede wrote: >> >> Add X86 specific arch init code, which fills the privacy-screen lookup >> table by checking for various vendor specific ACPI interfaces for >> controlling the

[PATCH] gpu: drm: panel-edp: Fix edp_panel_entry documentation

2021-11-17 Thread Kieran Bingham
The edp_panel_entry members 'delay' and 'name' are documented, but without the correct syntax for kernel doc. This generates the following warnings: drivers/gpu/drm/panel/panel-edp.c:204: warning: Function parameter or member 'delay' not described in 'edp_panel_entry'

Re: [PATCH 10/10] drm/i915: Add privacy-screen support (v3)

2021-11-17 Thread Hans de Goede
Hi Rajat, On 11/17/21 14:59, Rajat Jain wrote: > Hello Hans, > > I'm working on my platform's privacy-screen support based on your > patches, and had some (I know late) questions. Would be great if you > could please help answer. Please see inline. > > On Tue, Oct 5, 2021 at 1:25 PM Hans de

Re: [PATCH 07/12] dt-bindings: display: rockchip: Add binding for VOP2

2021-11-17 Thread Rob Herring
On Wed, 17 Nov 2021 15:33:42 +0100, Sascha Hauer wrote: > The VOP2 is found on newer Rockchip SoCs like the rk3568 or the rk3566. > The binding differs slightly from the existing VOP binding, so add a new > binding file for it. > > Signed-off-by: Sascha Hauer > --- >

[PATCH] arm64: dts: rockchip: enable vop2 and hdmi tx on quartz64a

2021-11-17 Thread Michael Riesch
Enable the RK356x Video Output Processor (VOP) 2 on the Pine64 Quartz64 Model A. Signed-off-by: Michael Riesch --- .../boot/dts/rockchip/rk3566-quartz64-a.dts | 24 +++ 1 file changed, 24 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts

Re: [PATCH] drm/format-helper: Fix dst computation in drm_fb_xrgb8888_to_rgb888_dstclip()

2021-11-17 Thread Hector Martin
On 17/11/2021 23.56, Thomas Zimmermann wrote: Hi Am 17.11.21 um 15:22 schrieb Hector Martin: The dst pointer was being advanced by the clip width, not the full line stride, resulting in corruption. The clip offset was also calculated incorrectly. Cc: sta...@vger.kernel.org Signed-off-by:

RE: Backlight control broken on UM325 (OLED) on 5.15 (bisected)

2021-11-17 Thread Li, Roman
[Public] Hi Samuel, Can you please try: https://patchwork.freedesktop.org/patch/463485/ ? Thanks, Roman > -Original Message- > From: Samuel Čavoj > Sent: Tuesday, November 16, 2021 8:33 AM > To: Alex Deucher > Cc: Deucher, Alexander ; Li, Sun peng (Leo) > ; Li, Roman ; Maling list -

Re: [PATCH 10/12] arm64: dts: rockchip: rk3568-evb: Enable VOP2 and hdmi

2021-11-17 Thread Michael Riesch
Hi Sascha, On 11/17/21 3:33 PM, Sascha Hauer wrote: This enabled the VOP2 display controller along with hdmi and the required port routes which is enough to get a picture out of the hdmi port of the board. Signed-off-by: Sascha Hauer --- .../boot/dts/rockchip/rk3568-evb1-v10.dts | 24

Re: [PATCH 10/12] arm64: dts: rockchip: rk3568-evb: Enable VOP2 and hdmi

2021-11-17 Thread Rob Herring
On Wed, Nov 17, 2021 at 8:34 AM Sascha Hauer wrote: > > This enabled the VOP2 display controller along with hdmi and the > required port routes which is enough to get a picture out of the > hdmi port of the board. > > Signed-off-by: Sascha Hauer > --- > .../boot/dts/rockchip/rk3568-evb1-v10.dts

Re: [PATCH 11/12] drm/rockchip: Make VOP driver optional

2021-11-17 Thread Heiko Stübner
Am Mittwoch, 17. November 2021, 15:50:54 CET schrieb Sascha Hauer: > On Wed, Nov 17, 2021 at 03:40:26PM +0100, Heiko Stübner wrote: > > Am Mittwoch, 17. November 2021, 15:33:46 CET schrieb Sascha Hauer: > > > With upcoming VOP2 support VOP won't be the only choice anymore, so make > > > the VOP

Re: [PATCH 09/12] arm64: dts: rockchip: rk356x: Add HDMI nodes

2021-11-17 Thread Rob Herring
On Wed, Nov 17, 2021 at 8:34 AM Sascha Hauer wrote: > > Add support for the HDMI port found on RK3568. > > Signed-off-by: Sascha Hauer > --- > arch/arm64/boot/dts/rockchip/rk356x.dtsi | 65 > 1 file changed, 65 insertions(+) > > diff --git

[PATCH 3/3] drm/simpledrm: Enable XRGB2101010 format

2021-11-17 Thread Hector Martin
This is the format used by the bootloader framebuffer on Apple ARM64 platforms, and is already supported by simplefb. This avoids regressing on these platforms when simpledrm is enabled and replaces simplefb. Signed-off-by: Hector Martin --- drivers/gpu/drm/tiny/simpledrm.c | 2 +- 1 file

[PATCH 2/3] drm/format-helper: Add drm_fb_xrgb8888_to_xrgb2101010_dstclip()

2021-11-17 Thread Hector Martin
Add XRGB emulation support for devices that can only do XRGB2101010. This is chiefly useful for simpledrm on Apple devices where the bootloader-provided framebuffer is 10-bit, which already works fine with simplefb. This is required to make simpledrm support this too. Signed-off-by: Hector

[PATCH 1/3] drm/simpledrm: Bind to OF framebuffers in /chosen

2021-11-17 Thread Hector Martin
This matches the simplefb behavior; these nodes are not matched by the standard OF machinery. This fixes a regression when simpledrm replaces simeplefb. Signed-off-by: Hector Martin --- drivers/gpu/drm/tiny/simpledrm.c | 17 + 1 file changed, 17 insertions(+) diff --git

[PATCH 0/3] drm/simpledrm: Apple M1 / DT platform support fixes

2021-11-17 Thread Hector Martin
Hi DRM folks, This short series makes simpledrm work on Apple M1 (including Pro/Max) platforms the way simplefb already does, by adding XRGB2101010 support and making it bind to framebuffers in /chosen the same way simplefb does. This avoids breaking the bootloader-provided framebuffer console

Re: [PATCH] drm/format-helper: Fix dst computation in drm_fb_xrgb8888_to_rgb888_dstclip()

2021-11-17 Thread Thomas Zimmermann
Hi Am 17.11.21 um 15:22 schrieb Hector Martin: The dst pointer was being advanced by the clip width, not the full line stride, resulting in corruption. The clip offset was also calculated incorrectly. Cc: sta...@vger.kernel.org Signed-off-by: Hector Martin Thanks for your patch, but you're

Re: [PATCH v1 00/12] drm/rockchip: RK356x VOP2 support

2021-11-17 Thread Rob Herring
On Wed, Nov 17, 2021 at 8:34 AM Sascha Hauer wrote: > > This series adds initial graphics support for the Rockchip RK356[68] > SoCs. Graphics support is based around the VOP2 controller which > replaces the VOP controller found on earlier Rockchip SoCs. The driver > has been tested with HDMI

[PATCH 3/5] drm/vc4: Remove conflicting framebuffers before callind bind_all

2021-11-17 Thread Maxime Ripard
The bind hooks will modify their controller registers, so simplefb is going to be unusable anyway. Let's avoid any transient state where it could still be in the system but no longer functionnal. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_drv.c | 8 1 file changed, 4

[PATCH 5/5] ARM: dts: rpi: Add the firmware node to vc4

2021-11-17 Thread Maxime Ripard
Add the firmware phandle to the vc4 node so that we can send it the message that we're done with the firmware display. Signed-off-by: Maxime Ripard --- arch/arm/boot/dts/bcm2835-rpi.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/bcm2835-rpi.dtsi

[PATCH 4/5] drm/vc4: Notify the firmware when DRM is in charge

2021-11-17 Thread Maxime Ripard
Once the call to drm_fb_helper_remove_conflicting_framebuffers() has been made, simplefb has been unregistered and the KMS driver is entirely in charge of the display. Thus, we can notify the firmware it can free whatever resource it was using to maintain simplefb functional. Signed-off-by:

[PATCH 2/5] firmware: raspberrypi: Add RPI_FIRMWARE_NOTIFY_DISPLAY_DONE

2021-11-17 Thread Maxime Ripard
The RPI_FIRMWARE_NOTIFY_DISPLAY_DONE firmware call allows to tell the firmware the kernel is in charge of the display now and the firmware can free whatever resources it was using. Signed-off-by: Maxime Ripard --- include/soc/bcm2835/raspberrypi-firmware.h | 1 + 1 file changed, 1 insertion(+)

[PATCH 1/5] dt-bindings: display: vc4: Add optional phandle to firmware

2021-11-17 Thread Maxime Ripard
The firmware can free all the resources it was using to run the display engine that won't be needed once the kernel has taken over. Thus, we need a phandle to the firmware DT node to be able to send that message when relevant. Signed-off-by: Maxime Ripard ---

[PATCH 0/5] drm/vc4: Use the firmware to stop the display pipeline

2021-11-17 Thread Maxime Ripard
Hi, The VC4 driver has had limited support to disable the HDMI controllers and pixelvalves at boot if the firmware has enabled them. However, this proved to be limited, and a bit unreliable so a new firmware command has been introduced some time ago to make it free all its resources and disable

Re: [PATCH 11/12] drm/rockchip: Make VOP driver optional

2021-11-17 Thread Heiko Stübner
Am Mittwoch, 17. November 2021, 15:33:46 CET schrieb Sascha Hauer: > With upcoming VOP2 support VOP won't be the only choice anymore, so make > the VOP driver optional. > > Signed-off-by: Sascha Hauer > --- > arch/arm/configs/multi_v7_defconfig | 1 + > arch/arm64/configs/defconfig

[PATCH] drm/format-helper: Fix dst computation in drm_fb_xrgb8888_to_rgb888_dstclip()

2021-11-17 Thread Hector Martin
The dst pointer was being advanced by the clip width, not the full line stride, resulting in corruption. The clip offset was also calculated incorrectly. Cc: sta...@vger.kernel.org Signed-off-by: Hector Martin --- drivers/gpu/drm/drm_format_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Rename gt to gt0

2021-11-17 Thread Chris Wilson
Quoting Andi Shyti (2021-11-17 13:34:56) > diff --git a/drivers/gpu/drm/i915/display/intel_atomic_plane.c > b/drivers/gpu/drm/i915/display/intel_atomic_plane.c > index 089fb4658b216..0bbf8c0c42eac 100644 > --- a/drivers/gpu/drm/i915/display/intel_atomic_plane.c > +++

[PATCH v2 6/6] drm/i915: Drain the ttm delayed workqueue too

2021-11-17 Thread Matthew Auld
From: Maarten Lankhorst Lets be thorough here. Users of the TTM backend would likely expect this behaviour. Signed-off-by: Maarten Lankhorst Reviewed-by: Matthew Auld Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/i915_drv.h | 1 + 1 file changed, 1 insertion(+) diff --git

  1   2   >