Re: [PATCH] drm/amdgpu: Fix recursive locking warning

2022-02-03 Thread Christian König
Am 04.02.22 um 04:11 schrieb Rajneesh Bhardwaj: Noticed the below warning while running a pytorch workload on vega10 GPUs. Change to trylock to avoid conflicts with already held reservation locks. [ +0.03] WARNING: possible recursive locking detected [ +0.03] 5.13.0-kfd-rajneesh #1030

[git pull] drm fixes for 5.17-rc3

2022-02-03 Thread Dave Airlie
Hi Linus, Regular fixes for the week. Daniel has agreed to bring back the fbcon hw acceleration under a CONFIG option for the non-drm fbdev users, we don't advise turning this on unless you are in the niche that is old fbdev drivers, Since it's essentially a revert and shouldn't be high impact

Re: Kconfig CONFIG_FB dependency regression

2022-02-03 Thread Randy Dunlap
On 2/3/22 19:21, Thinh Nguyen wrote: > Arnd Bergmann wrote: >> On Thu, Feb 3, 2022 at 12:55 AM Thinh Nguyen >> wrote: >>> Arnd Bergmann wrote: On Wed, Feb 2, 2022 at 1:14 AM Thinh Nguyen wrote: > Fabio Estevam wrote: CONFIG_FB should not normally be needed for

RE: [Patch v5 00/24] CHECKPOINT RESTORE WITH ROCm

2022-02-03 Thread Bhardwaj, Rajneesh
[AMD Official Use Only] Thank you Felix for the review and your guidance. -Original Message- From: Kuehling, Felix Sent: Thursday, February 3, 2022 10:22 PM To: Bhardwaj, Rajneesh ; amd-...@lists.freedesktop.org Cc: Yat Sin, David ; Deucher, Alexander ;

Re: [Patch v5 00/24] CHECKPOINT RESTORE WITH ROCm

2022-02-03 Thread Felix Kuehling
The series is Reviewed-by: Felix Kuehling Am 2022-02-03 um 04:08 schrieb Rajneesh Bhardwaj: V5: Proposed IOCTL APIs for CRIU with consolidated feedback CRIU is a user space tool which is very popular for container live migration in datacentres. It can checkpoint a running application, save

[PATCH] drm/amdgpu: Fix recursive locking warning

2022-02-03 Thread Rajneesh Bhardwaj
Noticed the below warning while running a pytorch workload on vega10 GPUs. Change to trylock to avoid conflicts with already held reservation locks. [ +0.03] WARNING: possible recursive locking detected [ +0.03] 5.13.0-kfd-rajneesh #1030 Not tainted [ +0.04]

[PATCH] drm/sprd: remove allow_fb_modifiers setting

2022-02-03 Thread Tomohito Esaki
Remove allow_fb_modifiers setting in this driver. The allow_fb_modifiers flag was removed. Signed-off-by: Tomohito Esaki Fixes: 3d082157a242 ("drm: remove allow_fb_modifiers") Reported-by: kernel test robot --- drivers/gpu/drm/sprd/sprd_drm.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH 1/2] drm/mm: Add an iterator to optimally walk over holes for an allocation (v2)

2022-02-03 Thread Vivek Kasireddy
This iterator relies on drm_mm_first_hole() and drm_mm_next_hole() functions to identify suitable holes for an allocation of a given size by efficiently traversing the rbtree associated with the given allocator. It replaces the for loop in drm_mm_insert_node_in_range() and can also be used by drm

Re: [Intel-gfx] [PATCH] drm/i915: Add fallback inside memcpy_from_wc functions

2022-02-03 Thread kernel test robot
Hi Balasubramani, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-tip/drm-tip drm-exynos/exynos-drm-next drm/drm-next tegra-drm/drm/tegra/for-next v5.17-rc2 next-20220203] [cannot apply to airlied/drm

Re: [PATCH 16/19] drm/i915/guc: Use a single pass to calculate regset

2022-02-03 Thread Lucas De Marchi
On Tue, Feb 01, 2022 at 02:42:20PM -0800, Daniele Ceraolo Spurio wrote: On 1/26/2022 12:36 PM, Lucas De Marchi wrote: The ADS initialitazion was using 2 passes to calculate the regset sent to GuC to initialize each engine: the first pass to just have the final object size and the second to

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915/uapi: Add query for hwconfig table

2022-02-03 Thread Jordan Justen
Jordan Justen writes: > John, Rodrigo, > > It is now clear to me just how dependent i915 is going to be on the > closed source guc software, and that's just a fact of life for our > graphics stack going forward. > > In that context, it seems kind of pointless for me to make a big deal > out of

Re: [PATCH 11/21] fbcon: Extract fbcon_open/release helpers

2022-02-03 Thread Sam Ravnborg
Hi Daniel, > > > + kfree(ops->cursor_state.mask); > > + kfree(ops->cursor_data); > > + kfree(ops->cursor_src); > > + kfree(ops->fontbuffer); > > + kfree(oldinfo->fbcon_par); > > + oldinfo->fbcon_par = NULL; > These all look like candidates to stuff into fbcon_release() > That would

Re: [PATCH 10/21] fb: Delete fb_info->queue

2022-02-03 Thread Sam Ravnborg
On Mon, Jan 31, 2022 at 10:05:41PM +0100, Daniel Vetter wrote: > It was only used by fbcon, and that now switched to its own, > private work. > > Signed-off-by: Daniel Vetter > Cc: Helge Deller > Cc: linux-fb...@vger.kernel.org I would merge this with the patch that drops the usage > --- >

Re: [PATCH 09/21] fbcon: Replace FBCON_FLAGS_INIT with a boolean

2022-02-03 Thread Sam Ravnborg
On Mon, Jan 31, 2022 at 10:05:40PM +0100, Daniel Vetter wrote: > It's only one flag and slightly tidier code. > > Signed-off-by: Daniel Vetter > Cc: Daniel Vetter > Cc: Tetsuo Handa > Cc: Greg Kroah-Hartman > Cc: Du Cheng > Cc: Thomas Zimmermann > Cc: Claudio Suarez Acked-by: Sam Ravnborg

Re: [PATCH 07/21] fbdev/sysfs: Fix locking

2022-02-03 Thread Sam Ravnborg
On Mon, Jan 31, 2022 at 10:05:38PM +0100, Daniel Vetter wrote: > fb_set_var requires we hold the fb_info lock. Or at least this now > matches what the ioctl does ... > > Note that ps3fb and sh_mobile_lcdcfb are busted in different ways here, > but I will not fix them up. > > Also in practice

Re: [PATCH 05/21] fbcon: Introduce wrapper for console->fb_info lookup

2022-02-03 Thread Sam Ravnborg
On Mon, Jan 31, 2022 at 10:05:36PM +0100, Daniel Vetter wrote: > Half of it is protected by console_lock, but the other half is a lot > more awkward: Registration/deregistration of fbdev are serialized, but > we don't really clear out anything in con2fb_map and so there's > potential for use-after

Re: [PATCH 12/21] fbcon: Ditch error handling for con2fb_release_oldinfo

2022-02-03 Thread Sam Ravnborg
On Mon, Jan 31, 2022 at 10:05:43PM +0100, Daniel Vetter wrote: > It doesn't ever fail anymore. > > Signed-off-by: Daniel Vetter > Cc: Daniel Vetter > Cc: Thomas Zimmermann > Cc: Greg Kroah-Hartman > Cc: Claudio Suarez > Cc: Du Cheng > Cc: Tetsuo Handa Acked-by: Sam Ravnborg

Re: [PATCH 11/21] fbcon: Extract fbcon_open/release helpers

2022-02-03 Thread Sam Ravnborg
Hi Daniel, On Mon, Jan 31, 2022 at 10:05:42PM +0100, Daniel Vetter wrote: > There's two minor behaviour changes in here: > - in error paths we now consistently call fb_ops->fb_release > - fb_release really can't fail (fbmem.c ignores it too) and there's no > reasonable cleanup we can do anyway.

Re: [PATCH v2] drm/msm/dp: add connector type to enhance debug messages

2022-02-03 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-01-31 18:34:47) > On 27/01/2022 02:46, Kuogee Hsieh wrote: > > DP driver is a generic driver which supports both eDP and DP. > > For debugging purpose it is required to have capabilities to > > differentiate message are generated from eDP or DP. > > This patch do: >

Re: [PATCH] drm/panel: Select DRM_DP_HELPER for DRM_PANEL_EDP

2022-02-03 Thread Lyude Paul
Reviewed-by: Lyude Paul On Thu, 2022-02-03 at 10:13 +0100, Thomas Zimmermann wrote: > As reported in [1], DRM_PANEL_EDP depends on DRM_DP_HELPER. Select > the option to fix the build failure. The issue has been reported > before, when DisplayPort helpers where hidden behind the option >

[Important!] 2022 X.Org Foundation Membership deadline for voting in the election

2022-02-03 Thread Lyude Paul
The 2022 X.Org Foundation elections are rapidly approaching. We will be forwarding instructions on the nomination process to membership in the near future. Please note that only current members can vote in the upcoming election, and that the deadline for new memberships or renewals to vote in the

Re: [PATCH 06/21] fbcon: delete delayed loading code

2022-02-03 Thread Sam Ravnborg
Hi Daniel, On Mon, Jan 31, 2022 at 10:05:37PM +0100, Daniel Vetter wrote: > Before > > commit 6104c37094e729f3d4ce65797002112735d49cd1 > Author: Daniel Vetter > Date: Tue Aug 1 17:32:07 2017 +0200 > > fbcon: Make fbcon a built-time depency for fbdev > > it was possible to load fbcon and

[PATCH AUTOSEL 5.4 07/15] drm: panel-orientation-quirks: Add quirk for the 1Netbook OneXPlayer

2022-02-03 Thread Sasha Levin
From: Raymond Jay Golo [ Upstream commit d3cbc6e323c9299d10c8d2e4127c77c7d05d07b1 ] The 1Netbook OneXPlayer uses a panel which has been mounted 90 degrees rotated. Add a quirk for this. Signed-off-by: Raymond Jay Golo Signed-off-by: Daniel Vetter Link:

[PATCH AUTOSEL 5.10 10/25] drm: panel-orientation-quirks: Add quirk for the 1Netbook OneXPlayer

2022-02-03 Thread Sasha Levin
From: Raymond Jay Golo [ Upstream commit d3cbc6e323c9299d10c8d2e4127c77c7d05d07b1 ] The 1Netbook OneXPlayer uses a panel which has been mounted 90 degrees rotated. Add a quirk for this. Signed-off-by: Raymond Jay Golo Signed-off-by: Daniel Vetter Link:

[PATCH AUTOSEL 5.15 35/41] drm/amd/display: Correct MPC split policy for DCN301

2022-02-03 Thread Sasha Levin
From: Zhan Liu [ Upstream commit ac46d93235074a6c5d280d35771c23fd8620e7d9 ] [Why] DCN301 has seamless boot enabled. With MPC split enabled at the same time, system will hang. [How] Revert MPC split policy back to "MPC_SPLIT_AVOID". Since we have ODM combine enabled on DCN301, pipe split is not

[PATCH AUTOSEL 5.15 19/41] drm/vc4: Fix deadlock on DSI device attach error

2022-02-03 Thread Sasha Levin
From: Padmanabha Srinivasaiah [ Upstream commit 0a3d12ab5097b1d045e693412e6b366b7e82031b ] DSI device attach to DSI host will be done with host device's lock held. Un-registering host in "device attach" error path (ex: probe retry) will result in deadlock with below call trace and non

[PATCH AUTOSEL 5.15 20/41] drm: panel-orientation-quirks: Add quirk for the 1Netbook OneXPlayer

2022-02-03 Thread Sasha Levin
From: Raymond Jay Golo [ Upstream commit d3cbc6e323c9299d10c8d2e4127c77c7d05d07b1 ] The 1Netbook OneXPlayer uses a panel which has been mounted 90 degrees rotated. Add a quirk for this. Signed-off-by: Raymond Jay Golo Signed-off-by: Daniel Vetter Link:

[PATCH AUTOSEL 5.16 40/52] drm/amdgpu/display: use msleep rather than udelay for long delays

2022-02-03 Thread Sasha Levin
From: Alex Deucher [ Upstream commit 98fdcacb45f7cd2092151d6af2e60152811eb79c ] Some architectures (e.g., ARM) throw an compilation error if the udelay is too long. In general udelays of longer than 2000us are not recommended on any architecture. Switch to msleep in these cases. Reviewed-by:

[PATCH AUTOSEL 5.16 39/52] drm/amdgpu/display: adjust msleep limit in dp_wait_for_training_aux_rd_interval

2022-02-03 Thread Sasha Levin
From: Alex Deucher [ Upstream commit dc919d670c6fd1ac81ebf31625cd19579f7b3d4c ] Some architectures (e.g., ARM) have relatively low udelay limits. On most architectures, anything longer than 2000us is not recommended. Change the check to align with other similar checks in DC. Reviewed-by: Harry

[PATCH AUTOSEL 5.16 38/52] drm/amd/display: Correct MPC split policy for DCN301

2022-02-03 Thread Sasha Levin
From: Zhan Liu [ Upstream commit ac46d93235074a6c5d280d35771c23fd8620e7d9 ] [Why] DCN301 has seamless boot enabled. With MPC split enabled at the same time, system will hang. [How] Revert MPC split policy back to "MPC_SPLIT_AVOID". Since we have ODM combine enabled on DCN301, pipe split is not

[PATCH AUTOSEL 5.16 20/52] drm: panel-orientation-quirks: Add quirk for the 1Netbook OneXPlayer

2022-02-03 Thread Sasha Levin
From: Raymond Jay Golo [ Upstream commit d3cbc6e323c9299d10c8d2e4127c77c7d05d07b1 ] The 1Netbook OneXPlayer uses a panel which has been mounted 90 degrees rotated. Add a quirk for this. Signed-off-by: Raymond Jay Golo Signed-off-by: Daniel Vetter Link:

Re: [PATCH 04/21] fbcon: delete a few unneeded forward decl

2022-02-03 Thread Sam Ravnborg
On Mon, Jan 31, 2022 at 10:05:35PM +0100, Daniel Vetter wrote: > I didn't bother with any code movement to fix the others, these just > got a bit in the way. > > Signed-off-by: Daniel Vetter > Cc: Helge Deller > Cc: Daniel Vetter > Cc: Thomas Zimmermann > Cc: Du Cheng > Cc: Tetsuo Handa >

[PATCH AUTOSEL 5.16 19/52] drm/vc4: Fix deadlock on DSI device attach error

2022-02-03 Thread Sasha Levin
From: Padmanabha Srinivasaiah [ Upstream commit 0a3d12ab5097b1d045e693412e6b366b7e82031b ] DSI device attach to DSI host will be done with host device's lock held. Un-registering host in "device attach" error path (ex: probe retry) will result in deadlock with below call trace and non

Re: [PATCH 01/21] MAINTAINERS: Add entry for fbdev core

2022-02-03 Thread Sam Ravnborg
Hi Daniel, On Mon, Jan 31, 2022 at 10:05:32PM +0100, Daniel Vetter wrote: > Ever since Tomi extracted the core code in 2014 it's been defacto me > maintaining this, with help from others from dri-devel and sometimes > Linus (but those are mostly merge conflicts): > > $ git shortlog -ns

Re: [PATCH v2] drm/panel: Select DRM_DP_HELPER for DRM_PANEL_EDP

2022-02-03 Thread Sam Ravnborg
On Thu, Feb 03, 2022 at 10:39:22AM +0100, Thomas Zimmermann wrote: > As reported in [1], DRM_PANEL_EDP depends on DRM_DP_HELPER. Select > the option to fix the build failure. The error message is shown > below. > > arm-linux-gnueabihf-ld: drivers/gpu/drm/panel/panel-edp.o: in function >

Re: [PATCH v5 6/6] drm/vc4: hdmi: Support HDMI YUV output

2022-02-03 Thread Ville Syrjälä
On Thu, Jan 27, 2022 at 03:10:21PM +0100, Maxime Ripard wrote: > +/* > + * Conversion between Full Range RGB and Full Range YUV444 using the > + * BT.709 Colorspace > + * > + * [ -0.117208 -0.394207 0.511416 128 ] > + * [ 0.511416 -0.464524 -0.046891 128 ] > + * [ 0.212639 0.715169 0.072192

[PATCH v4 2/4] drm/i915/gt: Drop invalidate_csb_entries

2022-02-03 Thread Michael Cheng
Drop invalidate_csb_entries and directly call drm_clflush_virt_range. This allows for one less function call, and prevent complier errors when building for non-x86 architectures. v2(Michael Cheng): Drop invalidate_csb_entries function and directly invoke drm_clflush_virt_range.

[PATCH v4 4/4] drm/i915/: Re-work clflush_write32

2022-02-03 Thread Michael Cheng
Use drm_clflush_virt_range instead of clflushopt and remove the memory barrier, since drm_clflush_virt_range takes care of that. Signed-off-by: Michael Cheng --- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git

[PATCH v4 3/4] drm/i915/gt: Re-work reset_csb

2022-02-03 Thread Michael Cheng
Use drm_clflush_virt_range instead of directly invoking clflush. This will prevent compiler errors when building for non-x86 architectures. v2(Michael Cheng): Remove extra clflush v3(Michael Cheng): Remove memory barrier since drm_clflush_virt_range takes care of it.

[PATCH v4 0/4] Use drm_clflush* instead of clflush

2022-02-03 Thread Michael Cheng
This patch series re-work a few i915 functions to use drm_clflush_virt_range instead of calling clflush or clflushopt directly. This will prevent errors when building for non-x86 architectures. v2: s/PAGE_SIZE/sizeof(value) for Re-work intel_write_status_page and added more patches to convert

[PATCH v4 1/4] drm/i915/gt: Re-work intel_write_status_page

2022-02-03 Thread Michael Cheng
Re-work intel_write_status_page to use drm_clflush_virt_range. This will prevent compiler errors when building for non-x86 architectures. Signed-off-by: Michael Cheng --- drivers/gpu/drm/i915/gt/intel_engine.h | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git

Re: [PATCH v5 2/6] drm/vc4: hdmi: Move clock calculation into its own function

2022-02-03 Thread Ville Syrjälä
On Thu, Jan 27, 2022 at 03:10:17PM +0100, Maxime Ripard wrote: > The code to compute our clock rate for a given setup will be called in > multiple places in the next patches, so let's create a separate function > for it. > > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/vc4/vc4_hdmi.c |

Re: Linux 5.16.3 breaks headless Raspberry Pi 3 boot, again

2022-02-03 Thread Michael Stapelberg
Hi Maxime, maxime at cerno.tech (Maxime Ripard) writes: > I'm not entirely sure what you expect by insisting on things getting > broken *again*, but we got it, thanks. I wanted to remind of the previous issue, which had the same symptoms, and hence might be related and helpful in debugging.

Re: [PATCH 8/8] drm/ast: Move SIL164-based connector code into separate helpers

2022-02-03 Thread Javier Martinez Canillas
On 1/11/22 13:00, Thomas Zimmermann wrote: > Add helpers for initializing SIL164-based connectors. These used to be > handled by the VGA connector code. But SIL164 provides output via DVI-I, > so set the encoder and connector types accordingly. > > If a SIL164 chip has been detected, ast will now

Re: [PATCH v16 33/40] soc/tegra: pmc: Enable core domain support for Tegra20 and Tegra30

2022-02-03 Thread Thierry Reding
On Wed, Dec 01, 2021 at 02:23:40AM +0300, Dmitry Osipenko wrote: > All device drivers got runtime PM and OPP support. Flip the core domain > support status for Tegra20 and Tegra30 SoCs. > > Reviewed-by: Ulf Hansson > Signed-off-by: Dmitry Osipenko > --- > drivers/soc/tegra/pmc.c | 4 ++-- > 1

Re: [PATCH 7/8] drm/ast: Move DP501-based connector code into separate helpers

2022-02-03 Thread Javier Martinez Canillas
On 1/11/22 13:00, Thomas Zimmermann wrote: > Add helpers for DP501-based connectors. DP501 provides output via > DisplayPort. This used to be handled by the VGA connector code. > > If a DP501 chip has been detected, ast will now create a DisplayPort > connector instead of a VGA connector. > >

Re: [PATCH] drm/i915: Flip guc_id allocation partition

2022-02-03 Thread Matthew Brost
On Wed, Feb 02, 2022 at 11:15:00PM +0100, Michal Wajdeczko wrote: > > > On 13.01.2022 17:27, Matthew Brost wrote: > > Move the multi-lrc guc_id from the lower allocation partition (0 to > > number of multi-lrc guc_ids) to upper allocation partition (number of > > single-lrc to max guc_ids). > >

Re: [PATCH 6/8] drm/ast: Initialize encoder and connector for VGA in helper function

2022-02-03 Thread Javier Martinez Canillas
On 1/11/22 13:00, Thomas Zimmermann wrote: > Move encoder and connector initialization into a single helper and > put all related mode-setting structures into a single place. Done in > preparation of moving transmitter code into separate helpers. No > functional changes. > > Signed-off-by: Thomas

[PATCH v4 2/4] drm/i915/gt: Drop invalidate_csb_entries

2022-02-03 Thread Michael Cheng
Drop invalidate_csb_entries and directly call drm_clflush_virt_range. This allows for one less function call, and prevent complier errors when building for non-x86 architectures. v2(Michael Cheng): Drop invalidate_csb_entries function and directly invoke drm_clflush_virt_range.

[PATCH v4 0/4] Use drm_clflush* instead of clflush

2022-02-03 Thread Michael Cheng
This patch series re-work a few i915 functions to use drm_clflush_virt_range instead of calling clflush or clflushopt directly. This will prevent errors when building for non-x86 architectures. v2: s/PAGE_SIZE/sizeof(value) for Re-work intel_write_status_page and added more patches to convert

[PATCH v4 4/4] drm/i915/: Re-work clflush_write32

2022-02-03 Thread Michael Cheng
Use drm_clflush_virt_range instead of clflushopt and remove the memory barrier, since drm_clflush_virt_range takes care of that. Signed-off-by: Michael Cheng --- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git

[PATCH v4 3/4] drm/i915/gt: Re-work reset_csb

2022-02-03 Thread Michael Cheng
Use drm_clflush_virt_range instead of directly invoking clflush. This will prevent compiler errors when building for non-x86 architectures. v2(Michael Cheng): Remove extra clflush v3(Michael Cheng): Remove memory barrier since drm_clflush_virt_range takes care of it.

[PATCH v4 1/4] drm/i915/gt: Re-work intel_write_status_page

2022-02-03 Thread Michael Cheng
Re-work intel_write_status_page to use drm_clflush_virt_range. This will prevent compiler errors when building for non-x86 architectures. Signed-off-by: Michael Cheng --- drivers/gpu/drm/i915/gt/intel_engine.h | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git

RE: [RFC v2 00/22] Add Support for Plane Color Lut and CSC features

2022-02-03 Thread Shankar, Uma
> -Original Message- > From: dri-devel On Behalf Of Harry > Wentland > Sent: Wednesday, February 2, 2022 9:42 PM > To: Shankar, Uma ; intel-...@lists.freedesktop.org; > dri- > de...@lists.freedesktop.org > Cc: sebast...@sebastianwick.net; shashank.sha...@amd.com > Subject: Re: [RFC v2

Re: [PATCH -next] drm/amdkfd: Fix resource_size.cocci warning

2022-02-03 Thread Felix Kuehling
Am 2022-02-03 um 00:04 schrieb Yang Li: Use resource_size function on resource object instead of explicit computation. Eliminate the following coccicheck warning: ./drivers/gpu/drm/amd/amdkfd/kfd_migrate.c:978:11-14: ERROR: Missing resource_size with res Reported-by: Abaci Robot

Re: [PATCH 5/8] drm/ast: Rename struct ast_connector to struct ast_vga_connector

2022-02-03 Thread Javier Martinez Canillas
On 1/11/22 13:00, Thomas Zimmermann wrote: > Prepare for introducing other connectors besides VGA. No functional > changes. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat

Re: [PATCH] HPE BMC GXP SUPPORT

2022-02-03 Thread Verdun, Jean-Marie
> Maybe it does not look like, but this is actually a v2. Nick was asked > to change the naming for the nodes already in v1. Unfortunately it did > not happen, so we have vuart, spifi, vic and more. > It is a waste of reviewers' time to ask them to perform the same review > twice

Re: [PATCH 4/8] drm/ast: Remove unused value dp501_maxclk

2022-02-03 Thread Javier Martinez Canillas
On 1/11/22 13:00, Thomas Zimmermann wrote: > Remove reading the link-rate. The value is maintained by the connector > code but never used. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat

Re: [PATCH 3/8] drm/ast: Remove AST_TX_ITE66121 constant

2022-02-03 Thread Javier Martinez Canillas
On 1/11/22 13:00, Thomas Zimmermann wrote: > The ITE66121 is an HDMI transmitter chip. There's no code for > detecting or programming the chip within ast. Remove the enum > constant. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas Best regards, -- Javier

Re: [PATCH 2/8] drm/ast: Move connector mode_valid function to CRTC

2022-02-03 Thread Javier Martinez Canillas
On 1/11/22 13:00, Thomas Zimmermann wrote: > The tests in ast_mode_valid() verify the correct resolution for the > supplied mode. This is a limitation of the CRTC, so move the function > to the CRTC helpers. No functional changes. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier

Re: [PATCH 1/8] drm/ast: Fail if connector initialization fails

2022-02-03 Thread Javier Martinez Canillas
Hello Thomas, On 1/11/22 13:00, Thomas Zimmermann wrote: > Update the connector code to fail if the connector could not be > initialized. The current code just ignored the error and failed > later when the connector was supposed to be used. > > Signed-off-by: Thomas Zimmermann > ---

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-03 Thread Sui Jingfeng
+static int lsdc_primary_plane_atomic_check(struct drm_plane *plane, + struct drm_atomic_state *state) +{ + struct drm_device *ddev = plane->dev; + struct lsdc_device *ldev = to_lsdc(ddev); + struct drm_plane_state *old_plane_state =

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-03 Thread Sui Jingfeng
+static enum drm_mode_status +lsdc_crtc_helper_mode_valid(struct drm_crtc *crtc, + const struct drm_display_mode *mode) +{ + struct drm_device *ddev = crtc->dev; + struct lsdc_device *ldev = to_lsdc(ddev); + const struct lsdc_chip_desc *desc =

[PATCH] drm/i915: Add fallback inside memcpy_from_wc functions

2022-02-03 Thread Balasubramani Vivekanandan
memcpy_from_wc functions can fail if SSE4.1 is not supported or the supplied addresses are not 16-byte aligned. It was then upto to the caller to use memcpy as fallback. Now fallback to memcpy is implemented inside memcpy_from_wc functions relieving the user from checking the return value of

[Bug 215511] Dual monitor with amd 5700 causes system to hang at startup.

2022-02-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215511 --- Comment #6 from Jose Mestre (pmes...@gmail.com) --- Hello, i've tried this patch and it works with 5.15.12#0f591d17e36e08313b0c440b99b0e57b47e01a9a and with 5.17.0-rc2. Kind regards. -- You may reply to this email to add a comment. You are

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-03 Thread Sui Jingfeng
diff --git a/drivers/gpu/drm/lsdc/Makefile b/drivers/gpu/drm/lsdc/Makefile new file mode 100644 index ..342990654478 --- /dev/null +++ b/drivers/gpu/drm/lsdc/Makefile @@ -0,0 +1,15 @@ +# +# Makefile for the lsdc drm device driver. +# + +lsdc-y := \ + lsdc_drv.o \ +

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-03 Thread Sui Jingfeng
On 2022/2/3 16:58, Maxime Ripard wrote: diff --git a/drivers/gpu/drm/lsdc/Kconfig b/drivers/gpu/drm/lsdc/Kconfig new file mode 100644 index ..7ed1b0fdbe1b --- /dev/null +++ b/drivers/gpu/drm/lsdc/Kconfig @@ -0,0 +1,38 @@ +config DRM_LSDC + tristate "DRM Support for loongson's

Re: [PATCH] drm/vc4: crtc: Fix redundant variable assignment

2022-02-03 Thread Sam Ravnborg
On Thu, Feb 03, 2022 at 04:11:51PM +0100, Maxime Ripard wrote: > The variable is assigned twice to the same value. Let's drop one. > > Reported-by: kernel test robot > Signed-off-by: Maxime Ripard Reviewed-by: Sam Ravnborg > --- > drivers/gpu/drm/vc4/vc4_crtc.c | 1 - > 1 file changed, 1

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-03 Thread Sui Jingfeng
On 2022/2/3 16:58, Maxime Ripard wrote: Hi, On Thu, Feb 03, 2022 at 04:25:44PM +0800, Sui Jingfeng wrote: From: suijingfeng There is a display controller in loongson's LS2K1000 SoC and LS7A1000 bridge, and the DC in those chip is a PCI device. This patch provide a minimal support for this

[PATCH] drm/ast: fix using freed memory

2022-02-03 Thread trix
From: Tom Rix clang static analysis reports this problem ast_mode.c:1235:3: warning: Use of memory after it is freed drm_connector_update_edid_property(_connector->base, edid); ^~ The second condition on if (!flags &&

[PATCH] drm/vc4: crtc: Fix redundant variable assignment

2022-02-03 Thread Maxime Ripard
The variable is assigned twice to the same value. Let's drop one. Reported-by: kernel test robot Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c index

Re: (subset) [PATCH] drm/connector: Fix typo in documentation

2022-02-03 Thread Maxime Ripard
On Wed, 2 Feb 2022 10:43:40 +0100, Maxime Ripard wrote: > Commit 4adc33f36d80 ("drm/edid: Split deep color modes between RGB and > YUV444") introduced two new variables in struct drm_display_info and > their documentation, but the documentation part had a typo resulting in > a doc build warning. >

Re: (subset) [PATCH] drm/vc4: hdmi: Unregister codec device on unbind

2022-02-03 Thread Maxime Ripard
On Thu, Feb 03, 2022 at 04:06:37PM +0100, Maxime Ripard wrote: > On Thu, 27 Jan 2022 12:14:52 +0100, Maxime Ripard wrote: > > On bind we will register the HDMI codec device but we don't unregister > > it on unbind, leading to a device leakage. Unregister our device at > > unbind. > > > > > >

[Bug 215511] Dual monitor with amd 5700 causes system to hang at startup.

2022-02-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215511 --- Comment #5 from Alex Deucher (alexdeuc...@gmail.com) --- Created attachment 300385 --> https://bugzilla.kernel.org/attachment.cgi?id=300385=edit possible fix This patch should fix it. -- You may reply to this email to add a comment. You

Re: (subset) [PATCH] drm/vc4: hdmi: Unregister codec device on unbind

2022-02-03 Thread Maxime Ripard
On Thu, 27 Jan 2022 12:14:52 +0100, Maxime Ripard wrote: > On bind we will register the HDMI codec device but we don't unregister > it on unbind, leading to a device leakage. Unregister our device at > unbind. > > Applied to drm/drm-misc (drm-misc-fixes). Thanks! Maxime

Re: (subset) [PATCH] drm/vc4: hdmi: Ensure we don't use 2711 HPD registers on Pi0-3

2022-02-03 Thread Maxime Ripard
On Thu, 27 Jan 2022 14:17:54 +0100, Maxime Ripard wrote: > From: Dave Stevenson > > The existing logic was flawed in that it could try reading the > 2711 specific registers for HPD on a CM1/3 where the HPD GPIO > hadn't been defined in DT. > > Ensure we don't do the 2711 register read on

Re: (subset) [PATCH] drm/vc4: hdmi: Don't try disabling SCDC on Pi0-3.

2022-02-03 Thread Maxime Ripard
On Thu, 27 Jan 2022 14:45:59 +0100, Maxime Ripard wrote: > From: Dave Stevenson > > The code that set the scdc_enabled flag to ensure it was > disabled at boot time also ran on Pi0-3 where there is no > SCDC support. This lead to a warning in vc4_hdmi_encoder_post_crtc_disable > due to

Re: (subset) [PATCH] drm/vc4: hdmi: Allow DBLCLK modes even if horz timing is odd.

2022-02-03 Thread Maxime Ripard
On Thu, 27 Jan 2022 14:51:16 +0100, Maxime Ripard wrote: > From: Dave Stevenson > > The 2711 pixel valve can't produce odd horizontal timings, and > checks were added to vc4_hdmi_encoder_atomic_check and > vc4_hdmi_encoder_mode_valid to filter out/block selection of > such modes. > > [...]

Re: [PATCH v2 3/3] drm/panel: Add MIPI DBI compatible SPI driver

2022-02-03 Thread Maxime Ripard
Hi Sam, On Wed, Feb 02, 2022 at 06:14:16PM +0100, Sam Ravnborg wrote: > Hi Noralf, > > > > > > > Parts of it is ergonomics I guess. We're used to having all those > > > properties either in the DT or the driver, but here we introduce a new > > > way that isn't done anywhere else. > > > > > >

Re: [PATCH] HPE BMC GXP SUPPORT

2022-02-03 Thread Krzysztof Kozlowski
On 03/02/2022 15:29, Rob Herring wrote: > On Wed, Feb 2, 2022 at 10:55 AM wrote: >> >> From: Nick Hawkins >> (...) >> + >> + vuart_a: vuart_a@80fd0200 { > > serial@... Maybe it does not look like, but this is actually a v2. Nick was asked to change the naming for the nodes already in

Re: [PATCH v3] drm: document struct drm_mode_fb_cmd2

2022-02-03 Thread Daniel Stone
On Thu, 3 Feb 2022 at 13:38, Simon Ser wrote: > Follow-up for the DRM_IOCTL_MODE_GETFB2 docs. > > v2: (Daniel Stone) > - Replace fourcc.org with drm_fourcc.h because this is the > authoritative source and the website may have mismatches. > - Drop assumption that offsets will generally be 0. > -

Re: [PATCH 1/7] drm/selftests: Move i915 buddy selftests into drm

2022-02-03 Thread Christian König
Am 03.02.22 um 14:32 schrieb Arunpravin: - move i915 buddy selftests into drm selftests folder - add Makefile and Kconfig support - add sanitycheck testcase Prerequisites - These series of selftests patches are created on top of drm buddy series - Enable kselftests for DRM as a module in

Re: [PATCH] HPE BMC GXP SUPPORT

2022-02-03 Thread Rob Herring
On Wed, Feb 2, 2022 at 10:55 AM wrote: > > From: Nick Hawkins > > GXP is the name of the HPE SoC. > This SoC is used to implement BMC features of HPE servers > (all ProLiant, Synergy, and many Apollo, and Superdome machines) > It does support many features including: > ARMv7

RE: [Patch v5 15/24] drm/amdkfd: CRIU implement gpu_id remapping

2022-02-03 Thread Yat Sin, David
One nit pick. Regards, David @@ -673,15 +693,19 @@ static int kfd_ioctl_dbg_address_watch(struct file *filep, memset((void *) _info, 0, sizeof(struct dbg_address_watch_info)); - dev = kfd_device_by_id(args->gpu_id); - if (!dev) + mutex_lock(>mutex); + pdd =

[PATCH v6 4/4] dt-bindings: drm/bridge: anx7625: Add aux-bus node

2022-02-03 Thread Hsin-Yi Wang
List panel under aux-bus node if it's connected to anx7625's aux bus. Signed-off-by: Hsin-Yi Wang --- .../display/bridge/analogix,anx7625.yaml| 17 + 1 file changed, 17 insertions(+) diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml

[PATCH v6 3/4] drm/bridge: anx7625: Support reading edid through aux channel

2022-02-03 Thread Hsin-Yi Wang
Support reading edid through aux channel if panel is connected to aux bus. Extend anx7625_aux_dpcd_trans() to implement aux transfer function: 1. panel is populated in devm_of_dp_aux_populate_ep_devices(), so move anx7625_parse_dt() after. 2. Use pm runtime autosuspend since aux transfer

[PATCH v6 2/4] drm/bridge: anx7625: Convert to use devm_kzalloc

2022-02-03 Thread Hsin-Yi Wang
Use devm_kzalloc instead of kzalloc and drop kfree(). Let the memory handled by driver detach. Signed-off-by: Hsin-Yi Wang Reviewed-by: Xin Ji --- v2->v3: remove kfree() in anx7625_i2c_remove(). --- drivers/gpu/drm/bridge/analogix/anx7625.c | 10 +++--- 1 file changed, 3 insertions(+), 7

[PATCH v6 1/4] drm/bridge: anx7625: send DPCD command to downstream

2022-02-03 Thread Hsin-Yi Wang
From: Xin Ji Send DPCD command to downstream before anx7625 power down, let downstream monitor enter into standby mode. Signed-off-by: Xin Ji Signed-off-by: Hsin-Yi Wang Reviewed-by: Hsin-Yi Wang --- v3->v4: Use common DP_AUX_NATIVE_READ/WRITE Previously in:

Re: [PATCH 19/20] drm/i915/lmem: don't treat small BAR as an error

2022-02-03 Thread Matthew Auld
On 03/02/2022 13:56, Thomas Hellström wrote: On Thu, 2022-02-03 at 11:18 +, Matthew Auld wrote: On 03/02/2022 09:48, Thomas Hellström wrote: On 1/26/22 16:21, Matthew Auld wrote: Just pass along the probed io_size. The backend should be able to utilize the entire range here, even if some

Re: [PATCH 19/20] drm/i915/lmem: don't treat small BAR as an error

2022-02-03 Thread Thomas Hellström
On Thu, 2022-02-03 at 11:18 +, Matthew Auld wrote: > On 03/02/2022 09:48, Thomas Hellström wrote: > > > > On 1/26/22 16:21, Matthew Auld wrote: > > > Just pass along the probed io_size. The backend should be able to > > > utilize the entire range here, even if some of it is non- > > >

[RFC 3/5] drm/hdmi21: Add helpers to verify non-dsc DFM requirements

2022-02-03 Thread Vandita Kulkarni
Add helpers to compute DFM variables and to verify if the DFM requirements are met or not in non dsc cases. Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/drm_frl_dfm_helper.c | 161 +++ include/drm/drm_frl_dfm_helper.h | 2 + 2 files changed, 163

[RFC 4/5] drm/hdmi21: Add support for DFM calculation with DSC

2022-02-03 Thread Vandita Kulkarni
From: Ankit Nautiyal Add helper functions for calculating FRL capacity and DFM requirements with given compressed bpp. Signed-off-by: Ankit Nautiyal Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/drm_frl_dfm_helper.c | 298 +++ include/drm/drm_frl_dfm_helper.h

[RFC 5/5] drm/hdmi21: Add frl_dfm_helper to Makefile

2022-02-03 Thread Vandita Kulkarni
Add the new frl_dfm_helper file to drm Makefile Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile index 8675c2af7ae1..4fa9b48995c8 100644 ---

[RFC 2/5] drm/hdmi21: Add non dsc frl capacity computation helpers

2022-02-03 Thread Vandita Kulkarni
Add helper functions for computing non dsc frl link characteristics Signed-off-by: Vandita Kulkarni --- drivers/gpu/drm/drm_frl_dfm_helper.c | 396 +++ 1 file changed, 396 insertions(+) create mode 100644 drivers/gpu/drm/drm_frl_dfm_helper.c diff --git

[RFC 0/5] Add data flow metering support for HDMI2.1

2022-02-03 Thread Vandita Kulkarni
The below patches add support for data flow metering as mentioned in the section 6.5.6 FRL data flow metering of HDMI 2.1 specification. Add functions to calclulate the DFM parameters for the given frl config, which is further used to evaluate the data flow metering requirement as specified in

[RFC 1/5] drm/hdmi21: Define frl_dfm structure

2022-02-03 Thread Vandita Kulkarni
Define frl_dfm structure to hold frl characteristics needed for frl capacity computation in order to meet the data flow metering requirement. Signed-off-by: Vandita Kulkarni --- include/drm/drm_frl_dfm_helper.h | 126 +++ 1 file changed, 126 insertions(+) create

Re: [PATCH 09/21] fbcon: Replace FBCON_FLAGS_INIT with a boolean

2022-02-03 Thread Geert Uytterhoeven
On Wed, Feb 2, 2022 at 10:25 AM Thomas Zimmermann wrote: > Am 31.01.22 um 22:05 schrieb Daniel Vetter: > > It's only one flag and slightly tidier code. > > > > Signed-off-by: Daniel Vetter > > Cc: Daniel Vetter > > Cc: Tetsuo Handa > > Cc: Greg Kroah-Hartman > > Cc: Du Cheng > > Cc: Thomas

[PATCH v3] drm: document struct drm_mode_fb_cmd2

2022-02-03 Thread Simon Ser
Follow-up for the DRM_IOCTL_MODE_GETFB2 docs. v2: (Daniel Stone) - Replace fourcc.org with drm_fourcc.h because this is the authoritative source and the website may have mismatches. - Drop assumption that offsets will generally be 0. - Mention that unused entries must be zero'ed out. v3:

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-03 Thread Dan Carpenter
On Thu, Feb 03, 2022 at 12:29:11PM +0100, Krzysztof Kozlowski wrote: > On Thu, 3 Feb 2022 at 12:08, Dan Carpenter wrote: > > > > > > This does not look like compliant with GPL-2.0. You cannot call a > > > license GPL-2.0 and restrict it with some other provisions. > > > > That's the MIT license.

[PATCH 7/7] drm/selftests: add drm buddy pathological testcase

2022-02-03 Thread Arunpravin
create a pot-sized mm, then allocate one of each possible order within. This should leave the mm with exactly one page left. Free the largest block, then whittle down again. Eventually we will have a fully 50% fragmented mm. Signed-off-by: Arunpravin ---

  1   2   3   >