Re: [PATCH] drm/amd/display: rewrite the check for mods

2022-11-16 Thread Simon Ser
This breaks the "size" out-parameter.

[PATCH] drm/atomic: add quirks for blind save/restore

2022-11-16 Thread Simon Ser
Two quirks to make blind atomic save/restore [1] work correctly: - Mark the DPMS property as immutable for atomic clients, since atomic clients cannot change it. - Allow user-space to set content protection to "enabled", interpret it as "desired". [1]:

Re: [PATCH] dma-buf: Fix possible UAF in dma_buf_export

2022-11-16 Thread Charan Teja Kalla
Sometime back Dan also reported the same issue[1] where I do mentioned that fput()-->dma_buf_file_release() will remove it from the list. But it seems that I failed to notice fput() here calls the dma_buf_file_release() asynchronously i.e. dmabuf that is accessed in the close path is already

[PATCH] drm/amd/display: rewrite the check for mods

2022-11-16 Thread Jiasheng Jiang
When the *mods is NULL, it should be better to return error immediately, rather than continue with redundant operations. Signed-off-by: Jiasheng Jiang --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

linux-next: build failure after merge of the drm-misc tree

2022-11-16 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (powerpc ppc44x_defconfig) failed like this: ld: drivers/video/fbdev/core/fbmon.o: in function `fb_modesetting_disabled': fbmon.c:(.text+0x1e4): multiple definition of `fb_modesetting_disabled';

[PATCH] drm: bridge: dw_hdmi: fix preference of RGB modes over YUV420

2022-11-16 Thread Guillaume BRUN
Cheap monitors sometimes advertise YUV modes they don't really have (HDMI specification mandates YUV support so even monitors without actual support will often wrongfully advertise it) which results in YUV matches and user forum complaints of a red tint to light colour display areas in common

[PATCH linux-next] drm/panel: Use device_match_of_node()

2022-11-16 Thread ye.xingchen
From: ye xingchen Replace the open-code with device_match_of_node(). Signed-off-by: ye xingchen --- drivers/gpu/drm/drm_panel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c index f634371c717a..ba66ac1ad88a 100644

[PATCH linux-next] drm/imx: Use device_match_of_node()

2022-11-16 Thread ye.xingchen
From: ye xingchen Replace the open-code with device_match_of_node(). Signed-off-by: ye xingchen --- drivers/gpu/drm/imx/imx-drm-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c index

[PATCH linux-next] drm/bridge: Use device_match_of_node()

2022-11-16 Thread ye.xingchen
From: ye xingchen Replace the open-code with device_match_of_node(). Signed-off-by: ye xingchen --- drivers/gpu/drm/drm_bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c index 1545c50fd1c8..4a8cafe2b130

[PATCH] drm: Fix possible UAF in drm_addmap_core

2022-11-16 Thread Yi Yang
smatch report warning as follows: drivers/gpu/drm/drm_bufs.c:365 drm_addmap_core() warn: '>head' not removed from list If drm_map_handle() fails in drm_addmap_core(), the list will be freed, but the list->head will not be removed from dev->maplist, then list traversal may cause UAF. Fix by

[PATCH] drm: bridge: dw_hdmi: fix preference of RGB modes over YUV420

2022-11-16 Thread Guillaume BRUN
Cheap monitors sometimes advertise YUV modes they don't really have (HDMI specification mandates YUV support so even monitors without actual support will often wrongfully advertise it) which results in YUV matches and user forum complaints of a red tint to light colour display areas in common

[PATCH] backlight: pwm_bl: Drop support for legacy PWM probing

2022-11-16 Thread Uwe Kleine-König
There is no in-tree user left which relies on legacy probing. So drop support for it which removes another user of the deprecated pwm_request() function. Signed-off-by: Uwe Kleine-König --- drivers/video/backlight/pwm_bl.c | 12 include/linux/pwm_backlight.h| 1 - 2 files

[PATCH 2/2] drm/amd/display: Remove set but unused variable cursor_bpp

2022-11-16 Thread Jiapeng Chong
Variable cursor_bpp is not effectively used in the function, so delete it. drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_hwseq.c:217:10: warning: variable ‘cursor_bpp’ set but not used. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3120 Reported-by: Abaci Robot Signed-off-by:

[PATCH 1/2] drm/amd/display: Remove set but unused variable 'TPreMargin'

2022-11-16 Thread Jiapeng Chong
Variable TPreMargin is not effectively used in the function, so delete it. drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_util_32.c:3478:10: warning: variable ‘TPreMargin’ set but not used. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3144 Reported-by: Abaci Robot

Re: [Intel-gfx] [PATCH 1/1] drm/i915/mtl: Enable Idle Messaging for GSC CS

2022-11-16 Thread Nilawar, Badal
Hi Rodrigo, On 15-11-2022 20:57, Rodrigo Vivi wrote: On Tue, Nov 15, 2022 at 07:14:40PM +0530, Badal Nilawar wrote: From: Vinay Belgaumkar By defaut idle mesaging is disabled for GSC CS so to unblock RC6 entry on media tile idle messaging need to be enabled. v2: - Fix review comments

Re: [PATCH 0/7] DYNAMIC_DEBUG fixups for rc

2022-11-16 Thread Greg KH
On Fri, Nov 11, 2022 at 03:17:08PM -0700, Jim Cromie wrote: > hi Jason, Greg, DRM-folk, > > drm.debug-on-dyndbg has a regression due to a chicken-&-egg problem; > drm.debug is applied to enable dyndbg callsites before the dependent > modules' callsites are available to be enabled. > > My "fixes"

Re: [PATCH 1/7] drm: mark drm.debug-on-dyndbg as BROKEN for now

2022-11-16 Thread Greg KH
On Fri, Nov 11, 2022 at 03:17:09PM -0700, Jim Cromie wrote: > drm.debug-on-dyndbg has a regression, due to a chicken-egg > initialization problem: > > 1- modprobe i915 >i915 needs drm.ko, which is loaded 1st > > 2- "modprobe drm drm.debug=0x1ff" (virtual/implied) >drm.debug is set

[PATCH] dma-buf: Fix possible UAF in dma_buf_export

2022-11-16 Thread Gaosheng Cui
Smatch report warning as follows: drivers/dma-buf/dma-buf.c:681 dma_buf_export() warn: '>list_node' not removed from list If dma_buf_stats_setup() fails in dma_buf_export(), goto err_sysfs and dmabuf will be freed, but dmabuf->list_node will not be removed from db_list.head, then list

[RFC PATCH v6] media: mediatek: vcodec: support stateless AV1 decoder

2022-11-16 Thread Xiaoyong Lu
Add mediatek av1 decoder linux driver which use the stateless API in MT8195. Signed-off-by: Xiaoyong Lu --- Changes from v5: - change av1 PROFILE and LEVEL cfg - test by av1 fluster, result is 173/239 Changes from v4: - convert vb2_find_timestamp to vb2_find_buffer - test by av1 fluster,

Re: [PATCH v8 03/14] drm: bridge: Generalize Exynos-DSI driver into a Samsung DSIM bridge

2022-11-16 Thread Marek Vasut
On 11/10/22 19:38, Jagan Teki wrote: [...] +static int samsung_dsim_wait_for_hdr_fifo(struct samsung_dsim *dsi) +{ + int timeout = 2000; + + do { + u32 reg = samsung_dsim_read(dsi, DSIM_FIFOCTRL_REG); + + if (!(reg & DSIM_SFR_HEADER_FULL)) Seems that

[PATCH v4] udmabuf: add vmap and vunmap methods to udmabuf_ops

2022-11-16 Thread Lukasz Wiecaszek
The reason behind that patch is associated with videobuf2 subsystem (or more genrally with v4l2 framework) and user created dma buffers (udmabuf). In some circumstances when dealing with V4L2_MEMORY_DMABUF buffers videobuf2 subsystem wants to use dma_buf_vmap() method on the attached dma buffer.

Re: [PATCH v8 06/14] drm: bridge: samsung-dsim: Handle proper DSI host initialization

2022-11-16 Thread Marek Vasut
On 11/10/22 19:38, Jagan Teki wrote: DSI host initialization handling in previous exynos dsi driver has some pitfalls. It initializes the host during host transfer() hook that is indeed not the desired call flow for I2C and any other DSI configured downstream bridges. Host transfer() is usually

[pull] amdgpu, amdkfd drm-fixes-6.1

2022-11-16 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 6.1. The following changes since commit 094226ad94f471a9f19e8f8e7140a09c2625abaa: Linux 6.1-rc5 (2022-11-13 13:12:55 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.1-2022-11-16 for you to

Re: [PATCH] drm/msm/hdmi: remove unnecessary NULL check

2022-11-16 Thread Abhinav Kumar
On 11/15/2022 5:03 AM, Dan Carpenter wrote: This code was refactored in commit 69a88d8633ec ("drm/msm/hdmi: move resource allocation to probe function") and now the "hdmi" pointer can't be NULL. Checking causes a Smatch warning: drivers/gpu/drm/msm/hdmi/hdmi.c:141 msm_hdmi_init()

Re: [PATCH 12/13] drm/scheduler: rework entity flush, kill and fini

2022-11-16 Thread Dmitry Osipenko
Hi, On 10/14/22 11:46, Christian König wrote: > +/* Remove the entity from the scheduler and kill all pending jobs */ > +static void drm_sched_entity_kill(struct drm_sched_entity *entity) > +{ > + struct drm_sched_job *job; > + struct dma_fence *prev; > + > + if (!entity->rq) > +

linux-next: manual merge of the drm tree with Linus' tree

2022-11-16 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/rcar-du/Kconfig between commit: a830a1567859 ("drm: rcar-du: Fix Kconfig dependency between RCAR_DU and RCAR_MIPI_DSI") from Linus' tree and commit: 7a043f978ed1 ("drm: rcar-du: Add RZ/G2L DSI driver")

Re: [PATCH] drm/i915/huc: fix leak of debug object in huc load fence on driver unload

2022-11-16 Thread Brian Norris
Hi Daniele, On Thu, Nov 10, 2022 at 04:56:51PM -0800, Daniele Ceraolo Spurio wrote: > The fence is always initialized in huc_init_early, but the cleanup in > huc_fini is only being run if HuC is enabled. This causes a leaking of > the debug object when HuC is disabled/not supported, which can in

Re: [PATCH mm-unstable v1 12/20] RDMA/siw: remove FOLL_FORCE usage

2022-11-16 Thread Jason Gunthorpe
On Wed, Nov 16, 2022 at 11:26:51AM +0100, David Hildenbrand wrote: > GUP now supports reliable R/O long-term pinning in COW mappings, such > that we break COW early. MAP_SHARED VMAs only use the shared zeropage so > far in one corner case (DAXFS file with holes), which can be ignored > because GUP

Re: [PATCH mm-unstable v1 11/20] RDMA/usnic: remove FOLL_FORCE usage

2022-11-16 Thread Jason Gunthorpe
On Wed, Nov 16, 2022 at 11:26:50AM +0100, David Hildenbrand wrote: > GUP now supports reliable R/O long-term pinning in COW mappings, such > that we break COW early. MAP_SHARED VMAs only use the shared zeropage so > far in one corner case (DAXFS file with holes), which can be ignored > because GUP

Re: [PATCH mm-unstable v1 10/20] RDMA/umem: remove FOLL_FORCE usage

2022-11-16 Thread Jason Gunthorpe
On Wed, Nov 16, 2022 at 11:26:49AM +0100, David Hildenbrand wrote: > GUP now supports reliable R/O long-term pinning in COW mappings, such > that we break COW early. MAP_SHARED VMAs only use the shared zeropage so > far in one corner case (DAXFS file with holes), which can be ignored > because GUP

Re: [PATCH v2 1/4] drm/amdgpu/mst: Stop ignoring error codes and deadlocking

2022-11-16 Thread Lyude Paul
On Wed, 2022-11-16 at 04:39 +, Lin, Wayne wrote: > [Public] > > All the patch set looks good to me. Feel free to add: > Reviewed-by: Wayne Lin > > Again, thank you Lyude for helping on this!!! No problem! I was the one who introduced the bug anyway :P, I'm just glad we were able to fix

[drm-misc:drm-misc-next 8/8] hid-picolcd_leds.c:(.text+0x140): multiple definition of `fb_modesetting_disabled'; drivers/hid/hid-picolcd_core.o:hid-picolcd_core.c:(.text+0x1060): first defined here

2022-11-16 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next head: 330ff5a555869aa0ba3b4c206bf046232e356842 commit: 0ba2fa8cbd29278a180ac90bd66b2c0bbdeacc89 [8/8] fbdev: Add support for the nomodeset kernel parameter config: s390-allmodconfig compiler: s390-linux-gcc (GCC) 12.1.0 reproduce

Re: [pull] amdgpu, amdkfd, radeon drm-next-6.2

2022-11-16 Thread Alex Deucher
On Wed, Nov 16, 2022 at 12:03 AM Dave Airlie wrote: > > arm32 build fails > > /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c: > In function ‘disable_dangling_plane’: >

Re: [PATCH v3] udmabuf: add vmap and vunmap methods to udmabuf_ops

2022-11-16 Thread Lukasz Wiecaszek
On Wed, Nov 16, 2022 at 01:01:46PM +0100, Christian König wrote: > Am 15.11.22 um 21:04 schrieb Lukasz Wiecaszek: > > The reason behind that patch is associated with videobuf2 subsystem > > (or more genrally with v4l2 framework) and user created > > dma buffers (udmabuf). In some circumstances > >

[linux-next:master] BUILD REGRESSION 15f3bff12cf6a888ec2ad39652828c60e6836b3d

2022-11-16 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 15f3bff12cf6a888ec2ad39652828c60e6836b3d Add linux-next specific files for 20221116 Error/Warning reports: https://lore.kernel.org/linux-mm/202210261404.b6ulzg7h-...@intel.com https

[drm-misc:drm-misc-next 8/8] include/linux/fb.h:810:6: warning: no previous prototype for function 'fb_modesetting_disabled'

2022-11-16 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next head: 330ff5a555869aa0ba3b4c206bf046232e356842 commit: 0ba2fa8cbd29278a180ac90bd66b2c0bbdeacc89 [8/8] fbdev: Add support for the nomodeset kernel parameter config: s390-randconfig-r012-20221116 compiler: clang version 16.0.0

[drm-misc:drm-misc-next 8/8] include/linux/fb.h:811: multiple definition of `fb_modesetting_disabled'; drivers/video/fbdev/core/fb_cmdline.o:include/linux/fb.h:811: first defined here

2022-11-16 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next head: 330ff5a555869aa0ba3b4c206bf046232e356842 commit: 0ba2fa8cbd29278a180ac90bd66b2c0bbdeacc89 [8/8] fbdev: Add support for the nomodeset kernel parameter config: s390-defconfig compiler: s390-linux-gcc (GCC) 12.1.0 reproduce

[PATCH v5] drm/mediatek: Add AFBC support to Mediatek DRM driver

2022-11-16 Thread Justin Green
From: Justin Green Tested on MT8195 and confirmed both correct video output and improved DRAM bandwidth performance. v5: * Removed some dead defines. * Refactored mtk_ovl_set_afbc(). v4: * Move modifier validation to format_mod_supported function. * Add modifiers to drm_universal_plane_init()

Re: [PATCH mm-unstable v1 20/20] mm: rename FOLL_FORCE to FOLL_PTRACE

2022-11-16 Thread David Hildenbrand
On 16.11.22 19:16, Linus Torvalds wrote: On Wed, Nov 16, 2022 at 2:30 AM David Hildenbrand wrote: Let's make it clearer that functionality provided by FOLL_FORCE is really only for ptrace access. I'm not super-happy about this one. I do understand the "let's rename the bit so that no new

Re: [RESEND] drm/edid/firmware: stop using a throwaway platform device

2022-11-16 Thread Matthieu CHARETTE
Thank you everyone for your work! Matthieu. On Wed, Nov 16 2022 at 03:32:01 PM +0200, Jani Nikula wrote: On Wed, 16 Nov 2022, Thomas Zimmermann wrote: Hi Am 14.11.22 um 12:17 schrieb Jani Nikula: We've used a temporary platform device for firmware EDID loading since it was introduced

Re: [PATCH mm-unstable v1 20/20] mm: rename FOLL_FORCE to FOLL_PTRACE

2022-11-16 Thread Linus Torvalds
On Wed, Nov 16, 2022 at 2:30 AM David Hildenbrand wrote: > > Let's make it clearer that functionality provided by FOLL_FORCE is > really only for ptrace access. I'm not super-happy about this one. I do understand the "let's rename the bit so that no new user shows up". And it's true that the

Re: [PATCH 1/1] drm/i915/mtl: Enable Idle Messaging for GSC CS

2022-11-16 Thread Belgaumkar, Vinay
On 11/15/2022 5:44 AM, Badal Nilawar wrote: From: Vinay Belgaumkar By defaut idle mesaging is disabled for GSC CS so to unblock RC6 entry on media tile idle messaging need to be enabled. v2: - Fix review comments (Vinay) - Set GSC idle hysterisis to 5 us (Badal) Bspec: 71496 Cc:

Re: [PATCH v1] dt-bindings: display: Convert fsl,imx-fb.txt to dt-schema

2022-11-16 Thread Philipp Zabel
On Thu, Nov 10, 2022 at 10:49:45AM +0100, Uwe Kleine-König wrote: [...] > new file mode 100644 > index ..c3cf6f92a766 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/imx/fsl,imx-lcdc.yaml > @@ -0,0 +1,110 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)

Re: [PATCH] drm/i915/guc: add the GSC CS to the GuC capture list

2022-11-16 Thread Teres Alexis, Alan Previn
I'm assuming that you have verified that the GuC ADS code is calling for the registration of the GSC capture register list accordingly and for the correct tile. That said: Reviewed-by: Alan Previn On Thu, 2022-11-10 at 16:18 -0800, Ceraolo Spurio, Daniele wrote: > For the GSC engine we only

Re: [PATCH v1] dt-bindings: display: Convert fsl,imx-fb.txt to dt-schema

2022-11-16 Thread Rob Herring
On Thu, Nov 10, 2022 at 10:49:45AM +0100, Uwe Kleine-König wrote: > This is a straight forward conversion. Note that fsl,imx-lcdc was picked > as the new name as this is the compatible that should supersede the > legacy fb binding. > > Signed-off-by: Uwe Kleine-König > --- > Hello, > > the

Re: [PATCH 2/2] drm/tests: helpers: Add SPDX header

2022-11-16 Thread Maíra Canal
Hi Maxime, On 11/16/22 12:18, Maxime Ripard wrote: > The SPDX header is missing, let's add it and fix the corresponding > checkpatch warning. > > Suggested-by: Maíra Canal > Fixes: 44a3928324e9 ("drm/tests: Add Kunit Helpers") > Signed-off-by: Maxime Ripard Could you add the

Re: [PATCH 1/2] drm/tests: client: Remove extra blank lines

2022-11-16 Thread Maíra Canal
On 11/16/22 12:18, Maxime Ripard wrote: > Some extra blank lines slipped through, remove them. > > Fixes: 8fc0380f6ba7 ("drm/client: Add some tests for > drm_connector_pick_cmdline_mode()") > Signed-off-by: Maxime Ripard Reviewed-by: Maíra Canal Best Regards, - Maíra Canal > --- >

[PATCH] dt-bindings: msm/dsi: Don't require vdds-supply on 10nm PHY

2022-11-16 Thread Konrad Dybcio
On some SoCs (hello SM6350) vdds-supply is not wired to any smd-rpm or rpmh regulator, but instead powered by the VDD_MX/mx.lvl line, which is voted for in the DSI ctrl node. Signed-off-by: Konrad Dybcio --- Documentation/devicetree/bindings/display/msm/dsi-phy-10nm.yaml | 1 - 1 file changed,

Re: [PATCH v3 05/10] dt-bindings: display: bridge: Add MHDP DP for i.MX8MQ

2022-11-16 Thread Rob Herring
On Tue, Nov 08, 2022 at 09:00:08PM +0800, Sandor Yu wrote: > Add bindings for i.MX8MQ MHDP DisplayPort. > > Signed-off-by: Sandor Yu > --- > .../display/bridge/cdns,mhdp-imx8mq-dp.yaml | 59 +++ > 1 file changed, 59 insertions(+) > create mode 100644 >

Re: [PATCH v3 02/10] dt-bindings: display: bridge: Add MHDP HDMI for i.MX8MQ

2022-11-16 Thread Rob Herring
On Tue, Nov 08, 2022 at 09:00:05PM +0800, Sandor Yu wrote: > Add bindings for i.MX8MQ MHDP HDMI. > > Signed-off-by: Sandor Yu > --- > .../display/bridge/cdns,mhdp-imx8mq-hdmi.yaml | 59 +++ > 1 file changed, 59 insertions(+) > create mode 100644 >

RE: [v1] drm/msm/disp/dpu1: add color management support for the crtc

2022-11-16 Thread Kalyan Thota
>-Original Message- >From: Dmitry Baryshkov >Sent: Wednesday, November 16, 2022 8:37 PM >To: Kalyan Thota ; Kalyan Thota (QUIC) >; dri-devel@lists.freedesktop.org; linux-arm- >m...@vger.kernel.org; freedr...@lists.freedesktop.org; >devicet...@vger.kernel.org >Cc:

[PATCH printk v5 32/40] printk, xen: fbfront: create/use safe function for forcing preferred

2022-11-16 Thread John Ogness
With commit 9e124fe16ff2("xen: Enable console tty by default in domU if it's not a dummy") a hack was implemented to make sure that the tty console remains the console behind the /dev/console device. The main problem with the hack is that, after getting the console pointer to the tty console, it

[PATCH printk v5 00/40] reduce console_lock scope

2022-11-16 Thread John Ogness
This is v5 of a series to prepare for threaded/atomic printing. v4 is here [0]. This series focuses on reducing the scope of the BKL console_lock. It achieves this by switching to SRCU and a dedicated mutex for console list iteration and modification, respectively. The console_lock will no longer

[PATCH 0/7] drm: Fix the color-depth/bpp confusion

2022-11-16 Thread Thomas Zimmermann
A number of drivers mix up the meaning of bits-per-pixel and color depth. For each of them, set the correct values. As a rule of thumb, the color depth is the number of color and alpha bits that affect image composition. The bpp value is the color depth in the pixel plus the filler bits. The

[PATCH 2/7] drm/logicvc: Fix preferred fbdev cpp

2022-11-16 Thread Thomas Zimmermann
Logicvc can have different values for the preferred color depth. Set the fbdev bpp value depending on the runtime value. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/logicvc/logicvc_drm.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git

[PATCH 5/7] drm/simpledrm: Set preferred depth from format of scanout buffer

2022-11-16 Thread Thomas Zimmermann
Set the preferred depth from the format of the scanout buffer. The value cannot be hardcoded, as the scanout buffer's is only known at runtime. Also derive the fbdev emulations bpp value from the scanout format. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tiny/simpledrm.c | 4 ++-- 1

[PATCH 6/7] drm/solomon: Set preferred color depth and bpp to the correct values

2022-11-16 Thread Thomas Zimmermann
Set the preferred color depth to 24 bits and the fbdev bpp to 32 bits. This will signal XRGB as default format to clients. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/solomon/ssd130x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 7/7] drm/fb-helper: Don't use the preferred depth for the BPP default

2022-11-16 Thread Thomas Zimmermann
If no preferred value for bits-per-pixel has been given, fall back to 32. Never use the preferred depth. The color depth is the number of color/alpha bits per pixel, while bpp is the overall number of bits in most cases. Most noteworthy, XRGB has a depth of 24 and a bpp value of 32. Using

[PATCH 3/7] drm/cirrus: Decouple fbdev bpp value from color depth

2022-11-16 Thread Thomas Zimmermann
Cirrus has a preferred color depth of 16 bit; also use it as fbdev bpp value. Don't use the color depth directly. It has a different meaning than bpp and both cannot be used interchangeably. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tiny/cirrus.c | 2 +- 1 file changed, 1

[PATCH 4/7] drm/ofdrm: Set preferred depth from format of scanout buffer

2022-11-16 Thread Thomas Zimmermann
Set the preferred depth from the format of the scanout buffer. The value cannot be hardcoded, as the scanout buffer's is only known at runtime. Keeping the existing switch statement just duplicates the driver's existing logic for format detection. Also remove the FIXME comment from the call to

[PATCH 1/7] drm/hisilicon/hibmc: Fix preferred depth and bpp

2022-11-16 Thread Thomas Zimmermann
Set the preferred color depth to 24 bits and the fbdev bpp to 32 bits. This will signal XRGB as default format to clients. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v2 2/3] drm/msm/disp/dpu1: add helper to know if display is pluggable

2022-11-16 Thread Dmitry Baryshkov
On 16/11/2022 18:35, Abhinav Kumar wrote: On 11/16/2022 7:18 AM, Dmitry Baryshkov wrote: On 16/11/2022 18:11, Abhinav Kumar wrote: On 11/16/2022 7:08 AM, Dmitry Baryshkov wrote: On 16/11/2022 17:30, Kalyan Thota wrote: Since DRM encoder type for few encoders can be similar (like eDP and

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Never return 0 if request wait succeeds

2022-11-16 Thread Janusz Krzysztofik
On Wednesday, 16 November 2022 15:42:46 CET Andrzej Hajda wrote: > On 16.11.2022 12:25, Janusz Krzysztofik wrote: > > According to the docs of i915_request_wait_timeout(), its return value > > "may be zero if the request is unfinished after the timeout expires." > > However, 0 is also returned

Re: [PATCH v3] drm/mediatek: Add AFBC support to Mediatek DRM driver

2022-11-16 Thread Justin Green
Hi Chun-Kuang, > > + mtk_ovl_set_afbc(dev, cmdq_pkt, idx, is_afbc); > > mtk_ddp_write_relaxed(cmdq_pkt, con, >cmdq_reg, ovl->regs, > > DISP_REG_OVL_CON(idx)); > > - mtk_ddp_write_relaxed(cmdq_pkt, pitch, >cmdq_reg, ovl->regs, > > +

Re: [PATCH v2 2/3] drm/msm/disp/dpu1: add helper to know if display is pluggable

2022-11-16 Thread Abhinav Kumar
On 11/16/2022 7:18 AM, Dmitry Baryshkov wrote: On 16/11/2022 18:11, Abhinav Kumar wrote: On 11/16/2022 7:08 AM, Dmitry Baryshkov wrote: On 16/11/2022 17:30, Kalyan Thota wrote: Since DRM encoder type for few encoders can be similar (like eDP and DP) find out if the interface supports HPD

Re: [PATCH 2/3] drm/tests: helpers: Add module infos

2022-11-16 Thread Jani Nikula
On Wed, 16 Nov 2022, Maxime Ripard wrote: > On Wed, Nov 16, 2022 at 01:32:51PM +0200, Jani Nikula wrote: >> On Wed, 16 Nov 2022, Maíra Canal wrote: >> > Hi Maxime, >> > >> > On 11/16/22 06:17, Maxime Ripard wrote: >> >> The MODULE_LICENSE macro is missing from the kunit helpers file, thus >> >>

[PATCH 2/2] drm/tests: helpers: Add SPDX header

2022-11-16 Thread Maxime Ripard
The SPDX header is missing, let's add it and fix the corresponding checkpatch warning. Suggested-by: Maíra Canal Fixes: 44a3928324e9 ("drm/tests: Add Kunit Helpers") Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_kunit_helpers.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH v2 2/3] drm/msm/disp/dpu1: add helper to know if display is pluggable

2022-11-16 Thread Dmitry Baryshkov
On 16/11/2022 18:11, Abhinav Kumar wrote: On 11/16/2022 7:08 AM, Dmitry Baryshkov wrote: On 16/11/2022 17:30, Kalyan Thota wrote: Since DRM encoder type for few encoders can be similar (like eDP and DP) find out if the interface supports HPD from encoder bridge to differentiate between

[PATCH 1/2] drm/tests: client: Remove extra blank lines

2022-11-16 Thread Maxime Ripard
Some extra blank lines slipped through, remove them. Fixes: 8fc0380f6ba7 ("drm/client: Add some tests for drm_connector_pick_cmdline_mode()") Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_client_modeset_test.c | 2 -- 1 file changed, 2 deletions(-) diff --git

Re: (subset) [PATCH 2/3] drm/tests: helpers: Add module infos

2022-11-16 Thread Maxime Ripard
On Wed, 16 Nov 2022 10:17:11 +0100, Maxime Ripard wrote: > The MODULE_LICENSE macro is missing from the kunit helpers file, thus > leading to a build error. > > Let's introduce it along with MODULE_AUTHOR. > > Applied to local tree (tmp). Thanks! Maxime

Re: (subset) [PATCH 1/3] drm/tests: Include helpers header

2022-11-16 Thread Maxime Ripard
On Wed, 16 Nov 2022 10:17:10 +0100, Maxime Ripard wrote: > The kunit helpers code weren't including its header, leading to a > warning that no previous prototype had been defined for public > functions. > > Include the matching header to fix the warning. > > > [...] Applied to local tree

Re: [PATCH 2/3] drm/tests: helpers: Add module infos

2022-11-16 Thread Maxime Ripard
On Wed, Nov 16, 2022 at 01:32:51PM +0200, Jani Nikula wrote: > On Wed, 16 Nov 2022, Maíra Canal wrote: > > Hi Maxime, > > > > On 11/16/22 06:17, Maxime Ripard wrote: > >> The MODULE_LICENSE macro is missing from the kunit helpers file, thus > >> leading to a build error. > >> > >> Let's

Re: [PATCH v2 2/3] drm/msm/disp/dpu1: add helper to know if display is pluggable

2022-11-16 Thread Abhinav Kumar
On 11/16/2022 7:08 AM, Dmitry Baryshkov wrote: On 16/11/2022 17:30, Kalyan Thota wrote: Since DRM encoder type for few encoders can be similar (like eDP and DP) find out if the interface supports HPD from encoder bridge to differentiate between builtin and pluggable displays. Changes in v1:

Re: [PATCH v2 2/3] drm/msm/disp/dpu1: add helper to know if display is pluggable

2022-11-16 Thread Dmitry Baryshkov
On 16/11/2022 17:30, Kalyan Thota wrote: Since DRM encoder type for few encoders can be similar (like eDP and DP) find out if the interface supports HPD from encoder bridge to differentiate between builtin and pluggable displays. Changes in v1: - add connector type in the disp_info (Dmitry) -

Re: [v1] drm/msm/disp/dpu1: add color management support for the crtc

2022-11-16 Thread Dmitry Baryshkov
On 16/11/2022 17:29, Kalyan Thota wrote: -Original Message- From: Dmitry Baryshkov Sent: Saturday, November 12, 2022 4:13 AM To: Kalyan Thota (QUIC) ; dri- de...@lists.freedesktop.org; linux-arm-...@vger.kernel.org; freedr...@lists.freedesktop.org; devicet...@vger.kernel.org Cc:

Re: [PATCH v2 01/12] dt-bindings: display: msm: Add qcom,sm8350-dpu binding

2022-11-16 Thread Rob Herring
On Tue, 15 Nov 2022 14:30:54 +0100, Robert Foss wrote: > Mobile Display Subsystem (MDSS) encapsulates sub-blocks > like DPU display controller, DSI etc. Add YAML schema for DPU device > tree bindings > > Signed-off-by: Robert Foss > --- > .../bindings/display/msm/qcom,sm8350-dpu.yaml | 120

Re: [PATCH v2 2/3] drm/etnaviv: allocate unique ID per drm_file

2022-11-16 Thread Tvrtko Ursulin
On 16/11/2022 13:18, Philipp Zabel wrote: On Fri, Sep 16, 2022 at 05:12:04PM +0200, Lucas Stach wrote: Allows to easily track if several fd are pointing to the same execution context due to being dup'ed. Signed-off-by: Lucas Stach --- drivers/gpu/drm/etnaviv/etnaviv_drv.c | 3 +++

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Never return 0 if request wait succeeds

2022-11-16 Thread Andrzej Hajda
On 16.11.2022 12:25, Janusz Krzysztofik wrote: According to the docs of i915_request_wait_timeout(), its return value "may be zero if the request is unfinished after the timeout expires." However, 0 is also returned when the request is found finished right after the timeout has expired. Since

[Bug 216624] The system freezes when it reaches the screen to ask password for LUKS

2022-11-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216624 --- Comment #13 from The Linux kernel's regression tracker (Thorsten Leemhuis) (regressi...@leemhuis.info) --- FWIW, the nouveau developers might not see this report here, they want bugs filed here:

[PATCH v2 1/3] drm/msm/disp/dpu1: pin 1 crtc to 1 encoder

2022-11-16 Thread Kalyan Thota
Pin each crtc with one encoder. This arrangement will disallow crtc switching between encoders and also will facilitate to advertise certain features on crtc based on encoder type. Changes in v1: - use drm_for_each_encoder macro while iterating through encoder list (Dmitry) Changes in v2: -

[PATCH v2 3/3] drm/msm/disp/dpu1: add color management support for the crtc

2022-11-16 Thread Kalyan Thota
Add color management support for the crtc provided there are enough dspps that can be allocated from the catalog. Changes in v1: - cache color enabled state in the dpu crtc obj (Dmitry) - simplify dspp allocation while creating crtc (Dmitry) - register for color when crtc is created (Dmitry)

[PATCH v2 2/3] drm/msm/disp/dpu1: add helper to know if display is pluggable

2022-11-16 Thread Kalyan Thota
Since DRM encoder type for few encoders can be similar (like eDP and DP) find out if the interface supports HPD from encoder bridge to differentiate between builtin and pluggable displays. Changes in v1: - add connector type in the disp_info (Dmitry) - add helper functions to know encoder type -

[PATCH v2 0/3] add color management support for the crtc

2022-11-16 Thread Kalyan Thota
Add color management support for the crtc provided there are enough dspps that can be allocated from the catalog Kalyan Thota (3): drm/msm/disp/dpu1: pin 1 crtc to 1 encoder drm/msm/disp/dpu1: add helper to know if display is pluggable drm/msm/disp/dpu1: add color management support for the

RE: [v1] drm/msm/disp/dpu1: add color management support for the crtc

2022-11-16 Thread Kalyan Thota
>-Original Message- >From: Dmitry Baryshkov >Sent: Saturday, November 12, 2022 4:13 AM >To: Kalyan Thota (QUIC) ; dri- >de...@lists.freedesktop.org; linux-arm-...@vger.kernel.org; >freedr...@lists.freedesktop.org; devicet...@vger.kernel.org >Cc: linux-ker...@vger.kernel.org;

RE: [v1] drm/msm/disp/dpu1: pin 1 crtc to 1 encoder

2022-11-16 Thread Kalyan Thota
>-Original Message- >From: Dmitry Baryshkov >Sent: Saturday, November 12, 2022 3:51 AM >To: Kalyan Thota (QUIC) ; dri- >de...@lists.freedesktop.org; linux-arm-...@vger.kernel.org; >freedr...@lists.freedesktop.org; devicet...@vger.kernel.org >Cc: linux-ker...@vger.kernel.org;

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Never return 0 on timeout when retiring requests

2022-11-16 Thread Andrzej Hajda
On 16.11.2022 12:25, Janusz Krzysztofik wrote: Users of intel_gt_retire_requests_timeout() expect 0 return value on success. However, we have no protection from passing back 0 potentially returned by dma_fence_wait_timeout() on timeout. Replace 0 with -ETIME before using timeout as return

Re: [PATCH i-g-t 8/8] gputop: Basic vendor agnostic GPU top tool

2022-11-16 Thread Philipp Zabel
On Fr, 2022-11-11 at 15:58 +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Rudimentary vendor agnostic example of how lib_igt_drm_clients can be used > to display a sorted by card and usage list of processes using GPUs. > > Borrows a bit of code from intel_gpu_top but for now omits the

Re: [PATCH 19/26] drm: shmobile: Remove #ifdef guards for PM related functions

2022-11-16 Thread Kieran Bingham
Quoting Paul Cercueil (2022-11-07 17:52:49) > Use the DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr() macros to handle > the .suspend/.resume callbacks. > > These macros allow the suspend and resume functions to be automatically > dropped by the compiler when CONFIG_SUSPEND is disabled, without

Re: [PATCH 17/26] drm: rcar-du: Remove #ifdef guards for PM related functions

2022-11-16 Thread Kieran Bingham
Quoting Paul Cercueil (2022-11-07 17:52:47) > Use the DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr() macros to handle > the .suspend/.resume callbacks. > > These macros allow the suspend and resume functions to be automatically > dropped by the compiler when CONFIG_SUSPEND is disabled, without

Re: [PATCH v2 3/3] drm/etnaviv: export client GPU usage statistics via fdinfo

2022-11-16 Thread Philipp Zabel
On Fri, Sep 16, 2022 at 05:12:05PM +0200, Lucas Stach wrote: > This exposes a accumulated GPU active time per client via the > fdinfo infrastructure. > > Signed-off-by: Lucas Stach > --- > v2: > - fix code style > - switch to raw seq_printf > - leave some breadcrumbs about the output format >

Re: [PATCH] drm/msm/dp: remove limitation of link rate at 5.4G to support HBR3

2022-11-16 Thread Dmitry Baryshkov
On 15/11/2022 21:43, Kuogee Hsieh wrote: On 11/9/2022 11:43 PM, Dmitry Baryshkov wrote: On 10/11/2022 02:47, Kuogee Hsieh wrote: On 11/2/2022 11:04 AM, Dmitry Baryshkov wrote: On 02/11/2022 20:28, Doug Anderson wrote: Hi, On Wed, Nov 2, 2022 at 10:23 AM Dmitry Baryshkov wrote: 1.

Re: [RESEND] drm/edid/firmware: stop using a throwaway platform device

2022-11-16 Thread Jani Nikula
On Wed, 16 Nov 2022, Thomas Zimmermann wrote: > Hi > > Am 14.11.22 um 12:17 schrieb Jani Nikula: >> We've used a temporary platform device for firmware EDID loading since >> it was introduced in commit da0df92b5731 ("drm: allow loading an EDID as >> firmware to override broken monitor"), but

Re: [PATCH v2 2/3] drm/etnaviv: allocate unique ID per drm_file

2022-11-16 Thread Philipp Zabel
On Fri, Sep 16, 2022 at 05:12:04PM +0200, Lucas Stach wrote: > Allows to easily track if several fd are pointing to the same > execution context due to being dup'ed. > > Signed-off-by: Lucas Stach > --- > drivers/gpu/drm/etnaviv/etnaviv_drv.c | 3 +++ > drivers/gpu/drm/etnaviv/etnaviv_drv.h | 1

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Fix negative remaining time after retire requests

2022-11-16 Thread Andrzej Hajda
On 16.11.2022 12:25, Janusz Krzysztofik wrote: Commit b97060a99b01 ("drm/i915/guc: Update intel_gt_wait_for_idle to work with GuC") extended the API of intel_gt_retire_requests_timeout() with an extra argument 'remaining_timeout', intended for passing back unconsumed portion of requested timeout

Re: [Intel-gfx] How is the progress for removing flush_scheduled_work() callers?

2022-11-16 Thread Ville Syrjälä
On Wed, Nov 16, 2022 at 12:08:27PM +0200, Jani Nikula wrote: > On Sun, 06 Nov 2022, Tetsuo Handa wrote: > > Like commit c4f135d643823a86 ("workqueue: Wrap flush_workqueue() using a > > macro") says, flush_scheduled_work() is dangerous and will be forbidden. > > We are on the way for removing all

[PATCH RESEND v4 2/2] gpu: drm: meson: Use devm_regulator_*get_enable*()

2022-11-16 Thread Matti Vaittinen
Simplify using the devm_regulator_get_enable_optional(). Also drop the seemingly unused struct member 'hdmi_supply'. Signed-off-by: Matti Vaittinen --- I am doing a clean-up for my local git and encountered this one. Respinning as it seems this one fell through the cracks. ---

[PATCH RESEND v4 1/2] gpu: drm: sii902x: Use devm_regulator_bulk_get_enable()

2022-11-16 Thread Matti Vaittinen
Simplify using devm_regulator_bulk_get_enable() Signed-off-by: Matti Vaittinen Acked-by: Robert Foss --- I am doing a clean-up for my local git and encountered this one. Respinning as it seems this one fell through the cracks. --- drivers/gpu/drm/bridge/sii902x.c | 26

[PATCH RESEND v4 0/2] Use devm helpers for regulator get and enable

2022-11-16 Thread Matti Vaittinen
Simplify couple of drivers by using the new devm_regulator_*get_enable*() Found these patches when doing some clean-up for my local git. Seems like these two fell through the cracks while other were merged. So, this is a respin of subset of original series v4. These patches were previously

Re: The state of Quantization Range handling

2022-11-16 Thread Pekka Paalanen
On Tue, 15 Nov 2022 00:11:56 +0100 Sebastian Wick wrote: > There are still regular bug reports about monitors (sinks) and sources > disagreeing about the quantization range of the pixel data. In > particular sources sending full range data when the sink expects > limited range. From a user space

Re: [PATCH 1/2] drm/ttm: Clean up page shift operation

2022-11-16 Thread Christian König
Am 16.11.22 um 09:50 schrieb Somalapuram Amaranath: remove page shift operations as ttm_resource moved from num_pages to size_t size in bytes. Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 +--- drivers/gpu/drm/ttm/ttm_range_manager.c| 2 +-

  1   2   >