Re: [PATCH] drm/amd/pm: remove unused num_of_active_display variable

2023-04-11 Thread Alex Deucher
Applied. Thanks! On Sun, Apr 9, 2023 at 8:48 PM Quan, Evan wrote: > > [AMD Official Use Only - General] > > Reviewed-by: Evan Quan > > > -Original Message- > > From: Tom Rix > > Sent: Saturday, April 1, 2023 12:41 AM > > To: Quan, Evan ; Deucher, Alexander > > ; Koenig, Christian > >

Re: [PATCH 1/5] drm/amdgpu: Move a variable assignment behind a null pointer check in amdgpu_ras_interrupt_dispatch()

2023-04-11 Thread Markus Elfring
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c >> @@ -1730,11 +1730,12 @@ int amdgpu_ras_interrupt_dispatch(struct >> amdgpu_device *adev, >>   struct ras_dispatch_if *info) >>   { >>   struct ras_manager *obj = amdgpu_ras_find_obj(adev, >head); >> -    struct ras_ih_data *data =

Re: [PATCH] drm/drm_plane.h: fix grammar of the comment

2023-04-11 Thread Daniel Vetter
On Sun, Apr 09, 2023 at 09:15:47PM +0800, Sui Jingfeng wrote: > From: Sui Jingfeng > > Signed-off-by: Sui Jingfeng Applied to drm-misc-next, thanks > --- > include/drm/drm_plane.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/drm/drm_plane.h

Re: [PATCH 0/2] Add support for dumping error captures via kernel logging

2023-04-11 Thread Rodrigo Vivi
On Mon, Apr 10, 2023 at 12:25:21PM -0700, john.c.harri...@intel.com wrote: > From: John Harrison > > Sometimes, the only effective way to debug an issue is to dump all the > interesting information at the point of failure. So add support for > doing that. No! Please no! We have some of this on

Re: [PATCH v2 1/2] drm: Spelling s/sempahore/semaphore/

2023-04-11 Thread Hamza Mahfooz
On 4/11/23 06:52, Geert Uytterhoeven wrote: Fix misspellings of "semaphore". Signed-off-by: Geert Uytterhoeven Series is Reviewed-by: Hamza Mahfooz --- drivers/gpu/drm/i915/i915_request.c | 2 +- drivers/gpu/drm/radeon/cik.c| 2 +- drivers/gpu/drm/radeon/r600.c | 2 +-

Re: [PATCH v5 2/9] video/aperture: use generic code to figure out the vga default device

2023-04-11 Thread Daniel Vetter
On Fri, Apr 07, 2023 at 10:54:00PM +0200, Helge Deller wrote: > On 4/6/23 15:21, Thomas Zimmermann wrote: > > From: Daniel Vetter > > > > Since vgaarb has been promoted to be a core piece of the pci subsystem > > we don't have to open code random guesses anymore, we actually know > > this in a

Re: [Intel-gfx] [PATCH v4 5/5] drm/i915/gt: Make sure that errors are propagated through request chains

2023-04-11 Thread Rodrigo Vivi
On Tue, Apr 11, 2023 at 08:39:00AM +0200, Das, Nirmoy wrote: > > On 3/8/2023 10:41 AM, Andi Shyti wrote: > > Currently, when we perform operations such as clearing or copying > > large blocks of memory, we generate multiple requests that are > > executed in a chain. > > > > However, if one of

[PATCH] dt-bindings: display/msm: dsi-controller-main: Document qcom, master-dsi and qcom, sync-dual-dsi

2023-04-11 Thread Jianhua Lu
This fixes warning: sm8250-xiaomi-elish-csot.dtb: dsi@ae94000: Unevaluated properties are not allowed ('qcom,master-dsi', 'qcom,sync-dual-dsi' were unexpected) Signed-off-by: Jianhua Lu --- .../bindings/display/msm/dsi-controller-main.yaml| 12 1 file changed, 12

Re: [PATCH] fbmem: Reject FB_ACTIVATE_KD_TEXT from userspace

2023-04-11 Thread Daniel Vetter
On Tue, Apr 11, 2023 at 04:03:24PM +0200, Javier Martinez Canillas wrote: > Daniel Vetter writes: > > > This is an oversight from dc5bdb68b5b3 ("drm/fb-helper: Fix vt > > restore") - I failed to realize that nasty userspace could set this. > > > > It's not pretty to mix up kernel-internal and

Re: [RFC PATCH 00/10] Xe DRM scheduler and long running workload plans

2023-04-11 Thread Daniel Vetter
On Tue, Apr 11, 2023 at 11:02:55AM +0200, Christian König wrote: > The point is that this not only requires some work in the drm_scheduler, but > rather it then makes only little sense to use the drm_scheduler in the first > place. > > The whole point of the drm_scheduler is to provide dma_fence

Re: [PATCH -next] drm/nouveau/disp: make gv100_disp_core_mthd_base static

2023-04-11 Thread Karol Herbst
Reviewed-by: Karol Herbst On Sat, Sep 24, 2022 at 10:00 AM ruanjinjie wrote: > > The symbol is not used outside of the file, so mark it static. > > Fixes the following warning: > > ./drivers/gpu/drm/nouveau/nvkm/engine/disp/gv100.c:591:1: warning: > symbol 'gv100_disp_core_mthd_base' was not

[PATCH] accel/habanalabs: remove variable gaudi_irq_name

2023-04-11 Thread Tom Rix
gcc with W=1 reports drivers/accel/habanalabs/gaudi/gaudi.c:117:19: error: ‘gaudi_irq_name’ defined but not used [-Werror=unused-const-variable=] 117 | static const char gaudi_irq_name[GAUDI_MSI_ENTRIES][GAUDI_MAX_STRING_LEN] = { | ^~ This variable is not

Re: [RFC PATCH 00/10] Xe DRM scheduler and long running workload plans

2023-04-11 Thread Daniel Vetter
On Sat, Apr 08, 2023 at 04:05:20PM +0900, Asahi Lina wrote: > On 04/04/2023 10.58, Matthew Brost wrote: > > On Tue, Apr 04, 2023 at 10:07:48AM +0900, Asahi Lina wrote: > > > Hi, thanks for the Cc! > > > > > > > No problem. > > > > > On 04/04/2023 09.22, Matthew Brost wrote: > > > > Hello, > > >

Re: [PATCH] drm/nouveau/mc/ga100: make ga100_mc_device static

2023-04-11 Thread Karol Herbst
Reviewed-by: Karol Herbst On Thu, Dec 29, 2022 at 4:52 PM Ben Dooks wrote: > > Make ga100_mc_device static as it isn't exported, to > fix the following sparse warning: > > drivers/gpu/drm/nouveau/nvkm/subdev/mc/ga100.c:51:1: warning: symbol > 'ga100_mc_device' was not declared. Should it be

Re: [PATCH] fbmem: Reject FB_ACTIVATE_KD_TEXT from userspace

2023-04-11 Thread Javier Martinez Canillas
Daniel Vetter writes: > This is an oversight from dc5bdb68b5b3 ("drm/fb-helper: Fix vt > restore") - I failed to realize that nasty userspace could set this. > > It's not pretty to mix up kernel-internal and userspace uapi flags > like this, but since the entire fb_var_screeninfo structure is

Patch "drm/display/dp_mst: Handle old/new payload states in drm_dp_remove_payload()" has been added to the 6.1-stable tree

2023-04-11 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/display/dp_mst: Handle old/new payload states in drm_dp_remove_payload() to the 6.1-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename

Re: [PATCH 1/5] drm/amdgpu: Move a variable assignment behind a null pointer check in amdgpu_ras_interrupt_dispatch()

2023-04-11 Thread Felix Kuehling
Am 2023-04-11 um 09:42 schrieb Markus Elfring: Date: Tue, 11 Apr 2023 10:52:48 +0200 The address of a data structure member was determined before a corresponding null pointer check in the implementation of the function “amdgpu_ras_interrupt_dispatch”. Thus avoid the risk for undefined

Re: [PATCH] fbmem: Reject FB_ACTIVATE_KD_TEXT from userspace

2023-04-11 Thread Maarten Lankhorst
On 2023-04-11 15:44, Daniel Vetter wrote: On Tue, Apr 04, 2023 at 09:39:34PM +0200, Daniel Vetter wrote: This is an oversight from dc5bdb68b5b3 ("drm/fb-helper: Fix vt restore") - I failed to realize that nasty userspace could set this. It's not pretty to mix up kernel-internal and userspace

[PATCH 5/5] drm/amd/display: Move an expression into a return statement in dcn201_link_encoder_create()

2023-04-11 Thread Markus Elfring
Date: Tue, 11 Apr 2023 14:04:57 +0200 The address of a data structure member was determined before a corresponding null pointer check in the implementation of the function “dcn201_link_encoder_create”. Thus avoid the risk for undefined behaviour by moving the usage of an expression into a return

[PATCH 4/5] drm/amd/display: Delete a redundant statement in trigger_hotplug()

2023-04-11 Thread Markus Elfring
Date: Tue, 11 Apr 2023 13:26:35 +0200 An immediate return is performed by this function after a null pointer was detected for the member “dc_link” in the data structure “amdgpu_dm_connector”. This check was repeated within one if branch. Thus omit such a redundant statement. Signed-off-by:

[PATCH 3/5] drm/amd/display: Delete three unnecessary variable initialisations in trigger_hotplug()

2023-04-11 Thread Markus Elfring
Date: Tue, 11 Apr 2023 12:34:42 +0200 The variables “link”, “wr_buf” and “ret” will eventually be set to appropriate values a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 6

Re: [PATCH RESEND v3 2/3] drm/ttm: Reduce the number of used allocation orders for TTM pages

2023-04-11 Thread Daniel Vetter
On Tue, Apr 11, 2023 at 02:11:18PM +0200, Christian König wrote: > Am 11.04.23 um 11:51 schrieb Daniel Vetter: > > On Tue, Apr 04, 2023 at 10:06:49PM +0200, Thomas Hellström wrote: > > > When swapping out, we will split multi-order pages both in order to > > > move them to the swap-cache and to be

Re: [PATCH] fbmem: Reject FB_ACTIVATE_KD_TEXT from userspace

2023-04-11 Thread Daniel Vetter
On Tue, Apr 04, 2023 at 09:39:34PM +0200, Daniel Vetter wrote: > This is an oversight from dc5bdb68b5b3 ("drm/fb-helper: Fix vt > restore") - I failed to realize that nasty userspace could set this. > > It's not pretty to mix up kernel-internal and userspace uapi flags > like this, but since the

[PATCH 2/5] drm/amd/display: Move three variable assignments behind condition checks in trigger_hotplug()

2023-04-11 Thread Markus Elfring
Date: Tue, 11 Apr 2023 11:39:02 +0200 The address of a data structure member was determined before a corresponding null pointer check in the implementation of the function “trigger_hotplug”. Thus avoid the risk for undefined behaviour by moving the assignment for three local variables behind

[PATCH 0/5] drm/amd: Adjustments for three function implementations

2023-04-11 Thread Markus Elfring
Date: Tue, 11 Apr 2023 14:36:36 +0200 Some update suggestions were taken into account from static source code analysis. Markus Elfring (5) amdgpu: Move a variable assignment behind a null pointer check in amdgpu_ras_interrupt_dispatch() display: Move three variable assignments behind

[PATCH 1/5] drm/amdgpu: Move a variable assignment behind a null pointer check in amdgpu_ras_interrupt_dispatch()

2023-04-11 Thread Markus Elfring
Date: Tue, 11 Apr 2023 10:52:48 +0200 The address of a data structure member was determined before a corresponding null pointer check in the implementation of the function “amdgpu_ras_interrupt_dispatch”. Thus avoid the risk for undefined behaviour by moving the assignment for the variable

Re: [PATCH v3 28/65] clk: renesas: r9a06g032: Add a determine_rate hook

2023-04-11 Thread Miquel Raynal
Hi Geert & Maxime, ge...@linux-m68k.org wrote on Tue, 11 Apr 2023 12:27:38 +0200: > CC Gareth, Hervé, Miquel, Ralph > > On Tue, Apr 4, 2023 at 2:44 PM Maxime Ripard wrote: > > The Renesas r9a06g032 bitselect clock implements a mux with a set_parent > > hook, but doesn't provide a

Re: (subset) [PATCH] drm/vc4: remove unused render_wait variable

2023-04-11 Thread Maxime Ripard
On Thu, 06 Apr 2023 11:12:03 -0400, Tom Rix wrote: > smatch reports > drivers/gpu/drm/vc4/vc4_irq.c:60:1: warning: symbol > 'render_wait' was not declared. Should it be static? > > This variable is not used so remove it. > > > [...] Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: [PATCH v2] drm/vkms: add module parameter to set background color

2023-04-11 Thread Maíra Canal
On 4/11/23 05:58, Simon Ser wrote: Hi, On Monday, April 10th, 2023 at 19:50, Melissa Wen wrote: On 04/10, Simon Ser wrote: I think this should be a KMS property instead of a module parameter. Is there a reason why this patch uses a module parameter? It breaks user-space expectations. a

Re: [PATCH v10 2/2] drm: add kms driver for loongson display controller

2023-04-11 Thread Sui Jingfeng
Hi, On 2023/4/4 22:10, Emil Velikov wrote: +++ b/drivers/gpu/drm/loongson/lsdc_drv.h @@ -0,0 +1,324 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Copyright (C) 2022 Loongson Corporation + * We're in 2023, update the year across the files? OK, it just that we started to upstream this

Re: [PATCH RESEND v3 2/3] drm/ttm: Reduce the number of used allocation orders for TTM pages

2023-04-11 Thread Christian König
Am 11.04.23 um 11:51 schrieb Daniel Vetter: On Tue, Apr 04, 2023 at 10:06:49PM +0200, Thomas Hellström wrote: When swapping out, we will split multi-order pages both in order to move them to the swap-cache and to be able to return memory to the swap cache as soon as possible on a page-by-page

[PATCH v7 8/8] arm64: dts: renesas: rzg2lc-smarc: Enable DU and link with DSI

2023-04-11 Thread Biju Das
Enable DU on RZ/G2LC SMARC EVK by linking with DSI. Signed-off-by: Biju Das --- v7: * New patch. --- arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi | 21 +++ 1 file changed, 21 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi

[PATCH v7 7/8] arm64: dts: renesas: rzg2l-smarc: Enable DU and link with DSI

2023-04-11 Thread Biju Das
Enable DU and link with DSI on RZ/{G2L,V2L} SMARC EVK. Signed-off-by: Biju Das --- arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi | 21 1 file changed, 21 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi b/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi

[PATCH v7 6/8] arm64: dts: renesas: r9a07g054: Add DU node

2023-04-11 Thread Biju Das
Add DU node to RZ/V2L SoC DTSI. Signed-off-by: Biju Das --- v7: * New patch. --- arch/arm64/boot/dts/renesas/r9a07g054.dtsi | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r9a07g054.dtsi b/arch/arm64/boot/dts/renesas/r9a07g054.dtsi index

[PATCH v7 5/8] arm64: dts: renesas: r9a07g044: Add DU node

2023-04-11 Thread Biju Das
Add DU node to RZ/G2L SoC DTSI. Signed-off-by: Biju Das --- v7: * New patch. --- arch/arm64/boot/dts/renesas/r9a07g044.dtsi | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi index

[PATCH v7 4/8] drm: rzg2l-du: Add RZ/V2L DU Support

2023-04-11 Thread Biju Das
Add support for RZ/V2L DU. The RZ/V2L DU block is identical to RZ/G2L SoC. Signed-off-by: Biju Das --- v7: * New patch. --- drivers/gpu/drm/rcar-du/rzg2l_du_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/rcar-du/rzg2l_du_drv.c

[PATCH v7 3/8] drm: rcar-du: Add RZ/G2L DU Support

2023-04-11 Thread Biju Das
The LCD controller is composed of Frame Compression Processor (FCPVD), Video Signal Processor (VSPD), and Display Unit (DU). It has DPI/DSI interfaces and supports a maximum resolution of 1080p along with 2 RPFs to support the blending of two picture layers and raster operations (ROPs). The DU

[PATCH v7 2/8] dt-bindings: display: renesas, rzg2l-du: Document RZ/V2L DU bindings

2023-04-11 Thread Biju Das
Document DU found in RZ/V2L SoC. The DU block is identical to RZ/G2L SoC and therefore use RZ/G2L fallback to avoid any driver changes. Signed-off-by: Biju Das --- v7: * New patch. --- .../devicetree/bindings/display/renesas,rzg2l-du.yaml| 9 +++-- 1 file changed, 7 insertions(+), 2

[PATCH v7 0/8] Add RZ/{G2L,G2LC} and RZ/V2L DU support

2023-04-11 Thread Biju Das
RZ/G2L LCD controller composed of Frame compression Processor(FCPVD), Video signal processor (VSPD) and Display unit(DU). The output of LCDC is connected to Display parallel interface and MIPI link video interface. The output from DSI is connected to ADV7535. Created new CRTC/DRM driver

[PATCH v7 1/8] dt-bindings: display: Document Renesas RZ/G2L DU bindings

2023-04-11 Thread Biju Das
The RZ/G2L LCD controller is composed of Frame Compression Processor (FCPVD), Video Signal Processor (VSPD), and Display Unit (DU). The DU module supports the following hardware features − Display Parallel Interface (DPI) and MIPI LINK Video Interface − Display timing master − Generates video

[PATCH v7 17/17] drm: rcar-du: Add rcar_du_lib_vsps_init()

2023-04-11 Thread Biju Das
Add rcar_du_lib_vsps_init() to RCar DU kms lib to handle both rcar_du_vsp_init() and rzg2l_du_vsp_init(). Signed-off-by: Biju Das --- v6->v7: * Rebased to drm-tip. v1->v6: * Rebased on drm-misc-next and DU-next. v1: * Created the lib suggested by Laurent. Ref:

[PATCH v7 15/17] drm: rcar-du: Move rcar_du_encoders_init()

2023-04-11 Thread Biju Das
RZ/G2L supports only DSI and DPI. Add rcar_du_encoders_init() to handle the pointer to du_output_name(), so that we can share du_encoders_init() between RCar and RZ/G2L kms drivers. Signed-off-by: Biju Das --- v6->v7: * Rebased to drm-tip. v1->v6: * Rebased on drm-misc-next and DU-next. v1: *

[PATCH v7 16/17] drm: rcar-du: Move rcar_du_properties_init()

2023-04-11 Thread Biju Das
Move rcar_du_properties_init() to RCar DU kms lib, so that it can be shared by both RCar and RZ/G2L kms drivers. Signed-off-by: Biju Das --- v6->v7: * Rebased to drm-tip. v1->v6: * Rebased on drm-misc-next and DU-next. v1: * Created the lib suggested by Laurent. Ref:

[PATCH v7 14/17] drm: rcar-du: Add rcar_du_lib_mode_cfg_helper_get()

2023-04-11 Thread Biju Das
Add rcar_du_lib_mode_cfg_helper_get() in RCar DU kms lib to get the pointer to rcar_du_mode_config_helper, so that both rcar_du_atomic_ commit_tail() and rcar_du_mode_config_helper can be reused by rcar_du_modeset_init() and rzg2l_du_modeset_init(). Signed-off-by: Biju Das --- v6->v7: * Rebased

[PATCH v7 13/17] drm: rcar-du: Add rcar_du_lib_fb_create()

2023-04-11 Thread Biju Das
Move the common code from rcar_du_fb_create->rcar_du_lib_fb_create, so that rzg2l_du_fb_create() can reuse the common code. Signed-off-by: Biju Das --- v6->v7: * Rebased to drm-tip. v1->v6: * Rebased on drm-misc-next and DU-next. v1: * Created the lib suggested by Laurent. Ref:

[PATCH v7 12/17] drm: rcar-du: Move rcar_du_vsp_plane_atomic_update()

2023-04-11 Thread Biju Das
Move rcar_du_vsp_plane_atomic_update() to RCar DU vsp lib so that both RCar and RZ/G2L DU vsp drivers can share this function. Signed-off-by: Biju Das --- v6->v7: * Rebased to drm-tip. v1->v6: * Rebased on drm-misc-next and DU-next. v1: * Created the lib suggested by Laurent. Ref:

[PATCH v7 11/17] drm: rcar-du: Move rcar_du_vsp_plane_cleanup_fb()

2023-04-11 Thread Biju Das
Move rcar_du_vsp_plane_cleanup_fb() to RCar DU vsp lib so that it can be shared by both RCar and RZ/G2L DU vsp drivers. Signed-off-by: Biju Das --- v6->v7: * Rebased to drm-tip. v1->v6: * Rebased on drm-misc-next and DU-next. v1: * Created the lib suggested by Laurent. Ref:

[PATCH v7 10/17] drm: rcar-du: Move rcar_du_vsp_plane_prepare_fb()

2023-04-11 Thread Biju Das
Move rcar_du_vsp_plane_prepare_fb() to RCar DU vsp lib so that both RCar and RZ/G2L DU vsp drivers can share this function. Signed-off-by: Biju Das --- v6->v7: * Rebased to drm-tip. v1->v6: * Rebased on drm-misc-next and DU-next. v1: * Created the lib suggested by Laurent. Ref:

[PATCH v7 09/17] drm: rcar-du: Add rcar_du_lib_vsp_init()

2023-04-11 Thread Biju Das
RZ/G2L does not have plane registers as well as it uses different CRTC. The below functions are SoC specific * rcar_du_crtc_finish_page_flip() * __rcar_du_plane_setup * __rcar_du_plane_atomic_check All other function can be handled in common code. This patch introduces rcar_du_lib_vsp_init() to

[PATCH v7 08/17] drm: rcar-du: Move rcar_du_gem_prime_import_sg_table()

2023-04-11 Thread Biju Das
Move rcar_du_gem_prime_import_sg_table() to RCar DU KMS lib. Signed-off-by: Biju Das --- v6->v7: * Rebased to drm-tip. v1->v6: * Rebased on drm-misc-next and DU-next. v1: * Created the lib suggested by Laurent. Ref:

[PATCH v7 07/17] drm: rcar-du: Move rcar_du_dumb_create()

2023-04-11 Thread Biju Das
Move rcar_du_dumb_create() to RCar DU KMS lib. Signed-off-by: Biju Das --- v6->v7: * Rebased to drm-tip. v1->v6: * Rebased on drm-misc-next and DU-next. v1: * Created the lib suggested by Laurent. Ref:

[PATCH v7 06/17] drm: rcar-du: Move rcar_du_vsp_{map,unmap}_fb()

2023-04-11 Thread Biju Das
Move rcar_du_vsp_{map,unmap}_fb() to RCar DU VSP lib. Signed-off-by: Biju Das --- v6->v7: * Rebased to drm-tip. v1->v6: * Rebased on drm-misc-next and DU-next. v1: * Created the lib suggested by Laurent. Ref:

[PATCH v7 05/17] drm: rcar-du: Move rcar_du_vsp_atomic_flush()

2023-04-11 Thread Biju Das
Move rcar_du_vsp_atomic_flush() to RCar DU vsp lib. Signed-off-by: Biju Das --- v6->v7: * Rebased to drm-tip. v1->v6: * Rebased on drm-misc-next and DU-next. v1: * Created the lib suggested by Laurent. Ref:

[PATCH v7 04/17] drm: rcar-du: Move rcar_du_vsp_atomic_begin()

2023-04-11 Thread Biju Das
Move rcar_du_vsp_atomic_begin() to RCar DU VSP lib. Signed-off-by: Biju Das --- v6->v7: * Rebased to drm-tip. v1->v6: * Rebased on drm-misc-next and DU-next. v1: * Created the lib suggested by Laurent. Ref:

[PATCH v7 03/17] drm: rcar-du: Add vsp lib support

2023-04-11 Thread Biju Das
Add RCar DU vsp lib support by moving rcar_du_vsp_disable() to the lib file so that same function can be used by both RCar and RZ/G2L DU VSP drivers. Signed-off-by: Biju Das --- v6->v7: * Rebased to drm-tip. v1->v6: * Rebased on drm-misc-next and DU-next. v1: * Created the lib suggested by

[PATCH v7 02/17] drm: rcar-du: Add kms lib support

2023-04-11 Thread Biju Das
Add RCar DU kms lib support for sharing the common code between RCar and RZ/G2L DU KMS drivers by moving rcar_du_format_infos table and rcar_du_format_infos() to the lib file. Signed-off-by: Biju Das --- v6->v7: * Rebased to drm-tip. v1->v6: * Rebased on drm-misc-next and DU-next. v1: *

[PATCH v7 01/17] drm: rcar-du: Add encoder lib support

2023-04-11 Thread Biju Das
Add RCar DU encoder lib support by moving rcar_du_encoder_count_ports() and rcar_du_encoder_funcs to the lib file and added rcar_du_lib_encoder_init() to share the common code between RCar and RZ/G2L DU encoder drivers. Signed-off-by: Biju Das --- v6->v7: * Rebased to drm-tip. v5->v6: *

[PATCH v7 00/17] Add RCar DU lib support

2023-04-11 Thread Biju Das
The DU controller on RZ/G2L LCDC is similar to R-Car as it is connected to VSPD. RCar DU lib is created for sharing kms, vsp and encoder driver code between both RCar and RZ/G2L alike SoCs. Tested this patch series on RZ/{G2M, G2L, G2LC} and RZ/V2L platforms. v6->v7: * Split DU lib and RZ/G2L

Re: [PATCH v5 3/3] drm/virtio: Support sync objects

2023-04-11 Thread Emil Velikov
Hi Dmitry, On Sun, 9 Apr 2023 at 13:40, Dmitry Osipenko wrote: > +static void virtio_gpu_free_syncobjs(struct drm_syncobj **syncobjs, > +uint32_t nr_syncobjs) > +{ > + uint32_t i = nr_syncobjs; > + > + while (i--) { > + if

Re: [PATCH 2/2] drm: Spelling s/randevouz/rendez-vouz/

2023-04-11 Thread Geert Uytterhoeven
Hi Marc, On Tue, Apr 11, 2023 at 12:49 PM Marc Dionne wrote: > On Tue, Apr 11, 2023 at 7:44 AM Geert Uytterhoeven > wrote: > > > > Fix a misspelling of "rendez-vouz". > > > > Signed-off-by: Geert Uytterhoeven > > --- a/include/drm/task_barrier.h > > +++ b/include/drm/task_barrier.h > > @@

[PATCH v2 2/2] drm: Spelling s/randevouz/rendez-vous/

2023-04-11 Thread Geert Uytterhoeven
Fix a misspelling of "rendez-vous". Signed-off-by: Geert Uytterhoeven --- v2: - s/vouz/vous/. --- include/drm/task_barrier.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/task_barrier.h b/include/drm/task_barrier.h index 217c1cf21c1ab7d5..f6e6ed52968133d2

[PATCH v2 1/2] drm: Spelling s/sempahore/semaphore/

2023-04-11 Thread Geert Uytterhoeven
Fix misspellings of "semaphore". Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/i915/i915_request.c | 2 +- drivers/gpu/drm/radeon/cik.c| 2 +- drivers/gpu/drm/radeon/r600.c | 2 +- include/drm/task_barrier.h | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)

Re: [PATCH v5 4/4] drm/msm/dpu: use CTL_SC7280_MASK for sm8450's ctl_0

2023-04-11 Thread Dmitry Baryshkov
On 11/04/2023 03:57, Abhinav Kumar wrote: On 4/7/2023 5:27 PM, Dmitry Baryshkov wrote: On sm8450 platform the CTL_0 doesn't differ from the rest of CTL blocks, so switch it to CTL_SC7280_MASK too. Some background: original commit 100d7ef6995d ("drm/msm/dpu: add support for SM8450") had all

Re: [PATCH v10 2/2] drm: add kms driver for loongson display controller

2023-04-11 Thread Sui Jingfeng
Hi, On 2023/4/4 22:10, Emil Velikov wrote: +static const struct dev_pm_ops lsdc_pm_ops = { + .suspend = lsdc_pm_suspend, + .resume = lsdc_pm_resume, + .freeze = lsdc_pm_freeze, + .thaw = lsdc_pm_thaw, + .poweroff = lsdc_pm_freeze, + .restore = lsdc_pm_resume,

Re: [PATCH v2 1/2] drm: Add fdinfo memory stats

2023-04-11 Thread Daniel Vetter
On Mon, Apr 10, 2023 at 02:06:06PM -0700, Rob Clark wrote: > From: Rob Clark > > Add a helper to dump memory stats to fdinfo. For the things the drm > core isn't aware of, use a callback. > > v2: Fix typos, change size units to match docs, use div_u64 > > Signed-off-by: Rob Clark >

Re: linux-next: build failure after merge of the driver-core tree

2023-04-11 Thread Greg KH
On Tue, Apr 11, 2023 at 11:55:20AM +0200, Daniel Vetter wrote: > On Tue, Apr 11, 2023 at 02:38:12PM +1000, Stephen Rothwell wrote: > > Hi all, > > > > After merging the driver-core tree, today's linux-next build (x86_64 > > allmodconfig) failed like this: > > > > In file included from

Re: [PATCH v2] drm/vkms: add module parameter to set background color

2023-04-11 Thread Daniel Vetter
On Tue, Apr 11, 2023 at 08:58:16AM +, Simon Ser wrote: > Hi, > > On Monday, April 10th, 2023 at 19:50, Melissa Wen wrote: > > > On 04/10, Simon Ser wrote: > > > > > I think this should be a KMS property instead of a module parameter. > > > Is there a reason why this patch uses a module

Re: [GIT PULL] mediatek drm next for 6.4

2023-04-11 Thread Daniel Vetter
On Mon, Apr 10, 2023 at 11:30:05PM +, Chun-Kuang Hu wrote: > Hi, Dave & Daniel: > > This includes: > > 1. Add support for 10-bit overlays > 2. Add MediaTek SoC DRM (vdosys1) support for mt8195 > 3. Change mmsys compatible for mt8195 mediatek-drm > 4. Only trigger DRM HPD events if bridge is

Re: [PATCH v3 1/2] drm/mediatek: Add mdp_rdma get format function

2023-04-11 Thread Daniel Vetter
On Thu, Mar 30, 2023 at 11:26:13AM +0800, Nancy.Lin wrote: > Add mdp_rdma get_format and get_num_formats function. > > Signed-off-by: Nancy.Lin The mtk get_formats stuff seems like a lot of midlayering for not much reasons? Is that really needed? Just a drive-by questions I had while merging

Re: [PATCH v3 28/65] clk: renesas: r9a06g032: Add a determine_rate hook

2023-04-11 Thread Geert Uytterhoeven
CC Gareth, Hervé, Miquel, Ralph On Tue, Apr 4, 2023 at 2:44 PM Maxime Ripard wrote: > The Renesas r9a06g032 bitselect clock implements a mux with a set_parent > hook, but doesn't provide a determine_rate implementation. > > This is a bit odd, since set_parent() is there to, as its name implies,

Re: [pull] drm/msm: drm-msm-next-2023-04-10 for v6.4

2023-04-11 Thread Daniel Vetter
On Mon, Apr 10, 2023 at 07:50:50AM -0700, Rob Clark wrote: > Hi Dave, > > This is the main pull for v6.4, see below for description. A bit big > this time because of (1) generated header updates and (2) dpu hw > catelog rework which split the increasingly unwieldy > big-giant-file-of-tables into

Re: [PATCH v10 2/2] drm: add kms driver for loongson display controller

2023-04-11 Thread Sui Jingfeng
Hi, On 2023/4/4 22:10, Emil Velikov wrote: +static enum drm_mode_status +lsdc_mode_config_mode_valid(struct drm_device *ddev, + const struct drm_display_mode *mode) +{ + struct lsdc_device *ldev = to_lsdc(ddev); + const struct drm_format_info *info =

[PATCH 1/2] drm: Spelling s/sempahore/semaphore/

2023-04-11 Thread Geert Uytterhoeven
Fix misspellings of "semaphore". Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/i915/i915_request.c | 2 +- drivers/gpu/drm/radeon/cik.c| 2 +- drivers/gpu/drm/radeon/r600.c | 2 +- include/drm/task_barrier.h | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)

[PATCH 2/2] drm: Spelling s/randevouz/rendez-vouz/

2023-04-11 Thread Geert Uytterhoeven
Fix a misspelling of "rendez-vouz". Signed-off-by: Geert Uytterhoeven --- include/drm/task_barrier.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/task_barrier.h b/include/drm/task_barrier.h index 217c1cf21c1ab7d5..59ead429acb2afb0 100644 ---

[PATCH v2 1/8] arm64: dts: renesas: r9a07g044: Add fcpvd node

2023-04-11 Thread Biju Das
Add fcpvd node to RZ/G2L SoC DTSI. Signed-off-by: Biju Das Reviewed-by: Geert Uytterhoeven --- v1->v2: * Added Rb tag from Geert. --- arch/arm64/boot/dts/renesas/r9a07g044.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi

[PATCH v2 0/8] Enable DSI and ADV7535 on RZ/G2{L, LC} and RZ/V2L platforms

2023-04-11 Thread Biju Das
This patch series aims to Enable DSI by linking with ADV7535 on SMARC EVK based on RZ/G2{L, LC} and RZ/V2L platforms. patch#1 and #2 depend upon the binding patch [1] [1] https://patchwork.kernel.org/project/linux-renesas-soc/patch/20230406171324.837247-1-biju.das...@bp.renesas.com/ patch #4

Re: [git pull] habanalabs for drm-next-6.4

2023-04-11 Thread Daniel Vetter
On Mon, Apr 10, 2023 at 03:46:37PM +0300, Oded Gabbay wrote: > Hi Dave, Daniel. > > An additional pull request for 6.4. > > Mostly bug fixes and cleanups. > > Full details are in the signed tag. > > Thanks, > Oded > > The following changes since commit

Re: linux-next: build failure after merge of the driver-core tree

2023-04-11 Thread Daniel Vetter
On Tue, Apr 11, 2023 at 02:38:12PM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the driver-core tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > In file included from include/linux/linkage.h:7, > from include/linux/kernel.h:17, >

Re: [PATCH RESEND v3 2/3] drm/ttm: Reduce the number of used allocation orders for TTM pages

2023-04-11 Thread Daniel Vetter
On Tue, Apr 04, 2023 at 10:06:49PM +0200, Thomas Hellström wrote: > When swapping out, we will split multi-order pages both in order to > move them to the swap-cache and to be able to return memory to the > swap cache as soon as possible on a page-by-page basis. > Reduce the page max order to the

Re: linux-next: build warning after merge of the drm tree

2023-04-11 Thread Andi Shyti
Hi Stephen, On Tue, Apr 11, 2023 at 04:02:36PM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the drm tree, today's linux-next build (htmldocs) > produced this warning: > > drivers/gpu/drm/i915/gt/uc/intel_guc.h:274: warning: Function parameter or > member 'dbgfs_node' not

Re: [PATCH RESEND v2 0/2] panel-simple: Add InnoLux G070ACE-L01 support

2023-04-11 Thread Richard Leitner
On Mon, Mar 13, 2023 at 08:50:15AM +0100, richard.leit...@linux.dev wrote: > This series adds support for the InnoLux G070ACE-L01 7" 800x480 TFT LCD > panel with WLED backlight. Friendly reminder for this small series  > > Signed-off-by: Richard Leitner > --- > Richard Leitner (2): >

Re: [PATCH 1/2] drm/i915: constify pointers to hwmon_channel_info

2023-04-11 Thread Jani Nikula
On Fri, 07 Apr 2023, Krzysztof Kozlowski wrote: > Statically allocated array of pointed to hwmon_channel_info can be made > const for safety. > > Signed-off-by: Krzysztof Kozlowski > > --- > > This depends on hwmon core patch: >

Re: [PATCH] fbdev: Don't spam dmesg on bad userspace ioctl input

2023-04-11 Thread Geert Uytterhoeven
Hi Michel, On Wed, Apr 5, 2023 at 10:50 AM Michel Dänzer wrote: > On 4/4/23 14:36, Daniel Vetter wrote: > > There's a few reasons the kernel should not spam dmesg on bad > > userspace ioctl input: > > - at warning level it results in CI false positives > > - it allows userspace to drown dmesg

Re: [PATCH 2/2] drm/nouveau/kms: Add INHERIT ioctl to nvkm/nvif for reading IOR state

2023-04-11 Thread Dan Carpenter
Hi Lyude, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Lyude-Paul/drm-nouveau-kms-Add-INHERIT-ioctl-to-nvkm-nvif-for-reading-IOR-state/20230408-062329 base:

Re: [RFC PATCH 00/10] Xe DRM scheduler and long running workload plans

2023-04-11 Thread Christian König
The point is that this not only requires some work in the drm_scheduler, but rather it then makes only little sense to use the drm_scheduler in the first place. The whole point of the drm_scheduler is to provide dma_fence implementation for the submitted jobs. We also have dependency

Re: [Intel-gfx] [PATCH v4 1/5] drm/i915: Throttle for ringspace prior to taking the timeline mutex

2023-04-11 Thread Andrzej Hajda
On 08.03.2023 10:41, Andi Shyti wrote: From: Chris Wilson Before taking exclusive ownership of the ring for emitting the request, wait for space in the ring to become available. This allows others to take the timeline->mutex to make forward progresses while userspace is blocked. In

Re: [PATCH v2] drm/vkms: add module parameter to set background color

2023-04-11 Thread Simon Ser
Hi, On Monday, April 10th, 2023 at 19:50, Melissa Wen wrote: > On 04/10, Simon Ser wrote: > > > I think this should be a KMS property instead of a module parameter. > > Is there a reason why this patch uses a module parameter? It breaks > > user-space expectations. > > a KMS property is what

Re: [PATCH v10 2/2] drm: add kms driver for loongson display controller

2023-04-11 Thread Sui Jingfeng
Hi, On 2023/4/4 22:10, Emil Velikov wrote: --- /dev/null +++ b/drivers/gpu/drm/loongson/lsdc_drv.c +static const struct lsdc_desc dc_in_ls7a1000 = { + .chip = CHIP_LS7A1000, + .num_of_crtc = LSDC_NUM_CRTC, + .max_pixel_clk = 20, + .max_width = 2048, +

Re: [PATCH] drm/vkms: add module parameter to set background color

2023-04-11 Thread Dan Carpenter
Hi Maíra, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Ma-ra-Canal/drm-vkms-add-module-parameter-to-set-background-color/20230407-012233 base:

Re: [PATCH v2 08/19] arch/m68k: Implement with generic helpers

2023-04-11 Thread Geert Uytterhoeven
On Thu, Apr 6, 2023 at 4:30 PM Thomas Zimmermann wrote: > Replace the architecture's fb_is_primary_device() with the generic > one from . No functional changes. > > v2: > * provide empty fb_pgprotect() on non-MMU systems > > Signed-off-by: Thomas Zimmermann > Cc: Geert Uytterhoeven

Re: [PATCH v10 2/2] drm: add kms driver for loongson display controller

2023-04-11 Thread Sui Jingfeng
Hi, On 2023/4/4 22:10, Emil Velikov wrote: + val = lsdc_crtc_rreg32(ldev, LSDC_CRTC0_CFG_REG, index); + /* clear old dma step settings */ + val &= ~CFG_DMA_STEP_MASK; + + if (descp->chip == CHIP_LS7A2000) { + /* +* Using large dma step as

Re: [PATCH v2 07/19] arch/m68k: Merge variants of fb_pgprotect() into single function

2023-04-11 Thread Geert Uytterhoeven
On Thu, Apr 6, 2023 at 4:30 PM Thomas Zimmermann wrote: > Merge all variants of fb_pgprotect() into a single function body. > There are two different cases for MMU systems. For non-MMU systems, > the function body will be empty. No functional changes, but this > will help with the switch to . > >

Re: [PATCH v2 01/19] fbdev: Prepare generic architecture helpers

2023-04-11 Thread Geert Uytterhoeven
Hi Thomas, On Thu, Apr 6, 2023 at 4:30 PM Thomas Zimmermann wrote: > Generic implementations of fb_pgprotect() and fb_is_primary_device() > have been in the source code for a long time. Prepare the header file > to make use of them. > > Improve the code by using an inline function for

Re: [RFC 1/2] drm: Add fdinfo memory stats

2023-04-11 Thread Boris Brezillon
Hi Rob, On Thu, 6 Apr 2023 14:59:16 -0700 Rob Clark wrote: > From: Rob Clark > > Add a helper to dump memory stats to fdinfo. For the things the drm > core isn't aware of, use a callback. > > Signed-off-by: Rob Clark > --- > Documentation/gpu/drm-usage-stats.rst | 21 +++ >

Re: RFC: DSI/DRM multiplexer bridge

2023-04-11 Thread Alexander Stein
Am Donnerstag, 6. April 2023, 11:55:52 CEST schrieb Jagan Teki: > [Replying the Daniel thread since he included bridge maintainers] > > On Thu, Apr 6, 2023 at 2:07 PM Daniel Vetter wrote: > > Adding the usual bridge maintainer/review folks since this looks tricky. > > -Daniel > > > > On Thu, 6

[PATCH 2/2] drm: sun4i: tie DSI PHY Poweron/off to crtc enable/disable

2023-04-11 Thread Brandon Cheo Fusi
Poweron/off the DSI PHY when the crtc is enabled/disabled. This allows the modeset helpers to manage the DSI sink while preserving the old drm_panel_ and drm_panel_ sequences. Signed-off-by: Brandon Cheo Fusi --- drivers/gpu/drm/sun4i/sun4i_tcon.c | 10 +- 1 file changed, 9

[PATCH 0/2] drm: sun4i/dsi: allow modeset helpers to manage display

2023-04-11 Thread Brandon Cheo Fusi
This change moves DSI PHY poweron/off from the encoder to the TCON. As a consequence enabling or disabling the DSI sink can be left to the modeset helpers, and bridge support easily introduced without touching the drm_encoder.bridge_chain or converting the encoder to a drm_bridge. Brandon Cheo

[PATCH 1/2] drm: sun4i/dsi: factor out DSI PHY poweron and poweroff

2023-04-11 Thread Brandon Cheo Fusi
Factor out PHY poweron and poweroff sequences from sun6i_dsi_encoder_enable and sun6i_dsi_encoder_disable.This leaves nothing to be be done in sun6i_dsi_encoder_disable, so get rid of that. Also remove drm_panel_ as these would be invoked the modeset helpers. Signed-off-by: Brandon Cheo Fusi ---

linux-next: build failure after merge of the drm tree

2023-04-11 Thread Stephen Rothwell
Hi all, After merging the drm tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/gpu/drm/ttm/ttm_pool.c:73:29: error: variably modified 'global_write_combined' at file scope 73 | static struct ttm_pool_type global_write_combined[TTM_DIM_ORDER]; |

Re: [PATCH v4 5/5] drm/i915/gt: Make sure that errors are propagated through request chains

2023-04-11 Thread Das, Nirmoy
On 3/8/2023 10:41 AM, Andi Shyti wrote: Currently, when we perform operations such as clearing or copying large blocks of memory, we generate multiple requests that are executed in a chain. However, if one of these requests fails, we may not realize it unless it happens to be the last request

<    1   2   3   >