Re: [PATCH v7 6/8] PCI/VGA: Introduce is_boot_device function callback to vga_client_register

2023-06-21 Thread Sui Jingfeng
Hi, A nouveau developer(Lyude) from redhat send me a R-B, Thanks for the developers of nouveau project. Please allow me add a link[1] here. [1] https://lore.kernel.org/all/0afadc69f99a36bc9d03ecf54ff25859dbc10e28.ca...@redhat.com/ On 2023/6/13 11:01, Sui Jingfeng wrote: From: Sui

Re: [PATCH v6 0/8] PCI/VGA: introduce is_boot_device function callback to vga_client_register

2023-06-21 Thread Sui Jingfeng
Hi On 2023/6/22 06:11, Lyude Paul wrote: For the nouveau bits: Reviewed-by: Lyude Paul Thanks a lot On Tue, 2023-06-13 at 03:25 +0800, Sui Jingfeng wrote: From: Sui Jingfeng The vga_is_firmware_default() function is arch-dependent, it's probably wrong if we simply remove the arch guard.

Re: [PATCH 0/6] drm: Add mouse cursor hotspot support to atomic KMS

2023-06-21 Thread Zack Rusin
On Wed, 2023-06-21 at 09:10 +0200, Javier Martinez Canillas wrote: > !! External Email > > [adding Zack Rusin again who seems to have fallen from the Cc list] > > Albert Esteve writes: > > On 6/10/22 10:59, Daniel Vetter wrote: > > > On Fri, Jun 10, 2022 at 10:41:05AM +0200, Daniel Vetter

Re: [PATCH 0/5] accel/qaic: Improve bounds checking in encode/decode

2023-06-21 Thread Jeffrey Hugo
On 6/21/2023 1:21 AM, Dan Carpenter wrote: (I think this is the first cover letter I have ever written). These patches are based on review and not from testing. Thank you for your review. I look forward to reading your patches and learning from them. Did you use any kind of tooling? If

Re: [PATCH 2/3] linux/bits.h: Add fixed-width GENMASK and BIT macros

2023-06-21 Thread Yury Norov
Hi Lucas, all! (Thanks, Andy, for pointing to this thread.) On Mon, May 08, 2023 at 10:14:02PM -0700, Lucas De Marchi wrote: > Add GENMASK_U32(), GENMASK_U16() and GENMASK_U8() macros to create > masks for fixed-width types and also the corresponding BIT_U32(), > BIT_U16() and BIT_U8(). Can

Re: [PATCH v2 1/2] dt-bindings: backlight: document new property default-brightness-level

2023-06-21 Thread Rob Herring
On Thu, Jun 22, 2023 at 12:54:56AM +0300, Alexandru Ardelean wrote: > From: Yannick Fertre > > Add documentation for new default-brightness-level property. Why? > > Signed-off-by: Yannick Fertre > Signed-off-by: Alexandru Ardelean > --- > > Link to original patch: > >

Re: [PATCH 3/3] dt-bindings: display: msm: sm8550-mdss: document displayport controller subnode

2023-06-21 Thread Rob Herring
On Wed, 21 Jun 2023 11:26:27 +0200, Neil Armstrong wrote: > Document the optional document displayport controller subnode > of the SM8550 MDSS. > > Signed-off-by: Neil Armstrong > --- > .../devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml | 8 > > 1 file changed, 8

Re: [PATCH 2/3] dt-bindings: display: msm: sm8450-mdss: document displayport controller subnode

2023-06-21 Thread Rob Herring
On Wed, 21 Jun 2023 11:26:26 +0200, Neil Armstrong wrote: > Document the optional document displayport controller subnode > of the SM8450 MDSS. > > Signed-off-by: Neil Armstrong > --- > .../devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml | 8 > > 1 file changed, 8

Re: [PATCH 1/3] dt-bindings: display: msm: sm8350-mdss: document displayport controller subnode

2023-06-21 Thread Rob Herring
On Wed, 21 Jun 2023 11:26:25 +0200, Neil Armstrong wrote: > Document the optional document displayport controller subnode > of the SM8350 MDSS. > > Signed-off-by: Neil Armstrong > --- > Documentation/devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml | 6 > ++ > 1 file changed, 6

Re: [PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF mitigations

2023-06-21 Thread Andrew Lunn
> Honestly I'm not sure though we need this complexity right now? I mean, > it'd be really easy to replace the calls in mac80211 with some other > more generalised calls in the future? > > You need some really deep platform/hardware level knowledge and > involvement to do this, so I don't think

Re: [PATCH v4 1/2] dt-bindings: phy: add mediatek MIPI CD-PHY module v0.5

2023-06-21 Thread Rob Herring
On Tue, 20 Jun 2023 14:18:46 +0200, Julien Stephan wrote: > From: Florian Sylvestre > > This adds the bindings, for the MIPI CD-PHY module v0.5 embedded in > some Mediatek soc, such as the mt8365 > > Signed-off-by: Florian Sylvestre > Signed-off-by: Julien Stephan > --- >

Re: [PATCH 2/3] drm/msm/dpu: Set DATABUS_WIDEN on command mode encoders

2023-06-21 Thread Dmitry Baryshkov
On 22/06/2023 02:01, Abhinav Kumar wrote: On 6/21/2023 9:36 AM, Dmitry Baryshkov wrote: On 21/06/2023 18:17, Marijn Suijten wrote: On 2023-06-20 14:38:34, Jessica Zhang wrote: +    if (phys_enc->hw_intf->ops.enable_widebus) +    phys_enc->hw_intf->ops.enable_widebus(phys_enc->hw_intf);

Re: [PATCH 2/3] drm/msm/dpu: Set DATABUS_WIDEN on command mode encoders

2023-06-21 Thread Abhinav Kumar
On 6/21/2023 9:36 AM, Dmitry Baryshkov wrote: On 21/06/2023 18:17, Marijn Suijten wrote: On 2023-06-20 14:38:34, Jessica Zhang wrote: +    if (phys_enc->hw_intf->ops.enable_widebus) +    phys_enc->hw_intf->ops.enable_widebus(phys_enc->hw_intf); No. Please provide a single function

[PATCH v2 5/5] drm/rockchip: vop2: Add missing call to crtc reset helper

2023-06-21 Thread Jonas Karlman
Add missing call to crtc reset helper to properly vblank reset. Also move vop2_crtc_reset and call vop2_crtc_destroy_state to simplify and remove duplicated code. Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver") Signed-off-by: Jonas Karlman --- v2: - Add check for allocation failure

[PATCH v2 4/5] drm/rockchip: vop2: Don't crash for invalid duplicate_state

2023-06-21 Thread Jonas Karlman
It's possible for users to try to duplicate the CRTC state even when the state doesn't exist. drm_atomic_helper_crtc_duplicate_state() (and other users of __drm_atomic_helper_crtc_duplicate_state()) already guard this with a WARN_ON() instead of crashing, so let's do that here too. Fixes:

[PATCH v2 3/5] drm/rockchip: vop: Fix call to crtc reset helper

2023-06-21 Thread Jonas Karlman
Allocation of crtc_state may fail in vop_crtc_reset, causing an invalid pointer to be passed to __drm_atomic_helper_crtc_reset. Fix this by adding a NULL check of crtc_state, similar to other drivers. Fixes: 01e2eaf40c9d ("drm/rockchip: Convert to using __drm_atomic_helper_crtc_reset() for

[PATCH v2 1/5] drm/rockchip: vop: Fix reset of state in duplicate state crtc funcs

2023-06-21 Thread Jonas Karlman
struct rockchip_crtc_state members such as output_type, output_bpc and enable_afbc is always reset to zero in the atomic_duplicate_state crtc funcs. Fix this by using kmemdup on the subclass rockchip_crtc_state struct. Fixes: 4e257d9eee23 ("drm/rockchip: get rid of

[PATCH v2 2/5] drm/rockchip: vop: Use cleanup helper directly as destroy funcs

2023-06-21 Thread Jonas Karlman
vop_plane_destroy and vop_crtc_destroy are plain wrappers around drm_plane_cleanup and drm_crtc_cleanup. Use them directly as plane and crtc funcs to closer match VOP2 driver. Signed-off-by: Jonas Karlman Reviewed-by: Sascha Hauer --- v2: - Collect r-b tag

[PATCH v2 0/5] drm/rockchip: Fix crtc duplicate state and crtc reset funcs

2023-06-21 Thread Jonas Karlman
failure in crtc reset funcs - Collect r-b tags This series is also available at [1]. [1] https://github.com/Kwiboo/linux-rockchip/commits/next-20230621-duplicate-state Jonas Karlman (5): drm/rockchip: vop: Fix reset of state in duplicate state crtc funcs drm/rockchip: vop: Use cleanup helper

Re: [PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF mitigations

2023-06-21 Thread Johannes Berg
On Wed, 2023-06-21 at 21:25 +0200, Andrew Lunn wrote: > > ACPI core does has notifiers that are used, but they don't work the same. > > If you look at patch 4, you'll see amdgpu registers and unregisters using > > both > > > > acpi_install_notify_handler() > > and > > acpi_remove_notify_handler()

Re: [PATCH v9 2/2] dt-bindings: msm: dsi-controller-main: Document clocks on a per compatible basis

2023-06-21 Thread Dmitry Baryshkov
On 22/06/2023 00:45, Marijn Suijten wrote: Hi! On 2023-01-18 17:16:21, Bryan O'Donoghue wrote: Each compatible has a different set of clocks which are associated with it. Add in the list of clocks for each compatible. So if each set of compatibles have their own unique set of clocks, is

Re: [PATCH v6 0/8] PCI/VGA: introduce is_boot_device function callback to vga_client_register

2023-06-21 Thread Lyude Paul
For the nouveau bits: Reviewed-by: Lyude Paul On Tue, 2023-06-13 at 03:25 +0800, Sui Jingfeng wrote: > From: Sui Jingfeng > > The vga_is_firmware_default() function is arch-dependent, it's probably > wrong if we simply remove the arch guard. As the VRAM BAR which contains > firmware

[PATCH 3/3] drm: panel-orientation-quirks: Add quirk for AYA NEO GEEK

2023-06-21 Thread Joaquín Ignacio Aramendía
Add quirk orientation for AYA NEO GEEK. One of the more recent devices by the brand. The name appears without spaces in dmi strings. The board name is completely different to the previous models making it difficult to reuse their quirks despite being the same resolution and mounting. Tested by

[PATCH 2/3] drm: panel-orientation-quirks: Add quirk for AYA NEO Founder edition

2023-06-21 Thread Joaquín Ignacio Aramendía
Add quirk orientation for AYA NEO Founder. The name appears with spaces in dmi strings as other devices of the brand. The panel is the same as the NEXT and 2021 models. Those could not be reused as the former has VENDOR name as "AYANEO" without spaces and the latter has "AYADEVICE". Tested by the

[PATCH 1/3] drm: panel-orientation-quirks: Add quirk for AYA NEO 2 model

2023-06-21 Thread Joaquín Ignacio Aramendía
Add quirk orientation for AYA NEO 2. The name appears without spaces in dmi strings. That made it difficult to reuse the 2021 match and the display is greater in resolution. Tested by the JELOS team that has been patching their own kernel for a while now and confirmed by users in the AYA NEO and

[PATCH 0/3] drm: panel-orientation-quirks: Add some quirks for

2023-06-21 Thread Joaquín Ignacio Aramendía
Add quirks for AYA NEO devices: - 2 - GEEK - Founder The quirks have been tested by the JELOS team that has been patching their own kernel for a while now and confirmed by users in the AYA NEO and ChimeraOS discord servers. Joaquín Ignacio Aramendía (3): drm: panel-orientation-quirks: Add

[PATCH v2 1/2] dt-bindings: backlight: document new property default-brightness-level

2023-06-21 Thread Alexandru Ardelean
From: Yannick Fertre Add documentation for new default-brightness-level property. Signed-off-by: Yannick Fertre Signed-off-by: Alexandru Ardelean --- Link to original patch: https://github.com/STMicroelectronics/linux/commit/c4067d7bd883c6fa14ffd49892c4ce663cdafe98 Changelog v1 -> v2: *

[PATCH v2 2/2] backlight: gpio_backlight: add new property default-brightness-level

2023-06-21 Thread Alexandru Ardelean
From: Yannick Fertre Add new property to set a brightness by default at probe. Reviewed-by: Daniel Thompson Signed-off-by: Yannick Fertre Signed-off-by: Alexandru Ardelean --- Link to original patch:

Re: [PATCH v9 2/2] dt-bindings: msm: dsi-controller-main: Document clocks on a per compatible basis

2023-06-21 Thread Marijn Suijten
Hi! On 2023-01-18 17:16:21, Bryan O'Donoghue wrote: > Each compatible has a different set of clocks which are associated with it. > Add in the list of clocks for each compatible. So if each set of compatibles have their own unique set of clocks, is there a reason to have so many duplicate then:

[PATCH] amd/display: only accept async flips for fast updates

2023-06-21 Thread André Almeida
From: Simon Ser Up until now, amdgpu was silently degrading to vsync when user-space requested an async flip but the hardware didn't support it. The hardware doesn't support immediate flips when the update changes the FB pitch, the DCC state, the rotation, enables or disables CRTCs or planes,

[PATCH 0/1] amd/display: only accept async flips for fast updates

2023-06-21 Thread André Almeida
Hi, This fix was developed with the "Add support for atomic async page-flips" patchset, it's not dependent on the new feature but it wasn't applied by the time so I'm resending it now. Extracted from: https://lore.kernel.org/dri-devel/20220929184307.258331-3-cont...@emersion.fr/ Simon Ser (1):

Re: [PATCH 2/9] mfd: atmel-hlcdc: Add compatible for SAM9X7 HLCD controller

2023-06-21 Thread Lee Jones
On Wed, 21 Jun 2023, Conor Dooley wrote: > On Wed, Jun 21, 2023 at 06:56:45PM +0100, Lee Jones wrote: > > On Tue, 13 Jun 2023, Manikandan Muralidharan wrote: > > > > > Add compatible for SAM9X7 HLCD controller. > > > > > > Signed-off-by: Manikandan Muralidharan > > > --- > > >

[PULL] drm-misc-fixes

2023-06-21 Thread Maarten Lankhorst
Hi Dave, Daniel, Midsummer is nearly here! So sending the pull request a bit early. Cheers! ~Maarten drm-misc-fixes-2023-06-21: drm-misc-fixes for v6.4: - Qaic imported dma-buf fix. - Fix null pointer deref when printing a dp-mst message. The following changes since commit

[PATCH v4] drm/vkms: Add support to 1D gamma LUT

2023-06-21 Thread Arthur Grillo
Support a 1D gamma LUT with interpolation for each color channel on the VKMS driver. Add a check for the LUT length by creating vkms_atomic_check(). Tested with: igt@kms_color@gamma igt@kms_color@legacy-gamma igt@kms_color@invalid-gamma-lut-sizes v2: - Add interpolation between the values of

Re: [PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF mitigations

2023-06-21 Thread Andrew Lunn
> ACPI core does has notifiers that are used, but they don't work the same. > If you look at patch 4, you'll see amdgpu registers and unregisters using > both > > acpi_install_notify_handler() > and > acpi_remove_notify_handler() > > If we supported both ACPI notifications and non-ACPI

Re: [PATCH v4 2/6] dma-buf/heaps: Don't assert held reservation lock for dma-buf mmapping

2023-06-21 Thread T.J. Mercier
On Wed, Jun 21, 2023 at 11:16 AM Dmitry Osipenko wrote: > > Hi, > > On 6/21/23 20:21, T.J. Mercier wrote: > > On Mon, May 29, 2023 at 3:46 PM Dmitry Osipenko > > wrote: > >> > >> Don't assert held dma-buf reservation lock on memory mapping of exported > >> buffer. > >> > >> We're going to change

Re: [PATCH v4 0/6] Move dma-buf mmap() reservation locking down to exporters

2023-06-21 Thread Dmitry Osipenko
On 5/30/23 01:39, Dmitry Osipenko wrote: > This patchset makes dma-buf exporters responisble for taking care of > the reservation lock. I also included patch that moves drm-shmem to use > reservation lock, to let CI test the whole set. I'm going to take all > the patches via the drm-misc tree,

Re: [PATCH 2/9] mfd: atmel-hlcdc: Add compatible for SAM9X7 HLCD controller

2023-06-21 Thread Conor Dooley
On Wed, Jun 21, 2023 at 06:56:45PM +0100, Lee Jones wrote: > On Tue, 13 Jun 2023, Manikandan Muralidharan wrote: > > > Add compatible for SAM9X7 HLCD controller. > > > > Signed-off-by: Manikandan Muralidharan > > --- > > drivers/mfd/atmel-hlcdc.c | 1 + > > 1 file changed, 1 insertion(+) > >

Re: [PATCH v4 0/2] retrieve DSI DSC through priv-dsi[0]

2023-06-21 Thread Marijn Suijten
On 2023-06-21 09:18:16, Kuogee Hsieh wrote: > moving retrieving struct drm_dsc_cofnig from setup_display to > atomic_enable() and delete struct drm_dsc_config from > struct msm_display_info. Abhinav suggested to reword this for clarity in v3, but none of that seems to have made it through? -

[PATCH] drm/mgag200: Fix a warning reported by Fi.CI.SPARSE

2023-06-21 Thread Sui Jingfeng
drivers/gpu/drm/mgag200/mgag200_drv.c:23:5: warning: symbol 'mgag200_modeset' was not declared. Should it be static? Found in the log of Fi.CI.SPARSE test [1] [1] https://patchwork.freedesktop.org/series/119249/ Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/mgag200/mgag200_drv.c | 2 +- 1

Re: [PATCH v2] drm/msm/dsi: Document DSC related pclk_rate and hdisplay calculations

2023-06-21 Thread Marijn Suijten
On 2023-06-20 17:27:46, Dmitry Baryshkov wrote: > On 20/06/2023 15:05, Marijn Suijten wrote: > > On 2023-06-20 00:06:47, Dmitry Baryshkov wrote: > >> Provide actual documentation for the pclk and hdisplay calculations in > >> the case of DSC compression being used. > >> > >> Signed-off-by: Dmitry

Re: [PATCH 2/3] drm/msm/dpu: Set DATABUS_WIDEN on command mode encoders

2023-06-21 Thread Marijn Suijten
On 2023-06-21 19:36:37, Dmitry Baryshkov wrote: > On 21/06/2023 18:17, Marijn Suijten wrote: > > On 2023-06-20 14:38:34, Jessica Zhang wrote: > > > >>> +    if (phys_enc->hw_intf->ops.enable_widebus) > >>> +    phys_enc->hw_intf->ops.enable_widebus(phys_enc->hw_intf); > >> >

Re: [PATCH drm-next v5 03/14] drm: manager to keep track of GPUs VA mappings

2023-06-21 Thread Donald Robson
Hi Danilo, One comment below, but otherwise it looks great. Thanks for adding the example! Thanks, Donald On Tue, 2023-06-20 at 02:42 +0200, Danilo Krummrich wrote: > > +/** > + * DOC: Overview > + * > + * The DRM GPU VA Manager, represented by struct drm_gpuva_manager keeps > track > + * of a

Re: [PATCH v2] drm/i915: Replace kmap() with kmap_local_page()

2023-06-21 Thread Intel
On 6/21/23 18:35, Ira Weiny wrote: Thomas Hellström (Intel) wrote: I think one thing worth mentioning in the context of this patch is that IIRC kmap_local_page() will block offlining of the mapping CPU until kunmap_local(), so while I haven't seen any guidelines around the usage of this api

Re: [PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF mitigations

2023-06-21 Thread Limonciello, Mario
So if we go down this path of CONFIG_WBRF and CONFIG_WBRF_ACPI, another question would be where should the new "wbrf.c" be stored?  The ACPI only version most certainly made sense in drivers/acpi/wbrf.c, but a generic version that only has an ACPI implementation right now not so much. On

Re: [PATCH] drm/tests: Add test case for drm_rect_clip_scaled()

2023-06-21 Thread Arthur Grillo Queiroz Cabral
On 14/06/23 14:54, nelsonbogado99 wrote: > From: Nelson Bogado > > To evaluate the behavior of the drm_rect_clip_scaled() helper function > with misplaced rectangles and improve the robustness and quality of it. > > The new test was executed using the following command: > > $

Re: [PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF mitigations

2023-06-21 Thread Andrew Lunn
> And consumer would need to call it, but only if CONFIG_WBRF_ACPI isn't set. Why? How is ACPI special that it does not need notifiers? > I don't see why it couldn't be a DT/ACPI hybrid solution for ARM64. As said somewhere else, nobody does hybrid. In fact, turn it around. Why not implement

Re: [PATCH v15 0/2] drm: Add kms driver for loongson display controller

2023-06-21 Thread Sui Jingfeng
Hi, Dear maintainers: Any chance to get this driver merged ? I have already write this driver by myself from the zero, iterate about 15 times? it there anything missing? On 2023/6/15 22:36, Sui Jingfeng wrote: From: Sui Jingfeng Loongson display controller IP has been integrated in

Re: [PATCH v4 5/6] dma-buf: Change locking policy for mmap()

2023-06-21 Thread Dmitry Osipenko
On 6/21/23 08:42, Christian König wrote: > Am 20.06.23 um 17:58 schrieb Dmitry Osipenko: >> On 5/31/23 22:58, Dmitry Osipenko wrote: >>> On 5/30/23 01:39, Dmitry Osipenko wrote: Change locking policy of mmap() callback, making exporters responsible for handling dma-buf reservation

Re: [PATCH v4 2/6] dma-buf/heaps: Don't assert held reservation lock for dma-buf mmapping

2023-06-21 Thread Dmitry Osipenko
Hi, On 6/21/23 20:21, T.J. Mercier wrote: > On Mon, May 29, 2023 at 3:46 PM Dmitry Osipenko > wrote: >> >> Don't assert held dma-buf reservation lock on memory mapping of exported >> buffer. >> >> We're going to change dma-buf mmap() locking policy such that exporters >> will have to handle the

Re: [PATCH v2] drm/vkms: Fix race-condition between the hrtimer and the atomic commit

2023-06-21 Thread Arthur Grillo Queiroz Cabral
On 23/05/23 09:32, Maíra Canal wrote: > Currently, it is possible for the composer to be set as enabled and then > as disabled without a proper call for the vkms_vblank_simulate(). This > is problematic, because the driver would skip one CRC output, causing CRC > tests to fail. Therefore, we

Re: [PATCH 2/9] mfd: atmel-hlcdc: Add compatible for SAM9X7 HLCD controller

2023-06-21 Thread Lee Jones
On Tue, 13 Jun 2023, Manikandan Muralidharan wrote: > Add compatible for SAM9X7 HLCD controller. > > Signed-off-by: Manikandan Muralidharan > --- > drivers/mfd/atmel-hlcdc.c | 1 + > 1 file changed, 1 insertion(+) Applied, thanks -- Lee Jones [李琼斯]

Re: [PATCH v10 07/11] drm/etnaviv: Add support for the dma coherent device

2023-06-21 Thread Lucas Stach
Am Donnerstag, dem 22.06.2023 um 01:31 +0800 schrieb Sui Jingfeng: > Hi, > > On 2023/6/22 00:07, Lucas Stach wrote: > > And as the HW guarantees it on your platform, your platform > > implementation makes this function effectively a no-op. Skipping the > > call to this function is breaking the

Re: [PATCH 09/13] net: Convert sunrpc from pagevec to folio_batch

2023-06-21 Thread Chuck Lever
On Wed, Jun 21, 2023 at 05:45:53PM +0100, Matthew Wilcox (Oracle) wrote: > Remove the last usage of pagevecs. There is a slight change here; we > now free the folio_batch as soon as it fills up instead of freeing the > folio_batch when we try to add a page to a full batch. This should have > no

Re: [PATCH v10 07/11] drm/etnaviv: Add support for the dma coherent device

2023-06-21 Thread Lucas Stach
Am Donnerstag, dem 22.06.2023 um 01:21 +0800 schrieb Sui Jingfeng: > Hi, > > On 2023/6/21 23:58, Lucas Stach wrote: > > Am Mittwoch, dem 21.06.2023 um 23:30 +0800 schrieb Sui Jingfeng: > > > Hi, > > > > > > On 2023/6/21 18:00, Lucas Stach wrote: > > > > >

Re: [PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF mitigations

2023-06-21 Thread Limonciello, Mario
On 6/21/2023 12:26 PM, Andrew Lunn wrote: I think what you're asking for is another layer of indirection like CONFIG_WBRF in addition to CONFIG_ACPI_WBRF. Producers would call functions like wbrf_supported_producer() where the source file is not guarded behind CONFIG_ACPI_WBRF, but instead by

Re: [PATCH v2] drm/panel: simple: Add connector_type for innolux_at043tn24

2023-06-21 Thread Sam Ravnborg
On Tue, Jun 20, 2023 at 08:22:02AM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > The innolux at043tn24 display is a parallel LCD. Pass the 'connector_type' > information to avoid the following warning: > > panel-simple panel: Specify missing connector_type > > Signed-off-by: Fabio

Re: [PATCH v10 07/11] drm/etnaviv: Add support for the dma coherent device

2023-06-21 Thread Sui Jingfeng
Hi, On 2023/6/22 00:07, Lucas Stach wrote: And as the HW guarantees it on your platform, your platform implementation makes this function effectively a no-op. Skipping the call to this function is breaking the DMA API abstraction, as now the driver is second guessing the DMA API implementation.

Re: [PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF mitigations

2023-06-21 Thread Andrew Lunn
> I think what you're asking for is another layer of indirection > like CONFIG_WBRF in addition to CONFIG_ACPI_WBRF. > > Producers would call functions like wbrf_supported_producer() > where the source file is not guarded behind CONFIG_ACPI_WBRF, > but instead by CONFIG_WBRF and locally use

Re: [RFC 0/5] Proposal to use netlink for RAS and Telemetry across drm subsystem

2023-06-21 Thread Sebastian Wick
On Fri, May 26, 2023 at 6:21 PM Aravind Iddamsetty wrote: > > Our hardware supports RAS(Reliability, Availability, Serviceability) by > exposing a set of error counters which can be used by observability > tools to take corrective actions or repairs. Traditionally there were > being exposed via

Re: [PATCH v10 07/11] drm/etnaviv: Add support for the dma coherent device

2023-06-21 Thread Sui Jingfeng
Hi, On 2023/6/21 23:58, Lucas Stach wrote: Am Mittwoch, dem 21.06.2023 um 23:30 +0800 schrieb Sui Jingfeng: Hi, On 2023/6/21 18:00, Lucas Stach wrote: dma_sync_sgtable_for_cpu(dev->dev, etnaviv_obj->sgt, etnaviv_op_to_dma_dir(op));

Re: [PATCH v4 2/6] dma-buf/heaps: Don't assert held reservation lock for dma-buf mmapping

2023-06-21 Thread T.J. Mercier
On Mon, May 29, 2023 at 3:46 PM Dmitry Osipenko wrote: > > Don't assert held dma-buf reservation lock on memory mapping of exported > buffer. > > We're going to change dma-buf mmap() locking policy such that exporters > will have to handle the lock. The previous locking policy caused deadlock >

Re: [PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF mitigations

2023-06-21 Thread Andrew Lunn
> Think a little more about what a non-ACPI implementation > would look like: > > 1) Would producers and consumers still need you to set CONFIG_ACPI_WBRF? I would expect there to be an CONFIG_WBRF, and then under that a CONFIG_WBRF_ACPI, CONFIG_WBRF_DT, CONFIG_WBRF_FOOBAR, each indicating they

Re: [PATCH] dt-bindings: backlight: kinetic,ktz8866: Add missing type for "current-num-sinks"

2023-06-21 Thread Lee Jones
On Tue, 13 Jun 2023, Rob Herring wrote: > "current-num-sinks" is missing a type, add it. > > Signed-off-by: Rob Herring > --- > .../devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml | 1 + > 1 file changed, 1 insertion(+) Applied, thanks -- Lee Jones [李琼斯]

Re: [PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF mitigations

2023-06-21 Thread Limonciello, Mario
On 6/21/2023 11:52 AM, Andrew Lunn wrote: On Wed, Jun 21, 2023 at 11:15:00AM -0500, Limonciello, Mario wrote: On 6/21/2023 10:39 AM, Johannes Berg wrote: On Wed, 2023-06-21 at 17:36 +0200, Andrew Lunn wrote: On Wed, Jun 21, 2023 at 01:45:56PM +0800, Evan Quan wrote: From: Mario Limonciello

Re: [PATCH 1/2] drm: execution context for GEM buffers v5

2023-06-21 Thread Boris Brezillon
On Wed, 21 Jun 2023 18:51:59 +0200 Boris Brezillon wrote: > On Wed, 21 Jun 2023 15:36:59 +0200 > "Christian König" wrote: > > > +/** > > + * drm_exec_until_all_locked - loop until all GEM objects are locked > > + * @exec: drm_exec object > > + * > > + * Core functionality of the drm_exec

Re: [PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF mitigations

2023-06-21 Thread Andrew Lunn
On Wed, Jun 21, 2023 at 11:15:00AM -0500, Limonciello, Mario wrote: > > On 6/21/2023 10:39 AM, Johannes Berg wrote: > > On Wed, 2023-06-21 at 17:36 +0200, Andrew Lunn wrote: > > > On Wed, Jun 21, 2023 at 01:45:56PM +0800, Evan Quan wrote: > > > > From: Mario Limonciello > > > > > > > > Due to

Re: [PATCH 1/2] drm: execution context for GEM buffers v5

2023-06-21 Thread Boris Brezillon
On Wed, 21 Jun 2023 15:36:59 +0200 "Christian König" wrote: > +/** > + * drm_exec_until_all_locked - loop until all GEM objects are locked > + * @exec: drm_exec object > + * > + * Core functionality of the drm_exec object. Loops until all GEM objects are > + * locked and no more contention

Re: [PATCH 2/2] drm: add drm_exec selftests v4

2023-06-21 Thread kernel test robot
-20230621] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Christian-K-nig/drm-add

Re: [PATCH 2/2] drm: add drm_exec selftests v4

2023-06-21 Thread kernel test robot
-20230621] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Christian-K-nig/drm-add

Re: [PATCH v10 07/11] drm/etnaviv: Add support for the dma coherent device

2023-06-21 Thread Sui Jingfeng
Hi On 2023/6/21 23:58, Lucas Stach wrote: you approach forbidden any possibility to use the WC BO at anywhere. My approach need only check once, while you approach need at least 3 check plus so much bit-wise logic operations,  plus a function call  (&, ==, &&, &, ~, &) . and every time you

[PATCH 09/13] net: Convert sunrpc from pagevec to folio_batch

2023-06-21 Thread Matthew Wilcox (Oracle)
Remove the last usage of pagevecs. There is a slight change here; we now free the folio_batch as soon as it fills up instead of freeing the folio_batch when we try to add a page to a full batch. This should have no effect in practice. Signed-off-by: Matthew Wilcox (Oracle) ---

[PATCH 12/13] mm: Remove references to pagevec

2023-06-21 Thread Matthew Wilcox (Oracle)
Most of these should just refer to the LRU cache rather than the data structure used to implement the LRU cache. Signed-off-by: Matthew Wilcox (Oracle) --- mm/huge_memory.c| 2 +- mm/khugepaged.c | 6 +++--- mm/ksm.c| 6 +++--- mm/memory.c | 6 +++---

[PATCH 03/13] scatterlist: Add sg_set_folio()

2023-06-21 Thread Matthew Wilcox (Oracle)
This wrapper for sg_set_page() lets drivers add folios to a scatterlist more easily. We could, perhaps, do better by using a different page in the folio if offset is larger than UINT_MAX, but let's hope we get a better data structure than this before we need to care about such large folios.

[PATCH 04/13] i915: Convert shmem_sg_free_table() to use a folio_batch

2023-06-21 Thread Matthew Wilcox (Oracle)
Remove a few hidden compound_head() calls by converting the returned page to a folio once and using the folio APIs. We also only increment the refcount on the folio once instead of once for each page. Ideally, we would have a for_each_sgt_folio macro, but until then this will do. Signed-off-by:

[PATCH 11/13] mm: Rename invalidate_mapping_pagevec to mapping_try_invalidate

2023-06-21 Thread Matthew Wilcox (Oracle)
We don't use pagevecs for the LRU cache any more, and we don't know that the failed invalidations were due to the folio being in an LRU cache. So rename it to be more accurate. Signed-off-by: Matthew Wilcox (Oracle) --- mm/fadvise.c | 16 +++- mm/internal.h | 4 ++--

[PATCH 02/13] mm: Add __folio_batch_release()

2023-06-21 Thread Matthew Wilcox (Oracle)
This performs the same role as __pagevec_release(), ie skipping the check for batch length of 0. Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/pagevec.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/include/linux/pagevec.h b/include/linux/pagevec.h index

[PATCH 06/13] mm: Remove check_move_unevictable_pages()

2023-06-21 Thread Matthew Wilcox (Oracle)
All callers have now been converted to call check_move_unevictable_folios(). Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/swap.h | 1 - mm/vmscan.c | 17 - 2 files changed, 18 deletions(-) diff --git a/include/linux/swap.h b/include/linux/swap.h index

[PATCH 00/13] Remove pagevecs

2023-06-21 Thread Matthew Wilcox (Oracle)
We're almost done with the pagevec -> folio_batch conversion. Finish the job. Matthew Wilcox (Oracle) (13): afs: Convert pagevec to folio_batch in afs_extend_writeback() mm: Add __folio_batch_release() scatterlist: Add sg_set_folio() i915: Convert shmem_sg_free_table() to use a

[PATCH 05/13] drm: Convert drm_gem_put_pages() to use a folio_batch

2023-06-21 Thread Matthew Wilcox (Oracle)
Remove a few hidden compound_head() calls by converting the returned page to a folio once and using the folio APIs. Signed-off-by: Matthew Wilcox (Oracle) --- drivers/gpu/drm/drm_gem.c | 68 ++- 1 file changed, 39 insertions(+), 29 deletions(-) diff --git

[PATCH 08/13] i915: Convert i915_gpu_error to use a folio_batch

2023-06-21 Thread Matthew Wilcox (Oracle)
Remove one of the last remaining users of pagevec. Signed-off-by: Matthew Wilcox (Oracle) --- drivers/gpu/drm/i915/i915_gpu_error.c | 50 +-- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c

[PATCH 01/13] afs: Convert pagevec to folio_batch in afs_extend_writeback()

2023-06-21 Thread Matthew Wilcox (Oracle)
Removes a folio->page->folio conversion for each folio that's involved. More importantly, removes one of the last few uses of a pagevec. Signed-off-by: Matthew Wilcox (Oracle) --- fs/afs/write.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/fs/afs/write.c

[PATCH 07/13] pagevec: Rename fbatch_count()

2023-06-21 Thread Matthew Wilcox (Oracle)
This should always have been called folio_batch_count(). Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/pagevec.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/pagevec.h b/include/linux/pagevec.h index 42aad53e382e..3a9d29dd28a3 100644 ---

[PATCH 13/13] mm: Remove unnecessary pagevec includes

2023-06-21 Thread Matthew Wilcox (Oracle)
These files no longer need pagevec.h, mostly due to function declarations being moved out of it. Signed-off-by: Matthew Wilcox (Oracle) --- mm/fadvise.c| 1 - mm/memory_hotplug.c | 1 - mm/migrate.c| 1 - mm/readahead.c | 1 - mm/swap_state.c | 1 - 5 files changed, 5

[PATCH 10/13] mm: Remove struct pagevec

2023-06-21 Thread Matthew Wilcox (Oracle)
All users are now converted to use the folio_batch so we can get rid of this data structure. Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/pagevec.h | 63 +++-- mm/swap.c | 18 ++-- 2 files changed, 13 insertions(+), 68

Re: [PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF mitigations

2023-06-21 Thread Limonciello, Mario
On 6/21/2023 11:31 AM, Andrew Lunn wrote: I think there is enough details for this to happen. It's done so that either the AML can natively behave as a consumer or a driver can behave as a consumer. +/** + * APIs needed by drivers/subsystems for contributing frequencies: + * During probe,

Re: [PATCH v10 07/11] drm/etnaviv: Add support for the dma coherent device

2023-06-21 Thread Sui Jingfeng
Hi, On 2023/6/22 00:12, Lucas Stach wrote: Am Mittwoch, dem 21.06.2023 um 23:41 +0800 schrieb Sui Jingfeng: On 2023/6/21 23:23, Lucas Stach wrote: Am Mittwoch, dem 21.06.2023 um 22:44 +0800 schrieb Sui Jingfeng: Hi, On 2023/6/21 18:00, Lucas Stach wrote: diff --git

Re: [RFC PATCH v3 3/4] drm/amdgpu: Implement DRM_IOCTL_GET_RESET

2023-06-21 Thread André Almeida
Em 21/06/2023 04:40, Christian König escreveu: Am 21.06.23 um 02:57 schrieb André Almeida: Implement get_reset ioctl for amdgpu Well that pretty much won't work since the jobs are destroyed much later than the contexts. Why does this prevents the code to work? If the context is detroyed,

Re: [PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF mitigations

2023-06-21 Thread Johannes Berg
On Wed, 2023-06-21 at 18:14 +0200, Andrew Lunn wrote: > > > Do only ACPI based systems have: > > > > > >    interference of relatively high-powered harmonics of the (G-)DDR > > >    memory clocks with local radio module frequency bands used by > > >    Wifi 6/6e/7." > > > > > > Could Device Tree

Re: [PATCH v2] drm/i915: Replace kmap() with kmap_local_page()

2023-06-21 Thread Ira Weiny
Thomas Hellström (Intel) wrote: > > I think one thing worth mentioning in the context of this patch is that > IIRC kmap_local_page() will block offlining of the mapping CPU until > kunmap_local(), so while I haven't seen any guidelines around the usage > of this api for long-held mappings, I

Re: [PATCH 2/3] drm/msm/dpu: Set DATABUS_WIDEN on command mode encoders

2023-06-21 Thread Dmitry Baryshkov
On 21/06/2023 18:17, Marijn Suijten wrote: On 2023-06-20 14:38:34, Jessica Zhang wrote: +    if (phys_enc->hw_intf->ops.enable_widebus) +    phys_enc->hw_intf->ops.enable_widebus(phys_enc->hw_intf); No. Please provide a single function which takes necessary configuration, including

Re: [RFC PATCH v3 2/4] drm: Create DRM_IOCTL_GET_RESET

2023-06-21 Thread André Almeida
Em 21/06/2023 05:09, Pekka Paalanen escreveu: On Tue, 20 Jun 2023 21:57:17 -0300 André Almeida wrote: Create a new DRM ioctl operation to get the numbers of resets for a given context. The numbers reflect just the resets that happened after the context was created, and not since the machine

Re: [PATCH v10 07/11] drm/etnaviv: Add support for the dma coherent device

2023-06-21 Thread Sui Jingfeng
Hi, On 2023/6/22 00:12, Lucas Stach wrote: Am Mittwoch, dem 21.06.2023 um 23:41 +0800 schrieb Sui Jingfeng: On 2023/6/21 23:23, Lucas Stach wrote: Am Mittwoch, dem 21.06.2023 um 22:44 +0800 schrieb Sui Jingfeng: Hi, On 2023/6/21 18:00, Lucas Stach wrote: diff --git

Re: [PATCH v2 00/10] drm/panel and i2c-hid: Allow panels and touchscreens to power sequence together

2023-06-21 Thread Doug Anderson
Maxime, On Tue, Jun 13, 2023 at 8:56 AM Doug Anderson wrote: > > Hi, > > On Tue, Jun 13, 2023 at 5:06 AM Maxime Ripard wrote: > > > > > > What I'm trying to say is: could we just make it work by passing a bunch > > > > of platform_data, 2-3 callbacks and a device registration from the panel > >

Re: [PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF mitigations

2023-06-21 Thread Andrew Lunn
> I think there is enough details for this to happen. It's done > so that either the AML can natively behave as a consumer or a > driver can behave as a consumer. > > > > > +/** > > > > > + * APIs needed by drivers/subsystems for contributing frequencies: > > > > > + * During probe, check

Re: [RFC PATCH v3 1/4] drm/doc: Document DRM device reset expectations

2023-06-21 Thread André Almeida
Em 21/06/2023 04:58, Pekka Paalanen escreveu: On Tue, 20 Jun 2023 21:57:16 -0300 André Almeida wrote: Create a section that specifies how to deal with DRM device resets for kernel and userspace drivers. Signed-off-by: André Almeida Hi André, nice to see this! I ended up giving lots of

Re: [PATCH 2/2] drm: add drm_exec selftests v4

2023-06-21 Thread kernel test robot
-20230621] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Christian-K-nig/drm-add

[PATCH 2/2] dma-buf: allow nested dma_resv_reserve_fences

2023-06-21 Thread Yunxiang Li
Calling dma_resv_reserve_fences a second time would not reserve memory correctly, this is quite unintuitive and the current debug build option cannot catch this error reliably because of the slack in max_fences. Rework the function to allow multiple invocations, the side-effect being reserve

[PATCH 1/2] drm/amdgpu: fix missing fence reserve in amdgpu_vm_sdma_commit

2023-06-21 Thread Yunxiang Li
When amdgpu_bo_fence is converted to dma_resv_add_fence, the reserve was removed in that process, so putting it back. Fixes: 4247084057cf ("drm/amdgpu: use DMA_RESV_USAGE_BOOKKEEP v2") Signed-off-by: Yunxiang Li --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c | 4 1 file changed, 4

[PATCH 0/2] drm: fix soft lockup when saturating vram

2023-06-21 Thread Yunxiang Li
When running multiple graphical application and vram is saturated, the excessive swapping triggers the BUG_ON() in dma_resv_add_fences. The root cause is that calling dma_resv_reserve_fences twice would shadow the second call and this happens in amdgpu_cs_ioctl/amdgpu_gem_va_ioctl path shadowing

  1   2   3   >