Re: WARNING in amdgpu_sync_keep_later / dma_fence_is_later should be rate limited

2023-09-21 Thread Christian König
Am 21.09.23 um 23:30 schrieb Alex Deucher: On Thu, Sep 21, 2023 at 4:21 PM Rafał Miłecki wrote: On 21.09.2023 21:52, Deucher, Alexander wrote: backporting commit 187916e6ed9d ("drm/amdgpu: install stub fence into potential unused fence pointers") to stable kernels resulted in lots of WARNINGs

Re: [PATCH 0/5] drm/amd/display: Remove migrate-disable and move memory allocation.

2023-09-21 Thread Christian König
Am 21.09.23 um 16:15 schrieb Sebastian Andrzej Siewior: Hi, I stumbled uppon the amdgpu driver via a bugzilla report. The actual fix is #4 + #5 and the rest was made while looking at the code. Oh, yes please :) Rodrigo and I have been trying to sort those things out previously, but that's

[Bug 201957] amdgpu: ring gfx timeout

2023-09-21 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201957 G OConnor (graham.ocon...@gmail.com) changed: What|Removed |Added CC|

Re: [PATCH v2 3/6] drm: lcdif: rework runtime PM handling in the atomic commit

2023-09-21 Thread kernel test robot
Hi Lucas, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on linus/master v6.6-rc2 next-20230921] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest

Re: WARNING in amdgpu_sync_keep_later / dma_fence_is_later should be rate limited

2023-09-21 Thread Alex Deucher
On Thu, Sep 21, 2023 at 4:21 PM Rafał Miłecki wrote: > > On 21.09.2023 21:52, Deucher, Alexander wrote: > >> backporting commit 187916e6ed9d ("drm/amdgpu: install stub fence into > >> potential unused fence pointers") to stable kernels resulted in lots of > >> WARNINGs on some devices. In my case

[PATCH v2 5/6] drm: lcdif: move pitch setup to plane atomic update

2023-09-21 Thread Lucas Stach
The buffer pitch may change when switching the buffer on a atomic update. As the register is double buffered it can be safely changed while the display is active. Signed-off-by: Lucas Stach Reviewed-by: Marek Vasut --- v2: no changes --- drivers/gpu/drm/mxsfb/lcdif_kms.c | 26

[PATCH v2 1/6] drm: lcdif: improve burst size configuration comment

2023-09-21 Thread Lucas Stach
The comment regarding AXI bust size configuration is a bit hard to read. Improve the wording somewhat. Signed-off-by: Lucas Stach Reviewed-by: Marco Felsch Reviewed-by: Marek Vasut --- v2: Some more rewording. --- drivers/gpu/drm/mxsfb/lcdif_kms.c | 8 1 file changed, 4

[PATCH v2 2/6] drm: lcdif: don't clear unrelated bits in CTRLDESCL0_5 when setting up format

2023-09-21 Thread Lucas Stach
The CTRLDESCL0_5 register also holds other bits that are not related to the format, which should not be overwritten when the format is set up. Use a proper RMW access in lcdif_set_formats(). Signed-off-by: Lucas Stach --- v2: new patch --- drivers/gpu/drm/mxsfb/lcdif_kms.c | 40

[PATCH v2 4/6] drm: lcdif: remove superfluous setup of framebuffer DMA address

2023-09-21 Thread Lucas Stach
Now that the plane state is fully programmed into the hardware before the scanout is started there is no need to program the plane framebuffer DMA address from the CRTC atomic_enable anymore. Signed-off-by: Lucas Stach Reviewed-by: Marek Vasut --- v2: no changes ---

[PATCH v2 3/6] drm: lcdif: rework runtime PM handling in the atomic commit

2023-09-21 Thread Lucas Stach
drm_atomic_helper_commit_tail_rpm makes it hard for drivers to follow the documented encoder/bridge enable flow, as it commits all CRTC enables before the planes are fully set up, so drivers that can't enable the display link without valid plane setup either need to do the plane setup in the CRTC

[PATCH v2 6/6] drm: lcdif: force modeset when FB format changes

2023-09-21 Thread Lucas Stach
Force a modeset if the new FB has a different format than the currently active one. While it might be possible to change between compatible formats without a full modeset as the format control is also supposed to be double buffered, the colorspace conversion is not, so when the CSC changes we need

RE: WARNING in amdgpu_sync_keep_later / dma_fence_is_later should be rate limited

2023-09-21 Thread Deucher, Alexander
[Public] > -Original Message- > From: Rafał Miłecki > Sent: Thursday, September 21, 2023 3:41 PM > To: Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui ; amd- > g...@lists.freedesktop.org; dri-devel ; Yu, > Lang > Subject: WARNING in amdgpu_sync_keep_later / dma_fence_is_later

[RFT PATCH v2 12/12] drm/renesas/shmobile: Call drm_helper_force_disable_all() at shutdown/remove time

2023-09-21 Thread Douglas Anderson
Based on grepping through the source code, this driver appears to be missing a call to drm_atomic_helper_shutdown(), or in this case the non-atomic equivalent drm_helper_force_disable_all(), at system shutdown time and at driver remove time. This is important because drm_helper_force_disable_all()

[RFT PATCH v2 10/12] drm/gma500: Call drm_helper_force_disable_all() at shutdown/remove time

2023-09-21 Thread Douglas Anderson
Based on grepping through the source code, this driver appears to be missing a call to drm_atomic_helper_shutdown(), or in this case the non-atomic equivalent drm_helper_force_disable_all(), at system shutdown time and at driver remove time. This is important because drm_helper_force_disable_all()

[RFT PATCH v2 09/12] drm/exynos: Call drm_atomic_helper_shutdown() at shutdown/unbind time

2023-09-21 Thread Douglas Anderson
Based on grepping through the source code this driver appears to be missing a call to drm_atomic_helper_shutdown() at system shutdown time and at driver unbind time. Among other things, this means that if a panel is in use that it won't be cleanly powered off at system shutdown time. The fact

[RFT PATCH v2 11/12] drm/radeon: Call drm_helper_force_disable_all() at shutdown/remove time

2023-09-21 Thread Douglas Anderson
Based on grepping through the source code, this driver appears to be missing a call to drm_atomic_helper_shutdown(), or in this case the non-atomic equivalent drm_helper_force_disable_all(), at system shutdown time and at driver remove time. This is important because drm_helper_force_disable_all()

[RFT PATCH v2 07/12] drm/amdgpu: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-21 Thread Douglas Anderson
Based on grepping through the source code this driver appears to be missing a call to drm_atomic_helper_shutdown() at system shutdown time. Among other things, this means that if a panel is in use that it won't be cleanly powered off at system shutdown time. The fact that we should call

[RFT PATCH v2 08/12] drm/sprd: Call drm_atomic_helper_shutdown() at remove time

2023-09-21 Thread Douglas Anderson
Based on grepping through the source code, this driver appears to be missing a call to drm_atomic_helper_shutdown() at remove time. Let's add it. The fact that we should call drm_atomic_helper_shutdown() in the case of OS driver remove comes straight out of the kernel doc "driver instance

[RFT PATCH v2 06/12] drm/arcpgu: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-21 Thread Douglas Anderson
Based on grepping through the source code this driver appears to be missing a call to drm_atomic_helper_shutdown() at system shutdown time. Among other things, this means that if a panel is in use that it won't be cleanly powered off at system shutdown time. The fact that we should call

[RFT PATCH v2 05/12] drm/tegra: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-21 Thread Douglas Anderson
Based on grepping through the source code this driver appears to be missing a call to drm_atomic_helper_shutdown() at system shutdown time. Among other things, this means that if a panel is in use that it won't be cleanly powered off at system shutdown time. The fact that we should call

[RFT PATCH v2 03/12] drm/mediatek: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-21 Thread Douglas Anderson
Based on grepping through the source code this driver appears to be missing a call to drm_atomic_helper_shutdown() at system shutdown time. Among other things, this means that if a panel is in use that it won't be cleanly powered off at system shutdown time. The fact that we should call

[RFT PATCH v2 04/12] drm/nouveau: Call drm_atomic_helper_shutdown() or equiv at shutdown time

2023-09-21 Thread Douglas Anderson
Based on grepping through the source code this driver appears to be missing a call to drm_atomic_helper_shutdown() (or drm_helper_force_disable_all() if not using atomic) at system shutdown time. Among other things, this means that if a panel is in use that it won't be cleanly powered off at

[RFT PATCH v2 02/12] drm/kmb: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-21 Thread Douglas Anderson
Based on grepping through the source code this driver appears to be missing a call to drm_atomic_helper_shutdown() at system shutdown time. Among other things, this means that if a panel is in use that it won't be cleanly powered off at system shutdown time. The fact that we should call

[RFT PATCH v2 01/12] drm/imx/dcss: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-21 Thread Douglas Anderson
Based on grepping through the source code this driver appears to be missing a call to drm_atomic_helper_shutdown() at system shutdown time. Among other things, this means that if a panel is in use that it won't be cleanly powered off at system shutdown time. The fact that we should call

[RFT PATCH v2 00/12] drm: call drm_atomic_helper_shutdown() at the right times

2023-09-21 Thread Douglas Anderson
This patch series came about after a _long_ discussion between me and Maxime Ripard in response to a different patch I sent out [1]. As part of that discussion, we realized that it would be good if DRM drivers consistently called drm_atomic_helper_shutdown() properly at shutdown and driver

Re: [RFT PATCH 6/6] drm/hisilicon/kirin: Call drm_atomic_helper_shutdown() at shutdown/unbind time

2023-09-21 Thread Doug Anderson
Hi, On Fri, Sep 1, 2023 at 4:41 PM Douglas Anderson wrote: > > Based on grepping through the source code this driver appears to be > missing a call to drm_atomic_helper_shutdown() at system shutdown time > and at driver unbind time. Among other things, this means that if a > panel is in use that

Re: [RFT PATCH 5/6] drm: Call drm_atomic_helper_shutdown() at shutdown/remove time for misc drivers

2023-09-21 Thread Doug Anderson
Hi, On Fri, Sep 1, 2023 at 4:41 PM Douglas Anderson wrote: > > Based on grepping through the source code these drivers appear to be > missing a call to drm_atomic_helper_shutdown() at system shutdown time > and at driver remove (or unbind) time. Among other things, this means > that if a panel

Re: [RFT PATCH 2/6] drm: Call drm_atomic_helper_shutdown() at shutdown time for misc drivers

2023-09-21 Thread Doug Anderson
Hi, On Fri, Sep 1, 2023 at 4:40 PM Douglas Anderson wrote: > > Based on grepping through the source code these drivers appear to be > missing a call to drm_atomic_helper_shutdown() at system shutdown > time. Among other things, this means that if a panel is in use that it > won't be cleanly

Re: [RFT PATCH 4/6] drm/ssd130x: Call drm_atomic_helper_shutdown() at remove time

2023-09-21 Thread Doug Anderson
Hi, On Fri, Sep 1, 2023 at 4:40 PM Douglas Anderson wrote: > > Based on grepping through the source code, this driver appears to be > missing a call to drm_atomic_helper_shutdown() at remove time. Let's > add it. > > The fact that we should call drm_atomic_helper_shutdown() in the case > of OS

Re: [RFT PATCH 3/6] drm/vc4: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-21 Thread Doug Anderson
Hi, On Fri, Sep 1, 2023 at 4:40 PM Douglas Anderson wrote: > > Based on grepping through the source code these drivers appear to be > missing a call to drm_atomic_helper_shutdown() at system shutdown > time. Among other things, this means that if a panel is in use that it > won't be cleanly

Re: [RFT PATCH 01/15] drm/armada: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-21 Thread Doug Anderson
Hi, On Wed, Sep 20, 2023 at 11:58 AM Russell King (Oracle) wrote: > > On Wed, Sep 20, 2023 at 11:03:32AM -0700, Doug Anderson wrote: > > Maxime, > > > > On Wed, Sep 13, 2023 at 8:34 AM Doug Anderson wrote: > > > > > > Hi, > > > > > > On Tue, Sep 5, 2023 at 7:23 AM Doug Anderson > > > wrote: >

Re: [PATCH] drm/mipi-dsi: Fix detach call without attach

2023-09-21 Thread Sebastian Reichel
SI host for this peripheral > * @dev: driver model device node for this peripheral > + * @attached: the DSI device has been successfully attached > * @name: DSI peripheral chip type > * @channel: virtual channel assigned to the peripheral > * @format: pixel format for video mo

[PATCH] drm/i915/guc: Suppress 'ignoring reset notification' message

2023-09-21 Thread John . C . Harrison
From: John Harrison If an active context has been banned (e.g. Ctrl+C killed) then it is likely to be reset as part of evicting it from the hardware. That results in a 'ignoring context reset notification: banned = 1' message at info level. This confuses/concerns people and makes them thing

Re: [PATCH] MAINTAINERS: Update drm-misc entry to match all drivers

2023-09-21 Thread Helen Koike
On 21/09/2023 15:12, Helen Koike wrote: Hi, On 19/09/2023 10:12, Maxime Ripard wrote: We've had a number of times when a patch slipped through and we couldn't pick them up either because our MAINTAINERS entry only covers the framework and thus we weren't Cc'd. Let's take another approach

Re: [PATCH] MAINTAINERS: Update drm-misc entry to match all drivers

2023-09-21 Thread Helen Koike
Hi, On 19/09/2023 10:12, Maxime Ripard wrote: We've had a number of times when a patch slipped through and we couldn't pick them up either because our MAINTAINERS entry only covers the framework and thus we weren't Cc'd. Let's take another approach where we match everything, and remove all the

Re: [PATCH RFC v2 00/37] drm/connector: Create HDMI Connector infrastructure

2023-09-21 Thread Maxime Ripard
Hi Hans, On Thu, Sep 21, 2023 at 06:29:29PM +0200, Hans Verkuil wrote: > On 20/09/2023 16:35, Maxime Ripard wrote: > > Hi, > > > > Here's a series that creates a subclass of drm_connector specifically > > targeted at HDMI controllers. > > > > The idea behind this series came from a recent

Re: [PATCH RFC v2 00/37] drm/connector: Create HDMI Connector infrastructure

2023-09-21 Thread Hans Verkuil
On 20/09/2023 16:35, Maxime Ripard wrote: > Hi, > > Here's a series that creates a subclass of drm_connector specifically > targeted at HDMI controllers. > > The idea behind this series came from a recent discussion on IRC during > which we discussed infoframes generation of i915 vs everything

[PULL] drm-misc-fixes

2023-09-21 Thread Thomas Zimmermann
Hi Dave and Daniel, this is the PR for drm-misc-fixes for this week. Best regards Thomas drm-misc-fixes-2023-09-21: Short summary of fixes pull: * DRM MM-test fixes * Fbdev Kconfig fixes * ivpu: * IRQ-handling fixes * meson: * Fix memory leak in HDMI EDID code * nouveau: *

[PATCH] drm/edid/firmware: drop drm_kms_helper.edid_firmware backward compat

2023-09-21 Thread Jani Nikula
Since the edid_firmware module parameter was moved from drm_kms_helper.ko to drm.ko in v4.15, we've had a backwards compatibility helper in place, with a DRM_NOTE() suggesting to migrate to drm.edid_firmware. This was added in commit ac6c35a4d8c7 ("drm: add backwards compatibility support for

Re: [PATCH drm-misc-next v4 4/8] drm/gpuvm: add common dma-resv per struct drm_gpuvm

2023-09-21 Thread Danilo Krummrich
On 9/21/23 16:34, Christian König wrote: Am 21.09.23 um 16:25 schrieb Boris Brezillon: On Thu, 21 Sep 2023 15:34:44 +0200 Danilo Krummrich wrote: On 9/21/23 09:39, Christian König wrote: Am 20.09.23 um 16:42 schrieb Danilo Krummrich: Provide a common dma-resv for GEM objects not being

Re: [PATCH drm-misc-next v4 4/8] drm/gpuvm: add common dma-resv per struct drm_gpuvm

2023-09-21 Thread Boris Brezillon
On Thu, 21 Sep 2023 16:34:54 +0200 Christian König wrote: > Am 21.09.23 um 16:25 schrieb Boris Brezillon: > > On Thu, 21 Sep 2023 15:34:44 +0200 > > Danilo Krummrich wrote: > > > >> On 9/21/23 09:39, Christian König wrote: > >>> Am 20.09.23 um 16:42 schrieb Danilo Krummrich: >

[PULL] drm-intel-fixes

2023-09-21 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-fixes-2023-09-21: - Prevent error pointer dereference (Dan Carpenter) - Fix PMU busyness values when using GuC mode (Umesh) Thanks, Rodrigo. The following changes since commit ce9ecca0238b140b88f43859b211c9fdfd8e5b70: Linux 6.6-rc2 (2023-09-17

Re: [PATCH 01/15] dt-bindings: mailbox: Add property for CMDQ secure driver

2023-09-21 Thread 林睿祥

Re: [PATCH 00/10] Add mediate-drm secure flow for SVP

2023-09-21 Thread 林睿祥

Re: [PATCH 00/15] Add CMDQ secure driver for SVP

2023-09-21 Thread 林睿祥

Re: [PATCH drm-misc-next v4 4/8] drm/gpuvm: add common dma-resv per struct drm_gpuvm

2023-09-21 Thread Danilo Krummrich
On 9/21/23 16:25, Boris Brezillon wrote: On Thu, 21 Sep 2023 15:34:44 +0200 Danilo Krummrich wrote: On 9/21/23 09:39, Christian König wrote: Am 20.09.23 um 16:42 schrieb Danilo Krummrich: Provide a common dma-resv for GEM objects not being used outside of this GPU-VM. This is used in a

Re: [PATCH v8 2/7] phy: Add HDMI configuration options

2023-09-21 Thread Vinod Koul
On 21-09-23, 16:01, Vinod Koul wrote: > On 22-08-23, 20:22, Dmitry Baryshkov wrote: > > On 22/08/2023 16:54, Vinod Koul wrote: > > > On 17-08-23, 13:05, Dmitry Baryshkov wrote: > > >> On 08/08/2023 11:32, Sandor Yu wrote: > > >>> Allow HDMI PHYs to be configured through the generic > > >>>

Re: [PATCH drm-misc-next v4 4/8] drm/gpuvm: add common dma-resv per struct drm_gpuvm

2023-09-21 Thread Christian König
Am 21.09.23 um 16:25 schrieb Boris Brezillon: On Thu, 21 Sep 2023 15:34:44 +0200 Danilo Krummrich wrote: On 9/21/23 09:39, Christian König wrote: Am 20.09.23 um 16:42 schrieb Danilo Krummrich: Provide a common dma-resv for GEM objects not being used outside of this GPU-VM. This is used

Re: (subset) [PATCH v9 0/7] Initial support Cadence MHDP8501(HDMI/DP) for i.MX8MQ

2023-09-21 Thread Vinod Koul
On Thu, 07 Sep 2023 09:05:27 +0800, Sandor Yu wrote: > The patch set initial support Cadence MHDP8501(HDMI/DP) DRM bridge > drivers and Cadence HDP-TX PHY(HDMI/DP) drivers for Freescale i.MX8MQ. > > The patch set compose of DRM bridge drivers and PHY drivers. > > Both of them need the followed

Re: [PATCH v6 0/8] Initial support for Cadence MHDP8501(HDMI/DP) for i.MX8MQ

2023-09-21 Thread Vinod Koul
On Thu, 15 Jun 2023 09:38:10 +0800, Sandor Yu wrote: > The patch set initial support for Cadence MHDP8501(HDMI/DP) DRM bridge > drivers and Cadence HDP-TX PHY(HDMI/DP) drivers for Freescale i.MX8MQ. > > The patch set compose of DRM bridge drivers and PHY drivers. > > Both of them need the

Re: [PATCH 11/15] soc: mediatek: Add cmdq_insert_backup_cookie before EOC for secure pkt

2023-09-21 Thread 林睿祥

Re: [PATCH 08/15] soc: mediatek: Add cmdq_pkt_finalize_loop to CMDQ driver

2023-09-21 Thread 林睿祥

Re: [PATCH drm-misc-next v4 4/8] drm/gpuvm: add common dma-resv per struct drm_gpuvm

2023-09-21 Thread Boris Brezillon
On Thu, 21 Sep 2023 15:34:44 +0200 Danilo Krummrich wrote: > On 9/21/23 09:39, Christian König wrote: > > Am 20.09.23 um 16:42 schrieb Danilo Krummrich: > >> Provide a common dma-resv for GEM objects not being used outside of this > >> GPU-VM. This is used in a subsequent patch to generalize

Re: [PATCH drm-misc-next v4 4/8] drm/gpuvm: add common dma-resv per struct drm_gpuvm

2023-09-21 Thread Christian König
Am 21.09.23 um 15:34 schrieb Danilo Krummrich: On 9/21/23 09:39, Christian König wrote: Am 20.09.23 um 16:42 schrieb Danilo Krummrich: Provide a common dma-resv for GEM objects not being used outside of this GPU-VM. This is used in a subsequent patch to generalize dma-resv, external and

Re: [PATCH] drm/ssd130x: Drop _helper prefix from struct drm_*_helper_funcs callbacks

2023-09-21 Thread Maxime Ripard
On Thu, 14 Sep 2023 21:51:24 +0200, Javier Martinez Canillas wrote: > The driver uses a naming convention where functions for struct drm_*_funcs > callbacks are named ssd130x_$object_$operation, while the callbacks for > struct drm_*_helper_funcs are named ssd130x_$object_helper_$operation. > >

[PATCH 5/5] drm/amd/display: Move the memory allocation out of dcn20_validate_bandwidth_fp().

2023-09-21 Thread Sebastian Andrzej Siewior
dcn20_validate_bandwidth_fp() is invoked while FPU access has been enabled. FPU access requires disabling preemption even on PREEMPT_RT. It is not possible to allocate memory with disabled preemption even with GFP_ATOMIC on PREEMPT_RT. Move the memory allocation before FPU access is enabled. To

Re: [PATCH 06/15] mailbox: mediatek: Add cmdq_mbox_stop to disable GCE thread

2023-09-21 Thread 林睿祥

[PATCH 4/5] drm/amd/display: Move the memory allocation out of dcn21_validate_bandwidth_fp().

2023-09-21 Thread Sebastian Andrzej Siewior
dcn21_validate_bandwidth_fp() is invoked while FPU access has been enabled. FPU access requires disabling preemption even on PREEMPT_RT. It is not possible to allocate memory with disabled preemption even with GFP_ATOMIC on PREEMPT_RT. Move the memory allocation before FPU access is enabled.

[PATCH 3/5] drm/amd/display: Add a warning if the FPU is used outside from task context.

2023-09-21 Thread Sebastian Andrzej Siewior
Add a warning if the FPU is used from any context other than task context. This is only precaution since the code is not able to be used from softirq while the API allows it on x86 for instance. Signed-off-by: Sebastian Andrzej Siewior --- drivers/gpu/drm/amd/display/amdgpu_dm/dc_fpu.c | 1 + 1

[PATCH 0/5] drm/amd/display: Remove migrate-disable and move memory allocation.

2023-09-21 Thread Sebastian Andrzej Siewior
Hi, I stumbled uppon the amdgpu driver via a bugzilla report. The actual fix is #4 + #5 and the rest was made while looking at the code. Sebastian

[PATCH 1/5] drm/amd/display: Remove migrate_en/dis from dc_fpu_begin().

2023-09-21 Thread Sebastian Andrzej Siewior
This is a revert of the commit mentioned below while it is not wrong, as in the kernel will explode, having migrate_disable() here it is complete waste of resources. Additionally commit message is plain wrong the review tag does not make it any better. The migrate_disable() interface has a fat

[PATCH 2/5] drm/amd/display: Simplify the per-CPU usage.

2023-09-21 Thread Sebastian Andrzej Siewior
The fpu_recursion_depth counter is used to ensure that dc_fpu_begin() can be invoked multiple times while the FPU-disable function itself is only invoked once. Also the counter part (dc_fpu_end()) is ballanced properly. Instead of using the get_cpu_ptr() dance around the inc it is simpler to

Re: [PATCH v8 2/7] phy: Add HDMI configuration options

2023-09-21 Thread Vinod Koul
On 22-08-23, 20:22, Dmitry Baryshkov wrote: > On 22/08/2023 16:54, Vinod Koul wrote: > > On 17-08-23, 13:05, Dmitry Baryshkov wrote: > >> On 08/08/2023 11:32, Sandor Yu wrote: > >>> Allow HDMI PHYs to be configured through the generic > >>> functions through a custom structure added to the generic

Re: [PATCH 08/31] phy: rockchip-inno-usb2: Split ID interrupt phy registers

2023-09-21 Thread Vinod Koul
On 29-08-23, 19:16, Alex Bee wrote: > Commit 51a9b2c03dd3 ("phy: rockchip-inno-usb2: Handle ID IRQ") added ID > detection interrupt registers. However the current implementation assumes > that falling and rising edge interrupt are always enabled in registers > spaning over subsequent bits. > That

[PATCH v2] drm: renesas: rcar-du: use proper naming for R-Car

2023-09-21 Thread Wolfram Sang
Not RCAR, but R-Car. Signed-off-by: Wolfram Sang Reviewed-by: Kieran Bingham --- Changes since v1: * rebased to 6.6-rc2 * added tag from Kieran (Thanks!) drivers/gpu/drm/renesas/rcar-du/rcar_du_plane.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH drm-misc-next v4 4/8] drm/gpuvm: add common dma-resv per struct drm_gpuvm

2023-09-21 Thread Danilo Krummrich
On 9/21/23 09:39, Christian König wrote: Am 20.09.23 um 16:42 schrieb Danilo Krummrich: Provide a common dma-resv for GEM objects not being used outside of this GPU-VM. This is used in a subsequent patch to generalize dma-resv, external and evicted object handling and GEM validation.

Re: [PATCH] drm/ssd130x: Drop _helper prefix from struct drm_*_helper_funcs callbacks

2023-09-21 Thread Maxime Ripard
Hi, On Thu, Sep 21, 2023 at 10:52:14AM +0200, Thomas Zimmermann wrote: > Am 21.09.23 um 09:44 schrieb Maxime Ripard: > > On Mon, Sep 18, 2023 at 09:19:07AM +0200, Javier Martinez Canillas wrote: > > > Thomas Zimmermann writes: > > > > > > > Hi > > > > > > > > Am 14.09.23 um 21:51 schrieb

Re: [PATCH 5.4 000/367] 5.4.257-rc1 review

2023-09-21 Thread Sui Jingfeng
Hi, On 2023/9/21 21:10, Sui Jingfeng wrote: return -ERR_PTR(-ENOMEM) return ERR_PTR(-ENOMEM);

[PATCH v2] drm/dp_mst: Fix NULL deref in get_mst_branch_device_by_guid_helper()

2023-09-21 Thread Lukasz Majczak
As drm_dp_get_mst_branch_device_by_guid() is called from drm_dp_get_mst_branch_device_by_guid(), we need to check mstb parameter, Check mstb parameter, otherwise NULL dereference may occur in the call to memcpy() and cause following: [12579.365869] BUG: kernel NULL pointer dereference, address:

Re: [PATCH 5.4 000/367] 5.4.257-rc1 review

2023-09-21 Thread Sui Jingfeng
Hi, On 2023/9/21 20:08, Naresh Kamboju wrote: On Wed, 20 Sept 2023 at 14:25, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.4.257 release. There are 367 patches in this series, all will be posted as a response to this one. If anyone has any issues with

Re: [PATCH 7/8] drm/i915/dsc: Add debugfs entry to validate DSC fractional bpp

2023-09-21 Thread Sharma, Swati2
On 21-Sep-23 5:44 PM, Jani Nikula wrote: On Thu, 21 Sep 2023, "Sharma, Swati2" wrote: On 21-Sep-23 1:30 PM, Jani Nikula wrote: On Wed, 13 Sep 2023, Mitul Golani wrote: From: Swati Sharma DSC_Sink_BPP_Precision entry is added to i915_dsc_fec_support_show to depict sink's precision. Also,

Re: (subset) [PATCH] MAINTAINERS: Update gma500 git repo

2023-09-21 Thread Maxime Ripard
On Thu, 21 Sep 2023 13:00:38 +0200, Maxime Ripard wrote: > The GMA500 driver has been handled through drm-misc for a while but the > git repo hasn't been updated. Make sure it points to the right place. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: [PATCH 7/8] drm/i915/dsc: Add debugfs entry to validate DSC fractional bpp

2023-09-21 Thread Jani Nikula
On Thu, 21 Sep 2023, "Sharma, Swati2" wrote: > On 21-Sep-23 1:30 PM, Jani Nikula wrote: >> On Wed, 13 Sep 2023, Mitul Golani >> wrote: >>> From: Swati Sharma >>> >>> DSC_Sink_BPP_Precision entry is added to i915_dsc_fec_support_show >>> to depict sink's precision. >>> Also, new debugfs entry

Re: [PATCH] drm/bridge: Add 200ms delay to wait FW HPD status stable

2023-09-21 Thread Laurent Pinchart
The subject line is missing the driver name. On Thu, Sep 21, 2023 at 03:09:10PM +0300, Jani Nikula wrote: > On Thu, 21 Sep 2023, Xin Ji wrote: > > For the none-interrupt design(sink device is panel, polling HPD s/none-interrupt/no-interrupt/ ? s/design/design / > > status when chip power on),

Re: [PATCH] drm/bridge: Add 200ms delay to wait FW HPD status stable

2023-09-21 Thread Jani Nikula
On Thu, 21 Sep 2023, Xin Ji wrote: > For the none-interrupt design(sink device is panel, polling HPD > status when chip power on), anx7625 FW has more than 200ms HPD > de-bounce time in FW, for the safety to get HPD status, driver > better to wait 200ms before HPD detection after OS resume back.

Re: [PATCH 5.4 000/367] 5.4.257-rc1 review

2023-09-21 Thread Naresh Kamboju
On Wed, 20 Sept 2023 at 14:25, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 5.4.257 release. > There are 367 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > >

Re: [PATCH 7/8] drm/i915/dsc: Add debugfs entry to validate DSC fractional bpp

2023-09-21 Thread Sharma, Swati2
On 21-Sep-23 1:30 PM, Jani Nikula wrote: On Wed, 13 Sep 2023, Mitul Golani wrote: From: Swati Sharma DSC_Sink_BPP_Precision entry is added to i915_dsc_fec_support_show to depict sink's precision. Also, new debugfs entry is created to enforce fractional bpp. If Force_DSC_Fractional_BPP_en is

[PATCH 5/5] drm/i915: Implement fdinfo memory stats printing

2023-09-21 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Use the newly added drm_print_memory_stats helper to show memory utilisation of our objects in drm/driver specific fdinfo output. To collect the stats we walk the per memory regions object lists and accumulate object size into the respective drm_memory_stats categories.

[PATCH 2/5] drm/i915: Record which client owns a VM

2023-09-21 Thread Tvrtko Ursulin
From: Tvrtko Ursulin To enable accounting of indirect client memory usage (such as page tables) in the following patch, lets start recording the creator of each PPGTT. Signed-off-by: Tvrtko Ursulin Reviewed-by: Aravind Iddamsetty --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 11

[PATCH 4/5] drm/i915: Account ring buffer and context state storage

2023-09-21 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Account ring buffers and logical context space against the owning client memory usage stats. Signed-off-by: Tvrtko Ursulin Reviewed-by: Aravind Iddamsetty --- drivers/gpu/drm/i915/gt/intel_context.c | 14 ++ drivers/gpu/drm/i915/i915_drm_client.c | 10

[PATCH 3/5] drm/i915: Track page table backing store usage

2023-09-21 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Account page table backing store against the owning client memory usage stats. Signed-off-by: Tvrtko Ursulin Reviewed-by: Aravind Iddamsetty --- drivers/gpu/drm/i915/gt/intel_gtt.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[PATCH 1/5] drm/i915: Add ability for tracking buffer objects per client

2023-09-21 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In order to show per client memory usage lets add some infrastructure which enables tracking buffer objects owned by clients. We add a per client list protected by a new per client lock and to support delayed destruction (post client exit) we make tracked objects hold

[PATCH v7 0/5] fdinfo memory stats

2023-09-21 Thread Tvrtko Ursulin
From: Tvrtko Ursulin A short series to enable fdinfo memory stats for i915. I added tracking of most classes of objects (user objects, page tables, context state, ring buffers) which contribute to client's memory footprint and am accouting their memory use along the similar lines as in Rob's

Re: [PATCH] omap: dsi: do not WARN on detach if dsidev was never attached

2023-09-21 Thread Tony Lindgren
* Tomi Valkeinen [230921 10:53]: > I sent a patch to the DSI framework code, > "[PATCH] drm/mipi-dsi: Fix detach call without attach". > > If that fixes the issue (please test, I don't have a suitable platform), > perhaps it's a better fix as detach really shouldn't be called if attach has > not

Re: [PATCH] drm/mipi-dsi: Fix detach call without attach

2023-09-21 Thread Tony Lindgren
* Tomi Valkeinen [230921 10:51]: > mipi_dsi_host_unregister() will call two functions for all its DSI > peripheral devices: mipi_dsi_detach() and mipi_dsi_device_unregister(). > The latter makes sense, as the device exists, but the former may be > wrong as attach has not necessarily been done. >

Re: [PATCH] MAINTAINERS: Update gma500 git repo

2023-09-21 Thread Patrik Jakobsson
On Thu, Sep 21, 2023 at 1:00 PM Maxime Ripard wrote: > > The GMA500 driver has been handled through drm-misc for a while but the > git repo hasn't been updated. Make sure it points to the right place. > > Signed-off-by: Maxime Ripard Acked-by: Patrik Jakobsson > > --- > > Cc: Patrik Jakobsson

Re: [PATCH v2] MAINTAINERS: Update drm-misc entry to match all drivers

2023-09-21 Thread Thomas Zimmermann
Am 21.09.23 um 12:57 schrieb Maxime Ripard: We've had a number of times when a patch slipped through and we couldn't pick them up either because our MAINTAINERS entry only covers the framework and thus we weren't Cc'd. Let's take another approach where we match everything, and remove all the

[PATCH v5 1/4] video: fbdev: atyfb: only use ioremap_uc() on i386 and ia64

2023-09-21 Thread Baoquan He
From: Arnd Bergmann ioremap_uc() is only meaningful on old x86-32 systems with the PAT extension, and on ia64 with its slightly unconventional ioremap() behavior, everywhere else this is the same as ioremap() anyway. Change the only driver that still references ioremap_uc() to only do so on

[PATCH] MAINTAINERS: Update gma500 git repo

2023-09-21 Thread Maxime Ripard
The GMA500 driver has been handled through drm-misc for a while but the git repo hasn't been updated. Make sure it points to the right place. Signed-off-by: Maxime Ripard --- Cc: Patrik Jakobsson --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS

[PATCH v2] MAINTAINERS: Update drm-misc entry to match all drivers

2023-09-21 Thread Maxime Ripard
We've had a number of times when a patch slipped through and we couldn't pick them up either because our MAINTAINERS entry only covers the framework and thus we weren't Cc'd. Let's take another approach where we match everything, and remove all the drivers that are not maintained through

Re: [PATCH] omap: dsi: do not WARN on detach if dsidev was never attached

2023-09-21 Thread Tomi Valkeinen
Hi, On 19/09/2023 16:37, H. Nikolaus Schaller wrote: dsi_init_output() called by dsi_probe() may fail. In that case mipi_dsi_host_unregister() is called which may call omap_dsi_host_detach() with uninitialized dsi->dsidev because omap_dsi_host_attach() was never called before. This happens if

[PATCH] drm/mipi-dsi: Fix detach call without attach

2023-09-21 Thread Tomi Valkeinen
dsi_device_info { struct mipi_dsi_device { struct mipi_dsi_host *host; struct device dev; + bool attached; char name[DSI_DEV_NAME_SIZE]; unsigned int channel; --- base-commit: 9fc75c40faa29df14ba16066be6bdfaea9f39ce4 change-id: 20230921-dsi-detach-fix-6736f7a48ba7 Best regards, -- Tomi Valkeinen

Re: MAINTAINERS: Update drm-misc entry to match all drivers

2023-09-21 Thread Maxime Ripard
On Thu, Sep 21, 2023 at 05:09:07PM +0800, Sui Jingfeng wrote: > On 2023/9/21 16:47, Maxime Ripard wrote: > > Adding Paul in Cc > > > > On Thu, Sep 21, 2023 at 04:25:50PM +0800, suijingfeng wrote: > > > On 2023/9/19 21:12, Maxime Ripard wrote: > > > > We've had a number of times when a patch

[PATCH v3 1/2] drm/bridge: megachips-stdpxxxx-ge-b850v3-fw: switch to drm_do_get_edid()

2023-09-21 Thread Ian Ray
Migrate away from custom EDID parsing and validity checks. Note: This is a follow-up to the original RFC by Jani [1]. The first submission in this series should have been marked v2. [1] https://patchwork.freedesktop.org/patch/msgid/20230901102400.552254-1-jani.nik...@intel.com

[PATCH v3 2/2] MAINTAINERS: Update entry for megachips-stdpxxxx-ge-b850v3-fw

2023-09-21 Thread Ian Ray
Replace Martin, who has left GE. Signed-off-by: Ian Ray --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index bf0f54c..31bb835 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -13524,7 +13524,7 @@ F: drivers/usb/mtu3/ MEGACHIPS

Re: [Intel-gfx] [PATCH] drm/i915/gem: Allow users to disable waitboost

2023-09-21 Thread Tvrtko Ursulin
On 20/09/2023 22:56, Vinay Belgaumkar wrote: Provide a bit to disable waitboost while waiting on a gem object. Waitboost results in increased power consumption by requesting RP0 while waiting for the request to complete. Add a bit in the gem_wait() IOCTL where this can be disabled. This is

Re: MAINTAINERS: Update drm-misc entry to match all drivers

2023-09-21 Thread Patrik Jakobsson
On Thu, Sep 21, 2023 at 10:47:58AM +0200, Maxime Ripard wrote: > Hi, > > Adding Paul in Cc > > On Thu, Sep 21, 2023 at 04:25:50PM +0800, suijingfeng wrote: > > On 2023/9/19 21:12, Maxime Ripard wrote: > > > We've had a number of times when a patch slipped through and we couldn't > > > pick them

Re: [PATCH 1/2] drm/bridge: megachips-stdpxxxx-ge-b850v3-fw: switch to drm_do_get_edid()

2023-09-21 Thread Jani Nikula
On Thu, 21 Sep 2023, Ian Ray wrote: > Migrate away from custom EDID parsing and validity checks. > > Signed-off-by: Jani Nikula > Signed-off-by: Ian Ray So this is v2 of [1]. For future reference, people can get really fussy about preserving authorship. I don't really mind in this case,

Re: MAINTAINERS: Update drm-misc entry to match all drivers

2023-09-21 Thread Maxime Ripard
Hi Paul, On Thu, Sep 21, 2023 at 10:57:46AM +0200, Paul Cercueil wrote: > Le jeudi 21 septembre 2023 à 10:47 +0200, Maxime Ripard a écrit : > > On Thu, Sep 21, 2023 at 04:25:50PM +0800, suijingfeng wrote: > > > On 2023/9/19 21:12, Maxime Ripard wrote: > > > > We've had a number of times when a

Re: [PATCH] MAINTAINERS: Update drm-misc entry to match all drivers

2023-09-21 Thread Maxime Ripard
Hi Thomas, On Thu, Sep 21, 2023 at 10:57:57AM +0200, Thomas Zimmermann wrote: > Am 19.09.23 um 15:12 schrieb Maxime Ripard: > > We've had a number of times when a patch slipped through and we couldn't > > pick them up either because our MAINTAINERS entry only covers the > > framework and thus we

  1   2   >