RE: [PATCH 09/28] drm: Add Color ops capability property

2024-02-13 Thread Shankar, Uma
> -Original Message- > From: Sebastian Wick > Sent: Tuesday, February 13, 2024 5:35 PM > To: Shankar, Uma > Cc: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > ville.syrj...@linux.intel.com; pekka.paala...@collabora.com; > cont...@emersion.fr;

RE: [PATCH 08/28] drm: Add Color lut range attributes

2024-02-13 Thread Shankar, Uma
> -Original Message- > From: Sebastian Wick > Sent: Tuesday, February 13, 2024 5:34 PM > To: Shankar, Uma > Cc: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > ville.syrj...@linux.intel.com; pekka.paala...@collabora.com; > cont...@emersion.fr;

RE: [PATCH 00/28] Plane Color Pipeline support for Intel platforms

2024-02-13 Thread Shankar, Uma
> -Original Message- > From: Pekka Paalanen > Sent: Tuesday, February 13, 2024 4:32 PM > To: Shankar, Uma > Cc: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > ville.syrj...@linux.intel.com; cont...@emersion.fr; harry.wentl...@amd.com; > m...@igalia.com;

RE: [PATCH 17/28] drm/i915: Define segmented Lut and add capabilities to colorop

2024-02-13 Thread Shankar, Uma
> -Original Message- > From: dri-devel On Behalf Of Pekka > Paalanen > Sent: Tuesday, February 13, 2024 3:07 PM > To: Shankar, Uma > Cc: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > ville.syrj...@linux.intel.com; cont...@emersion.fr; harry.wentl...@amd.com; >

[PATCH] Revert "drm/panel-edp: Add auo_b116xa3_mode"

2024-02-13 Thread Hsin-Yi Wang
This reverts commit 70e0d5550f5cec301ad116703b840a539fe985dc. The overridden mode fixes the panel glitching issue on mt8186 chromebook. However, it causes the internal display not working on mt8173 chromebook. Revert the overridden mode for now to let mt8173 have a functional display.

RE: [PATCH 05/28] drm: Add support for 3x3 CTM

2024-02-13 Thread Shankar, Uma
> -Original Message- > From: Pekka Paalanen > Sent: Tuesday, February 13, 2024 2:45 PM > To: Shankar, Uma > Cc: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > ville.syrj...@linux.intel.com; cont...@emersion.fr; harry.wentl...@amd.com; > m...@igalia.com;

Re: [PATCH] drm/dp: Don't attempt AUX transfers when eDP panels are not powered

2024-02-13 Thread Hsin-Yi Wang
On Wed, Feb 14, 2024 at 2:23 PM Douglas Anderson wrote: > > If an eDP panel is not powered on then any attempts to talk to it over > the DP AUX channel will timeout. Unfortunately these attempts may be > quite slow. Userspace can initiate these attempts either via a > /dev/drm_dp_auxN device or

[PATCH v3 2/2] fbcon: Defer console takeover for splash screens to first switch

2024-02-13 Thread Daniel van Vugt
Until now, deferred console takeover only meant defer until there is output. But that risks stepping on the toes of userspace splash screens, as console messages may appear before the splash screen. So check the command line for the expectation of userspace splash and if present then extend the

[PATCH v3 1/2] dummycon: Add dummycon_(un)register_switch_notifier

2024-02-13 Thread Daniel van Vugt
To detect switch attempts before a real console exists. This will be used for the same purpose as dummycon_(un)register_output_notifier, for fbcon to detect a more polite time to take over. Signed-off-by: Daniel van Vugt --- drivers/video/console/dummycon.c | 35 +++-

[PATCH 2/2] drm/tests/drm_buddy: add alloc_contiguous test

2024-02-13 Thread Arunpravin Paneer Selvam
From: Matthew Auld Sanity check DRM_BUDDY_CONTIGUOUS_ALLOCATION. References: https://gitlab.freedesktop.org/drm/amd/-/issues/3097 Signed-off-by: Matthew Auld Cc: Arunpravin Paneer Selvam Cc: Limonciello Cc: Christian König Reviewed-by: Arunpravin Paneer Selvam Signed-off-by: Arunpravin

[PATCH 1/2] drm/buddy: Fix alloc_range() error handling code

2024-02-13 Thread Arunpravin Paneer Selvam
Few users have observed display corruption when they boot the machine to KDE Plasma or playing games. We have root caused the problem that whenever alloc_range() couldn't find the required memory blocks the function was returning SUCCESS in some of the corner cases. The right approach would be if

Re: [etnaviv-next v13 7/7] drm/etnaviv: Add support for vivante GPU cores attached via PCI(e)

2024-02-13 Thread Sui Jingfeng
Hi, On 2024/2/9 19:02, Daniel Vetter wrote: On Thu, Feb 08, 2024 at 04:27:02PM +0100, Maxime Ripard wrote: On Wed, Feb 07, 2024 at 10:35:49AM +0100, Daniel Vetter wrote: On Wed, Feb 07, 2024 at 01:27:59AM +0800, Sui Jingfeng wrote: The component helper functions are the glue, which is used

Re: [PATCH] nouveau/gsp: add kconfig option to enable GSP paths by default

2024-02-13 Thread Dave Airlie
(ignore this one, sent another just after) On Wed, 14 Feb 2024 at 13:40, Dave Airlie wrote: > > From: Dave Airlie > > Turing and Ampere will continue to use the old paths by default, > but we should allow distros to decide what the policy is. > > Signed-off-by: Dave Airlie > --- >

[PATCH] nouveau/gsp: add kconfig option to enable GSP paths by default

2024-02-13 Thread Dave Airlie
From: Dave Airlie Turing and Ampere will continue to use the old paths by default, but we should allow distros to decide what the policy is. Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/Kconfig| 8 drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c | 6 +- 2

[PATCH] nouveau/gsp: add kconfig option to enable GSP paths by default

2024-02-13 Thread Dave Airlie
From: Dave Airlie Turing and Ampere will continue to use the old paths by default, but we should allow distros to decide what the policy is. Signed-off-by: Dave Airlie --- drivers/gpu/drm/nouveau/Kconfig| 8 drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c | 3 +++ 2

Re: [PATCH 1/2] [v3] nouveau: add command-line GSP-RM registry support

2024-02-13 Thread kernel test robot
Hi Timur, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-intel/for-linux-next-fixes] [also build test WARNING on drm-tip/drm-tip linus/master v6.8-rc4 next-20240213] [cannot apply to drm-misc/drm-misc-next drm/drm-next drm-exynos/exynos-drm-next drm

Re: [PATCH 01/28] [NOT FOR REVIEW] drm: color pipeline base work

2024-02-13 Thread kernel test robot
Hi Uma, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm/drm-next next-20240213] [cannot apply to drm-intel/for-linux-next drm-intel/for-linux-next-fixes linus/master v6.8-rc4] [If your patch is applied

Coverity: jpeg_v4_0_5_start(): Code maintainability issues

2024-02-13 Thread coverity-bot
Hello! This is an experimental semi-automated report about issues detected by Coverity from a scan of next-20240213 as part of the linux-next scan project: https://scan.coverity.com/projects/linux-next-weekly-scan You're getting this email because you were associated with the identified lines

[PATCH] drm/dp: move intel_dp_vsc_sdp_pack() to generic helper

2024-02-13 Thread Abhinav Kumar
intel_dp_vsc_sdp_pack() can be re-used by other DRM drivers as well. Lets move this to drm_dp_helper to achieve this. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/display/drm_dp_helper.c | 78 + drivers/gpu/drm/i915/display/intel_dp.c | 73 +--

[PATCH 2/2] drm/amd/display: clean else not following close brace

2024-02-13 Thread Joao Paulo Pereira da Silva
From: jppaulo Put else statement in the same line and after the close brace. Signed-off-by: Joao Paulo Pereira da Silva --- drivers/gpu/drm/amd/display/dc/core/dc_link_enc_cfg.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH 1/2] drm/amd/display: clean inconsistent indenting

2024-02-13 Thread Joao Paulo Pereira da Silva
From: jppaulo Clean some wrong indenting that throw errors in checkpatch. Signed-off-by: Joao Paulo Pereira da Silva --- drivers/gpu/drm/amd/display/dc/core/dc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c

[PATCH 0/2] drm/amd/display: clean codestyle errors

2024-02-13 Thread Joao Paulo Pereira da Silva
jppaulo (2): drm/amd/display: clean inconsistent indenting drm/amd/display: clean else not following close brace drivers/gpu/drm/amd/display/dc/core/dc.c | 6 +++--- drivers/gpu/drm/amd/display/dc/core/dc_link_enc_cfg.c | 3 +-- 2 files changed, 4 insertions(+), 5 deletions(-)

[PATCH v2] iosys-map: fix typo

2024-02-13 Thread Randy Dunlap
Correct a spello/typo in comments. Signed-off-by: Randy Dunlap Cc: Thomas Zimmermann Cc: dri-devel@lists.freedesktop.org --- v2: don't change "set up" to "setup" (Thomas) include/linux/iosys-map.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -- a/include/linux/iosys-map.h

Re: [PATCH v2 16/19] drm/msm/dpu: modify encoder programming for CDM over DP

2024-02-13 Thread Abhinav Kumar
On 2/13/2024 1:16 PM, Dmitry Baryshkov wrote: On Tue, 13 Feb 2024 at 23:10, Abhinav Kumar wrote: On 2/13/2024 11:31 AM, Dmitry Baryshkov wrote: On Tue, 13 Feb 2024 at 20:46, Abhinav Kumar wrote: On 2/13/2024 10:23 AM, Dmitry Baryshkov wrote: On Tue, 13 Feb 2024 at 19:32, Abhinav

Re: [PATCH 04/10] hid/hid-picolcd: Remove struct backlight_ops.check_fb

2024-02-13 Thread kernel test robot
Hi Thomas, kernel test robot noticed the following build errors: [auto build test ERROR on lee-backlight/for-backlight-next] [also build test ERROR on lee-backlight/for-backlight-fixes hid/for-next lee-leds/for-leds-next linus/master v6.8-rc4 next-20240213] [If your patch is applied

Re: [PATCH v2 16/19] drm/msm/dpu: modify encoder programming for CDM over DP

2024-02-13 Thread Dmitry Baryshkov
On Tue, 13 Feb 2024 at 23:10, Abhinav Kumar wrote: > > > > On 2/13/2024 11:31 AM, Dmitry Baryshkov wrote: > > On Tue, 13 Feb 2024 at 20:46, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 2/13/2024 10:23 AM, Dmitry Baryshkov wrote: > >>> On Tue, 13 Feb 2024 at 19:32, Abhinav Kumar > >>>

Re: [PATCH 01/28] [NOT FOR REVIEW] drm: color pipeline base work

2024-02-13 Thread kernel test robot
Hi Uma, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm/drm-next next-20240213] [cannot apply to drm-intel/for-linux-next drm-intel/for-linux-next-fixes linus/master v6.8-rc4] [If your patch is applied

Re: [RFC PATCH net-next v5 07/14] page_pool: devmem support

2024-02-13 Thread Mina Almasry
On Tue, Feb 13, 2024 at 5:28 AM Pavel Begunkov wrote: > > On 12/18/23 02:40, Mina Almasry wrote: > > Convert netmem to be a union of struct page and struct netmem. Overload > > the LSB of struct netmem* to indicate that it's a net_iov, otherwise > > it's a page. > > > > Currently these entries in

Re: [PATCH v2 16/19] drm/msm/dpu: modify encoder programming for CDM over DP

2024-02-13 Thread Abhinav Kumar
On 2/13/2024 11:31 AM, Dmitry Baryshkov wrote: On Tue, 13 Feb 2024 at 20:46, Abhinav Kumar wrote: On 2/13/2024 10:23 AM, Dmitry Baryshkov wrote: On Tue, 13 Feb 2024 at 19:32, Abhinav Kumar wrote: On 2/13/2024 3:18 AM, Dmitry Baryshkov wrote: On Sat, 10 Feb 2024 at 03:53, Paloma

Re: [PATCH] drm/rockchip: vop2: add a missing unlock in vop2_crtc_atomic_enable()

2024-02-13 Thread Heiko Stuebner
On Fri, 19 Jan 2024 11:08:40 -0800, Harshit Mogalapalli wrote: > Unlock before returning on the error path. > > Applied, thanks! [1/1] drm/rockchip: vop2: add a missing unlock in vop2_crtc_atomic_enable() commit: b6ddaa63f728d26c12048aed76be99c24f435c41 Best regards, -- Heiko Stuebner

Re: [RFC PATCH net-next v5 05/14] netdev: netdevice devmem allocator

2024-02-13 Thread Mina Almasry
On Tue, Feb 13, 2024 at 5:24 AM Pavel Begunkov wrote: > > On 12/18/23 02:40, Mina Almasry wrote: > > Implement netdev devmem allocator. The allocator takes a given struct > > netdev_dmabuf_binding as input and allocates net_iov from that > > binding. > > > > The allocation simply delegates to the

Re: [PATCH i-g-t v3] benchmarks: Add VKMS benchmark

2024-02-13 Thread Arthur Grillo
On 13/02/24 15:06, Kamil Konieczny wrote: > Hi Arthur, > On 2024-02-09 at 16:39:09 -0300, Arthur Grillo wrote: > > I will merge this with different description: > > [PATCH i-g-t v3] benchmarks: Add KMS frambuffer stress benchmark > > Is this ok? Its ok Best Regards, ~Arthur Grillo > >

[PATCH] drm: ci: use clk_ignore_unused for apq8016

2024-02-13 Thread Dmitry Baryshkov
If the ADV7511 bridge driver is compiled as a module, while DRM_MSM is built-in, the clk_disable_unused congests with the runtime PM handling of the DSI PHY for the clk_prepare_lock(). This causes apq8016 runner to fail without completing any jobs ([1]). Drop the BM_CMDLINE which duplicate the

Re: [PATCH v2] drm/i915: Add GuC submission interface version query

2024-02-13 Thread Souza, Jose
On Fri, 2024-02-09 at 09:06 +, Tvrtko Ursulin wrote: > On 08/02/2024 17:55, Souza, Jose wrote: > > On Thu, 2024-02-08 at 07:19 -0800, José Roberto de Souza wrote: > > > On Thu, 2024-02-08 at 14:59 +, Tvrtko Ursulin wrote: > > > > On 08/02/2024 14:30, Souza, Jose wrote: > > > > > On Thu,

Re: (subset) [PATCH v2 1/6] dt-bindings: display: rockchip: rockchip, dw-hdmi: remove port property

2024-02-13 Thread Heiko Stuebner
On Wed, 31 Jan 2024 22:14:29 +0100, Johan Jonker wrote: > The hdmi-connector nodes are now functional and the new way to model > hdmi ports nodes with both in and output port subnodes. Unfortunately > with the conversion to YAML the old method with only an input port node > was used. Later the new

Re: [PATCH v2 16/19] drm/msm/dpu: modify encoder programming for CDM over DP

2024-02-13 Thread Dmitry Baryshkov
On Tue, 13 Feb 2024 at 20:46, Abhinav Kumar wrote: > > > > On 2/13/2024 10:23 AM, Dmitry Baryshkov wrote: > > On Tue, 13 Feb 2024 at 19:32, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 2/13/2024 3:18 AM, Dmitry Baryshkov wrote: > >>> On Sat, 10 Feb 2024 at 03:53, Paloma Arellano > >>>

Re: (subset) [PATCH v2 1/6] dt-bindings: display: rockchip: rockchip, dw-hdmi: remove port property

2024-02-13 Thread Heiko Stuebner
On Wed, 31 Jan 2024 22:14:29 +0100, Johan Jonker wrote: > The hdmi-connector nodes are now functional and the new way to model > hdmi ports nodes with both in and output port subnodes. Unfortunately > with the conversion to YAML the old method with only an input port node > was used. Later the new

Re: [PATCH 1/2] [v3] nouveau: add command-line GSP-RM registry support

2024-02-13 Thread Timur Tabi
On Tue, 2024-02-13 at 16:43 +0100, Danilo Krummrich wrote: > > +struct registry_list_entry { > > + struct list_head list; > > Nit: 'head' or 'entry' might be more suitable. Will fix in v4. > > > + size_t name_len; > > + u32 type; > > I prefer to represent type as enum or use a define

Re: (subset) [PATCH 0/7] Add Support for RK3566 Powkiddy RGB10MAX3

2024-02-13 Thread Heiko Stuebner
On Mon, 12 Feb 2024 12:49:43 -0600, Chris Morgan wrote: > From: Chris Morgan > > Add support for the Powkiddy RGB10MAX3 handheld gaming console. > > [1] > https://powkiddy.com/products/pre-sale-powkiddy-rgb10max3-handheld-game-console > > Chris Morgan (7): > dt-bindings: display: st7703:

Re: [PATCH v6 31/36] drm/rockchip: inno_hdmi: Switch to HDMI connector

2024-02-13 Thread Heiko Stuebner
Am Montag, 12. Februar 2024, 14:13:14 CET schrieb Maxime Ripard: > The new HDMI connector infrastructure allows to remove some boilerplate, > especially to generate infoframes. Let's switch to it. > > Signed-off-by: Maxime Ripard Acked-by: Heiko Stuebner > --- >

Re: (subset) [PATCH 0/7] Add Support for RK3566 Powkiddy RGB10MAX3

2024-02-13 Thread Heiko Stuebner
On Mon, 12 Feb 2024 12:49:43 -0600, Chris Morgan wrote: > From: Chris Morgan > > Add support for the Powkiddy RGB10MAX3 handheld gaming console. > > [1] > https://powkiddy.com/products/pre-sale-powkiddy-rgb10max3-handheld-game-console > > Chris Morgan (7): > dt-bindings: display: st7703:

Re: [PATCH v2 16/19] drm/msm/dpu: modify encoder programming for CDM over DP

2024-02-13 Thread Abhinav Kumar
On 2/13/2024 10:23 AM, Dmitry Baryshkov wrote: On Tue, 13 Feb 2024 at 19:32, Abhinav Kumar wrote: On 2/13/2024 3:18 AM, Dmitry Baryshkov wrote: On Sat, 10 Feb 2024 at 03:53, Paloma Arellano wrote: Adjust the encoder format programming in the case of video mode for DP to accommodate

Re: [PATCH 2/2] [v3] drm/nouveau: expose GSP-RM logging buffers via debugfs

2024-02-13 Thread Danilo Krummrich
On 2/13/24 18:10, Timur Tabi wrote: On Tue, 2024-02-13 at 17:57 +0100, Danilo Krummrich wrote: + struct debugfs_blob_wrapper blob_init; + struct debugfs_blob_wrapper blob_intr; + struct debugfs_blob_wrapper blob_rm; + struct debugfs_blob_wrapper blob_pmu; + struct

Re: [PATCH v2 16/19] drm/msm/dpu: modify encoder programming for CDM over DP

2024-02-13 Thread Dmitry Baryshkov
On Tue, 13 Feb 2024 at 19:32, Abhinav Kumar wrote: > > > > On 2/13/2024 3:18 AM, Dmitry Baryshkov wrote: > > On Sat, 10 Feb 2024 at 03:53, Paloma Arellano > > wrote: > >> > >> Adjust the encoder format programming in the case of video mode for DP > >> to accommodate CDM related changes. > >> >

[PATCH] backlight: ktd2801: depend on GPIOLIB

2024-02-13 Thread Duje Mihanović
help Say Y to enable the backlight driver for the Kinetic KTD2801 1-wire --- base-commit: 46d4e2eb58e14c8935fa0e27d16d4c62ef82849a change-id: 20240213-ktd2801-deps-0f571c09b824 Best regards, -- Duje Mihanović

[PATCH] drm/nouveau/mmu/r535: uninitialized variable in r535_bar_new_()

2024-02-13 Thread Dan Carpenter
If gf100_bar_new_() fails then "bar" is not initialized. Fixes: 5bf0257136a2 ("drm/nouveau/mmu/r535: initial support") Signed-off-by: Dan Carpenter --- It looks like this was intended to handle a failure from the "rm" func but "rm" can't actually fail so it's easier to write the error handling

Re: [PATCH i-g-t v3] benchmarks: Add VKMS benchmark

2024-02-13 Thread Kamil Konieczny
Hi Arthur, On 2024-02-09 at 16:39:09 -0300, Arthur Grillo wrote: I will merge this with different description: [PATCH i-g-t v3] benchmarks: Add KMS frambuffer stress benchmark Is this ok? Regards, Kamil > Create a benchmark for the VKMS driver. Use a KMS layout with deliberate > odd sizes to

[PATCH] drm/imx/dcss: fix resource size calculation

2024-02-13 Thread Dan Carpenter
The resource is inclusive of the ->start and ->end addresses so this calculation is not correct. It should be "res->end - res->start + 1". Use the resource_size() to do the calculation. Fixes: 90393c9b5408 ("drm/imx/dcss: request memory region") Signed-off-by: Dan Carpenter --- >From static

Re: drm/msm: DisplayPort regressions in 6.8-rc1

2024-02-13 Thread Abhinav Kumar
Hi Johan Thanks for the report. I do agree that pm runtime eDP driver got merged that time but I think the issue is either a combination of that along with DRM aux bridge https://patchwork.freedesktop.org/series/122584/ OR just the latter as even that went in around the same time. Thats

Re: [PATCH] gpu: host1x: bus: make host1x_bus_type const

2024-02-13 Thread Greg Kroah-Hartman
On Tue, Feb 13, 2024 at 11:44:40AM -0300, Ricardo B. Marliere wrote: > Since commit d492cc2573a0 ("driver core: device.h: make struct > bus_type a const *"), the driver core can properly handle constant > struct bus_type, move the host1x_bus_type variable to be a constant > structure as well,

Re: [PATCH] nouveau: offload fence uevents work to workqueue

2024-02-13 Thread Danilo Krummrich
On 2/9/24 19:52, Daniel Vetter wrote: On Fri, Feb 09, 2024 at 06:41:32PM +0100, Danilo Krummrich wrote: On 2/6/24 15:03, Daniel Vetter wrote: On Mon, Feb 05, 2024 at 11:00:04PM +0100, Danilo Krummrich wrote: On 2/5/24 22:08, Dave Airlie wrote: On Tue, 6 Feb 2024 at 02:22, Danilo Krummrich

Re: [PATCH 1/2] drm/scheduler: improve GPU scheduler documentation v2

2024-02-13 Thread Danilo Krummrich
Hi Christian, What's the status of this effort? Was there ever a follow-up? - Danilo On 11/16/23 23:23, Danilo Krummrich wrote: Hi Christian, Thanks for sending an update of this patch! On Thu, Nov 16, 2023 at 03:15:46PM +0100, Christian König wrote: Start to improve the scheduler

Re: [PATCH v2 16/19] drm/msm/dpu: modify encoder programming for CDM over DP

2024-02-13 Thread Abhinav Kumar
On 2/13/2024 3:18 AM, Dmitry Baryshkov wrote: On Sat, 10 Feb 2024 at 03:53, Paloma Arellano wrote: Adjust the encoder format programming in the case of video mode for DP to accommodate CDM related changes. Changes in v2: - Move timing engine programming to a separate patch from

[PATCH] drm/msm: Wire up tlb ops

2024-02-13 Thread Rob Clark
From: Rob Clark The brute force iommu_flush_iotlb_all() was good enough for unmap, but in some cases a map operation could require removing a table pte entry to replace with a block entry. This also requires tlb invalidation. Missing this was resulting an obscure iova fault on what should be a

Re: [PATCH 2/2] [v3] drm/nouveau: expose GSP-RM logging buffers via debugfs

2024-02-13 Thread Timur Tabi
On Tue, 2024-02-13 at 17:57 +0100, Danilo Krummrich wrote: + struct debugfs_blob_wrapper blob_init; + struct debugfs_blob_wrapper blob_intr; + struct debugfs_blob_wrapper blob_rm; + struct debugfs_blob_wrapper blob_pmu; + struct dentry *debugfs_logging_dir; I

Re: [PATCH] backlight: ktd2801: fix LED dependency

2024-02-13 Thread Daniel Thompson
On Mon, Feb 12, 2024 at 03:31:50PM +0100, Duje Mihanović wrote: > On Monday, February 12, 2024 1:44:28 PM CET Daniel Thompson wrote: > > On Mon, Feb 12, 2024 at 12:18:12PM +0100, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > The new backlight driver unconditionally selects

Re: [PATCH 2/2] [v3] drm/nouveau: expose GSP-RM logging buffers via debugfs

2024-02-13 Thread Danilo Krummrich
On 2/12/24 22:15, Timur Tabi wrote: The LOGINIT, LOGINTR, LOGRM, and LOGPMU buffers are circular buffers that have printf-like logs from GSP-RM and PMU encoded in them. LOGINIT, LOGINTR, and LOGRM are allocated by Nouveau and their DMA addresses are passed to GSP-RM during initialization. The

Re: [PATCH v2 6/6] drm: add drm_mode_atomic_commit event

2024-02-13 Thread Steven Rostedt
On Tue, 13 Feb 2024 16:50:31 +0100 Pierre-Eric Pelloux-Prayer wrote: > @@ -1503,6 +1504,24 @@ int drm_mode_atomic_ioctl(struct drm_device *dev, > drm_mode_object_put(obj); > } > > + if (trace_drm_mode_atomic_commit_enabled()) { > + struct drm_crtc_state

Re: [PATCH] dt-bindings: use capital "OR" for multiple licenses in SPDX

2024-02-13 Thread Rob Herring
On Thu, 08 Feb 2024 11:53:27 +0100, Krzysztof Kozlowski wrote: > Documentation/process/license-rules.rst and checkpatch expect the SPDX > identifier syntax for multiple licenses to use capital "OR". Correct it > to keep consistent format and avoid copy-paste issues. > > Signed-off-by:

Re: [PATCH] drm/crtc: fix uninitialized variable use even harder

2024-02-13 Thread Dmitry Baryshkov
On Mon, 12 Feb 2024 13:55:34 -0800, Rob Clark wrote: > DRM_MODESET_LOCK_ALL_BEGIN() has a hidden trap-door (aka retry loop), > which means we can't rely too much on variable initializers. > > Applied to drm-misc-fixes, thanks! [1/1] drm/crtc: fix uninitialized variable use even harder

Re: [PATCH] drm/crtc: fix uninitialized variable use even harder

2024-02-13 Thread Dmitry Baryshkov
On Tue, 13 Feb 2024 at 15:50, Dmitry Baryshkov wrote: > > On Mon, 12 Feb 2024 at 23:55, Rob Clark wrote: > > > > From: Rob Clark > > > > DRM_MODESET_LOCK_ALL_BEGIN() has a hidden trap-door (aka retry loop), > > which means we can't rely too much on variable initializers. > > > > Fixes:

[PATCH v2 6/6] drm: add drm_mode_atomic_commit event

2024-02-13 Thread Pierre-Eric Pelloux-Prayer
With this and the dma_fence_sync_to event, a tool can draw the relationship between the compositing draw, the atomic commit, and vblank. An example on a 2 monitors system look like this: gnome-shell-1638[018] . 2571.905124: drm_mode_atomic_commit: file=245c3f0c, pid=1165,

[PATCH v2 5/6] drm/amdgpu: add a amdgpu_cs_ioctl2 event

2024-02-13 Thread Pierre-Eric Pelloux-Prayer
amdgpu_cs_ioctl already exists but serves a different purpose. amdgpu_cs_ioctl2 marks the beginning of the kernel processing of the ioctl which is useful for tools to map which events belong to the same submission (without this, the first event would be the amdgpu_bo_set_list ones).

[PATCH v2 4/6] drm/amdgpu: add BO clear event

2024-02-13 Thread Pierre-Eric Pelloux-Prayer
Useful to identify why sdma jobs are submitted. Signed-off-by: Pierre-Eric Pelloux-Prayer --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 16 2 files changed, 18 insertions(+) diff --git

[PATCH v2 3/6] amdgpu: use trace_dma_fence_sync_to in amdgpu_fence_sync

2024-02-13 Thread Pierre-Eric Pelloux-Prayer
This makes it possible to understand the dependencies between jobs. Possible usage of this trace: * stuttering issues like Mesa !9189 * incorrect synchronization: I don't have a link for this one, but having these events was very useful to debug a virtio-gpu / native-context / radeonsi sync

[PATCH v2 2/6] dma-buf/fence-chain: use trace_dma_fence_sync_to

2024-02-13 Thread Pierre-Eric Pelloux-Prayer
To inform tools about the relationship between the fences. Signed-off-by: Pierre-Eric Pelloux-Prayer --- drivers/dma-buf/dma-fence-chain.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/dma-buf/dma-fence-chain.c b/drivers/dma-buf/dma-fence-chain.c index

[PATCH v2 1/6] tracing, dma-buf: add a trace_dma_fence_sync_to event

2024-02-13 Thread Pierre-Eric Pelloux-Prayer
This new event can be used to trace where a given dma_fence is added as a dependency of some other work. I plan to use it in amdgpu. Signed-off-by: Pierre-Eric Pelloux-Prayer --- drivers/dma-buf/dma-fence.c | 1 + include/trace/events/dma_fence.h | 34 2

[PATCH v2 0/6] dma-fence, drm, amdgpu new trace events

2024-02-13 Thread Pierre-Eric Pelloux-Prayer
This series adds new events to make it easier for tools like gpuvis or umr to graph the GPUs, kernel and applications activity. UMR patches using these events can be found here: https://gitlab.freedesktop.org/tomstdenis/umr/-/merge_requests/37 V1:

Re: [etnaviv-next v13 7/7] drm/etnaviv: Add support for vivante GPU cores attached via PCI(e)

2024-02-13 Thread Sui Jingfeng
Hi, On 2024/2/13 22:38, Maxime Ripard wrote: On Sat, Feb 10, 2024 at 12:25:33AM +0800, Sui Jingfeng wrote: On 2024/2/9 23:15, Maxime Ripard wrote: On Fri, Feb 09, 2024 at 12:02:48PM +0100, Daniel Vetter wrote: On Thu, Feb 08, 2024 at 04:27:02PM +0100, Maxime Ripard wrote: On Wed, Feb 07,

Re: [PATCH 1/2] [v3] nouveau: add command-line GSP-RM registry support

2024-02-13 Thread Danilo Krummrich
On 2/12/24 22:15, Timur Tabi wrote: Add the NVreg_RegistryDwords command line parameter, which allows specifying additional registry keys to be sent to GSP-RM. This allows additional configuration, debugging, and experimentation with GSP-RM, which uses these keys to alter its behavior. Note

Re: [PATCH 2/2] drm/tests/drm_buddy: add alloc_contiguous test

2024-02-13 Thread Christian König
Am 13.02.24 um 15:28 schrieb Matthew Auld: On 13/02/2024 13:52, Arunpravin Paneer Selvam wrote: Sanity check DRM_BUDDY_CONTIGUOUS_ALLOCATION. References: https://gitlab.freedesktop.org/drm/amd/-/issues/3097 Signed-off-by: Matthew Auld Reviewed-by: Arunpravin Paneer Selvam It looks like you

Re: [PATCH] drm/xe: skip building debugfs code for CONFIG_DEBUG_FS=n

2024-02-13 Thread Arnd Bergmann
On Tue, Feb 13, 2024, at 15:55, Jani Nikula wrote: > On Tue, 13 Feb 2024, Arnd Bergmann wrote: >> From: Arnd Bergmann >> >> Some of the debugfs functions are stubbed out in these configurations, >> so trying to build the .c file with the definition fails: >> >> In file included from

Re: [PATCH] drm/xe: skip building debugfs code for CONFIG_DEBUG_FS=n

2024-02-13 Thread Jani Nikula
On Tue, 13 Feb 2024, Arnd Bergmann wrote: > From: Arnd Bergmann > > Some of the debugfs functions are stubbed out in these configurations, > so trying to build the .c file with the definition fails: > > In file included from include/uapi/linux/posix_types.h:5, > from

Re: Build regressions/improvements in v6.8-rc1

2024-02-13 Thread Andreas Larsson
On 2024-01-23 15:21, Arnd Bergmann wrote: >>> + /kisskb/src/arch/sparc/include/asm/floppy_64.h: error: no previous >>> prototype for 'sparc_floppy_irq' [-Werror=missing-prototypes]: => 200:13 >>> + /kisskb/src/arch/sparc/include/asm/floppy_64.h: error: no previous >>> prototype for

Re: [PATCH 04/10] hid/hid-picolcd: Remove struct backlight_ops.check_fb

2024-02-13 Thread kernel test robot
Hi Thomas, kernel test robot noticed the following build errors: [auto build test ERROR on lee-backlight/for-backlight-next] [also build test ERROR on lee-backlight/for-backlight-fixes hid/for-next lee-leds/for-leds-next linus/master v6.8-rc4 next-20240213] [If your patch is applied

[PATCH] gpu: host1x: bus: make host1x_bus_type const

2024-02-13 Thread Ricardo B. Marliere
type; struct host1x; -extern struct bus_type host1x_bus_type; +extern const struct bus_type host1x_bus_type; int host1x_register(struct host1x *host1x); int host1x_unregister(struct host1x *host1x); --- base-commit: 2429b3c529da29d4277d519bd66d034842dcd70c change-id: 20240213-bus_cleanup-host1

Re: Re: [PATCH drm-misc-next] drm/xe: Fix a missing argument to drm_err_printer

2024-02-13 Thread Jani Nikula
On Tue, 13 Feb 2024, Maxime Ripard wrote: > On Mon, Feb 12, 2024 at 12:53:05PM +0200, Jani Nikula wrote: >> On Mon, 12 Feb 2024, Thomas Hellström >> wrote: >> > The indicated commit below added a device argument to the >> > function, but there was a call in the xe driver that was >> > not

Re: Re: [etnaviv-next v13 7/7] drm/etnaviv: Add support for vivante GPU cores attached via PCI(e)

2024-02-13 Thread Maxime Ripard
On Sat, Feb 10, 2024 at 12:25:33AM +0800, Sui Jingfeng wrote: > On 2024/2/9 23:15, Maxime Ripard wrote: > > On Fri, Feb 09, 2024 at 12:02:48PM +0100, Daniel Vetter wrote: > > > On Thu, Feb 08, 2024 at 04:27:02PM +0100, Maxime Ripard wrote: > > > > On Wed, Feb 07, 2024 at 10:35:49AM +0100, Daniel

Re: [PATCH 2/2] drm/tests/drm_buddy: add alloc_contiguous test

2024-02-13 Thread Matthew Auld
On 13/02/2024 13:52, Arunpravin Paneer Selvam wrote: Sanity check DRM_BUDDY_CONTIGUOUS_ALLOCATION. References: https://gitlab.freedesktop.org/drm/amd/-/issues/3097 Signed-off-by: Matthew Auld Reviewed-by: Arunpravin Paneer Selvam It looks like you changed the patch authorship here. Cc:

Re: Re: [PATCH drm-misc-next] drm/xe: Fix a missing argument to drm_err_printer

2024-02-13 Thread Maxime Ripard
On Mon, Feb 12, 2024 at 12:53:05PM +0200, Jani Nikula wrote: > On Mon, 12 Feb 2024, Thomas Hellström > wrote: > > The indicated commit below added a device argument to the > > function, but there was a call in the xe driver that was > > not properly changed. > > Aww, crap. Looks like my

Re: [syzbot] [dri?] KASAN: slab-use-after-free Read in drm_atomic_helper_wait_for_vblanks (2)

2024-02-13 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:c664e16bb1ba Merge tag 'docs-6.8-fixes2' of git://git.lwn... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=14f8d1e018 kernel config:

Re: Re: [RFC PATCH 2/3] drm/tidss: Add support for display sharing

2024-02-13 Thread Maxime Ripard
Hi Devarsh, On Thu, Feb 08, 2024 at 06:26:17PM +0530, Devarsh Thakkar wrote: > Hi Maxime, > > Thanks a lot for checking on this. > > On 26/01/24 17:45, Maxime Ripard wrote: > > Hi, > > > > Thanks a lot for working on that. > > > > On Tue, Jan 16, 2024 at 07:11:41PM +0530, Devarsh Thakkar

Re: [PATCH] drm/crtc: fix uninitialized variable use even harder

2024-02-13 Thread Daniel Vetter
On Mon, Feb 12, 2024 at 01:55:34PM -0800, Rob Clark wrote: > From: Rob Clark > > DRM_MODESET_LOCK_ALL_BEGIN() has a hidden trap-door (aka retry loop), > which means we can't rely too much on variable initializers. > > Fixes: 6e455f5dcdd1 ("drm/crtc: fix uninitialized variable use") >

[PATCH 2/2] drm/tests/drm_buddy: add alloc_contiguous test

2024-02-13 Thread Arunpravin Paneer Selvam
Sanity check DRM_BUDDY_CONTIGUOUS_ALLOCATION. References: https://gitlab.freedesktop.org/drm/amd/-/issues/3097 Signed-off-by: Matthew Auld Reviewed-by: Arunpravin Paneer Selvam Cc: Arunpravin Paneer Selvam Cc: Limonciello Cc: Christian König Signed-off-by: Arunpravin Paneer Selvam ---

[PATCH 1/2] drm/buddy: Fix alloc_range() error handling code

2024-02-13 Thread Arunpravin Paneer Selvam
Few users have observed display corruption when they boot the machine to KDE Plasma or playing games. We have root caused the problem that whenever alloc_range() couldn't find the required memory blocks the function was returning SUCCESS in some of the corner cases. The right approach would be if

Re: [PATCH] drm/crtc: fix uninitialized variable use even harder

2024-02-13 Thread Dmitry Baryshkov
On Mon, 12 Feb 2024 at 23:55, Rob Clark wrote: > > From: Rob Clark > > DRM_MODESET_LOCK_ALL_BEGIN() has a hidden trap-door (aka retry loop), > which means we can't rely too much on variable initializers. > > Fixes: 6e455f5dcdd1 ("drm/crtc: fix uninitialized variable use") > Signed-off-by: Rob

[PATCH] drm/xe: skip building debugfs code for CONFIG_DEBUG_FS=n

2024-02-13 Thread Arnd Bergmann
From: Arnd Bergmann Some of the debugfs functions are stubbed out in these configurations, so trying to build the .c file with the definition fails: In file included from include/uapi/linux/posix_types.h:5, from drivers/gpu/drm/i915/display/intel_pipe_crc.c:27:

RE: [PATCH v2 1/6] drm/mst: read sideband messaging cap

2024-02-13 Thread Jani Nikula
On Tue, 13 Feb 2024, "Murthy, Arun R" wrote: >> -Original Message- >> From: Nikula, Jani >> Sent: Tuesday, February 13, 2024 5:01 PM >> To: intel-...@lists.freedesktop.org >> Cc: dri-devel@lists.freedesktop.org; intel...@lists.freedesktop.org; Nikula, >> Jani >> ; Murthy, Arun R ; Ville

Re: [PATCH 02/10] auxdisplay/ht16k33: Remove struct backlight_ops.check_fb

2024-02-13 Thread Robin van der Gracht
On Mon, 12 Feb 2024 17:16:35 +0100 Thomas Zimmermann wrote: > The driver sets struct fb_info.bl_dev to the correct backlight > device. Thus rely on the backlight core code to match backlight > and framebuffer devices, and remove the extra check_fb function > from struct backlight_ops. > >

Re: [RFC PATCH net-next v5 08/14] memory-provider: dmabuf devmem memory provider

2024-02-13 Thread Pavel Begunkov
On 12/18/23 02:40, Mina Almasry wrote: Implement a memory provider that allocates dmabuf devmem in the form of net_iov. The provider receives a reference to the struct netdev_dmabuf_binding via the pool->mp_priv pointer. The driver needs to set this pointer for the provider in the net_iov. The

Re: [RFC PATCH net-next v5 07/14] page_pool: devmem support

2024-02-13 Thread Pavel Begunkov
On 12/18/23 02:40, Mina Almasry wrote: Convert netmem to be a union of struct page and struct netmem. Overload the LSB of struct netmem* to indicate that it's a net_iov, otherwise it's a page. Currently these entries in struct page are rented by the page_pool and used exclusively by the net

Re: [RFC PATCH net-next v5 05/14] netdev: netdevice devmem allocator

2024-02-13 Thread Pavel Begunkov
On 12/18/23 02:40, Mina Almasry wrote: Implement netdev devmem allocator. The allocator takes a given struct netdev_dmabuf_binding as input and allocates net_iov from that binding. The allocation simply delegates to the binding's genpool for the allocation logic and wraps the returned memory

[RFC] drm/i915: Support replaying GPU hangs with captured context image

2024-02-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin When debugging GPU hangs Mesa developers are finding it useful to replay the captured error state against the simulator. But due various simulator limitations which prevent replicating all hangs, one step further is being able to replay against a real GPU. This is almost

RE: [PATCH v2 1/6] drm/mst: read sideband messaging cap

2024-02-13 Thread Murthy, Arun R
> -Original Message- > From: Nikula, Jani > Sent: Tuesday, February 13, 2024 5:01 PM > To: intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; intel...@lists.freedesktop.org; Nikula, > Jani > ; Murthy, Arun R ; Ville > Syrjälä > Subject: [PATCH v2 1/6] drm/mst: read

Re: [PATCH 09/28] drm: Add Color ops capability property

2024-02-13 Thread Sebastian Wick
On Tue, Feb 13, 2024 at 12:18:16PM +0530, Uma Shankar wrote: > Add capability property which a colorop can expose it's > hardware's abilities. It's a blob property that can be > filled with respective data structures depending on the > colorop. The user space is expected to read this property >

Re: [PATCH 08/28] drm: Add Color lut range attributes

2024-02-13 Thread Sebastian Wick
On Tue, Feb 13, 2024 at 12:18:15PM +0530, Uma Shankar wrote: > This defines a new structure to define color lut ranges, > along with related macro definitions and enums. This will help > describe segmented lut ranges/PWL LUTs in the hardware. > > Signed-off-by: Uma Shankar > Signed-off-by:

Re: [PATCH 6/7] dt-bindings: arm: rockchip: Add Powkiddy RGB10MAX3

2024-02-13 Thread Krzysztof Kozlowski
On 12/02/2024 19:49, Chris Morgan wrote: > From: Chris Morgan > > The Powkiddy RGB10MAX3 is a handheld gaming device made by Powkiddy and > powered by the Rockchip RK3566 SoC. > > Signed-off-by: Chris Morgan > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 3/7] dt-bindings: display: Document ST7703 panel rotation

2024-02-13 Thread Krzysztof Kozlowski
On 12/02/2024 19:49, Chris Morgan wrote: > From: Chris Morgan > > Document the rotation property for ST7703 based panels. > > Signed-off-by: Chris Morgan > --- Acked-by: Krzysztof Kozlowski (with or without empty line removal) Best regards, Krzysztof

Re: [PATCH 1/7] dt-bindings: display: st7703: Add Powkiddy RGB10MAX3 panel

2024-02-13 Thread Krzysztof Kozlowski
On 12/02/2024 19:49, Chris Morgan wrote: > From: Chris Morgan > > The RGB10MAX3 panel is a panel specific to the Powkiddy RGB10MAX3 > handheld device that measures 5 inches diagonally with a resolution > of 720x1280. > > Signed-off-by: Chris Morgan Acked-by: Krzysztof Kozlowski Best

drm/msm: DisplayPort regressions in 6.8-rc1

2024-02-13 Thread Johan Hovold
Hi, Since 6.8-rc1 the internal eDP display on the Lenovo ThinkPad X13s does not always show up on boot. The logs indicate problems with the runtime PM and eDP rework that went into 6.8-rc1: [6.006236] Console: switching to colour dummy device 80x25 [6.007542]

  1   2   >