Re: [Intel-gfx] [PATCH v2 4/5] drm/i915/mtl: Add hardware-level lock for steering

2022-12-02 Thread Balasubramani Vivekanandan
nt for CI if it ever >happens (this would imply misbehaving hardware/firmware). (Mika) > - Add "MTL_" prefix to new steering semaphore register. (Mika) > > Cc: Mika Kuoppala > Signed-off-by: Matt Roper Reviewed-by: Balasubramani Vivekanandan

Re: [PATCH v3 5/5] drm/i915/mtl: Hold forcewake and MCR lock over PPAT setup

2022-12-01 Thread Balasubramani Vivekanandan
la) > > Suggested-by: Balasubramani Vivekanandan > > Signed-off-by: Matt Roper Reviewed-by: Balasubramani Vivekanandan Regards, Bala > --- > drivers/gpu/drm/i915/gt/intel_gtt.c | 27 +++ > 1 file changed, 19 insertions(+), 8 deletions(-) &g

Re: [PATCH v2 5/5] drm/i915/mtl: Hold forcewake and MCR lock over PPAT setup

2022-11-30 Thread Balasubramani Vivekanandan
On 28.11.2022 15:30, Matt Roper wrote: > PPAT setup involves a series of multicast writes. This can be optimized > slightly be acquiring forcewake and the steering lock just once for the > entire sequence. > > Suggested-by: Balasubramani Vivekanandan > > Sign

Re: [PATCH v2 3/5] drm/i915/gt: Add dedicated MCR lock

2022-11-30 Thread Balasubramani Vivekanandan
qsave/irqrestore spinlock calls; platforms using execlist >submission rather than GuC submission can perform MCR accesses in >interrupt context because reset -> errordump happens in a tasklet. > > Cc: Chris Wilson > Cc: Mika Kuoppala > Cc: Balasubramani Vivekanandan &

Re: [PATCH v2 2/5] drm/i915/gt: Pass gt rather than uncore to lowest-level reads/writes

2022-11-30 Thread Balasubramani Vivekanandan
On 28.11.2022 15:30, Matt Roper wrote: > Passing the GT rather than uncore to the lowest level MCR read and write > functions will make it easier to introduce dedicated MCR locking in a > following patch. > > Signed-off-by: Matt Roper Reviewed-by: Balasubramani Vivekanandan

Re: [PATCH v2 1/5] drm/i915/gt: Correct kerneldoc for intel_gt_mcr_wait_for_reg()

2022-11-30 Thread Balasubramani Vivekanandan
ot > Signed-off-by: Matt Roper Reviewed-by: Balasubramani Vivekanandan Regards, Bala > --- > drivers/gpu/drm/i915/gt/intel_gt_mcr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c > b/drivers/gpu/drm/i915/

Re: [Intel-gfx] [PATCH 2/3] Documentation/gpu: Limit index to maxdepth=2

2022-11-15 Thread Balasubramani Vivekanandan
On 07.11.2022 09:32, Lucas De Marchi wrote: > With a lot of sub-section it's a little bit hard to find the information > needed in the main GPU index. Limit the maxdepth to 2 so it doesn't get > poluted with noise from each driver and from other sections. > > Signed-off-by: Lucas De Marchi > ---

Re: [PATCH] drm/i915: Update workaround documentation

2022-11-10 Thread Balasubramani Vivekanandan
ep > the > - * following order: > + * - Workaround batchbuffers: buffers that get executed automatically by the > + * hardware on every HW context restore. These buffers are created and > + * programmed in the default context so the hardware always go through > those &

Re: [Intel-gfx] [PATCH v3 14/14] drm/i915/xelpmp: Add multicast steering for media GT

2022-10-17 Thread Balasubramani Vivekanandan
+-- > 3 files changed, 32 insertions(+), 4 deletions(-) Reviewed-by: Balasubramani Vivekanandan Regards, Bala > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c > b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c > index 23a1ef9659bf..0d2811724b00 100644 > --- a/drivers/g

Re: [PATCH v3 13/14] drm/i915/xelpg: Add multicast steering

2022-10-17 Thread Balasubramani Vivekanandan
anges added on future platforms will also be dumped). > - Restore MULTICAST bit at the end of rw_with_mcr_steering_fw() if we >cleared it. Also force the MULTICAST bit to true at the beginning of >multicast writes just to be safe. (Bala) > > Bspec: 67788, 6

Re: [Intel-gfx] [PATCH v3 12/14] drm/i915: Define multicast registers as a new type

2022-10-17 Thread Balasubramani Vivekanandan
.c| 4 +- > drivers/gpu/drm/i915/gvt/handlers.c | 2 +- > drivers/gpu/drm/i915/gvt/mmio_context.c | 14 ++--- > drivers/gpu/drm/i915/i915_reg_defs.h | 27 +- > 12 files changed, 117 insertions(+), 83 deletions(-) Reviewed-by: Balasubramani Vivekanandan Regar

Re: [Intel-gfx] [PATCH v3 11/14] drm/i915/gt: Add MCR-specific workaround initializers

2022-10-17 Thread Balasubramani Vivekanandan
arounds_types.h | 4 +- > 2 files changed, 263 insertions(+), 174 deletions(-) Reviewed-by: Balasubramani Vivekanandan Regards, Bala > > diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c > b/drivers/gpu/drm/i915/gt/intel_workarounds.c > index 96b9f02a2284..7671994d5b7a 10

Re: [PATCH v3 10/14] drm/i915/guc: Handle save/restore of MCR registers explicitly

2022-10-17 Thread Balasubramani Vivekanandan
r them). > > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 55 +- > 1 file changed, 34 insertions(+), 21 deletions(-) Reviewed-by: Balasubramani Vivekanandan Regards, Bala > > diff --git a/drivers/gpu/drm/i915/gt/uc/in

Re: [PATCH v3 09/14] drm/i915/gt: Always use MCR functions on multicast registers

2022-10-17 Thread Balasubramani Vivekanandan
> - Switch more uncore operations in mmio_invalidate_full() to MCR >operations for Xe_HP. (Bala) > > Cc: Balasubramani Vivekanandan > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/gt/intel_gt.c| 58 --- > drivers/gpu/drm/i915/gt/inte

Re: [PATCH v3 08/14] drm/i915: Define MCR registers explicitly

2022-10-17 Thread Balasubramani Vivekanandan
ons(+), 66 deletions(-) Reviewed-by: Balasubramani Vivekanandan Regards, Bala > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_regs.h > b/drivers/gpu/drm/i915/gt/intel_gt_regs.h > index 890960b56b9e..ad9985015b0e 100644 > --- a/drivers/gpu/drm/i915/gt/intel_gt_regs.h > +++ b/dri

Re: [Intel-gfx] [PATCH v3 07/14] drm/i915/gt: Add intel_gt_mcr_wait_for_reg_fw()

2022-10-17 Thread Balasubramani Vivekanandan
++ > drivers/gpu/drm/i915/gt/intel_gt_mcr.h | 7 > 2 files changed, 62 insertions(+) Reviewed-by: Balasubramani Vivekanandan Regards, Bala > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c > b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c > index 4d

Re: [PATCH v3 06/14] drm/i915/xehp: Check for faults on primary GAM

2022-10-17 Thread Balasubramani Vivekanandan
> drivers/gpu/drm/i915/gt/intel_gt.c| 52 +++ > drivers/gpu/drm/i915/i915_gpu_error.c | 12 +-- > 2 files changed, 55 insertions(+), 9 deletions(-) Reviewed-by: Balasubramani Vivekanandan Regards, Bala > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c

Re: [PATCH v3 05/14] drm/i915/gt: Add intel_gt_mcr_multicast_rmw() operation

2022-10-17 Thread Balasubramani Vivekanandan
pu/drm/i915/gt/intel_gt_mcr.h | 3 +++ > 2 files changed, 31 insertions(+) Reviewed-by: Balasubramani Vivekanandan Regards, Bala > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c > b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c > index a2047a68ea7a..4dc360f4e344 100644 > -

Re: [PATCH v3 04/14] drm/i915/gt: Correct prefix on a few registers

2022-10-17 Thread Balasubramani Vivekanandan
rs/gpu/drm/i915/gt/intel_workarounds.c | 10 +- > 2 files changed, 9 insertions(+), 9 deletions(-) Reviewed-by: Balasubramani Vivekanandan Regards, Bala > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_regs.h > b/drivers/gpu/drm/i915/gt/intel_gt_regs.h > index 71d8787

Re: [PATCH v3 03/14] drm/i915/gt: Drop a few unused register definitions

2022-10-17 Thread Balasubramani Vivekanandan
n any future platform. > > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/gt/intel_gt_regs.h | 17 - > 1 file changed, 17 deletions(-) Reviewed-by: Balasubramani Vivekanandan Regards, Bala

Re: [PATCH v3 02/14] drm/i915/xehp: Create separate reg definitions for new MCR registers

2022-10-17 Thread Balasubramani Vivekanandan
the unconditional GEN9_LNCFCMOCS usage >in selftest_mocs. (Bala) > - Include some additional TLB registers. > > Bspec: 66534 > Cc: Balasubramani Vivekanandan > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/gt/intel_ggtt.c| 4 ++-- > drivers/gp

Re: [PATCH v3 01/14] drm/i915/gen8: Create separate reg definitions for new MCR registers

2022-10-17 Thread Balasubramani Vivekanandan
recently added for DG2/PVC. (Bala) > > Signed-off-by: Matt Roper > Reviewed-by: Balasubramani Vivekanandan > --- > drivers/gpu/drm/i915/gt/intel_engine_cs.c | 4 +-- > drivers/gpu/drm/i915/gt/intel_gt_regs.h | 11 +++- > drivers/gpu/drm/i915/gt/intel_workaro

Re: [PATCH v2 13/14] drm/i915/mtl: Add multicast steering for render GT

2022-10-14 Thread Balasubramani Vivekanandan
On 30.09.2022 17:45, Matt Roper wrote: > MTL once again changes the multicast register types and steering > details. Key changes from past platforms: > * The number of instances of some MCR types (NODE, OAAL2, and GAM) vary >according to the MTL subplatform and cannot be read from fuse >

Re: [PATCH v2 12/14] drm/i915: Define multicast registers as a new type

2022-10-13 Thread Balasubramani Vivekanandan
On 30.09.2022 17:45, Matt Roper wrote: > Rather than treating multicast registers as 'i915_reg_t' let's define > them as a completely new type. This will allow the compiler to help us > make sure we're using multicast-aware functions to operate on multicast > registers. > > This plan does break

Re: [PATCH v2 09/14] drm/i915/gt: Always use MCR functions on multicast registers

2022-10-12 Thread Balasubramani Vivekanandan
On 30.09.2022 17:45, Matt Roper wrote: > Rather than relying on the implicit behavior of intel_uncore_*() > functions, let's always use the intel_gt_mcr_*() functions to operate on > multicast/replicated registers. > > v2: > - Add TLB invalidation registers > > Signed-off-by: Matt Roper > ---

Re: [PATCH 02/12] drm/i915/xehp: Create separate reg definitions for new MCR registers

2022-09-28 Thread Balasubramani Vivekanandan
On 19.09.2022 15:32, Matt Roper wrote: > Starting in Xe_HP, several registers our driver works with have been > converted from singleton registers into replicated registers with > multicast behavior. Although the registers are still located at the > same MMIO offsets as on previous platforms,

Re: [PATCH 01/12] drm/i915/gen8: Create separate reg definitions for new MCR registers

2022-09-28 Thread Balasubramani Vivekanandan
On 19.09.2022 15:32, Matt Roper wrote: > Gen8 was the first time our hardware had multicast registers (or at > least the first time the multicast nature was exposed and MMIO accesses > could be steered). There are some registers that transitioned from > singleton behavior to multicast during the

Re: [Intel-gfx] [PATCH 05/12] drm/i915/xehp: Check for faults on primary GAM

2022-09-26 Thread Balasubramani Vivekanandan
On 19.09.2022 15:32, Matt Roper wrote: > On Xe_HP the fault registers are now in a multicast register range. > However as part of the GAM these registers follow special rules and we > need only read from the "primary" GAM's instance to get the information > we need. So a single

Re: [PATCH 01/12] drm/i915/gen8: Create separate reg definitions for new MCR registers

2022-09-26 Thread Balasubramani Vivekanandan
| F_CMD_ACCESS, > NULL, NULL); > MMIO_DFH(GEN7_HALF_SLICE_CHICKEN1, D_ALL, F_MODE_MASK | F_CMD_ACCESS, > NULL, NULL); > > /* display */ > diff --git a/drivers/gpu/drm/i915/gvt/mmio_context.c > b/drivers/gpu/drm/i915/gvt/mmio_context.c > index 1c6e941c9666..ac58460fb3

Re: [Intel-gfx] [PATCH] drm/i915: Noop lrc_init_wa_ctx() on recent/future platforms

2022-09-22 Thread Balasubramani Vivekanandan
e > those don't use either guc or execlist, i.e. HAS_EXECLISTS() is false. > > Signed-off-by: Lucas De Marchi > --- > drivers/gpu/drm/i915/gt/intel_lrc.c | 16 > 1 file changed, 4 insertions(+), 12 deletions(-) Reviewed-by: Balasubramani Vivekanandan > &g

Re: [Intel-gfx] [PATCH v4 11/11] drm/i915/mtl: Do not update GV point, mask value

2022-09-09 Thread Balasubramani Vivekanandan
On 01.09.2022 23:03, Radhakrishna Sripada wrote: > Display 14 and future platforms do not directly communicate to Pcode > via mailbox the SAGV bandwidth information. PM Demand registers are > used to communicate display power requirements to the PUnit which would > include GV point and mask value.

Re: [Intel-gfx] [PATCH v4 05/11] drm/i915/mtl: Add gmbus and gpio support

2022-09-08 Thread Balasubramani Vivekanandan
(MattR) > > BSpec: 49306 > > Cc: Matt Roper > Original Author: Brian J Lovin > Signed-off-by: Radhakrishna Sripada > --- > drivers/gpu/drm/i915/display/intel_gmbus.c | 15 +++ > drivers/gpu/drm/i915/display/intel_gmbus.h | 1 + > 2 files chang

Re: [Intel-gfx] [PATCH v3 05/11] drm/i915/mtl: Add gmbus and gpio support

2022-09-08 Thread Balasubramani Vivekanandan
(MattR) > > BSpec: 49306 > > Cc: Matt Roper > Original Author: Brian J Lovin > Signed-off-by: Radhakrishna Sripada > --- > drivers/gpu/drm/i915/display/intel_gmbus.c | 15 +++ > drivers/gpu/drm/i915/display/intel_gmbus.h | 1 + > 2 files chang

Re: [PATCH v4 04/11] drm/i915/mtl: Define engine context layouts

2022-09-06 Thread Balasubramani Vivekanandan
> - Dg2, mtl xcs offsets slightly vary. Use a separate offsets array(Bala) > - Drop unused registers in mtl rcs offsets.(Bala) > > Bspec: 46261, 46260, 45585 > Cc: Balasubramani Vivekanandan > Signed-off-by: Matt Roper > Signed-off-by: Radhakrishn

Re: [Intel-gfx] [PATCH] drm/i915/dg2: Incorporate Wa_16014892111 into DRAW_WATERMARK tuning

2022-08-26 Thread Balasubramani Vivekanandan
even if an RC6 entry had wiped the > register back to hardware defaults since the last context ran. > > Fixes: 6dc85721df74 ("drm/i915/dg2: Add additional tuning settings") > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6642 > Signed-off-by: Matt Roper Reviewed-

Re: [PATCH v2 05/21] drm/i915/mtl: Define engine context layouts

2022-08-25 Thread Balasubramani Vivekanandan
On 18.08.2022 16:41, Radhakrishna Sripada wrote: > From: Matt Roper > > The part of the media and blitter engine contexts that we care about for > setting up an initial state are the same on MTL as they were on DG2 > (and PVC), so we need to update the driver conditions to re-use the DG2 >

Re: [Intel-gfx] [PATCH v2 02/21] drm/i915: Parse and set stepping for platforms with GMD

2022-08-24 Thread Balasubramani Vivekanandan
t; drivers/gpu/drm/i915/intel_step.c | 60 +++ > 1 file changed, 60 insertions(+) Reviewed-by: Balasubramani Vivekanandan > > diff --git a/drivers/gpu/drm/i915/intel_step.c > b/drivers/gpu/drm/i915/intel_step.c > index 42b3133d8387..0fa7147c7d0f 100644 > --- a/dr

Re: [PATCH v2 04/21] drm/i915/mtl: Don't mask off CCS according to DSS fusing

2022-08-24 Thread Balasubramani Vivekanandan
; Signed-off-by: Matt Roper > Signed-off-by: Radhakrishna Sripada > --- > drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Balasubramani Vivekanandan > > diff --git a/drivers/gpu/drm/i915/gt/intel_e

Re: [PATCH v2 03/21] drm/i915/mtl: MMIO range is now 4MB

2022-08-24 Thread Balasubramani Vivekanandan
by: Radhakrishna Sripada Reviewed-by: Balasubramani Vivekanandan > --- > drivers/gpu/drm/i915/intel_uncore.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_uncore.c > b/drivers/gpu/drm/i915/intel_uncore.c > index a852

Re: [PATCH] drm/i915/xehp: Correct steering initialization

2022-06-08 Thread Balasubramani Vivekanandan
5/sseu: Disassociate internal subslice mask > representation from uapi") > Cc: Balasubramani Vivekanandan > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/gt/intel_workarounds.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a

Re: [PATCH] drm/i915/dg2: Correct DSS check for Wa_1308578152

2022-06-07 Thread Balasubramani Vivekanandan
n >. > > Fixes: b87d39019651 ("drm/i915/sseu: Disassociate internal subslice mask > representation from uapi") > Reported-by: Balasubramani Vivekanandan > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/gt/intel_workarounds.c | 2 +- > 1 file changed, 1 i

Re: [PATCH v5 0/6] i915: SSEU handling updates

2022-06-02 Thread Balasubramani Vivekanandan
> > > v5: > - Rebase to latest drm-tip (resolve trivial conflicts) > - Move XEHP_BITMAP_BITS() to the header so that w

Re: [PATCH v5 5/6] drm/i915/sseu: Disassociate internal subslice mask representation from uapi

2022-06-01 Thread Balasubramani Vivekanandan
On 23.05.2022 13:45, Matt Roper wrote: > As with EU masks, it's easier to store subslice/DSS masks internally in > a format that's more natural for the driver to work with, and then only > covert into the u8[] uapi form when the query ioctl is invoked. Since > the hardware design changed

[PATCH] drm/i915/display/adl_p: Updates to HDMI combo PHY voltage swing table

2022-05-26 Thread Balasubramani Vivekanandan
New updates to HDMI combo PHY voltage swing tables. Actually with this update (bspec updated on 08/17/2021), the values are reverted back to be same as icelake for HDMI combo PHY. Bspec: 49291 Signed-off-by: Balasubramani Vivekanandan --- .../drm/i915/display/intel_ddi_buf_trans.c| 22

[PATCH] drm/i915/hwconfig: Report no hwconfig support on ADL-N

2022-05-23 Thread Balasubramani Vivekanandan
ADL-N being a subplatform of ADL-P, it lacks support for hwconfig table. Explicit check added to skip ADL-N. Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt

[PATCH v3 3/7] drm/i915: use the memcpy_from_wc call from the drm

2022-04-26 Thread Balasubramani Vivekanandan
memcpy_from_wc functions in i915_memcpy.c will be removed and replaced by the implementation in drm_cache.c. Updated to use the functions provided by drm_cache.c. v2: Pass newly added src offset argument to the modified drm_memcpy_from_wc_vaddr() function. Signed-off-by: Balasubramani

[PATCH v3 7/7] drm/i915: Avoid dereferencing io mapped memory

2022-04-26 Thread Balasubramani Vivekanandan
as fallback. Signed-off-by: Balasubramani Vivekanandan Acked-by: Nirmoy Das --- drivers/gpu/drm/i915/i915_gpu_error.c | 45 +++ 1 file changed, 25 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c

[PATCH v3 5/7] drm/i915/selftests: use the memcpy_from_wc call from the drm

2022-04-26 Thread Balasubramani Vivekanandan
accordingly (Lucas) Cc: Lucas De Marchi Cc: Matthew Auld Cc: Thomas Hellstr_m Cc: Thomas Zimmermann Cc: Daniel Vetter Signed-off-by: Balasubramani Vivekanandan Acked-by: Nirmoy Das --- .../drm/i915/selftests/intel_memory_region.c | 41 +-- 1 file changed, 28 insertions(+), 13

[PATCH v3 6/7] drm/i915/gt: Avoid direct dereferencing of io memory

2022-04-26 Thread Balasubramani Vivekanandan
is not supported but uses memcpy_fromio as fallback for copying. Cc: Matthew Brost Cc: Michał Winiarski Signed-off-by: Balasubramani Vivekanandan Acked-by: Nirmoy Das --- drivers/gpu/drm/i915/gt/selftest_reset.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff

[PATCH v3 4/7] drm/i915/guc: use iosys_map abstraction to access GuC log

2022-04-26 Thread Balasubramani Vivekanandan
Marchi Cc: Daniele Ceraolo Spurio Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/gt/uc/guc_capture_fwif.h | 2 +- .../gpu/drm/i915/gt/uc/intel_guc_capture.c| 52 + drivers/gpu/drm/i915/gt/uc/intel_guc_log.c| 77 ++- drivers/gpu/drm/i915/gt/uc

[PATCH v3 2/7] drm: Add drm_memcpy_from_wc() variant which accepts destination address

2022-04-26 Thread Balasubramani Vivekanandan
provides the offset into the src address to start copy from. Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Cc: Thomas Hellstr_m Signed-off-by: Balasubramani Vivekanandan Reviewed-by: Lucas De Marchi Reviewed-by: Nirmoy Das --- drivers

[PATCH v3 1/7] drm: Relax alignment constraint for destination address

2022-04-26 Thread Balasubramani Vivekanandan
-off-by: Balasubramani Vivekanandan Reviewed-by: Lucas De Marchi Reviewed-by: Nirmoy Das --- drivers/gpu/drm/drm_cache.c | 44 - 1 file changed, 38 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_cache.c b/drivers/gpu/drm/drm_cache.c index

[PATCH v3 0/7] drm/i915: Use the memcpy_from_wc function from drm

2022-04-26 Thread Balasubramani Vivekanandan
log using iosys_map abstraction, in addition to using drm_memcpy_from_wc. Cc: Jani Nikula Cc: Lucas De Marchi Cc: David Airlie Cc: Daniel Vetter Cc: Chris Wilson Cc: Thomas Hellstr_m Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: Nirmoy Das Balasubramani Vivekanandan (7):

[PATCH] drm/i915/uc: use io memcpy functions for device memory copy

2022-04-06 Thread Balasubramani Vivekanandan
. Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c index bb864655c495..06d30670e15c

Re: [PATCH v7 3/9] drm/i915/gt: Optimize the migration and clear loop

2022-04-05 Thread Balasubramani Vivekanandan
On 01.04.2022 18:07, Ramalingam C wrote: > Move the static calculations out of the loops for copy and clear. > > Signed-off-by: Ramalingam C > Reviewed-by: Thomas Hellstrom > --- > drivers/gpu/drm/i915/gt/intel_migrate.c | 40 - > 1 file changed, 19 insertions(+), 21

Re: [PATCH v7 3/9] drm/i915/gt: Optimize the migration and clear loop

2022-03-29 Thread Balasubramani Vivekanandan
On 29.03.2022 00:37, Ramalingam C wrote: > Move the static calculations out of the loops for copy and clear. > > Signed-off-by: Ramalingam C > Reviewed-by: Thomas Hellström > --- > drivers/gpu/drm/i915/gt/intel_migrate.c | 44 - > 1 file changed, 21 insertions(+), 23

Re: [Intel-gfx] [PATCH v2 5/7] drm/i915/selftests: use the memcpy_from_wc call from the drm

2022-03-28 Thread Balasubramani Vivekanandan
/O memory access? > > > > On Thu, Mar 03, 2022 at 11:30:11PM +0530, Balasubramani Vivekanandan wrote: > > > memcpy_from_wc functions in i915_memcpy.c will be removed and replaced > > > by the implementation in drm_cache.c. > > > Updated to use the

Re: [PATCH v2 4/7] drm/i915/guc: use the memcpy_from_wc call from the drm

2022-03-22 Thread Balasubramani Vivekanandan
On 21.03.2022 14:14, Lucas De Marchi wrote: > On Thu, Mar 03, 2022 at 11:30:10PM +0530, Balasubramani Vivekanandan wrote: > > memcpy_from_wc functions in i915_memcpy.c will be removed and replaced > > by the implementation in drm_cache.c. > > Updated to use the functions pr

Re: [PATCH] drm/i915/guc: Use iosys_map interface to update lrc_desc

2022-03-14 Thread Balasubramani Vivekanandan
On 11.03.2022 10:40, Lucas De Marchi wrote: > On Tue, Mar 08, 2022 at 10:17:42PM +0530, Balasubramani Vivekanandan wrote: > > This patch is continuation of the effort to move all pointers in i915, > > which at any point may be pointing to device memory or system memory, to > >

[PATCH] drm/i915/guc: Use iosys_map interface to update lrc_desc

2022-03-08 Thread Balasubramani Vivekanandan
://patchwork.freedesktop.org/series/99711/ This patch converts all access to the lrc_desc through iosys_map interfaces. Cc: Lucas De Marchi Cc: John Harrison Cc: Matthew Brost Cc: Umesh Nerlige Ramappa Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/gt/uc/intel_guc.h| 2 +- .../gpu/drm

[PATCH v2 2/7] drm: Add drm_memcpy_from_wc() variant which accepts destination address

2022-03-03 Thread Balasubramani Vivekanandan
Zimmermann Cc: David Airlie Cc: Daniel Vetter Cc: Thomas Hellstr_m Cc: Lucas De Marchi Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/drm_cache.c | 54 + include/drm/drm_cache.h | 3 +++ 2 files changed, 57 insertions(+) diff --git a/drivers

[PATCH v2 0/7] drm/i915: Use the memcpy_from_wc function from drm

2022-03-03 Thread Balasubramani Vivekanandan
feedback from Lucas) Cc: Jani Nikula Cc: Lucas De Marchi Cc: David Airlie Cc: Daniel Vetter Cc: Chris Wilson Cc: Thomas Hellstr_m Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: Nirmoy Das Balasubramani Vivekanandan (7): drm: Relax alignment constraint for destination

[PATCH v2 1/7] drm: Relax alignment constraint for destination address

2022-03-03 Thread Balasubramani Vivekanandan
-off-by: Balasubramani Vivekanandan Reviewed-by: Lucas De Marchi --- drivers/gpu/drm/drm_cache.c | 44 - 1 file changed, 38 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_cache.c b/drivers/gpu/drm/drm_cache.c index c3e6e615bf09..a21c1350eb09

[PATCH v2 7/7] drm/i915: Avoid dereferencing io mapped memory

2022-03-03 Thread Balasubramani Vivekanandan
as fallback. Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/i915_gpu_error.c | 45 +++ 1 file changed, 25 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c index 4967e79806f8

[PATCH v2 6/7] drm/i915/gt: Avoid direct dereferencing of io memory

2022-03-03 Thread Balasubramani Vivekanandan
is not supported but uses memcpy_fromio as fallback for copying. Cc: Matthew Brost Cc: Michał Winiarski Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/gt/selftest_reset.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v2 3/7] drm/i915: use the memcpy_from_wc call from the drm

2022-03-03 Thread Balasubramani Vivekanandan
memcpy_from_wc functions in i915_memcpy.c will be removed and replaced by the implementation in drm_cache.c. Updated to use the functions provided by drm_cache.c. Signed-off-by: Balasubramani Vivekanandan Reviewed-by: Lucas De Marchi --- drivers/gpu/drm/i915/gem/i915_gem_object.c | 6 -- 1

[PATCH v2 4/7] drm/i915/guc: use the memcpy_from_wc call from the drm

2022-03-03 Thread Balasubramani Vivekanandan
Marchi Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c index a24dc6441872

[PATCH v2 5/7] drm/i915/selftests: use the memcpy_from_wc call from the drm

2022-03-03 Thread Balasubramani Vivekanandan
accordingly (Lucas) Cc: Lucas De Marchi Cc: Matthew Auld Cc: Thomas Hellstr_m Signed-off-by: Balasubramani Vivekanandan --- .../drm/i915/selftests/intel_memory_region.c | 41 +-- 1 file changed, 28 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/i915/selftests

Re: [Intel-gfx] [PATCH 0/7] drm/i915: Use the memcpy_from_wc function from drm

2022-02-23 Thread Balasubramani Vivekanandan
On 23.02.2022 10:02, Das, Nirmoy wrote: > > On 22/02/2022 15:51, Balasubramani Vivekanandan wrote: > > drm_memcpy_from_wc() performs fast copy from WC memory type using > > non-temporal instructions. Now there are two similar implementations of > > this function. O

[PATCH 7/7] drm/i915: Avoid dereferencing io mapped memory

2022-02-22 Thread Balasubramani Vivekanandan
as fallback. Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/i915_gpu_error.c | 45 +++ 1 file changed, 25 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c index 1d042551619e

[PATCH 6/7] drm/i915/gt: Avoid direct dereferencing of io memory

2022-02-22 Thread Balasubramani Vivekanandan
is not supported but uses memcpy_fromio as fallback for copying. Cc: Matthew Brost Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/gt/selftest_reset.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/selftest_reset.c

[PATCH 5/7] drm/i915/selftests: use the memcpy_from_wc call from the drm

2022-02-22 Thread Balasubramani Vivekanandan
memcpy_from_wc functions in i915_memcpy.c will be removed and replaced by the implementation in drm_cache.c. Updated to use the functions provided by drm_cache.c. Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/selftests/intel_memory_region.c | 8 ++-- 1 file changed, 6

[PATCH 4/7] drm/i915/guc: use the memcpy_from_wc call from the drm

2022-02-22 Thread Balasubramani Vivekanandan
memcpy_from_wc functions in i915_memcpy.c will be removed and replaced by the implementation in drm_cache.c. Updated to use the functions provided by drm_cache.c. Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 11 --- 1 file changed, 8

[PATCH 3/7] drm/i915: use the memcpy_from_wc call from the drm

2022-02-22 Thread Balasubramani Vivekanandan
memcpy_from_wc functions in i915_memcpy.c will be removed and replaced by the implementation in drm_cache.c. Updated to use the functions provided by drm_cache.c. Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/gem/i915_gem_object.c | 8 1 file changed, 4 insertions

[PATCH 2/7] drm: Add drm_memcpy_from_wc() variant which accepts destination address

2022-02-22 Thread Balasubramani Vivekanandan
Zimmermann Cc: David Airlie Cc: Daniel Vetter Cc: Thomas Hellstr_m Signed-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/drm_cache.c | 54 + include/drm/drm_cache.h | 3 +++ 2 files changed, 57 insertions(+) diff --git a/drivers/gpu/drm/drm_cache.c b

[PATCH 1/7] drm: Relax alignment constraint for destination address

2022-02-22 Thread Balasubramani Vivekanandan
-off-by: Balasubramani Vivekanandan --- drivers/gpu/drm/drm_cache.c | 44 - 1 file changed, 38 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_cache.c b/drivers/gpu/drm/drm_cache.c index c3e6e615bf09..a21c1350eb09 100644 --- a/drivers/gpu/drm

[PATCH 0/7] drm/i915: Use the memcpy_from_wc function from drm

2022-02-22 Thread Balasubramani Vivekanandan
Balasubramani Vivekanandan (7): drm: Relax alignment constraint for destination address drm: Add drm_memcpy_from_wc() variant which accepts destination address drm/i915: use the memcpy_from_wc call from the drm drm/i915/guc: use the memcpy_from_wc call from the drm drm/i915/selftests: use

Re: [Intel-gfx] [PATCH v2 1/1] drm/i915: Add fallback inside memcpy_from_wc functions

2022-02-09 Thread Balasubramani Vivekanandan
On 08.02.2022 11:11, Lucas De Marchi wrote: > On Mon, Feb 07, 2022 at 09:43:08PM +0530, Balasubramani Vivekanandan wrote: > > memcpy_from_wc functions can fail if SSE4.1 is not supported or the > > supplied addresses are not 16-byte aligned. It was then upto to the > >

[PATCH v2 1/1] drm/i915: Add fallback inside memcpy_from_wc functions

2022-02-07 Thread Balasubramani Vivekanandan
-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/gem/i915_gem_object.c | 5 +- drivers/gpu/drm/i915/gt/selftest_reset.c | 8 ++- drivers/gpu/drm/i915/i915_gpu_error.c | 9 ++- drivers/gpu/drm/i915/i915_memcpy.c | 78 -- drivers/gpu/drm/i915/i915_memcpy.h

[PATCH v2 0/1] Add fallback inside memcpy_from_wc functions

2022-02-07 Thread Balasubramani Vivekanandan
Fallback function implemented inside memcpy_from_wc functions when copying using accelerated read is not possible. v2: Fixed Sparse warnings Balasubramani Vivekanandan (1): drm/i915: Add fallback inside memcpy_from_wc functions drivers/gpu/drm/i915/gem/i915_gem_object.c | 5 +- drivers/gpu

[PATCH] drm/i915: Add fallback inside memcpy_from_wc functions

2022-02-03 Thread Balasubramani Vivekanandan
-by: Balasubramani Vivekanandan --- drivers/gpu/drm/i915/gem/i915_gem_object.c | 3 +- drivers/gpu/drm/i915/gt/selftest_reset.c | 8 ++- drivers/gpu/drm/i915/i915_gpu_error.c | 9 ++- drivers/gpu/drm/i915/i915_memcpy.c | 78 -- drivers/gpu/drm/i915/i915_memcpy.h