Hi Alex,
On Sun, Apr 15, 2018 at 9:48 PM Agrawal, Akshu wrote:
>
>
>
> On 4/13/2018 9:45 PM, Daniel Kurtz wrote:
> > Commit 51f7415039d4 ("drm/amd/amdgpu: creating two I2S instances for
> > stoney/cz") added support for the "BT_I2S" ACP i2s channel.
3509] 880107d4dd00: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
fc
[6.613509]
==
Fixes: 51f7415039d4 ("drm/amd/amdgpu: creating two I2S instances for stoney/cz")
Signed-off-by: Daniel Kurtz <djku...@chromium.org
On Tue, Jan 24, 2017 at 9:35 AM, Bibby Hsieh <bibby.hs...@mediatek.com> wrote:
>
> Hi, Daniel,
>
> Thanks for your comment.
>
> On Tue, 2017-01-03 at 14:27 +0800, Daniel Kurtz wrote:
> > On Fri, Dec 30, 2016 at 2:26 PM, Bibby Hsieh <bibby.hs...@mediatek.com>
&
Hi Kristian,
On Wed, Dec 21, 2016 at 8:12 AM, Kristian H. Kristensen
wrote:
> From: "Kristian H. Kristensen"
>
> This new ioctl exctends DRM_IOCTL_MODE_GETPLANE, by returning
> information about the modifiers that will work with each format.
>
> Signed-off-by: Kristian H. Kristensen
> ---
>
On Fri, Dec 30, 2016 at 2:26 PM, Bibby Hsieh
wrote:
>
> MT8173 overlay can support UYVY and YUYV format,
> we add the format in DRM driver.
>
> Signed-off-by: Bibby Hsieh
> Reviewed-by: Daniel Kurtz
> ---
> drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 21
RM_FORMAT_XRGB,
> DRM_FORMAT_ARGB,
> DRM_FORMAT_RGB565,
> + DRM_FORMAT_YUYV,
> + DRM_FORMAT_UYVY,
nit: probably better to alphabetize these.
Other than that,
Reviewed-by: Daniel Kurtz
>
> };
>
> static void mtk_plane_reset(struct drm_plane *plane)
> --
> 1.9.1
>
Hi YT,
On Fri, Nov 25, 2016 at 6:34 PM, YT Shen wrote:
>
> There are some hardware settings changed, between MT8173 & MT2701:
> DISP_OVL address offset changed, color format definition changed.
> DISP_RDMA fifo size changed.
> DISP_COLOR offset changed.
> MIPI_TX pll setting changed.
> And add
Hi YT,
I don't see a reason to handle device_data in such a generic way at
the generic mtk_ddp_comp layer.
The device data is very component specific, so just define different
structs for different comp types, ie:
struct mtk_disp_ovl_driver_data {
unsigned int reg_ovl_addr;
unsigned int
Hi CK,
On Thu, Nov 17, 2016 at 1:36 PM, CK Hu wrote:
> Hi, Jitao:
>
>
> On Wed, 2016-11-16 at 11:20 +0800, Jitao Shi wrote:
>> Tune dsi frame rate by pixel clock, dsi add some extra signal (i.e.
>> Tlpx, Ths-prepare, Ths-zero, Ths-trail,Ths-exit) when enter and exit LP
>> mode, those signals
Hi YT,
Sorry for the very late review.
My biggest problem with this patch is it describes itself as adding
support for a new use case "DSI -> panel", but makes many changes to
the existing working flow "DSI -> bridge -> panel".
If these changes are really needed, or improve the existing flow,
S.
> So need to multiply a coefficient to offset the extra signal's effect.
> coefficient = ((htotal*bpp/lane_number)+Tlpx+Ths_prep+Ths_zero+
> Ths_trail+Ths_exit)/(htotal*bpp/lane_number)
>
> Signed-off-by: Jitao Shi
For this patch,
Reviewed-by: Daniel Kurtz
But, o
On Tue, Oct 25, 2016 at 6:23 AM, Matthias Brugger
wrote:
>
> On 10/18/2016 04:37 PM, Enric Balletbo Serra wrote:
> [...]
>>> --- /dev/null
>>> +++ b/drivers/gpu/drm/bridge/parade-ps8640.c
> [...]
>>>
>>> +
>>> +/* Firmware */
>>> +#define PS_FW_NAME "ps864x_fw.bin"
>>> +
>>
>> From
On Thu, Sep 29, 2016 at 11:29 AM, Bibby Hsieh
wrote:
>
> Clean the interrupt status before enable interrupt
> and set the vblank_disable_allowed to fix the issue.
For the series:
Reviewed-by: Daniel Kurtz
>
> Bibby Hsieh (2):
> drm/mediatek: set vblank_disable_allow
Hi Laurent,
On Mon, Sep 19, 2016 at 8:27 PM, Laurent Pinchart
wrote:
> The vblank interrupt is disabled after one occurrence, preventing the
> atomic update event from being processed twice. However, this also
> prevents the software frame counter from being updated correctly that
> would
On Wed, Sep 21, 2016 at 3:36 PM, Sean Paul wrote:
> On Mon, Sep 19, 2016 at 7:14 AM, Daniel Kurtz wrote:
>> Hi Sean,
>>
>> On Sat, Sep 17, 2016 at 2:22 AM, Sean Paul wrote:
>>>
>>> Instead of assigning device managed resources to local variables,
&
On Sat, Sep 17, 2016 at 2:22 AM, Sean Paul wrote:
> If create_crtc fails in vop bind, ensure the irq refcount is zeroed
> back out before exiting.
>
> Signed-off-by: Sean Paul
Reviewed-by: Daniel Kurtz
> ---
> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 6 +-
&g
Hi Sean,
On Sat, Sep 17, 2016 at 2:22 AM, Sean Paul wrote:
>
> Instead of assigning device managed resources to local variables,
> keep track of them in the vop struct.
Why this patch?
Is it fixing an issue?
Or, is it preparing for some future use of ahb_rst outside of vop_initial?
I thought
On Wed, Sep 7, 2016 at 3:12 AM, Sean Paul wrote:
> The ->set() callback would always be called when transitioning
> from FLUSH->DISABLE since we assign state to psr->state right
> above the skip condition.
>
> Reported-by: Daniel Kurtz
> Signed-off-by: Sean Paul
Hi Ville,
Two fixes inline...
On Wed, Jul 27, 2016 at 1:34 AM, wrote:
>
> From: Ville Syrjälä
>
> Add a version of drm_plane_helper_check_update() which takes a plane
> state instead of having the caller pass in everything.
>
> And to reduce code duplication, let's reimplement
>
Hi Emil,
One answer inline below. The rest I leave to Jitao...
[snip...]
On Fri, Jun 17, 2016 at 3:14 AM, Emil Velikov
wrote:
>> +static ssize_t ps8640_update_fw_store(struct device *dev,
>> + struct device_attribute *attr,
>> +
Hi Jitao,
On Thu, Jun 2, 2016 at 5:57 PM, Jitao Shi wrote:
>
> This patch adds drm_bridge driver for parade DSI to eDP bridge chip.
>
> Signed-off-by: Jitao Shi
> Reviewed-by: Daniel Kurtz
> ---
> Changes since v15:
> - Drop drm_connector_(un)register calls from para
Hi Jitao,
This patch looks really good now.
Just saw small nits below.
Other than these small items, for the series:
Reviewed-by: Daniel Kurtz
On Thu, Mar 17, 2016 at 9:15 AM, Jitao Shi wrote:
> This patch adds drm_bridge driver for parade DSI to eDP bridge chip.
>
> Signed-off-by:
On Tue, Mar 15, 2016 at 7:49 PM, Philipp Zabel
wrote:
>
> Hi Daniel,
>
> Am Mittwoch, den 09.03.2016, 22:07 +0800 schrieb Daniel Kurtz:
> > Hi Philipp, CK,
> >
> > Some small comments.
> > Nothing that couldn't be addressed after merging, if you prefer.
&g
Hi Philipp, Jie,
Some small comments.
Nothing that can't be fixed after merging if you prefer.
On Tue, Mar 8, 2016 at 9:27 PM, Philipp Zabel wrote:
> From: Jie Qiu
>
> Add DPI connector/encoder to support HDMI output via the
> attached HDMI bridge.
>
> Signed-off-by: Jie Qiu
> Signed-off-by:
Hi Philipp, CK,
Some small comments.
Nothing that couldn't be addressed after merging, if you prefer.
On Tue, Mar 8, 2016 at 9:27 PM, Philipp Zabel wrote:
> From: CK Hu
>
> This patch add a drm encoder/connector driver for the MIPI DSI function
> block of the Mediatek display subsystem and a
Hi Philipp & Jie,
Sorry I only now had a chance to dig deeper and review the HDMI driver.
Lots of comments inline below...
On Tue, Mar 8, 2016 at 9:27 PM, Philipp Zabel wrote:
> From: Jie Qiu
>
> This patch adds drivers for the HDMI bridge connected to the DPI0
> display subsystem function
Hi Jitao,
Getting very close now...
Comments inline...
On Tue, Feb 23, 2016 at 3:35 PM, Jitao Shi wrote:
> This patch adds drm_bridge driver for parade DSI to eDP bridge chip.
>
> Signed-off-by: Jitao Shi
> ---
> Changes since v10:
> - Tuning PS8640 reset sleep pins squence
>
> The
Hi Philipp,
I tried using this driver with the Jitao Shi's latest Parade PS8640
driver from [0], which is based on Archit's recent DRM/DSI patch set
[1], and the parade bridge driver fails to find its DSI host using
of_find_mipi_dsi_host_by_node().
[0 ]https://patchwork.kernel.org/patch/8199281/
Hi Philipp,
On Thu, Feb 4, 2016 at 3:25 AM, Philipp Zabel wrote:
> From: CK Hu
>
> This patch adds the device nodes for the DISP function blocks
> comprising the display subsystem.
>
> Signed-off-by: CK Hu
> Signed-off-by: Cawa Cheng
> Signed-off-by: Jie Qiu
>
On Thu, Feb 4, 2016 at 2:37 PM, CK Hu wrote:
> Hi Philipp:
>
> On Wed, 2016-02-03 at 12:01 +0100, Philipp Zabel wrote:
>> Hi Daniel,
>>
>
>> > > +static void mtk_output_dsi_disable(struct mtk_dsi *dsi)
>> > > +{
>> > > + if (!dsi->enabled)
>> > > + return;
>> > > +
>> > > +
Hi Jitao,
Looks really good.
Just a couple of tiny things...
On Wed, Feb 3, 2016 at 4:48 PM, Jitao Shi wrote:
>
> This patch adds drm_bridge driver for parade DSI to eDP bridge chip.
>
> Signed-off-by: Jitao Shi
> ---
[snip]
> +static int ps8640_get_modes(struct drm_connector *connector)
Hi Jitao,
One more comment, inline...
On Mon, Feb 1, 2016 at 12:13 PM, Jitao Shi wrote:
> This patch adds drm_bridge driver for parade DSI to eDP bridge chip.
>
> Signed-off-by: Jitao Shi
[snip]
> +static int ps8640_probe(struct i2c_client *client,
> + const struct
atch adds an initial DRM driver for the Mediatek MT8173 DISP
> subsystem. It currently supports two fixed output streams from the
> OVL0/OVL1 sources to the DSI0/DPI0 sinks, respectively.
>
> Signed-off-by: CK Hu
> Signed-off-by: YT Shen
> Signed-off-by: Daniel Kurtz
> Signed-off-by:
t; subsystem. It currently supports two fixed output streams from the
> OVL0/OVL1 sources to the DSI0/DPI0 sinks, respectively.
>
> Signed-off-by: CK Hu
> Signed-off-by: YT Shen
> Signed-off-by: Daniel Kurtz
> Signed-off-by: Philipp Zabel
[snip]
> +int mtk_drm_crtc_
Hi Philipp,
Two more comments below...
On Tue, Feb 2, 2016 at 4:10 PM, Daniel Kurtz wrote:
> On Tue, Jan 5, 2016 at 1:36 AM, Philipp Zabel
> wrote:
>> From: CK Hu
>>
>> This patch adds the device nodes for the DISP function blocks
>> comprising the display subs
Hi Philipp,
I ran into some issues when trying to bring up just the DSI path of
the Mediatek DRM driver.
Things were failing in probe/bind that triggered some oopses in the
unbind/error paths.
This resulted in the following review of the dsi patch...
On Tue, Jan 12, 2016 at 11:15 PM, Philipp
On Tue, Jan 5, 2016 at 1:36 AM, Philipp Zabel wrote:
> From: CK Hu
>
> This patch adds the device nodes for the DISP function blocks
> comprising the display subsystem.
>
> Signed-off-by: CK Hu
> Signed-off-by: Cawa Cheng
> Signed-off-by: Jie Qiu
> Signed-off-by:
On Mon, Feb 1, 2016 at 12:13 PM, Jitao Shi wrote:
> This patch adds drm_bridge driver for parade DSI to eDP bridge chip.
>
> Signed-off-by: Jitao Shi
> ---
> Changes since v7:
> - Change ps8640_regw to ps8640_regw_bytes and remove devm_kzalloc
> - Fine tune ps8640 power squence
> - Add
tly supports two fixed output streams from the
> OVL0/OVL1 sources to the DSI0/DPI0 sinks, respectively.
>
> Signed-off-by: CK Hu
> Signed-off-by: YT Shen
> Signed-off-by: Daniel Kurtz
> Signed-off-by: Philipp Zabel
[snip...]
> diff --git a/drivers/gpu/drm/mediatek/mt
Hi Jitao,
On Tue, Jan 12, 2016 at 6:18 PM, Jitao Shi wrote:
> This patch adds drm_bridge driver for parade DSI to eDP bridge chip.
>
> Signed-off-by: Jitao Shi
> ---
> Changes since v6:
> - Add ps8640 firmware update function
> - Change i2c to i2c_transfer from i2c_master_recv/i2c_master_send
Hi Philipp,
On Wed, Dec 16, 2015 at 5:52 PM, Philipp Zabel
wrote:
> Hi Daniel,
>
> Am Dienstag, den 15.12.2015, 02:57 +0800 schrieb Daniel Kurtz:
>> HI Philipp,
>>
>> This driver is looking really good.
>>
>> But, still some things to think about (mostl
On Tue, Dec 15, 2015 at 11:30 AM, Jitao Shi wrote:
> This patch adds drm_bridge driver for parade DSI to eDP bridge chip.
>
> Signed-off-by: Jitao Shi
> ---
> Changes since v5
> -fix compile errors when CONFIG_GPIOLIB=n
> ---
> drivers/gpu/drm/bridge/Kconfig | 10 +
>
HI Philipp,
This driver is looking really good.
But, still some things to think about (mostly small) inline below...
On Tue, Dec 1, 2015 at 5:07 AM, Philipp Zabel wrote:
> From: CK Hu
>
> This patch adds an initial DRM driver for the Mediatek MT8173 DISP
> subsystem. It currently supports two
Hi Alex,
Drive-by review because I was just reviewing something similar for a
different device...
On Wed, Nov 25, 2015 at 6:15 AM, Alex Goins wrote:
> If a buffer is backed by dmabuf, wait on its reservation object's exclusive
> fence before flipping.
>
> v2: First commit
> v3: Remove
Hi Tomeu,
On Tue, Oct 27, 2015 at 10:38 PM, Tomeu Vizoso
wrote:
> Adds a function that sets the pointer to dev_pm_domain in struct device
> and that warns if the device has already finished probing. The reason
> why we want to enforce that is because in the general case that can
> cause problems
Hi Philipp,
A bunch of review comments inline.
On Wed, Nov 4, 2015 at 7:44 PM, Philipp Zabel wrote:
> From: CK Hu
>
> This patch adds an initial DRM driver for the Mediatek MT8173 DISP
> subsystem. It currently supports two fixed output streams from the
> OVL0/OVL1 sources to the DSI0/DPI0
On Fri, Oct 2, 2015 at 3:40 PM, Philipp Zabel wrote:
> Am Donnerstag, den 01.10.2015, 22:29 +0800 schrieb Daniel Kurtz:
>> On Thu, Oct 1, 2015 at 8:58 PM, Rob Herring wrote:
>> > I was thinking one of the display related blocks like
>> > whatever block provi
On Thu, Oct 1, 2015 at 8:58 PM, Rob Herring wrote:
> On Thu, Oct 1, 2015 at 3:59 AM, Philipp Zabel
> wrote:
>> Am Mittwoch, den 30.09.2015, 12:13 -0500 schrieb Rob Herring:
>>> On Mon, Sep 21, 2015 at 3:11 AM, Philipp Zabel
>>> wrote:
>>> > Note how the display-subsystem node overlaps the
ver
> - Added HDMI driver
> - Added HDMI DDC I2C master driver
> - Added HDMI PHY driver
>
> CK Hu (3):
> dt-bindings: drm/mediatek: Add Mediatek display subsystem dts binding
> drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.
> drm/mediatek: Add DSI sub dri
Hi Eric,
Thanks for starting to upstream this Analogix Slimport driver!
As Greg says, please move this driver to its intended directory, I presume:
/drivers/gpu/drm/bridge
And when you submit, use get_maintainer.pl to add the proper reviewers
and lists.
At present, you have no DRM folks, nor
] Previously, we were performing the mmap() without first taking a
reference on the underlying gem buffer. This could leak ptes if the gem
object is destroyed while userspace is still holding the mapping.
Signed-off-by: Daniel Kurtz
Reviewed-by: Daniel Vetter
Cc: stable at vger.kernel.org
---
drivers/gpu
On Sun, Apr 19, 2015 at 12:55 AM, Heiko Stübner wrote:
>
> Am Donnerstag, 16. April 2015, 16:41:51 schrieb Ãrjan Eide:
> > Set vm_pgoff to 0 after using it to look up the GEM node, before passing
> > it on rockchip_gem_mmap_buf() where the offset must be from the start of
> > the buffer.
> >
>
It's not necessary if we are about to skip the rest of the if clause anyway
because name is NULL.
On May 28, 2015 9:14 PM, "Emil Velikov" wrote:
> On 28 May 2015 at 00:57, Joonyoung Shim wrote:
> > This is to remove to open the DRM device unnecessarily as call
> > drmAvailable() when name is
NAK. The original code is correct.
On Thu, May 14, 2015 at 2:17 PM, Guo Yejun wrote:
> Signed-off-by: Guo Yejun
> ---
> xf86drm.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/xf86drm.c b/xf86drm.c
> index f7c45f8..5e7306e 100644
> --- a/xf86drm.c
> +++
e comments start are
supposed to start with a single "/*"
[0] https://www.kernel.org/doc/Documentation/CodingStyle
Other than that, this patch is
Reviewed-by: Daniel Kurtz
Thanks for sending this up!
>
> + vma->vm_pgoff = 0;
> +
> obj = container_of(node, struct drm_gem_object, vma_node);
> ret = rockchip_gem_mmap_buf(obj, vma);
>
> --
> 1.9.1
>
ith the cookie value still in vma->vm_pgoff.
>
> rockchip_gem_mmap_buf() in drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> still does this. It should be fixed before fixing
> arm_iommu_mmap_attrs().
>
> Signed-off-by: Ãrjan Eide
Reviewed-by: Daniel Kurtz
I tested this patch
t;irq = (unsigned int)irq;
But, either way, this patch is:
Reviewed-By: Daniel Kurtz
Thanks for the fix.
>
> /* vop AHP clk */
> struct clk *hclk;
> --
> 2.1.4
>
>
Hi Heiko,
On Sun, Apr 19, 2015 at 12:30 AM, Heiko Stübner wrote:
> platform_get_irq() can return negative error values and we already test for
> these. Therefore the variable holding this value should be signed to not
> loose error values.
>
> Reported-by: David Binderman
> Signed-off-by:
Hi Emil,
On Thu, Mar 26, 2015 at 11:12 PM, Emil Velikov
wrote:
>
> Hi Daniel,
> On 25/03/15 01:01, Daniel Kurtz wrote:
> > Unfortunately, there are some users of libdrm installed headers that like
> > to be built with -std=c89 -pedantic, which does not like "inline&q
Unfortunately, there are some users of libdrm installed headers that like
to be built with -std=c89 -pedantic, which does not like "inline".
However, __inline works.
Signed-off-by: Daniel Kurtz
---
xf86drmMode.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xf8
On Fri, Mar 20, 2015 at 1:50 AM, Emil Velikov
wrote:
> On 19/03/15 17:42, Daniel Kurtz wrote:
>> On Fri, Mar 6, 2015 at 4:52 PM, Daniel Kurtz wrote:
>>> There is a rockchip drm kms driver.
>>> Add "rockchip" to the static lists of driver names
On Fri, Mar 6, 2015 at 4:54 PM, Daniel Kurtz wrote:
> --enable-install-test-programs allows tests to be installed in $bindir.
> This is disabled by default, but very useful when cross compiling.
>
> Signed-off-by: Daniel Kurtz
Ping?
Can somebody please help review & push thi
On Fri, Mar 6, 2015 at 4:52 PM, Daniel Kurtz wrote:
> There is a rockchip drm kms driver.
> Add "rockchip" to the static lists of driver names in the the standard
> set of tests.
>
> Signed-off-by: Daniel Kurtz
Ping?
Can somebody please help review & p
educe one level of indirection
makes the code slightly more readable."
, but otherwise this is:
Reviewed-by: Daniel Kurtz
> ---
>
> Changes in v2: None
>
> drivers/gpu/drm/bridge/dw_hdmi.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git
> + sizes.surface_height = max_t(u32, desired_mode->vdisplay + y,
> sizes.surface_width);
This should be:
sizes.surface_height = max_t(u32, desired_mode->vdisplay + y,
sizes.surface_height);
Other than that, this one is:
Reviewed-by: Daniel Kurtz
> +
--enable-install-test-programs allows tests to be installed in $bindir.
This is disabled by default, but very useful when cross compiling.
Signed-off-by: Daniel Kurtz
---
tests/proptest/Makefile.am | 5 +
1 file changed, 5 insertions(+)
diff --git a/tests/proptest/Makefile.am b/tests
There is a rockchip drm kms driver.
Add "rockchip" to the static lists of driver names in the the standard
set of tests.
Signed-off-by: Daniel Kurtz
---
tests/kmstest/main.c | 1 +
tests/modetest/modetest.c | 2 +-
tests/proptest/proptest.c | 2 +-
tests/vbltest/vbltest.c | 2 +
On Tue, Feb 24, 2015 at 7:02 PM, Philipp Zabel
wrote:
> It is replaced by drm_of_encoder_active_endpoint_id.
>
> Suggested-by: Daniel Kurtz
> Signed-off-by: Philipp Zabel
Reviewed-by: Daniel Kurtz
> ---
> drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 2 +-
> dri
Suggested-by: Daniel Kurtz
> Signed-off-by: Philipp Zabel
Reviewed-by: Daniel Kurtz
> ---
> drivers/gpu/drm/drm_of.c | 34 ++
> include/drm/drm_of.h | 32
> 2 files changed, 66 insertions(+)
>
> diff
t; -
> + for_each_endpoint_of_node(node, ep) {
> port = of_graph_get_remote_port(ep);
> of_node_put(port);
Shouldn't we put port after comparing it to crtc->port?
This looks like an existing issue, though so this patch is (assuming
the series [0] i
On Tue, Feb 3, 2015 at 11:12 PM, Yakir Yang wrote:
> Signed-off-by: Yakir Yang
Reviewed-by: Daniel Kurtz
> ---
> Changes in v3:
> - Combine hdmi_set_clock_regenerator_n() and hdmi_regenerate_cts()
>
> Changes in v2: None
>
> drivers/gpu/drm/bridge/dw_hdmi.c | 16 ++
On Tue, Feb 3, 2015 at 11:11 PM, Yakir Yang wrote:
> By parsing the indentification registers we can know what functions
> are present on the hdmi ip.
>
> Signed-off-by: Yakir Yang
> ---
> Changes in v3:
> - Add ID registers parse and record
>
> Changes in v2: None
>
>
On Feb 4, 2015 11:38 AM, "Mark yao" wrote:
>
> On 2015å¹´02æ02æ¥ 15:53, Daniel Vetter wrote:
>>
>> On Mon, Feb 02, 2015 at 10:30:09AM +0800, Mark yao wrote:
>>>
>>> On 2015å¹´02æ02æ¥ 10:07, Daniel Kurtz wrote:
>>>>
>>>&g
Hi ykk,
On Fri, Jan 30, 2015 at 7:29 PM, Yakir Yang wrote:
> RK3288's VOP do not support INTERLACE display mode, so we should
> remove those modes out of mode_ok list.
>
> Signed-off-by: Yakir Yang
Reviewed-by: Daniel Kurtz
Can you move this patch out of your hdmi audio patch s
Hi ykk,
On Sat, Jan 31, 2015 at 10:34 PM, Yang Kuankuan wrote:
>
> On 01/31/2015 06:48 AM, Russell King - ARM Linux wrote:
>>
>>> +void hdmi_audio_clk_enable(struct dw_hdmi *hdmi)
>>> +{
>>> + if (hdmi->audio_enable)
>>> + return;
>>> +
>>> + mutex_lock(>audio_mutex);
On Sat, Jan 31, 2015 at 5:43 PM, Heiko Stübner wrote:
> Am Samstag, 31. Januar 2015, 13:43:23 schrieb Daniel Kurtz:
>> Hi Heiko,
>>
>> On Sat, Jan 31, 2015 at 3:28 AM, Heiko Stübner wrote:
>> > The function disables the dclk at the beginning, so don't simply ret
& FS_INTR)) {
> - DRM_ERROR("Unknown VOP IRQs: %#02x\n", active_irqs);
> - return IRQ_NONE;
> + if (active_irqs & DSP_HOLD_VALID_INTR) {
> + if (!completion_done(>dsp_hold_completion))
Why i
On Jan 31, 2015 5:37 PM, "Heiko Stübner" wrote:
>
> Am Samstag, 31. Januar 2015, 13:43:23 schrieb Daniel Kurtz:
> > Hi Heiko,
> >
> > On Sat, Jan 31, 2015 at 3:28 AM, Heiko Stübner wrote:
> > > The function disables the dclk at the beginning, so don'
Hi Heiko,
On Sat, Jan 31, 2015 at 3:28 AM, Heiko Stübner wrote:
> The function disables the dclk at the beginning, so don't simply return
> when an error happens, but instead enable the clock again, so that
> enable and disable calls are balanced.
This function is a bit of a disaster, and
f-by: Dan Carpenter
>
Otherwise, good catch!
Reviewed-by: Daniel Kurtz
>
> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> index 98fb640..8ae239f 100644
> --- a/drivers/gpu/drm/drm_crtc.c
> +++ b/drivers/gpu/drm/drm_crtc.c
> @@ -783,7 +783,7 @@ int
On Mon, Jan 26, 2015 at 9:47 AM, huang lin wrote:
> The AUO b101ean01 panel is a 10.1" 1280x800 panel,
> which can be supported by the simple panel driver.
>
> Signed-off-by: huang lin
Reviewed-by: Daniel Kurtz
>
> ---
>
> Changes in v4:
> - Add auo,b101ea
ady power off at SUSPEND, crash
> so use a bool val is more suitable.
>
> Signed-off-by: Mark Yao
This version looks good. Moving to atomic is definitely important,
and part of the plan.
For now, though, this series is:
Reviewed-by: Daniel Kurtz
> ---
> Changes in v2:
&g
dsp_vsync_pol
> VSYNC polarity
> 1'b0 : negative
> 1'b1 : positive
> dsp_hsync_pol
> HSYNC polarity
> 1'b0 : negative
> 1'b1 : positive
>
> Signed-off-by: Mark Yao
Looks good!
Reviewed-by: Daniel Kurtz
> ---
> drivers/gpu/drm/r
Mark: did you get a chance to fixup the "Reported-by" line? It's not
a bit deal if you didn't.
Dave: did you pick up this pull request? Did Mark request properly?
On Fri, Jan 9, 2015 at 12:01 PM, Daniel Kurtz wrote:
> On Wed, Jan 7, 2015 at 5:27 PM, Daniel Kurtz wrote:
>&
On Fri, Jan 16, 2015 at 11:14 AM, Daniel Kurtz wrote:
>
> On Fri, Jan 16, 2015 at 10:36 AM, huang lin wrote:
> > The AUO b101ean01 panel is a 10.1" 1280x800 panel,
> > which can be supported by the simple panel driver.
> >
> > Signed-off-by: huang li
On Fri, Jan 16, 2015 at 10:36 AM, huang lin wrote:
> The AUO b101ean01 panel is a 10.1" 1280x800 panel,
> which can be supported by the simple panel driver.
>
> Signed-off-by: huang lin
Reviewed-by: Daniel Kurtz
>
> ---
>
> Changes in v3:
> - changed moving
b/drivers/gpu/drm/panel/panel-simple.c
> @@ -392,6 +392,29 @@ static const struct panel_desc auo_b116xw03 = {
> },
> };
>
> +static const struct drm_display_mode auo_b101ean01_mode = {
Perhaps you missed my last review where I suggested moving the
definitions for auo_b101ean0
(s), which may be written
in-kernel by fbcon.
Signed-off-by: Daniel Kurtz
---
drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 2 +-
drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 17 -
drivers/gpu/drm/rockchip/rockchip_drm_gem.h | 3 ++-
3 files changed, 15 insertions(+), 7
On Wed, Jan 7, 2015 at 5:27 PM, Daniel Kurtz wrote:
> dma_alloc_attrs() returns NULL if it cannot allocate a dma buffer (or
> mapping), not a negative error code.
>
> Rerported-by: Pawel Osciak
Oops! I just noticed that this is spelled wrong. Should be "Reported-by".
Hi hl,
Thanks for submitting this patch.
On Fri, Jan 9, 2015 at 9:47 AM, huang lin wrote:
>
> The AUO b101ean01 panel is a 10.1" 1280x800 panel,
> which can be supported by the simple panel driver.
>
> Signed-off-by: huang lin
>
> ---
>
> drivers/gpu/drm/panel/panel-simple.c | 26
dma_alloc_attrs() returns NULL if it cannot allocate a dma buffer (or
mapping), not a negative error code.
Rerported-by: Pawel Osciak
Signed-off-by: Daniel Kurtz
---
drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers
Hi Andy,
This driver adds HDMI to rockchip/drm. The fact that rockchip's hdmi
uses dw_hdmi is an implementation detail. I do not think that the names
used for rk3288-hdmi should include "dw" in them.
See inline for what I mean...
On Thu, Dec 4, 2014 at 10:34 PM, Andy Yan wrote:
> Rockchip
On Tue, Dec 2, 2014 at 1:31 AM, Heiko Stübner wrote:
> Hi Mark,
>
> Am Dienstag, 2. Dezember 2014, 17:13:20 schrieb Mark Yao:
>> This a series of patches is a DRM Driver for Rockchip Socs, add support
>> for vop devices. Future patches will add additional encoders/connectors,
>> such as eDP,
On Thu, Nov 27, 2014 at 2:08 AM, Mark yao wrote:
>
> On 2014å¹´11æ27æ¥ 10:12, Dave Airlie wrote:
>>> Hi Dave
>>> Do you mean that I need send you a branch, based on drm-next, merge
>>> with
>>> iommu tree and rockchip drm?
>>
>> Yes, grab drm-next, git pull the arm/rockchip
On Fri, Nov 14, 2014 at 7:13 PM, Zubair Lutfullah Kakakhel
wrote:
>
>
> On 14/11/14 11:08, Andy Yan wrote:
>>
>> On 2014å¹´11æ14æ¥ 18:55, Zubair Lutfullah Kakakhel wrote:
>>>
>>> On 14/11/14 10:53, Andy Yan wrote:
Hi ZubairLK:
Thanks for your review.
On 2014å¹´11æ14æ¥
yte register width access
> drm: bridge/dw_hdmi: add mode_valid support
> drm: bridge/dw_hdmi: clear i2cmphy_stat0 reg in hdmi_phy_wait_i2c_done
> drm: bridge/dw_hdmi: add function dw_hdmi_phy_enable_spare
> dt-bindings: Add documentation for rockchip dw hdmi
> drm: bri
i-byte register width access
> drm: bridge/dw_hdmi: add mode_valid support
> drm: bridge/dw_hdmi: clear i2cmphy_stat0 reg in hdmi_phy_wait_i2c_done
> drm: bridge/dw_hdmi: add function dw_hdmi_phy_enable_spare
> dt-bindings: Add documentation for rockchip dw hdmi
> drm: brid
->ddc) {
> dev_dbg(hdmi->dev, "failed to read ddc node\n");
> + of_node_put(ddc_node);
> + return -EPROBE_DEFER;
> + }
Nit: You could move "of_node_put()" above &quo
all arms of this statement
> + if (hdmi->hdmi_data.video_mode.mdvi)
> [...]
> + else {
> [...]
>
> Signed-off-by: Andy Yan
Reviewed-by: Daniel Kurtz
>
> ---
>
> Changes in v11: None
> Changes in v10: None
> Changes in v9: None
> Changes in v8: None
Hi Mark,
More review comments inline... (sorry for the delay)
On Fri, Sep 26, 2014 at 6:55 PM, Mark Yao wrote:
> From: Mark yao
>
> This patch adds the basic structure of a DRM Driver for Rockchip Socs.
>
> Signed-off-by: Mark Yao
> Signed-off-by: Daniel Kurtz
> Ac
1 - 100 of 363 matches
Mail list logo
