lt;
optimal_dcfclk_for_uclk[j]) {
Regards
David Binderman
Hello there Laurent,
>Would you be able to send a patch to fix this ?
Sadly, no. My success rate with kernel patches is low enough to make it not
worth trying.
Regards
David Binderman
From: Laurent Pinchart
Sent: 09 March 2023 09:26
To: David Binderman
Cc: andrzej.ha...@intel.
n a run time sanity check to make sure no
31 bit overflow.
Just a couple of ideas for the code.
Regards
David Binderman
long literals,
like 3500UL, should
have been used ?
Regards
David Binderman
amp;& i <
num_dcfclk_sta_targets) {
It might be wise to move the limits check to before use.
Regards
David Binderman
j--) {
but
unsigned int i, j, closest_clk_lvl;
so it looks like the loop never terminates. Suggest code rework.
Regards
David Binderman
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
bytes long. Suggest code rework.
Regards
David Binderman
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
.
Regards
David Binderman
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
datawords = (*(lspr + delta) << 16) | (*lspr);
++lspr;
Regards
David Binderman
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
&& buffer->fault[i]; i++)
Regards
David Binderman
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hello there,
[linux-5.1/drivers/video/fbdev/via/viafbdev.c:233]: (style) Assignment
'depth=30' is redundant with condition 'depth==30'.
Source code is
else if (depth == 30)
depth = 30;
Suggest code rework.
Regards
David Binderman
nable_uvd(adev, true);
else
amdgpu_device_ip_set_powergating_state(adev,
AMD_IP_BLOCK_TYPE_VCN,
AMD_PG_STATE_UNGATE);
So second function call never happens. Suggest code rework.
Regards
D
stream->sink->link->connector_signal != SIGNAL_TYPE_EDP)
return false;
Suggest add some code to deal with the case that the for loop doesn't find
what it is looking for and so pipe_ctx is NULL.
Regards
David Binderman
___
dri-d
int find_bb_size(struct parser_exec_state *s)
so the code isn't properly checking the return value. Suggest code rework.
Regards
David Binderman
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/
Hello there,
Code I looked at is in linux-4.14-rc6, released 20171023, so reasonably
up to date.
I did a further check on github.com/torvalds/linux and the code
looks wrong there, too.
So I don't see the fix you mentioned in either of the places I looked.
Regards
David Binderman
t new code
if ((temp & PIPEACONF_PIPE_STATE) != 0)
break;
Regards
David Binderman
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
period;
u64 delay;
if (duty > target)
delay = slow_down_period;
else if (duty == target)
delay = min(bump_period, slow_down_period) ;
Last if can never be true, so call to min can never execute. Suggest code
rework.
Regards
David
Hello there,
drivers/gpu/drm/i915/intel_pm.c:4467]: (warning) Comparison of a boolean
expression with an integer other than 0 or 1.
Source code is
else if ((ddb_allocation && ddb_allocation /
fixed_16_16_to_u32_round_up(plane_blocks_per_line)) >= 1)
Reg
se type long ?
Regards
David Binderman
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
ESS_WO:
dmaobj->flags0 |= 0x8000;
case NV_MEM_ACCESS_RW:
dmaobj->flags2 |= 0x0002;
break;
default:
return -EINVAL;
}
Suggest either document the fallthrough or add the missing break.
Regards
Dav
[drivers/gpu/drm/radeon/r100.c:2550]: (style) Variable 'tmp' is assigned a value
that is never used.
[drivers/gpu/drm/radeon/r100.c:2875]: (style) Variable 'tmp' is assigned a value
that is never used.
Regards
David Binderman
___
dri-devel mailing li
_state)) {
Suggest code rework.
Regards
David Binderman
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
, dclk, ixCG_DCLK_CNTL, ixCG_DCLK_STATUS);
return 0;
Regards
David Binderman
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
/exynos/exynos5433_drm_decon.c:131]: (style) Same expression on
both sides of '|'.
Source code is
writel(TRIGCON_TE_AUTO_MASK | TRIGCON_SWTRIGEN
| TRIGCON_TE_AUTO_MASK | TRIGCON_SWTRIGEN,
Regards
David Binderman
___
dri-devel mailing l
ike
#define INTEL_BSM_MASK (0xUL<< 20)
might be better.
Regards
David Binderman
the variable in some way, or delete it.
Regards
David Binderman
m_crtcs)
return 0;
crtc = priv->crtcs[pipe];
Feel free to mess this tentative patch about in any way you see fit.
Regards
David Binderman
On Mon, Jun 13, 2016 at 4:27 PM, Rob Clark wrote:
> yup, looks like we can drop the two pipe<0 checks. Care to send a patch?
>
>
Checking if unsigned variable 'pipe' is less than zero.
Duplicate a few lines further down.
Regards
David Binderman
never used.
[drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c:4657]: (style) Variable 'tmp'
is assigned a value that is never used.
Regards
David Binderman
x) << 20)
Regards
David Binderman
lue that is never used.
[linux-4.6-rc2/drivers/gpu/drm/radeon/si_dpm.c:4190]: (style) Variable
'voltage_found' is assigned a value that is never used.
Regards
David Binderman
= clock;
Suggest init all fields of local variable clock shortly after declaration, that
way the function mrst_sdvo_find_best_pll can only ever return init'ed data.
Regards
David Binderman
Hello there,
[linux-next/drivers/gpu/drm/rockchip/dw-mipi-dsi.c:470]: (style) Checking if
unsigned variable 'bpp' is less than zero.
   bpp = mipi_dsi_pixel_format_to_bpp(dsi->format);
   if (bpp < 0) {
but
 unsigned int bpp, i, pre;
Suggest code rework.
Regards
David Binderman
ta Avail"
   "Special Packet Sent",
Missing comma means the consecutive strings are concatenated and so there are
only
31 elements in the array, not the presumably intended 32.
Regards
David Binderman
  blackout = RREG32(MC_SHARED_BLACKOUT_CNTL);
           WREG32(MC_SHARED_BLACKOUT_CNTL, blackout | 1);
       }
Regards
David Binderman
ase MIPI_DSI_RX_ACKNOWLEDGE_AND_ERROR_REPORT:
       pr_err("%s: rx ACK_ERR_PACLAGE\n", __func__);
       ret = 0;
   case MIPI_DSI_RX_GENERIC_SHORT_READ_RESPONSE_1BYTE:
   case MIPI_DSI_RX_DCS_SHORT_READ_RESPONSE_1BYTE:
       ret = dsi_short_read1_resp(buf, msg);
       break;
R
36 matches
Mail list logo
