Re: [PATCH] drm/connector: hdmi: Fix kerneldoc warnings

2024-06-10 Thread Dmitry Baryshkov
gned-off-by: Maxime Ripard > --- > include/drm/drm_connector.h | 207 +++- > 1 file changed, 109 insertions(+), 98 deletions(-) > With the semicolon fixed: Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v5 2/9] drm/bridge-connector: switch to using drmm allocations

2024-06-10 Thread Dmitry Baryshkov
On Mon, Jun 10, 2024 at 02:07:06PM +0200, Maxime Ripard wrote: > Hi, > > +Hans > > On Mon, Jun 10, 2024 at 02:46:03PM GMT, Dmitry Baryshkov wrote: > > On Mon, 10 Jun 2024 at 11:04, Maxime Ripard wrote: > > > > > > Hi, > > > > > > On Fr

Re: [PATCH v2 7/9] drm/bridge: cdns-dsi: Support atomic bridge APIs

2024-06-10 Thread Dmitry Baryshkov
On Mon, Jun 10, 2024 at 06:02:41PM +0530, Aradhya Bhatia wrote: > Hi Dmitry, > > Thank you for reviewing the patches. > > On 31/05/24 04:51, Dmitry Baryshkov wrote: > > On Thu, May 30, 2024 at 03:06:19PM +0530, Aradhya Bhatia wrote: > >> Change the existing

Re: [PATCH v5 2/9] drm/bridge-connector: switch to using drmm allocations

2024-06-10 Thread Dmitry Baryshkov
On Mon, 10 Jun 2024 at 11:04, Maxime Ripard wrote: > > Hi, > > On Fri, Jun 07, 2024 at 04:22:59PM GMT, Dmitry Baryshkov wrote: > > Turn drm_bridge_connector to using drmm_kzalloc() and > > drmm_connector_init() and drop the custom destroy function. The >

Re: [PATCH] drm/msm/a6xx: request memory region

2024-06-10 Thread Dmitry Baryshkov
o this file. > --- > drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 33 +++-- > 1 file changed, 11 insertions(+), 22 deletions(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH] drm/bridge: it6505: Fix potential NULL dereference

2024-06-09 Thread Dmitry Baryshkov
On Sat, Jun 08, 2024 at 05:21:08PM +0300, Dan Carpenter wrote: > Smatch complains correctly that the NULL checking isn't consistent: > > drivers/gpu/drm/bridge/ite-it6505.c:2583 it6505_poweron() > error: we previously assumed 'pdata->pwr18' could be null > (see line 2569) > > Add a

Re: [PATCH] drm/bridge: it6505: Fix potential NULL dereference

2024-06-09 Thread Dmitry Baryshkov
ine 2569) > > Add a NULL check to prevent a NULL dereference on the error path. > > Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver") > Signed-off-by: Dan Carpenter > --- > drivers/gpu/drm/bridge/ite-it6505.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deleti

Re: [PATCH v4 08/13] drm/msm/dpu: add support for virtual planes

2024-06-07 Thread Dmitry Baryshkov
On Sat, 8 Jun 2024 at 02:55, Abhinav Kumar wrote: > > > > On 6/7/2024 3:26 PM, Dmitry Baryshkov wrote: > > On Sat, 8 Jun 2024 at 00:39, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 6/7/2024 2:10 PM, Dmitry Baryshkov wrote: > &g

Re: [PATCH v4 08/13] drm/msm/dpu: add support for virtual planes

2024-06-07 Thread Dmitry Baryshkov
On Sat, 8 Jun 2024 at 00:39, Abhinav Kumar wrote: > > > > On 6/7/2024 2:10 PM, Dmitry Baryshkov wrote: > > On Fri, Jun 07, 2024 at 12:22:16PM -0700, Abhinav Kumar wrote: > >> > >> > >> On 6/7/2024 12:16 AM, Dmitry Baryshkov wrote: > >>>

Re: [PATCH v4 08/13] drm/msm/dpu: add support for virtual planes

2024-06-07 Thread Dmitry Baryshkov
On Fri, Jun 07, 2024 at 12:22:16PM -0700, Abhinav Kumar wrote: > > > On 6/7/2024 12:16 AM, Dmitry Baryshkov wrote: > > On Thu, Jun 06, 2024 at 03:21:11PM -0700, Abhinav Kumar wrote: > > > On 3/13/2024 5:02 PM, Dmitry Baryshkov wrote: > > > > Only several SSPP

Re: [PATCH] drm/msm/a6xx: request memory region

2024-06-07 Thread Dmitry Baryshkov
e corresponding managed > devres-function. Please at least compile-test the patch before sending. > > Signed-off-by: Kiarash Hajian > --- > To: Rob Clark > To: Abhinav Kumar > To: Dmitry Baryshkov > To: Sean Paul > To: Marijn Suijten > To: David Airlie > To: Da

[PATCH v5 7/9] drm/msm/hdmi: get rid of hdmi_mode

2024-06-07 Thread Dmitry Baryshkov
Use connector->display_info.is_hdmi instead of manually using drm_detect_hdmi_monitor(). Acked-by: Maxime Ripard Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi.c| 2 +- drivers/gpu/drm/msm/hdmi/hdmi.h| 2 -- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c |

[PATCH v5 9/9] drm/msm/hdmi: also send the SPD and HDMI Vendor Specific InfoFrames

2024-06-07 Thread Dmitry Baryshkov
requirements. The msm-4.4 kernel uses GENERIC0 to send HDR InfoFrame which we do not at this point anyway. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 93 ++ 1 file changed, 93 insertions(+) diff --git a/drivers/gpu/drm/msm/hdmi

[PATCH v5 2/9] drm/bridge-connector: switch to using drmm allocations

2024-06-07 Thread Dmitry Baryshkov
Turn drm_bridge_connector to using drmm_kzalloc() and drmm_connector_init() and drop the custom destroy function. The drm_connector_unregister() and fwnode_handle_put() are already handled by the drm_connector_cleanup() and so are safe to be dropped. Acked-by: Maxime Ripard Signed-off-by: Dmitry

[PATCH v5 8/9] drm/msm/hdmi: update HDMI_GEN_PKT_CTRL_GENERIC0_UPDATE definition

2024-06-07 Thread Dmitry Baryshkov
The GENERIC0_UPDATE field is a single bit. Redefine it as boolean to simplify its usage in the driver. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/registers/display/hdmi.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/registers/display

[PATCH v5 6/9] drm/msm/hdmi: make use of the drm_connector_hdmi framework

2024-06-07 Thread Dmitry Baryshkov
Setup the HDMI connector on the MSM HDMI outputs. Make use of atomic_check hook and of the provided Infoframe infrastructure. Acked-by: Maxime Ripard Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/Kconfig| 2 + drivers/gpu/drm/msm/hdmi/hdmi.c| 45

[PATCH v5 5/9] drm/msm/hdmi: turn mode_set into atomic_enable

2024-06-07 Thread Dmitry Baryshkov
The mode_set callback is deprecated, it doesn't get the drm_bridge_state, just mode-related argumetns. Turn it into the atomic_enable callback as suggested by the documentation. Acked-by: Maxime Ripard Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 33

[PATCH v5 1/9] drm/connector: hdmi: allow disabling Audio Infoframe

2024-06-07 Thread Dmitry Baryshkov
the HDMI hardware from sending the Infoframe. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_hdmi_state_helper.c | 36 + include/drm/display/drm_hdmi_state_helper.h | 1 + 2 files changed, 37 insertions(+) diff --git a/drivers/gpu/drm/display

[PATCH v5 4/9] drm/msm/hdmi: switch to atomic bridge callbacks

2024-06-07 Thread Dmitry Baryshkov
Change MSM HDMI bridge to use atomic_* callbacks in preparation to enablign the HDMI connector support. Acked-by: Maxime Ripard Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH v5 3/9] drm/bridge-connector: implement glue code for HDMI connector

2024-06-07 Thread Dmitry Baryshkov
implementation. Note, to simplify implementation, there can be only one bridge in a chain that sets DRM_BRIDGE_OP_HDMI. Setting more than one is considered an error. This limitation can be lifted later, if the need arises. Acked-by: Maxime Ripard Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm

[PATCH v5 0/9] drm/msm: make use of the HDMI connector infrastructure

2024-06-07 Thread Dmitry Baryshkov
, I'll finish MSM HDMI bridge conversion (reworking the Audio Infoframe code). Other bridges can follow the same approach (we have lt9611 / lt9611uxc / adv7511 on Qualcomm hardware). [1] https://patchwork.freedesktop.org/series/122421/ Signed-off-by: Dmitry Baryshkov --- Changes in v5: - Made

Re: [PATCH v2 4/4] drm/panel: starry: add new panel driver

2024-06-07 Thread Dmitry Baryshkov
s by the driver IC, not by the timings. Please stop top-posting. > > Similar to this driver: panel-boe-tv101wum-nl6.c > > thanks > > On Sun, Jun 2, 2024 at 12:26 AM Dmitry Baryshkov > wrote: > > > > On Sat, Jun 01, 2024 at 04:45:28PM +0800, Zhaoxiong Lv wrote: > > &

Re: [PATCH v2 2/4] drm/panel: kd101ne3: add new panel driver

2024-06-07 Thread Dmitry Baryshkov
On Fri, Jun 07, 2024 at 07:44:33PM +0800, zhaoxiong lv wrote: > hi Alex Bee > > I compared these two drivers. Although the control IC is the same, the > panel is different, and the init_cmd and timing are also slightly > different, so I added a separate driver. But it obviously uses the same

Re: [PATCH v2 1/4] dt-bindings: display: panel: Add KD101NE3-40TI support

2024-06-07 Thread Dmitry Baryshkov
On Fri, 7 Jun 2024 at 14:38, zhaoxiong lv wrote: > > hi Dmitry Baryshkov > > Because this is a separate mipi dsi driver, I did not put it in > panel-sample-dsi.yaml. Driver and bindings are two separate things. Bindings describe the hardware. If there is no other reason to

Re: [PATCH v4 08/13] drm/msm/dpu: add support for virtual planes

2024-06-07 Thread Dmitry Baryshkov
On Thu, Jun 06, 2024 at 03:21:11PM -0700, Abhinav Kumar wrote: > On 3/13/2024 5:02 PM, Dmitry Baryshkov wrote: > > Only several SSPP blocks support such features as YUV output or scaling, > > thus different DRM planes have different features. Properly utilizing > >

Re: [PATCH] drm/msm/a6xx: Fix A702 UBWC mode

2024-06-06 Thread Dmitry Baryshkov
r Abbott > Closes: > https://lore.kernel.org/linux-arm-msm/CACu1E7FTN=kwaDJMNiTmFspALzj2+Q-nvsN5ugi=vz4rdug...@mail.gmail.com/ > Signed-off-by: Konrad Dybcio > --- > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v4] drm/msm/a6xx: use __unused__ to fix compiler warnings for gen7_* includes

2024-06-06 Thread Dmitry Baryshkov
lark > Signed-off-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 12 > 1 file changed, 4 insertions(+), 8 deletions(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v4 06/13] drm/msm/dpu: split dpu_plane_atomic_check()

2024-06-06 Thread Dmitry Baryshkov
On Thu, 6 Jun 2024 at 11:53, Dmitry Baryshkov wrote: > > On Thu, 6 Jun 2024 at 02:47, Abhinav Kumar wrote: > > > > > > > > On 6/5/2024 4:32 PM, Dmitry Baryshkov wrote: > > > On Thu, 6 Jun 2024 at 02:19, Abhinav Kumar > > > wrote: > >

Re: [PATCH v4 06/13] drm/msm/dpu: split dpu_plane_atomic_check()

2024-06-06 Thread Dmitry Baryshkov
On Thu, 6 Jun 2024 at 02:47, Abhinav Kumar wrote: > > > > On 6/5/2024 4:32 PM, Dmitry Baryshkov wrote: > > On Thu, 6 Jun 2024 at 02:19, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 3/13/2024 5:02 PM, Dmitry Baryshkov wrote: &

Re: [PATCH v4 06/13] drm/msm/dpu: split dpu_plane_atomic_check()

2024-06-05 Thread Dmitry Baryshkov
On Thu, 6 Jun 2024 at 02:19, Abhinav Kumar wrote: > > > > On 3/13/2024 5:02 PM, Dmitry Baryshkov wrote: > > Split dpu_plane_atomic_check() function into two pieces: > > > > dpu_plane_atomic_check_nopipe() performing generic checks on the pstate, > >

Re: [PATCH v3] drm/msm/a6xx: use __unused__ to fix compiler warnings for gen7_* includes

2024-06-05 Thread Dmitry Baryshkov
local assignment > > changes in v3: > - drop the Link from the auto add > > Fixes: 64d6255650d4 ("drm/msm: More fully implement devcoredump for a7xx") > Suggested-by: Rob Clark > Signed-off-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 12 > 1 file changed, 4 insertions(+), 8 deletions(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH] drm/msm/a6xx: use __always_unused to fix compiler warnings for gen7_* includes

2024-06-04 Thread Dmitry Baryshkov
On Tue, Jun 04, 2024 at 02:51:04PM -0700, Abhinav Kumar wrote: > GCC diagnostic pragma method throws below warnings in some of the versions > > drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:16:9: warning: unknown option > after '#pragma GCC diagnostic' kind [-Wpragmas] > #pragma GCC diagnostic

Re: [PATCH 00/14] Add initial support for the Rockchip RK3588 HDMI TX Controller

2024-06-04 Thread Dmitry Baryshkov
On Tue, Jun 04, 2024 at 10:44:04PM +0300, Cristian Ciocaltea wrote: > On 6/1/24 7:32 PM, Dmitry Baryshkov wrote: > > On Sat, Jun 01, 2024 at 04:12:22PM +0300, Cristian Ciocaltea wrote: > >> The RK3588 SoC family integrates a Quad-Pixel (QP) variant of the > >>

Re: [PATCH] drm/msm/adreno: Add some missing MODULE_FIRMWARE entries

2024-06-04 Thread Dmitry Baryshkov
On Wed, 5 Jun 2024 at 01:30, Peter Robinson wrote: > > On Tue, 4 Jun 2024 at 23:18, Dmitry Baryshkov > wrote: > > > > On Wed, 5 Jun 2024 at 00:40, Peter Robinson wrote: > > > > > > Add missing MODULE_FIRMWARE for firmware in linux-firmware, > > >

Re: [PATCH] drm/msm/adreno: Add some missing MODULE_FIRMWARE entries

2024-06-04 Thread Dmitry Baryshkov
On Wed, 5 Jun 2024 at 00:40, Peter Robinson wrote: > > Add missing MODULE_FIRMWARE for firmware in linux-firmware, > this is needed for automatically adding firmware to things > like initrds when the drivers are built as modules. This is > useful for devices like the X13s and the RBx devices on >

Re: [PATCH] drm/msm/a6xx: Print SQE fw version

2024-06-04 Thread Dmitry Baryshkov
On Tue, 4 Jun 2024 at 18:48, Rob Clark wrote: > > From: Rob Clark > > Add the SQE fw version to dmesg and devcoredump. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 32 +++-- > drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 1 + >

Re: [PATCH 1/7] dt-bindings: display/msm/dsi: allow specifying TE source

2024-06-04 Thread Dmitry Baryshkov
On Tue, Jun 04, 2024 at 05:22:03PM +0200, Krzysztof Kozlowski wrote: > On 04/06/2024 17:14, Dmitry Baryshkov wrote: > >>>>>> > >>>>>> I didnt follow why this is a link property. Sorry , I didnt follow the > >>>>>> split part. >

Re: [PATCH 1/7] dt-bindings: display/msm/dsi: allow specifying TE source

2024-06-04 Thread Dmitry Baryshkov
On Wed, May 29, 2024 at 06:08:21PM -0700, Abhinav Kumar wrote: > > > On 5/29/2024 5:02 PM, Dmitry Baryshkov wrote: > > On Thu, 30 May 2024 at 00:57, Abhinav Kumar > > wrote: > > > > > > > > > > > > On 5/23/2024 2:58 AM, Dmitry Barys

Re: [PATCH v4 4/5] drm/mipi-dbi: Add support for DRM_FORMAT_RGB888

2024-06-04 Thread Dmitry Baryshkov
ulation_format/pixel_format/ (Dmitry) > > Signed-off-by: Noralf Trønnes > --- > drivers/gpu/drm/drm_mipi_dbi.c | 29 + > include/drm/drm_mipi_dbi.h | 5 + > 2 files changed, 30 insertions(+), 4 deletions(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v4 3/5] drm/mipi-dbi: Make bits per word configurable for pixel transfers

2024-06-04 Thread Dmitry Baryshkov
n use to tell how many > bits per word to use for the SPI transfer. > > v4: > - Expand the commit message (Dmitry) > > Signed-off-by: Noralf Trønnes > --- > drivers/gpu/drm/drm_mipi_dbi.c | 14 ++ > include/drm/drm_mipi_dbi.h | 5 + > 2 files

Re: [PATCH v2 06/22] drm/msm: Use iommu_paging_domain_alloc()

2024-06-04 Thread Dmitry Baryshkov
+-- > 1 file changed, 5 insertions(+), 2 deletions(-) Acked-by: Dmitry Baryshkov Thank you! > > diff --git a/drivers/gpu/drm/msm/msm_iommu.c b/drivers/gpu/drm/msm/msm_iommu.c > index d5512037c38b..2a94e82316f9 100644 > --- a/drivers/gpu/drm/msm/msm_iommu.c > +++ b/drivers/

Re: [PATCH v3 4/5] drm/mipi-dbi: Add support for DRM_FORMAT_RGB888

2024-06-03 Thread Dmitry Baryshkov
On Mon, Jun 03, 2024 at 01:21:35PM +0200, Noralf Trønnes via B4 Relay wrote: > From: Noralf Trønnes > > DRM_FORMAT_RGB888 is 24 bits per pixel and it would be natural to send it > on the SPI bus using a 24 bits per word transfer. The problem with this > is that not all SPI controllers support 24

Re: [PATCH v2 7/9] drm/msm/dpu: check for overflow in _dpu_crtc_setup_lm_bounds()

2024-06-03 Thread Dmitry Baryshkov
On Mon, Jun 03, 2024 at 02:24:27PM -0700, Abhinav Kumar wrote: > > > On 6/3/2024 2:16 PM, Dmitry Baryshkov wrote: > > On Mon, 3 Jun 2024 at 23:57, Abhinav Kumar > > wrote: > > > > > > > > > > > > On 6/2/2024 2:39 PM, Dmitry Ba

Re: [PATCH] drm/msm/dpu: drop duplicate drm formats from wb2_formats arrays

2024-06-03 Thread Dmitry Baryshkov
uce separate wb2_format arrays for rgb and yuv") Fixes: 53324b99bd7b ("drm/msm/dpu: add writeback blocks to the sm8250 DPU catalog") Reviewed-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v2 7/9] drm/msm/dpu: check for overflow in _dpu_crtc_setup_lm_bounds()

2024-06-03 Thread Dmitry Baryshkov
On Mon, 3 Jun 2024 at 23:57, Abhinav Kumar wrote: > > > > On 6/2/2024 2:39 PM, Dmitry Baryshkov wrote: > > Check in _dpu_crtc_setup_lm_bounds() that CRTC width is not overflowing > > LM requirements. > > > > Signed-off-by: Dmitry Baryshkov > > --- >

Re: [PATCH v3 3/5] drm/mipi-dbi: Make bits per word configurable for pixel transfers

2024-06-03 Thread Dmitry Baryshkov
On Mon, Jun 03, 2024 at 01:21:34PM +0200, Noralf Trønnes via B4 Relay wrote: > From: Noralf Trønnes > > This prepares for supporting other pixel formats than RGB565. Yes, the patch is pretty simple, however could you please expand the commit message by describing write_memory_bpw introduction.

Re: [PATCH v3 2/5] drm/mipi-dbi: Remove mipi_dbi_machine_little_endian()

2024-06-03 Thread Dmitry Baryshkov
-- > 1 file changed, 19 insertions(+), 16 deletions(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v3 00/12] drm/imx/ipuv3: switch LDB and parallel-display driver to use drm_bridge_connector

2024-06-03 Thread Dmitry Baryshkov
nknown > OF: /soc/bus@6000/i2c@63fc4000/bridge-hdmi@39:sil,sii9022 > ops: [0x7] detect edid hpd > bridge[2]: 0xc0fb9794 > type: [11] HDMI-A > OF: /connector-hdmi:hdmi-connector > ops: [0x0] > > On Sun, Jun 2, 2024 at 5:04 AM Dmitry Barysh

Re: [PATCH v4 1/9] drm/connector: hdmi: accept NULL for Audio Infoframe

2024-06-03 Thread Dmitry Baryshkov
On Mon, Jun 03, 2024 at 11:09:40AM +0200, Maxime Ripard wrote: > Hi, > > Sorry for not answering your mail on the previous version sooner. > > On Fri, May 31, 2024 at 11:07:24PM GMT, Dmitry Baryshkov wrote: > > Allow passing NULL as audio infoframe as a way to disabl

[PATCH v2 8/9] drm/msm/dpu: merge MAX_IMG_WIDTH/HEIGHT with DPU_MAX_IMG_WIDTH/HEIGHT

2024-06-02 Thread Dmitry Baryshkov
dpu_formats.c defines DPU_MAX_IMG_WIDTH and _HEIGHT, while dpu_hw_catalog.h defines just MAX_IMG_WIDTH and _HEIGHT. Merge these constants to remove duplication. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c| 3 --- drivers/gpu

[PATCH v2 9/9] drm/msm/dpu: sync mode_config limits to the FB limits in dpu_plane.c

2024-06-02 Thread Dmitry Baryshkov
Lift mode_config limits set by the DPU driver to the actual FB limits as handled by the dpu_plane.c. Move 2*max_lm_width check where it belongs, to the drm_crtc_helper_funcs::mode_valid() callback. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 15

[PATCH v2 7/9] drm/msm/dpu: check for overflow in _dpu_crtc_setup_lm_bounds()

2024-06-02 Thread Dmitry Baryshkov
Check in _dpu_crtc_setup_lm_bounds() that CRTC width is not overflowing LM requirements. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b

[PATCH v2 5/9] drm/msm/dpu: check for the plane pitch overflow

2024-06-02 Thread Dmitry Baryshkov
Check that the plane pitch doesn't overflow the maximum pitch size allowed by the hardware. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 2 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 6 +- 2 files changed, 7 insertions

[PATCH v2 6/9] drm/msm/dpu: drop call to _dpu_crtc_setup_lm_bounds from atomic_begin

2024-06-02 Thread Dmitry Baryshkov
The dpu_crtc_atomic_check() already calls _dpu_crtc_setup_lm_bounds(). There is no need to call it from dpu_crtc_atomic_begin(). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1

[PATCH v2 4/9] drm/msm/dpu: move dpu_format_populate_plane_sizes to atomic_check

2024-06-02 Thread Dmitry Baryshkov
Move a call to dpu_format_populate_plane_sizes() to the atomic_check step, so that any issues with the FB layout can be reported as early as possible. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions

[PATCH v2 3/9] drm/msm/dpu: split dpu_format_populate_layout

2024-06-02 Thread Dmitry Baryshkov
Split dpu_format_populate_layout() into addess-related and pitch/format-related parts. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c| 8 +++- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c| 45

[PATCH v2 2/9] drm/msm/dpu: drop dpu_format_populate_layout from dpu_plane_sspp_atomic_update

2024-06-02 Thread Dmitry Baryshkov
The dpu_plane_prepare_fb() already calls dpu_format_populate_layout(). Store the generated layour in the plane state and drop this call from dpu_plane_sspp_update(). Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 19

[PATCH v2 1/9] drm/msm/dpu: drop dpu_format_check_modified_format

2024-06-02 Thread Dmitry Baryshkov
The msm_kms_funcs::check_modified_format() callback is not used by the driver. Drop it completely. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 43 - drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h | 16 --- drivers/gpu/drm

[PATCH v2 0/9] drm/msm/dpu: be more friendly to X.org

2024-06-02 Thread Dmitry Baryshkov
-off-by: Dmitry Baryshkov --- Changes in v2: - Added dpu_crtc_valid() to verify that 2*lm_width limit is enforced (Abhinav) - Link to v1: https://lore.kernel.org/r/20240319-dpu-mode-config-width-v1-0-d0fe6bf81...@linaro.org --- Dmitry Baryshkov (9): drm/msm/dpu: drop

[PATCH v3 09/12] drm/imx: add internal bridge handling display-timings DT node

2024-06-02 Thread Dmitry Baryshkov
-display drivers. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/imx/Kconfig | 10 +++ drivers/gpu/drm/bridge/imx/Makefile| 1 + drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c | 85 ++ include/drm/bridge/imx.h | 13

[PATCH v3 05/12] drm/imx: ldb: drop custom EDID support

2024-06-02 Thread Dmitry Baryshkov
Bindings for the imx-ldb never allowed specifying the EDID in DT. None of the existing DT files use it. Drop it now in favour of using debugfs overrides or the drm.edid_firmware support. Reviewed-by: Philipp Zabel Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/imx/ipuv3/imx-ldb.c | 29

[PATCH v3 11/12] drm/imx: parallel-display: switch to imx_legacy_bridge / drm_bridge_connector

2024-06-02 Thread Dmitry Baryshkov
at the same time. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/imx/ipuv3/parallel-display.c | 100 ++- 1 file changed, 20 insertions(+), 80 deletions(-) diff --git a/drivers/gpu/drm/imx/ipuv3/parallel-display.c b/drivers/gpu/drm/imx/ipuv3/parallel-display.c index

[PATCH v3 10/12] drm/imx: ldb: switch to imx_legacy_bridge / drm_bridge_connector

2024-06-02 Thread Dmitry Baryshkov
at the same time. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/imx/ipuv3/Kconfig | 1 + drivers/gpu/drm/imx/ipuv3/imx-ldb.c | 103 ++-- 2 files changed, 30 insertions(+), 74 deletions(-) diff --git a/drivers/gpu/drm/imx/ipuv3/Kconfig b/drivers/gpu/drm/imx/ipuv3

[PATCH v3 12/12] drm/imx: move imx_drm_connector_destroy to imx-tve

2024-06-02 Thread Dmitry Baryshkov
The imx-tve driver is the only remaining user of imx_drm_connector_destroy(). Move the function to imx-tve.c Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/imx/ipuv3/imx-drm-core.c | 7 --- drivers/gpu/drm/imx/ipuv3/imx-drm.h | 2 -- drivers/gpu/drm/imx/ipuv3/imx-tve.c | 8

[PATCH v3 08/12] drm/imx: parallel-display: switch to drm_panel_bridge

2024-06-02 Thread Dmitry Baryshkov
Defer panel handling to drm_panel_bridge, unifying codepaths for the panel and bridge cases. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/imx/ipuv3/Kconfig| 3 ++- drivers/gpu/drm/imx/ipuv3/parallel-display.c | 36 +++- 2 files changed, 10 insertions

[PATCH v3 04/12] drm/imx: parallel-display: drop edid override support

2024-06-02 Thread Dmitry Baryshkov
are to be provided as a part of the panel driver. Drop support for the edid property. Reviewed-by: Philipp Zabel Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/imx/ipuv3/parallel-display.c | 13 - 1 file changed, 13 deletions(-) diff --git a/drivers/gpu/drm/imx/ipuv3/parallel

[PATCH v3 07/12] drm/imx: ldb: switch to drm_panel_bridge

2024-06-02 Thread Dmitry Baryshkov
Defer panel handling to drm_panel_bridge, unifying codepaths for the panel and bridge cases. The MFD_SYSCON symbol is moved to select to prevent Kconfig symbol loops. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/imx/ipuv3/Kconfig | 6 +++-- drivers/gpu/drm/imx/ipuv3/imx-ldb.c | 44

[PATCH v3 06/12] drm/imx: ldb: drop custom DDC bus support

2024-06-02 Thread Dmitry Baryshkov
None of the boards ever supported by the upstream kernel used the custom DDC bus support with the LDB connector. If a need arises to do so, one should use panel-simple and its DDC bus code. Drop ddc-i2c-bus support from the imx-ldb driver. Reviewed-by: Philipp Zabel Signed-off-by: Dmitry

[PATCH v3 00/12] drm/imx/ipuv3: switch LDB and parallel-display driver to use drm_bridge_connector

2024-06-02 Thread Dmitry Baryshkov
://lore.kernel.org/all/20240602-imx-sii902x-defconfig-v1-1-71a6c382b...@linaro.org/ Signed-off-by: Dmitry Baryshkov --- Changes in v3: - Notice (soft) dependencies in the cover letter (Chris) - Select DRM_BRIDGE instead of depending on it (Philipp) - Dropped unused selection of DRM_PANEL (Philipp) - Added

[PATCH v3 03/12] drm/imx: cleanup the imx-drm header

2024-06-02 Thread Dmitry Baryshkov
Drop unused defines and obsolete prototypes from the imx-drm.h header. Reviewed-by: Philipp Zabel Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/imx/ipuv3/imx-drm.h | 12 1 file changed, 12 deletions(-) diff --git a/drivers/gpu/drm/imx/ipuv3/imx-drm.h b/drivers/gpu/drm/imx

[PATCH v3 02/12] dt-bindings: display: imx/ldb: drop ddc-i2c-bus property

2024-06-02 Thread Dmitry Baryshkov
The in-kernel DT files do not use ddc-i2c-bus property with the iMX LVDS Display Bridge. If in future a need arises to support such usecase, the panel-simple should be used, which is able to handle the DDC bus. Acked-by: Rob Herring Signed-off-by: Dmitry Baryshkov --- Documentation/devicetree

[PATCH v3 01/12] dt-bindings: display: fsl-imx-drm: drop edid property support

2024-06-02 Thread Dmitry Baryshkov
are to be provided as a part of the panel driver. Drop the edid property from the fsl-imx-drm bindings. Acked-by: Rob Herring Signed-off-by: Dmitry Baryshkov --- Documentation/devicetree/bindings/display/imx/fsl-imx-drm.txt | 2 -- 1 file changed, 2 deletions(-) diff --git a/Documentation

Re: [PATCH 00/14] Add initial support for the Rockchip RK3588 HDMI TX Controller

2024-06-01 Thread Dmitry Baryshkov
On Sat, Jun 01, 2024 at 04:12:22PM +0300, Cristian Ciocaltea wrote: > The RK3588 SoC family integrates a Quad-Pixel (QP) variant of the > Synopsys DesignWare HDMI TX controller used in the previous SoCs. > > It is HDMI 2.1 compliant and supports the following features, among > others: > > *

Re: [PATCH v2 1/4] dt-bindings: display: panel: Add KD101NE3-40TI support

2024-06-01 Thread Dmitry Baryshkov
On Sat, Jun 01, 2024 at 04:45:25PM +0800, Zhaoxiong Lv wrote: > Create a new dt-scheam for the kd101ne3-40ti. > The bias IC of this kindisplay-kd101ne3 panel is placed > on the panel side, so when the panel is powered on, > there is no need to control AVDD and AVEE in the driver. > >

Re: [PATCH v2 4/4] drm/panel: starry: add new panel driver

2024-06-01 Thread Dmitry Baryshkov
On Sat, Jun 01, 2024 at 04:45:28PM +0800, Zhaoxiong Lv wrote: > This Starry panel has the same timing as the Kingdisplay panel, > so add starry configuration in the Kingdisplay driver. Do these two panels share the same driver IC? Programming sequences do not seem common, so it might be better to

Re: [PATCH v2 2/4] drm/panel: kd101ne3: add new panel driver

2024-06-01 Thread Dmitry Baryshkov
On Sat, Jun 01, 2024 at 04:45:26PM +0800, Zhaoxiong Lv wrote: > The bias IC of this kindisplay-kd101ne3 panel is placed > on the panel side, so when the panel is powered on, > there is no need to control AVDD and AVEE in the driver, > only 3.3v and reset are needed. > > Signed-off-by: Zhaoxiong

[PATCH v4 7/9] drm/msm/hdmi: get rid of hdmi_mode

2024-05-31 Thread Dmitry Baryshkov
Use connector->display_info.is_hdmi instead of manually using drm_detect_hdmi_monitor(). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi.c| 2 +- drivers/gpu/drm/msm/hdmi/hdmi.h| 2 -- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 11 --- 3 files chan

[PATCH v4 6/9] drm/msm/hdmi: make use of the drm_connector_hdmi framework

2024-05-31 Thread Dmitry Baryshkov
Setup the HDMI connector on the MSM HDMI outputs. Make use of atomic_check hook and of the provided Infoframe infrastructure. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/Kconfig| 2 + drivers/gpu/drm/msm/hdmi/hdmi.c| 44 ++--- drivers/gpu/drm/msm/hdmi

[PATCH v4 5/9] drm/msm/hdmi: turn mode_set into atomic_enable

2024-05-31 Thread Dmitry Baryshkov
The mode_set callback is deprecated, it doesn't get the drm_bridge_state, just mode-related argumetns. Turn it into the atomic_enable callback as suggested by the documentation. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 33 ++--- 1

[PATCH v4 0/9] drm/msm: make use of the HDMI connector infrastructure

2024-05-31 Thread Dmitry Baryshkov
, I'll finish MSM HDMI bridge conversion (reworking the Audio Infoframe code). Other bridges can follow the same approach (we have lt9611 / lt9611uxc / adv7511 on Qualcomm hardware). [1] https://patchwork.freedesktop.org/series/122421/ Signed-off-by: Dmitry Baryshkov --- Changes in v4: - Reworked

[PATCH v4 9/9] drm/msm/hdmi: also send the SPD and HDMI Vendor Specific InfoFrames

2024-05-31 Thread Dmitry Baryshkov
requirements. The msm-4.4 kernel uses GENERIC0 to send HDR InfoFrame which we do not at this point anyway. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 93 ++ 1 file changed, 93 insertions(+) diff --git a/drivers/gpu/drm/msm/hdmi

[PATCH v4 8/9] drm/msm/hdmi: update HDMI_GEN_PKT_CTRL_GENERIC0_UPDATE definition

2024-05-31 Thread Dmitry Baryshkov
The GENERIC0_UPDATE field is a single bit. Redefine it as boolean to simplify its usage in the driver. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/registers/display/hdmi.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/registers/display

[PATCH v4 2/9] drm/bridge-connector: switch to using drmm allocations

2024-05-31 Thread Dmitry Baryshkov
Turn drm_bridge_connector to using drmm_kzalloc() and drmm_connector_init() and drop the custom destroy function. The drm_connector_unregister() and fwnode_handle_put() are already handled by the drm_connector_cleanup() and so are safe to be dropped. Acked-by: Maxime Ripard Signed-off-by: Dmitry

[PATCH v4 4/9] drm/msm/hdmi: switch to atomic bridge callbacks

2024-05-31 Thread Dmitry Baryshkov
Change MSM HDMI bridge to use atomic_* callbacks in preparation to enablign the HDMI connector support. Acked-by: Maxime Ripard Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH v4 3/9] drm/bridge-connector: implement glue code for HDMI connector

2024-05-31 Thread Dmitry Baryshkov
implementation. Note, to simplify implementation, there can be only one bridge in a chain that sets DRM_BRIDGE_OP_HDMI. Setting more than one is considered an error. This limitation can be lifted later, if the need arises. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/drm_bridge_connector.c | 96

[PATCH v4 1/9] drm/connector: hdmi: accept NULL for Audio Infoframe

2024-05-31 Thread Dmitry Baryshkov
Allow passing NULL as audio infoframe as a way to disable Audio Infoframe generation. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_hdmi_state_helper.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/display

Re: [PATCH RESEND] drm: panel-orientation-quirks: Add quirk for Aya Neo KUN

2024-05-31 Thread Dmitry Baryshkov
; --- > drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++ > 1 file changed, 6 insertions(+) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v4 05/13] drm/msm/dpu: move scaling limitations out of the hw_catalog

2024-05-31 Thread Dmitry Baryshkov
On Fri, May 31, 2024 at 12:20:24PM -0700, Abhinav Kumar wrote: > > > On 5/31/2024 1:16 AM, Dmitry Baryshkov wrote: > > On Fri, 31 May 2024 at 04:02, Abhinav Kumar > > wrote: > > > > > > > > > > > > On 3/13/2024 5:02 PM, Dmitry

Re: [PATCH v3 0/3] drm/panel-edp: remove several legacy compatibles used by the driver

2024-05-31 Thread Dmitry Baryshkov
On Fri, May 31, 2024 at 10:18:07AM -0600, Jeffrey Hugo wrote: > On 5/30/2024 5:12 PM, Dmitry Baryshkov wrote: > > There are two ways to describe an eDP panel in device tree. The > > recommended way is to add a device on the AUX bus, ideally using the > > edp-panel compa

Re: [PATCH 06/20] drm/msm: Use iommu_paging_domain_alloc()

2024-05-31 Thread Dmitry Baryshkov
On Fri, May 31, 2024 at 09:57:54AM +0800, Baolu Lu wrote: > On 5/30/24 3:58 PM, Dmitry Baryshkov wrote: > > On Thu, 30 May 2024 at 04:59, Baolu Lu wrote: > > > On 5/29/24 4:21 PM, Dmitry Baryshkov wrote: > > > > On Wed, May 29, 2024 at 01:32:36PM +0800, Lu Bao

Re: [PATCH] docs: document python version used for compilation

2024-05-31 Thread Dmitry Baryshkov
On Fri, May 31, 2024 at 09:33:12AM +0200, Geert Uytterhoeven wrote: > Hi Thierry, > > On Thu, May 30, 2024 at 7:07 PM Thierry Reding > wrote: > > Alternatively, maybe Kconfig could be taught about build dependencies? > > git grep "depends on \$(" -- "*Kconf*" > I'd rather not do that. The

Re: [PATCH v4 05/13] drm/msm/dpu: move scaling limitations out of the hw_catalog

2024-05-31 Thread Dmitry Baryshkov
On Fri, 31 May 2024 at 04:02, Abhinav Kumar wrote: > > > > On 3/13/2024 5:02 PM, Dmitry Baryshkov wrote: > > Max upscale / downscale factors are constant between platforms. In > > preparation to adding support for virtual planes and allocating SSPP > > blocks on d

Re: [PATCH v4 1/2] drm/bridge: sii902x: Fix mode_valid hook

2024-05-30 Thread Dmitry Baryshkov
/gpu/drm/bridge/sii902x.c | 32 +++- > 1 file changed, 23 insertions(+), 9 deletions(-) > Reviewed-by: Dmitry Baryshkov Chris, you might be interested in testing this series. -- With best wishes Dmitry

Re: [PATCH v2 8/9] drm/atomic-helper: Re-order bridge chain pre-enable and post-disable

2024-05-30 Thread Dmitry Baryshkov
On Thu, May 30, 2024 at 03:06:20PM +0530, Aradhya Bhatia wrote: > Move the bridge pre_enable call before crtc enable, and the bridge > post_disable call after the crtc disable. > > The sequence of enable after this patch will look like: > > bridge[n]_pre_enable > ... >

Re: [PATCH v3 0/3] drm/panel-edp: remove several legacy compatibles used by the driver

2024-05-30 Thread Dmitry Baryshkov
On Fri, 31 May 2024 at 02:24, Doug Anderson wrote: > > Hi, > > On Thu, May 30, 2024 at 4:13 PM Dmitry Baryshkov > wrote: > > > > There are two ways to describe an eDP panel in device tree. The > > recommended way is to add a device on the AUX bus, ideally u

Re: [PATCH v2 7/9] drm/bridge: cdns-dsi: Support atomic bridge APIs

2024-05-30 Thread Dmitry Baryshkov
rmat negotiation hook. > > Signed-off-by: Aradhya Bhatia > --- > .../gpu/drm/bridge/cadence/cdns-dsi-core.c| 70 --- > 1 file changed, 62 insertions(+), 8 deletions(-) Reviewed-by: Dmitry Baryshkov Minor nit below. > > @@ -915,13 +920,62 @@ sta

[PATCH v3 3/3] drm/panel-edp: drop several legacy panels

2024-05-30 Thread Dmitry Baryshkov
he AUX bus. Reviewed-by: Douglas Anderson Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/panel/panel-edp.c | 173 ++ 1 file changed, 7 insertions(+), 166 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-e

[PATCH v3 2/3] dt-bindings: display: panel-simple: drop several eDP panels

2024-05-30 Thread Dmitry Baryshkov
Reviewed-by: Douglas Anderson Signed-off-by: Dmitry Baryshkov --- .../devicetree/bindings/display/panel/panel-simple.yaml| 10 -- 1 file changed, 10 deletions(-) diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindin

[PATCH v3 1/3] drm/panel-edp: add fat warning against adding new panel compatibles

2024-05-30 Thread Dmitry Baryshkov
e retained for backwards compatibility. Suggested-by: Doug Anderson Reviewed-by: Neil Armstrong Reviewed-by: Douglas Anderson Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/panel/panel-edp.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/p

[PATCH v3 0/3] drm/panel-edp: remove several legacy compatibles used by the driver

2024-05-30 Thread Dmitry Baryshkov
never used by the devices supported by the upstream kernel and are a subject to possible removal: - lg,lp097qx1-spa1 - samsung,lsn122dl01-c01 - sharp,ld-d5116z01b I'm considering dropping them later, unless there is a good reason not to do so. Signed-off-by: Dmitry Baryshkov --- Changes in v3

  1   2   3   4   5   6   7   8   9   10   >