[PATCH] drm/bridge: dw-hdmi: fix trivial typo in comment

2024-01-27 Thread Eugen Hristev
s/Initializateion/Initialization Fixes: 9aaf880ed4ee ("imx-drm: Add mx6 hdmi transmitter support") Signed-off-by: Eugen Hristev --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c

Re: [PATCH v4 1/2] drm/mediatek: fix kernel oops if no crtc is found

2023-09-21 Thread Eugen Hristev
river for MT8195") Signed-off-by: Michael Walle Reviewed-by: Nícolas F. R. A. Prado Tested-by: Nícolas F. R. A. Prado Reviewed-by: AngeloGioacchino Del Regno I tried this patch as well, hit the crash during my tests. I also reviewed your changes Tested-by: Eugen Hristev Reviewed-by: Eug

Re: [PATCH RESEND v4 2/2] drm/mediatek: Fix iommu fault during crtc enabling

2023-08-08 Thread Eugen Hristev
Hi Jason, On 8/7/23 04:51, Jason-JH.Lin wrote: The plane_state of drm_atomic_state is not sync to the mtk_plane_state stored in mtk_crtc during crtc enabling. So we need to update the mtk_plane_state stored in mtk_crtc by the drm_atomic_state carried from mtk_drm_crtc_atomic_enable(). While

Re: [v3] media: mediatek: vcodec: fix AV1 decoding on MT8188

2023-08-04 Thread Eugen Hristev
Hi Xiaoyong, On 8/3/23 14:10, Xiaoyong Lu wrote: Fix AV1 decoding failure when the iova is 36bit. Before this fix, the decoder was accessing incorrect addresses with 36bit iova tile buffer, leading to iommu faults. Fixes: 2f5d0aef37c6 ("media: mediatek: vcodec: support stateless AV1 decoder")

Re: [PATCH v8 4/8] drm/mediatek: Add encoder_index function to mtk_ddp_comp_funcs

2023-08-03 Thread Eugen Hristev
On 8/2/23 17:47, Jason-JH.Lin wrote: 1. Add encoder_index function to mtk_ddp_comp_funcs to support dynamic connector selection for some ddp_comp who has encoder_index. 2. Add mtk_ddp_comp_encoder_index_set function to set encoder_index to each comp. Usually a commit that does two things in a

Re: [PATCH v8 3/8] drm/mediatek: Fix using wrong drm private data to bind mediatek-drm

2023-08-03 Thread Eugen Hristev
On 8/2/23 17:47, Jason-JH.Lin wrote: In mtk_drm_kms_init(), each element in all_drm_priv should has one display path private data only, such as: all_drm_priv[CRTC_MAIN] should has main_path data only all_drm_priv[CRTC_EXT] should has ext_path data only all_drm_priv[CRTC_THIRD] should has

Re: [PATCH v8 2/8] drm/mediatevk: Add crtc path enum for all_drm_priv array

2023-08-03 Thread Eugen Hristev
On 8/2/23 17:47, Jason-JH.Lin wrote: Add mtk_drm_crtc_path enum for eatch display path. Typo: each Instead of using array index of all_drm_priv in mtk_drm_kms_init(), mtk_drm_crtc_path enum can make more readable. can make *code* more readable ? Signed-off-by: Jason-JH.Lin ---

Re: [PATCH v7 2/4] drm/mediatek: Fix using wrong drm private data to bind mediatek-drm

2023-07-31 Thread Eugen Hristev
On 7/31/23 11:21, Jason-JH Lin (林睿祥) wrote: Hi Eugen, Thanks for the reviews. On Fri, 2023-07-28 at 11:47 +0300, Eugen Hristev wrote: Hi, On 7/27/23 19:41, Jason-JH.Lin wrote: Add checking the length of each data path before assigning drm private data into all_drm_priv array. Fixes

Re: [PATCH v7 2/4] drm/mediatek: Fix using wrong drm private data to bind mediatek-drm

2023-07-28 Thread Eugen Hristev
Hi, On 7/27/23 19:41, Jason-JH.Lin wrote: Add checking the length of each data path before assigning drm private data into all_drm_priv array. Fixes: 1ef7ed48356c ("drm/mediatek: Modify mediatek-drm for mt8195 multi mmsys support") Signed-off-by: Jason-JH.Lin ---