Re: [PATCH V2 2/2] drm/bridge: samsung-dsim: Fix porch calcalcuation rounding

2024-05-07 Thread Frieder Schrempf
n one lane. For certain >>> timings and lane configurations, the HFP may not be evenly divisible. >>> If the HFP is rounded down, it ends up being too small which can cause >>> some monitors to not sync properly. In these instances, adjust htotal >>> and hsync to

Re: sn65dsi83: dsi burst mode

2024-03-07 Thread Frieder Schrempf
On 07.03.24 09:09, Sean Nyekjaer wrote: > Hi, > > We are using the stm32mp1 together with the sn65dsi83 bridge. > The ti,sn65dsi83 driver is (hard) enabling MIPI_DSI_MODE_VIDEO_BURST, then > the st,stm32-dsi driver is adding +20% to the clock speed. > > That means our LVDS is +20% higher than

Re: [PATCH v2 1/2] drm/bridge: Fix improper bridge init order with pre_enable_prev_first

2024-02-29 Thread Frieder Schrempf
Hi, On 28.03.23 19:07, Jagan Teki wrote: > For a given bridge pipeline if any bridge sets pre_enable_prev_first > flag then the pre_enable for the previous bridge will be called before > pre_enable of this bridge and opposite is done for post_disable. > > These are the potential bridge flags to

Re: [PATCH 1/1] drm/bridge: ti-sn65dsi83: Fix enable error path

2024-02-29 Thread Frieder Schrempf
On 29.02.24 10:47, Luca Ceresoli wrote: > Hello Alexander, > > On Wed, 28 Feb 2024 09:15:46 +0100 > Alexander Stein wrote: > > > [...] > >> Oh I mistook this DSI-LVDS bridge with the DSI-DP bridge on a different >> board, my bad. I hope I can provide some insights. My platform is >>

Re: [PATCH] drm: bridge: samsung-dsim: Don't use FORCE_STOP_STATE

2024-01-29 Thread Frieder Schrempf
On 29.01.24 10:20, Frieder Schrempf wrote: > On 26.01.24 19:28, Dave Airlie wrote: >> Just FYI this conflictted pretty heavily with drm-misc-next changes in >> the same area, someone should check drm-tip has the correct >> resolution, I'm not really sure what is definitely

Re: [PATCH] drm: bridge: samsung-dsim: Don't use FORCE_STOP_STATE

2024-01-29 Thread Frieder Schrempf
On 26.01.24 19:28, Dave Airlie wrote: > Just FYI this conflictted pretty heavily with drm-misc-next changes in > the same area, someone should check drm-tip has the correct > resolution, I'm not really sure what is definitely should be. > > Dave. Thanks! I took a quick look at what is now in

Re: [PATCH 2/2] drm/bridge: samsung-dsim: Fix porch calcalcuation rounding

2024-01-29 Thread Frieder Schrempf
, the HFP may not be evenly divisible. >> If the HFP is rounded down, it ends up being too small which can cause >> some monitors to not sync properly. In these instances, adjust htotal >> and hsync to round the HFP up, and recalculate the htotal. >> >> Tested-by: Fri

Re: [PATCH] drm: bridge: samsung-dsim: Don't use FORCE_STOP_STATE

2023-12-18 Thread Frieder Schrempf
On 01.12.23 10:04, Michael Walle wrote: >> The FORCE_STOP_STATE bit is unsuitable to force the DSI link into LP-11 >> mode. It seems the bridge internally queues DSI packets and when the >> FORCE_STOP_STATE bit is cleared, they are sent in close succession >> without any useful timing (this also

Re: [PATCH 1/2] drm/bridge: samsung-dsim: Set P divider based on min/max of fin pll

2023-12-12 Thread Frieder Schrempf
is is literally one of the things I came up with. So I'm happy to provide: Reviewed-by: Frieder Schrempf Tested-by: Frieder Schrempf Regarding the P divider, I'm also wondering if there is an upper limit for the p-value (not for the resulting fin_pll) that we should take into account, too. The proble

Re: [PATCH v5 04/10] drm: bridge: samsung-dsim: complete the CLKLANE_STOP setting

2023-12-07 Thread Frieder Schrempf
On 07.12.23 15:16, Dario Binacchi wrote: > The patch completes the setting of CLKLANE_STOP for the imx8mn and imx8mp > platforms (i. e. not exynos). This also affects i.MX8MM, so better just mention i.MX in general in the commit message. > > Co-developed-by: Michael Trimarchi > Signed-off-by:

Re: [PATCH] drm/bridge: samsung-dsim: check the return value only if necessary

2023-12-07 Thread Frieder Schrempf
On 07.12.23 17:10, Dario Binacchi wrote: > It was useless to check again the "ret" variable if the function > register_host() was not called. > > Signed-off-by: Dario Binacchi Reviewed-by: Frieder Schrempf > --- > > drivers/gpu/drm/bridge/samsung-dsim.c |

Re: [PATCH v2 1/2] drm: bridge: adv7511: fix reading edid segments

2023-11-30 Thread Frieder Schrempf
On 30.11.23 16:57, Frieder Schrempf wrote: > Hi Emil, > > On 27.10.23 14:22, Emil Abildgaard Svendsen wrote: >> [Sie erhalten nicht häufig E-Mails von e...@bang-olufsen.dk. Weitere >> Informationen, warum dies wichtig ist, finden Sie unter >> https://aka.ms/Lea

Re: [PATCH v2 1/2] drm: bridge: adv7511: fix reading edid segments

2023-11-30 Thread Frieder Schrempf
Hi Emil, On 27.10.23 14:22, Emil Abildgaard Svendsen wrote: > [Sie erhalten nicht häufig E-Mails von e...@bang-olufsen.dk. Weitere > Informationen, warum dies wichtig ist, finden Sie unter > https://aka.ms/LearnAboutSenderIdentification ] > > Currently reading EDID only works because usually

Re: [PATCH] drm: bridge: samsung-dsim: Don't use FORCE_STOP_STATE

2023-11-14 Thread Frieder Schrempf
he changes back then. Instead, we had an automated test setup to do cyclic on/off switching for the display and check for a black screen using a sensor. It is quite a hassle to set up and I'm currently not planning to spend that much effort to verify this change again. Anyway, I currently don't see any reasons to not revert my changes. Your revert looks correct and seems to work fine as far as I can tell. Reviewed-by: Frieder Schrempf Thanks Frieder

Re: [PATCH] drm: bridge: adv7511: fix reading edid segments

2023-10-26 Thread Frieder Schrempf
On 26.10.23 13:30, Emil Abildgaard Svendsen wrote: > [Sie erhalten nicht häufig E-Mails von e...@bang-olufsen.dk. Weitere > Informationen, warum dies wichtig ist, finden Sie unter > https://aka.ms/LearnAboutSenderIdentification ] > > Currently reading EDID only works because usually only two

Re: [RFC] drm: bridge: samsung-dsim: Recalculate timings when rounding HFP up

2023-10-26 Thread Frieder Schrempf
the ADV7535 bridge and I don't see any change when trying the 30 different modes the monitor reports as supported. 18 of those work and 12 don't work. So at least there is no negative impact in this case. Tested-by: Frieder Schrempf # Kontron BL i.MX8MM with HDMI monitor Thanks Frieder

Re: [PATCH 0/5] drm/bridge: samsung-dsim: fix various modes with ADV7535 bridge

2023-09-07 Thread Frieder Schrempf
Hi Michael, On 06.09.23 11:56, Michael Tretter wrote: > Hi Frieder, > > On Wed, 06 Sep 2023 11:31:45 +0200, Frieder Schrempf wrote: >> On 04.09.23 16:02, Frieder Schrempf wrote: >>> On 28.08.23 17:59, Michael Tretter wrote: >>>> I tested the i.MX8M Nano EVK wi

Re: [PATCH 0/5] drm/bridge: samsung-dsim: fix various modes with ADV7535 bridge

2023-09-06 Thread Frieder Schrempf
On 04.09.23 16:02, Frieder Schrempf wrote: > Hi Michael, > > On 28.08.23 17:59, Michael Tretter wrote: >> I tested the i.MX8M Nano EVK with the NXP supplied MIPI-DSI adapter, >> which uses an ADV7535 MIPI-DSI to HDMI converter. I found that a few >> modes were wo

Re: [PATCH 0/5] drm/bridge: samsung-dsim: fix various modes with ADV7535 bridge

2023-09-04 Thread Frieder Schrempf
s. Maybe there is still an error in the > calculation of the porches and someone at NXP can chime in. Thanks for working on this! We tested these patches with our Kontron BL i.MX8MM board and a "10.1inch HDMI LCD (E)" display from Waveshare [1]. Without this series we don't get

Re: [PATCH v2 4/4] drm/bridge: imx: add driver for HDMI TX Parallel Video Interface

2023-07-25 Thread Frieder Schrempf
e powered up and told about the polarity of the video > sync signals to act in bypass mode. > > Signed-off-by: Lucas Stach > Tested-by: Marek Vasut I tested this on our Kontron BL i.MX8MP board. Feel free to add: Tested-by: Frieder Schrempf Lucas, any chance that you can revive this

Re: [PATCH v2 2/4] drm/bridge: imx: add bridge wrapper driver for i.MX8MP DWC HDMI

2023-07-25 Thread Frieder Schrempf
arek Vasut I tested this on our Kontron BL i.MX8MP board. Feel free to add: Tested-by: Frieder Schrempf

[PATCH v2] drm: bridge: samsung-dsim: Fix init during host transfer

2023-07-24 Thread Frieder Schrempf
From: Frieder Schrempf In case the downstream bridge or panel uses DSI transfers before the DSI host was actually initialized through samsung_dsim_atomic_enable() which clears the stop state (LP11) mode, all transfers will fail. This happens with downstream bridges that are controlled by DSI

[PATCH] drm: bridge: samsung-dsim: Fix init during host transfer

2023-07-24 Thread Frieder Schrempf
From: Frieder Schrempf In case the downstream bridge or panel uses DSI transfers before the DSI host was actually initialized through samsung_dsim_atomic_enable() which clears the stop state (LP11) mode, all transfers will fail. This happens with downstream bridges that are controlled by DSI

Re: [PATCH v4] drm: adv7511: Fix low refresh rate register for ADV7533/5

2023-07-20 Thread Frieder Schrempf
: adv7533: Initial support for ADV7533") > Reviewed-by: Robert Foss > Reviewed-by: Nuno Sa > Signed-off-by: Bogdan Togorean > Signed-off-by: Alexandru Ardelean Reviewed-by: Frieder Schrempf

Re: [PATCH v2 1/2] drm: bridge: samsung-dsim: Fix i.MX8M enable flow to meet spec

2023-07-20 Thread Frieder Schrempf
On 19.07.23 18:34, Tim Harvey wrote: > On Wed, Jul 19, 2023 at 12:05 AM Frieder Schrempf > wrote: >> >> Hi Tim, >> >> On 19.07.23 01:03, Tim Harvey wrote: >>> On Thu, Jul 13, 2023 at 3:01 AM Frieder Schrempf >>> wrote: >>>> >

Re: [PATCH v2 1/2] drm: bridge: samsung-dsim: Fix i.MX8M enable flow to meet spec

2023-07-19 Thread Frieder Schrempf
Hi Tim, On 19.07.23 01:03, Tim Harvey wrote: > On Thu, Jul 13, 2023 at 3:01 AM Frieder Schrempf > wrote: >> >> Hi Tim, >> >> On 13.07.23 09:18, Frieder Schrempf wrote: >>> Hi Tim, >>> >>> On 13.07.23 00:34, Tim Harvey wrote: &g

Re: [PATCH 1/1] drm/bridge: Fix handling of bridges with pre_enable_prev_first flag

2023-07-17 Thread Frieder Schrempf
On 14.07.23 19:16, Dave Stevenson wrote: > Hi Frieder > > On Mon, 10 Jul 2023 at 08:46, Frieder Schrempf > wrote: >> >> On 07.07.23 21:00, Vladimir Lypak wrote: >>> [Sie erhalten nicht häufig E-Mails von vladimir.ly...@gmail.com. Weitere >>> Informa

Re: [PATCH v2 1/2] drm: bridge: samsung-dsim: Fix i.MX8M enable flow to meet spec

2023-07-13 Thread Frieder Schrempf
Hi Tim, On 13.07.23 09:18, Frieder Schrempf wrote: > Hi Tim, > > On 13.07.23 00:34, Tim Harvey wrote: >> On Wed, May 3, 2023 at 9:33 AM Frieder Schrempf wrote: >>> >>> From: Frieder Schrempf >>> >>> According to the documentation [1] th

Re: [PATCH v2 1/2] drm: bridge: samsung-dsim: Fix i.MX8M enable flow to meet spec

2023-07-13 Thread Frieder Schrempf
Hi Tim, On 13.07.23 00:34, Tim Harvey wrote: > On Wed, May 3, 2023 at 9:33 AM Frieder Schrempf wrote: >> >> From: Frieder Schrempf >> >> According to the documentation [1] the proper enable flow is: >> >> 1. Enable DSI link and keep data lanes in LP-1

Re: [PATCH 1/1] drm/bridge: Fix handling of bridges with pre_enable_prev_first flag

2023-07-10 Thread Frieder Schrempf
On 07.07.23 21:00, Vladimir Lypak wrote: > [Sie erhalten nicht häufig E-Mails von vladimir.ly...@gmail.com. Weitere > Informationen, warum dies wichtig ist, finden Sie unter > https://aka.ms/LearnAboutSenderIdentification ] > > In function drm_atomic_bridge_chain_post_disable handling of >

Re: [PATCH v2 2/2] drm/bridge: ti-sn65dsi83: Fix enable/disable flow to meet spec

2023-05-22 Thread Frieder Schrempf
On 17.05.23 00:22, Fabio Estevam wrote: > On Thu, May 4, 2023 at 6:12 AM Alexander Stein > wrote: >> >> Am Mittwoch, 3. Mai 2023, 18:33:07 CEST schrieb Frieder Schrempf: >>> From: Frieder Schrempf >>> >>> The datasheet describes the following initiali

[PATCH v2 2/2] drm/bridge: ti-sn65dsi83: Fix enable/disable flow to meet spec

2023-05-03 Thread Frieder Schrempf
From: Frieder Schrempf The datasheet describes the following initialization flow including minimum delay times between each step: 1. DSI data lanes need to be in LP-11 and the clock lane in HS mode 2. toggle EN signal 3. initialize registers 4. enable PLL 5. soft reset 6. enable DSI stream 7

[PATCH v2 1/2] drm: bridge: samsung-dsim: Fix i.MX8M enable flow to meet spec

2023-05-03 Thread Frieder Schrempf
From: Frieder Schrempf According to the documentation [1] the proper enable flow is: 1. Enable DSI link and keep data lanes in LP-11 (stop state) 2. Disable stop state to bring data lanes into HS mode Currently we do this all at once within enable(), which doesn't allow to meet

[PATCH v2 0/2] Init flow fixes for Samsung DSIM and TI SN65DSI84

2023-05-03 Thread Frieder Schrempf
From: Frieder Schrempf This patchset contains a proposal to fix the initialization flow for the display pipeline used on our i.MX8MM Kontron boards: i.MX8MM LCDIF -> i.MX8MM DSIM -> TI SN65DSI84 -> 7" LVDS Panel Without these changes the display works most of the time, but fa

Re: [PATCH V3 7/7] drm: bridge: samsung-dsim: Let blanking calcuation work in non-burst mode

2023-05-03 Thread Frieder Schrempf
: Tested on Kontron BL i.MX8MM with SN65DSI84 and ADV7535 bridges. Tested-by: Frieder Schrempf Reviewed-by: Frieder Schrempf > --- > drivers/gpu/drm/bridge/samsung-dsim.c | 4 +++- > include/drm/bridge/samsung-dsim.h | 1 + > 2 files changed, 4 insertions(+), 1 deletion(-) > > d

Re: [PATCH V3 6/7] drm: bridge: samsung-dsim: Support non-burst mode

2023-05-03 Thread Frieder Schrempf
; device like an HDMI bridge chip. This should have no > impact for people using burst-mode and setting the burst > clock rate is still required for those users. > > Signed-off-by: Adam Ford > Tested-by: Chen-Yu Tsai Tested on Kontron BL i.MX8MM with SN65DSI84 and ADV7535 bridges. T

Re: [PATCH V3 5/7] drm: bridge: samsung-dsim: Dynamically configure DPHY timing

2023-05-03 Thread Frieder Schrempf
se: Tested on Kontron BL i.MX8MM with SN65DSI84 and ADV7535 bridges. Tested-by: Frieder Schrempf Reviewed-by: Frieder Schrempf > --- > drivers/gpu/drm/bridge/samsung-dsim.c | 79 +++ > include/drm/bridge/samsung-dsim.h | 1 + > 2 files changed, 70 i

Re: [PATCH V3 4/7] drm: bridge: samsung-dsim: Select GENERIC_PHY_MIPI_DPHY

2023-05-03 Thread Frieder Schrempf
Ford This fixes the build error which existed in v2! Tested on Kontron BL i.MX8MM with SN65DSI84 and ADV7535 bridges. Tested-by: Frieder Schrempf Reviewed-by: Frieder Schrempf

Re: [PATCH V3 3/7] drm: bridge: samsung-dsim: Fetch pll-clock-frequency automatically

2023-05-03 Thread Frieder Schrempf
> Tested-by: Chen-Yu Tsai Tested on Kontron BL i.MX8MM with SN65DSI84 and ADV7535 bridges. Tested-by: Frieder Schrempf Reviewed-by: Frieder Schrempf

Re: [PATCH V3 2/7] drm: bridge: samsung-dsim: Fix PMS Calculator on imx8m[mnp]

2023-05-03 Thread Frieder Schrempf
dsim: Add i.MX8M Mini/Nano > support") > Signed-off-by: Adam Ford > Reviewed-by: Lucas Stach > Tested-by: Chen-Yu Tsai Tested on Kontron BL i.MX8MM with SN65DSI84 and ADV7535 bridges. Tested-by: Frieder Schrempf Reviewed-by: Frieder Schrempf

Re: [PATCH V3 1/7] drm: bridge: samsung-dsim: fix blanking packet size calculation

2023-05-03 Thread Frieder Schrempf
Signed-off-by: Lucas Stach > Signed-off-by: Adam Ford > Tested-by: Chen-Yu Tsai Tested-by: Frieder Schrempf

Re: [RFC PATCH 3/3] drm: bridge: samsung-dsim: Remove init quirk for Exynos

2023-04-18 Thread Frieder Schrempf
On 18.04.23 15:12, Marek Szyprowski wrote: > On 18.04.2023 12:42, Frieder Schrempf wrote: >> From: Frieder Schrempf >> >> Assuming that with the init flow fixed to meet the documentation at >> [1] and the pre_enable_prev_first flag set in downstream bridge/panel >

[RFC PATCH 3/3] drm: bridge: samsung-dsim: Remove init quirk for Exynos

2023-04-18 Thread Frieder Schrempf
From: Frieder Schrempf Assuming that with the init flow fixed to meet the documentation at [1] and the pre_enable_prev_first flag set in downstream bridge/panel drivers which require it, we can use the default flow for Exynos as already done for i.MX8M. [1] https://docs.kernel.org/gpu/drm-kms

[RFC PATCH 2/3] drm/bridge: ti-sn65dsi83: Fix enable/disable flow to meet spec

2023-04-18 Thread Frieder Schrempf
From: Frieder Schrempf The datasheet describes the following initialization flow including minimum delay times between each step: 1. DSI data lanes need to be in LP-11 and the clock lane in HS mode 2. toggle EN signal 3. initialize registers 4. enable PLL 5. soft reset 6. enable DSI stream 7

[RFC PATCH 1/3] drm: bridge: samsung-dsim: Fix i.MX8M enable flow to meet spec

2023-04-18 Thread Frieder Schrempf
From: Frieder Schrempf According to the documentation [1] the proper enable flow is: 1. Enable DSI link and keep data lanes in LP-11 (stop state) 2. Disable stop state to bring data lanes into HS mode Currently we do this all at once within enable(), which doesn't allow to meet

[RFC PATCH 0/3] Init flow fixes for Samsung DSIM and TI SN65DSI84

2023-04-18 Thread Frieder Schrempf
From: Frieder Schrempf This patchset contains a proposal to fix the initialization flow for the display pipeline used on our i.MX8MM Kontron boards: i.MX8MM LCDIF -> i.MX8MM DSIM -> TI SN65DSI84 -> 7" LVDS Panel Without these changes the display works most of the time, but fa

Re: IMX8MM: assign panel to mipi_dsi in a device tree

2023-03-06 Thread Frieder Schrempf
On 05.03.23 20:45, Patrick Boettcher wrote: > [Sie erhalten nicht häufig E-Mails von patrick.boettc...@posteo.de. Weitere > Informationen, warum dies wichtig ist, finden Sie unter > https://aka.ms/LearnAboutSenderIdentification ] > > On Mon, 6 Mar 2023 00:05:03 +0530 > Jagan Teki wrote: > >>

Re: [PATCH v12 00/18] drm: Add Samsung MIPI DSIM bridge

2023-02-22 Thread Frieder Schrempf
On 17.02.23 19:22, Rasmus Villemoes wrote: > On 07/02/2023 10.09, Rasmus Villemoes wrote: > >> I managed to get the whole chain lcdif -> mipi -> bridge -> dp-connector >> to probe with these settings >> > [...] >> Now hotplug-detect doesn't work with the current sn65dsi86 driver, but >> that's a

Re: [PATCH v12 00/18] drm: Add Samsung MIPI DSIM bridge

2023-02-06 Thread Frieder Schrempf
On 03.02.23 13:29, Rasmus Villemoes wrote: > On 01/02/2023 23.00, Marek Vasut wrote: >> On 1/30/23 13:45, Rasmus Villemoes wrote: >>> On 27/01/2023 12.30, Marek Vasut wrote: On 1/27/23 12:04, Jagan Teki wrote: >>> >> Thanks, but that's exactly what I'm doing, and I don't see any >>

Re: [PATCH v12 00/18] drm: Add Samsung MIPI DSIM bridge

2023-02-01 Thread Frieder Schrempf
> Patch 0012 - 0013: component vs bridge > > Patch 0014 : DSIM bridge > > Patch 0015 - 0016: i.MX8M Mini/Nano > > Patch 0017 - 0018: i.MX8M Plus > > Changes for v12: > - collect RB from Marek V > - add te_irq_handler hook > - fix comments from Marek V > - u

Re: [PATCH v11 17/18] dt-bindings: display: exynos: dsim: Add NXP i.MX8M Plus support

2023-01-23 Thread Frieder Schrempf
On 23.01.23 13:23, Jagan Teki wrote: > Samsung MIPI DSIM bridge can also be found in i.MX8M Plus SoC. > > Add dt-bingings for it. > > Signed-off-by: Jagan Teki > --- > Changes for v11: > - collect ACK from Rob Tag is missing > Changes for v10, v9: > - none > >

Re: [PATCH v11 3/3] drm: exynos: dsi: Restore proper bridge chain order

2023-01-23 Thread Frieder Schrempf
On 20.01.23 20:42, Dave Stevenson wrote: > Hi Jagan > > On Fri, 20 Jan 2023 at 19:10, Jagan Teki wrote: >> >> Hi Dave, >> >> On Sat, Jan 21, 2023 at 12:26 AM Dave Stevenson >> wrote: >>> >>> Hi Jagan >>> >>> Responding due to Marek's comment on the "Add Samsung MIPI DSIM >>> bridge" series,

Re: [PATCH v10 18/18] drm: bridge: samsung-dsim: Add i.MX8M Plus support

2022-12-15 Thread Frieder Schrempf
th the i.MX8M Mini/Nano one. > > Signed-off-by: Marek Vasut > Signed-off-by: Jagan Teki Reviewed-by: Frieder Schrempf

Re: [PATCH v10 16/18] drm: bridge: samsung-dsim: Add i.MX8M Mini/Nano support

2022-12-15 Thread Frieder Schrempf
On 14.12.22 13:59, Jagan Teki wrote: > Samsung MIPI DSIM master can also be found in i.MX8M Mini/Nano SoC. > > Add compatible and associated driver_data for it. > > Reviewed-by: Laurent Pinchart > Signed-off-by: Marek Szyprowski > Signed-off-by: Jagan Teki Reviewed-by: Frieder Schrempf

Re: [PATCH v10 11/18] drm: exynos: dsi: Add atomic_get_input_bus_fmts

2022-12-15 Thread Frieder Schrempf
ats > > Tested-by: Marek Szyprowski > Signed-off-by: Jagan Teki Reviewed-by: Frieder Schrempf

Re: [PATCH v10 10/18] drm: exynos: dsi: Add input_bus_flags

2022-12-15 Thread Frieder Schrempf
l bus flags DE_LOW setting via input_bus_flags > for i.MX8M Mini/Nano platforms. > > Suggested-by: Marek Vasut > Signed-off-by: Jagan Teki Reviewed-by: Frieder Schrempf

Re: [PATCH v10 09/18] drm: exynos: dsi: Add atomic check

2022-12-15 Thread Frieder Schrempf
On 15.12.22 09:39, Frieder Schrempf wrote: > On 14.12.22 13:58, Jagan Teki wrote: >> Look like an explicit fixing up of mode_flags is required for DSIM IP >> present in i.MX8M Mini/Nano SoCs. >> >> At least the LCDIF + DSIM needs active low sync polarities in order >&

Re: [PATCH v10 09/18] drm: exynos: dsi: Add atomic check

2022-12-15 Thread Frieder Schrempf
e inverted HS/VS/DE signals, i.e. active LOW. > > No clear evidence about whether it can be documentation issues or > something, so added a comment FIXME for this and updated the active low > sync polarities using SAMSUNG_DSIM_TYPE_IMX8MM hw_type. > > Comments are suggested by Marek Vasut. > > Signed-off-by: Jagan Teki Reviewed-by: Frieder Schrempf

Re: [PATCH v10 08/18] drm: exynos: dsi: Handle proper host initialization

2022-12-15 Thread Frieder Schrempf
mon across all classes of DSI device drivers. > > The host init during pre_enable is conditional and not invoked for Exynos > as existing downstream drm panels and bridges in Exynos are expecting > the host initialization during DSI transfer. > > Signed-off-by: Jagan Teki &g

Re: [PATCH v10 07/18] drm: exynos: dsi: Introduce hw_type platform data

2022-12-15 Thread Frieder Schrempf
3250, > + DSIM_TYPE_EXYNOS4210, > + DSIM_TYPE_EXYNOS5410, > + DSIM_TYPE_EXYNOS5422, > + DSIM_TYPE_EXYNOS5433, > + The empty line looks a bit awkward to me. Otherwise: Reviewed-by: Frieder Schrempf > + DSIM_TYPE_COUNT, > +}; > + [...]

Re: [PATCH v10 05/18] drm: exynos: dsi: Mark PHY as optional

2022-12-15 Thread Frieder Schrempf
8M blk-ctrl driver. > > So, mark the phy get as optional. > > Reviewed-by: Marek Vasut > Signed-off-by: Jagan Teki Reviewed-by: Frieder Schrempf

Re: [PATCH v10 2/2] drm: exynos: dsi: Properly name HSA/HBP/HFP/HSE bits

2022-12-14 Thread Frieder Schrempf
wever the driver logic for handling HSE is based on the > MIPI_DSI_MODE_VIDEO_HSE flag itself. > > Cc: Nicolas Boichat > Reviewed-by: Marek Vasut > Signed-off-by: Jagan Teki Reviewed-by: Frieder Schrempf

Re: [PATCH v10 1/2] drm: exynos: dsi: Fix MIPI_DSI*_NO_* mode flags

2022-12-14 Thread Frieder Schrempf
orted-by: Sébastien Szymanski > Signed-off-by: Jagan Teki Reviewed-by: Frieder Schrempf

Re: [PATCH v11 3/3] drm: exynos: dsi: Restore proper bridge chain order

2022-12-14 Thread Frieder Schrempf
rek Szyprowski > Signed-off-by: Jagan Teki Reviewed-by: Frieder Schrempf

Re: [PATCH v11 2/3] drm/bridge: tc358764: Enable pre_enable_prev_first flag

2022-12-14 Thread Frieder Schrempf
revious bridge should be initialized > properly before the tc358764 bridge is powered up. > > Signed-off-by: Marek Szyprowski > Signed-off-by: Jagan Teki Reviewed-by: Frieder Schrempf

Re: [PATCH v11 1/3] drm: panel: Enable prepare_prev_first flag for samsung-s6e panels

2022-12-14 Thread Frieder Schrempf
samsung-s6e panels for this change. >     > This makes sure that the previous controller, likely to be a DSI > host controller should be initialized to LP-11 before the panel > is powered up. > > Signed-off-by: Marek Szyprowski > Signed-off-by: Jagan Teki Reviewed-by: Frieder Schrempf

Re: [PATCH 1/2] dt-bindings: drm/bridge: ti-sn65dsi83: Add enable delay property

2022-12-12 Thread Frieder Schrempf
On 12.12.22 10:23, Krzysztof Kozlowski wrote: > On 12/12/2022 10:09, Frieder Schrempf wrote: >>>>> This does seem like a hardware bug right there, can you double-check >>>>> this with the hardware engineer ? >>>> >>>> Yep, check

Re: [PATCH 1/2] dt-bindings: drm/bridge: ti-sn65dsi83: Add enable delay property

2022-12-12 Thread Frieder Schrempf
On 12.12.22 10:32, Laurent Pinchart wrote: > On Mon, Dec 12, 2022 at 10:09:45AM +0100, Frieder Schrempf wrote: >> On 09.12.22 15:49, Marek Vasut wrote: >>> On 12/9/22 14:38, Alexander Stein wrote: >>>> Am Freitag, 9. Dezember 2022, 13:43:02 CET schrieb Marek

Re: [PATCH 1/2] dt-bindings: drm/bridge: ti-sn65dsi83: Add enable delay property

2022-12-12 Thread Frieder Schrempf
On 09.12.22 15:49, Marek Vasut wrote: > On 12/9/22 14:38, Alexander Stein wrote: >> Am Freitag, 9. Dezember 2022, 13:43:02 CET schrieb Marek Vasut: >>> On 12/9/22 13:21, Alexander Stein wrote: Hi Marek, Am Freitag, 9. Dezember 2022, 13:02:10 CET schrieb Marek Vasut: > On 12/9/22

Re: [PATCH v8 06/14] drm: bridge: samsung-dsim: Handle proper DSI host initialization

2022-12-06 Thread Frieder Schrempf
On 05.12.22 16:37, Frieder Schrempf wrote: > Hi Dave, > > On 05.12.22 16:20, Dave Stevenson wrote: >> Hi Frieder >> >> On Mon, 5 Dec 2022 at 07:30, Frieder Schrempf >> wrote: >>> >>> On 02.12.22 15:55, Dave Stevenson wrote: >>>> Hi

Re: [PATCH v3 3/5] drm/bridge: Introduce pre_enable_prev_first to alter bridge init order

2022-12-05 Thread Frieder Schrempf
ing the function calls and capturing the DSI data signal and the SN65DSI84 enable GPIO (EN) on a scope. I've also gone through the code of this patch and it all makes sense to me. There is only one small nitpick (see below). Tested-by: Frieder Schrempf Reviewed-by: Frieder Schrempf Thanks Fri

Re: [PATCH v8 06/14] drm: bridge: samsung-dsim: Handle proper DSI host initialization

2022-12-05 Thread Frieder Schrempf
Hi Dave, On 05.12.22 16:20, Dave Stevenson wrote: > Hi Frieder > > On Mon, 5 Dec 2022 at 07:30, Frieder Schrempf > wrote: >> >> On 02.12.22 15:55, Dave Stevenson wrote: >>> Hi Marek >>> >>> On Fri, 2 Dec 2022 at 12:21, Marek Vasut wrote:

Re: [PATCH v8 00/14] drm: bridge: Add Samsung MIPI DSIM bridge

2022-12-05 Thread Frieder Schrempf
i SoM. > > Repo: > https://gitlab.com/openedev/kernel/-/commits/imx8mm-dsi-v8 > > Any inputs? > Jagan. I tested this on the Kontron DL i.MX8MM which uses a TI SN65DSI84 bridge and a Jenson 7" LVDS Display. Tested-by: Frieder Schrempf # Kontron DL i.MX8MM

Re: [PATCH v8 02/14] drm: exynos: dsi: Properly name HSA/HBP/HFP/HSE bits

2022-12-05 Thread Frieder Schrempf
On 10.11.22 19:38, Jagan Teki wrote: > HSA/HBP/HFP/HSE mode bits in Exynos DSI host specify a naming > conversion as 'disable mode bit' due to its bit definition, > 0 = Enable and 1 = Disable. > > Fix the naming convention of the mode bits. > > Signed-off-by: Jagan Teki > --- >

Re: [PATCH v8 01/14] drm: exynos: dsi: Fix MIPI_DSI*_NO_* mode flags

2022-12-05 Thread Frieder Schrempf
ptional). >>> >>> 0 = Disables transfer >>> 1 = Enables transfer >>> >>> In command mode, this bit is ignored. >> >> Okay. I'd suggest adding a comment in the code, it'd be so tempting to >> attempt to "fix" this as the if/or pattern looks different from the >> others. >> >> But it's up to you all. > > I agree. Clearly the discrepancy is confusing and leads to mistakes. +1 for a comment in the code that explains the misnamed bit. Otherwise: Reviewed-By: Frieder Schrempf

Re: [PATCH v8 06/14] drm: bridge: samsung-dsim: Handle proper DSI host initialization

2022-12-04 Thread Frieder Schrempf
On 02.12.22 15:55, Dave Stevenson wrote: > Hi Marek > > On Fri, 2 Dec 2022 at 12:21, Marek Vasut wrote: >> >> On 12/2/22 11:52, Marek Szyprowski wrote: >>> Hi, >>> >>> Sorry for delay, I was on a sick leave last 2 weeks. >>> >>> On 28.11.2022 15:43, Jagan Teki wrote: ,On Sat, Nov 26, 2022

Re: [PATCH] drm/bridge: ti-sn65dsi83: Fix delay after reset deassert to match spec

2022-11-24 Thread Frieder Schrempf
On 24.11.22 12:00, Alexander Stein wrote: > Am Dienstag, 22. November 2022, 09:12:18 CET schrieb Frieder Schrempf: >> From: Frieder Schrempf >> >> The datasheet specifies a delay of 10 milliseconds, but the current >> driver only waits for 1 ms. Fix this to m

[PATCH] drm/bridge: ti-sn65dsi83: Fix delay after reset deassert to match spec

2022-11-22 Thread Frieder Schrempf
From: Frieder Schrempf The datasheet specifies a delay of 10 milliseconds, but the current driver only waits for 1 ms. Fix this to make sure the initialization sequence meets the spec. Fixes: ceb515ba29ba ("drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver")

Re: [PATCH v8 09/14] drm: bridge: samsung-dsim: Add atomic_get_input_bus_fmts

2022-11-15 Thread Frieder Schrempf
On 15.11.22 09:09, Marek Szyprowski wrote: > Hi Jagan, > > On 14.11.2022 18:07, Jagan Teki wrote: >> On Mon, Nov 14, 2022 at 8:10 PM Marek Szyprowski >> wrote: >>> On 14.11.2022 11:57, Marek Szyprowski wrote: On 10.11.2022 19:38, Jagan Teki wrote: > Finding the right input bus format

Re: [PATCH v8 00/14] drm: bridge: Add Samsung MIPI DSIM bridge

2022-11-14 Thread Frieder Schrempf
Hi Jagan, On 10.11.22 19:38, Jagan Teki wrote: > This series supports common bridge support for Samsung MIPI DSIM > which is used in Exynos and i.MX8MM SoC's. > > The final bridge supports both the Exynos and i.MX8M Mini/Nano/Plus. > > Changes for v8: > * fixed comment lines > * fixed commit

Re: [PATCH v7 00/10] drm: bridge: Add Samsung MIPI DSIM bridge

2022-11-07 Thread Frieder Schrempf
; Patch 0009: document fsl,imx8mm-mipi-dsim > > Patch 0010: add i.MX8MM DSIM support > > Tested in Engicam i.Core MX8M Mini SoM. > > Repo: > https://gitlab.com/openedev/kernel/-/commits/imx8mm-dsi-v7 > > Any inputs? > Jagan. I tested this on the Kontron DL i.MX8MM which uses a TI SN65DSI84 bridge and a Jenson 7" LVDS Display. Thanks for your work, Jagan! Tested-by: Frieder Schrempf # Kontron DL i.MX8MM

Re: [PATCH v4 02/12] drm: bridge: Add Samsung DSIM bridge driver

2022-09-12 Thread Frieder Schrempf
Hi Jagan, Marek, Am 07.09.22 um 12:04 schrieb Marek Szyprowski: > Hi Jagan, > > On 06.09.2022 21:07, Jagan Teki wrote: >> On Mon, Sep 5, 2022 at 4:54 PM Marek Szyprowski >> wrote: >>> On 02.09.2022 12:47, Marek Szyprowski wrote: On 29.08.2022 20:40, Jagan Teki wrote: > Samsung MIPI

Re: [PATCH V2 0/3] DSI host and peripheral initialisation ordering

2022-07-06 Thread Frieder Schrempf
Hi Dave, Am 06.07.22 um 12:27 schrieb Dave Stevenson: > Hi Frieder. > > Apologies Lucas - I missed your response. > > On Wed, 6 Jul 2022 at 08:09, Frieder Schrempf > wrote: >> >> Am 10.06.22 um 09:52 schrieb Lucas Stach: >>> Hi, >>> >>>

Re: [PATCH V2 0/3] DSI host and peripheral initialisation ordering

2022-07-06 Thread Frieder Schrempf
Am 10.06.22 um 09:52 schrieb Lucas Stach: > Hi, > > Am Mittwoch, dem 11.05.2022 um 16:58 +0200 schrieb Marek Szyprowski: >> Hi Dave, >> >> On 05.04.2022 13:43, Dave Stevenson wrote: >>> On Fri, 18 Mar 2022 at 12:25, Dave Stevenson >>> wrote: On Fri, 4 Mar 2022 at 15:18, Dave Stevenson

Re: [PATCH][RESEND] drm/bridge: ti-sn65dsi83: Check link status register after enabling the bridge

2022-04-06 Thread Frieder Schrempf
Am 05.04.22 um 23:36 schrieb Marek Vasut: > On 4/5/22 17:24, Dave Stevenson wrote: > > Hi, > >> If we can initialise the DSI host before the bridge for the >> pre_enable, then all the configuration moves to the atomic_pre_enable >> and there should be no need to have the delay.

Re: [PATCH v6 0/6] drm: exynos: dsi: Convert drm bridge

2022-03-10 Thread Frieder Schrempf
Am 10.03.22 um 14:03 schrieb Frieder Schrempf: > Hi Jagan, > > Am 09.03.22 um 15:01 schrieb Jagan Teki: >> Hi Frieder, >> >> On Wed, Mar 9, 2022 at 6:54 PM Frieder Schrempf >> wrote: >>> >>> Hi Jagan, >>> >>> Am 03.03

Re: [PATCH v6 0/6] drm: exynos: dsi: Convert drm bridge

2022-03-10 Thread Frieder Schrempf
Hi Jagan, Am 09.03.22 um 15:01 schrieb Jagan Teki: > Hi Frieder, > > On Wed, Mar 9, 2022 at 6:54 PM Frieder Schrempf > wrote: >> >> Hi Jagan, >> >> Am 03.03.22 um 17:36 schrieb Jagan Teki: >>> Updated series about drm bridge conversion of exynos ds

Re: [PATCH v6 0/6] drm: exynos: dsi: Convert drm bridge

2022-03-09 Thread Frieder Schrempf
Hi Jagan, Am 03.03.22 um 17:36 schrieb Jagan Teki: > Updated series about drm bridge conversion of exynos dsi. > > Previous version can be accessible, here [1]. > > Patch 1: tc358764 panel_bridge API > > Patch 2: connector reset > > Patch 3: bridge attach in MIC > > Patch 4: panel_bridge API

Re: [RFC PATCH 2/9] drm: bridge: Add Samsung SEC MIPI DSIM bridge driver

2021-06-28 Thread Frieder Schrempf
Hi Jagan, On 24.06.21 10:30, Krzysztof Kozlowski wrote: > On 24/06/2021 04:48, Fabio Estevam wrote: >> Hi Jagan/Laurent, >> >> On Wed, Jun 23, 2021 at 7:23 PM Laurent Pinchart >> wrote: >> >>> Looking at the register set, it seems to match the Exynos 5433, >>> supported by

Re: [PATCH V4 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-05-10 Thread Frieder Schrempf
implemented, the > LVDS666 is not supported, but could be added if needed. > > Reviewed-by: Linus Walleij > Reviewed-by: Frieder Schrempf > Tested-by: Frieder Schrempf > Signed-off-by: Marek Vasut > Cc: Douglas Anderson > Cc: Jagan Teki > Cc: Laurent Pinchart > Cc: Linus W

Re: [PATCH V3 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-05-06 Thread Frieder Schrempf
On 06.05.21 17:46, Marek Vasut wrote: > On 5/6/21 5:38 PM, Frieder Schrempf wrote: > [...] >> Works on i.MX8MM with SN65DSI84 and a single link LVDS display (1024x600) >> and from my perspective everything else also looks good. Thanks for your >> work! >> >>

Re: [PATCH V3 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-05-06 Thread Frieder Schrempf
iver I get distorted colors. I need to use MEDIA_BUS_FMT_RGB888_1X24 to make it work, but this is not valid for LVDS. Again I don't think this driver is to blame as I can't see where it does anything wrong, but my experience here is very limited so I still want to mention it. Reviewed-

Re: [PATCH V2 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-04-29 Thread Frieder Schrempf
On 28.04.21 16:16, Marek Vasut wrote: On 4/28/21 11:24 AM, Neil Armstrong wrote: [...] +static int sn65dsi83_probe(struct i2c_client *client, +   const struct i2c_device_id *id) +{ +    struct device *dev = >dev; +    enum sn65dsi83_model model; +    struct sn65dsi83 *ctx; +    int

Re: [PATCH V2 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-04-28 Thread Frieder Schrempf
On 28.04.21 09:51, Frieder Schrempf wrote: On 22.04.21 00:31, Marek Vasut wrote: Add driver for TI SN65DSI83 Single-link DSI to Single-link LVDS bridge and TI SN65DSI84 Single-link DSI to Dual-link or 2x Single-link LVDS bridge. TI SN65DSI85 is unsupported due to lack of hardware to test

Re: [PATCH V2 1/2] dt-bindings: drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 bindings

2021-04-28 Thread Frieder Schrempf
On 22.04.21 00:31, Marek Vasut wrote: Add DT binding document for TI SN65DSI83 and SN65DSI84 DSI to LVDS bridge. Signed-off-by: Marek Vasut Cc: Douglas Anderson Cc: Jagan Teki Cc: Laurent Pinchart Cc: Linus Walleij Cc: Rob Herring Cc: Sam Ravnborg Cc: Stephen Boyd Cc:

Re: [PATCH V2 2/2] drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver

2021-04-28 Thread Frieder Schrempf
On 22.04.21 00:31, Marek Vasut wrote: Add driver for TI SN65DSI83 Single-link DSI to Single-link LVDS bridge and TI SN65DSI84 Single-link DSI to Dual-link or 2x Single-link LVDS bridge. TI SN65DSI85 is unsupported due to lack of hardware to test on, but easy to add. The driver operates the chip

Re: [PATCH v2 10/16] drm/exynos: implement a drm bridge

2021-04-20 Thread Frieder Schrempf
On 23.02.21 13:07, Daniel Vetter wrote: On Thu, Feb 18, 2021 at 5:02 PM Andrzej Hajda wrote: Hi Michael, W dniu 18.02.2021 o 09:04, Michael Tretter pisze: On Wed, 10 Feb 2021 10:10:37 +0100, Frieder Schrempf wrote: On 04.02.21 18:46, Daniel Vetter wrote: On Thu, Feb 4, 2021 at 6:26 PM

Re: [PATCH v2 10/16] drm/exynos: implement a drm bridge

2021-02-10 Thread Frieder Schrempf
On 04.02.21 18:46, Daniel Vetter wrote: On Thu, Feb 4, 2021 at 6:26 PM Laurent Pinchart wrote: Hi Daniel, On Thu, Feb 04, 2021 at 06:19:22PM +0100, Daniel Vetter wrote: On Thu, Feb 4, 2021 at 5:28 PM Andrzej Hajda wrote: W dniu 04.02.2021 o 17:05, Daniel Vetter pisze: On Thu, Feb 04, 2021

Re: Using Etnaviv with mxsfb-drm

2020-12-15 Thread Frieder Schrempf
Hi Lucas, On 14.12.20 14:06, Lucas Stach wrote: Hi Frieder, Am Montag, den 14.12.2020, 13:33 +0100 schrieb Frieder Schrempf: Hi Lucas, hi Marek, while doing some tests on i.MX8MM with Etnaviv and mxsfb-drm (using the patches for DSIM, GPC, BLK-CTL, etc., see branch at [1]), I noticed that I

Using Etnaviv with mxsfb-drm

2020-12-15 Thread Frieder Schrempf
Hi Lucas, hi Marek, while doing some tests on i.MX8MM with Etnaviv and mxsfb-drm (using the patches for DSIM, GPC, BLK-CTL, etc., see branch at [1]), I noticed that I don't seem to be able to run glmark2: ~# glmark2-es2-drm === glmark2

  1   2   >