Re: [PATCH 0/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-03-02 Thread Gustavo Padovan
rnelCI. > > However I don't really see this happening, unless I'm missing a > part of the story or some upcoming announcement with an updated > roadmap. For some reason the old and established paradigm seems > unshakeable. The new KernelCI implementation is starting to look > just like a refresh of the old one with newer components - which > is a huge missed opportunity to really change things IMHO. Calling that a missed opportunity is a subjective perspective about the latest developments in KernelCI. The system implementation is one level less important than the actual kernel community engagement the project can generate. If one asks people around, the lack of community engagement with KernelCI is evident. However, after the recent leadership change in the project there is a growing effort to bring the kernel community closer to the KernelCI project with a renewed focus on high quality test results, clean regression reporting, among other things. Then, with an increased number of community members involved, we will have the necessary feedback (and funding!) to evolve the KernelCI infrastructure and technology to new levels. Otherwise, envisioning something that can solve *all* community testing needs would never be anything more than a fantasy in people's heads. - Gus -- Gustavo Padovan Kernel Lead Collabora Ltd.

Re: [PATCH v3] drm/rockchip: update cursors asynchronously through atomic.

2018-11-27 Thread Gustavo Padovan
. Best regards, Tomasz From your comment in v2: Isn't this going to drop the old fb reference on the floor without waiting for the hardware to actually stop scanning out from it? I've been trying to analyze this better, I also got some help from Gustavo Padovan, and I think there is n

Re: [PATCH] drm/i2c/tda9950.c: set MAX_RETRIES for errors only

2018-09-13 Thread Gustavo Padovan
executes all retries for us */ > - tx_status |= CEC_TX_STATUS_MAX_RETRIES; > + if (tx_status != CEC_TX_STATUS_OK) > + tx_status |= CEC_TX_STATUS_MAX_RETRIES; > cec_transmit_done(priv->adap, tx_status, arb_lost_cnt, >

Re: [PATCH] drm/atomic: add ATOMIC_AMEND flag to the Atomic IOCTL.

2018-08-07 Thread Gustavo Padovan
On Tue, Aug 07, 2018 at 06:40:39PM +0200, Daniel Vetter wrote: > On Mon, Aug 06, 2018 at 06:01:02PM +0200, Enric Balletbo i Serra wrote: > > From: Gustavo Padovan > > > > This flag tells core to jump ahead the queued update if the conditions > > in drm_atomic_async_che

Re: [PATCH v2 2/2] drm/vkms: Implement CRC debugfs API

2018-08-03 Thread Gustavo Padovan
On Fri, Aug 03, 2018 at 12:42:15PM -0400, Sean Paul wrote: > On Thu, Aug 02, 2018 at 08:09:51AM -0300, Gustavo Padovan wrote: > > Hi Haneen, > > > > On Thu, Aug 02, 2018 at 04:10:26AM +0300, Haneen Mohammed wrote: > > > This patch implement the necessary fun

[PULL] drm-misc-next-fixes

2018-08-02 Thread Gustavo Padovan
Hi Dave, Two fixes for 4.19 here. For an oops on the DP CEC code and a memory leak on the vkms driver. Please pull. Regards, Gustavo drm-misc-next-fixes-2018-08-02: Fixes an oops on the DP CEC code and a memory leak on the vkms driver. The following changes since commit

Re: [PATCH v2 2/2] drm/vkms: Implement CRC debugfs API

2018-08-02 Thread Gustavo Padovan
Hi Haneen, On Thu, Aug 02, 2018 at 04:10:26AM +0300, Haneen Mohammed wrote: > This patch implement the necessary functions to compute and add CRCs > entries: > > - Implement the set_crc_source() callback. > - Compute CRC using crc32 on the visible part of the framebuffer. > - Use ordered

Re: [PATCH v2] drm/vkms: Use new return type vm_fault_t

2018-07-30 Thread Gustavo Padovan
Hi Souptick, On Thu, Jul 26, 2018 at 08:15:49PM +0530, Souptick Joarder wrote: > Use new return type vm_fault_t for fault handler. > > Signed-off-by: Souptick Joarder > --- > v2: Updated patch title > > drivers/gpu/drm/vkms/vkms_drv.h | 2 +- > drivers/gpu/drm/vkms/vkms_gem.c | 5 ++--- > 2

Re: [PATCH] drm/vkms: Fix connector leak at the module removal

2018-07-28 Thread Gustavo Padovan
Hi Rodrigo, On Wed, Jul 18, 2018 at 09:40:45PM -0300, Rodrigo Siqueira wrote: > Currently, vkms shows an error message if the following steps occur: (1) > load vkms, (2) perform any specific operation in the vkms (e.g., run an > IGT test), and (3) unload the module. The following error message >

Re: [PATCH for v4.19] drm_dp_cec.c: fix formatting typo: %pdH -> %phD

2018-07-28 Thread Gustavo Padovan
On Tue, Jul 24, 2018 at 09:20:28PM +0200, Hans Verkuil wrote: > This caused a kernel oops since %pdH interpreted the pointer > as a struct file. > > Signed-off-by: Hans Verkuil > --- > drivers/gpu/drm/drm_dp_cec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [RFC RESEND PATCH] drm/rockchip: update cursors asynchronously through atomic.

2018-07-24 Thread Gustavo Padovan
sync_check, + .atomic_async_update = vop_plane_atomic_async_update, }; static const struct drm_plane_funcs vop_plane_funcs = { -- 2.18.0 -- Gustavo Padovan Collabora Ltd ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PULL] drm-misc-next

2018-07-18 Thread Gustavo Padovan
Hi Dave, Another round for 4.19. Fixes the build issue for sun4i. Many fixes and improvements, most interesting thing is probably the DisplayPort CEC-Tunneling-over-AUX support. Please pull, thanks. drm-misc-next-2018-07-18: drm-misc-next for 4.19: Core Changes: - add support for DisplayPort

[PULL] drm-misc-next

2018-07-11 Thread Gustavo Padovan
tation structure. drm/v3d: Fix a grammar nit in the scheduler docs. Gustavo Padovan (1): Merge drm-upstream/drm-next into drm-misc-next Haneen Mohammed (1): drm/vkms: Introduce basic VKMS driver Jagan Teki (1): drm/panel: simple: Add support for Rocktech RK070ER9427 LCD pan

Re: [RFC PATCH] drm/atomic: add ASYNC_UPDATE flag to the Atomic IOCTL.

2018-07-09 Thread Gustavo Padovan
Hi Ville, On Thu, 2018-06-28 at 16:35 +0300, Ville Syrjälä wrote: > On Wed, Jun 27, 2018 at 11:25:06PM +0200, Enric Balletbo i Serra > wrote: > > From: Gustavo Padovan > > > > This flag tells core to jump ahead the queued update if the > > conditions > >

[PULL] drm-misc-next

2018-07-04 Thread Gustavo Padovan
larify license drm/vmwgfx: add SPDX idenitifier and clarify license Eric Anholt (2): drm/v3d: Define the fourcc modifier for the Broadcom UIF format. drm/vc4: Make DSI call into the bridge after the DSI link is enabled. Gustavo Padovan (2): Merge tag 'ib-fbdev-drm-v4.19-de

Re: [PATCH v5 0/3] console/fbcon: Add support for deferred console takeover

2018-06-29 Thread Gustavo Padovan
On Fri, 2018-06-29 at 12:08 +0200, Bartlomiej Zolnierkiewicz wrote: > Hi Gustavo, > > On Thursday, June 28, 2018 07:44:38 PM Gustavo Padovan wrote: > > Hi Bartlomiej, > > > > On Thu, 2018-06-28 at 15:50 +0200, Bartlomiej Zolnierkiewicz wrote: > > > On Thursda

Re: [RFC PATCH] drm/atomic: add ASYNC_UPDATE flag to the Atomic IOCTL.

2018-06-29 Thread Gustavo Padovan
Hi Maarten, On Thu, 2018-06-28 at 10:31 +0200, Maarten Lankhorst wrote: > Op 27-06-18 om 23:25 schreef Enric Balletbo i Serra: > > From: Gustavo Padovan > > > > This flag tells core to jump ahead the queued update if the > > conditions > > in drm_atomic_asy

Re: [PATCH v5 0/3] console/fbcon: Add support for deferred console takeover

2018-06-28 Thread Gustavo Padovan
Hi Bartlomiej, On Thu, 2018-06-28 at 15:50 +0200, Bartlomiej Zolnierkiewicz wrote: > On Thursday, June 28, 2018 11:03:48 AM Hans de Goede wrote: > > Hi All, > > > > Here is v5 of my patch-set, to delay fbcon taking over the console > > (and > > binding to fbdev devices) until there actually is

[PULL] drm-misc-next

2018-06-27 Thread Gustavo Padovan
Hi Dave, One more for 4.19. We don't have any big change on this one, it is mostly drivers updates here. Please pull. Regards, Gustavo drm-misc-next-2018-06-27: drm-misc-next for 4.19: Cross-subsystem Changes: devicetree documentation dt-bindings defintions for sun8i (Jernej Skrabec) Core

Re: [PATCH v2] dma-buf/fence: Take refcount on the module that owns the fence

2018-06-22 Thread Gustavo Padovan
module)) > + fence->owner = NULL; > > trace_dma_fence_init(fence); > } > -EXPORT_SYMBOL(dma_fence_init); > +EXPORT_SYMBOL(_dma_fence_init); Do we still need to export the symbol, it won't be called from outside anymore? Other than that looks good to me: Reviewed-by: Gustavo Padovan Gustavo ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PULL] drm-misc-next

2018-06-21 Thread Gustavo Padovan
to vc4_format_mod_supported(). Gerd Hoffmann (1): dma-buf: make map_atomic and map function pointers optional Gustavo Padovan (1): Merge drm-upstream/drm-next into drm-misc-next Haneen Mohammed (1): drm: Add checks for atomic_[duplicate/destroy]_state with atomic drivers Heiko Stueb

[PULL] drm-misc-next

2018-06-20 Thread Gustavo Padovan
evenson (1): drm/vc4: Add support for SAND modifier. Eric Anholt (2): drm: Trust format_mod_supported() when it OKs a plane modifier. drm/vc4: Add missing formats to vc4_format_mod_supported(). Gerd Hoffmann (1): dma-buf: make map_atomic and map function pointers optional

Re: [PATCH] dma-fence: Make dma_fence_add_callback() fail if signaled with error

2018-05-09 Thread Gustavo Padovan
Hi Ezequiel, On Wed, 2018-05-09 at 17:14 -0300, Ezequiel Garcia wrote: > Change how dma_fence_add_callback() behaves, when the fence > has error-signaled by the time it is being add. After this commit, > dma_fence_add_callback() returns the fence error, if it > has error-signaled before

[PULL] drm-misc-fixes

2018-03-22 Thread Gustavo Padovan
Hi Dave, A few fixes for 4.16. Main thing here is getting getfb to reject multiplanar fbs. I should have sent some of these before but conference and traveling got in the way. Thanks, Gustavo drm-misc-fixes-2018-03-22: Main change is a patch to reject getfb call for multiplanar framebuffers,

[PULL] drm-misc-fixes

2018-03-07 Thread Gustavo Padovan
Hi Dave, Only a few sun4i fixes this week. Please pull. Regards, Gustavo drm-misc-fixes-2018-03-07: sun4i fixes on clk, division by zero and LVDS. The following changes since commit 9a191b114906457c4b2494c474f58ae4142d4e67: virtio-gpu: fix ioctl and expose the fixed status to userspace.

[PULL] drm-misc-fixes

2018-02-28 Thread Gustavo Padovan
Hi Dave, A few more fixes for 4.16, including 2 regression fixes. Please pull. Thanks, Gustavo drm-misc-fixes-2018-02-28: Two regression fixes here: a fb format regression on nouveau and a 4.16-rc1 regression with on LVDS with one sun4i device. Plus a sun4i and a virtio-gpu fixes. The

[PULL] drm-misc-fixes

2018-02-21 Thread Gustavo Padovan
Hi Dave, A bunch of fixes for 4.16. For some reason the lut fixes showed up again here when generating the pull-request with dim-tools. Once you pull I can fast forward the to drm-fixes hopefully. Thanks, Gustavo drm-misc-fixes-2018-02-21: Fixes for 4.16. I contains fixes for deadlock on

[PATCH v2 4/5] drm/virtio: add out-fences support for explicit synchronization

2018-02-16 Thread Gustavo Padovan
From: Gustavo Padovan <gustavo.pado...@collabora.com> On the out-fence side we get fence returned by the submitted draw call and attach it to a sync_file and send the sync_file fd to userspace. On error -1 is returned to userspace. Signed-off-by: Gustavo Padovan <gustavo.pado...@coll

[PATCH v2 5/5] drm/virtio: bump driver version after explicit synchronization addition

2018-02-16 Thread Gustavo Padovan
From: Gustavo Padovan <gustavo.pado...@collabora.com> To reflect the (backward compatible) changes in the uabi we are bumping the driver's version. Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.co> --- drivers/gpu/drm/virtio/virtgpu_drv.h | 4 ++-- 1 file changed, 2 inse

[PATCH v2 2/5] drm/virtio: add uapi for in and out explicit fences

2018-02-16 Thread Gustavo Padovan
From: Gustavo Padovan <gustavo.pado...@collabora.com> Add a new field called fence_fd that will be used by userspace to send in-fences to the kernel and receive out-fences created by the kernel. This uapi enables virtio to take advantage of explicit synchronization of dma-bufs. There a

[PATCH v2 1/5] drm/virtio: add virtio_gpu_alloc_fence()

2018-02-16 Thread Gustavo Padovan
From: Gustavo Padovan <gustavo.pado...@collabora.com> Refactor fence creation to remove the potential allocation failure from the cmd_submit and atomic_commit paths. Now the fence should be allocated first and just after we should proceed with the rest of the execution. v2: - only

[PATCH v2 3/5] drm/virtio: add in-fences support for explicit synchronization

2018-02-16 Thread Gustavo Padovan
From: Gustavo Padovan <gustavo.pado...@collabora.com> When the execbuf call receives an in-fence it will get the dma_fence related to that fence fd. If that fence is from a foreign context we wait on it before submitting the draw call. v2: - incorporate fix for context check from Rob H

[PATCH v2 0/5] virgl: fence fd support

2018-02-16 Thread Gustavo Padovan
From: Gustavo Padovan <gustavo.pado...@collabora.com> Hi, So I finally got around to finish this work! :) Here are the updated patchset with fixes for Rob Herring incorporated. This follow pretty much the same semantics of other drivers that implemented explicit fence support. It e

Re: [PULL] drm-misc-fixes

2018-01-31 Thread Gustavo Padovan
! 2018-01-31 Gustavo Padovan <gust...@padovan.org>: > Hi Dave, > > This one got applied late to drm-misc-fixes, it should go to 4.16 > anyway. Please pull, Thanks. > > Gustavo > > drm-misc-fixes-2018-01-31: > - fix lut loading for cirrus >

[PULL] drm-misc-fixes

2018-01-31 Thread Gustavo Padovan
Hi Dave, This one got applied late to drm-misc-fixes, it should go to 4.16 anyway. Please pull, Thanks. Gustavo drm-misc-fixes-2018-01-31: - fix lut loading for cirrus The following changes since commit a8750ddca918032d6349adbf9a4b6555e7db20da: Linux 4.15-rc8 (2018-01-14 15:32:30 -0800) are

[PULL] drm-misc-next-fixes

2018-01-31 Thread Gustavo Padovan
Hi Dave, two fixes for the 4.16 cycle from the drm-misc-next-fixes. drm-misc-next-fixes-2018-01-31: This contains a fix to restrict what lessee can do with masters and another one when waiting for timeouts on reservation objects. The following changes since commit

Re: [PATCH 7/9] dma-buf/dma-fence: Signal all callbacks from dma_fence_release()

2018-01-31 Thread Gustavo Padovan
callbacks know this signal is due to an error. > + */ > + spin_lock_irqsave(fence->lock, flags); > + fence->error = -EDEADLK; > + dma_fence_signal_locked(fence); > + spin_unlock_irqrestore(fence->l

Re: [PATCH] MAINTAINERS: Maarten for drm-misc co-maintainer

2018-01-31 Thread Gustavo Padovan
x.intel.com> > Cc: David Airlie <airl...@linux.ie> > Cc: Gustavo Padovan <gust...@padovan.org> > Cc: Sean Paul <seanp...@chromium.org> > Acked-by: Sean Paul <seanp...@chromium.org> > Acked-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> &g

[PULL] drm-misc-next-fixes

2018-01-18 Thread Gustavo Padovan
Hi Dave, A few fixes for 4.16. Please pull. Thanks. drm-misc-next-fixes-2018-01-18: Fixes for 4.16: Fixes one Kconfig issue and a enable some panels to work properly. There is also a fix of error code return in sun4i. The following changes since commit a1c55bccf6004ec9fbcf892328f9658767aa22bb:

[PULL] drm-misc-next

2018-01-08 Thread Gustavo Padovan
Hi Dave, This is a late pull request for 4.16. It our final one. Due to holidays we failed to send it before. In terms of features nothing really big/important apart from the addition of the Ilitek ILI9322 panel driver, that have been tested at linux-next for more than two weeks. The changes

[PULL] drm-misc-next

2017-12-21 Thread Gustavo Padovan
Hi Dave, Flushing out drm-misc-next before the holidays. Docs and fbdev work here. We will skip a pull request next week, back in 2018! Regards, Gustavo drm-misc-next-2017-12-21: drm-misc-next for 4.16: Core Changes: - mostly doc updates and some fbdev improvements The following changes since

[PULL] drm-misc-next

2017-12-14 Thread Gustavo Padovan
Hi Dave, More of the same. A lot of improvements from Noralf on this one. Nothing really big here. Regards, Gustavo drm-misc-next-2017-12-14: drm-misc-next for 4.16: Cross-subsystem Changes: - Documentation for amlogic dt dt-bindings Core Changes: - Update edid-derived drm_display_info

[PULL] drm-misc-next

2017-12-07 Thread Gustavo Padovan
ydrm: export mipi_dbi_buf_copy and mipi_dbi_spi_cmd_max_speed drm/tinydrm: add driver for ILI9225 panels Gustavo A. R. Silva (1): drm/fb-helper: Fix potential NULL pointer dereference Gustavo Padovan (1): Merge arlied/drm-next into drm-misc-next Hans de Goede (8): fbcon: A

Re: [PULL] drm-misc-next for 4.16

2017-11-30 Thread Gustavo Padovan
Forgot to setup gpg sign... 2017-11-30 Gustavo Padovan <gust...@padovan.org>: > Hi Dave, > > Here goes my first pull request as drm-misc co-maintainer, outstanding > here is the plane clipping fixes from Ville and the work to reduce > bdev emulation footprint in drivers f

[PULL] drm-misc-next for 4.16

2017-11-30 Thread Gustavo Padovan
Hi Dave, Here goes my first pull request as drm-misc co-maintainer, outstanding here is the plane clipping fixes from Ville and the work to reduce bdev emulation footprint in drivers from Noralf. Otherwise it is more of the same. No UAPI changes. drm-misc-next-2017-11-30 for 4.16:

Re: [PATCH] MAINTAINERS: Remove Jani as drm-misc co-maintainer

2017-11-29 Thread Gustavo Padovan
; > maintainer. This still leaves us with a nice team of three who are > > actually doing the drm-misc work, while I focus on drm-intel. > > > > Cc: Daniel Vetter <daniel.vet...@intel.com> > > Cc: Gustavo Padovan <gust...@padovan.org> > > Cc: Sean Paul &

Re: [PATCH] drm: mali-dp: Disable planes when their CRTC gets disabled.

2017-11-15 Thread Gustavo Padovan
Dudau <liviu.du...@arm.com> > --- > drivers/gpu/drm/arm/malidp_crtc.c | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Gustavo Padovan <gustavo.pado...@collabora.com> Gustavo ___ dri-devel mailing list dri-devel@lists.freedesktop.org ht

Re: [PATCH] drm: mali-dp: Separate static internal data into a read-only structure.

2017-11-15 Thread Gustavo Padovan
--- > drivers/gpu/drm/arm/malidp_planes.c | 19 +-- > 5 files changed, 93 insertions(+), 80 deletions(-) Reviewed-by: Gustavo Padovan <gustavo.pado...@collabora.com> Gustavo ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm: Print the fb dimensions when the src coord check fails

2017-11-02 Thread Gustavo Padovan
2017-11-02 Daniel Vetter : > On Wed, Nov 01, 2017 at 08:35:33PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > When debugging bad plane source coordinates it helps to have an > > idea of what the framebuffer dimensions are. > > > >

Re: [PATCH] drm/drm_mm.h: Fix the name of the referenced function in comment

2017-11-02 Thread Gustavo Padovan
Hi Liviu, 2017-11-01 Liviu Dudau : > drm_mm_insert_node_generic() is a simplified version of > drm_mm_insert_node_in_range(), update comment to reflect correct > function name. > > Signed-off-by: Liviu Dudau > --- > include/drm/drm_mm.h | 2 +- > 1

Re: [PATCH] dma-buf: Cleanup comments on dma_buf_map_attachment()

2017-11-02 Thread Gustavo Padovan
Hi Liviu, 2017-11-01 Liviu Dudau : > Mappings need to be unmapped by calling dma_buf_unmap_attachment() and > not by calling again dma_buf_map_attachment(). Also fix some spelling > mistakes. > > Signed-off-by: Liviu Dudau > --- >

Re: [PATCH] drm: Spelling fixes

2017-11-02 Thread Gustavo Padovan
Hi Liviu, 2017-11-01 Liviu Dudau : > Minor spelling fix for 'monster' and replace 'on' with 'own' in > comments. > > Signed-off-by: Liviu Dudau > --- > drivers/gpu/drm/drm_atomic.c | 2 +- > drivers/gpu/drm/drm_mm.c | 2 +- > 2 files changed, 2

Re: [PATCH] drm/vc4: Fix wrong printk format in vc4_bo_stats_debugfs()

2017-11-01 Thread Gustavo Padovan
rgeable.purged_num) > - seq_printf(m, "%30s: %6dkb BOs (%d)\n", "total purged BO", > + seq_printf(m, "%30s: %6zdkb BOs (%d)\n", "total purged BO", > vc4->purgeable.purged_size / 1024, >

Re: [PATCH] drm/stm: checkpatch strict minor updates

2017-11-01 Thread Gustavo Padovan
state->crtc_w) || (src_h != state->crtc_h)) { > + if (src_w != state->crtc_w || src_h != state->crtc_h) { > DRM_ERROR("Scaling is not supported"); > return -EINVAL; Reviewed-by: Gustavo Padovan <gustavo.pado...@collabora.com> ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/stm: dsi: Rename driver name

2017-11-01 Thread Gustavo Padovan
stm_dt_ids, > - .name = "dw_mipi_dsi-stm", > + .name = "stm32-display-dsi", Reviewed-by: Gustavo Padovan <gustavo.pado...@collabora.com> Gustavo ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 6/6] drm/msm/mdp5: Don't use async plane update path if plane visibility changes

2017-11-01 Thread Gustavo Padovan
plane update path, > so return an error if the new state's "visible" isn't the same as the > current state's "visible". > > Cc: Gustavo Padovan <gustavo.pado...@collabora.com> > Signed-off-by: Archit Taneja <arch...@codeaurora.org> > --- > d

Re: [Intel-gfx] [maintainer-tools PATCH] dim: Sign commits in addition to tags

2017-11-01 Thread Gustavo Padovan
2017-10-31 Sean Paul : > On Tue, Oct 31, 2017 at 1:31 PM, Daniel Vetter wrote: > > On Tue, Oct 31, 2017 at 5:14 PM, Sean Paul wrote: > >> On Tue, Oct 31, 2017 at 4:27 AM, Jani Nikula > >> wrote: > >>> >

Re: [PATCH v2] sync_file: Return consistent status in SYNC_IOC_FILE_INFO

2017-10-09 Thread Gustavo Padovan
l_fence_info to track what has been > > encoded and using that as the overall sync_file status. > > > > Tested-by: Vamsidhar Reddy Gaddam <vamsidhar.gad...@arm.com> > > Signed-off-by: John Einar Reitan <john.rei...@arm.com> > > Cc: Sumit Semwal <sumit.se

Re: [Intel-gfx] [-PATCH v5 1/5] drm/i915: update cursors asynchronously through atomic

2017-09-08 Thread Gustavo Padovan
2017-09-08 Chris Wilson <ch...@chris-wilson.co.uk>: > Quoting Gustavo Padovan (2017-09-08 20:24:15) > > @@ -13167,6 +13170,26 @@ static int intel_atomic_commit(struct drm_device > > *dev, > > struct drm_i915_private *dev_priv = to_i915(de

[-PATCH v5 2/5] drm/i915: remove intel_cursor_plane_funcs

2017-09-08 Thread Gustavo Padovan
From: Gustavo Padovan <gustavo.pado...@collabora.com> After converting legacy cursor updates to atomic async commits intel_cursor_plane_funcs just duplicates intel_plane_funcs now. Cc: Daniel Vetter <daniel.vet...@intel.com> Cc: intel-...@lists.freedesktop.org Signed-off-by: Gus

[-PATCH v5 4/5] drm/msm: remove mdp5_cursor_plane_funcs

2017-09-08 Thread Gustavo Padovan
From: Gustavo Padovan <gustavo.pado...@collabora.com> After converting legacy cursor updates to atomic async commits mdp5_cursor_plane_funcs just duplicates mdp5_plane_funcs now. Cc: Rob Clark <robdcl...@gmail.com> Cc: Archit Taneja <arch...@codeaurora.org> Signed-off-b

[-PATCH v5 3/5] drm/msm: update cursors asynchronously through atomic

2017-09-08 Thread Gustavo Padovan
From: Gustavo Padovan <gustavo.pado...@collabora.com> Add support to async updates of cursors by using the new atomic interface for that. Basically what this commit does is do what mdp5_update_cursor_plane_legacy() did but through atomic. v5: call drm_atomic_helper_async_check() from the

[-PATCH v5 5/5] drm/vc4: update cursors asynchronously through atomic

2017-09-08 Thread Gustavo Padovan
From: Gustavo Padovan <gustavo.pado...@collabora.com> Add support for async updates of cursors by using the new atomic interface for that. Basically what this commit does is do what vc4_update_plane() did but through atomic. v5: add missing call to vc4_plane_atomic_check() (Eric Anholt) v

[-PATCH v5 1/5] drm/i915: update cursors asynchronously through atomic

2017-09-08 Thread Gustavo Padovan
From: Gustavo Padovan <gustavo.pado...@collabora.com> Add support to async updates of cursors by using the new atomic interface for that. Basically what this commit does is do what intel_legacy_cursor_update() did but through atomic. v4: - call drm_atomic_helper_async_check(

Re: [PATCH v2 2/2] dma-buf/sw_sync: force signal all unsignaled fences on dying timeline

2017-09-08 Thread Gustavo Padovan
Hi Chris, 2017-09-07 Chris Wilson <ch...@chris-wilson.co.uk>: > Quoting Gustavo Padovan (2017-09-07 20:02:46) > > From: Dominik Behr <db...@chromium.org> > > > > To avoid hanging userspace components that might have been waiting on the > > active f

[PATCH v2 2/2] dma-buf/sw_sync: force signal all unsignaled fences on dying timeline

2017-09-07 Thread Gustavo Padovan
which Android still relies on. It was broken on the dma fence conversion a few years ago and never fixed. v2: Do not bother with cleanup do the list (Chris Wilson) Signed-off-by: Dominik Behr <db...@chromium.org> Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.com> --

[PATCH v2 1/2] selftests: sync: add test that waits on a destroyed timeline

2017-09-07 Thread Gustavo Padovan
a.co.uk> Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.com> --- tools/testing/selftests/sync/sync_test.c | 1 + tools/testing/selftests/sync/sync_wait.c | 58 tools/testing/selftests/sync/synctest.h | 1 + 3 files changed, 60 insertions(+) di

[PATCH 1/2] selftests: sync: add test that waits on a destroyed timeline

2017-09-04 Thread Gustavo Padovan
a.co.uk> Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.com> --- tools/testing/selftests/sync/sync_test.c | 1 + tools/testing/selftests/sync/sync_wait.c | 58 tools/testing/selftests/sync/synctest.h | 1 + 3 files changed, 60 insertions(+) di

[PATCH 2/2] dma-buf/sw_sync: force signal all unsignaled fences on dying timeline

2017-09-04 Thread Gustavo Padovan
which Android still relies on. It was broken on the dma fence conversion a few years ago and never fixed. Signed-off-by: Dominik Behr <db...@chromium.org> Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.com> --- drivers/dma-buf/sw_sync.c | 12 1 file chan

Re: [Intel-gfx] [RFC PATCH 5/5] drm/atomic: Make async plane update checks work as intended.

2017-09-02 Thread Gustavo Padovan
tion we can reject the fast update, and force the slowpath > > to be used as was originally intended. > > > > Cc: Gustavo Padovan <gustavo.pado...@collabora.com> > > Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> > > Makes sense, but I th

Re: [PATCH] dma-buf/sync_file: document flags field

2017-08-18 Thread Gustavo Padovan
2017-08-01 Sumit Semwal <sumit.sem...@linaro.org>: > Hi Gustavo, > > On 1 August 2017 at 01:06, Gustavo Padovan <gust...@padovan.org> wrote: > > From: Gustavo Padovan <gustavo.pado...@collabora.com> > > > > Documentation for it was missing. > &g

Re: [PATCH] drm/atomic: Handle -EDEADLK with out-fences correctly

2017-08-18 Thread Gustavo Padovan
e reallocate freed memory, and installing over an existing > fd, or potential other fun. > > Zero fence_state and num_fences correctly in the retry loop, which > allows kms_atomic_transition to pass. > > Fixes: beaf5af48034 ("drm/fence: add out-fences support") > Cc:

Re: [PATCH 3/3] selftests: sync: add test that closes the fd before fence signal

2017-08-02 Thread Gustavo Padovan
Hi Shuah, On Wed, 2017-08-02 at 13:45 -0600, Shuah Khan wrote: > On 07/31/2017 01:43 PM, Gustavo Padovan wrote: > > 2017-07-30 Chris Wilson <ch...@chris-wilson.co.uk>: > > > > > Quoting Gustavo Padovan (2017-07-29 16:22:17) > > > > From: Gust

Re: [PATCH 3/3] selftests: sync: add test that closes the fd before fence signal

2017-07-31 Thread Gustavo Padovan
2017-07-30 Chris Wilson <ch...@chris-wilson.co.uk>: > Quoting Gustavo Padovan (2017-07-29 16:22:17) > > From: Gustavo Padovan <gustavo.pado...@collabora.com> > > > > We found this bug in the sw_sync so adding a test case to prevent it to > > happen in th

[PATCH] dma-buf/sync_file: document flags field

2017-07-31 Thread Gustavo Padovan
From: Gustavo Padovan <gustavo.pado...@collabora.com> Documentation for it was missing. Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.com> --- include/linux/sync_file.h | 4 1 file changed, 4 insertions(+) diff --git a/include/linux/sync_file.h b/include/linux

Re: [PATCH 2/3] dma-buf/sw_sync: clean up list before signaling the fence

2017-07-31 Thread Gustavo Padovan
2017-07-30 Chris Wilson <ch...@chris-wilson.co.uk>: > Quoting Gustavo Padovan (2017-07-29 16:22:16) > > From: Gustavo Padovan <gustavo.pado...@collabora.com> > > > > If userspace already dropped its own reference by closing the sw_sync > > fence

Re: [PATCH 1/3] dma-buf/sw_sync: move timeline_fence_ops around

2017-07-31 Thread Gustavo Padovan
2017-07-30 Chris Wilson <ch...@chris-wilson.co.uk>: > Quoting Gustavo Padovan (2017-07-29 16:22:15) > > From: Gustavo Padovan <gustavo.pado...@collabora.com> > > > > We are going to use timeline_fence_signaled() in a internal function in > > the nex

Re: [PATCH] dma-buf/sync_file: Allow multiple sync_files to wrap a single dma-fence

2017-07-31 Thread Gustavo Padovan
2017-07-31 Daniel Vetter <dan...@ffwll.ch>: > On Sat, Jul 29, 2017 at 12:18:32PM -0300, Gustavo Padovan wrote: > > Hi Chris, > > > > 2017-07-28 Chris Wilson <ch...@chris-wilson.co.uk>: > > > > > Up until recently sync_file were create to export

Re: [PATCH] drm: Fix kerneldoc for atomic_async_update

2017-07-31 Thread Gustavo Padovan
2017-07-31 Daniel Vetter <daniel.vet...@ffwll.ch>: > The enumeration of FIXMEs wasn't indented properly. > > Fixes: fef9df8b5945 ("drm/atomic: initial support for asynchronous plane > update") > Cc: Gustavo Padovan <gustavo.pado...@collabora.com> >

[PATCH 1/3] dma-buf/sw_sync: move timeline_fence_ops around

2017-07-29 Thread Gustavo Padovan
From: Gustavo Padovan <gustavo.pado...@collabora.com> We are going to use timeline_fence_signaled() in a internal function in the next commit. Cc: Chris Wilson <ch...@chris-wilson.co.uk> Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.com> --- drivers/dma-b

[PATCH 3/3] selftests: sync: add test that closes the fd before fence signal

2017-07-29 Thread Gustavo Padovan
From: Gustavo Padovan <gustavo.pado...@collabora.com> We found this bug in the sw_sync so adding a test case to prevent it to happen in the future. Cc: Shuah Khan <shua...@osg.samsung.com> Cc: linux-kselft...@vger.kernel.org Signed-off-by: Gustavo Padovan <gustavo.pado..

Re: [PATCH] dma-buf/sync_file: Allow multiple sync_files to wrap a single dma-fence

2017-07-29 Thread Gustavo Padovan
This patch reverts my suggestion in commit e24165537312 > ("dma-buf/sync_file: only enable fence signalling on poll()") to use a > single bit in the shared dma-fence and restores the sync_file->flags for > tracking the bits individually. > > Reported-by: Gustavo Padovan

[PATCH 2/3] dma-buf/sw_sync: clean up list before signaling the fence

2017-07-29 Thread Gustavo Padovan
From: Gustavo Padovan <gustavo.pado...@collabora.com> If userspace already dropped its own reference by closing the sw_sync fence fd we might end up in a deadlock where dma_fence_is_signaled_locked() will trigger the release of the fence and thus try to hold the lock to remove the fenc

Re: [PATCH] dma-buf/sw_sync: hold a fence reference when check if it signaled

2017-07-27 Thread Gustavo Padovan
2017-07-27 Chris Wilson <ch...@chris-wilson.co.uk>: > Quoting Gustavo Padovan (2017-07-27 20:03:53) > > From: Gustavo Padovan <gustavo.pado...@collabora.com> > > > > If userspace already dropped its own reference by closing the sw_sync > > fence

[PATCH] dma-buf/sw_sync: hold a fence reference when check if it signaled

2017-07-27 Thread Gustavo Padovan
From: Gustavo Padovan <gustavo.pado...@collabora.com> If userspace already dropped its own reference by closing the sw_sync fence fd we might end up in a deadlock where dma_fence_is_signaled_locked() will trigger the release of the fence a thus try to hold the lock to remove the fenc

Re: [PATCH] dma-buf/fence: Avoid use of uninitialised timestamp

2017-07-14 Thread Gustavo Padovan
amp > > for the signaled fence may be shown before the fence is reported as > > signaled, but that's a pre-existing error. > > Now deserves a > Reported-by: Rafael Antognolli <rafael.antogno...@intel.com> > > > Signed-off-by: Chris Wilson <ch...@chris-wilson.c

[PATCH v4 6/6] drm/vc4: update cursors asynchronously through atomic

2017-06-30 Thread Gustavo Padovan
From: Gustavo Padovan <gustavo.pado...@collabora.com> Add support for async updates of cursors by using the new atomic interface for that. Basically what this commit does is do what vc4_update_plane() did but through atomic. v5: add missing call to vc4_plane_atomic_check() (Eric Anholt) v

[PATCH v4 4/6] drm/msm: update cursors asynchronously through atomic

2017-06-30 Thread Gustavo Padovan
From: Gustavo Padovan <gustavo.pado...@collabora.com> Add support to async updates of cursors by using the new atomic interface for that. Basically what this commit does is do what mdp5_update_cursor_plane_legacy() did but through atomic. v5: call drm_atomic_helper_async_check() from the

[PATCH v4 5/6] drm/msm: remove mdp5_cursor_plane_funcs

2017-06-30 Thread Gustavo Padovan
From: Gustavo Padovan <gustavo.pado...@collabora.com> After converting legacy cursor updates to atomic async commits mdp5_cursor_plane_funcs just duplicates mdp5_plane_funcs now. Cc: Rob Clark <robdcl...@gmail.com> Cc: Archit Taneja <arch...@codeaurora.org> Signed-off-b

[PATCH v4 3/6] drm/i915: remove intel_cursor_plane_funcs

2017-06-30 Thread Gustavo Padovan
From: Gustavo Padovan <gustavo.pado...@collabora.com> After converting legacy cursor updates to atomic async commits intel_cursor_plane_funcs just duplicates intel_plane_funcs now. Cc: Daniel Vetter <daniel.vet...@intel.com> Signed-off-by: Gustavo Padovan <gustavo.pado..

[PATCH v4 1/6] drm/atomic: initial support for asynchronous plane update

2017-06-30 Thread Gustavo Padovan
From: Gustavo Padovan <gustavo.pado...@collabora.com> In some cases, like cursor updates, it is interesting to update the plane in an asynchronous fashion to avoid big delays. The current queued update could be still waiting for a fence to signal and thus block any subsequent update unt

[PATCH v4 0/6] drm: add asynchrounous plane update

2017-06-30 Thread Gustavo Padovan
From: Gustavo Padovan <gustavo.pado...@collabora.com> Hi, Follow up after Daniel's comments. Here I move the common async code to drm_atomic_helper.c. i915 and msm now have to call the drm_atomic_helper_async_check() themselves. Please review! Thanks. Gustavo Gustavo Padovan (6):

[PATCH v4 2/6] drm/i915: update cursors asynchronously through atomic

2017-06-30 Thread Gustavo Padovan
From: Gustavo Padovan <gustavo.pado...@collabora.com> Add support to async updates of cursors by using the new atomic interface for that. Basically what this commit does is do what intel_legacy_cursor_update() did but through atomic. v4: - call drm_atomic_helper_async_check(

Re: [PATCH] drm/atomic: Drop helper include from drm_atomic.c

2017-06-30 Thread Gustavo Padovan
Hi Daniel, 2017-06-30 Daniel Vetter <daniel.vet...@ffwll.ch>: > Core code should never have to look at helper stuff, to make sure that > all helper code is 100% optional and can be overriden. > > Cc: Gustavo Padovan <gust...@padovan.org> > Signed-off-by: Daniel Vet

Re: [PATCH 1/7] dma-buf/dma-fence: Extract __dma_fence_is_later()

2017-06-29 Thread Gustavo Padovan
Hi, 2017-06-29 Sean Paul : > On Thu, Jun 29, 2017 at 01:59:24PM +0100, Chris Wilson wrote: > > Often we have the task of comparing two seqno known to be on the same > > context, so provide a common __dma_fence_is_later(). > > > > Signed-off-by: Chris Wilson

[PATCH v3 6/6] drm/vc4: update cursors asynchronously through atomic

2017-06-28 Thread Gustavo Padovan
From: Gustavo Padovan <gustavo.pado...@collabora.com> Add support for async updates of cursors by using the new atomic interface for that. Basically what this commit does is do what vc4_update_plane() did but through atomic. v5: add missing call to vc4_plane_atomic_check() (Eric Anholt) v

[PATCH v3 5/6] drm/msm: remove mdp5_cursor_plane_funcs

2017-06-28 Thread Gustavo Padovan
From: Gustavo Padovan <gustavo.pado...@collabora.com> After converting legacy cursor updates to atomic async commits mdp5_cursor_plane_funcs just duplicates mdp5_plane_funcs now. Cc: Rob Clark <robdcl...@gmail.com> Cc: Archit Taneja <arch...@codeaurora.org> Signed-off-b

[PATCH v3 4/6] drm/msm: update cursors asynchronously through atomic

2017-06-28 Thread Gustavo Padovan
From: Gustavo Padovan <gustavo.pado...@collabora.com> Add support to async updates of cursors by using the new atomic interface for that. Basically what this commit does is do what mdp5_update_cursor_plane_legacy() did but through atomic. v4: add missing atomic async commi

[PATCH v3 1/6] drm/atomic: initial support for asynchronous plane update

2017-06-28 Thread Gustavo Padovan
From: Gustavo Padovan <gustavo.pado...@collabora.com> In some cases, like cursor updates, it is interesting to update the plane in an asynchronous fashion to avoid big delays. The current queued update could be still waiting for a fence to signal and thus block any subsequent update unt

[PATCH v3 2/6] drm/i915: update cursors asynchronously through atomic

2017-06-28 Thread Gustavo Padovan
From: Gustavo Padovan <gustavo.pado...@collabora.com> Add support to async updates of cursors by using the new atomic interface for that. Basically what this commit does is do what intel_legacy_cursor_update() did but through atomic. v3: - set correct vma to new state for c

  1   2   3   4   5   6   7   8   9   10   >