Re: [PATCH 1/2] dt-bindings: display: panel: Add Samsung AMS639RQ08

2024-06-10 Thread Krzysztof Kozlowski
gt; + > + reset-gpios: true > + port: true > + > +additionalProperties: false This goes after "required:" block. > + > +required: > + - compatible > + - reg > + - vdd3p3-supply > + - vddio-supply > + - vsn-supply > + - vsp-supply > + - reset-gpios > + - port > + Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 2/3] dt-bindings: display: simple: Add PrimeView PM070WL4 panel

2024-06-06 Thread Krzysztof Kozlowski
On 06/06/2024 09:28, Primoz Fiser wrote: > Add PrimeView PM070WL4 7.0" 800x480 TFT LCD panel compatible string. > > Signed-off-by: Primoz Fiser > --- > .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git >

Re: [PATCH 1/3] dt-bindings: Add vendor prefix for PrimeView

2024-06-06 Thread Krzysztof Kozlowski
On 06/06/2024 09:28, Primoz Fiser wrote: > The Prime View International (PVI) is a LCD panel manufacturer. > Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. For bindings, the

[PATCH] dt-bindings: display: panel: constrain 'reg' in DSI panels (part two)

2024-06-05 Thread Krzysztof Kozlowski
channel number). Few bindings missed previous fixup: LG SW43408 and Raydium RM69380. Signed-off-by: Krzysztof Kozlowski --- This should apply on any tree. --- .../devicetree/bindings/display/panel/lg,sw43408.yaml| 4 +++- .../devicetree/bindings/display/panel/raydium,rm69380.yaml | 5

Re: [PATCH 1/7] dt-bindings: display/msm/dsi: allow specifying TE source

2024-06-05 Thread Krzysztof Kozlowski
On 04/06/2024 19:52, Abhinav Kumar wrote: > > > On 6/4/2024 8:36 AM, Krzysztof Kozlowski wrote: >> On 04/06/2024 17:32, Dmitry Baryshkov wrote: >>> On Tue, Jun 04, 2024 at 05:22:03PM +0200, Krzysztof Kozlowski wrote: >>>> On 04/06/2024 17:14, Dmitry Baryshkov

Re: [PATCH 1/7] dt-bindings: display/msm/dsi: allow specifying TE source

2024-06-04 Thread Krzysztof Kozlowski
the default. In such case the property can > be skipped. > > Signed-off-by: Dmitry Baryshkov Maybe we need third DT maintainer review/ack... Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/7] dt-bindings: display/msm/dsi: allow specifying TE source

2024-06-04 Thread Krzysztof Kozlowski
On 04/06/2024 17:32, Dmitry Baryshkov wrote: > On Tue, Jun 04, 2024 at 05:22:03PM +0200, Krzysztof Kozlowski wrote: >> On 04/06/2024 17:14, Dmitry Baryshkov wrote: >>>>>>>> >>>>>>>> I didnt follow why this is a link

Re: [PATCH 1/7] dt-bindings: display/msm/dsi: allow specifying TE source

2024-06-04 Thread Krzysztof Kozlowski
On 04/06/2024 17:14, Dmitry Baryshkov wrote: >> >> I didnt follow why this is a link property. Sorry , I didnt follow the >> split part. > > There is a link between the DSI host and the panel. I don't want to > end up in a situation when the properties of the link are split

Re: [PATCH 5/6] drm/sti: hdmi: drop driver owner assignment

2024-06-04 Thread Krzysztof Kozlowski
On 27/05/2024 16:47, Alain Volmat wrote: > Hi Krzysztof, > > thanks for your patch, sorry for the delay. > > On Sat, Mar 30, 2024 at 09:57:21PM +0100, Krzysztof Kozlowski wrote: >> Core in platform_driver_register() already sets the .owner, so driver >> does not nee

[RESEND PATCH] drm/exynos: dp: drop driver owner initialization

2024-06-04 Thread Krzysztof Kozlowski
Core in platform_driver_register() already sets the .owner, so driver does not need to. Whatever is set here will be anyway overwritten by main driver calling platform_driver_register(). Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/exynos/exynos_dp.c | 1 - 1 file changed, 1 deletion

Re: [PATCH v2 3/4] dt-bindings: display: panel: Add compatible for Starry-er88577

2024-06-01 Thread Krzysztof Kozlowski
On 01/06/2024 10:45, Zhaoxiong Lv wrote: > The Starry-er88577 is a 10.1" WXGA TFT-LCD panel, which fits > in nicely with the existing panel-kingdisplay-kd101ne3 driver. > Hence, we add a new compatible with panel specific config. > > Signed-off-by: Zhaoxiong Lv > --- > > Chage since V2: >

Re: [PATCH v2 1/4] dt-bindings: display: panel: Add KD101NE3-40TI support

2024-06-01 Thread Krzysztof Kozlowski
On 01/06/2024 10:45, Zhaoxiong Lv wrote: > Create a new dt-scheam for the kd101ne3-40ti. > The bias IC of this kindisplay-kd101ne3 panel is placed > on the panel side, so when the panel is powered on, > there is no need to control AVDD and AVEE in the driver. > + > + reg: > +description: the

Re: [PATCH v4 09/10] drm/vs: Innosilicon HDMI support

2024-05-21 Thread Krzysztof Kozlowski
On 21/05/2024 12:58, keith wrote: > add inno hdmi driver which binds to vs display controller > and this driver uses the commom api from the inno hdmi > > Signed-off-by: keith > --- ... > +static int starfive_hdmi_bind(struct device *dev, struct device *master, > +

Re: [PATCH v4 02/10] drm/bridge: add common api for inno hdmi

2024-05-21 Thread Krzysztof Kozlowski
On 21/05/2024 12:58, keith wrote: > Add INNO common api so that it can be used by vendor > drivers which implement vendor specific extensions to Innosilicon HDMI. > > Signed-off-by: keith > --- > MAINTAINERS | 2 + > +} > + > +static u32

Re: [PATCH v4 01/10] dt-bindings: display: Add YAML schema for JH7110 display pipeline

2024-05-21 Thread Krzysztof Kozlowski
On 21/05/2024 12:58, keith wrote: > JH7110 SoC display pipeline includes a display controller and hdmi. > Dc controller IP : Vivante DC8200 Dual Display > HDMI IP : INNOSILICON HDMI2.0 > > As the INNO hdmi ip is also used by rockchip SoC in the driver code, > the innosilicon,inno-hdmi.yaml schema

Re: [PATCH v4 00/10] drm/verisilicon : support DC8200 and inno hdmi

2024-05-21 Thread Krzysztof Kozlowski
On 21/05/2024 12:58, keith wrote: > Verisilicon/DC8200 display controller IP has 2 display pipes and each > pipe support a primary plane and a cursor plane . > In addition, there are four overlay planes as two display pipes common > resources. > > The first display pipe is bound to the inno

Re: [PATCH v3 3/6] dt-bindings: display: simple: Add Microtips & Lincolntech Dual-LVDS Panels

2024-05-15 Thread Krzysztof Kozlowski
On 15/05/2024 11:51, Aradhya Bhatia wrote: > Add the Microtips Technology USA's MF-101HIEBCAF0 10.1"[0] panel, > MF-103HIEB0GA0 10.25"[1] panel, and Lincoln Technology Solutions' > LCD185-101CT 10.1"[2] panel. > Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 0/3] dt-bindings: display: panel: constrain 'reg'

2024-05-14 Thread Krzysztof Kozlowski
On 14/05/2024 10:44, Neil Armstrong wrote: > On 13/05/2024 18:41, Dmitry Baryshkov wrote: >> On Mon, 13 May 2024 at 16:17, Rob Herring wrote: >>> >>> On Thu, May 09, 2024 at 11:42:50AM +0200, Krzysztof Kozlowski wrote: >>>> Hi, >>>> >>>

Re: [PATCH v2 2/2] Add dp PHY dt-bindings

2024-05-13 Thread Krzysztof Kozlowski
On 13/05/2024 16:17, Krzysztof Kozlowski wrote: >>> dp.yaml >>>> @@ -0,0 +1,45 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>> +%YAML 1.2 >>>> +--- >>>> +$id: >>> http://devicetree.org/schemas/di

Re: [PATCH v2 2/2] Add dp PHY dt-bindings

2024-05-13 Thread Krzysztof Kozlowski
On 13/05/2024 16:15, LIANKUN YANG (杨连坤) wrote: > On Mon, 2024-05-13 at 08:37 +0200, Krzysztof Kozlowski wrote: >> >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> On 10/05/2024 13:04, Lia

Re: [PATCH 2/2] dt-bindings: panel-simple-dsi: Add generic panel-dsi

2024-05-13 Thread Krzysztof Kozlowski
On 13/05/2024 11:34, Johan Adolfsson wrote: > > >> -Original Message----- >> From: Krzysztof Kozlowski >> Sent: den 22 april 2024 22:57 >> To: Johan Adolfsson ; Neil Armstrong >> ; Jessica Zhang ; Sam >> Ravnborg ; Maarten Lankhorst >>

Re: [PATCH v2 1/2] Add write DP phyd register from parse dts

2024-05-13 Thread Krzysztof Kozlowski
On 10/05/2024 13:04, Liankun Yang wrote: > During the testing phase, screen flickering is observed when > using displayport for screen casting. Relevant SSC register parameters > are set in dts to address the screen flickering issue effectively and > improve compatibility with different devices by

Re: [PATCH v2 2/2] Add dp PHY dt-bindings

2024-05-13 Thread Krzysztof Kozlowski
On 10/05/2024 13:04, Liankun Yang wrote: > Add dp PHY dt-bindings. This tells me nothing. Read submitting patches. > > Changeds in v2: This does goes to changelog, not commit log. > - Add dp PHY dt-bindings. > https://patchwork.kernel.org/project/linux-mediatek/patch/ >

[PATCH 3/3] dt-bindings: display: panel: constrain 'reg' in DSI panels

2024-05-09 Thread Krzysztof Kozlowski
channel number). Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/display/panel/asus,z00t-tm5p5-nt35596.yaml | 5 - .../devicetree/bindings/display/panel/boe,bf060y8m-aj0.yaml | 4 +++- Documentation/devicetree/bindings/display/panel/boe,himax8279d.yaml | 4

[PATCH 2/3] dt-bindings: display: panel: constrain 'reg' in SPI panels

2024-05-09 Thread Krzysztof Kozlowski
SPI-attached devices could have more than one chip-select, thus their bindings are supposed to constrain the 'reg' property to match hardware. Add missing 'reg' constrain for SPI-attached display panels. Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/display/panel/abt

[PATCH 1/3] dt-bindings: display: samsung,ams495qa01: add missing SPI properties ref

2024-05-09 Thread Krzysztof Kozlowski
Samsung AMS495QA01 panel is a SPI device, so it should reference spi-peripheral-props.yaml schema to allow and validate the SPI device properties. Fixes: 92be07c65b22 ("dt-bindings: display: panel: Add Samsung AMS495QA01") Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetre

[PATCH 0/3] dt-bindings: display: panel: constrain 'reg'

2024-05-09 Thread Krzysztof Kozlowski
and examples are correct here. Worst case this can be fixed later - maxItems:2. Best regards, Krzysztof --- Krzysztof Kozlowski (3): dt-bindings: display: samsung,ams495qa01: add missing SPI properties ref dt-bindings: display: panel: constrain 'reg' in SPI panels dt-bindings

Re: [PATCH v1 1/2] dt-bindings: display: panel: Add Starry-er88577 support

2024-05-09 Thread Krzysztof Kozlowski
On 09/05/2024 10:40, Krzysztof Kozlowski wrote: > >> + >> +maintainers: >> + - Zhaoxiong Lv >> + >> +allOf: >> + - $ref: panel-common.yaml# >> + >> +properties: >> + compatible: >> +const: starry,er88577 >> + >>

Re: [PATCH v2 1/2] dt-bindings: display: panel: Add Starry-er88577 support

2024-05-09 Thread Krzysztof Kozlowski
On 09/05/2024 10:34, Zhaoxiong Lv wrote: > Create a new dt-scheam for the Starry-er88577. > > Signed-off-by: Zhaoxiong Lv > --- > Chage since V2: > > - Unmodified > > V1: > https://lore.kernel.org/all/20240509064959.23550-2-lvzhaoxi...@huaqin.corp-partner.google.com/ You just sent v1 2

Re: [PATCH v1 1/2] dt-bindings: display: panel: Add Starry-er88577 support

2024-05-09 Thread Krzysztof Kozlowski
On 09/05/2024 08:49, Zhaoxiong Lv wrote: > Create a new dt-scheam for the Starry-er88577. typo, but anyway, this is not a "dt-schema". Describe hardware instead in one sentence. > > Signed-off-by: Zhaoxiong Lv > --- > .../display/panel/starry,er88577.yaml | 59 +++ >

Re: [PATCH v1 1/2] dt-bindings: input: i2c-hid: Introduce Ilitek ili2900

2024-05-09 Thread Krzysztof Kozlowski
On 09/05/2024 08:43, Zhaoxiong Lv wrote: > From: lvzhaoxiong > > The ili2900 touch screen chip same as ilitek ili9882t controller > has a reset gpio. > > Signed-off-by: lvzhaoxiong You just sent the same, ignoring entire feedback. That's a shortcut to get ignored on your contributions... :(

Re: [PATCH v2] mailbox: mtk-cmdq: Fix sleeping function called from invalid context

2024-05-08 Thread Krzysztof Kozlowski
On 08/05/2024 11:51, Jason-JH.Lin wrote: > When we run kernel with lockdebug option, we will get the BUG below: > [ 106.692124] BUG: sleeping function called from invalid context at > drivers/base/power/runtime.c:1164 > [ 106.692190] in_atomic(): 1, irqs_disabled(): 128, non_block: 0, pid:

Re: [PATCH v2 00/19] backlight: Constify lcd_ops

2024-05-02 Thread Krzysztof Kozlowski
On 02/05/2024 09:22, Lee Jones wrote: > On Wed, 24 Apr 2024, Krzysztof Kozlowski wrote: > >> Hi, >> >> Changes in v2: >> - Collect tags, including wrongly places Thomas' tag (which requires me >> to manually edit 15 other patches to drop it). >> -

Re: [PATCH v4 03/16] dt-bindings: mfd: mediatek: Add codec property for MT6357 PMIC

2024-04-29 Thread Krzysztof Kozlowski
On 26/04/2024 19:22, Alexandre Mergnat wrote: >regulators: > type: object > $ref: /schemas/regulator/mediatek,mt6357-regulator.yaml > @@ -83,6 +111,12 @@ examples: > interrupt-controller; > #interrupt-cells = <2>; > > +audio-codec { > +

Re: [PATCH v4 02/16] ASoC: dt-bindings: mediatek,mt8365-mt6357: Add audio sound card document

2024-04-29 Thread Krzysztof Kozlowski
E > + - PDM3_BE > + - PDM4_BE > + - SPDIF_IN_BE > + - SPDIF_OUT_BE > + - TDM_IN_BE > + - TDM_OUT_BE Feels like BE is redundant. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v4 01/16] ASoC: dt-bindings: mediatek,mt8365-afe: Add audio afe document

2024-04-28 Thread Krzysztof Kozlowski
On 26/04/2024 19:22, Alexandre Mergnat wrote: > Add MT8365 audio front-end bindings > > Signed-off-by: Alexandre Mergnat > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v3 03/18] ASoC: dt-bindings: mt6357: Add audio codec document

2024-04-25 Thread Krzysztof Kozlowski
On 23/04/2024 19:07, Alexandre Mergnat wrote: > > > On 09/04/2024 17:55, Krzysztof Kozlowski wrote: >>> + >>> +additionalProperties: false >>> + >>> +examples: >>> + - | >>> +codec { >>> +mediatek,micbias0-mi

Re: [PATCH 10/10] arm64: dts: qcom: Add AYN Odin 2

2024-04-25 Thread Krzysztof Kozlowski
On 24/04/2024 17:29, Xilin Wu via B4 Relay wrote: > From: Xilin Wu > > AYN Odin 2 is a gaming handheld based on QCS8550, which is derived > from SM8550 but without modem RF system. > > + > +/ { > + model = "AYN Odin 2"; > + compatible = "ayn,odin2", "qcom,qcs8550", "qcom,sm8550"; > +

Re: [PATCH 1/4] drm/tiny: ili9225: drop driver owner assignment

2024-04-24 Thread Krzysztof Kozlowski
On 27/03/2024 18:48, Krzysztof Kozlowski wrote: > Core in spi_register_driver() already sets the .owner, so driver > does not need to. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/gpu/drm/tiny/ili9225.c | 1 - > 1 file changed, 1 deletion(-) It has been almost

Re: [PATCH] drm/etnaviv: drop driver owner assignment

2024-04-24 Thread Krzysztof Kozlowski
On 01/04/2024 12:26, Christian Gmeiner wrote: >> >> Core in platform_driver_register() already sets the .owner, so driver >> does not need to. Whatever is set here will be anyway overwritten by >> main driver calling platform_driver_register(). >> >>

Re: [PATCH 1/2] drm/bridge: chipone-icn6211: drop driver owner assignment

2024-04-24 Thread Krzysztof Kozlowski
On 30/03/2024 21:27, Krzysztof Kozlowski wrote: > Core in mipi_dsi_driver_register() already sets the .owner, so driver > does not need to. > > Signed-off-by: Krzysztof Kozlowski > --- It has been almost a month. Any comments on this patchset? Best regards, Krzysztof

Re: [PATCH 1/4] drm/sti: dvo: drop driver owner assignment

2024-04-24 Thread Krzysztof Kozlowski
On 30/03/2024 21:38, Krzysztof Kozlowski wrote: > Core in platform_driver_register() already sets the .owner, so driver > does not need to. Whatever is set here will be anyway overwritten by > main driver calling platform_driver_register(). > > Signed-off-by: Krzysztof Kozlowski

[PATCH v2 19/19] const_structs.checkpatch: add lcd_ops

2024-04-24 Thread Krzysztof Kozlowski
'struct lcd_ops' is not modified by core code. Suggested-by: Thomas Weißschuh Signed-off-by: Krzysztof Kozlowski --- Patch making lcd_ops const in progress: https://lore.kernel.org/r/20240414-video-backlight-lcd-ops-v1-0-9b37fcbf5...@kernel.org Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo

[PATCH v2 18/19] fbdev: omap: lcd_ams_delta: Constify lcd_ops

2024-04-24 Thread Krzysztof Kozlowski
'struct lcd_ops' is not modified by core backlight code, so it can be made const for increased code safety. Reviewed-by: Thomas Zimmermann Signed-off-by: Krzysztof Kozlowski --- Depends on the first patch in the series. --- drivers/video/fbdev/omap/lcd_ams_delta.c | 2 +- 1 file changed, 1

[PATCH v2 17/19] fbdev: imx: Constify lcd_ops

2024-04-24 Thread Krzysztof Kozlowski
'struct lcd_ops' is not modified by core backlight code, so it can be made const for increased code safety. Reviewed-by: Thomas Zimmermann Signed-off-by: Krzysztof Kozlowski --- Depends on the first patch in the series. --- drivers/video/fbdev/imxfb.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2 16/19] fbdev: clps711x: Constify lcd_ops

2024-04-24 Thread Krzysztof Kozlowski
'struct lcd_ops' is not modified by core backlight code, so it can be made const for increased code safety. Reviewed-by: Thomas Zimmermann Signed-off-by: Krzysztof Kozlowski --- Depends on the first patch in the series. --- drivers/video/fbdev/clps711x-fb.c | 2 +- 1 file changed, 1 insertion

[PATCH v2 15/19] HID: picoLCD: Constify lcd_ops

2024-04-24 Thread Krzysztof Kozlowski
'struct lcd_ops' is not modified by core backlight code, so it can be made const for increased code safety. Reviewed-by: Bruno Prémont Signed-off-by: Krzysztof Kozlowski --- Depends on the first patch in the series. --- drivers/hid/hid-picolcd_lcd.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2 14/19] backlight: tdo24m: Constify lcd_ops

2024-04-24 Thread Krzysztof Kozlowski
'struct lcd_ops' is not modified by core backlight code, so it can be made const for increased code safety. Reviewed-by: Daniel Thompson Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/tdo24m.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video

[PATCH v2 13/19] backlight: platform_lcd: Constify lcd_ops

2024-04-24 Thread Krzysztof Kozlowski
'struct lcd_ops' is not modified by core backlight code, so it can be made const for increased code safety. Reviewed-by: Daniel Thompson Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/platform_lcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH v2 12/19] backlight: otm3225a: Constify lcd_ops

2024-04-24 Thread Krzysztof Kozlowski
'struct lcd_ops' is not modified by core backlight code, so it can be made const for increased code safety. Reviewed-by: Daniel Thompson Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/otm3225a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video

[PATCH v2 11/19] backlight: ltv350qv: Constify lcd_ops

2024-04-24 Thread Krzysztof Kozlowski
'struct lcd_ops' is not modified by core backlight code, so it can be made const for increased code safety. Reviewed-by: Daniel Thompson Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/ltv350qv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video

[PATCH v2 10/19] backlight: lms501kf03: Constify lcd_ops

2024-04-24 Thread Krzysztof Kozlowski
'struct lcd_ops' is not modified by core backlight code, so it can be made const for increased code safety. Reviewed-by: Daniel Thompson Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/lms501kf03.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video

[PATCH v2 09/19] backlight: lms283gf05: Constify lcd_ops

2024-04-24 Thread Krzysztof Kozlowski
'struct lcd_ops' is not modified by core backlight code, so it can be made const for increased code safety. Reviewed-by: Daniel Thompson Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/lms283gf05.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video

[PATCH v2 08/19] backlight: l4f00242t03: Constify lcd_ops

2024-04-24 Thread Krzysztof Kozlowski
'struct lcd_ops' is not modified by core backlight code, so it can be made const for increased code safety. Reviewed-by: Daniel Thompson Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/l4f00242t03.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH v2 07/19] backlight: jornada720_lcd: Constify lcd_ops

2024-04-24 Thread Krzysztof Kozlowski
'struct lcd_ops' is not modified by core backlight code, so it can be made const for increased code safety. Reviewed-by: Daniel Thompson Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/jornada720_lcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH v2 06/19] backlight: ili9320: Constify lcd_ops

2024-04-24 Thread Krzysztof Kozlowski
'struct lcd_ops' is not modified by core backlight code, so it can be made const for increased code safety. Reviewed-by: Daniel Thompson Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/ili9320.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video

[PATCH v2 05/19] backlight: ili922x: Constify lcd_ops

2024-04-24 Thread Krzysztof Kozlowski
'struct lcd_ops' is not modified by core backlight code, so it can be made const for increased code safety. Reviewed-by: Daniel Thompson Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/ili922x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video

[PATCH v2 04/19] backlight: hx8357: Constify lcd_ops

2024-04-24 Thread Krzysztof Kozlowski
'struct lcd_ops' is not modified by core backlight code, so it can be made const for increased code safety. Reviewed-by: Daniel Thompson Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/hx8357.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video

[PATCH v2 03/19] backlight: corgi_lcd: Constify lcd_ops

2024-04-24 Thread Krzysztof Kozlowski
'struct lcd_ops' is not modified by core backlight code, so it can be made const for increased code safety. Reviewed-by: Daniel Thompson Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/corgi_lcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video

[PATCH v2 02/19] backlight: ams369fg06: Constify lcd_ops

2024-04-24 Thread Krzysztof Kozlowski
'struct lcd_ops' is not modified by core backlight code, so it can be made const for increased code safety. Reviewed-by: Daniel Thompson Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/ams369fg06.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video

[PATCH v2 01/19] backlight: Constify lcd_ops

2024-04-24 Thread Krzysztof Kozlowski
'struct lcd_ops' passed in lcd_device_register() is not modified by core backlight code, so it can be made const for code safety. This allows drivers to also define the structure as const. Reviewed-by: Daniel Thompson Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/lcd.c | 4

[PATCH v2 00/19] backlight: Constify lcd_ops

2024-04-24 Thread Krzysztof Kozlowski
, Krzysztof --- Krzysztof Kozlowski (19): backlight: Constify lcd_ops backlight: ams369fg06: Constify lcd_ops backlight: corgi_lcd: Constify lcd_ops backlight: hx8357: Constify lcd_ops backlight: ili922x: Constify lcd_ops backlight: ili9320: Constify lcd_ops

Re: [PATCH v4 9/9] drm/bridge: tfp410: Add platform module alias

2024-04-23 Thread Krzysztof Kozlowski
On 23/04/2024 12:44, Sui Jingfeng wrote: If you need platform one, for some reason, explain what is your matching path and add appropriate ID table. With that explanation, of course. >>> When tfp410 works as a transparent bridge. The device itself is just a >>> platform device.

Re: [PATCH v4 9/9] drm/bridge: tfp410: Add platform module alias

2024-04-23 Thread Krzysztof Kozlowski
On 23/04/2024 12:12, Sui Jingfeng wrote: > Hi, > > On 2024/4/23 16:05, Krzysztof Kozlowski wrote: >> On 22/04/2024 21:19, Sui Jingfeng wrote: >>> Otherwise when compiled as module, this driver will not be probed on >>> non-DT environment. This is a fundamential st

Re: [PATCH v4 9/9] drm/bridge: tfp410: Add platform module alias

2024-04-23 Thread Krzysztof Kozlowski
On 22/04/2024 21:19, Sui Jingfeng wrote: > Otherwise when compiled as module, this driver will not be probed on > non-DT environment. This is a fundamential step to make this driver > truely OF-independent. NAK. You should not need MODULE_ALIAS() in normal cases. If you need it, usually it means

Re: [PATCH 2/2] dt-bindings: panel-simple-dsi: Add generic panel-dsi

2024-04-22 Thread Krzysztof Kozlowski
On 22/04/2024 16:34, Johan Adolfsson wrote: > > > -Original Message- > From: Krzysztof Kozlowski > Sent: den 19 april 2024 01:05 > To: Johan Adolfsson ; Neil Armstrong > ; Jessica Zhang ; Sam > Ravnborg ; Maarten Lankhorst > ; Maxime Ripard ; > Th

Re: [PATCH 1/2] drm/panel: panel-simple: Add generic panel-dsi driver

2024-04-18 Thread Krzysztof Kozlowski
On 18/04/2024 16:01, Johan Adolfsson wrote: > Add generic panel-dsi panel, similar to panel-dpi that can have it's > timing, lanes and flags overridden by devicetree. > Add some dev_err() and dev_warn() calls. > ... > /* sentinel */ > } > @@ -4992,17 +5051,28 @@ static int

Re: [PATCH 2/2] dt-bindings: panel-simple-dsi: Add generic panel-dsi

2024-04-18 Thread Krzysztof Kozlowski
On 18/04/2024 16:01, Johan Adolfsson wrote: > panel-dsi is similar to panel-dpi with overridable timings ??? > > Signed-off-by: Johan Adolfsson > --- > Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git >

Re: [PATCH v1 1/2] dt-bindings: display: panel: Add KD101NE3-40TI support

2024-04-18 Thread Krzysztof Kozlowski
On 18/04/2024 10:15, lvzhaoxiong wrote: > Create a new dt-scheam for the kd101ne3-40ti. There is another thread like this, which is confusing. Please version your patches. patman solves it. b4 as well. Read the guidelines provided to you by Google. > > Signed-off-by: lvzhaoxiong Same comment

Re: [PATCH v1 1/2] dt-bindings: input: i2c-hid: Introduce Ilitek ili2900

2024-04-18 Thread Krzysztof Kozlowski
On 18/04/2024 14:48, lvzhaoxiong wrote: > The ili2900 touch screen chip same as ilitek ili9882t controller > has a reset gpio. > > Signed-off-by: lvzhaoxiong Except that this was not tested, please use full name, not login, if possible. Best regards, Krzysztof

Re: [PATCH v2 0/2] drm/panel: add Khadas TS050 V2 panel support

2024-04-18 Thread Krzysztof Kozlowski
On 18/04/2024 03:14, Jacobe Zang wrote: > Hi Krzysztof, > >> You must say that you ignored/dropped received tags. > > I don't know which tags you mean and where should I fix. Please tell me in > detail.

Re: [PATCH v2 0/2] drm/panel: add Khadas TS050 V2 panel support

2024-04-15 Thread Krzysztof Kozlowski
On 15/04/2024 05:14, Jacobe Zang wrote: > Changes from v1 at [1]: > - Fix name from "newts050" to "ts050v2" > - Add specific description about controller change You must say that you ignored/dropped received tags. Best regards, Krzysztof

Re: [PATCH v2 1/2] dt-bindings: panel-simple-dsi: add Khadas TS050 V2 panel bindings

2024-04-15 Thread Krzysztof Kozlowski
quot; prefix is already stating that these are bindings. See also: https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 Acked-by: Krzysztof Kozlowski --- This is an automated instruction, just in case, because many review tags are being ignore

Re: [PATCH 00/18] backlight: Constify lcd_ops

2024-04-15 Thread Krzysztof Kozlowski
On 15/04/2024 08:56, Thomas Zimmermann wrote: > Hi > > for patches 16, 17 and 18: > > Reviewed-by: Thomas Zimmermann This does not work like this. Toolset will apply your review tag for EVERYTHING. You must provide tag under each individual patch. Best regards, Krzysztof

[PATCH 18/18] fbdev: omap: lcd_ams_delta: Constify lcd_ops

2024-04-14 Thread Krzysztof Kozlowski
'struct lcd_ops' is not modified by core backlight code, so it can be made const for increased code safety. Signed-off-by: Krzysztof Kozlowski --- Depends on the first patch in the series. --- drivers/video/fbdev/omap/lcd_ams_delta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 17/18] fbdev: imx: Constify lcd_ops

2024-04-14 Thread Krzysztof Kozlowski
'struct lcd_ops' is not modified by core backlight code, so it can be made const for increased code safety. Signed-off-by: Krzysztof Kozlowski --- Depends on the first patch in the series. --- drivers/video/fbdev/imxfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 16/18] fbdev: clps711x: Constify lcd_ops

2024-04-14 Thread Krzysztof Kozlowski
'struct lcd_ops' is not modified by core backlight code, so it can be made const for increased code safety. Signed-off-by: Krzysztof Kozlowski --- Depends on the first patch in the series. --- drivers/video/fbdev/clps711x-fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 15/18] HID: picoLCD: Constify lcd_ops

2024-04-14 Thread Krzysztof Kozlowski
'struct lcd_ops' is not modified by core backlight code, so it can be made const for increased code safety. Signed-off-by: Krzysztof Kozlowski --- Depends on the first patch in the series. --- drivers/hid/hid-picolcd_lcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 14/18] backlight: tdo24m: Constify lcd_ops

2024-04-14 Thread Krzysztof Kozlowski
'struct lcd_ops' is not modified by core backlight code, so it can be made const for increased code safety. Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/tdo24m.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/backlight/tdo24m.c b/drivers

[PATCH 13/18] backlight: platform_lcd: Constify lcd_ops

2024-04-14 Thread Krzysztof Kozlowski
'struct lcd_ops' is not modified by core backlight code, so it can be made const for increased code safety. Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/platform_lcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/backlight/platform_lcd.c b

[PATCH 12/18] backlight: otm3225a: Constify lcd_ops

2024-04-14 Thread Krzysztof Kozlowski
'struct lcd_ops' is not modified by core backlight code, so it can be made const for increased code safety. Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/otm3225a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/backlight/otm3225a.c b/drivers

[PATCH 11/18] backlight: ltv350qv: Constify lcd_ops

2024-04-14 Thread Krzysztof Kozlowski
'struct lcd_ops' is not modified by core backlight code, so it can be made const for increased code safety. Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/ltv350qv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/backlight/ltv350qv.c b/drivers

[PATCH 09/18] backlight: lms283gf05: Constify lcd_ops

2024-04-14 Thread Krzysztof Kozlowski
'struct lcd_ops' is not modified by core backlight code, so it can be made const for increased code safety. Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/lms283gf05.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/backlight/lms283gf05.c b

[PATCH 10/18] backlight: lms501kf03: Constify lcd_ops

2024-04-14 Thread Krzysztof Kozlowski
'struct lcd_ops' is not modified by core backlight code, so it can be made const for increased code safety. Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/lms501kf03.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/backlight/lms501kf03.c b

[PATCH 08/18] backlight: l4f00242t03: Constify lcd_ops

2024-04-14 Thread Krzysztof Kozlowski
'struct lcd_ops' is not modified by core backlight code, so it can be made const for increased code safety. Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/l4f00242t03.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/backlight/l4f00242t03.c b

[PATCH 06/18] backlight: ili9320: Constify lcd_ops

2024-04-14 Thread Krzysztof Kozlowski
'struct lcd_ops' is not modified by core backlight code, so it can be made const for increased code safety. Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/ili9320.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/backlight/ili9320.c b/drivers

[PATCH 07/18] backlight: jornada720_lcd: Constify lcd_ops

2024-04-14 Thread Krzysztof Kozlowski
'struct lcd_ops' is not modified by core backlight code, so it can be made const for increased code safety. Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/jornada720_lcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/backlight

[PATCH 05/18] backlight: ili922x: Constify lcd_ops

2024-04-14 Thread Krzysztof Kozlowski
'struct lcd_ops' is not modified by core backlight code, so it can be made const for increased code safety. Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/ili922x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/backlight/ili922x.c b/drivers

[PATCH 04/18] backlight: hx8357: Constify lcd_ops

2024-04-14 Thread Krzysztof Kozlowski
'struct lcd_ops' is not modified by core backlight code, so it can be made const for increased code safety. Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/hx8357.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/backlight/hx8357.c b/drivers

[PATCH 03/18] backlight: corgi_lcd: Constify lcd_ops

2024-04-14 Thread Krzysztof Kozlowski
'struct lcd_ops' is not modified by core backlight code, so it can be made const for increased code safety. Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/corgi_lcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/backlight/corgi_lcd.c b

[PATCH 02/18] backlight: ams369fg06: Constify lcd_ops

2024-04-14 Thread Krzysztof Kozlowski
'struct lcd_ops' is not modified by core backlight code, so it can be made const for increased code safety. Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/ams369fg06.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/backlight/ams369fg06.c b

[PATCH 01/18] backlight: Constify lcd_ops

2024-04-14 Thread Krzysztof Kozlowski
'struct lcd_ops' passed in lcd_device_register() is not modified by core backlight code, so it can be made const for code safety. This allows drivers to also define the structure as const. Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/lcd.c | 4 ++-- include/linux/lcd.h

[PATCH 00/18] backlight: Constify lcd_ops

2024-04-14 Thread Krzysztof Kozlowski
Hi, Dependencies All further patches depend on the first patch. Therefore everything could go via backlight tree (please ack) or via cross-tree pulls. Or whatever maintainer choose, just coordinate this with backlight. Best regards, Krzysztof --- Krzysztof Kozlowski (18

Re: [PATCH 1/2] dt-bindings: display: panel: Add Raydium RM69380

2024-04-14 Thread Krzysztof Kozlowski
On 14/04/2024 17:22, David Wronek wrote: > Raydium RM69380 is a display driver IC used to drive OLED DSI panels. > Add a dt-binding for it. > > Signed-off-by: David Wronek > --- > .../bindings/display/panel/raydium,rm69380.yaml| 94 > ++ > 1 file changed, 94

Re: [PATCH v3 01/18] ASoC: dt-bindings: mediatek,mt8365-afe: Add audio afe document

2024-04-13 Thread Krzysztof Kozlowski
On 10/04/2024 11:29, Alexandre Mergnat wrote: > > > On 09/04/2024 17:46, Krzysztof Kozlowski wrote: >>> +soc { >>> +#address-cells = <2>; >>> +#size-cells = <2>; >>> + >>> +afe@1122 { >&

Re: [PATCH] ARM: dts: bcm2835: Enable 3D rendering through V3D

2024-04-12 Thread Krzysztof Kozlowski
On 12/04/2024 15:25, Maíra Canal wrote: > RPi 0-3 is packed with a GPU that provides 3D rendering capabilities to > the RPi. Currently, the downstream kernel uses an overlay to enable the > GPU and use GPU hardware acceleration. When deploying a mainline kernel > to the RPi 0-3, we end up without

Re: [PATCH v1 1/1] drm/mediatek/dp: The register is written with the parsed DTS SSC value.

2024-04-11 Thread Krzysztof Kozlowski
On 11/04/2024 08:30, LIANKUN YANG (杨连坤) wrote: > On Wed, 2024-04-03 at 16:56 +0200, Krzysztof Kozlowski wrote: >> >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> On 03/04/2024 08:41

Re: [PATCH] MAINTAINERS: adjust DRM DRIVERS FOR EXYNOS after dt-binding conversion

2024-04-11 Thread Krzysztof Kozlowski
cumentation/devicetree/bindings/display/samsung/ and the directory with > the previous txt devicetree bindings, i.e., > Documentation/devicetree/bindings/display/exynos/, has disappeared. > > Adjust the DRM DRIVERS FOR EXYNOS section to this change. This should go via Rob's tree. Revie

Re: [PATCH v1 3/4] dt-bindings: display: panel: Add compatible for IVO t109nw41

2024-04-10 Thread Krzysztof Kozlowski
On 10/04/2024 09:14, Cong Yang wrote: > The IVO t109nw41 is a 11.0" WUXGA TFT LCD panel, which fits in nicely with > the existing panel-boe-tv101wum-nl6 driver. Hence, we add a new compatible > with panel specific config. > > Signed-off-by: Cong Yang > --- >

Re: [PATCH v1 1/4] dt-bindings: display: panel: Add compatible for BOE nv110wum-l60

2024-04-10 Thread Krzysztof Kozlowski
On 10/04/2024 09:14, Cong Yang wrote: > The BOE nv110wum-l60 is a 11.0" WUXGA TFT LCD panel, which fits in nicely > with the existing panel-boe-tv101wum-nl6 driver. Hence, we add a new > compatible with panel specific config. > > Signed-off-by: Cong Yang > --- >

  1   2   3   4   5   6   7   8   9   10   >