[PATCH v7 0/2] Add a Himax HX8837 display controller driver

2021-01-28 Thread Lubomir Rintel
Hi, please take a look at the patches chained to this messages and consider applying them. They add support for the controller that drives the panel on the OLPC XO laptops. Compared to v7, points risen in review by Laurent Pinchart have been addressed. Details in change log of patch 1/2. Tested

[PATCH v7 2/2] drm/bridge: hx8837: add a Himax HX8837 display controller driver

2021-01-28 Thread Lubomir Rintel
: http://wiki.laptop.org/images/0/09/DCON_datasheet_HX8837-A.pdf + * + * Copyright (C) 2020 Lubomir Rintel + */ + +#include +#include +#include +#include +#include + +#include +#include +#include + +#define bridge_to_hx8837_priv(x) \ + container_of(x, struct hx8837_priv, brid

[PATCH v7 1/2] dt-bindings: display: himax, hx8837: Add Himax HX8837 bindings

2021-01-28 Thread Lubomir Rintel
Himax HX8837 is a secondary display controller used to drive the panel on OLPC platforms. Signed-off-by: Lubomir Rintel Reviewed-by: Rob Herring --- Changes since v6: (All based on feedback from Laurent Pinchart) - Add power supplies - Make load/stat-gpios optional - Fix whitespace errors

Re: [PATCH v4 0/3] Generic USB Display driver

2021-01-25 Thread Lubomir Rintel
> easier to understand just from reading the header file. > > Noralf. > > [1] https://github.com/notro/gud/wiki The patch set: Tested-by: Lubomir Rintel Works like a charm with this board [1], though it didn't impress the girls as much as I hoped. Code here [2], picture here [3]. [1]

Re: [PATCH v4 0/3] Generic USB Display driver

2021-01-24 Thread Lubomir Rintel
4362] usb 1-1.2: new full-speed USB device number 6 using mv-ehci [ 42.228048] usb 1-1.2: New USB device found, idVendor=1d50, idProduct=614d, bcdDevice= 1.00 [ 42.236812] usb 1-1.2: New USB device strings: Mfr=1, Product=2, SerialNumber=3 [ 42.254298] usb 1-1.2: Product: LCD Display

[PATCH libdrm 0/3] tests/etnaviv_2d_test: some test improvements

2020-12-02 Thread Lubomir Rintel
Hi, patches chained to this message contains changes I've found useful when testing whether 2d rendering works well with the etnaviv driver on my platform. Perhaps they're useful enough for merging upstream. Thanks Lubo ___ dri-devel mailing list

[PATCH libdrm 2/3] tests/etnaviv_2d_test: pick the 2D core

2020-12-02 Thread Lubomir Rintel
Run the test on a core capable of 2D rendering instead of hardcoding to core zero. Signed-off-by: Lubomir Rintel --- tests/etnaviv/etnaviv_2d_test.c | 31 --- 1 file changed, 24 insertions(+), 7 deletions(-) diff --git a/tests/etnaviv/etnaviv_2d_test.c b/tests

[PATCH libdrm 1/3] tests/etnaviv_2d_test: explain the errors

2020-12-02 Thread Lubomir Rintel
Just so that it's obvious what failed and why. Signed-off-by: Lubomir Rintel --- tests/etnaviv/etnaviv_2d_test.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/tests/etnaviv/etnaviv_2d_test.c b/tests/etnaviv/etnaviv_2d_test.c index 8dd77b66..eb9dfa59

[PATCH libdrm 3/3] tests/etnaviv_2d_test: check whether the rendering is correct

2020-12-02 Thread Lubomir Rintel
writable directory, which is an unsafe thing to do anyway. Signed-off-by: Lubomir Rintel --- tests/etnaviv/etnaviv_2d_test.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/tests/etnaviv/etnaviv_2d_test.c b/tests/etnaviv/etnaviv_2d_test.c index

Re: [PATCH v6 1/2] dt-bindings: display: himax,hx8837: Add Himax HX8837 bindings

2020-11-19 Thread Lubomir Rintel
On Sun, Nov 01, 2020 at 06:39:22PM +0200, Laurent Pinchart wrote: > Hi Lubomir, > > Thank you for the patch. Thanks for the message. Some responses inline below. > On Fri, Oct 30, 2020 at 04:07:59AM +0100, Lubomir Rintel wrote: > > Himax HX8837 is a secondary display contro

Re: [PATCH v6 2/2] drm/bridge: hx8837: add a Himax HX8837 display controller driver

2020-11-01 Thread Lubomir Rintel
Hello Sam, thanks for your response. On Sat, Oct 31, 2020 at 09:01:37AM +0100, Sam Ravnborg wrote: > Hi Lubomir. > > On Fri, Oct 30, 2020 at 04:08:00AM +0100, Lubomir Rintel wrote: > > Himax HX8837 is used to drive the LCD panel on OLPC platforms. > > > > It c

[PATCH v6 1/2] dt-bindings: display: himax, hx8837: Add Himax HX8837 bindings

2020-10-30 Thread Lubomir Rintel
Himax HX8837 is a secondary display controller used to drive the panel on OLPC platforms. Signed-off-by: Lubomir Rintel Reviewed-by: Rob Herring --- Changes since v4: - Rob's Reviewed-by Changes since v3: - Moved to bindings/display/ - Added the ports - Converted to YAML - Removed Pavel's Ack

[PATCH v6 2/2] drm/bridge: hx8837: add a Himax HX8837 display controller driver

2020-10-30 Thread Lubomir Rintel
@ -0,0 +1,330 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * HiMax HX8837 Display Controller Driver + * + * Datasheet: http://wiki.laptop.org/images/0/09/DCON_datasheet_HX8837-A.pdf + * + * Copyright (C) 2020 Lubomir Rintel + */ + +#include +#include +#include +#include +#include

Re: [RESEND PATCH v5 2/2] drm/bridge: hx8837: add a Himax HX8837 display controller driver

2020-10-26 Thread Lubomir Rintel
Hello Sam, On Fri, Oct 16, 2020 at 10:07:34PM +0200, Sam Ravnborg wrote: > Hi Lubomir. > > On Sat, Sep 26, 2020 at 02:07:19AM +0200, Lubomir Rintel wrote: > > Himax HX8837 is used to drive the LCD panel on OLPC platforms. > > > > It controls the panel backlight and

[RESEND PATCH v5 1/2] dt-bindings: display: himax, hx8837: Add Himax HX8837 bindings

2020-09-28 Thread Lubomir Rintel
Himax HX8837 is a secondary display controller used to drive the panel on OLPC platforms. Signed-off-by: Lubomir Rintel Reviewed-by: Rob Herring --- Changes since v4: - Rob's Reviewed-by Changes since v3: - Moved to bindings/display/ - Added the ports - Converted to YAML - Removed Pavel's Ack

[RESEND PATCH v5 0/2] Add a Himax HX8837 display controller driver

2020-09-28 Thread Lubomir Rintel
Hi, please take a look at the patches chained to this messages and consider applying them. They add support for the controller that drives the panel on the OLPC XO laptops. The only change since the previous version is the Reviewed-by tag in DT bindings. Compared to v3 the bindings have been

[RESEND PATCH v5 2/2] drm/bridge: hx8837: add a Himax HX8837 display controller driver

2020-09-28 Thread Lubomir Rintel
Driver + * + * Datasheet: http://wiki.laptop.org/images/0/09/DCON_datasheet_HX8837-A.pdf + * + * Copyright (C) 2020 Lubomir Rintel + */ + +#include +#include +#include + +#include +#include +#include +#include +#include +#include + +#define bridge_to_hx8837_priv(x) \ + container_of

[PATCH v5 0/2] Add a Himax HX8837 display controller driver

2020-09-10 Thread Lubomir Rintel
Hi, please take a look at the patches chained to this messages and consider applying them. They add support for the controller that drives the panel on the OLPC XO laptops. The only change since the previous version is the Reviewed-by tag in DT bindings. Compared to v3 the bindings have been

[PATCH v5 2/2] drm/bridge: hx8837: add a Himax HX8837 display controller driver

2020-09-10 Thread Lubomir Rintel
asheet: http://wiki.laptop.org/images/0/09/DCON_datasheet_HX8837-A.pdf + * + * Copyright (C) 2020 Lubomir Rintel + */ + +#include +#include +#include + +#include +#include +#include +#include +#include +#include + +#define bridge_to_hx8837_priv(x) \ + container_of(x, struct hx8837_priv

[PATCH v5 1/2] dt-bindings: display: himax, hx8837: Add Himax HX8837 bindings

2020-09-10 Thread Lubomir Rintel
Himax HX8837 is a secondary display controller used to drive the panel on OLPC platforms. Signed-off-by: Lubomir Rintel Reviewed-by: Rob Herring --- Changes since v4: - Rob's Reviewed-by Changes since v3: - Moved to bindings/display/ - Added the ports - Converted to YAML - Removed Pavel's Ack

[PATCH v4 0/2] dt-bindings: display: himax,hx8837: Add Himax HX8837 bindings

2020-08-20 Thread Lubomir Rintel
(Re-sending the cover letter here, because I left the subject empty and the archive didn't pick it up. Sorry.) Hi, please take a look at the patches chained to this messages and consider applying them. They add support for the controller that drives the panel on the OLPC XO laptops. Compared to

[PATCH 2/2] drm/panel: simple: Add support for Innolux LS075AT011

2020-08-20 Thread Lubomir Rintel
This adds support for the Innolux LS075AT011 7.5" 1200x900 panel. There's no public data sheet for the panel -- the values have been taken from Open Firmware and the documentation for the display controller that drives the panel and tested on the OLPC laptop. Signed-off-by: Lubomir R

[PATCH v4 2/2] drm/bridge: hx8837: add a Himax HX8837 display controller driver

2020-08-20 Thread Lubomir Rintel
asheet: http://wiki.laptop.org/images/0/09/DCON_datasheet_HX8837-A.pdf + * + * Copyright (C) 2020 Lubomir Rintel + */ + +#include +#include +#include + +#include +#include +#include +#include +#include +#include + +#define bridge_to_hx8837_priv(x) \ + container_of(x, struct hx8837_priv

[PATCH 0/2] drm/panel: Add support for Innolux LS075AT011

2020-08-20 Thread Lubomir Rintel
Hi, Please take a look at the patches chanied to this message and consider applying them. They add description of the display panel found on OLPC laptops to the simple panel driver. There is no datasheet for the hardware and thus the timings were determined on a best effort basis. The clock

Re: [PATCH 2/2] drm/panel: simple: Add Innolux N133HSE panel support

2020-08-20 Thread Lubomir Rintel
On Mon, May 11, 2020 at 09:47:08AM +0200, Sam Ravnborg wrote: > Hi Richard. > > On Sat, May 09, 2020 at 01:18:34PM +0200, s...@48.io wrote: > > From: Sean Cross > > > > The Innolux N133HSE panel is a 13.3" 1920x1080 panel that contains an > > integrated backlight, and connects via eDP. > > > >

[PATCH 1/2] dt-bindings: display: simple: add Innolux LS075AT011

2020-08-20 Thread Lubomir Rintel
Add the Innolux LS075AT011 7.5" (1200x900) color/reflective LCD panel to the panel-simple compatible list. This panel is used in the OLPC laptops. Signed-off-by: Lubomir Rintel --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+)

[PATCH v4 1/2] dt-bindings: display: himax, hx8837: Add Himax HX8837 bindings

2020-08-20 Thread Lubomir Rintel
Himax HX8837 is a secondary display controller used to drive the panel on OLPC platforms. Signed-off-by: Lubomir Rintel --- Changes since v3: - Moved to bindings/display/ - Added the ports - Converted to YAML - Removed Pavel's Ack, because the changes are substantial Changes since v2: - s

Re: [PATCH v3 0/6] Generic USB Display driver

2020-07-16 Thread Lubomir Rintel
On Tue, Jul 14, 2020 at 09:03:14PM +0200, Noralf Trønnes wrote: > > > Den 14.07.2020 19.40, skrev Peter Stuge: > > Hi Noralf, > > > > Noralf Trønnes wrote: > >> I would like to keep the SET_BUFFER request since it will serve as a > >> syncing point between the host and the device. I'm no USB

Re: [PATCH v3 0/6] Generic USB Display driver

2020-07-10 Thread Lubomir Rintel
with a little help from a microcontroller. I've actually had some success doing just that [1]. [1] https://assets.octodon.social/media_attachments/files/009/983/960/original/64ad8ea46c1b06c5.jpg I suppose you can add: Tested-by: Lubomir Rintel I've had to jump through some hoops though. My

Re: [PATCH v5 0/2] mfd: Add ENE KB3930 Embedded Controller driver

2020-06-18 Thread Lubomir Rintel
On Wed, Jun 17, 2020 at 10:58:28AM +0200, Lucas Stach wrote: > Hi Lubomir, > > Am Mittwoch, den 17.06.2020, 00:44 +0200 schrieb Lubomir Rintel: > > Hi, > > > > please consider applying the patches chained to this message. It's the > > fifth version of the d

[PATCH v5 2/2] mfd: ene-kb3930: Add driver for ENE KB3930 Embedded Controller

2020-06-17 Thread Lubomir Rintel
platform, it registers the appropriate cells. Signed-off-by: Lubomir Rintel --- Changes since v3: - Clarify that the power-off function is provided by this driver while LEDS_ARIEL is necessary to drive the leds in Kconfig help text - s/kb3930_power_off/kb3930_pm_power_off/, s/global_kb3930

[RESEND PATCH v2 1/4] drm/etnaviv: Fix error path on failure to enable bus clk

2020-06-17 Thread Lubomir Rintel
Since commit 65f037e8e908 ("drm/etnaviv: add support for slave interface clock") the reg clock is enabled before the bus clock and we need to undo its enablement on error. Fixes: 65f037e8e908 ("drm/etnaviv: add support for slave interface clock") Signed-off-by: Lubomir Rint

[PATCH v5 1/2] dt-bindings: mfd: Add ENE KB3930 Embedded Controller binding

2020-06-17 Thread Lubomir Rintel
Add binding document for the ENE KB3930 Embedded Controller. Signed-off-by: Lubomir Rintel Reviewed-by: Rob Herring --- Changes since v4: - Collected Rob's Reviewed-by Changes since v1: - Addressed binding validation failure .../devicetree/bindings/mfd/ene-kb3930.yaml | 55

[PATCH v5 0/2] mfd: Add ENE KB3930 Embedded Controller driver

2020-06-17 Thread Lubomir Rintel
Hi, please consider applying the patches chained to this message. It's the fifth version of the driver for the ENE KB3930 Embedded Controller. This version is essentially a resend of v4. The only actual change is the addition of the Rob's Reviewed-by tag which I failed to do previously. Detailed

[RESEND PATCH v2 3/4] drm/etnaviv: Make the "core" clock mandatory

2020-06-17 Thread Lubomir Rintel
It is always present. It was documented as mandatory prior to commit 90aeca875f8a ("dt-bindings: display: Convert etnaviv to json-schema"). Signed-off-by: Lubomir Rintel --- Changes since v1: - Add this patch drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 2 +- 1 file changed, 1 inser

[RESEND PATCH v2 2/4] drm/etnaviv: Don't ignore errors on getting clocks

2020-06-17 Thread Lubomir Rintel
mandates the "bus" clock while the dove machine only specifies "core". Signed-off-by: Lubomir Rintel --- Changes since v1: - Fix the actual return value drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/dri

[RESEND PATCH v2 4/4] drm/etnaviv: Simplify clock enable/disable

2020-06-17 Thread Lubomir Rintel
All the NULL checks are pointless, clk_*() routines already deal with NULL just fine. Signed-off-by: Lubomir Rintel --- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 53 ++- 1 file changed, 19 insertions(+), 34 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c

[RESEND PATCH v2 0/4] drm/etnaviv: Tidy up clocks handling

2020-06-17 Thread Lubomir Rintel
Hi, please consider applying patches that are chained to this message. They make getting/enabling the clocks in the etnaviv driver slightly nicer, first two also fix potential problems. Compared to v1, patch 2/4 was fixed and patch 3/4 was added. As it was pointed out in response to v1, the

[PATCH v2 4/4] drm/etnaviv: Simplify clock enable/disable

2020-05-25 Thread Lubomir Rintel
All the NULL checks are pointless, clk_*() routines already deal with NULL just fine. Signed-off-by: Lubomir Rintel --- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 53 ++- 1 file changed, 19 insertions(+), 34 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c

[PATCH v2 1/4] drm/etnaviv: Fix error path on failure to enable bus clk

2020-05-25 Thread Lubomir Rintel
Since commit 65f037e8e908 ("drm/etnaviv: add support for slave interface clock") the reg clock is enabled before the bus clock and we need to undo its enablement on error. Fixes: 65f037e8e908 ("drm/etnaviv: add support for slave interface clock") Signed-off-by: Lubomir Rint

[PATCH v2 0/4] drm/etnaviv: Tidy up clocks handling

2020-05-25 Thread Lubomir Rintel
Hi, please consider applying patches that are chained to this message. They make getting/enabling the clocks in the etnaviv driver slightly nicer, first two also fix potential problems. Compared to v1, patch 2/4 was fixed and patch 3/4 was added. As it was pointed out in response to v1, the

[PATCH v2 3/4] drm/etnaviv: Make the "core" clock mandatory

2020-05-25 Thread Lubomir Rintel
It is always present. It was documented as mandatory prior to commit 90aeca875f8a ("dt-bindings: display: Convert etnaviv to json-schema"). Signed-off-by: Lubomir Rintel --- Changes since v1: - Add this patch --- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 2 +- 1 file changed, 1 inser

[PATCH v2 2/4] drm/etnaviv: Don't ignore errors on getting clocks

2020-05-25 Thread Lubomir Rintel
mandates the "bus" clock while the dove machine only specifies "core". Signed-off-by: Lubomir Rintel --- Changes since v1: - Fix the actual return value --- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/dri

Re: [PATCH 2/3] drm/etnaviv: Don't ignore errors on getting clocks

2020-05-25 Thread Lubomir Rintel
Cc += robh On Wed, May 20, 2020 at 04:04:39PM +0200, Lucas Stach wrote: > Am Mittwoch, den 20.05.2020, 15:38 +0200 schrieb Lubomir Rintel: > > On Thu, May 14, 2020 at 09:53:08AM +0100, Russell King - ARM Linux admin > > wrote: > > > On Thu, May 14, 2020 at 10:40:58AM

Re: [PATCH 2/3] drm/etnaviv: Don't ignore errors on getting clocks

2020-05-22 Thread Lubomir Rintel
On Thu, May 14, 2020 at 09:53:08AM +0100, Russell King - ARM Linux admin wrote: > On Thu, May 14, 2020 at 10:40:58AM +0200, Lucas Stach wrote: > > Am Donnerstag, den 14.05.2020, 09:27 +0100 schrieb Russell King - ARM Linux > > admin: > > > On Thu, May 14, 2020 at 10:18:02AM +0200, Lucas Stach

[PATCH 3/3] drm/etnaviv: Simplify clock enable/disable

2020-05-15 Thread Lubomir Rintel
All the NULL checks are pointless, clk_*() routines already deal with NULL just fine. Signed-off-by: Lubomir Rintel --- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 53 ++- 1 file changed, 19 insertions(+), 34 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c

[PATCH 1/3] drm/etnaviv: Fix error path on failure to enable bus clk

2020-05-15 Thread Lubomir Rintel
Since commit 65f037e8e908 ("drm/etnaviv: add support for slave interface clock") the reg clock is enabled before the bus clock and we need to undo its enablement on error. Fixes: 65f037e8e908 ("drm/etnaviv: add support for slave interface clock") Signed-off-by: Lubomir Rint

[PATCH 2/3] drm/etnaviv: Don't ignore errors on getting clocks

2020-05-15 Thread Lubomir Rintel
There might be good reasons why the getting a clock failed. To treat the clocks as optional we're specifically only interested in ignoring -ENOENT, and devm_clk_get_optional() does just that. Signed-off-by: Lubomir Rintel --- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 16 1 file

[PATCH] drm/etnaviv: Fix the pm_domain lookup

2020-05-15 Thread Lubomir Rintel
res match more than one domain. This tries to remedy it. Tested with kmscube with mesa 20 on ome machine with GC860 and another with GC2000 + GC300 pair. Signed-off-by: Lubomir Rintel --- drivers/gpu/drm/etnaviv/etnaviv_perfmon.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --

[PATCH v5 1/3] dt-bindings: Add vendor prefix for Chrontel, Inc.

2020-04-25 Thread Lubomir Rintel
Chrontel makes encoders for video displays and perhaps other stuff. Their web site is http://www.chrontel.com/. Signed-off-by: Lubomir Rintel Acked-by: Rob Herring --- Changes since v1: - Collect Rob's ack Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2

[PATCH v5 3/3] drm/bridge: chrontel-ch7033: Add a new driver

2020-04-25 Thread Lubomir Rintel
, with VGA as well as DVI. Signed-off-by: Lubomir Rintel --- Changes since v4: - Removed the registration with the component framework and creation of drm_encoder. Changes since v3: - Cosmetic changes; drop ch7033_encoder_destroy() and use drm_encoder_cleanup() for drm_encoder_funcs.destroy callback

[PATCH v5 2/3] dt-bindings: display: Add Chrontel CH7033 Video Encoder binding

2020-04-25 Thread Lubomir Rintel
Add binding document for the Chrontel CH7033 VGA/DVI/HDMI Encoder. Signed-off-by: Lubomir Rintel Reviewed-by: Rob Herring --- Changes since v3: - Fixed the example so that it validates Changes since v1: - Dual licensed with BSD-2-Clause - Collected Rob's reviewed-by tag .../display/bridge

[PATCH v5 0/3] drm: Add support for Chrontel CH7033 VGA/DVI Encoder

2020-04-25 Thread Lubomir Rintel
Hi, chained to this message is another spin of a driver for CH7033. Compared to the previous submission, the integration with device component framework and creation of an encoder on component bind has been removed. This means that until the Armada driver won't work with this driver until it's

Re: [PATCH v4 3/3] drm/bridge: chrontel-ch7033: Add a new driver

2020-04-23 Thread Lubomir Rintel
On Tue, Apr 21, 2020 at 02:54:12PM +0200, Daniel Vetter wrote: > On Tue, Mar 24, 2020 at 04:19:31PM +0100, Lubomir Rintel wrote: > > This is a driver for video encoder with VGA and DVI/HDMI outputs. > > > > There is no documentation for the chip -- the operation was

[RESEND PATCH v4 2/3] dt-bindings: display: Add Chrontel CH7033 Video Encoder binding

2020-04-20 Thread Lubomir Rintel
Add binding document for the Chrontel CH7033 VGA/DVI/HDMI Encoder. Signed-off-by: Lubomir Rintel Reviewed-by: Rob Herring --- Changes since v3: - Fixed the example so that it validates Changes since v1: - Dual licensed with BSD-2-Clause - Collected Rob's reviewed-by tag .../display/bridge

[RESEND PATCH v4 1/3] dt-bindings: Add vendor prefix for Chrontel, Inc.

2020-04-20 Thread Lubomir Rintel
Chrontel makes encoders for video displays and perhaps other stuff. Their web site is http://www.chrontel.com/. Signed-off-by: Lubomir Rintel Acked-by: Rob Herring --- Changes since v1: - Collect Rob's ack Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2

[RESEND PATCH v4 0/3] drm: Add support for Chrontel CH7033 VGA/DVI Encoder

2020-04-20 Thread Lubomir Rintel
Hi, chained to this message is resend of v4 [1] of a driver for CH7033. Please consider enqueing it for 5.8. [1] https://lore.kernel.org/lkml/20200324151931.449985-1-lkund...@v3.sk/ Thanks, Lubo ___ dri-devel mailing list

[RESEND PATCH v4 3/3] drm/bridge: chrontel-ch7033: Add a new driver

2020-04-20 Thread Lubomir Rintel
an encoder on component bind, so that it works with the Armada DRM driver. Tested with a handful of monitors ranging from 1024x768@75 to 1400x1050@60, with VGA as well as DVI. Signed-off-by: Lubomir Rintel --- Changes since v3: - Cosmetic changes; drop ch7033_encoder_destroy() and use

[PATCH v4 0/3] drm: Add support for Chrontel CH7033 VGA/DVI Encoder

2020-03-25 Thread Lubomir Rintel
Hi, chained to this message is another spin of a driver for CH7033. Only cosmetic changes since the previous version [1]. Please take a look. [1] https://lore.kernel.org/lkml/20200314101627.336939-1-lkund...@v3.sk/ Thanks, Lubo ___ dri-devel

[PATCH v4 3/3] drm/bridge: chrontel-ch7033: Add a new driver

2020-03-25 Thread Lubomir Rintel
an encoder on component bind, so that it works with the Armada DRM driver. Tested with a handful of monitors ranging from 1024x768@75 to 1400x1050@60, with VGA as well as DVI. Signed-off-by: Lubomir Rintel --- Changes since v3: - Cosmetic changes; drop ch7033_encoder_destroy() and use

[PATCH v4 2/3] dt-bindings: display: Add Chrontel CH7033 Video Encoder binding

2020-03-25 Thread Lubomir Rintel
Add binding document for the Chrontel CH7033 VGA/DVI/HDMI Encoder. Signed-off-by: Lubomir Rintel Reviewed-by: Rob Herring --- Changes since v3: - Fixed the example so that it validates Changes since v1: - Dual licensed with BSD-2-Clause - Collected Rob's reviewed-by tag .../display/bridge

[PATCH v4 1/3] dt-bindings: Add vendor prefix for Chrontel, Inc.

2020-03-25 Thread Lubomir Rintel
Chrontel makes encoders for video displays and perhaps other stuff. Their web site is http://www.chrontel.com/. Signed-off-by: Lubomir Rintel Acked-by: Rob Herring --- Changes since v1: - Collect Rob's ack Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2

[PATCH v3 3/3] drm/bridge: chrontel-ch7033: Add a new driver

2020-03-15 Thread Lubomir Rintel
an encoder on component bind, so that it works with the Armada DRM driver. Tested with a handful of monitors ranging from 1024x768@75 to 1400x1050@60, with VGA as well as DVI. Signed-off-by: Lubomir Rintel --- Changes since v1: - Sort the includes - Drop a useless model id read - Chain to the bridge

[PATCH v3 1/3] dt-bindings: Add vendor prefix for Chrontel, Inc.

2020-03-15 Thread Lubomir Rintel
Chrontel makes encoders for video displays and perhaps other stuff. Their web site is http://www.chrontel.com/. Signed-off-by: Lubomir Rintel Acked-by: Rob Herring --- Changes since v1: - Collect Rob's ack Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2

[PATCH v3 0/3] drm: Add support for Chrontel CH7033 VGA/DVI Encoder

2020-03-15 Thread Lubomir Rintel
Hi, chained to this message is a driver for CH7033 along with device tree binding docs. I'm hoping that it could perhaps make it into 5.7. Please take a look. The only change compared to the previous submission [1] is the fix in the DT bindings example discovered by the validation tool. [1]

[PATCH v3 2/3] dt-bindings: display: Add Chrontel CH7033 Video Encoder binding

2020-03-15 Thread Lubomir Rintel
Add binding document for the Chrontel CH7033 VGA/DVI/HDMI Encoder. Signed-off-by: Lubomir Rintel Reviewed-by: Rob Herring --- Changes since v3: - Fixed the example so that it validates Changes since v1: - Dual licensed with BSD-2-Clause - Collected Rob's reviewed-by tag .../display/bridge

[RESEND PATCH v2 0/3] Add support for Chrontel CH7033 VGA/DVI Encoder

2020-03-09 Thread Lubomir Rintel
Hi, chained to this message is a driver for CH7033 along with device tree binding docs. I'm hoping that it could perhaps make it into 5.7. Please take a look. Previous submission [1] contained the exact same patches as this one, but at that time they relied on Laurent's omapdrm/bridge/devel

[RESEND PATCH v2 3/3] drm/bridge: chrontel-ch7033: Add a new driver

2020-03-09 Thread Lubomir Rintel
an encoder on component bind, so that it works with the Armada DRM driver. Tested with a handful of monitors ranging from 1024x768@75 to 1400x1050@60, with VGA as well as DVI. Signed-off-by: Lubomir Rintel --- Changes since v1: - Sort the includes - Drop a useless model id read - Chain to the bridge

[RESEND PATCH v2 1/3] dt-bindings: Add vendor prefix for Chrontel, Inc.

2020-03-09 Thread Lubomir Rintel
Chrontel makes encoders for video displays and perhaps other stuff. Their web site is http://www.chrontel.com/. Signed-off-by: Lubomir Rintel Acked-by: Rob Herring --- Changes since v1: - Collect Rob's ack Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2

[RESEND PATCH v2 2/3] dt-bindings: display: Add Chrontel CH7033 Video Encoder binding

2020-03-09 Thread Lubomir Rintel
Add binding document for the Chrontel CH7033 VGA/DVI/HDMI Encoder. Signed-off-by: Lubomir Rintel Reviewed-by: Rob Herring --- Changes since v1: - Dual licensed with BSD-2-Clause - Collected Rob's reviewed-by tag .../display/bridge/chrontel,ch7033.yaml | 86 +++ 1 file

[PATCH v2 3/3] drm/bridge: chrontel-ch7033: Add a new driver

2020-02-24 Thread Lubomir Rintel
an encoder on component bind, so that it works with the Armada DRM driver. Tested with a handful of monitors ranging from 1024x768@75 to 1400x1050@60, with VGA as well as DVI. Signed-off-by: Lubomir Rintel --- Changes since v1: - Sort the includes - Drop a useless model id read - Chain to the bridge

[PATCH v2 1/3] dt-bindings: Add vendor prefix for Chrontel, Inc.

2020-02-24 Thread Lubomir Rintel
Chrontel makes encoders for video displays and perhaps other stuff. Their web site is http://www.chrontel.com/. Signed-off-by: Lubomir Rintel Acked-by: Rob Herring --- Changes since v1: - Collect Rob's ack Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2

[PATCH v2 2/3] dt-bindings: display: Add Chrontel CH7033 Video Encoder binding

2020-02-24 Thread Lubomir Rintel
Add binding document for the Chrontel CH7033 VGA/DVI/HDMI Encoder. Signed-off-by: Lubomir Rintel Reviewed-by: Rob Herring --- Changes since v1: - Dual licensed with BSD-2-Clause - Collected Rob's reviewed-by tag .../display/bridge/chrontel,ch7033.yaml | 86 +++ 1 file

[PATCH v2 0/3] Add support for Chrontel CH7033 VGA/DVI Encoder

2020-02-24 Thread Lubomir Rintel
Hi, chained to this message is a driver for CH7033 along with device tree binding docs. Since the initial submission, issues pointed out in Laurent Pinchart's review [1] were addressed. Details in individual patches' change log. At his suggestion, the driver has been made to use

[PATCH v3 3/3] drm/armada: add mmp2 and mmp3 support

2020-01-12 Thread Lubomir Rintel
index 0..2053da32abea6 --- /dev/null +++ b/drivers/gpu/drm/armada/armada_6x0.c @@ -0,0 +1,178 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (C) 2012 Russell King + * Copyright (C) 2018,2019,2020 Lubomir Rintel + * Largely based on Armada 510 support + * + * This program

[PATCH v3 2/3] drm/armada: optionally enable the peripheral clock

2020-01-12 Thread Lubomir Rintel
It needs to be enabled (at least on MMP2) in order for the register writes to LCDC to work. Signed-off-by: Lubomir Rintel --- drivers/gpu/drm/armada/armada_crtc.c | 7 +++ drivers/gpu/drm/armada/armada_crtc.h | 1 + 2 files changed, 8 insertions(+) diff --git a/drivers/gpu/drm/armada

[PATCH v3 0/3] drm/armada: make it work on MMP2 and MMP3

2020-01-12 Thread Lubomir Rintel
Hi, chained to this message are patches that are necessary to make the Armada DRM driver useful on MMP2 and MMP3. They apply on top of drm-armada-devel. The first two patches were previously sent separately, around a year ago or so. The v2 of the third one previosly only implemented only MMP2

Re: [PATCH 3/3] drm/bridge: chrontel-ch7033: Add a new driver

2020-01-12 Thread Lubomir Rintel
Hello Laurent, On Wed, 2020-01-08 at 17:20 +0200, Laurent Pinchart wrote: > Hi Lubomir, > > Thank you for the patch. > > On Fri, Dec 20, 2019 at 08:49:14AM +0100, Lubomir Rintel wrote: > > This is a driver for video encoder with VGA and DVI/HDMI outputs. > > &g

[PATCH v3 1/3] drm/armada: add bus-width property to the output endpoint

2020-01-12 Thread Lubomir Rintel
This makes it possible to choose a different pixel format for the endpoint. Modelled after what other LCD controllers use, including marvell,pxa2xx-lcdc and atmel,hlcdc-display-controller and perhaps more. Signed-off-by: Lubomir Rintel --- drivers/gpu/drm/armada/armada_crtc.c | 27

[PATCH 2/3] dt-bindings: display: Add Chrontel CH7033 Video Encoder binding

2019-12-23 Thread Lubomir Rintel
Add binding document for the Chrontel CH7033 VGA/DVI/HDMI Encoder. Signed-off-by: Lubomir Rintel --- .../display/bridge/chrontel,ch7033.yaml | 86 +++ 1 file changed, 86 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/chrontel,ch7033

Add support for Chrontel CH7033 VGA/DVI Encoder

2019-12-23 Thread Lubomir Rintel
Hi, chained to this message is a driver for CH7033 along with device tree binding docs. Tested to work well on MMP3-based Dell Wyse 3020, some tweaks might be needed for other configurations. There's not datasheet or programming manual available. Thanks, Lubo

[PATCH 3/3] drm/bridge: chrontel-ch7033: Add a new driver

2019-12-23 Thread Lubomir Rintel
an encoder on component bind, so that it works with the Armada DRM driver. Tested with a handful of monitors ranging from 1024x768@75 to 1400x1050@60, with VGA as well as DVI. Signed-off-by: Lubomir Rintel --- drivers/gpu/drm/bridge/Kconfig | 10 + drivers/gpu/drm/bridge/Makefile

[PATCH 1/3] dt-bindings: Add vendor prefix for Chrontel, Inc.

2019-12-23 Thread Lubomir Rintel
Chrontel makes encoders for video displays and perhaps other stuff. Their web site is http://www.chrontel.com/. Signed-off-by: Lubomir Rintel --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor

Re: [PATCH] pxa168fb: Fix the function used to release some memory in an error handling path

2019-09-02 Thread Lubomir Rintel
the > error handling path of the probe function. > > Also, remove a useless 'PAGE_ALIGN()'. 'info->fix.smem_len' is already > PAGE_ALIGNed. > > Fixes: 638772c7553f ("fb: add support of LCD display controller on pxa168/910 > (base layer)") > Signed-off-by:

[PATCH v4 1/5] dt-bindings: reserved-memory: Add binding for Armada framebuffer

2019-08-28 Thread Lubomir Rintel
This is the binding for memory that is set aside for allocation of Marvell Armada framebuffer objects. Signed-off-by: Lubomir Rintel Reviewed-by: Rob Herring --- Changes since v2: - Collected the Reviewed-by tag Changes since v1: - Moved from bindings/display/armada/ - Removed the marvell

[PATCH v4 5/5] dt-bindings: display: armada: Document bus-width property

2019-08-28 Thread Lubomir Rintel
This makes it possible to choose a different pixel format for the endpoint. Modelled after what other LCD controllers use, including marvell,pxa2xx-lcdc and atmel,hlcdc-display-controller and perhaps more. Signed-off-by: Lubomir Rintel Reviewed-by: Rob Herring --- Changes since v2: - Collected

[PATCH v4 0/5] dt-bindings: improve the Armada DRM bindings

2019-08-28 Thread Lubomir Rintel
Hi, this is the fourth spin of a patch set that aims to complete the Armada DRM binding documentation. The only change from the last version is the addition of Reviewed-by tags. What is documented corresponds to the armada-devel branch of git://git.armlinux.org.uk/~rmk/linux-arm.git with these

[PATCH v4 2/5] dt-bindings: display: armada: Rename the binding doc file

2019-08-28 Thread Lubomir Rintel
Use a more generic name, since it will document more compatible LCD controllers than just that of Dove. Also, there's no point putting it in a separate directory. Signed-off-by: Lubomir Rintel --- Changes since v1: - Choose a better name than armada/marvell-armada-drm.txt, since

[PATCH v4 3/5] dt-bindings: display: armada: Improve the LCDC documentation

2019-08-28 Thread Lubomir Rintel
The port is a child, not a property. And should be accompanied by an example. Plus a pair of cosmetic changes that don't seem to deserve a separate commit. Signed-off-by: Lubomir Rintel Reviewed-by: Rob Herring --- Changes since v3: - Actually collected the Reviewed-by tag Changes since v2

[PATCH v4 4/5] dt-bindings: display: armada: Add more compatible strings

2019-08-28 Thread Lubomir Rintel
There's a generic compatible string and the driver will work on a MMP2 as well, using the same binding. Signed-off-by: Lubomir Rintel Reviewed-by: Rob Herring --- Changes since v3: - Collected Rob's Reviewed-by tag Changes since v2: - Order marvell,armada-lcdc after the model-specific strings

[PATCH] backlight: tdo24m: Switch to SPDX header

2019-06-11 Thread Lubomir Rintel
The original license text had a typo ("publishhed") which would be likely to confuse automated licensing auditing tools. Let's just switch to SPDX instead of fixing the wording. Signed-off-by: Lubomir Rintel --- drivers/video/backlight/tdo24m.c | 5 + 1 file changed, 1 inser

[PATCH] etnaviv: allow building on MMP

2019-04-17 Thread Lubomir Rintel
MMP2 has a GC860 core. Signed-off-by: Lubomir Rintel --- drivers/gpu/drm/etnaviv/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/etnaviv/Kconfig b/drivers/gpu/drm/etnaviv/Kconfig index 041a77e400d4..7616f695270f 100644 --- a/drivers/gpu/drm/etnaviv

Re: [PATCH] etnaviv: allow building on MMP

2019-04-17 Thread Lubomir Rintel
On Tue, 2019-04-16 at 18:01 +0200, Lubomir Rintel wrote: > MMP2 has a GC860 core. > > Signed-off-by: Lubomir Rintel > --- > drivers/gpu/drm/etnaviv/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/etnaviv/Kconfig b/drivers

[PATCH libdrm] tests/util: Add armada-drm driver

2019-03-24 Thread Lubomir Rintel
This makes the test utilities work with the Armada driver without the necessity of using the -M argument. Signed-off-by: Lubomir Rintel --- tests/util/kms.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/util/kms.c b/tests/util/kms.c index 5af8bf20..dd1bbee3 100644 --- a/tests/util

[PATCH v3 3/5] dt-bindings: display: armada: Improve the LCDC documentation

2019-03-21 Thread Lubomir Rintel
The port is a child, not a property. And should be accompanied by an example. Plus a pair of cosmetic changes that don't seem to deserve a separate commit. Signed-off-by: Lubomir Rintel --- Changes since v2: - Collected the Reviewed-by tag Changes since v1: - Minor adjustments to the commit

[PATCH v3 0/5] dt-bindings: improve the Armada DRM bindings

2019-03-21 Thread Lubomir Rintel
Hi, this is the third spin of a patch set that aims to complete the Armada DRM binding documentation. Apart from collecting the Review-by tags, the only change is the order of the compatible strings for the LCDC node. What is documented corresponds to the armada-devel branch of

[PATCH v3 4/5] dt-bindings: display: armada: Add more compatible strings

2019-03-21 Thread Lubomir Rintel
There's a generic compatible string and the driver will work on a MMP2 as well, using the same binding. Signed-off-by: Lubomir Rintel --- Changes since v2: - Order marvell,armada-lcdc after the model-specific strings. Changes since v1: - Added marvell,armada-lcdc compatible string

[PATCH v3 5/5] dt-bindings: display: armada: Document bus-width property

2019-03-21 Thread Lubomir Rintel
This makes it possible to choose a different pixel format for the endpoint. Modelled after what other LCD controllers use, including marvell,pxa2xx-lcdc and atmel,hlcdc-display-controller and perhaps more. Signed-off-by: Lubomir Rintel Reviewed-by: Rob Herring --- Changes since v2: - Collected

[PATCH v3 1/5] dt-bindings: reserved-memory: Add binding for Armada framebuffer

2019-03-21 Thread Lubomir Rintel
This is the binding for memory that is set aside for allocation of Marvell Armada framebuffer objects. Signed-off-by: Lubomir Rintel Reviewed-by: Rob Herring --- Changes since v2: - Collected the Reviewed-by tag Changes since v1: - Moved from bindings/display/armada/ - Removed the marvell

[PATCH v3 2/5] dt-bindings: display: armada: Rename the binding doc file

2019-03-21 Thread Lubomir Rintel
Use a more generic name, since it will document more compatible LCD controllers than just that of Dove. Also, there's no point putting it in a separate directory. Signed-off-by: Lubomir Rintel --- Changes since v1: - Choose a better name than armada/marvell-armada-drm.txt, since

  1   2   >