On Tue, 1 Dec 2020, Mikulas Patocka wrote:
> When I try to run Xorg (from Debian 9) with the kernel 5.10-rc6, it
> doesn't work at all, I get this crash:
I tried to rux Xorg on another machine (with up-to-date Debian ports) and
it didn't crash on unplug.
M
On Mon, 30 Nov 2020, Daniel Vetter wrote:
> On Mon, Nov 30, 2020 at 01:39:17PM -0500, Mikulas Patocka wrote:
> >
> >
> > On Mon, 30 Nov 2020, Daniel Vetter wrote:
> >
> > > On Mon, Nov 30, 2020 at 09:31:15AM -0500, Mikulas Patocka wrote:
> > &g
On Tue, 1 Dec 2020, Thomas Zimmermann wrote:
> Hi
>
> Am 30.11.20 um 19:39 schrieb Mikulas Patocka:
> >
> >
> > On Mon, 30 Nov 2020, Daniel Vetter wrote:
> >
> > > On Mon, Nov 30, 2020 at 09:31:15AM -0500, Mikulas Patocka wrote:
> > >
On Tue, 1 Dec 2020, Thomas Zimmermann wrote:
> Hi
>
> Am 30.11.20 um 15:31 schrieb Mikulas Patocka:
> >
> >
> > On Mon, 30 Nov 2020, Thomas Zimmermann wrote:
> >
> > > Udlfb has been superseded by DRM's udl. The DRM driver is better by
> > &
On Mon, 30 Nov 2020, Daniel Vetter wrote:
> On Mon, Nov 30, 2020 at 09:31:15AM -0500, Mikulas Patocka wrote:
> >
> > The framebuffer driver supports programs running full-screen directly on
> > the framebuffer console, such as web browser "links -g", image vi
On Mon, 30 Nov 2020, Thomas Zimmermann wrote:
> Udlfb has been superseded by DRM's udl. The DRM driver is better by
> any means and actively maintained. Remove udlfb.
Hi
I am using udlfb and it's definitely better than the DRM driver. The DRM
driver will crash the kernel if you unplug the
le(s)
> to. The correct way is to use the con2fb_map lookup table to find the
> framebuffer index.
>
> Fixes: cfafca8067c6 ("fbdev: fbcon: console unregistration from
> unregister_framebuffer")
> Signed-off-by: Noralf Trønnes
> Reviewed-by: Mikulas Patocka
> ---
On Thu, 2 Aug 2018, David Airlie wrote:
>
> I'm pretty sure udlkms handles this already.
>
> Dave.
But it crashes on unplug :-)
Mikulas
> On Wed, Aug 1, 2018 at 11:34 PM, Mikulas Patocka wrote:
>
>
> On Wed, 1 Aug 2018, Geert Uytterhoeven wrote:
915ca ("udlfb: handle unplug properly")
Reviewed-by: Mikulas Patocka
> ---
> drivers/video/fbdev/udlfb.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/video/fbdev/udlfb.c b/drivers/video/fbdev/udlfb.c
> index 070026a7e55a
On Tue, 4 Sep 2018, Daniel Vetter wrote:
> With kms you need logind or someone like that who orchestrates the vt
> switching and makes sure you can read/write other people's stuff.
BTW. I'm just wondering how is this 'master mode' security working at all.
The user start Xserver under the
On Tue, 4 Sep 2018, Daniel Vetter wrote:
> On Tue, Sep 4, 2018 at 7:04 PM, Mikulas Patocka wrote:
> >
> >
> > On Tue, 4 Sep 2018, Daniel Vetter wrote:
> >
> >> On Tue, Sep 4, 2018 at 1:41 AM, Dave Airlie wrote:
> >> >>
> >
On Tue, 4 Sep 2018, Daniel Vetter wrote:
> On Tue, Sep 4, 2018 at 1:41 AM, Dave Airlie wrote:
> >>
> >> I've seen that you dropped this patch:
> >> https://patchwork.kernel.org/patch/10445393/
> >>
> >> Is that patch correct or incorrect? In case it is incorrect, do you have
> >> an idea how
ith debug messages (2018-07-31 08:11:12
> +1000)
>
> ------------
> Mikulas Patocka (7):
> udl-kms: change down_interruptible to down
> udl-kms: handle allocation failure
> udl-kms: fix crash due to uninitialized memory
> udl-kms: avoid division
&g
On Mon, 27 Aug 2018, Ville Syrjälä wrote:
> On Sat, Aug 25, 2018 at 03:51:52PM -0400, Mikulas Patocka wrote:
> > Reading the registers without waiting for engine idle returns
> > unpredictable values. These unpredictable values result in display
> > corruption - if
On Fri, 17 Aug 2018, Mikulas Patocka wrote:
> There's console font corruption when using the mach64 driver in 24bpp
> mode.
>
> In 24bpp mode, the mach64 accelerator is set up for 8-bpp mode (with
> horizontal width and stride multiplied by 3). In this mode, the
> acce
This is a simple optimization for fifo waiting that improves scrolling
performance by 5%. If the queue has more free entries that what we
consume, we can skip the costly register read next time.
Signed-off-by: Mikulas Patocka
---
drivers/video/fbdev/aty/atyfb.h| 12
cares if
HOST_BYTE_ALIGN is set.
DP_PIX_WIDTH is written in the functions atyfb_copyarea and atyfb_fillrect
with the default value and in atyfb_imageblit with the value set according
to the source image data.
Signed-off-by: Mikulas Patocka
Cc: sta...@vger.kernel.org
---
drivers/video/fbdev/aty
If we want to blit full-color image, we
shouldn't use the triple code.
Signed-off-by: Mikulas Patocka
Cc: sta...@vger.kernel.org
---
drivers/video/fbdev/aty/mach64_accel.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Index: linux-stable/drivers/video/f
On Sun, 19 Aug 2018, Ville Syrjälä wrote:
> On Fri, Aug 17, 2018 at 03:15:52PM -0400, Mikulas Patocka wrote:
> > There's console font corruption when using the mach64 driver in 24bpp
> > mode.
> >
> > In 24bpp mode, the mach64 accelerator is set up for 8-bpp mode
On Sun, 19 Aug 2018, Ville Syrjälä wrote:
> On Fri, Aug 17, 2018 at 03:19:37PM -0400, Mikulas Patocka wrote:
> > On Sun Ultra 5, it happens that the dot clock is not set up properly for
> > some videomodes. For example, if we set the videomode "r1024x768x60" in
>
This patch fixes the debugging printks. Use pr_cont, so that the lines are
not broken up. Use printk when starting a new line (a long string of
pr_cont's without any printks causes missing characters in the console
output on sparc).
Signed-off-by: Mikulas Patocka
---
drivers/video/fbdev/aty
he card supports them. However, the
sparc64 firmware may set these extended dividers during boot - and the
mach64 driver detects incorrect dot clock in this case.
This patch makes the driver read the additional divider bit from
PLL_EXT_CNTL and calculate the initial refresh rate properly.
Signed-of
an unaccelerated function cfb_imageblit for color expansion.
Signed-off-by: Mikulas Patocka
Cc: sta...@vger.kernel.org
---
drivers/video/fbdev/aty/mach64_accel.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: linux-stable/drivers/video/fbdev/aty/mach64_accel.c
On Wed, 1 Aug 2018, Geert Uytterhoeven wrote:
> Hi Mikulas,
>
> On Wed, Aug 1, 2018 at 12:59 PM Mikulas Patocka wrote:
> > On Wed, 1 Aug 2018, Geert Uytterhoeven wrote:
> > > On Tue, Jul 31, 2018 at 5:23 PM Mikulas Patocka
> > > wrote:
> > > >
On Wed, 1 Aug 2018, Geert Uytterhoeven wrote:
> Hi Mikulas,
>
> On Tue, Jul 31, 2018 at 5:23 PM Mikulas Patocka wrote:
> > BTW when using the udlfb driver as a console, I've got this warning.
> > vt_console_print takes a spinlock and then calls the framebuffer d
BTW when using the udlfb driver as a console, I've got this warning.
vt_console_print takes a spinlock and then calls the framebuffer driver
that sleeps.
The question is - whose fault is this? Could the console code somehow be
told to print characters without holding a spinlock? Or does it
us.
Signed-off-by: Mikulas Patocka
---
drivers/video/fbdev/udlfb.c | 141 +++-
include/video/udlfb.h |3
2 files changed, 37 insertions(+), 107 deletions(-)
Index: linux-4.17.10/drivers/video/fbdev/udlf
On Wed, 25 Jul 2018, Bartlomiej Zolnierkiewicz wrote:
> > Can unregister_framebuffer() be called when /dev/fb0 is open as a file
> > handle and/or mapped to some process?
>
> It should be OK.
>
> > > Moreover the dlfb <-> fb_info locking scheme seems to be reversed
> > > (+racy) as it is
if (con2fb_map[i] != idx &&
> con2fb_map[i] != -1) {
> - new_idx = i;
> + new_idx = con2fb_map[i];
> break;
> }
> }
Reviewed-by: Mikulas Patocka
Yes - that's a good point. i is virtu
On Wed, 4 Jul 2018, Bartlomiej Zolnierkiewicz wrote:
> On Tuesday, July 03, 2018 01:18:57 PM Mikulas Patocka wrote:
> >
> > On Tue, 3 Jul 2018, Bartlomiej Zolnierkiewicz wrote:
> >
> > > Hi,
> > >
> > > On Sunday, June 03, 2018 11:46:29 AM Mik
On Wed, 4 Jul 2018, Daniel Vetter wrote:
> On Sun, Jun 03, 2018 at 11:46:29AM -0400, Mikulas Patocka wrote:
> > I have a USB display adapter using the udlfb driver and I use it on an ARM
> > board that doesn't have any graphics card. When I plug the adapter in, the
> >
On Tue, 3 Jul 2018, Bartlomiej Zolnierkiewicz wrote:
>
> Hi,
>
> On Sunday, June 03, 2018 11:46:29 AM Mikulas Patocka wrote:
> > I have a USB display adapter using the udlfb driver and I use it on an ARM
> > board that doesn't have any graphics card.
please drop us a note to
> help improve the system]
>
> url:
> https://github.com/0day-ci/linux/commits/Mikulas-Patocka/USB-DisplayLink-patches/20180603-233013
What is it really complaining about? That URL shows 404 Not Found and this
email has no warnings at all.
> base: g
On Wed, 6 Jun 2018, Alexey Brodkin wrote:
> Hi Mikulas,
>
> On Tue, 2018-06-05 at 11:30 -0400, Mikulas Patocka wrote:
> >
> > On Tue, 5 Jun 2018, Alexey Brodkin wrote:
> >
> > > Hi Mikulas,
> > >
> > > On Sun, 2018-06-03 at 16:41 +0200
On Tue, 5 Jun 2018, Alexey Brodkin wrote:
> Hi Mikulas,
>
> On Sun, 2018-06-03 at 16:40 +0200, Mikulas Patocka wrote:
> > Hi
> >
> > Here I'm sending bug fixes and performance improvements for the USB
> > DisplayLink framebuffer and modesett
On Tue, 5 Jun 2018, Alexey Brodkin wrote:
> Hi Mikulas,
>
> On Sun, 2018-06-03 at 16:41 +0200, Mikulas Patocka wrote:
> > Modern processors can detect linear memory accesses and prefetch data
> > automatically, so there's no need to use prefetch.
>
> Not each a
On Mon, 4 Jun 2018, Dave Airlie wrote:
> On 4 June 2018 at 00:40, Mikulas Patocka wrote:
> > Hi
> >
> > Here I'm sending bug fixes and performance improvements for the USB
> > DisplayLink framebuffer and modesetting drivers for this merge window.
> >
>
&
do_unregister_framebuffer to
a function unbind_console. When the console is unbound, the reference
count drops to zero and the udlfb driver frees the framebuffer. When the
adapter is plugged back, a new framebuffer is created and the console is
attached to it.
Signed-off-by: Mikulas Patocka
Cc: sta...@vger.kernel.org
The udl kms driver writes messages to the syslog whenever some application
opens or closes /dev/fb0 and whenever the user switches between the
Xserver and the console.
This patch changes the priority of these messages to debug.
Signed-off-by: Mikulas Patocka
---
drivers/gpu/drm/udl/udl_fb.c
and
this results in temporary screen corruption.
This patch fixes the screen corruption by always appending a byte 0xAF at
the end of URB. It also removes the uninitialized byte.
Signed-off-by: Mikulas Patocka
Cc: sta...@vger.kernel.org
---
drivers/video/fbdev/udlfb.c | 30
between memcpy and the rendering command).
We must make sure that we copy exactly the same pixel as the pixel that is
being rendered.
Signed-off-by: Mikulas Patocka
---
drivers/video/fbdev/udlfb.c | 45 +---
1 file changed, 34 insertions(+), 11 deletions
ivate" field and the "FB_VMODE_SMOOTH_XPAN" flag when
comparing the videomode, because they cause spurious switches when
switching to and from the Xserver.
Signed-off-by: Mikulas Patocka
Cc: sta...@vger.kernel.org
---
drivers/video/fbdev/udlfb.c | 18 --
i
.
Signed-off-by: Mikulas Patocka
---
drivers/video/fbdev/udlfb.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
Index: linux-4.17-rc7/drivers/video/fbdev/udlfb.c
===
--- linux-4.17-rc7.orig/drivers/video/fbdev
ure to a device-local memory.
Signed-off-by: Mikulas Patocka
Cc: sta...@vger.kernel.org
---
drivers/video/fbdev/udlfb.c |3 ++-
include/video/udlfb.h |1 +
2 files changed, 3 insertions(+), 1 deletion(-)
Index: linux-4.17-rc7/drivers/video/fbdev/udlf
0x340/0x568
kthread+0x118/0x120
ret_from_fork+0x10/0x18
Code: d2804002 f85e02e0 f85e02ec f9000461 (f923)
---[ end trace f9f3ad3856cb2ef3 ]---
note: kswapd0[39] exited with preempt_count 1
Signed-off-by: Mikulas Patocka
Cc: sta...@vger.kernel.org
---
drivers/gpu/drm/udl/udl_gem.c | 31 +++
Allocations larger than PAGE_ALLOC_COSTLY_ORDER are unreliable and they
may fail anytime. This patch fixes the udlfb driver so that when a large
alloactions fails, it tries to do multiple smaller allocations.
Signed-off-by: Mikulas Patocka
Cc: sta...@vger.kernel.org
---
drivers/video/fbdev
4ms, so that the video is played
without any frame skips.
This patch changes the delay to this value.
Signed-off-by: Mikulas Patocka
Cc: sta...@vger.kernel.org
---
include/video/udlfb.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-4.17-rc7/include/video/udlfb.h
Hi
Here I'm sending bug fixes and performance improvements for the USB
DisplayLink framebuffer and modesetting drivers for this merge window.
Mikulas
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
If we leave urbs around, it causes not only leak, but also memory
corruption. This patch fixes the function udl_free_urb_list, so that it
always waits for all urbs that are in progress.
Signed-off-by: Mikulas Patocka
Cc: sta...@vger.kernel.org
---
drivers/gpu/drm/udl/udl_main.c |7
Division is slow, so it shouldn't be done by the pixel generating code.
The driver supports only 2 or 4 bytes per pixel, so we can replace
division with a shift.
Signed-off-by: Mikulas Patocka
Cc: sta...@vger.kernel.org
---
drivers/gpu/drm/udl/udl_drv.h |2 -
drivers/gpu/drm/udl
Allocations larger than PAGE_ALLOC_COSTLY_ORDER are unreliable and they
may fail anytime. This patch fixes the udl kms driver so that when a large
alloactions fails, it tries to do multiple smaller allocations.
Signed-off-by: Mikulas Patocka
Cc: sta...@vger.kernel.org
---
drivers/gpu/drm/udl
Set the variable "line_length" in the function dlfb_ops_set_par. Without
this, we get garbage if we select different videomode with fbset.
Signed-off-by: Mikulas Patocka
Cc: sta...@vger.kernel.org
---
drivers/video/fbdev/udlfb.c |1 +
1 file changed, 1 insertion(+)
Index: linu
Modern processors can detect linear memory accesses and prefetch data
automatically, so there's no need to use prefetch.
Signed-off-by: Mikulas Patocka
---
drivers/gpu/drm/udl/udl_transfer.c |7 ---
1 file changed, 7 deletions(-)
Index: linux-4.16.12/drivers/gpu/drm/udl/udl_transfer.c
ure to a device-local memory.
Signed-off-by: Mikulas Patocka
Cc: sta...@vger.kernel.org
---
drivers/gpu/drm/udl/udl_fb.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Index: linux-4.17-rc7/drivers/gpu/drm/udl/udl_f
Modern processors can detect linear memory accesses and prefetch data
automatically, so there's no need to use prefetch.
Signed-off-by: Mikulas Patocka
---
drivers/video/fbdev/udlfb.c |8
1 file changed, 8 deletions(-)
Index: linux-4.17-rc7/drivers/video/fbdev/udlfb.c
.
Signed-off-by: Mikulas Patocka
---
drivers/gpu/drm/udl/udl_main.c| 10 --
drivers/gpu/drm/udl/udl_modeset.c |5 ++---
2 files changed, 6 insertions(+), 9 deletions(-)
Index: linux-4.16.12/drivers/gpu/drm/udl/udl_main.c
is attached.
Note that there is no reliable way to prevent the system from touching the
old framebuffer, so we must not free it. We add it to the list
dlfb->deferred_free and free it when the driver is unloaded.
Signed-off-by: Mikulas Patocka
---
drivers/video/fbdev/udlfb.c |
We must use kzalloc when allocating the fb_deferred_io structure.
Otherwise, the field first_io is undefined and it causes a crash.
Signed-off-by: Mikulas Patocka
Cc: sta...@vger.kernel.org
---
drivers/gpu/drm/udl/udl_fb.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux
and
this results in temporary screen corruption.
This patch fixes the screen corruption by always appending a byte 0xAF at
the end of URB. It also removes the uninitialized byte.
Signed-off-by: Mikulas Patocka
Cc: sta...@vger.kernel.org
---
drivers/gpu/drm/udl/udl_fb.c |5 -
drivers
ges
"down_interruptible" to "down" in dlfb_free_urb_list, so that we will
clean up the driver properly even if a signal arrives.
With this patch, the performance of udlfb no longer degrades.
Signed-off-by: Mikulas Patocka
Cc: sta...@vger.kernel.org
---
drivers/video/fbdev/udlfb
->height, 32) >> 5", that is just 8 words - this is incorrect and it
causes display corruption.
This patch adds the necesary padding of lines to 8 bytes.
This patch should be backported to stable kernels where f045f459d925 was
backported.
Signed-off-by: Mikulas Patocka
Fixes: f045f459d
On Mon, 24 Mar 2014, Daniel Vetter wrote:
> >> Like I've said the entire teardown sequence for legacy drm drivers is
> >> terminally busted, so the only hope we have is to reapply this missing
> >> duct-tape which made your X crash. But if that itself isn't a regression
> >> there's no way to
On Mon, 24 Mar 2014, Daniel Vetter wrote:
> On Mon, Mar 24, 2014 at 01:17:12PM -0400, Mikulas Patocka wrote:
> > > > > Hmm, given that Mikulas in
> > > > > https://lkml.org/lkml/2014/2/26/537
> > > > > offered a diff of linux-3.13.5 f
On Mon, 24 Mar 2014, Daniel Vetter wrote:
> On Mon, Mar 24, 2014 at 07:45:47AM +1000, Dave Airlie wrote:
> > On Mon, Mar 24, 2014 at 7:27 AM, Andreas Mohr wrote:
> > > On Sun, Mar 23, 2014 at 09:39:16AM -0700, Linus Torvalds wrote:
> > >> On Sun, Mar 23, 2014 at 5:15 AM, Andreas Mohr wrote:
>
Hi
I'm getting a reproducible crash in kernel MGA DRM driver.
The crash happens in the following way:
drm_release is called
drm_release calls drm_master_put(_priv->master);
drm_master_put drops a reference and calls drm_master_destroy
drm_master_destroy calls drm_rmmap_locked to unmap the
65 matches
Mail list logo
