of the error in the
log messages.
Signed-off-by: Nícolas F. R. A. Prado
---
Changes in v2:
- Converted all dev_err() in probe functions to dev_err_probe() instead
of just the ones in the component_add() error path
- Link to v1:
https://lore.kernel.org/r/20240605-mtk-disp-rdma-dev-err-probe-v1-1
On Thu, May 16, 2024 at 10:11:01AM +0200, AngeloGioacchino Del Regno wrote:
> Changes in v4:
> - Fixed a typo that caused pure OF graphs pipelines multiple
>concurrent outputs to not get correctly parsed (port->id);
> - Added OVL_ADAPTOR support for OF graph specified pipelines;
> - Now
update them
all.
Signed-off-by: Nícolas F. R. A. Prado
---
drivers/gpu/drm/mediatek/mtk_disp_aal.c | 2 +-
drivers/gpu/drm/mediatek/mtk_disp_ccorr.c | 2 +-
drivers/gpu/drm/mediatek/mtk_disp_color.c | 2 +-
drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 2 +-
drivers/gpu/drm
-by: Abhinav Kumar
Reviewed-by: AngeloGioacchino Del Regno
Reviewed-by: Neil Armstrong
Reviewed-by: Laurent Pinchart
Signed-off-by: Nícolas F. R. A. Prado
---
drivers/gpu/drm/panel/panel-truly-nt35597.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm
message so that it's only printed
when the devm_mipi_dsi_attach() call fails.
Fixes: 6352cd451ddb ("drm: bridge: Add TI DLPC3433 DSI to DMD bridge")
Suggested-by: AngeloGioacchino Del Regno
Reviewed-by: AngeloGioacchino Del Regno
Reviewed-by: Laurent Pinchart
Signed-off-by: Ní
river for Novatek NT35950 DSI DriverIC
panels")
Suggested-by: AngeloGioacchino Del Regno
Reviewed-by: Laurent Pinchart
Signed-off-by: Nícolas F. R. A. Prado
---
drivers/gpu/drm/panel/panel-novatek-nt35950.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/p
5 DSI/LVDS driver")
Suggested-by: AngeloGioacchino Del Regno
Reviewed-by: AngeloGioacchino Del Regno
Reviewed-by: Laurent Pinchart
Signed-off-by: Nícolas F. R. A. Prado
---
drivers/gpu/drm/bridge/tc358775.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drive
pport for lontium LT9611UXC bridge")
Suggested-by: AngeloGioacchino Del Regno
Reviewed-by: AngeloGioacchino Del Regno
Reviewed-by: Laurent Pinchart
Signed-off-by: Nícolas F. R. A. Prado
---
drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
1 DSI to HDMI bridge")
Suggested-by: AngeloGioacchino Del Regno
Reviewed-by: AngeloGioacchino Del Regno
Reviewed-by: Laurent Pinchart
Signed-off-by: Nícolas F. R. A. Prado
---
drivers/gpu/drm/bridge/lontium-lt9611.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git
8912B DSI to HDMI bridge")
Suggested-by: AngeloGioacchino Del Regno
Reviewed-by: AngeloGioacchino Del Regno
Reviewed-by: Laurent Pinchart
Signed-off-by: Nícolas F. R. A. Prado
---
drivers/gpu/drm/bridge/lontium-lt8912b.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
d I2C configuration support")
Suggested-by: AngeloGioacchino Del Regno
Reviewed-by: AngeloGioacchino Del Regno
Reviewed-by: Laurent Pinchart
Signed-off-by: Nícolas F. R. A. Prado
---
drivers/gpu/drm/bridge/chipone-icn6211.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
driver
- Link to v1:
https://lore.kernel.org/r/20240226-anx7625-defer-log-no-dsi-host-v1-1-242b1af31...@collabora.com
---
Nícolas F. R. A. Prado (9):
drm/bridge: anx7625: Don't log an error when DSI host can't be found
drm/bridge: icn6211: Don't log an error when DSI host can't be fo
eturn -EPROBE_DEFER if the dsi host
was not found")
Reviewed-by: AngeloGioacchino Del Regno
Reviewed-by: Neil Armstrong
Reviewed-by: Laurent Pinchart
Signed-off-by: Nícolas F. R. A. Prado
---
drivers/gpu/drm/bridge/analogix/anx7625.c | 6 ++
1 file changed, 2 insertions(+), 4 deletion
On Thu, Mar 21, 2024 at 02:08:59AM +0800, Chen-Yu Tsai wrote:
> On Thu, Mar 21, 2024 at 1:59 AM Nícolas F. R. A. Prado
> wrote:
> >
> > On Wed, Mar 20, 2024 at 04:19:51PM +0100, Maxime Ripard wrote:
> > > Hi,
> > >
> > > On Wed, Mar 20, 2024 at 1
On Wed, Mar 20, 2024 at 04:19:51PM +0100, Maxime Ripard wrote:
> Hi,
>
> On Wed, Mar 20, 2024 at 11:07:34AM -0400, Nícolas F. R. A. Prado wrote:
> > I noticed that there are some commits from drm-misc-next [1] that haven't
> > been
> > added to the for-linux-next [
Hi,
I noticed that there are some commits from drm-misc-next [1] that haven't been
added to the for-linux-next [2] branch, and consequently haven't made their way
into linux-next.
Namely, commit bf0390e2c95b ("drm/panel: add samsung s6e3fa7 panel driver") and
commit 2689b33b8864 ("dt-bindings:
On Fri, Mar 01, 2024 at 09:44:51AM +0100, AngeloGioacchino Del Regno wrote:
> Il 01/03/24 01:12, Nícolas F. R. A. Prado ha scritto:
> > Given that failing to find a DSI host causes the driver to defer probe,
> > make use of dev_err_probe() to log the reason. This makes the defer
&
On Fri, Mar 01, 2024 at 08:34:31AM +0200, Laurent Pinchart wrote:
> Hi Nícolas,
>
> On Thu, Feb 29, 2024 at 07:12:06PM -0500, Nícolas F. R. A. Prado wrote:
> > This series changes every occurence of the following pattern:
> >
> > dsi_host = of_fin
-by: Nícolas F. R. A. Prado
---
drivers/gpu/drm/panel/panel-truly-nt35597.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-truly-nt35597.c
b/drivers/gpu/drm/panel/panel-truly-nt35597.c
index b73448cf349d..d447db912a61 100644
--- a/drivers/gpu
river for Novatek NT35950 DSI DriverIC
panels")
Suggested-by: AngeloGioacchino Del Regno
Signed-off-by: Nícolas F. R. A. Prado
---
drivers/gpu/drm/panel/panel-novatek-nt35950.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-novatek-nt35950.c
b/d
message so that it's only printed
when the devm_mipi_dsi_attach() call fails.
Fixes: 6352cd451ddb ("drm: bridge: Add TI DLPC3433 DSI to DMD bridge")
Suggested-by: AngeloGioacchino Del Regno
Signed-off-by: Nícolas F. R. A. Prado
---
drivers/gpu/drm/bridge/ti-dlpc3433.c | 17 +---
5 DSI/LVDS driver")
Suggested-by: AngeloGioacchino Del Regno
Signed-off-by: Nícolas F. R. A. Prado
---
drivers/gpu/drm/bridge/tc358775.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/bridge/tc358775.c
b/drivers/gpu/drm/bridge/tc358775.c
index 90
pport for lontium LT9611UXC bridge")
Suggested-by: AngeloGioacchino Del Regno
Signed-off-by: Nícolas F. R. A. Prado
---
drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
b/drivers/gpu/
1 DSI to HDMI bridge")
Suggested-by: AngeloGioacchino Del Regno
Signed-off-by: Nícolas F. R. A. Prado
---
drivers/gpu/drm/bridge/lontium-lt9611.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c
b/drivers/gpu/drm/bridge/lont
8912B DSI to HDMI bridge")
Suggested-by: AngeloGioacchino Del Regno
Signed-off-by: Nícolas F. R. A. Prado
---
drivers/gpu/drm/bridge/lontium-lt8912b.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/bridge/lontium-lt8912b.c
b/drivers/gpu/drm/brid
d I2C configuration support")
Suggested-by: AngeloGioacchino Del Regno
Signed-off-by: Nícolas F. R. A. Prado
---
drivers/gpu/drm/bridge/chipone-icn6211.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c
b/drivers/gpu/drm/brid
eturn -EPROBE_DEFER if the dsi host
was not found")
Reviewed-by: AngeloGioacchino Del Regno
Reviewed-by: Neil Armstrong
Signed-off-by: Nícolas F. R. A. Prado
---
drivers/gpu/drm/bridge/analogix/anx7625.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/
e() helper.
Changes in v2:
- Added patches 2 onwards to fix all occurences of this pattern instead
of just for the anx7625 driver
- Link to v1:
https://lore.kernel.org/r/20240226-anx7625-defer-log-no-dsi-host-v1-1-242b1af31...@collabora.com
---
Nícolas F. R. A. Prado (9):
drm/bridge: anx7625
eturn -EPROBE_DEFER if the dsi host
was not found")
Signed-off-by: Nícolas F. R. A. Prado
---
drivers/gpu/drm/bridge/analogix/anx7625.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c
b/drivers/gpu/drm/bridge/analogix/anx76
as a module.
Suggested-by: AngeloGioacchino Del Regno
Fixes: f70ac097a2cf ("drm/mediatek: Add MT8195 Embedded DisplayPort driver")
Signed-off-by: Nícolas F. R. A. Prado
Reviewed-by: AngeloGioacchino Del Regno
---
Changes in v2:
- Added missing Suggested-by tag
drivers/gpu/drm/mediate
On Tue, Nov 21, 2023 at 11:59:14AM +0100, AngeloGioacchino Del Regno wrote:
> Il 20/11/23 21:28, Nícolas F. R. A. Prado ha scritto:
> > The mtk_dp driver registers a phy device which is handled by the
> > phy_mtk_dp driver and assumes that the phy probe will complete
> > sync
as a module.
Fixes: f70ac097a2cf ("drm/mediatek: Add MT8195 Embedded DisplayPort driver")
Signed-off-by: Nícolas F. R. A. Prado
---
drivers/gpu/drm/mediatek/mtk_dp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c
b/drivers/gpu/drm/mediatek/mtk_
; for device driver data) for just a few bits.
>
> This commit brings no functional changes.
>
> Signed-off-by: AngeloGioacchino Del Regno
>
Reviewed-by: Nícolas F. R. A. Prado
Thanks,
Nícolas
On Fri, Aug 04, 2023 at 09:28:42AM +0200, AngeloGioacchino Del Regno wrote:
> In preparation for adding a 12-bits gamma support for the DISP_GAMMA
> IP, remove the mtk_gamma_set_common() function and move the relevant
> bits in mtk_gamma_set() for DISP_GAMMA and mtk_aal_gamma_set() for
> DISP_AAL:
On Fri, Aug 04, 2023 at 09:28:41AM +0200, AngeloGioacchino Del Regno wrote:
> Make the code more robust and improve readability by using bitfield
> macros instead of open coding bit operations.
>
> Signed-off-by: AngeloGioacchino Del Regno
>
Reviewed-by: Nícolas F. R. A.
_in_ddp(dev,
> priv_n->data->main_path,
> + priv_n->data->main_len,
> + priv_n->ddp_comp))
My only nit is that you're sometimes using data, sometimes using priv_n->data.
Just us
On Tue, Aug 29, 2023 at 03:30:24PM +0200, Michael Walle wrote:
> Hi Nícolas,
>
> > > But the real reason I've enabled it was because I'll get an kernel
> > > oops otherwise. I thought it might be some quirk that you'll need
> > > both,
> > > because eDP will register even if theres no display -
647676 ("drm/mediatek: dpi/dsi: Change the getting possible_crtc
> way")
> Suggested-by: Nícolas F. R. A. Prado
> Signed-off-by: Michael Walle
> ---
> drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 41 ++---
> 1 file changed, 27 insertions(+),
ixes: 0d9eee9118b7 ("drm/mediatek: Add drm ovl_adaptor sub driver for
> MT8195")
> Signed-off-by: Michael Walle
There's also a typo in the commit subject: mediathek -> mediatek. But
regardless,
Reviewed-by: Nícolas F. R. A. Prado
Tested-by: Nícolas F. R. A. Prado
(tested th
On Fri, Aug 25, 2023 at 05:42:59PM +0200, Michael Walle wrote:
> Hi Nicolas,
>
> > > > For the eDP case we can support using aux-bus on MediaTek DP: this
> > > > gives us the possibility to declare our panel as generic "panel-edp"
> > > > which will automatically configure the timings and
Hi,
On Fri, Aug 25, 2023 at 02:01:09PM +0200, Michael Walle wrote:
> Hi AngeloGioacchino,
>
> > For the eDP case we can support using aux-bus on MediaTek DP: this
> > gives us the possibility to declare our panel as generic "panel-edp"
> > which will automatically configure the timings and
On Tue, Apr 04, 2023 at 12:48:00PM +0200, AngeloGioacchino Del Regno wrote:
> For the eDP case we can support using aux-bus on MediaTek DP: this
> gives us the possibility to declare our panel as generic "panel-edp"
> which will automatically configure the timings and available modes
> via the
On Tue, Apr 04, 2023 at 12:48:00PM +0200, AngeloGioacchino Del Regno wrote:
> For the eDP case we can support using aux-bus on MediaTek DP: this
> gives us the possibility to declare our panel as generic "panel-edp"
> which will automatically configure the timings and available modes
> via the
n -EPROBE_DEFER if the dsi host
was not found")
Reported-by: "kernelci.org bot"
Signed-off-by: Nícolas F. R. A. Prado
---
drivers/gpu/drm/bridge/analogix/anx7625.c | 128 +++---
1 file changed, 88 insertions(+), 40 deletions(-)
diff --git a/drivers/gpu/drm/bridge/analogi
On Sat, Feb 04, 2023 at 09:30:37PM +0800, Pin-yen Lin wrote:
[..]
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
[..]
> +static void anx7625_set_crosspoint_switch(struct anx7625_data *ctx,
> + enum
Hi,
On Mon, Jan 16, 2023 at 03:22:34PM +0800, Chen-Yu Tsai wrote:
> The device lock is used to serialize the low level power sequencing
> operations. Since drm_helper_hpd_irq_event() could end up calling
> .atomic_enable, which also calls power sequencing functions through
> runtime PM, this
Fixes: 27f26359de9b ("drm/bridge: anx7625: Set downstream sink into normal
> status")
> Signed-off-by: Chen-Yu Tsai
Reviewed-by: Nícolas F. R. A. Prado
In the same way, 0x68028 should be switched for DP_AUX_HDCP_BCAPS and 0x01 for
DP_BCAPS_HDCP_CAPABLE, though those aren't part of
On Fri, Jan 13, 2023 at 03:25:46AM +, Yunfei Dong (董云飞) wrote:
> Hi Nicolas,
>
> Thanks for your information.
> On Thu, 2023-01-12 at 15:58 -0500, Nícolas F. R. A. Prado wrote:
> > On Wed, May 18, 2022 at 08:30:02PM +0800, Yunfei Dong wrote:
> > > Vp8 need to use
On Wed, May 18, 2022 at 08:30:02PM +0800, Yunfei Dong wrote:
> Vp8 need to use MM21, but vp9 and h264 need to use HyFbc mode
> for mt8195. Vp8/vp9/h264 use the same MM21 format for mt8192.
Hi Yunfei,
why do VP9 and H264 need to use HyFbc (is this the same as MT21C?) mode on
MT8195? The SCP
by: AngeloGioacchino Del Regno
>
> Tested-by: Bo-Chen Chen
> Tested-by: Nícolas F. R. A. Prado
> ---
[..]
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> index 30dcb65d8a5a..ce5617ad04cb 100644
> --- a/drivers/gpu/drm
On Wed, Nov 23, 2022 at 10:15:25AM +0100, AngeloGioacchino Del Regno wrote:
> Il 22/11/22 15:39, Nícolas F. R. A. Prado ha scritto:
> > mtk_drm_bind() can fail, in which case drm_dev_put() is called,
> > destroying the drm_device object. However a pointer to it was still
in a panic. Clean the pointer when destroying the
object in the error path to prevent this from happening.
Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.")
Signed-off-by: Nícolas F. R. A. Prado
---
Changes in v2:
- Added Fixes tag
drivers/gpu/drm/mediatek/mtk_drm
in a panic. Clean the pointer when destroying the
object in the error path to prevent this from happening.
Signed-off-by: Nícolas F. R. A. Prado
---
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
b/drivers/gpu/drm
y: CK Hu
> > Tested-by: AngeloGioacchino Del Regno
> >
> > Tested-by: Bo-Chen Chen
> > Reviewed-by: Nícolas F. R. A. Prado
> > ---
> > drivers/soc/mediatek/mtk-mmsys.c | 45
> > 1 file changed, 16 insertions(+), 29
On Tue, Nov 08, 2022 at 06:46:54PM +0100, Matthias Brugger wrote:
> On 07/11/2022 08:22, Nancy.Lin wrote:
[..]
> > --- a/drivers/soc/mediatek/mtk-mmsys.c
> > +++ b/drivers/soc/mediatek/mtk-mmsys.c
> > @@ -80,6 +80,12 @@ static const struct mtk_mmsys_driver_data
> > mt8195_vdosys0_driver_data = {
On Fri, Nov 04, 2022 at 10:57:28AM +, Nancy Lin (林欣螢) wrote:
> Dear Nicolas,
>
> Thanks for the review.
>
> On Thu, 2022-11-03 at 17:28 -0400, Nícolas F. R. A. Prado wrote:
> > On Thu, Nov 03, 2022 at 11:26:09AM +0800, Nancy.Lin wrote:
> > > Add drm ov
by: AngeloGioacchino Del Regno
>
> Tested-by: Bo-Chen Chen
> Tested-by: Nícolas F. R. A. Prado
> Change-Id: I0501f3c80e78ec8279366cba9c137a2edd7a852e
> ---
> drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 61 -
> drivers/gpu/drm/mediatek/mtk_drm_crtc.h | 2 +-
&
On Thu, Nov 03, 2022 at 11:26:05AM +0800, Nancy.Lin wrote:
[..]
> --- /dev/null
> +++ b/drivers/gpu/drm/mediatek/mtk_ethdr.h
[..]
> +void mtk_ethdr_unregister_vblank_cb(struct device *dev);
> +void mtk_ethdr_enable_vblank(struct device *dev);
> +void mtk_ethdr_disable_vblank(struct device *dev);
>
30ad6c4f74a6b2ebf75fc0e3f9f207b0416d1
Again, no Change-Id please.
Reviewed-by: Nícolas F. R. A. Prado
Thanks,
Nícolas
p;
> +
> + tmp = readl_relaxed(mmsys->regs + offset);
> + tmp = (tmp & ~mask) | val;
You should mask the value before writing to prevent bad values from overwriting
bits outside the mask.
tmp = (tmp & ~mask) | (val & mask);
With that,
Reviewed-by: Nícolas F. R. A. Prado
Thanks,
Nícolas
On Thu, Nov 03, 2022 at 11:25:07AM +0800, Nancy.Lin wrote:
> Add four mmsys config APIs. The config APIs are used for config
> mmsys reg. Some mmsys regs need to be set according to the
> HW engine binding to the mmsys simultaneously.
>
> 1. mtk_mmsys_merge_async_config: config merge async
>
> Signed-off-by: Nancy.Lin
> Change-Id: I8065205ce44baa417f58176adaae9e1eefa6eadb
No Change-Id tag, please. There are some other commits with it as well.
Otherwise,
Reviewed-by: Nícolas F. R. A. Prado
Thanks,
Nícolas
On Fri, Oct 21, 2022 at 08:18:25PM +0800, xinlei.lee wrote:
> On Thu, 2022-10-20 at 12:40 -0400, Nícolas F. R. A. Prado wrote:
> > On Wed, Oct 19, 2022 at 10:52:15AM +0800, xinlei@mediatek.com
> > wrote:
[..]
> > > @@ -448,8 +453,12 @@ static void mtk_dpi_dual_edge(s
On Fri, Oct 21, 2022 at 07:59:02PM +0800, xinlei.lee wrote:
> On Thu, 2022-10-20 at 12:33 -0400, Nícolas F. R. A. Prado wrote:
> > Hi,
> >
> > On Wed, Oct 19, 2022 at 10:52:14AM +0800, xinlei@mediatek.com
> > wrote:
> > > From: Xinlei Lee
> > >
ys is set to true for this platform.
>
> Signed-off-by: Xinlei Lee
> Reviewed-by: CK Hu
> Reviewed-by: AngeloGioacchino Del Regno
>
Reviewed-by: Nícolas F. R. A. Prado
Thanks,
Nícolas
> ---
[..]
On Wed, Oct 19, 2022 at 10:52:15AM +0800, xinlei@mediatek.com wrote:
[..]
> @@ -134,6 +137,7 @@ struct mtk_dpi_yc_limit {
> * @yuv422_en_bit: Enable bit of yuv422.
> * @csc_enable_bit: Enable bit of CSC.
> * @pixels_per_iter: Quantity of transferred pixels per iteration.
> + *
e_bits(mmsys, MT8186_MMSYS_DPI_OUTPUT_FORMAT,
> + DPI_FORMAT_MASK, DPI_RGB888_DDR_CON);
> + break;
> + }
To be honest I don't really see the point of making the function slightly more
platform-agnostic like this. With a single platform making use of it it's just
an unneeded extra abstraction, and it could easily be done when a second
platform starts requiring this as well...
In any case,
Reviewed-by: Nícolas F. R. A. Prado
Thanks,
Nícolas
> }
[..]
of this.
Signed-off-by: Nícolas F. R. A. Prado
---
drivers/gpu/drm/bridge/analogix/anx7625.c | 48 ---
1 file changed, 25 insertions(+), 23 deletions(-)
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c
b/drivers/gpu/drm/bridge/analogix/anx7625.c
index b0ff1ecb80a5
On Mon, Aug 29, 2022 at 11:21:48AM +0800, xinlei@mediatek.com wrote:
> From: Xinlei Lee
>
> Dpi output needs to adjust the output format to dual edge for MT8186.
>
> Co-developed-by: Jitao Shi
> Signed-off-by: Jitao Shi
> Signed-off-by: Xinlei Lee
Reviewed-by: N
On Fri, Aug 26, 2022 at 11:58:29AM +0800, xinlei.lee wrote:
> On Wed, 2022-08-24 at 11:44 -0400, Nícolas F. R. A. Prado wrote:
> > On Wed, Aug 24, 2022 at 09:59:21AM +0800, xinlei.lee wrote:
> > > On Tue, 2022-08-23 at 16:16 -0400, Nícolas F. R. A. Prado wrote:
> > > &
On Fri, Aug 26, 2022 at 02:12:00PM +0800, xinlei.lee wrote:
> On Thu, 2022-08-25 at 17:04 +0200, Matthias Brugger wrote:
> >
> > On 23/08/2022 22:17, Nícolas F. R. A. Prado wrote:
> > > On Tue, Aug 23, 2022 at 02:38:22PM +0800, xinlei@mediatek.com
> > >
On Wed, Aug 24, 2022 at 09:59:21AM +0800, xinlei.lee wrote:
> On Tue, 2022-08-23 at 16:16 -0400, Nícolas F. R. A. Prado wrote:
> > On Tue, Aug 23, 2022 at 02:18:37PM +0800, xinlei@mediatek.com
> > wrote:
> > > From: Xinlei Lee
> > >
> > > Dpi output
On Tue, Aug 23, 2022 at 02:38:22PM +0800, xinlei@mediatek.com wrote:
> From: Xinlei Lee
>
> Add mmsys function to manipulate dpi output format configuration for MT8186.
>
> Co-developed-by: Jitao Shi
> Signed-off-by: Jitao Shi
> Signed-off-by: Xinlei Lee
Revi
On Tue, Aug 23, 2022 at 02:18:37PM +0800, xinlei@mediatek.com wrote:
> From: Xinlei Lee
>
> Dpi output needs to adjust the output format to dual edge for MT8186.
> Because MT8186 HW has been modified at that time, SW needs to cooperate.
> And the register (MMSYS) reserved for dpi will be
On Mon, Aug 22, 2022 at 08:50:45PM +0800, xinlei.lee wrote:
[..]
> Hi Nícolas:
>
> Thanks for your careful review.
> I will correct it in the next version:
> 1. Modify key nouns in the description;
> 2. Modify the label of jitao to Co-developed-by;
To be clear, you shouldn't change jitao's
by: AngeloGioacchino Del Regno
>
> Tested-by: Bo-Chen Chen
Tested-by: Nícolas F. R. A. Prado
Display and external display still work on mt8192 as they should.
Thanks,
Nícolas
cchino Del Regno
>
> Tested-by: Bo-Chen Chen
Tested-by: Nícolas F. R. A. Prado
Display and external display still work on mt8192 as it should.
Thanks,
Nícolas
Hi Xinlei,
On Fri, Aug 05, 2022 at 05:57:40PM +0800, xinlei@mediatek.com wrote:
> From: Xinlei Lee
>
> Add mmsys func to manipulate dpi output format config for MT8186.
func -> function
config -> configuration
>
> Signed-off-by: Jitao Shi
Same thing about the co-developed-by.
>
Hi Xinlei,
On Fri, Aug 05, 2022 at 05:57:41PM +0800, xinlei@mediatek.com wrote:
> From: Xinlei Lee
>
> Dpi output needs to adjust the output format to dual edge for MT8186.
Could you explain a bit more why this is needed? What does this configuration
do? And why is MMSYS involved in a DPI
On Fri, Aug 19, 2022 at 12:13:23PM +0800, Nancy.Lin wrote:
> Hi Nicolas,
>
>
> On Fri, 2022-08-19 at 10:09 +0800, Nancy.Lin wrote:
> > Hi Nicolas,
> >
> > Thanks for the review.
> >
> > On Thu, 2022-08-18 at 17:47 -0400, Nícolas F. R. A. Prado wrote:
&
On Fri, Aug 05, 2022 at 06:04:08PM +0800, Nancy.Lin wrote:
[..]
> Hello Matthias,
>
> This series is about mmsys configuration of external display path.
>
> It is in version *25*, and it is reviewed by many reviewers, like CK
> and Angelo.
> The reset.h is also reviewed by Krzysztof.
>
> This
Hi Nancy,
On Mon, Jul 11, 2022 at 03:52:42PM +0800, Nancy.Lin wrote:
[..]
> static const struct mtk_mmsys_driver_data mt2701_mmsys_driver_data = {
> .clk_driver = "clk-mt2701-mm",
> .routes = mmsys_default_routing_table,
> @@ -86,6 +88,7 @@ static const struct mtk_mmsys_driver_data
Hi Nancy,
On Thu, Aug 04, 2022 at 03:28:21PM +0800, Nancy.Lin wrote:
> Add vdosys1 ETHDR definition.
>
> Signed-off-by: Nancy.Lin
> Reviewed-by: Chun-Kuang Hu
> Reviewed-by: AngeloGioacchino Del Regno
>
Some line-wrapping happened to your patch when sending, so it's corrupted and
won't
; Tested bridge chain: DSI <=> ANX7625 => aux-bus panel
>
> Fixes: 7f6335c6a258 ("drm/mediatek: Modify dsi funcs to atomic operations")
> Signed-off-by: AngeloGioacchino Del Regno
>
Reviewed-by: Nícolas F. R. A. Prado
Tested-by: Nícolas F. R. A. Prado
Tested on m
nk timeout warnings.
Fixes: cde7e2e35c28 ("drm/mediatek: Separate poweron/poweroff from
enable/disable and define new funcs")
Signed-off-by: Nícolas F. R. A. Prado
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 21 ++---
1 file changed, 10 insertions(+), 11 deletions(-)
diff --g
Add panel identification entry for the AUO B120XAN01.0 (product ID:
0x1062) panel.
Signed-off-by: Nícolas F. R. A. Prado
---
v1: https://lore.kernel.org/all/20220719203857.1488831-3-nfrapr...@collabora.com
Changes in v2:
- Move entry to the top so it respects the sorting
drivers/gpu/drm
On Wed, Jul 20, 2022 at 09:49:35AM +0200, AngeloGioacchino Del Regno wrote:
> Il 20/07/22 00:40, Doug Anderson ha scritto:
> > Hi,
> >
> > On Tue, Jul 19, 2022 at 1:39 PM Nícolas F. R. A. Prado
> > wrote:
> > >
> > > Add panel identificat
On Tue, Jul 19, 2022 at 03:41:43PM -0700, Doug Anderson wrote:
> Hi,
>
> On Tue, Jul 19, 2022 at 1:39 PM Nícolas F. R. A. Prado
> wrote:
> >
> > Add panel identification entry for the AUO B120XAN01.0 (product ID:
> > 0x1062) panel.
> >
>
Add panel identification entry for the IVO R140NWF5 RH (product ID:
0x057d) panel.
Signed-off-by: Nícolas F. R. A. Prado
---
The comments on the driver indicate that the T3 timing should be set on
hpd_absent, while hpd_reliable would have a shorter time just while the
HPD line stabilizes on low
This series adds two new eDP panel entries in the first two patches, and
fixes a typo in the third one that prevented usage of the DT properties.
Please see the note in patch 1 for a question on hpd_reliable vs.
hpd_absent.
Nícolas F. R. A. Prado (3):
drm/panel-edp: Add panel entry
Add panel identification entry for the AUO B120XAN01.0 (product ID:
0x1062) panel.
Signed-off-by: Nícolas F. R. A. Prado
---
drivers/gpu/drm/panel/panel-edp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/panel/panel-edp.c
b/drivers/gpu/drm/panel/panel-edp.c
index
The value read from the "hpd-absent-delay-ms" property in DT was being
saved to the wrong variable, overriding the hpd_reliable delay. Fix the
typo.
Fixes: 5540cf8f3e8d ("drm/panel-edp: Implement generic "edp-panel"s probed by
EDID")
Signed-off-by: Nícolas F. R. A
/bridge: anx7625: Add mode-switch support
> drm/bridge: anx7625: Register number of Type C switches
> drm/bridge: anx7625: Register Type-C mode switches
For the whole series,
Reviewed-by: Nícolas F. R. A. Prado
Tested-by: Nícolas F. R. A. Prado
Tested that external display works on b
Hi Prashant,
On Thu, Jun 09, 2022 at 06:09:46PM +, Prashant Malani wrote:
> From: Pin-Yen Lin
>
> Add the callback function when the driver receives state
> changes of the Type-C port. The callback function configures the
> crosspoint switch of the anx7625 bridge chip, which can change the
Hi Prashant,
On Thu, Jun 09, 2022 at 06:09:44PM +, Prashant Malani wrote:
> Parse the "switches" node, if available, and count and store the number
> of Type-C switches within it. Since we currently don't do anything with
> this info, no functional changes are expected from this change.
>
>
Hi Prashant,
thanks for the patch. Please see sugestions below.
On Thu, Jun 09, 2022 at 06:09:42PM +, Prashant Malani wrote:
> Introduce a binding which represents a component that can control the
> routing of USB Type-C data lines as well as address data line
> orientation (based on CC
eck for the presence of a panel bridge by testing the trueness of that
variable.
In order to ensure proper behavior, zero out pdata->panel_bridge before
returning when no panel bridge is found.
Fixes: 9e82ea0fb1df ("drm/bridge: anx7625: switch to devm_drm_of_get_bridge")
Signed-off-by: Nícola
to get
merged), I was able to get the following fluster scores on
mt8192-asurada-spherion:
VP8: 59/61
VP9: 249/303
H.264: 92/135
So for the whole series:
Tested-by: Nícolas F. R. A. Prado
Thanks,
Nícolas
[1]
https://lore.kernel.org/all/2537b84fbba82a77ee0a517b12bdcdd5e6ac1503.ca...@mediatek.com/
On Tue, Apr 26, 2022 at 06:08:27PM +0800, Yunfei Dong wrote:
> Add support for VP9 decoding using the stateless API,
> as supported by MT8192. And the drivers is lat and core architecture.
>
> Signed-off-by: Yunfei Dong
> Signed-off-by: George Sun
> Reviewed-by: AngeloGioacchino Del Regno
>
>
On Fri, Apr 08, 2022 at 12:15:44PM +0200, AngeloGioacchino Del Regno wrote:
> Il 08/04/22 03:33, Nícolas F. R. A. Prado ha scritto:
> > Read the irq flags, like which edge to trigger on, from the devicetree
> > and use those when registering the irq instead of hardcoding them.
&
1 - 100 of 112 matches
Mail list logo
