On 11:42-20201204, Boris Brezillon wrote:
> On Tue, 1 Dec 2020 17:48:27 +0530
> Nikhil Devshatwar wrote:
>
> > input_bus_flags are specified in drm_bridge_timings (legacy) as well
> > as drm_bridge_state->input_bus_cfg.flags
> >
> > The flags from the
On 11:32-20201204, Boris Brezillon wrote:
> On Tue, 1 Dec 2020 17:48:27 +0530
> Nikhil Devshatwar wrote:
>
> > input_bus_flags are specified in drm_bridge_timings (legacy) as well
> > as drm_bridge_state->input_bus_cfg.flags
> >
> > The flags from the
off-by: Nikhil Devshatwar
---
Notes:
changes from v4:
* fix a warning Reported-by: kernel test robot
drivers/gpu/drm/bridge/ti-tfp410.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c
b/drivers/gpu/drm/bridge/ti-tfp410.c
in
DRM_BRIDGE_ATTACH_NO_CONNECTOR
Signed-off-by: Nikhil Devshatwar
Reviewed-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
---
Notes:
changes from v1:
* Add error handling
drivers/gpu/drm/tidss/tidss_drv.h | 3 +++
drivers/gpu/drm/tidss/tidss_kms.c | 19 ++-
2 files changed, 21 insertions(+), 1
input_bus_flags are specified in drm_bridge_timings (legacy) as well
as drm_bridge_state->input_bus_cfg.flags
The flags from the timings will be deprecated. Bridges are supposed
to validate and set the bridge state flags from atomic_check.
Signed-off-by: Nikhil Devshatwar
---
drivers/gpu/
the minimal required support to avoid failure
after moving to new connector model.
Signed-off-by: Nikhil Devshatwar
Reviewed-by: Tomi Valkeinen
---
Notes:
changes from v1:
* cosmetic fixes, commit message update
.../drm/bridge/cadence/cdns-mhdp8546-core.c | 25 +++
1 file
Remove the old code to iterate over the bridge chain, as this is
already done by the framework.
The bridge state should have the negotiated bus format and flags.
Use these from the bridge's state.
If the bridge does not support format negotiation, error out
and fail.
Signed-off-by: Nikhil
es the MBOX interrupts, which are not handled by
the driver.
Fix this with a read-modify-write to update only required bits.
Use the enable / disable function as required in other places.
Signed-off-by: Nikhil Devshatwar
Reviewed-by: Swapnil Jakhade
Reviewed-by: Tomi Valkeinen
---
Notes:
chan
Input format is the one selected by the bridge from DT properties.
Signed-off-by: Nikhil Devshatwar
Reviewed-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
---
Notes:
changes from v1:
* Use only MEDIA_BUS_FMT_FIXED for output
drivers/gpu/drm/bridge/ti-tfp410.c | 33
off-by: Nikhil Devshatwar
---
drivers/gpu/drm/bridge/ti-tfp410.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c
b/drivers/gpu/drm/bridge/ti-tfp410.c
index 3def9acba86b..4c536df003c8 100644
--- a/drivers/gpu/drm/bridge/ti-tfp410.c
+++ b/driv
format negotiations in the tfp410 and mhdp bridge drivers
as a first step before moving the connector model.
Nikhil Devshatwar (7):
drm/bridge: tfp410: Support format negotiation hooks
drm/bridge: tfp410: Set input_bus_flags in atomic_check
drm/bridge: mhdp8546: Add minimal format negotiation
On 11:46-20201130, Laurent Pinchart wrote:
> Hi Nikhil,
>
> On Mon, Nov 30, 2020 at 12:05:03PM +0530, Nikhil Devshatwar wrote:
> > On 14:51-20201125, Tomi Valkeinen wrote:
> > > On 19/11/2020 18:01, Nikhil Devshatwar wrote:
> > > > Remove the old c
On 11:45-20201130, Laurent Pinchart wrote:
> Hi Nikhil,
>
> Thank you for the patch.
>
> On Thu, Nov 19, 2020 at 09:31:32PM +0530, Nikhil Devshatwar wrote:
> > Remove the old code to iterate over the bridge chain, as this is
> > already done by the framework.
>
>> already start going in that direction ? We don't need to convert all
> > >> bridge drivers in one go here, just the ones that are used by tidss.
I took this as a future approach to eventually start supporting
atomic_funcs.
I will respin v4 of this series with updates to
On 14:51-20201125, Tomi Valkeinen wrote:
> Hi Nikhil,
>
> On 19/11/2020 18:01, Nikhil Devshatwar wrote:
> > Remove the old code to iterate over the bridge chain, as this is
> > already done by the framework.
> > The bridge state should have the negotiated bus format an
DRM_BRIDGE_ATTACH_NO_CONNECTOR
Signed-off-by: Nikhil Devshatwar
Reviewed-by: Tomi Valkeinen
Reviewed-by: Laurent Pinchart
---
Notes:
changes from v1:
* Add error handling
drivers/gpu/drm/tidss/tidss_drv.h | 3 +++
drivers/gpu/drm/tidss/tidss_kms.c | 19 ++-
2 files changed, 21 insertions(+), 1
bus_flags can be specified by a bridge in the timings.
If the bridge provides it, Override the bus_flags when propagating
from next bridge.
Signed-off-by: Nikhil Devshatwar
Reviewed-by: Tomi Valkeinen
---
Notes:
changes from v2:
* update comment
changes from v1:
* Check
Remove the old code to iterate over the bridge chain, as this is
already done by the framework.
The bridge state should have the negotiated bus format and flags.
Use these from the bridge's state.
If the bridge does not support format negotiation, error out
and fail.
Signed-off-by: Nikhil
es the MBOX interrupts, which are not handled by
the driver.
Fix this with a read-modify-write to update only required bits.
Use the enable / disable function as required in other places.
Signed-off-by: Nikhil Devshatwar
Reviewed-by: Swapnil Jakhade
---
Notes:
changes from v2:
* Fix the
Input format is the one selected by the bridge from DT properties.
Signed-off-by: Nikhil Devshatwar
Reviewed-by: Tomi Valkeinen
---
Notes:
changes from v1:
* Use only MEDIA_BUS_FMT_FIXED for output
drivers/gpu/drm/bridge/ti-tfp410.c | 33 ++
1 file changed, 33
the minimal required support to avoid failure
after moving to new connector model.
Signed-off-by: Nikhil Devshatwar
Reviewed-by: Tomi Valkeinen
---
Notes:
changes from v1:
* cosmetic fixes, commit message update
.../drm/bridge/cadence/cdns-mhdp8546-core.c | 25 +++
1 file
negotiation.
Support format negotiations in the tfp410 and mhdp bridge drivers
as a first step before moving the connector model.
Nikhil Devshatwar (6):
drm: bridge: Propagate the bus flags from bridge->timings
drm/bridge: tfp410: Support format negotiation hooks
drm/bridge: mhdp8546: Add mini
On 14:32-20201110, Swapnil Jakhade wrote:
>
>
> > -Original Message-
> > From: Nikhil Devshatwar
> > Sent: Tuesday, November 10, 2020 7:23 PM
> > To: Tomi Valkeinen ; Swapnil Kashinath Jakhade
> > ; Yuti Suresh Amonkar
> > Cc: dri-devel@lists.
On 14:27-20201110, Tomi Valkeinen wrote:
> On 10/11/2020 12:27, Nikhil Devshatwar wrote:
> > On 11:21-20201110, Tomi Valkeinen wrote:
> >> On 09/11/2020 19:06, Nikhil Devshatwar wrote:
> >>> When removing the tidss driver, there is a warning reported by
> >&g
On 11:02-20201110, Tomi Valkeinen wrote:
> Hi Nikhil,
>
> On 09/11/2020 19:05, Nikhil Devshatwar wrote:
> > This series moves the tidss to using new connectoe model, where the
> > SoC driver (tidss) creates the connector and all the bridges are
>
On 11:21-20201110, Tomi Valkeinen wrote:
> On 09/11/2020 19:06, Nikhil Devshatwar wrote:
> > When removing the tidss driver, there is a warning reported by
> > kernel about an unhandled interrupt for mhdp driver.
> >
> > [ 43.238895] irq 31: nobody cared (try bootin
es the MBOX interrupts, which are not handled by
the driver.
Fix this with a read-modify-write to update only required bits.
Do the same for enabling interrupts as well.
Signed-off-by: Nikhil Devshatwar
---
drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 7 +--
1 file changed, 5 inse
bus_flags can be specified by a bridge in the timings.
If the bridge provides it, Override the bus_flags when propagating
from next bridge.
Signed-off-by: Nikhil Devshatwar
---
drivers/gpu/drm/drm_bridge.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/drm_bridge.c
DRM_BRIDGE_ATTACH_NO_CONNECTOR
Signed-off-by: Nikhil Devshatwar
---
drivers/gpu/drm/tidss/tidss_drv.h | 3 +++
drivers/gpu/drm/tidss/tidss_kms.c | 19 ++-
2 files changed, 21 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tidss/tidss_drv.h
b/drivers/gpu/drm/tidss/tidss_drv.h
index
-by: Nikhil Devshatwar
---
drivers/gpu/drm/tidss/tidss_encoder.c | 22 ++
1 file changed, 14 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/tidss/tidss_encoder.c
b/drivers/gpu/drm/tidss/tidss_encoder.c
index e278a9c89476..ba5b6fccabe7 100644
--- a/drivers/gpu/drm/tidss
Input format is the one selected by the bridge from DT properties.
Signed-off-by: Nikhil Devshatwar
---
drivers/gpu/drm/bridge/ti-tfp410.c | 33 ++
1 file changed, 33 insertions(+)
diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c
b/drivers/gpu/drm/bridge/ti-tfp410.c
the minimal required support to avoid failure
after moving to new connector model.
Signed-off-by: Nikhil Devshatwar
---
.../drm/bridge/cadence/cdns-mhdp8546-core.c | 25 +++
1 file changed, 25 insertions(+)
diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
b/drivers/gpu
negotiation.
Support format negotiations in the tfp410 and mhdp bridge drivers
as a first step before moving the connector model.
Nikhil Devshatwar (6):
drm: bridge: Propagate the bus flags from bridge->timings
drm/bridge: tfp410: Support format negotiation hooks
drm/bridge: mhdp8546: Add mini
On 00:57-20201030, Laurent Pinchart wrote:
> Hi Nikhil,
>
> Thank you for the patch.
>
> On Fri, Oct 16, 2020 at 04:09:14PM +0530, Nikhil Devshatwar wrote:
> > When there is a chain of bridges attached to the encoder,
> > the bus_format should be ideall
> drm/omap: simplify DSI manual update code
> drm/omap: dsi: simplify pin config
> ARM: omap2plus_defconfig: Update for moved DSI command mode panel
>
> Tomi Valkeinen (5):
> drm/omap: squash omapdrm sub-modules into one
> drm/omap: remove unused display.c
> drm/
On 14:31-20201021, Tomi Valkeinen wrote:
> On 16/10/2020 13:39, Nikhil Devshatwar wrote:
> > When the next bridge does not specify any bus flags, use the
> > bridge->timings->input_bus_flags as fallback when propagating
> > bus flags from next bridge to current
On 15:11-20201019, Tomi Valkeinen wrote:
> Hi Nikhil,
>
> On 16/10/2020 13:39, Nikhil Devshatwar wrote:
> > This series moves the tidss to using new connectoe model, where the
> > SoC driver (tidss) creates the connector and all the bridges are
>
-by: Nikhil Devshatwar
---
drivers/gpu/drm/tidss/tidss_encoder.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/tidss/tidss_encoder.c
b/drivers/gpu/drm/tidss/tidss_encoder.c
index e278a9c89476..ae7f134754b7 100644
--- a/drivers/gpu/drm/tidss
When the next bridge does not specify any bus flags, use the
bridge->timings->input_bus_flags as fallback when propagating
bus flags from next bridge to current bridge.
Signed-off-by: Nikhil Devshatwar
---
drivers/gpu/drm/drm_bridge.c | 7 +++
1 file changed, 7 insertions(+)
diff
bindings.
Signed-off-by: Nikhil Devshatwar
---
drivers/gpu/drm/bridge/ti-tfp410.c | 32 ++
1 file changed, 32 insertions(+)
diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c
b/drivers/gpu/drm/bridge/ti-tfp410.c
index ba3fa2a9b8a4..b65e48e080c7 100644
--- a/drivers/gpu
DRM_BRIDGE_ATTACH_NO_CONNECTOR
Signed-off-by: Nikhil Devshatwar
---
drivers/gpu/drm/tidss/tidss_drv.h | 3 +++
drivers/gpu/drm/tidss/tidss_kms.c | 15 ++-
2 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tidss/tidss_drv.h
b/drivers/gpu/drm/tidss/tidss_drv.h
index 7de4bba52e6f
negotiation.
Support format negotiations in the tfp410 and mhdp bridge drivers.
Nikhil Devshatwar (5):
drm/tidss: Move to newer connector model
drm/tidss: Set bus_format correctly from bridge/connector
drm: bridge: Propagate the bus flags from bridge->timings
drm/bridge: tfp410: Support for
With new connector model, mhdp bridge will not create the connector and
SoC driver will rely on format negotiation to setup the encoder format.
Support format negotiations hooks in the drm_bridge_funcs.
Support a single format for input.
Signed-off-by: Nikhil Devshatwar
---
.../drm/bridge
Hi all,
I am trying to convert the upstream tidss drm driver to new
connector model.
The connector is getting created by the tidss driver and bridges are
attached with flag DRM_BRIDGE_ATTACH_NO_CONNECTOR
Here are some questions, regarding this:
1) Most of the info regarding bus_format and bus
44 matches
Mail list logo
