Re: [PATCH net-next v5 1/3] net: ethernet: ti: Add accessors for struct k3_cppi_desc_pool members

2024-03-30 Thread Russell King (Oracle)
On Thu, Mar 28, 2024 at 12:06:56PM +, Naveen Mamindlapalli wrote: > > diff --git a/drivers/net/ethernet/ti/k3-cppi-desc-pool.c > > b/drivers/net/ethernet/ti/k3- > > cppi-desc-pool.c > > index 05cc7aab1ec8..fe8203c05731 100644 > > --- a/drivers/net/ethernet/ti/k3-cppi-desc-pool.c > > +++

Re: [RFT PATCH 01/15] drm/armada: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-20 Thread Russell King (Oracle)
On Wed, Sep 20, 2023 at 11:03:32AM -0700, Doug Anderson wrote: > Maxime, > > On Wed, Sep 13, 2023 at 8:34 AM Doug Anderson wrote: > > > > Hi, > > > > On Tue, Sep 5, 2023 at 7:23 AM Doug Anderson wrote: > > > > > > Hi, > > > > > &

Re: [RFT PATCH 01/15] drm/armada: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-04 Thread Russell King (Oracle)
On Fri, Sep 01, 2023 at 04:41:12PM -0700, Douglas Anderson wrote: > Based on grepping through the source code this driver appears to be > missing a call to drm_atomic_helper_shutdown() at system shutdown > time. Among other things, this means that if a panel is in use that it > won't be cleanly

Re: [RFT PATCH 01/15] drm/armada: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-04 Thread Russell King (Oracle)
On Mon, Sep 04, 2023 at 09:36:10AM +0200, Maxime Ripard wrote: > On Sun, Sep 03, 2023 at 04:53:42PM +0100, Russell King (Oracle) wrote: > > On Fri, Sep 01, 2023 at 04:41:12PM -0700, Douglas Anderson wrote: > > > Based on grepping through the source code this driver appears t

Re: [RFT PATCH 01/15] drm/armada: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-03 Thread Russell King (Oracle)
On Fri, Sep 01, 2023 at 04:41:12PM -0700, Douglas Anderson wrote: > Based on grepping through the source code this driver appears to be > missing a call to drm_atomic_helper_shutdown() at system shutdown > time. Among other things, this means that if a panel is in use that it > won't be cleanly

Re: [PATCH 1/4] vgacon: rework Kconfig dependencies

2023-08-01 Thread Russell King (Oracle)
On Fri, Jul 07, 2023 at 11:52:23AM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > The list of dependencies here is phrased as an opt-out, but this is missing > a lot of architectures that don't actually support VGA consoles, and some > of the entries are stale: > > - powerpc used to

Re: [PATCH RFC v1 04/52] drm/armada: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Russell King (Oracle)
On Wed, Jul 12, 2023 at 11:46:14AM +0200, Uwe Kleine-König wrote: > Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" > is the better name as "dev" is usually a struct device pointer. > > No semantic changes. > > Signed-off-

Re: [PATCH] drm/etnaviv: disable MLCG and pulse eater on GPU reset

2023-06-14 Thread Russell King (Oracle)
On Wed, Jun 07, 2023 at 02:58:41PM +0200, Lucas Stach wrote: > Module level clock gating and the pulse eater might interfere with > the GPU reset, as they both have the potential to stop the clock > and thus reset propagation to parts of the GPU. > > Signed-off-by: Lucas Stach > --- > I'm not

Re: [PATCH] drm/i2c: tda998x: Replace all non-returning strlcpy with strscpy

2023-05-22 Thread Russell King (Oracle)
On Mon, May 22, 2023 at 03:53:50PM +, Azeem Shaikh wrote: > strlcpy() reads the entire source buffer first. > This read may exceed the destination size limit. > This is both inefficient and can lead to linear read > overflows if a source string is not NUL-terminated [1]. > In an effort to

Re: [PATCH v2 02/12] drm/armada: Use regular fbdev I/O helpers

2023-05-15 Thread Russell King (Oracle)
o DRM's fbdev helpers > > are mere wrappers around the fbdev code. > > > > By using fbdev helpers directly within each DRM fbdev emulation, > > we can eventually remove DRM's wrapper functions entirely. > > > > v2: > > * use FB_IO_HELPERS option

Re: [PATCH v1 0/2] ASoC/tda998x: Fix reporting of nonexistent capture streams

2022-12-02 Thread Russell King (Oracle)
/drm/i2c/tda998x_drv.c | 2 ++ > include/sound/hdmi-codec.h| 4 > sound/soc/codecs/hdmi-codec.c | 30 +- > 3 files changed, 31 insertions(+), 5 deletions(-) Looks sane. Reviewed-by: Russell King (Oracle) Thanks. -- RMK's Patch system: htt

Re: [PATCH resend] drm/armada: Fix off-by-one error in armada_overlay_get_property()

2022-11-21 Thread Russell King (Oracle)
On Mon, Nov 21, 2022 at 04:43:14PM +0100, Geert Uytterhoeven wrote: > As ffs() returns one more than the index of the first bit set (zero > means no bits set), the color key mode value is shifted one position too > much. > > Fix this by using FIELD_GET() instead. Reviewed-b

Re: [linux-next:master] BUILD REGRESSION 4662b7adea50bb62e993a67f611f3be625d3df0d

2022-07-14 Thread Russell King (Oracle)
Hi, I don't mean to discourge test systems, but looking at this, I just go "meh" and delete it - it doesn't seem to contain obviously useful information. One has to read every damn line to see if there's something of relevence, which I for one am not going to do. Is there some kind of

Re: [PATCH] drm/i2c: tda9950: Lower severity of log message about missing interrupts

2022-06-06 Thread Russell King (Oracle)
On Mon, Jun 06, 2022 at 06:14:36PM +0100, Mark Brown wrote: > The tda9950 driver prints an error message if it is instantiated without > an interrupt being available since the device is non-functional in that > case. Unfortunately due to packaging of tda9950 with tda998x series devices > the

Re: mainline build failure due to f1e4c916f97f ("drm/edid: add EDID block count and size helpers")

2022-05-30 Thread Russell King (Oracle)
On Mon, May 30, 2022 at 03:35:28PM +0200, Arnd Bergmann wrote: > The annotations for edid are completely correct and necessary. However > other driver authors just slap __packed annotations on any structure > even if the layout is not fixed at all like: > > struct my_driver_priv { >struct

Re: mainline build failure due to f1e4c916f97f ("drm/edid: add EDID block count and size helpers")

2022-05-30 Thread Russell King (Oracle)
On Mon, May 30, 2022 at 02:43:45PM +0200, Arnd Bergmann wrote: > Overall I'm not that worried because the only machines running OABI > kernels would be on really old hardware that runs a limited set of > driver code. ... and from what I remember, none of them care about EDID anyway. -- RMK's

Re: mainline build failure due to f1e4c916f97f ("drm/edid: add EDID block count and size helpers")

2022-05-30 Thread Russell King (Oracle)
On Mon, May 30, 2022 at 12:33:17PM +0300, Jani Nikula wrote: > On Mon, 30 May 2022, Jani Nikula wrote: > > On Sat, 28 May 2022, Linus Torvalds wrote: > >> On Sat, May 28, 2022 at 11:59 AM Arnd Bergmann wrote: > >>> > >>> It's CONFIG_ARM_AEABI, which is normally set everywhere. Without this >

Re: mainline build failure due to f1e4c916f97f ("drm/edid: add EDID block count and size helpers")

2022-05-28 Thread Russell King (Oracle)
On Sat, May 28, 2022 at 11:08:48AM -0700, Linus Torvalds wrote: > This smells like a compiler bug triggered by "there's a 16-bit member > field in that gtf2 structure, and despite it being packed and aligned > to 1, we somehow still align the size to 2". It's an age old thing, it's no compiler

Re: [PATCH] HPE BMC GXP SUPPORT

2022-02-04 Thread Russell King (Oracle)
On Fri, Feb 04, 2022 at 04:18:24AM -0800, Joe Perches wrote: > On Fri, 2022-02-04 at 12:05 +0000, Russell King (Oracle) wrote: > > On Wed, Feb 02, 2022 at 10:52:50AM -0600, nick.hawk...@hpe.com wrote: > > > + if (readb_relaxed(timer->control) & MASK_TCS_TC) { >

Re: [PATCH] HPE BMC GXP SUPPORT

2022-02-04 Thread Russell King (Oracle)
Hi, On Wed, Feb 02, 2022 at 10:52:50AM -0600, nick.hawk...@hpe.com wrote: > diff --git a/arch/arm/mach-hpe/Makefile b/arch/arm/mach-hpe/Makefile > new file mode 100644 > index ..8b0a91234df4 > --- /dev/null > +++ b/arch/arm/mach-hpe/Makefile > @@ -0,0 +1 @@ >

Re: [PATCH 3/3] [RFC] dt-bindings: display: bridge: nxp,tda998x: Convert to json-schema

2021-10-29 Thread Russell King (Oracle)
On Fri, Oct 29, 2021 at 11:40:26AM +0200, Geert Uytterhoeven wrote: > Hi Russell, > > On Fri, Oct 29, 2021 at 11:33 AM Russell King (Oracle) > wrote: > > On Fri, Oct 29, 2021 at 10:28:22AM +0200, Geert Uytterhoeven wrote: > > > No, you can still use port: > > &g

Re: [PATCH 3/3] [RFC] dt-bindings: display: bridge: nxp,tda998x: Convert to json-schema

2021-10-29 Thread Russell King (Oracle)
On Fri, Oct 29, 2021 at 10:28:22AM +0200, Geert Uytterhoeven wrote: > Hi Russell, > > Thanks for your comments! > > No, you can still use port: > > +oneOf: > + - required: > + - port > + - required: > + - ports > > When using ports, no further requirements are set, but perhaps

Re: [PATCH 3/3] [RFC] dt-bindings: display: bridge: nxp,tda998x: Convert to json-schema

2021-10-29 Thread Russell King (Oracle)
On Thu, Oct 28, 2021 at 08:04:48PM -0500, Rob Herring wrote: > On Thu, Oct 21, 2021 at 03:18:53PM +0200, Geert Uytterhoeven wrote: > > +properties: > > + port@0: > > +type: object > > +description: FIXME > > Looks like the input from the example > > > + > > +

Re: [PATCH] mailbox: remove the error message when gce clk is defer

2021-10-24 Thread Russell King (Oracle)
On Sun, Oct 24, 2021 at 12:48:31AM +0800, jason-jh.lin wrote: > Remove the error message when gce clk is defer. > > Signed-off-by: jason-jh.lin > --- > drivers/mailbox/mtk-cmdq-mailbox.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git

Re: [RFC PATCH] component: do not leave master devres group open after bind

2021-09-21 Thread Russell King (Oracle)
ady be claimed, or (preferred) be claimed when the master gets the bind call. However, I think the i915 bits are more complex than that simple view, so putting the component stuff inside its own devres group and closing it at the end of try_to_bring_up_master() makes sense. Acked-by: Russell King (Oracle) Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

Re: [PATCH 3/3] drm/etnaviv: use a 32 bit mask as coherent DMA mask

2021-08-26 Thread Russell King (Oracle)
On Thu, Aug 26, 2021 at 02:10:06PM +0200, Michael Walle wrote: > - pdev->dev.coherent_dma_mask = DMA_BIT_MASK(40); > - pdev->dev.dma_mask = >dev.coherent_dma_mask; > + /* > + * PTA and MTLB can have 40 bit base addresses, but > + * unfortunately, an entry in the MTLB can only

Re: [PATCH 2/3] drm/etnaviv: fix dma configuration of the virtual device

2021-08-26 Thread Russell King (Oracle)
On Thu, Aug 26, 2021 at 02:10:05PM +0200, Michael Walle wrote: > + pdev->dev.coherent_dma_mask = DMA_BIT_MASK(40); > + pdev->dev.dma_mask = >dev.coherent_dma_mask; Please use dma_coerce_mask_and_coherent() here instead. -- RMK's Patch system:

Re: [PATCH] component: Move host device to end of device lists on binding

2021-05-13 Thread Russell King - ARM Linux admin
On Mon, May 10, 2021 at 06:05:21PM +0200, Daniel Vetter wrote: > Entirely aside, but an s/master/aggregate/ or similar over the entire > component.c codebase would help a pile in making it easier to understand > which part does what. Or at least I'm always terribly confused about which > bind

Re: [PATCH] component: Move host device to end of device lists on binding

2021-05-11 Thread Russell King - ARM Linux admin
On Sat, May 08, 2021 at 12:41:18AM -0700, Stephen Boyd wrote: > Within the component device framework this usually isn't that bad > because the real driver work is done at bind time via > component{,master}_ops::bind(). It becomes a problem when the driver > core, or host driver, wants to operate

Re: [GIT PULL] immutable branch for amba changes targeting v5.12-rc1

2021-02-04 Thread Russell King - ARM Linux admin
On Thu, Feb 04, 2021 at 05:56:50PM +0100, Greg Kroah-Hartman wrote: > On Thu, Feb 04, 2021 at 04:52:24PM +0000, Russell King - ARM Linux admin > wrote: > > On Tue, Feb 02, 2021 at 03:06:05PM +0100, Greg Kroah-Hartman wrote: > > > I'm glad to take this through my char/misc

Re: [GIT PULL] immutable branch for amba changes targeting v5.12-rc1

2021-02-04 Thread Russell King - ARM Linux admin
On Tue, Feb 02, 2021 at 03:06:05PM +0100, Greg Kroah-Hartman wrote: > I'm glad to take this through my char/misc tree, as that's where the > other coresight changes flow through. So if no one else objects, I will > do so... Greg, did you end up pulling this after all? If not, Uwe produced a v2.

Re: [PATCH v3 0/5] amba: minor fix and various cleanups

2021-02-02 Thread Russell King - ARM Linux admin
> drivers/vfio, drivers/watchdog and sound/arm have no maintainer feedback > yet). > > My suggestion is to let this series go in via Russell King (who cares > for amba). Once enough Acks are there I can also provide a tag for > merging into different trees. Just tell me if you

Re: [PATCH v3 4/5] amba: Make the remove callback return void

2021-01-26 Thread Russell King - ARM Linux admin
On Tue, Jan 26, 2021 at 06:56:52PM +0100, Uwe Kleine-König wrote: > I'm surprised to see that the remove callback introduced in 2952ecf5df33 > ("coresight: etm4x: Refactor probing routine") has an __exit annotation. In general, remove callbacks should not have an __exit annotation. __exit _can_

Re: [PATCH] drm: bridge: dw-hdmi: Avoid resetting force in the detect function

2020-11-08 Thread Russell King - ARM Linux admin
On Sun, Nov 08, 2020 at 10:53:22AM +0100, Sam Ravnborg wrote: > Russell, > > On Sat, Oct 31, 2020 at 07:17:47PM +1100, Jonathan Liu wrote: > > It has been observed that resetting force in the detect function can > > result in the PHY being powered down in response to hot-plug detect > > being

Re: [PATCH] gpu/drm/armada: fix unused parameter warning

2020-10-12 Thread Russell King - ARM Linux admin
On Mon, Oct 12, 2020 at 04:57:24AM -0700, Bernard Zhao wrote: > Functions armada_drm_crtc_atomic_flush & > armada_drm_crtc_atomic_enable don`t use the second parameter. > So we may get warning like : > warning: unused parameter ‘***’ [-Wunused-parameter]. > This change is to fix the compile

Re: [PATCH v2 02/21] drm/armada: Introduce GEM object functions

2020-09-15 Thread Russell King - ARM Linux admin
mermann Acked-by: Russell King Thanks. > --- > drivers/gpu/drm/armada/armada_drv.c | 3 --- > drivers/gpu/drm/armada/armada_gem.c | 12 +++- > drivers/gpu/drm/armada/armada_gem.h | 2 -- > 3 files changed, 11 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/

Re: [PATCH] drm/etnaviv: always start/stop scheduler in timeout processing

2020-08-24 Thread Russell King - ARM Linux admin
ires a major rearchitecture of the > scheduler, which is not applicable as a fix. > > Fixes: 135517d3565b drm/scheduler: Avoid accessing freed bad job.) > Signed-off-by: Lucas Stach >From a brief test, this seems to fix the problem, thanks. Tested-by: Russell King > --- &g

Re: [PATCH] drm/etnaviv: fix external abort seen on GC600 rev 0x19

2020-08-23 Thread Russell King - ARM Linux admin
On Sun, Aug 23, 2020 at 09:10:25PM +0200, Christian Gmeiner wrote: > Hi > > > I have formally tested the patch with 5.7.10 - and it doesn't resolve > > the issue - sadly :( > > > > From my testing, the reads on > > VIVS_HI_CHIP_PRODUCT_ID > > VIVS_HI_CHIP_ECO_ID > > need to be conditional - while

Re: [PATCH 1/2] drm/imx: fix use after free

2020-06-11 Thread Russell King - ARM Linux admin
On Thu, Jun 11, 2020 at 02:43:31PM +0200, Marco Felsch wrote: > From: Philipp Zabel > > Component driver structures allocated with devm_kmalloc() in bind() are > freed automatically after unbind(). Since the contained drm structures > are accessed afterwards in drm_mode_config_cleanup(), move

Re: [PATCH 2/3] drm/etnaviv: Don't ignore errors on getting clocks

2020-05-20 Thread Russell King - ARM Linux admin
On Wed, May 20, 2020 at 04:04:39PM +0200, Lucas Stach wrote: > Am Mittwoch, den 20.05.2020, 15:38 +0200 schrieb Lubomir Rintel: > > Yes. This means that in fact "core" is the only required clock for all > > implementations of vivante,gc and the common binding needs to be updated > > to reflect

Re: [PATCH 2/3] drm/etnaviv: Don't ignore errors on getting clocks

2020-05-14 Thread Russell King - ARM Linux admin
On Thu, May 14, 2020 at 10:40:58AM +0200, Lucas Stach wrote: > Am Donnerstag, den 14.05.2020, 09:27 +0100 schrieb Russell King - ARM Linux > admin: > > On Thu, May 14, 2020 at 10:18:02AM +0200, Lucas Stach wrote: > > > Am Mittwoch, den 13.05.2020, 23:41 -0300 schrieb Fabio Es

Re: [PATCH 2/3] drm/etnaviv: Don't ignore errors on getting clocks

2020-05-14 Thread Russell King - ARM Linux admin
On Thu, May 14, 2020 at 10:18:02AM +0200, Lucas Stach wrote: > Am Mittwoch, den 13.05.2020, 23:41 -0300 schrieb Fabio Estevam: > > On Wed, May 13, 2020 at 2:09 PM Fabio Estevam wrote: > > > > > The binding doc Documentation/devicetree/bindings/gpu/vivante,gc.yaml > > > says that only the 'reg'

Re: decruft the vmalloc API

2020-04-08 Thread Russell King - ARM Linux admin
On Wed, Apr 08, 2020 at 01:58:58PM +0200, Christoph Hellwig wrote: > Hi all, > > Peter noticed that with some dumb luck you can toast the kernel address > space with exported vmalloc symbols. > > I used this as an opportunity to decruft the vmalloc.c API and make it > much more systematic. This

Re: [PATCH] Update my email address in various drivers

2020-03-30 Thread Russell King - ARM Linux admin
On Mon, Mar 30, 2020 at 08:04:44PM +0200, Sam Ravnborg wrote: > Hi Russell. > > On Sun, Mar 29, 2020 at 11:19:10AM +0100, Russell King wrote: > > Globally update my email address in six files scattered through the > > tree. > > > > Signed-off-by: Russell King &g

[PATCH] Update my email address in various drivers

2020-03-30 Thread Russell King
Globally update my email address in six files scattered through the tree. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_drv.c | 2 +- drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 2 +- drivers/gpu/drm/etnaviv/etnaviv_drv.c | 2 +- drivers

Re: [PATCH 18/51] drm/: Use drmm_add_final_kfree

2020-02-22 Thread Russell King - ARM Linux admin
On Fri, Feb 21, 2020 at 10:02:46PM +0100, Daniel Vetter wrote: > These are the leftover drivers that didn't have a ->release hook that > needed to be updated. > > Signed-off-by: Daniel Vetter > Cc: "James (Qian) Wang" > Cc: Liviu Dudau > Cc: Mihail Atanassov

Re: [PATCH] drm/etnaviv: only reject timeouts with tv_nsec >= 2 seconds

2020-01-22 Thread Russell King - ARM Linux admin
On Wed, Jan 22, 2020 at 11:30:34AM +0100, Guido Günther wrote: > Hi, > On Tue, Jan 21, 2020 at 08:05:27PM +0100, Arnd Bergmann wrote: > > On Tue, Jan 21, 2020 at 5:10 PM Lucas Stach wrote: > > > > > > Hi Guido, > > > > > > On Di, 2020-01-21 at 13:55 +0100, Guido Günther wrote: > > > > Hi, > > > >

Re: [PATCH] drm/etnaviv: only reject timeouts with tv_nsec >= 2 seconds

2020-01-21 Thread Russell King - ARM Linux admin
On Tue, Jan 21, 2020 at 01:55:46PM +0100, Guido Günther wrote: > Hi, > On Tue, Jan 21, 2020 at 12:45:25PM +0100, Arnd Bergmann wrote: > > As Guido Günther reported, get_abs_timeout() in the etnaviv user space > > sometimes passes timeouts with nanosecond values larger than 10, > > which

Re: [PATCH for-5.6 0/2] drm/bridge: dw-hdmi: PCM API updates

2020-01-09 Thread Russell King - ARM Linux admin
On Thu, Jan 09, 2020 at 10:10:09AM +0100, Takashi Iwai wrote: > On Tue, 10 Dec 2019 16:45:34 +0100, > Takashi Iwai wrote: > > > > Hi, > > > > this is a patch set for updating ALSA PCM API usages in dw-hdmi > > driver. I already tried to "fix" the driver some time ago but it was > > utterly

Re: [PATCH 00/30] drm/bridge: Add device links for lifetime control

2019-11-26 Thread Russell King - ARM Linux admin
si: Use drm_bridge_init() > drm/mediatek: hdmi: Use drm_bridge_init() > drm: rcar-du: lvds: Use drm_bridge_init() > drm: rcar-du: lvds: Don't set drm_bridge private pointer > drm/sti: sti_vdo: Use drm_bridge_init() > drm/komeda: Use drm_bridge interface for pipe outputs >

Re: [PATCH 05/15] drm/armada: Delete dma_buf->k(un)map implemenation

2019-11-25 Thread Russell King - ARM Linux admin
On Mon, Nov 25, 2019 at 10:44:43PM +0100, Daniel Vetter wrote: > On Mon, Nov 18, 2019 at 11:35:26AM +0100, Daniel Vetter wrote: > > It's a dummy anyway. > > > > Signed-off-by: Daniel Vetter > > Cc: Russell King > > I merged the entire series except this one an

Re: Incorrect buffer handling in dw-hdmi bridge audio

2019-11-05 Thread Russell King - ARM Linux admin
On Tue, Nov 05, 2019 at 05:44:26PM +0100, Takashi Iwai wrote: > On Tue, 05 Nov 2019 17:33:44 +0100, > Takashi Iwai wrote: > > > > On Tue, 05 Nov 2019 17:02:15 +0100, > > Russell King - ARM Linux admin wrote: > > > > > > On Tue, Nov 05, 2019 at 09:07:43

Re: Incorrect buffer handling in dw-hdmi bridge audio

2019-11-05 Thread Russell King - ARM Linux admin
On Tue, Nov 05, 2019 at 09:07:43AM +0100, Neil Armstrong wrote: > Hi, > > On 05/11/2019 08:55, Takashi Iwai wrote: > > Hi, > > > > while recently working on the ALSA memory allocator API cleanup, I > > noticed that dw-hdmi bridge driver seems doing weird about the buffer > > management. It

Re: [RFC,3/3] drm/komeda: Allow non-component drm_bridge only endpoints

2019-10-22 Thread Russell King - ARM Linux admin
On Tue, Oct 22, 2019 at 03:42:07PM +0100, Russell King - ARM Linux admin wrote: > On Tue, Oct 22, 2019 at 10:50:42AM +0200, Daniel Vetter wrote: > > On Tue, Oct 22, 2019 at 10:48 AM Russell King - ARM Linux admin > > wrote: > > > I had a patches, which is why I raised t

Re: [RFC,3/3] drm/komeda: Allow non-component drm_bridge only endpoints

2019-10-22 Thread Russell King - ARM Linux admin
On Tue, Oct 22, 2019 at 10:50:42AM +0200, Daniel Vetter wrote: > On Tue, Oct 22, 2019 at 10:48 AM Russell King - ARM Linux admin > wrote: > > I had a patches, which is why I raised the problem with the core: > > > > 6961edfee26d bridge hacks using device links > >

Re: [RFC,3/3] drm/komeda: Allow non-component drm_bridge only endpoints

2019-10-22 Thread Russell King - ARM Linux admin
On Tue, Oct 22, 2019 at 10:42:10AM +0200, Daniel Vetter wrote: > On Thu, Oct 17, 2019 at 12:41:37PM +0100, Russell King - ARM Linux admin > wrote: > > On Thu, Oct 17, 2019 at 10:48:12AM +, Brian Starkey wrote: > > > On Thu, Oct 17, 2019 at 10:21:03AM +, james qian

Re: [RFC,3/3] drm/komeda: Allow non-component drm_bridge only endpoints

2019-10-17 Thread Russell King - ARM Linux admin
On Thu, Oct 17, 2019 at 10:48:12AM +, Brian Starkey wrote: > On Thu, Oct 17, 2019 at 10:21:03AM +, james qian wang (Arm Technology > China) wrote: > > On Thu, Oct 17, 2019 at 08:20:56AM +, Brian Starkey wrote: > > > On Thu, Oct 17, 2019 at 03:07:59AM +, james qian wang (Arm

Re: [PATCHv8 2/2] drm: tda998x: set the connector info

2019-10-17 Thread Russell King - ARM Linux admin
On Thu, Oct 17, 2019 at 11:26:38AM +0200, Dariusz Marcinkiewicz wrote: > Hi Russel. > > On Wed, Oct 16, 2019 at 6:22 PM Russell King - ARM Linux admin > wrote: > > > ... > > > --- a/drivers/gpu/drm/i2c/tda998x_drv.c > > > +++ b/drivers/gpu/drm/i2c/tda998x_d

Re: [PATCHv9 2/2] drm: tda998x: set the connector info

2019-10-17 Thread Russell King - ARM Linux admin
On Thu, Oct 17, 2019 at 09:28:42AM +0200, Hans Verkuil wrote: > From: Dariusz Marcinkiewicz > > Fill in the cec_connector_info when calling cec_notifier_conn_register(). > > Signed-off-by: Dariusz Marcinkiewicz > Tested-by: Hans Verkuil > Signed-off-by: Hans Verkuil > --- >

Re: [PATCHv8 2/2] drm: tda998x: set the connector info

2019-10-16 Thread Russell King - ARM Linux admin
On Wed, Oct 16, 2019 at 03:39:16PM +0200, Hans Verkuil wrote: > From: Dariusz Marcinkiewicz > > Fill in the cec_connector_info when calling cec_notifier_conn_register(). > > Signed-off-by: Dariusz Marcinkiewicz > Tested-by: Hans Verkuil > Signed-off-by: Hans Verkuil > --- >

Re: [PATCHv8 1/2] drm: tda998x: use cec_notifier_conn_(un)register

2019-10-16 Thread Russell King - ARM Linux admin
On Wed, Oct 16, 2019 at 03:39:15PM +0200, Hans Verkuil wrote: > From: Dariusz Marcinkiewicz > > Use the new cec_notifier_conn_(un)register() functions to > (un)register the notifier for the HDMI connector. > > Signed-off-by: Dariusz Marcinkiewicz > Signed-off-by: Hans Verkuil Please explain

Re: [PATCH v2] drm: bridge/dw_hdmi: add audio sample channel status setting

2019-09-08 Thread Russell King - ARM Linux admin
On Thu, Sep 05, 2019 at 05:43:25PM +0800, Cheng-Yi Chiang wrote: > From: Yakir Yang > > When transmitting IEC60985 linear PCM audio, we configure the > Aduio Sample Channel Status information of all the channel > status bits in the IEC60958 frame. > Refer to 60958-3 page 10 for frequency,

Re: [PATCH] drm: bridge/dw_hdmi: add audio sample channel status setting

2019-09-04 Thread Russell King - ARM Linux admin
On Wed, Sep 04, 2019 at 05:45:20PM +0800, Cheng-yi Chiang wrote: > On Wed, Sep 4, 2019 at 5:28 PM Neil Armstrong wrote: > > > > Hi, > > > > On 04/09/2019 11:09, Cheng-yi Chiang wrote: > > > Hi, > > > > > > On Tue, Sep 3, 2019 at 5:53 PM Neil Armstrong > > > wrote: > > >> > > >> Hi, > > >> > >

Re: [PATCH] drm: bridge/dw_hdmi: add audio sample channel status setting

2019-09-04 Thread Russell King - ARM Linux admin
On Wed, Sep 04, 2019 at 05:09:29PM +0800, Cheng-yi Chiang wrote: > Hi, > > On Tue, Sep 3, 2019 at 5:53 PM Neil Armstrong wrote: > > > > Hi, > > > > On 03/09/2019 07:51, Cheng-Yi Chiang wrote: > > > From: Yakir Yang > > > > > > When transmitting IEC60985 linear PCM audio, we configure the > > >

Re: [PATCH v6 3/8] tda9950: use cec_notifier_cec_adap_(un)register

2019-08-13 Thread Russell King - ARM Linux admin
On Tue, Aug 13, 2019 at 01:02:35PM +0200, Dariusz Marcinkiewicz wrote: > Use the new cec_notifier_cec_adap_(un)register() functions to > (un)register the notifier for the CEC adapter. > > Signed-off-by: Dariusz Marcinkiewicz > Signed-off-by: Hans Verkuil > Tested-by: Hans Verkuil > --- >

Re: [PATCH v6 4/8] drm: tda998x: use cec_notifier_conn_(un)register

2019-08-13 Thread Russell King - ARM Linux admin
On Tue, Aug 13, 2019 at 01:02:36PM +0200, Dariusz Marcinkiewicz wrote: > Use the new cec_notifier_conn_(un)register() functions to > (un)register the notifier for the HDMI connector, and fill > in the cec_connector_info. > > Changes since v2: > - cec_notifier_phys_addr_invalidate where

Re: [PATCH v3 1/5] ASoC: hdmi-codec: Add an op to set callback function for plug event

2019-07-12 Thread Russell King - ARM Linux admin
On Fri, Jul 12, 2019 at 06:04:39PM +0800, Cheng-Yi Chiang wrote: > Add an op in hdmi_codec_ops so codec driver can register callback > function to handle plug event. > > Driver in DRM can use this callback function to report connector status. > > Signed-off-by: Cheng-Yi Chiang > --- >

Re: [PATCH v3 2/5] drm: bridge: dw-hdmi: Report connector status using callback

2019-07-12 Thread Russell King - ARM Linux admin
On Fri, Jul 12, 2019 at 06:04:40PM +0800, Cheng-Yi Chiang wrote: > Allow codec driver register callback function for plug event. > > The callback registration flow: > dw-hdmi <--- hw-hdmi-i2s-audio <--- hdmi-codec > > dw-hdmi-i2s-audio implements hook_plugged_cb op > so codec driver can register

Re: [PATCH 00/12] treewide: Fix GENMASK misuses

2019-07-10 Thread Russell King - ARM Linux admin
On Wed, Jul 10, 2019 at 11:17:31AM +0200, Johannes Berg wrote: > On Tue, 2019-07-09 at 22:04 -0700, Joe Perches wrote: > > These GENMASK uses are inverted argument order and the > > actual masks produced are incorrect. Fix them. > > > > Add checkpatch tests to help avoid more misuses too. > > >

[GIT PULL] ARM (for-airlie-armada branch)

2019-07-03 Thread Russell King
the simple-framebuffer Russell King (17): drm/armada: fix crtc interlace drm/armada: use __drm_atomic_helper_plane_reset in overlay reset drm/armada: add plane size/location accessors drm/armada: fix plane location and size for interlace drm/armada: add missing interlac

Re: [GIT PULL] ARM (for-airlie-armada branch)

2019-07-02 Thread Russell King - ARM Linux admin
The subject should've been "Armada updates for merge window". Sorry. On Tue, Jul 02, 2019 at 10:13:13AM +0100, Russell King wrote: > Hi David, > > The following changes since commit e93c9c99a629c61837d5a7fc2120cd2b6c70dbdd: > > Linux 5.1 (2019-05-05 17:42:58

Re: [PATCH] drm/armada: fix debugfs link error

2019-06-28 Thread Russell King - ARM Linux admin
On Fri, Jun 28, 2019 at 12:33:40PM +0200, Arnd Bergmann wrote: > Debugfs can be disabled at compile time, causing a link error > with the newly restructured code: > > drivers/gpu/drm/armada/armada_crtc.o: In function > `armada_drm_crtc_late_register': > armada_crtc.c:(.text+0x974): undefined

Re: [REGRESSION] drm/etnaviv: command buffer outside valid memory window

2019-06-27 Thread Russell King - ARM Linux admin
On Thu, Jun 27, 2019 at 04:49:30PM +0200, Lucas Stach wrote: > Am Donnerstag, den 27.06.2019, 15:32 +0100 schrieb Russell King - ARM Linux > admin: > > On Thu, Jun 27, 2019 at 11:04:17AM +0100, Russell King - ARM Linux admin > > wrote: > > > On Thu, Jun 27, 2019 at 11

Re: [PATCH] drm/etnaviv: add missing failure path to destroy suballoc

2019-06-27 Thread Russell King - ARM Linux admin
> Signed-off-by: Lucas Stach Tested-by: Russell King Thanks. > --- > drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c > b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c > ind

Re: [REGRESSION] drm/etnaviv: command buffer outside valid memory window

2019-06-27 Thread Russell King - ARM Linux admin
On Thu, Jun 27, 2019 at 11:04:17AM +0100, Russell King - ARM Linux admin wrote: > On Thu, Jun 27, 2019 at 11:20:15AM +0200, Lucas Stach wrote: > > Am Samstag, den 22.06.2019, 17:16 +0100 schrieb Russell King - ARM Linux > > admin: > > > While updating my various systems f

Re: [REGRESSION] drm/etnaviv: command buffer outside valid memory window

2019-06-27 Thread Russell King - ARM Linux admin
On Thu, Jun 27, 2019 at 11:20:15AM +0200, Lucas Stach wrote: > Am Samstag, den 22.06.2019, 17:16 +0100 schrieb Russell King - ARM Linux > admin: > > While updating my various systems for the TCP SACK issue, I notice > > that while most platforms are happy, the Cubox-i4 is not

[GIT PULL] TDA998x development updates

2019-06-26 Thread Russell King
the HDMI vendor info frame when required. Russell King (13): drm/i2c: tda998x: introduce tda998x_audio_settings drm/i2c: tda998x: implement different I2S flavours drm/i2c: tda998x: improve programming of audio divisor

Re: [PATCH 0/2] Associate ddc adapters with connectors

2019-06-25 Thread Russell King - ARM Linux admin
On Tue, Jun 25, 2019 at 04:07:55PM +0200, Daniel Vetter wrote: > Otherwise I like this. Biggest problem I'm seeing here is rolling this out > everywhere, this is a lot of work. And without widespread adoptions it's > not terribly useful for userspace. There will be cases where it's not possible,

Re: [PATCH 0/2] Associate ddc adapters with connectors

2019-06-25 Thread Russell King - ARM Linux admin
On Tue, Jun 25, 2019 at 12:14:27PM +0200, Andrzej Pietrasiewicz wrote: > Hi Russell, > > W dniu 25.06.2019 o 12:03, Russell King - ARM Linux admin pisze: > > On Tue, Jun 25, 2019 at 11:46:34AM +0200, Andrzej Pietrasiewicz wrote: > > > It is difficult for a user to know w

Re: [PATCH 0/2] Associate ddc adapters with connectors

2019-06-25 Thread Russell King - ARM Linux admin
On Tue, Jun 25, 2019 at 11:46:34AM +0200, Andrzej Pietrasiewicz wrote: > It is difficult for a user to know which of the i2c adapters is for which > drm connector. This series addresses this problem. > > The idea is to have a symbolic link in connector's sysfs directory, e.g.: > > ls -l

[REGRESSION] drm/etnaviv: command buffer outside valid memory window

2019-06-22 Thread Russell King - ARM Linux admin
While updating my various systems for the TCP SACK issue, I notice that while most platforms are happy, the Cubox-i4 is not. During boot, we get: [0.00] cma: Reserved 256 MiB at 0x3000 ... [0.00] Kernel command line: console=ttymxc0,115200n8 console=tty1

Re: [PATCH v1 1/2] drm/i2c: tda998x: access chip registers via a regmap

2019-06-21 Thread Russell King - ARM Linux admin
On Fri, Jun 21, 2019 at 05:13:33PM -0400, Sven Van Asbroeck wrote: > On Fri, Jun 21, 2019 at 11:15 AM Russell King - ARM Linux admin > wrote: > > > > Another con is the need to keep the functions that detail the register > > properties up to date, which if they're wrong

Re: [PATCH v1 2/2] drm/i2c: tda998x: remove indirect reg_read/_write() calls

2019-06-21 Thread Russell King - ARM Linux admin
On Mon, May 27, 2019 at 03:15:52PM -0400, Sven Van Asbroeck wrote: > -static void > -reg_set(struct tda998x_priv *priv, u16 reg, u8 val) > +static int > +reg_set(struct regmap *regmap, u16 reg, u8 val) I don't see the point of making this return an 'int' - you don't modify any of the callsites to

Re: [PATCH v1 1/2] drm/i2c: tda998x: access chip registers via a regmap

2019-06-21 Thread Russell King - ARM Linux admin
On Mon, May 27, 2019 at 03:15:51PM -0400, Sven Van Asbroeck wrote: > The tda988x i2c chip registers are accessed through a > paged register scheme. The kernel regmap abstraction > supports paged accesses. Replace this driver's > dedicated i2c access functions with a standard i2c > regmap. > >

[PATCH v2 01/13] drm/i2c: tda998x: introduce tda998x_audio_settings

2019-06-14 Thread Russell King
specification. Signed-off-by: Russell King --- drivers/gpu/drm/i2c/tda998x_drv.c | 68 +-- 1 file changed, 37 insertions(+), 31 deletions(-) diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c index 7f34601bb515..0668fb3537f2 100644

[PATCH 08/18] drm/armada: add comments about HWC32 cursor colour format

2019-06-14 Thread Russell King
Add some comments about the format of the HWC32 cursor colour format. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_crtc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/armada/armada_crtc.c b/drivers/gpu/drm/armada/armada_crtc.c index 5991feb1bcc9

[PATCH 06/18] drm/armada: move plane address and pitch calculation to atomic_check

2019-06-14 Thread Russell King
Move the plane address and pitch calculations to atomic_check rather than the update function, so we don't have to probe the interlace setting for the CRTC while updating the plane. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_overlay.c | 23 ++- drivers/gpu

[PATCH v2 13/13] drm/i2c: tda998x: add vendor specific infoframe support

2019-06-14 Thread Russell King
Add support for the vendor specific infoframe. Reviewed-by: Brian Starkey Signed-off-by: Russell King --- drivers/gpu/drm/i2c/tda998x_drv.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c index

[PATCH 18/18] drm/armada: no need to check parent of remote

2019-06-14 Thread Russell King
There's no need to check the parent of the remote device to check whether it is available or not, the remote is the device itself. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_drv.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/gpu

[PATCH 13/18] drm/armada: improve Dove clock selection

2019-06-14 Thread Russell King
Improve the Dove (Armada 510) LCD clock selection and divider calculation, limiting to the valid divisor values, and reporting an error if the clock is not achievable within the bounds of HDMI clocking requirements. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_510.c | 121

[PATCH 14/18] drm/armada: use mode_valid to validate the adjusted mode

2019-06-14 Thread Russell King
Validate the adjusted mode in the CRTC mode_fixup() call to ensure that any encoder or bridge doesn't supply us with a mode we can't support. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_crtc.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff

[PATCH 02/18] drm/armada: use __drm_atomic_helper_plane_reset in overlay reset

2019-06-14 Thread Russell King
Use the __drm_atomic_helper_plane_reset() helper in the overlay reset code to ensure that generic features are correctly reset in future. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_overlay.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers

[PATCH 16/18] drm/armada: replace the simple-framebuffer

2019-06-14 Thread Russell King
From: Lubomir Rintel If there's a simple-framebuffer carried over from boot firmware, it's going to stop working once we setup the LCDC for use via DRM. Kick it off from the hardware. Signed-off-by: Lubomir Rintel Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_drv.c | 11

[PATCH 01/18] drm/armada: fix crtc interlace

2019-06-14 Thread Russell King
We support interlace, but this was broken when we could no longer get a ref on the vblank interrupt. Arrange to get the ref on the vblank interrupt after we've re-enabled vblank, and put it before we disable the vblank. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_crtc.c | 15

[PATCH 04/18] drm/armada: fix plane location and size for interlace

2019-06-14 Thread Russell King
private plane state structure. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_hw.h | 15 --- drivers/gpu/drm/armada/armada_overlay.c | 15 --- drivers/gpu/drm/armada/armada_plane.c | 80 +++-- drivers/gpu/drm/armada/armada_plane.h | 20

[PATCH 12/18] drm/armada: add CRTC mode validation

2019-06-14 Thread Russell King
Add CRTC mode validation to reject modes that the CRTC does not support. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_crtc.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/gpu/drm/armada/armada_crtc.c b/drivers/gpu/drm/armada/armada_crtc.c

[PATCH 05/18] drm/armada: add missing interlaced support for overlay frame

2019-06-14 Thread Russell King
Interlaced support has been missing from the overlay frame, which is sub-optimal. Add support for this missing feature. Signed-off-by: Russell King --- drivers/gpu/drm/armada/armada_overlay.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/armada

[PATCH v2 07/13] drm/i2c: tda998x: configure both fields of AIP_CLKSEL together

2019-06-14 Thread Russell King
We can configure both fields of the AIP_CLKSEL register with a single write, there is no need to delay the setting of the CTS reference. Signed-off-by: Russell King --- drivers/gpu/drm/i2c/tda998x_drv.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers

[PATCH v2 08/13] drm/i2c: tda998x: move audio routing configuration

2019-06-14 Thread Russell King
Move the mux and clocking selection out of tda998x_configure_audio() into the parent functions, so we can validate this when parameters are set outside of the audio mutex. Signed-off-by: Russell King --- drivers/gpu/drm/i2c/tda998x_drv.c | 78 +++ 1 file

[PATCH v2 05/13] drm/i2c: tda998x: store audio port enable in settings

2019-06-14 Thread Russell King
Store the audio port enable register in the audio settings structure, which can never be zero for a valid audio configuration. Use this to signal whether we have audio configured, rather than AFMT_UNUSED. Signed-off-by: Russell King --- drivers/gpu/drm/i2c/tda998x_drv.c | 18

  1   2   3   4   5   6   7   8   9   10   >