[PATCH v1 08/11] drm/via: Move the via driver to drm/dri1/

2022-07-16 Thread Sam Ravnborg
drm/dri1 is the new home for all the legacy DRI1 drivers. Used the opportunity to rename the file to via.c to match the name of the driver. Signed-off-by: Sam Ravnborg Suggested-by: Javier Martinez Canillas --- drivers/gpu/drm/Makefile | 1 - drivers/gpu/drm/dri1

[PATCH v1 02/11] drm: Rename CONFIG_DRM_LEGACY to CONFIG_DRM_DRI1

2022-07-16 Thread Sam Ravnborg
The rename is done to make it more obvious what is DRI1 drivers and what is other type of legacy. Signed-off-by: Sam Ravnborg --- arch/powerpc/configs/pmac32_defconfig | 2 +- arch/powerpc/configs/ppc6xx_defconfig | 2 +- drivers/char/agp/Makefile | 2 +- drivers/char/agp/agp.h

[PATCH v1 04/11] drm/r128: Move the r128 driver to drm/dri1/

2022-07-16 Thread Sam Ravnborg
drm/dri1 is the new home for all the legacy DRI1 drivers. Signed-off-by: Sam Ravnborg Suggested-by: Javier Martinez Canillas --- drivers/gpu/drm/Makefile | 1 - drivers/gpu/drm/dri1/Makefile | 1 + drivers/gpu/drm/{ => dri1}/r128/Makefile | 0 driv

[PATCH v1 01/11] drm: rename DRIVER_LEGACY to DRIVER_DRI1

2022-07-16 Thread Sam Ravnborg
"legacy" is a general term - be specific and use the term dri1. The first step is to rename DRIVER_LEGACY to DRIVER_DRI1. Suggested-by: Javier Martinez Canillas Signed-off-by: Sam Ravnborg --- drivers/gpu/drm/drm_agpsupport.c| 4 ++-- drivers/gpu/drm/drm_bufs.c

[PATCH v1 0/11] drm: move dri1 drivers to drm/dri1/

2022-07-16 Thread Sam Ravnborg
in the last commit. The DRI1 specific part of drm/Kconfig is likewise pulled out and located in the dri1/ folder. Feedback welcome! Sam Sam Ravnborg (11): drm: rename DRIVER_LEGACY to DRIVER_DRI1 drm: Rename CONFIG_DRM_LEGACY to CONFIG_DRM_DRI1 drm/tdfx: Move the tdfx driver

[PATCH v2 13/13] drm/via: Fix style issues in via_3d_reg header

2022-07-13 Thread Sam Ravnborg
- Fix comments using wrong style - Drop repeated word This fixes all checkpatch complains and makes the file a little bit easier to read - as the eye is not distracted by the style violations. Suggested-by: Thomas Zimmermann Signed-off-by: Sam Ravnborg Cc: Kevin Brace --- drivers/gpu/drm/via

[PATCH v2 10/13] drm/via: Update to the latest via_3d_reg header

2022-07-13 Thread Sam Ravnborg
Updated the 3d_reg header file to match what is used by the openchrome driver. This verifies that the two drivers can use the same header file. The file is a verbatim copy from the openchrome repo - a few style issues will be fixed in following commits. Signed-off-by: Sam Ravnborg Cc: Kevin

[PATCH v2 12/13] drm/via: Make macros readable in the via_3d_reg header

2022-07-13 Thread Sam Ravnborg
Suggested-by: Thomas Zimmermann Signed-off-by: Sam Ravnborg Cc: Kevin Brace --- drivers/gpu/drm/via/via_3d_reg.h | 222 +++ 1 file changed, 74 insertions(+), 148 deletions(-) diff --git a/drivers/gpu/drm/via/via_3d_reg.h b/drivers/gpu/drm/via/via_3d_reg.h index 87

[PATCH v2 11/13] drm/via: Use SPDX tag for MIT license in via_3d_reg header

2022-07-13 Thread Sam Ravnborg
The license for the via_3d_reg header is MIT - so use the shorter SPDX tag to identify the license. Suggested-by: Thomas Zimmermann Signed-off-by: Sam Ravnborg Cc: Kevin Brace --- drivers/gpu/drm/via/via_3d_reg.h | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff

[PATCH v2 09/13] drm/via: Embed via_drv.h in via_dri1

2022-07-13 Thread Sam Ravnborg
With this change the driver is now a signle file driver. The only remaning heder file describes the HW and can be shared with the new openchrome driver. Signed-off-by: Sam Ravnborg Acked-by: Thomas Zimmermann Cc: Kevin Brace --- drivers/gpu/drm/via/via_dri1.c | 229

[PATCH v2 07/13] drm/via: Embed via_dmablit in via_dri1

2022-07-13 Thread Sam Ravnborg
Embed some of the header file in via_drv.h and the rest in via_dri1.c While embedding deleted extra empty lines and functions that has no external users are made static. Signed-off-by: Sam Ravnborg Acked-by: Thomas Zimmermann Cc: Kevin Brace --- drivers/gpu/drm/via/Makefile | 2

[PATCH v2 08/13] drm/via: Embed via_verifier in via_dri1

2022-07-13 Thread Sam Ravnborg
Embed the header file in via_drv.h and the code in via_dri1. All functions are made static as there are no more external users. Signed-off-by: Sam Ravnborg Acked-by: Thomas Zimmermann Cc: Kevin Brace --- drivers/gpu/drm/via/Makefile |2 +- drivers/gpu/drm/via/via_dri1.c | 1071

[PATCH v2 04/13] drm/via: Embed via_mm in via_dri1

2022-07-13 Thread Sam Ravnborg
All functions was made static as there are no external users. Signed-off-by: Sam Ravnborg Acked-by: Thomas Zimmermann Cc: Kevin Brace --- drivers/gpu/drm/via/Makefile | 2 +- drivers/gpu/drm/via/via_dri1.c | 208 drivers/gpu/drm/via/via_drv.h | 9

[PATCH v2 05/13] drm/via: Embed via_video in via_dri1

2022-07-13 Thread Sam Ravnborg
All functions are made static as there are no more external users. The file had a new copyright that is kept. Signed-off-by: Sam Ravnborg Acked-by: Thomas Zimmermann Cc: Kevin Brace --- drivers/gpu/drm/via/Makefile| 2 +- drivers/gpu/drm/via/via_dri1.c | 66

[PATCH v2 06/13] drm/via: Embed via_irq in via_dri1

2022-07-13 Thread Sam Ravnborg
All functions are made static as there are no more external users. The file had new copyrights that are kept. Signed-off-by: Sam Ravnborg Acked-by: Thomas Zimmermann Cc: Kevin Brace --- drivers/gpu/drm/via/Makefile | 2 +- drivers/gpu/drm/via/via_dri1.c | 347

[PATCH v2 03/13] drm/via: Embed via_map in via_dri1

2022-07-13 Thread Sam Ravnborg
A few functions has no external use and are made static. Signed-off-by: Sam Ravnborg Acked-by: Thomas Zimmermann Cc: Kevin Brace --- drivers/gpu/drm/via/Makefile | 2 +- drivers/gpu/drm/via/via_dri1.c | 102 + drivers/gpu/drm/via/via_drv.h | 4 - drivers/gpu/drm

[PATCH v2 02/13] drm/via: Embed via_dma in via_dri1

2022-07-13 Thread Sam Ravnborg
Moved the copyright notices so all copyrights are kept. A few variables was made static as there are no more users outside this file. Signed-off-by: Sam Ravnborg Acked-by: Thomas Zimmermann Cc: Kevin Brace --- drivers/gpu/drm/via/Makefile | 2 +- drivers/gpu/drm/via/via_dma.c | 744

[PATCH v2 01/13] drm/via: Rename via_drv to via_dri1

2022-07-13 Thread Sam Ravnborg
with the new driver. Signed-off-by: Sam Ravnborg Acked-by: Thomas Zimmermann Cc: Kevin Brace --- drivers/gpu/drm/via/Makefile | 2 +- drivers/gpu/drm/via/{via_drv.c => via_dri1.c} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename drivers/gpu/drm/via/{via_dr

[PATCH v2 0/11] drm/via: Make via a single file driver

2022-07-13 Thread Sam Ravnborg
to do it. Note: The patches has seen zero run-time testing - I only know they builds in my setup (for several archs). Sam Sam Ravnborg (13): drm/via: Rename via_drv to via_dri1 drm/via: Embed via_dma in via_dri1 drm/via: Embed via_map in via_dri1 drm/via: Embed via_mm

Re: [PATCH 2/2] gpu/drm/panel: Add Sony TD4353 JDI panel driver

2022-07-13 Thread Sam Ravnborg
Hi Konrad, thanks for submitting this driver. I know a new version is pending with the bindings changes but here is a few more things to address. Sam On Tue, Jul 12, 2022 at 10:02:41PM +0200, Konrad Dybcio wrote: > Add support for the Sony TD4353 JDI 2160x1080 display panel used in >

Re: [PATCH v3 00/10] drm: Add support for low-color frame buffer formats

2022-07-11 Thread Sam Ravnborg
Hi Thomas, On Mon, Jul 11, 2022 at 10:50:00AM +0200, Thomas Zimmermann wrote: > Hi > > Am 09.07.22 um 15:38 schrieb Sam Ravnborg: > > Hi Geert, > > > > On Fri, Jul 08, 2022 at 08:20:45PM +0200, Geert Uytterhoeven wrote: > > > Hi all, > > >

Re: [RFC PATCH v2 1/2] drm/bridge: ti-sn65dsi86: fetch bpc using drm_atomic_state

2022-07-11 Thread Sam Ravnborg
. > > Reviewed-by: Sam Ravnborg > Reviewed-by: Laurent Pinchart > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 22 -- > 1 file changed, 16 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/ti-

Re: [PATCH v1 0/11] drm/via: Make via a single file driver

2022-07-11 Thread Sam Ravnborg
the series > > Acked-by: Thomas Zimmermann Thanks! > > with suggestions below. > > Am 10.07.22 um 10:54 schrieb Sam Ravnborg: > > We have an upcoming openchrome driver for VIA where some > > of the files conflicts with the existing via driver. > > > >

Re: [RFC PATCH 3/3] drm/bridge: ti-sn65dsi86: support DRM_BRIDGE_ATTACH_NO_CONNECTOR

2022-07-10 Thread Sam Ravnborg
Hi Dmitry, On Sun, Jul 10, 2022 at 09:45:36PM +0300, Dmitry Baryshkov wrote: > Now as the driver does not depend on pdata->connector, add support for > attaching the bridge with DRM_BRIDGE_ATTACH_NO_CONNECTOR. > > Signed-off-by: Dmitry Baryshkov Looks good, Reviewed-by: Sam Ravnborg

Re: [RFC PATCH 2/3] drm/bridge: ti-sn65dsi86: fetch bpc using drm_atomic_state

2022-07-10 Thread Sam Ravnborg
if (!connector) > + return; It would be prudent with a dev_err() logging here as we do not expect to fail. I looked into something similar, but with a less elegant solution, and could not convince myself that the display driver would create the connector before ti_sn_bridge_atomic_e

Re: [RFC PATCH 1/3] drm/bridge: ti-sn65dsi86: switch to atomic ops

2022-07-10 Thread Sam Ravnborg
Hi Dmitry, On Sun, Jul 10, 2022 at 09:45:34PM +0300, Dmitry Baryshkov wrote: > Make ti-sn65dsi86 use atomic_enable / atomic_disable / atomic_pre_enable > / atomic_post_disable rather than their non-atomic versions. > > Signed-off-by: Dmitry Baryshkov a more or less identical patch was applied

Re: [PATCH libdrm v2 01/10] util: Improve SMPTE color LUT accuracy

2022-07-10 Thread Sam Ravnborg
Hi Geert, On Sun, Jul 10, 2022 at 01:04:23PM +0200, Geert Uytterhoeven wrote: > Hi Sam, > > On Sun, Jul 10, 2022 at 12:31 PM Sam Ravnborg wrote: > > On Fri, Jul 08, 2022 at 08:21:31PM +0200, Geert Uytterhoeven wrote: > > > Fill in the LSB when converting color compone

Re: [PATCH libdrm v2 00/10] Add support for low-color frame buffer formats

2022-07-10 Thread Sam Ravnborg
at I have browsed the patches - everything looked good. The parts with Floyd-Steinberg dithering did get less attention as I do not know it. But everything looked good and the series is: Acked-by: Sam Ravnborg Sam

Re: [PATCH libdrm v2 01/10] util: Improve SMPTE color LUT accuracy

2022-07-10 Thread Sam Ravnborg
* 0x101; \ (lut[idx].red = (r) << 8) | 1; had IMO been easier to read. Patch is: Acked-by: Sam Ravnborg for both ways to do it. > + lut[idx].green = (g) * 0x101; \ > + lut[idx].blue = (b) * 0x101 > > FILL_COLOR( 0, 192, 192, 192); /* grey */ > FILL_COLOR( 1, 192, 192, 0 ); /* yellow */ > -- > 2.25.1

Re: [PATCH v2 1/2] dt-bindings: display: panel: Add Novatek NT35596S panel bindings

2022-07-10 Thread Sam Ravnborg
Hi Molly, On Sun, Jul 10, 2022 at 02:19:41PM +0800, Molly Sophia wrote: > Hi Sam, > > Thanks for your suggestions. > > Sam Ravnborg 于 2022年7月10日周日 上午4:47写道: > > > Hi Molly, > > > > thanks for the quick response to the review comments. > > &g

[PATCH v1 11/11] drm/via: Update to the latest via_3d_reg file

2022-07-10 Thread Sam Ravnborg
Updated the 3d_reg header file to match what is used by the openchrome driver. This verifies that the two drivers can use the same header file. Signed-off-by: Sam Ravnborg --- drivers/gpu/drm/via/via_3d_reg.h | 395 --- 1 file changed, 304 insertions(+), 91 deletions

[PATCH v1 10/11] drm/via: Rename the via driver to via_dri1

2022-07-10 Thread Sam Ravnborg
The via driver is a dri1 driver. Make this obvious in the name of the driver. This also make the diver name "via" free for the upcoming openchrome driver. Signed-off-by: Sam Ravnborg --- drivers/gpu/drm/via/Makefile | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH v1 08/11] drm/via: Embed via_verifier in via_dri1

2022-07-10 Thread Sam Ravnborg
Embed the header file in via_drv.h and the code in via_dri1. All functions are made static as there are no more external users. Signed-off-by: Sam Ravnborg --- drivers/gpu/drm/via/Makefile |2 +- drivers/gpu/drm/via/via_dri1.c | 1071 +++ drivers/gpu/drm

[PATCH v1 09/11] drm/via: Embed via_drv.h in via_dri1

2022-07-10 Thread Sam Ravnborg
With this change the driver is now a signle file driver. The only remaning heder file describes the HW and can be shared with the new openchrome driver. Signed-off-by: Sam Ravnborg --- drivers/gpu/drm/via/via_dri1.c | 229 +++- drivers/gpu/drm/via/via_drv.h | 265

[PATCH v1 05/11] drm/via: Embed via_video in via_dri1

2022-07-10 Thread Sam Ravnborg
All functions are made static as there are no more external users. The file had a new copyright that is kept. Signed-off-by: Sam Ravnborg --- drivers/gpu/drm/via/Makefile| 2 +- drivers/gpu/drm/via/via_dri1.c | 66 ++- drivers/gpu/drm/via/via_drv.h | 4 -- drivers

[PATCH v1 07/11] drm/via: Embed via_dmablit in via_dri1

2022-07-10 Thread Sam Ravnborg
Embed some of the header file in via_drv.h and the rest in via_dri1.c While embedding deleted extra empty lines and functions that has no external users are made static. Signed-off-by: Sam Ravnborg --- drivers/gpu/drm/via/Makefile | 2 +- drivers/gpu/drm/via/via_dmablit.c | 807

[PATCH v1 06/11] drm/via: Embed via_irq in via_dri1

2022-07-10 Thread Sam Ravnborg
All functions are made static as there are no more external users. The file had new copyrights that are kept. Signed-off-by: Sam Ravnborg --- drivers/gpu/drm/via/Makefile | 2 +- drivers/gpu/drm/via/via_dri1.c | 347 + drivers/gpu/drm/via/via_drv.h | 9

[PATCH v1 03/11] drm/via: Embed via_map in via_dri1

2022-07-10 Thread Sam Ravnborg
A few functions has no external use and are made static. Signed-off-by: Sam Ravnborg --- drivers/gpu/drm/via/Makefile | 2 +- drivers/gpu/drm/via/via_dri1.c | 102 + drivers/gpu/drm/via/via_drv.h | 4 - drivers/gpu/drm/via/via_map.c | 132

[PATCH v1 04/11] drm/via: Embed via_mm in via_dri1

2022-07-10 Thread Sam Ravnborg
All functions was made static as there are no external users. Signed-off-by: Sam Ravnborg --- drivers/gpu/drm/via/Makefile | 2 +- drivers/gpu/drm/via/via_dri1.c | 208 drivers/gpu/drm/via/via_drv.h | 9 -- drivers/gpu/drm/via/via_mm.c | 241

[PATCH v1 02/11] drm/via: Embed via_dma in via_dri1

2022-07-10 Thread Sam Ravnborg
Moved the copyright notices so all copyrights are kept. A few variables was made static as there are no more users outside this file. Signed-off-by: Sam Ravnborg --- drivers/gpu/drm/via/Makefile | 2 +- drivers/gpu/drm/via/via_dma.c | 744 - drivers/gpu/drm

[PATCH v1 01/11] drm/via: Rename via_drv to via_dri1

2022-07-10 Thread Sam Ravnborg
with the new driver. Signed-off-by: Sam Ravnborg --- drivers/gpu/drm/via/Makefile | 2 +- drivers/gpu/drm/via/{via_drv.c => via_dri1.c} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename drivers/gpu/drm/via/{via_drv.c => via_dri1.c} (100%) diff --git a/drivers/g

[PATCH v1 0/11] drm/via: Make via a single file driver

2022-07-10 Thread Sam Ravnborg
with the one used in the openchrome driver. This was added to verify that the new header would not break the DRI1 driver. Sam Sam Ravnborg (11): drm/via: Rename via_drv to via_dri1 drm/via: Embed via_dma in via_dri1 drm/via: Embed via_map in via_dri1 drm/via: Embed via_mm

Re: [PATCH v2 1/2] dt-bindings: display: panel: Add Novatek NT35596S panel bindings

2022-07-09 Thread Sam Ravnborg
Hi Molly, thanks for the quick response to the review comments. On Sat, Jul 09, 2022 at 10:11:35PM +0800, MollySophia wrote: > Add documentation for "novatek,nt35596s" panel. > > Signed-off-by: MollySophia The s-o-b needs your real name - guess the above is a concatenation of first name and

Re: [PATCH v3 1/4] drm/lcdif: Clean up headers

2022-07-09 Thread Sam Ravnborg
pport for i.MX8MP LCDIF variant") > Signed-off-by: Marek Vasut > Cc: Alexander Stein > Cc: Laurent Pinchart > Cc: Liu Ying > Cc: Lucas Stach > Cc: Marek Vasut > Cc: Martyn Welch > Cc: Peng Fan > Cc: Robby Cai > Cc: Sam Ravnborg > Cc: Stefan Agner Not

Re: [PATCH v2] drm/fb: Improve drm_framebuffer.offsets documentation

2022-07-09 Thread Sam Ravnborg
/it/its/. > > Signed-off-by: Geert Uytterhoeven > Acked-by: Sam Ravnborg > Reviewed-by: Simon Ser More doc improvements - good! Applied to drm-misc (drm-misc-next). Sam

Re: [PATCH 2/3] drm/panel: simple: add support for the Samsung LTL101AL01 panel

2022-07-09 Thread Sam Ravnborg
Hi Martin, the patch looks good. On Mon, May 16, 2022 at 09:37:08PM +0200, Martin Jücker wrote: > Add timings and panel description for the Samsung LTL101AL01 panel. > > Signed-off-by: Martin Jücker Applied to drm-misc (drm-misc-next). Sam

Re: [PATCH 1/3] dt-bindings: display: simple: add support for Samsung LTL101AL01

2022-07-09 Thread Sam Ravnborg
Hi Martin, On Mon, May 16, 2022 at 09:37:07PM +0200, Martin Jücker wrote: > Add the Samsung LTL101AL01 WXGA LCD panel to the list. > > Signed-off-by: Martin Jücker Applied to drm-misc (drm-misc-next). Sam

Re: [PATCH v3] drm/mode: Improve drm_mode_fb_cmd2 documentation

2022-07-09 Thread Sam Ravnborg
Hi Geert, On Wed, Jul 06, 2022 at 03:20:18PM +0200, Geert Uytterhoeven wrote: > Fix various grammar mistakes in the kerneldoc comments documenting the > drm_mode_fb_cmd2 structure: > - s/is/are/, > - s/8 bit/8-bit/. > > Signed-off-by: Geert Uytterhoeven > Acked-by: Sam

Re: [PATCH v3 00/10] drm: Add support for low-color frame buffer formats

2022-07-09 Thread Sam Ravnborg
Hi Geert, On Fri, Jul 08, 2022 at 08:20:45PM +0200, Geert Uytterhoeven wrote: > Hi all, > > A long outstanding issue with the DRM subsystem has been the lack of > support for low-color displays, as used typically on older desktop > systems, and on small embedded displays. IT is super to

Re: [PATCH] drm: panel: Add novatek nt35596s panel driver

2022-07-09 Thread Sam Ravnborg
Hi Molly, Thanks for submitting this driver. A few comments follows - the most relevant is the error handling when unprepare/disable. Please take a look and re-submit. Sam On Fri, Jul 08, 2022 at 10:18:23AM +0800, MollySophia wrote: > Novatek NT35596s is a generic DSI IC that drives

Re: [PATCH 2/2] dt-bindings: display: panel: Add Novatek NT35596S panel bindings

2022-07-09 Thread Sam Ravnborg
Hi Molly, On Fri, Jul 08, 2022 at 10:18:24AM +0800, MollySophia wrote: > Add documentation for "novatek,nt35596s" panel. As a general note, we cannot apply a driver without the binding. So this patch should be the first in the series. Not a big deal, but it makes it easier on the committer

Re: [PATCH 2/3] drm/panel-novatek-nt35510: Emit an error message if power off fails

2022-07-09 Thread Sam Ravnborg
Hi Uwe, On Fri, Jul 08, 2022 at 11:49:21AM +0200, Uwe Kleine-König wrote: > Returning an error code from a mipi_dsi remove callback fails, this is > silently ignored. (mipi_dsi_drv_remove() propagates the return value to > device_remove() which ignores it.) So emit an error code in the driver >

Re: [PATCH 1/3] drm/panel: simple: Make panel_simple_remove() return void

2022-07-09 Thread Sam Ravnborg
Hi Uwe, On Fri, Jul 08, 2022 at 11:49:20AM +0200, Uwe Kleine-König wrote: > panel_simple_remove() returns zero unconditionally. Make it return no value > instead making more obvious what happens in the callers. > > This is a preparation for making platform and mipi-dsi remove callbacks > return

Re: [PATCH 3/3] drm/mipi-dsi: Make remove callback return void

2022-07-09 Thread Sam Ravnborg
On Fri, Jul 08, 2022 at 11:49:22AM +0200, Uwe Kleine-König wrote: > All implementations return 0 and the return value of mipi_dsi_drv_remove() > is ignored anyhow. > > So change the prototype of the remove function to return no value. This > way driver authors are not tempted to assume that

Re: [PATCH v2 1/4] drm/lcdif: Clean up headers

2022-07-09 Thread Sam Ravnborg
Hi Marek, On Sat, Jul 09, 2022 at 03:17:43AM +0200, Marek Vasut wrote: > Drop unneeded headers, sort rest alphabetically, no functional change. This and the following 3 patches are all: Acked-by: Sam Ravnborg Sam

Re: [PATCH 0/6] drm/ingenic: JZ4760(B) support and random changes

2022-07-09 Thread Sam Ravnborg
could see the code being a tad simpler, but the cost was more EXPORTs. With the added explanation, which you can add when applying, all patches are: Acked-by: Sam Ravnborg Sam

Re: [PATCH 00/14] drm/mgag200: Move model-specific code into separate functions

2022-07-08 Thread Sam Ravnborg
then later this is all nicely cleaned up. Especially the pll setup stuff did not get much scrunity, as it like most of the patch looked like code movements. All patches except "Move DAC-register setup into model-specific code" are: Acked-by: Sam Ravnborg > 14 files changed, 280

Re: [PATCH 14/14] drm/mgag200: Remove type field from struct mga_device

2022-07-08 Thread Sam Ravnborg
On Fri, Jul 08, 2022 at 11:39:29AM +0200, Thomas Zimmermann wrote: > Each model's specific code is located in a separate file. The type > field in struct mga_device is no unused. Remove it. s/no/now/ > > Signed-off-by: Thomas Zimmermann

Re: [PATCH 02/14] drm/mgag200: Move DAC-register setup into model-specific code

2022-07-08 Thread Sam Ravnborg
Hi Thomas, On Fri, Jul 08, 2022 at 11:39:17AM +0200, Thomas Zimmermann wrote: > Provide an init function for each model's DAC registers. Remove > the shared helper. > > The code for initializing the DAC registers consisted of a large > table of default value, plus many exceptions for the various

Re: [PATCH v5 0/3] Support Sharp LQ101R1SX03 and HannStar HSD101PWW2 panels

2022-07-04 Thread Sam Ravnborg
Hi Dmitry, On Thu, Jun 30, 2022 at 08:23:06PM +0300, Dmitry Osipenko wrote: > Hello Sam, > > On 5/29/22 21:05, Svyatoslav Ryhel wrote: > > This series adds support for Sharp LQ101R1SX03 and HannStar HSD101PWW2 > > display panels that are used by Asus Transformer tablets, which we're > > planning

[PATCH v2 1/1] drm/bridge: ti-sn65dsi86: Use atomic variants of drm_bridge_funcs

2022-07-04 Thread Sam Ravnborg
Move away from the deprecated enable/disable operations in drm_bridge_funcs and enable atomic use. v3: - Drop use of DRM_BRIDGE_STATE_OPS v2: - fix build (kernel test robot ) Signed-off-by: Sam Ravnborg Cc: Kieran Bingham Cc: Douglas Anderson Cc: Andrzej Hajda Cc: Neil Armstrong Cc

[PATCH v2 0/1] bridge/ti-sn65dsi86.c: convert to atomic operations

2022-07-04 Thread Sam Ravnborg
the first time. Sam Sam Ravnborg (1): drm/bridge: ti-sn65dsi86: Use atomic variants of drm_bridge_funcs drivers/gpu/drm/bridge/ti-sn65dsi86.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-)

Re: [PATCH 1/2] dt-bindings: display: simple: add EDT ETML0700Y5DHA panel

2022-07-04 Thread Sam Ravnborg
Hi Marco, On Mon, May 30, 2022 at 02:24:06PM +0200, Marco Felsch wrote: > Add binding for the Emerging Display Technology ETML0700Y5DHA panel. > It is a 7" WSVGA (1024x600) TFT LCD panel with: > - LVDS data interface, > - backlight and > - capacitive touch. > > Signed-off-by: Marco Felsch I

[PATCH v2 1/1] drm/bridge: ti-sn65dsi86: Use atomic variants of drm_bridge_funcs

2022-07-04 Thread Sam Ravnborg
Move away from the deprecated enable/disable operations in drm_bridge_funcs and enable atomic use. v3: - Drop use of DRM_BRIDGE_STATE_OPS v2: - fix build (kernel test robot ) Signed-off-by: Sam Ravnborg Cc: Kieran Bingham Cc: Douglas Anderson Cc: Andrzej Hajda Cc: Neil Armstrong Cc

[PATCH v2 0/1] bridge/ti-sn65dsi86.c: convert to atomic operations

2022-07-04 Thread Sam Ravnborg
/20220206154405.124-1-...@ravnborg.org/ Sam Sam Ravnborg (1): drm/bridge: ti-sn65dsi86: Use atomic variants of drm_bridge_funcs drivers/gpu/drm/bridge/ti-sn65dsi86.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-)

Re: [PATCH] drm/ingenic: Use the highest possible DMA burst size

2022-07-04 Thread Sam Ravnborg
rride the old value of the > burst size. (Note that regmap_set_bits() wasn't really valid before for > the same reason, but it never seemed to be a problem). > > Cc: > Fixes: 90b86fcc47b4 ("DRM: Add KMS driver for the Ingenic JZ47xx SoCs") > Signed-off-by: Paul Cercueil Acked-by: Sam Ravnborg

Re: [PATCH] drm/panel: nt35510: Remove duplicate 'the' in two places.

2022-07-04 Thread Sam Ravnborg
Hi Jiang, On Tue, Jun 21, 2022 at 10:01:51PM +0800, Jiang Jian wrote: > file: ./drivers/gpu/drm/panel/panel-novatek-nt35510.c > line: 193,214,253 > * amplification for the the step-up circuit: > changed to > * amplification for the step-up circuit: > > Signed-off-by: Jiang Jian Thanks -

Re: [PATCH 00/28] OpenChrome DRM for Linux 5.20

2022-06-27 Thread Sam Ravnborg
Hi Kevin/Thomas, > > I had a brief look over the patches. Even though the code looks fairly rough > in places, I think we should get this driver merged ASAP. Agreed, we have a had a few cases where we dragged out committing much too long time. Timing wise, it would be good if we can already

Re: [PATCH 0/1] Delete VIA DRM

2022-06-26 Thread Sam Ravnborg
Hi Kevin, On Sat, Jun 25, 2022 at 09:56:40PM -0500, Kevin Brace wrote: > From: Kevin Brace > > This patch is a supplemental patch to delete VIA DRM so that the proposed > OpenChrome DRM module can be compiled against drm-next-2022-06-03-1 tag of > drm-next branch. > Apply this patch first

Re: [PATCH 11/28] drm/via: Add via_drv.c

2022-06-25 Thread Sam Ravnborg
Hi Kevin, a few nitpicks in the following. Sam On Fri, Jun 24, 2022 at 03:26:16PM -0500, Kevin Brace wrote: > From: Kevin Brace > > Note that GPL is chosen as a license type. This is due to via_i2c.c > being GPL based. Everything else is MIT license based. It would be nice to have a

Re: [PATCH 08/28] drm/via: Add via_cursor.c

2022-06-25 Thread Sam Ravnborg
Hi Kevin, a few nitpicks in the following. Sam On Fri, Jun 24, 2022 at 03:26:13PM -0500, Kevin Brace wrote: > From: Kevin Brace > > Signed-off-by: Kevin Brace > --- > drivers/gpu/drm/via/via_cursor.c | 419 +++ > 1 file changed, 419 insertions(+) >

Re: [PATCH 04/28] drm/via: Add via_drv.h

2022-06-25 Thread Sam Ravnborg
Hi Kevin, A few nitpicks in the following. Sam On Fri, Jun 24, 2022 at 03:26:09PM -0500, Kevin Brace wrote: > From: Kevin Brace > > Main header file for the module. > > Signed-off-by: Kevin Brace > --- > drivers/gpu/drm/via/via_drv.h | 437 ++ > 1

Re: [PATCH 00/28] OpenChrome DRM for Linux 5.20

2022-06-24 Thread Sam Ravnborg
Hi Kevin, On Fri, Jun 24, 2022 at 03:26:05PM -0500, Kevin Brace wrote: > From: Kevin Brace > > Hi Dave and Daniel, > > This is my first attempt (this is not a RFC posting) in trying to get > OpenChrome DRM pulled in for Linux 5.20. I tried to apply the patches one-by-one but they fail as they

Re: [PATCH 3/3] drm: panel: Add driver for ClockworkPi cwd686 panel

2022-06-24 Thread Sam Ravnborg
Hi Max, On Wed, Jun 01, 2022 at 12:17:48AM -0500, Max Fierke wrote: > The ClockworkPi DevTerm (all models) uses a 6.86" IPS display > of unknown provenance, which uses the Chipone ICNL9707 IC driver. > > The display panel I have has two model numbers: TXW686001 and WTL068601G, > but cannot find

Re: [PATCH v4 0/4] Introduce EBBG FT8719 DRM panel driver

2022-06-24 Thread Sam Ravnborg
Hi Joel, On Wed, Jun 01, 2022 at 01:54:06PM +0530, Joel Selvaraj wrote: > Add bindings and DRM panel driver for EBBG FT8719 6.18" 2246x1080 DSI > video mode panel, which can be found on some Xiaomi Poco F1 phones. > The panel's backlight is managed through QCOM WLED driver. > > The driver is

Re: [PATCH v2] drm: bridge: adv7511: Add check for mipi_dsi_driver_register

2022-06-24 Thread Sam Ravnborg
On Thu, Jun 02, 2022 at 06:34:01PM +0800, Jiasheng Jiang wrote: > As mipi_dsi_driver_register could return error if fails, > it should be better to check the return value and return error > if fails. > Moreover, if i2c_add_driver fails, mipi_dsi_driver_register > should be reverted. > > Fixes:

Re: [PATCH] drm/bridge: parade-ps8622: Use backlight helper

2022-06-24 Thread Sam Ravnborg
On Tue, Jun 07, 2022 at 08:10:22PM +0200, Stephen Kitt wrote: > backlight_properties.fb_blank is deprecated. The states it represents > are handled by other properties; but instead of accessing those > properties directly, drivers should use the helpers provided by > backlight.h. > > Instead of

Re: [PATCH] drm/panel-edp: Add LQ140M1JW48 edp panel entry

2022-06-24 Thread Sam Ravnborg
On Tue, Jun 07, 2022 at 07:06:14PM -0700, Bjorn Andersson wrote: > Add panel identification entry for the Sharp LQ140M1JW48 eDP panel. > > Due to lacking documentation, a delay similar to those for the > LQ140M1JW46 numbers are picked for now. > > Signed-off-by: Bjorn Andersson Thanks, applied

Re: [PATCH 2/2] drm/panel: simple: add AM-800600P5TMQW-TB8H

2022-06-24 Thread Sam Ravnborg
Hi Bastian, On Fri, Jun 10, 2022 at 01:15:11PM +0200, Bastian Krause wrote: > Add support for the Ampire AM-800600P5TMQW-TB8H 800x600 panel. Data > sheet is currently not publicly available, unfortunately. > > Signed-off-by: Bastian Krause Applied to drm-misc (drm-misc-next). When applying I

Re: [PATCH v2] drm: shmobile: Use backlight helper

2022-06-24 Thread Sam Ravnborg
On Thu, Jun 16, 2022 at 07:08:21PM +0200, Stephen Kitt wrote: > This started with work on the removal of backlight_properties' > deprecated fb_blank field, much of which can be taken care of by using > helper functions provided by backlight.h instead of directly accessing > fields in

Re: [PATCH v2 1/3] drm/panel: Use backlight helper

2022-06-24 Thread Sam Ravnborg
> > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates this from future changes. > > Signed-off-by: Stephen Kitt

Re: [PATCH v2 2/3] drm/panel: panel-dsi-cm: Use backlight helpers

2022-06-24 Thread Sam Ravnborg
f-by: Stephen Kitt > Cc: Thierry Reding > Cc: Sam Ravnborg > Cc: David Airlie > Cc: Daniel Vetter > Cc: dri-devel@lists.freedesktop.org Thanks, applied to drm-misc (drm-misc-next) Sam

Re: [PATCH v2 3/3] drm/panel: sony-acx565akm: Use backlight helpers

2022-06-24 Thread Sam Ravnborg
s > removal. This change makes no functional difference since > FB_BLANK_UNBLANK is the default value. > > Signed-off-by: Stephen Kitt > Cc: Thierry Reding > Cc: Sam Ravnborg > Cc: David Airlie > Cc: Daniel Vetter > Cc: dri-devel@lists.freedesktop.org Thanks, applied to drm-misc (drm-misc-next) Sam

Re: [PATCH] drm/ssd130x: Use new regmap bulk write support to drop custom bus

2022-06-24 Thread Sam Ravnborg
g. But the regmap > API has been extended to support defining bulk read/write handlers, so the > custom regmap bus is not needed anymore and could just be dropped. > > Signed-off-by: Javier Martinez Canillas Patch looks good, but obviously needs the dependencies sorted out. Acked-by: Sam Ravnborg Sam

Re: [PATCH 1/1] drm/panel: panel-simple: Add dev_err_probe if backlight could not be found

2022-06-24 Thread Sam Ravnborg
On Tue, Jun 21, 2022 at 09:21:18AM +0200, Alexander Stein wrote: > If the backlight node is not enabled, this (silently) returns with > -EPROBE_DEFER. /sys/kernel/debug/devices_deferred also shows nothing > helpful: > $ cat /sys/kernel/debug/devices_deferred > display > > With this patch, there

Re: [PATCH] drm/panel: nt35510: Remove duplicate 'the' in two places.

2022-06-24 Thread Sam Ravnborg
On Tue, Jun 21, 2022 at 10:01:51PM +0800, Jiang Jian wrote: > file: ./drivers/gpu/drm/panel/panel-novatek-nt35510.c > line: 193,214,253 > * amplification for the the step-up circuit: > changed to > * amplification for the step-up circuit: > > Signed-off-by: Jiang Jian Thanks, applied to

Re: [PATCH] drm/pl111: drop unexpected word "the" in the comments

2022-06-24 Thread Sam Ravnborg
On Tue, Jun 21, 2022 at 09:31:07PM +0800, Jiang Jian wrote: > there is an unexpected word "the" in the comments that need to be dropped > > file: drivers/gpu/drm/pl111/pl111_display.c > line: 251 > * Note that the the ARM hardware's format reader takes 'r' from > changed to > * Note that the the

Re: [PATCH v2 10/68] drm/bridge: panel: Introduce drmm_of_get_bridge

2022-06-24 Thread Sam Ravnborg
ns a drmm managed pointer to the bridge if successful, or an error pointer otherwise. To tell the reader that there is no need for any cleanup. With this or something similar added: Acked-by: Sam Ravnborg Sam

Re: [PATCH v2 09/68] drm/bridge: panel: Introduce drmm_panel_bridge_add

2022-06-24 Thread Sam Ravnborg
On Wed, Jun 22, 2022 at 04:31:10PM +0200, Maxime Ripard wrote: > Unlike what can be found for other entities, there's no DRM-managed > function to create a panel_bridge instance from a panel. > > Let's introduce one. > > Signed-off-by: Maxime Ripard Acked-by: Sam Ravnborg

Re: [PATCH v2 08/68] drm/connector: Introduce drmm_connector_init_with_ddc

2022-06-24 Thread Sam Ravnborg
On Wed, Jun 22, 2022 at 04:31:09PM +0200, Maxime Ripard wrote: > Let's create a DRM-managed variant of drm_connector_init_with_ddc that will > take care of an action of the connector cleanup. > > Signed-off-by: Maxime Ripard Acked-by: Sam Ravnborg

Re: [PATCH v2 07/68] drm/connector: Introduce drmm_connector_init

2022-06-24 Thread Sam Ravnborg
p through a DRM-managed action. > > Acked-by: Thomas Zimmermann > Signed-off-by: Maxime Ripard Acked-by: Sam Ravnborg

Re: [PATCH v2 06/68] drm/connector: Clarify when drm_connector_unregister is needed

2022-06-24 Thread Sam Ravnborg
, but only those. > > drm_connector_init() already mentions that it only needs > drm_connector_cleanup(), so let's clarify the drm_connector_register() > and drm_connector_unregister() documentation to point at each other, and > remove the misleading part about drm_dev_unregister(). > > Signed-off-by: Maxime Ripard Acked-by: Sam Ravnborg

Re: [PATCH v2 05/68] drm/connector: Mention the cleanup after drm_connector_init

2022-06-24 Thread Sam Ravnborg
On Wed, Jun 22, 2022 at 04:31:06PM +0200, Maxime Ripard wrote: > Unlike encoders and CRTCs, the drm_connector_init() and > drm_connector_init_with_ddc() don't mention how the cleanup is supposed to > be done. Let's add it. > > Signed-off-by: Maxime Ripard Looks sensible, Acked-b

Re: [PATCH v2 04/68] drm/connector: Reorder headers

2022-06-24 Thread Sam Ravnborg
On Wed, Jun 22, 2022 at 04:31:05PM +0200, Maxime Ripard wrote: > Unlike most of the other files in DRM, and Linux in general, the headers in > drm_connector.c aren't sorted alphabetically. Let's fix that. > > Signed-off-by: Maxime Ripard Acked-by: Sam Ravnborg > --- >

Re: [PATCH] drm/bridge: add it6505 driver read config from dt property

2022-06-24 Thread Sam Ravnborg
Hi allen. On Thu, Jun 23, 2022 at 05:31:54PM +0800, allen wrote: > From: allen chen > > add read max-lane and max-pixel-clock from dt property > > Signed-off-by: Allen-kh Cheng > Can you fix so your s-o-b mail and author mail matches? As it is now an error is flagged as they do not match.

Re: [RESEND v5 1/2] dt-bindings: display: simple: Add DataImage FG1001L0DSSWMG01 compatible string

2022-06-24 Thread Sam Ravnborg
Hi Philip, On Thu, Jun 23, 2022 at 01:22:56PM +0200, Philip Oberfichtner wrote: > Add DataImage FG1001L0DSSWMG01 10.1" 1280x800 TFT LCD panel compatible > string. > > Signed-off-by: Philip Oberfichtner > Acked-by: Krzysztof Kozlowski Both patches applied to drm-misc (drm-misc-next)

Re: [PATCH] drm/ingenic: Use resource_size function on resource object

2022-06-24 Thread Sam Ravnborg
my code as well. > Signed-off-by: Jiapeng Chong Reviewed-by: Sam Ravnborg

Re: [PATCH v5 2/2] drm: lcdif: Add support for i.MX8MP LCDIF variant

2022-06-24 Thread Sam Ravnborg
> > + > > +static int lcdif_rpm_resume(struct device *dev) > > +{ > > + struct drm_device *drm = dev_get_drvdata(dev); > > + struct lcdif_drm_private *lcdif = drm->dev_private; > > + > > + /* These clock supply the Control Bus, APB, APBH Ctrl Registers */ > > +

Re: How do I gather up new code to be converted as patches?

2022-06-23 Thread Sam Ravnborg
Hi Kevin, On Fri, Jun 24, 2022 at 01:17:40AM +0200, Kevin Brace wrote: > Hi Sam, > > Okay, I think what you proposed works out for me, although adding 20+ files, > one by one, is a pain. Posting one patch per file works - but sometimes it just makes more sense to group some files. The process

Re: How do I gather up new code to be converted as patches?

2022-06-22 Thread Sam Ravnborg
Hi Kevin, On Wed, Jun 22, 2022 at 07:18:58PM +0200, Kevin Brace wrote: > Hi, > > How to I use git to gather up new code to be converted to patches? > Specifically, I have 20+ new files in one location (drivers/gpu/drm/via) > and a small change to DRM main make file (drivers/gpu/drm/Makefile).

<    1   2   3   4   5   6   7   8   9   10   >