Hi, Jayesh
On 5/31/24 21:33, Sam Ravnborg wrote:
Hi Jayesh,
+
static const struct drm_bridge_funcs sii902x_bridge_funcs = {
.attach = sii902x_bridge_attach,
.mode_set = sii902x_bridge_mode_set,
@@ -516,6 +529,7 @@ static const struct drm_bridge_funcs sii902x_bridge_funcs =
this flag enabled.
So move the mode_valid hook to drm_bridge_funcs with proper clock
checks for maximum and minimum pixel clock supported by the bridge.
Signed-off-by: Jayesh Choudhary
Acked-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/sii902x.c | 32 +++-
1
Hi,
On 5/30/24 17:29, Jayesh Choudhary wrote:
Move the mode_valid hook to drm_bridge_funcs structure to take care
of the case when the encoder attaches the bridge chain with the
DRM_BRIDGE_ATTACH_NO_CONNECTOR flag in which case, the connector is not
initialized in the bridge's attach call and
Hi,
On 5/31/24 05:14, Sam Ravnborg wrote:
Drop myself as reviewer of panel patches, to reflect the reality.
We lost one kindness reviewer for drivers of panel, unhappy!
Not sure if it is proper to give you a NAK here. :(
Best regards,
Sui
Signed-off-by: Sam Ravnborg
Cc: Neil Armstrong
isable_all/drm_atomic_helper_shutdown/]
[geert: shmob_drm_remove() already calls drm_atomic_helper_shutdown]
Signed-off-by: Geert Uytterhoeven
Reviewed-by: Laurent Pinchart
Reviewed-by: Sui Jingfeng
Best regards,
Sui
:
Acked-by: Sui Jingfeng
---
Tested on Koelsch (R-Car M2-W).
Support for DU variants using the VSP-compositor is more convoluted,
and left to the DU experts.
---
drivers/gpu/drm/renesas/rcar-du/rcar_du_plane.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git
Hi,
On 5/27/24 21:34, Geert Uytterhoeven wrote:
Add support for the drm_panic module, which displays a message on
the screen when a kernel panic occurs.
Signed-off-by: Geert Uytterhoeven
Reviewed-by: Jocelyn Falempe
Acked-by: Sui Jingfeng
---
Tested on Armadillo-800-EVA.
---
drivers
R [=n]
Selected by [y]:
- DRM_KUNIT_TEST [=y] && HAS_IOMEM [=y] && DRM [=y] && KUNIT [=y] && MMU [=y]
Signed-off-by: Thomas Hellström
Fixes: 54cb39e2293b ("drm/connector: hdmi: Create an HDMI sub-state")
Cc: Maxime Ripard
Cc: dri-devel@lists.freedesktop.org
Acked-by: Sui Jingfeng
Hi,
On 5/27/24 21:57, Maxime Ripard wrote:
Now that we're tracking the output bpc count in the connector state,
let's add a few tests to make sure it works as expected.
Reviewed-by: Dave Stevenson
Reviewed-by: Dmitry Baryshkov
Signed-off-by: Maxime Ripard
Tested-by: Sui Jingfeng
0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0xd0
+};
+
+#endif // DRM_KUNIT_EDID_H_
--
Best regards
Sui Jingfeng
to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url:
https://github.com/intel-lab-lkp/linux/commits/Sui-Jingfeng/drm-bridge-Allow-using-fwnode-APIs-to-get-the-next
Hi,
On 5/27/24 05:19, Dmitry Baryshkov wrote:
On Mon, May 27, 2024 at 04:21:07AM +0800, Sui Jingfeng wrote:
Normally, the drm_bridge::of_node won't be used by bridge driver instances
themselves. Rather, it is mainly used by other modules to find associated
drm bridge drvier. Therefore, adding
Use the freshly created helper to replace the use of DT-dependent APIs,
also print error log if the fwnode graph is not complete which is benefit
to debug.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/chrontel-ch7033.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions
Make this driver less DT-dependent by calling the newly created helpers,
also switch to use fwnode APIs to acquire additional device properties.
No functional changes for DT-based systems.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/ti-tfp410.c | 39 +++---
1
directly referencing and/or dereferencing
it.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/sii9234.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/sii9234.c b/drivers/gpu/drm/bridge/sii9234.c
index 7d2bbc31bac9..d930c093abb3 100644
Make this driver less DT-dependent by calling the newly created helpers,
also switch to use fwnode APIs to acquire additional device properties.
A side benifit is that boilerplates get reduced, no functional changes
for DT-based systems.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge
Make this driver less DT-dependent by calling the freshly created helpers,
also switch to use fwnode APIs to acquire additional device properties.
One side benifit is that boilerplates get reduced, no functional changes
for DT-based systems.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm
Switch to use the fwnode APIs, which is a fundamental step to make this
driver OF-independent possible. No functional changes for DT-based systems.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/display-connector.c | 23 +++---
1 file changed, 11 insertions(+), 12
() and
devm_drm_bridge_add(). A lot of driver instances has already added it into
their derived structure, promote it into drm_bridge core helps to reduce
a batch of boilerplates.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 3 +--
.../gpu/drm/bridge/analogix/analogix-anx6345.c
Make this driver less DT-dependent by calling the newly created helpers,
also switch to use fwnode APIs to acquire additional device properties.
A side benifit is that boilerplates get reduced, no functional changes
for DT-based systems.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge
Before applying this patch, people may worry about the OF and non-OF API
will have a risk to diverge. Eliminate the risk by reimplement the
of_drm_find_bridge() on the top of drm_bridge_find_by_fwnode(). As for now
the fundamental searching method is unique.
Signed-off-by: Sui Jingfeng
drm bridge instance should also has the fwnode
assigned, so that the user of it could find it via the fwnode handle.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/drm_bridge.c | 74
include/drm/drm_bridge.h | 11 +-
2 files changed, 83 insertions
v4 -> v5:
* Modify sii9234, ch7033 and ANX7688
* Trivial fixes
v5 -> v6:
* Implement the same thing with no boilerplate introduced
* Add 'struct device *' field to the drm_bridge structure
* Re-implement of_drm_find_bridge() with drm_bridge_find_by_fwnode(
as a subcomponent as well.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/loongson/Makefile| 3 +
drivers/gpu/drm/loongson/loong_gpu_pci_drv.c | 90
drivers/gpu/drm/loongson/loong_gpu_pci_drv.h | 27 ++
drivers/gpu/drm/loongson/loongson_module.c | 9 ++
drivers/gpu
are ready.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/loongson/Makefile | 1 +
drivers/gpu/drm/loongson/loongson_module.c| 17 +-
drivers/gpu/drm/loongson/loongson_module.h| 1 +
drivers/gpu/drm/loongson/lsdc_drv.c | 205 +++---
drivers/gpu/drm
problems if not process correctly.
Add the loongson_create_platform_device() function, which allows the KMS
driver to create sub-devices for it. The manually created decice acts as
agents for the principal part, migrate the potential issue to submodule.
Signed-off-by: Sui Jingfeng
---
drivers/gpu
.
This allows the master don't have to tear down everything, thereore
majority setups work can be preserved. The potential cyclic dependency
problem can be solved then.
v1 -> v2:
* Squash patch 0002 and patch 0003 into one
* Fill type and improve commit message
Sui Jingfeng
Hi, Maxime
I love you patch, yet it generates warnning calltrace. Despite it's
just a warning but it can overwhelm when we run kunit tests. Hence,
I suggest switch to the drm_atomic_connector_get_property() function.
Logs are pasted as below for easier to ready.
[ cut here
return ret;
+ }
+
+ return 0;
+}
+
--
Best regards
Sui Jingfeng
n 0;
+ }
+ return ret;
+ }
+
+ ret = mtk_ddp_comp_get_id(ep_dev_node, comp_type);
+ if (ret < 0)
+ return ret;
+
+ /* All ok! Pass the Component ID to the caller. */
+ *cid = (unsigned int)ret;
+
+ return 0;
+}
+
--
Best regards
Sui Jingfeng
Hi,
On 5/22/24 19:48, Sui Jingfeng wrote:
if the not bridge is not ready
'not' -> 'next'
Hi,
Looks good to me in overall!
On 5/21/24 15:57, AngeloGioacchino Del Regno wrote:
It is impossible to add each and every possible DDP path combination
for each and every possible combination of SoC and board: right now,
this driver hardcodes configuration for 10 SoCs and this is going to
Hi,
On 5/20/24 19:13, Dmitry Baryshkov wrote:
On Mon, 20 May 2024 at 14:11, Sui Jingfeng wrote:
Hi,
On 5/20/24 06:11, Dmitry Baryshkov wrote:
On Thu, May 16, 2024 at 06:10:06PM +0800, Liu Ying wrote:
Commit f3d9683346d6 ("drm/bridge: adv7511: Allow IRQ to share GPIO pins&qu
Hi,
On 5/20/24 06:11, Dmitry Baryshkov wrote:
On Thu, May 16, 2024 at 06:10:06PM +0800, Liu Ying wrote:
Commit f3d9683346d6 ("drm/bridge: adv7511: Allow IRQ to share GPIO pins")
fails to consider the case where adv7511->i2c_main->irq is zero, i.e.,
no interrupt requested at all.
Without
, as the PCIe device has already been created by the time the
etnaviv.ko is loaded. Hence, bind all of the virtual child to the real
master, this design reflects the hardware layout perfectly and is
extensible.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/Kconfig | 9
that works
for ARM-SoC can also works for PCIe cards.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/etnaviv_drv.c | 33 +++
drivers/gpu/drm/etnaviv/etnaviv_drv.h | 9
2 files changed, 37 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/etnaviv
In the etnaviv_pdev_probe(), etnaviv_gpu_platform_probe() function, the
value of '>dev' has been cached to the 'dev' local auto variable.
But part of callers use 'dev' as argument, while the rest use '>dev'.
To keep it consistent, use 'dev' uniformly.
Signed-off-by: Sui Jingfeng
---
d
.
Please note that write-combine mapping out of scope of the discussion
and therefore is not being addressed.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/etnaviv_drv.c | 3 +++
drivers/gpu/drm/etnaviv/etnaviv_drv.h | 9 +
drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 4
include
when trying to vmap a
DMABUF")
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/etnaviv_gem.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
index aa95a5e98374..eed98bb9e
structure.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/etnaviv_drv.c| 65
drivers/gpu/drm/etnaviv/etnaviv_drv.h| 7 +++
drivers/gpu/drm/etnaviv/etnaviv_gem.c| 6 +-
drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 2 +-
drivers/gpu/drm/etnaviv
helpers introduced, etnaviv_bind() and
etnaviv_unbind() gets simplified. Another potential benefit is that
we could put the struct drm_device into struct etnaviv_drm_private
in the future, which made them share the same life time.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/etnaviv_drv.c
blocks,
which make it easier to call this function on the platform where it works.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 53 ---
1 file changed, 32 insertions(+), 21 deletions(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
b/drivers
. Even though there is only one core.
* Defer the irq handler register.
* Rebase and improve the commit message
V14:
* Rebase onto etnaviv-next and improve commit message.
Tested with JD9230P GPU and LingJiu GP102 GPU.
Sui Jingfeng (8):
drm/etnaviv: Add a dedicated helper
.
Reducing boilerplate is also a side benefit.
Signed-off-by: Douglas Anderson
Acked-by: Sui Jingfeng
--
Best regards,
Sui
Hi,
On 5/16/24 14:26, Markus Elfring wrote:
…
fullfill the implement under the new framework.
fulfil the implementation?
Please improve your change descriptions another bit.
OK, despite has a few typos. but the quality of the patch itself
can be guaranteed. The first version is mainly
Hi,
On 5/16/24 16:33, Jani Nikula wrote:
If WERROR is already enabled, there's no point in enabling DRM_WERROR or
asking users about it.
Reported-by: Linus Torvalds
Closes:
https://lore.kernel.org/r/CAHk-=whxT8D_0j=bjtrvj-O=veojn6gw8gk4j2v+biduntz...@mail.gmail.com
Fixes: f89632a9e5fa
g interrupt
handling from adv7511_irq_process().
Fixes: f3d9683346d6 ("drm/bridge: adv7511: Allow IRQ to share GPIO pins")
Signed-off-by: Liu Ying
Acked-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --g
On 5/16/24 18:40, Sui Jingfeng wrote:
use 'to_i2c_client(bridge->dev)' to retrieve the pointer
to_i2c_client(bridge->kdev).
Besides, this also means that we don't need to add the fwnode
pointer into struct drm_bridge as member. Relief the conflicts
with other reviewers if th
Hi,
On 5/16/24 18:10, Liu Ying wrote:
Commit f3d9683346d6 ("drm/bridge: adv7511: Allow IRQ to share GPIO pins")
fails to consider the case where adv7511->i2c_main->irq is zero, i.e.,
no interrupt requested at all.
Without interrupt, adv7511_wait_for_edid() could return -EIO sometimes,
because
Hi,
On 5/16/24 16:25, Maxime Ripard wrote:
On Wed, May 15, 2024 at 11:19:58PM +0800, Sui Jingfeng wrote:
Hi,
On 5/15/24 22:58, Maxime Ripard wrote:
On Wed, May 15, 2024 at 10:53:00PM +0800, Sui Jingfeng wrote:
On 5/15/24 22:30, Maxime Ripard wrote:
On Wed, May 15, 2024 at 12:53:33AM +0800
Hi,
On 5/16/24 14:26, Markus Elfring wrote:
…
fullfill the implement under the new framework.
fulfil the implementation?
Please improve your change descriptions another bit.
I'll accept you suggestions, with pleasure. Thanks.
Regards,
Markus
--
Best regards
Sui
Hi,
On 5/16/24 04:30, Markus Elfring wrote:
In some display subsystems, the functionality of a PCI(e) device may too
…
of the functionality into child devices can helps to achieve better
modularity, eaiser for understand and maintain.
Add the loongson_create_platform_device() function to
Hi, Jani
I love your patch, thanks.
On 2024/5/14 20:55, Jani Nikula wrote:
Prefer the struct drm_edid based functions for reading the EDID and
updating the connector.
Signed-off-by: Jani Nikula
---
Reviewed-by: Sui Jingfeng
--
Best regards,
Sui
Hi, Jani
I love your patch, thanks.
On 2024/5/14 20:55, Jani Nikula wrote:
Prefer the struct drm_edid based functions for reading the EDID and
updating the connector.
Signed-off-by: Jani Nikula
---
Reviewed-by: Sui Jingfeng
--
Best regards,
Sui
Hi,
On 5/14/24 23:12, Laurent Pinchart wrote:
Hello,
On Tue, May 14, 2024 at 12:26:15AM +0800, Sui Jingfeng wrote:
On 5/13/24 16:02, Liu Ying wrote:
The connector is created by either this ADV7511 bridge driver or
any DRM device driver/previous bridge driver, so this ADV7511
bridge driver
Hi,
On 5/15/24 22:58, Maxime Ripard wrote:
On Wed, May 15, 2024 at 10:53:00PM +0800, Sui Jingfeng wrote:
On 5/15/24 22:30, Maxime Ripard wrote:
On Wed, May 15, 2024 at 12:53:33AM +0800, Sui Jingfeng wrote:
On 2024/5/15 00:22, Maxime Ripard wrote:
Hi,
On Tue, May 14, 2024 at 11:40:43PM
Hi,
On 5/15/24 22:30, Maxime Ripard wrote:
On Wed, May 15, 2024 at 12:53:33AM +0800, Sui Jingfeng wrote:
Hi,
On 2024/5/15 00:22, Maxime Ripard wrote:
Hi,
On Tue, May 14, 2024 at 11:40:43PM +0800, Sui Jingfeng wrote:
Because a lot of implementations has already added it into their drived
Hi,
On 5/15/24 18:28, Jani Nikula wrote:
On Wed, 15 May 2024, Sui Jingfeng wrote:
Hi,
On 5/15/24 17:39, Jani Nikula wrote:
On Tue, 14 May 2024, Sui Jingfeng wrote:
diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c
index 584d109330ab..1928d9d0dd3c 100644
Hi,
On 5/15/24 17:39, Jani Nikula wrote:
On Tue, 14 May 2024, Sui Jingfeng wrote:
The pointer of 'struct device' can also be used as a key to search drm
bridge instance from the global bridge list, traditionally, fwnode and
'OF' based APIs requires the system has decent fwnode/OF Graph
Hi,
On 2024/5/15 00:22, Maxime Ripard wrote:
Hi,
On Tue, May 14, 2024 at 11:40:43PM +0800, Sui Jingfeng wrote:
Because a lot of implementations has already added it into their drived
class, promote it into drm_bridge core may benifits a lot. drm bridge is
a driver, it should know
for simple bridge drivers which one device backing one drm_bridge
instance.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/drm_bridge.c | 39
include/drm/drm_bridge.h | 5 +
2 files changed, 44 insertions(+)
diff --git a/drivers/gpu/drm/drm_bridge.c b
don't have to set it manually for the canonical cases.
Let's reduce the boilerplates by using drm_bridge_add_with_dev().
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 3 +--
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 4 +---
drivers/gpu
Because a lot of implementations has already added it into their drived
class, promote it into drm_bridge core may benifits a lot. drm bridge is
a driver, it should know the underlying hardware entity.
Sui Jingfeng (2):
drm/bridge: Support finding bridge with struct device
drm/bridge: Switch
if (ret)
return ret;
}
--
Best regards
Sui Jingfeng
next bridge in DT")
Signed-off-by: Liu Ying
Acked-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
b/drivers/gpu/drm/bridge/adv7511/adv7511_d
ned if
it fails for some reasons, hence, it is guaranteed that the .encoder member
of the drm_bridge instance is not NULL when various bridge attach functions
are called.
Remove the redundant checking codes "if (!bridge->encoder) { ... }".
Reviewed-by: Laurent Pinchart
Signed-off-
ned if
it fails for some reasons, hence, it is guaranteed that the .encoder member
of the drm_bridge instance is not NULL when various i.MX specific bridge
attach functions are called.
Remove the redundant checking codes "if (!bridge->encoder) { ... }".
Reviewed-by: Laurent Pinchart
Si
der member of the struct drm_bridge is not NULL when
lt9611uxc_connector_init() function get called.
Remove the redundant checking codes "if (!bridge->encoder) { ... }".
Reviewed-by: Laurent Pinchart
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/lontium-lt9611uxc.c |
ned if it fails for some reasons, hence, it is guaranteed that the
.encoder member of the struct drm_bridge is not NULL when
dw_mipi_dsi_bridge_attach() function gets called.
Remove the redundant checking codes "if (!bridge->encoder) { ... }".
Reviewed-by: Laurent Pinchart
Signed-off-
nce is not
NULL when cdns_mhdp_connector_init() function get called.
Remove the redundant checking codes "if (!bridge->encoder) { ... }".
Reviewed-by: Laurent Pinchart
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/megachips-stdp-ge-b850v3-fw.c | 5 -
1 file changed, 5 de
ber of the struct drm_bridge is not NULL when cdns_mhdp_attach() gets
called.
Remove the redundant checking codes "if (!bridge->encoder) { ... }".
Reviewed-by: Laurent Pinchart
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 5 -
1 file chan
led by
adv7511_bridge_attach(). Hence, it is guaranteed that the .encoder member
of the drm_bridge instance is not NULL when adv7511_connector_init() get
called.
Remove the redundant checking codes "if (!bridge->encoder) { ... }".
Reviewed-by: Laurent Pinchart
Signed-off-by: Sui Jingfeng
---
ing codes "if (!bridge->encoder) { ... }".
Reviewed-by: Laurent Pinchart
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/ite-it6505.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/bridge/ite-it6505.c
b/drivers/gpu/drm/bridge/ite-it6505.c
index 3f68c82888
dge instance
is not NULL when panel_bridge_attach() function get called.
Remove the redundant checking codes "if (!bridge->encoder) { ... }".
Reviewed-by: Laurent Pinchart
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/panel.c | 5 -
1 file changed, 5 deletions(-)
diff --g
dge instance
is not NULL when the ptn3460_bridge_attach() function get called.
Remove the redundant checking codes "if (!bridge->encoder) { ... }".
Reviewed-by: Laurent Pinchart
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/nxp-ptn3460.c | 5 -
1 file changed, 5 deletion
nce
is not NULL when the simple_bridge_attach() get called.
Remove the redundant checking codes "if (!bridge->encoder) { ... }".
Reviewed-by: Laurent Pinchart
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/simple-bridge.c | 5 -
1 file changed, 5 deletions(-)
diff --g
nce
is not NULL when the tfp410_attach() function get called.
Remove the redundant checking codes "if (!bridge->encoder) { ... }".
Reviewed-by: Laurent Pinchart
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/ti-tfp410.c | 5 -
1 file changed, 5 deletions(-)
diff --git a
orrect commit message for bridges of i.MX (Ying)
Sui Jingfeng (12):
drm/bridge: simple-bridge: Remove a redundant check on existence of
bridge->encoder
drm/bridge: tfp410: Remove a redundant check on existence of
bridge->encoder
drm/bridge: nxp-ptn3460: Remove a redundant check
Hi,
On 5/13/24 13:56, Liu Ying wrote:
On 5/11/24 23:08, Sui Jingfeng wrote:
The check on the existence of bridge->encoder on the implementation layer
of drm bridge driver is not necessary, as it has already been done in the
drm_bridge_attach() function. It is guaranteed that the .enco
Hi,
On 2024/5/13 05:09, Laurent Pinchart wrote:
Hi Sui,
Thank you for the patch.
On Sat, May 11, 2024 at 08:42:38PM +0800, Sui Jingfeng wrote:
Because the check on the non-existence (encoder == NULL) has already been
done in the implementation of drm_bridge_attach() function
Move drm related device initialization into loongson_drm_master_bind(),
As we need to wait all other submodules ready before we could register
the drm device to userspace. Move output related things into subdriver,
fullfill the implement under the new framework.
Signed-off-by: Sui Jingfeng
back to the component core. This allows the master don't have to tear down
everything, the majority setups work can be preserved. The potential cyclic
dependency problem can be solved with such framework.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/loongson/Makefile | 1 +
drivers
the loongson_create_platform_device() function to pove the way for the
mentioned goals. Pure software method, no hardware operations involved.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/loongson/loongson_device.c | 42 ++
drivers/gpu/drm/loongson/lsdc_drv.h| 6
2 files changed, 48
back to the component core. This allows the master don't have to tear down
everything, the majority setups work can be preserved. The potential cyclic
dependency problem can be solved with such framework.
Sui Jingfeng (3):
drm/loongson: Add helpers for creating subdevice
drm/loongson: Introduce
ach()
function gets called. And .atomic_enable() of struct drm_bridge_funcs
shouldn't be able to called before the various is acctached.
Remove the redundant checking codes "if (!bridge->encoder) { ... }".
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/analogix/analogi
ach()
function gets called.
Remove the redundant checking codes "if (!bridge->encoder) { ... }".
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/imx/imx-ldb-helper.c | 5 -
drivers/gpu/drm/bridge/imx/imx8qxp-pixel-combiner.c | 5 -
drivers/gpu/drm/bridge/imx/imx8
der member of the struct drm_bridge is not NULL when
lt9611uxc_connector_init() function gets called.
Remove the redundant checking codes "if (!bridge->encoder) { ... }".
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 5 -
1 file changed, 5 deletion
der member of the struct drm_bridge is not NULL when
dw_mipi_dsi_bridge_attach() function gets called.
Remove the redundant checking codes "if (!bridge->encoder) { ... }".
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 5 -
1 file changed, 5 de
eed that
the .encoder member of the struct drm_bridge is not NULL when
ge_b850v3_lvds_attach() function gets called.
Remove the redundant checking codes "if (!bridge->encoder) { ... }".
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/megachips-stdp-ge-b850v3-fw.c | 5 -
1 file chan
der member of the struct drm_bridge is not NULL when
adv7511_bridge_attach() function gets called.
Remove the redundant checking codes "if (!bridge->encoder) { ... }".
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 5 -
1 file changed, 5 de
der member of the struct drm_bridge is not NULL when
adv7511_bridge_attach() function is called.
Remove the redundant checking codes "if (!bridge->encoder) { ... }".
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 5 -
1 file changed, 5 deletion
rm_bridge is not
NULL when the panel_bridge_attach() is called.
There is no need to check the existence of bridge->encoder another time,
remove the redundant checking codes "if (!bridge->encoder) { ... }".
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/ite-it6505.c | 5 -
1
NULL
when the panel_bridge_attach() is called.
There is no need to check the existence of bridge->encoder another time
at the implementation layer, therefore remove the redundant checking codes
"if (!bridge->encoder) { ... }".
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/
eforei, there is
no need to check another time at the later, remove the redundant checking
codes "if (!bridge->encoder) { ... }".
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/nxp-ptn3460.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/bridge/nxp-ptn3460.c
b/dri
refore there is no need to check another time at the later, remove the
redundant checking codes "if (!bridge->encoder) { ... }".
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/ti-tfp410.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c
b/dri
->encoder to NULL and return a negective error code.
Therefore, there is no need to check another again. Remove the redundant
codes at the later.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/simple-bridge.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/bridge/sim
d8dfccde2709
("drm/bridge: Drop conditionals around of_node pointers") for reference.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/drm_bridge.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c
index 30d66bee0ec6..a6dbe1751
Use the freshly created helper to replace the use of DT-dependent APIs,
also print error log if the fwnode graph is not complete which is benefit
to debug.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/chrontel-ch7033.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions
functional changes.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/cros-ec-anx7688.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/cros-ec-anx7688.c
b/drivers/gpu/drm/bridge/cros-ec-anx7688.c
index c8abd9920fee..30b27b808e02 100644
--- a/d
directly referencing and/or dereferencing
it.
Signed-off-by: Sui Jingfeng
---
drivers/gpu/drm/bridge/sii9234.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/sii9234.c b/drivers/gpu/drm/bridge/sii9234.c
index d8373d918324..19b09634a134 100644
1 - 100 of 1192 matches
Mail list logo
