Re: [PATCH v3 1/1] backlight: hid_bl: Add VESA VCP HID backlight driver

2023-09-04 Thread Thomas Weißschuh
+Cc Hans who ins involved with the backlight subsystem Hi Julius, today I stumbled upon a mail from Hans [0], which explains that the backlight subsystem is not actually a good fit (yet?) for external displays. It seems a new API is in the works that would better fit, but I'm not sure about the

Re: [PATCH v3 1/1] backlight: hid_bl: Add VESA VCP HID backlight driver

2023-08-27 Thread Thomas Weißschuh
On 2023-08-20 11:41:18+0200, Julius Zint wrote: > [..] > diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig > index 51387b1ef012..b964a820956d 100644 > --- a/drivers/video/backlight/Kconfig > +++ b/drivers/video/backlight/Kconfig > @@ -472,6 +472,14 @@ config

Re: [PATCH v2 1/1] backlight: hid_bl: Add VESA virtual control panel HID backlight driver

2023-08-06 Thread Thomas Weißschuh
Hi, this should probably also go to the maintainers of the "HID CORE LAYER" for review: HID CORE LAYER M: Jiri Kosina M: Benjamin Tissoires L: linux-in...@vger.kernel.org And maybe it would better fit to be in drivers/hid/ ? (Something for the maintainers to figure out) Some

[PATCH] dma-buf: make kobj_type structure constant

2023-02-16 Thread Thomas Weißschuh
Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.") the driver core allows the usage of const struct kobj_type. Take advantage of this to constify the structure definition to prevent modification at runtime. Signed-off-by: Thomas Weißschuh --- drivers/dma-buf/dma

[PATCH] drm/amdkfd: Make kobj_type structures constant

2023-02-15 Thread Thomas Weißschuh
Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.") the driver core allows the usage of const struct kobj_type. Take advantage of this to constify the structure definitions to prevent modification at runtime. Signed-off-by: Thomas Weißschuh --- drivers/gpu/drm/

[PATCH] drm/amdgpu: make kobj_type structures constant

2023-02-15 Thread Thomas Weißschuh
Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.") the driver core allows the usage of const struct kobj_type. Take advantage of this to constify the structure definitions to prevent modification at runtime. Signed-off-by: Thomas Weißschuh --- drivers/gpu/drm/

[PATCH] drm/i915: Make kobj_type structures constant

2023-02-15 Thread Thomas Weißschuh
Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.") the driver core allows the usage of const struct kobj_type. Take advantage of this to constify the structure definitions to prevent modification at runtime. Signed-off-by: Thomas Weißschuh --- drivers/gpu/d

[PATCH] drm/nouveau/led: explicitly include linux/leds.h

2023-02-14 Thread Thomas Weißschuh
Instead of relying on an accidental, transitive inclusion of linux/leds.h use it directly. Also drop the forware definition of struct led_classdev that is now provided by linux/leds.h. Signed-off-by: Thomas Weißschuh --- drivers/gpu/drm/nouveau/nouveau_led.h | 2 +- 1 file changed, 1 insertion

Re: [PATCH v2] backlight: propagate errors from get_brightness()

2021-09-23 Thread Thomas Weißschuh
On 2021-09-23T10:48+0100, Lee Jones wrote: > On Tue, 07 Sep 2021, Thomas Weißschuh wrote: > > > backlight.h documents "struct backlight_ops->get_brightness()" to return > > a negative errno on failure. > > So far these errors have not been handled in the backl

Re: [PATCH v2] backlight: propagate errors from get_brightness()

2021-09-21 Thread Thomas Weißschuh
On 2021-09-07T14:47+0200, Thomas Weißschuh wrote: > backlight.h documents "struct backlight_ops->get_brightness()" to return > a negative errno on failure. > So far these errors have not been handled in the backlight core. > This leads to negative values being exposed th

Re: [PATCH v2] backlight: propagate errors from get_brightness()

2021-09-07 Thread Thomas Weißschuh
On 2021-09-07T14:10+0100, Daniel Thompson wrote: > On Tue, Sep 07, 2021 at 02:47:51PM +0200, Thomas Weißschuh wrote: > > backlight.h documents "struct backlight_ops->get_brightness()" to return > > a negative errno on failure. > > So far these errors have not

[PATCH v2] backlight: propagate errors from get_brightness()

2021-09-07 Thread Thomas Weißschuh
. Signed-off-by: Thomas Weißschuh --- v1: https://lore.kernel.org/dri-devel/20210906215525.15418-1-li...@weissschuh.net/ v1 -> v2: * use dev_err() instead of dev_warn() (Daniel Thompson) * Finish logging format string with newline (Daniel Thompson) * Log errno via dedicated error pointe

[PATCH] backlight: propagate errors from get_brightness()

2021-09-07 Thread Thomas Weißschuh
. Signed-off-by: Thomas Weißschuh --- drivers/video/backlight/backlight.c | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c index 537fe1b376ad..d681962f8509 100644 --- a/drivers/vi