Re: [PATCH] fbdev: au1200fb: Fix potential divide by zero

2023-03-15 Thread Wei Chen
. Related discussions are here: https://lore.kernel.org/all/yxclzqgftr1nf...@ravnborg.org/ https://lore.kernel.org/all/ypgbhmtlqqb1k...@ravnborg.org/ https://lore.kernel.org/all/20220404084723.79089-1-zheyum...@gmail.com/ Thanks, Wei -- Original Message -- >From "Thomas Zimmermann"

[PATCH] fbdev: au1200fb: Fix potential divide by zero

2023-03-15 Thread Wei Chen
var->pixclock can be assigned to zero by user. Without proper check, divide by zero would occur when invoking macro PICOS2KHZ in au1200fb_fb_check_var. Error out if var->pixclock is zero. Signed-off-by: Wei Chen --- drivers/video/fbdev/au1200fb.c | 3 +++ 1 file changed, 3 insertions(+)

[PATCH] fbdev: lxfb: Fix potential divide by zero

2023-03-15 Thread Wei Chen
var->pixclock can be assigned to zero by user. Without proper check, divide by zero would occur in lx_set_clock. Error out if var->pixclock is zero. Signed-off-by: Wei Chen --- drivers/video/fbdev/geode/lxfb_core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/video

[PATCH] fbdev: nvidia: Fix potential divide by zero

2023-03-15 Thread Wei Chen
elieve it could also be triggered in driver nvidia from user site. Signed-off-by: Wei Chen --- drivers/video/fbdev/nvidia/nvidia.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/video/fbdev/nvidia/nvidia.c b/drivers/video/fbdev/nvidia/nvidia.c index e60a276b4855..ea4ba3dfb96b

Re: [PATCH] fbdev: tgafb: Fix potential divide by zero

2023-03-08 Thread Wei Chen
Dear Helge, Thank you for the kind words. My real name is Wei Chen. Please apply this patch to fbdev git tree if it is correct. Best, Wei On Thu, 9 Mar 2023 at 06:05, Helge Deller wrote: > > On 3/7/23 14:08, harperchen wrote: > > fb_set_var would by called when user invokes io