Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-08-04 Thread Javier Martinez Canillas
Javier Martinez Canillas writes: > Thomas Zimmermann writes: > [...] >> The reasoning is that userspace should always be in control of the >> format (sans that one exception). If userspace wants packed 24-bits it >> can support RGB888 explicitly. For the color-format transformation, >>

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-08-02 Thread Roger Sewell
Thomas, Jocelyn, I just thought I'd let you know that it occurred to me that, now I understood the workings of the mgag200 module better, I might be able to get an even higher screen resolution than before. So I relaxed the limits of this chip that returns unique_rev_id=1 to be those that

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-08-01 Thread Thomas Zimmermann
Hi Am 01.08.23 um 14:21 schrieb Roger Sewell: Jocelyn, Thomas, Jocelyn, your patch works perfectly - thank you. That's an interesting find. I briefly looked through the code that validates the modes, but there's no obvious reason why it would now work. May I leave it to the two of you

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-08-01 Thread Thomas Zimmermann
Hi Am 01.08.23 um 16:24 schrieb Jocelyn Falempe: On 01/08/2023 12:25, Thomas Zimmermann wrote: Hi Am 01.08.23 um 12:11 schrieb Jocelyn Falempe: On 28/07/2023 14:12, Roger Sewell wrote: Thomas, Jocelyn, JF> I think the culprit is probably this patch: JF>

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-08-01 Thread Jocelyn Falempe
On 01/08/2023 12:25, Thomas Zimmermann wrote: Hi Am 01.08.23 um 12:11 schrieb Jocelyn Falempe: On 28/07/2023 14:12, Roger Sewell wrote: Thomas, Jocelyn, JF> I think the culprit is probably this patch: JF> https://patchwork.freedesktop.org/patch/486242/ JF> JF> before this patch, JF>

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-08-01 Thread Roger Sewell
Jocelyn, Thomas, Jocelyn, your patch works perfectly - thank you. May I leave it to the two of you to decide what should happen about propagating this patch ? (I have set out my user's point of view about it in my email of Fri, 28 Jul 2023 10:11:00 +0100, but obviously my opinion is not

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-08-01 Thread Thomas Zimmermann
Hi Am 01.08.23 um 12:11 schrieb Jocelyn Falempe: On 28/07/2023 14:12, Roger Sewell wrote: Thomas, Jocelyn, JF> I think the culprit is probably this patch: JF> https://patchwork.freedesktop.org/patch/486242/ JF> JF> before this patch, JF> mgag200_simple_display_pipe_mode_valid() always return

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-08-01 Thread Jocelyn Falempe
On 28/07/2023 14:12, Roger Sewell wrote: Thomas, Jocelyn, JF> I think the culprit is probably this patch: JF> https://patchwork.freedesktop.org/patch/486242/ JF> JF> before this patch, JF> mgag200_simple_display_pipe_mode_valid() always return MODE_OK JF> JF> after this patch, it checks the

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-07-28 Thread Roger Sewell
Jocelyn, Thomas, JF> I think the culprit is probably this patch: JF> https://patchwork.freedesktop.org/patch/486242/ JF> JF> before this patch, JF> mgag200_simple_display_pipe_mode_valid() always return MODE_OK JF> JF> after this patch, it checks the bandwidth limit too. I can easily test

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-07-28 Thread Jocelyn Falempe
On 28/07/2023 09:45, Thomas Zimmermann wrote: Hi Am 27.07.23 um 23:34 schrieb Roger Sewell: Thomas, Jocelyn, As a result of the collection of the Xorg logs requested by Thomas, I've realised that at some long-past point upgrade the 1440x900@60 mode disappeared, and in order to get it back I

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-07-28 Thread Thomas Zimmermann
Hi Am 27.07.23 um 23:34 schrieb Roger Sewell: Thomas, Jocelyn, As a result of the collection of the Xorg logs requested by Thomas, I've realised that at some long-past point upgrade the 1440x900@60 mode disappeared, and in order to get it back I introduced the file

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-07-28 Thread Roger Sewell
Thomas, Jocelyn, As a result of the collection of the Xorg logs requested by Thomas, I've realised that at some long-past point upgrade the 1440x900@60 mode disappeared, and in order to get it back I introduced the file /etc/X11/xorg.conf.d/20-screen.conf attached. If I remove this file, then

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-07-28 Thread Roger Sewell
Thomas, > Could you provide us with the Xorg logs from /var/log/Xorg.0.log , > please? > > Specifically, I'd be interested in different logs from combinations of > the old and new kernel and the old and new userspace. I've managed to do six of the eight possible combinations of kernel, mgag200

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-07-28 Thread Jocelyn Falempe
On 27/07/2023 19:24, Roger Sewell wrote: Thomas, Could you provide us with the Xorg logs from /var/log/Xorg.0.log , please? Specifically, I'd be interested in different logs from combinations of the old and new kernel and the old and new userspace. I've managed to do six of the eight

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-07-28 Thread Thomas Zimmermann
Hi Am 27.07.23 um 19:24 schrieb Roger Sewell: Thomas, Could you provide us with the Xorg logs from /var/log/Xorg.0.log , please? Specifically, I'd be interested in different logs from combinations of the old and new kernel and the old and new userspace. I've managed to do six of the eight

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-07-27 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Hi Maxime > > Am 27.07.23 um 16:33 schrieb Maxime Ripard: >> Hi Thomas, >> >> On Wed, Jul 26, 2023 at 05:36:15PM +0200, Thomas Zimmermann wrote: I've already sent a patch to use internally 24bit colors, when userspace can use 32bit that would solve this

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-07-27 Thread Thomas Zimmermann
Hi Maxime Am 27.07.23 um 16:33 schrieb Maxime Ripard: Hi Thomas, On Wed, Jul 26, 2023 at 05:36:15PM +0200, Thomas Zimmermann wrote: I've already sent a patch to use internally 24bit colors, when userspace can use 32bit that would solve this issue as well. In the end, on the VGA link, 24 or 32

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-07-27 Thread Maxime Ripard
Hi Thomas, On Wed, Jul 26, 2023 at 05:36:15PM +0200, Thomas Zimmermann wrote: > > I've already sent a patch to use internally 24bit colors, when userspace > > can use 32bit that would solve this issue as well. In the end, on the > > VGA link, 24 or 32 bit colors are the same. That would allow

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-07-27 Thread Roger Sewell
Jocelyn, >> How can I check for sure whether I am using 24 or 32 bits per pixel >> ? > > The easiest solution if you already rebuilt your kernel is to print > the variable bpp here: > > https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/mgag200/mgag200_mode.c#L326 > >

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-07-26 Thread Thomas Zimmermann
Hi Am 25.07.23 um 23:31 schrieb Roger Sewell: Thomas, Thank you for your reply. Table 10 in the following document says that 1440x900@60Hz is supported: https://www.intel.com/content/dam/support/us/en/documents/motherboards/server/s5520ur/sb/e44031012_s5520ur_s5520urt_tps_r1_9.pdf That

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-07-26 Thread Thomas Zimmermann
Hi Jocelyn Am 26.07.23 um 10:10 schrieb Jocelyn Falempe: [...] So the old kernel already did the right thing. In the *new* code the nearest-named function I could see issys/class/drm/card1-eDP-1/modes mgag200_mode_config_mode_valid, which returns MODE_OK at the end of the function if the

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-07-26 Thread Thomas Zimmermann
Hi Am 26.07.23 um 12:11 schrieb Roger Sewell: Jocelyn, How can I check for sure whether I am using 24 or 32 bits per pixel ? The easiest solution if you already rebuilt your kernel is to print the variable bpp here:

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-07-26 Thread Jocelyn Falempe
On 26/07/2023 12:11, Roger Sewell wrote: Jocelyn, How can I check for sure whether I am using 24 or 32 bits per pixel ? The easiest solution if you already rebuilt your kernel is to print the variable bpp here:

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-07-26 Thread Jocelyn Falempe
On 25/07/2023 23:31, Roger Sewell wrote: Thomas, Thank you for your reply. Table 10 in the following document says that 1440x900@60Hz is supported: https://www.intel.com/content/dam/support/us/en/documents/motherboards/server/s5520ur/sb/e44031012_s5520ur_s5520urt_tps_r1_9.pdf That manual

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-07-26 Thread Jocelyn Falempe
On 25/07/2023 21:37, Thomas Zimmermann wrote: Hi Roger, thanks for all the information. Am 24.07.23 um 22:57 schrieb Roger Sewell: Thomas, Hello, I'm the user who reported the issue. Definitely happy to help you sort this out if I can, though my response speed will decrease when term

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-07-26 Thread Roger Sewell
Thomas, Thank you for your reply. >> Table 10 in the following document says that 1440x900@60Hz is >> supported: >> https://www.intel.com/content/dam/support/us/en/documents/motherboards/server/s5520ur/sb/e44031012_s5520ur_s5520urt_tps_r1_9.pdf > > That manual says that the resolution is

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-07-25 Thread Thomas Zimmermann
Hi Roger, thanks for all the information. Am 24.07.23 um 22:57 schrieb Roger Sewell: Thomas, Hello, I'm the user who reported the issue. Definitely happy to help you sort this out if I can, though my response speed will decrease when term restarts in October. I'd be interested in the exact

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-07-25 Thread Roger Sewell
Thomas, Hello, I'm the user who reported the issue. Definitely happy to help you sort this out if I can, though my response speed will decrease when term restarts in October. > I'd be interested in the exact model and the unique_rev_id > (you said A, rev1 ?) The machine is an Intel SR1625URR

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-07-24 Thread Thomas Zimmermann
Am 24.07.23 um 20:48 schrieb Thomas Zimmermann: Hi Jocelyn Am 17.07.23 um 15:29 schrieb Jocelyn Falempe: A G200SE_A rev 1 user reported that prior to v6.0, he was able to get Xorg working at 1440x900@60Hz. This somehow bypassed the bandwidth test in the driver. After v6.0, and the driver

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-07-24 Thread Thomas Zimmermann
Hi Jocelyn Am 17.07.23 um 15:29 schrieb Jocelyn Falempe: A G200SE_A rev 1 user reported that prior to v6.0, he was able to get Xorg working at 1440x900@60Hz. This somehow bypassed the bandwidth test in the driver. After v6.0, and the driver refactor, it's no longer possible. I took that

[PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-07-17 Thread Jocelyn Falempe
A G200SE_A rev 1 user reported that prior to v6.0, he was able to get Xorg working at 1440x900@60Hz. This somehow bypassed the bandwidth test in the driver. After v6.0, and the driver refactor, it's no longer possible. So increase the bandwidth, as the hardware is able to do it. In