Re: [Freedreno] [PATCH] drm/msm/dpu: add DSC range checking during resource reservation

2023-04-12 Thread Abhinav Kumar
On 4/12/2023 11:50 AM, Marijn Suijten wrote: On 2023-04-12 10:48:18, Abhinav Kumar wrote: [..] The only way to trigger this newly introduced range check is by omitting the DSC_x constants and manually writing e.g. an out-of-range value 10 here, or setting DSC_NONE. This is only allowed for

Re: [Freedreno] [PATCH] drm/msm/dpu: add DSC range checking during resource reservation

2023-04-12 Thread Dmitry Baryshkov
On 12/04/2023 21:50, Marijn Suijten wrote: On 2023-04-12 10:48:18, Abhinav Kumar wrote: [..] The only way to trigger this newly introduced range check is by omitting the DSC_x constants and manually writing e.g. an out-of-range value 10 here, or setting DSC_NONE. This is only allowed for

Re: [Freedreno] [PATCH] drm/msm/dpu: add DSC range checking during resource reservation

2023-04-12 Thread Marijn Suijten
On 2023-04-12 10:48:18, Abhinav Kumar wrote: [..] > > The only way to trigger this newly introduced range check is by omitting > > the DSC_x constants and manually writing e.g. an out-of-range value 10 > > here, or setting DSC_NONE. This is only allowed for interfaces. > > > > Correct, its just

Re: [Freedreno] [PATCH] drm/msm/dpu: add DSC range checking during resource reservation

2023-04-12 Thread Abhinav Kumar
On 4/12/2023 12:38 AM, Marijn Suijten wrote: On 2023-04-11 18:50:24, Abhinav Kumar wrote: On 4/11/2023 6:06 PM, Dmitry Baryshkov wrote: On 12/04/2023 01:32, Abhinav Kumar wrote: Hi Marijn On 4/11/2023 3:24 PM, Marijn Suijten wrote: Again, don't forget to include previous reviewers in

Re: [Freedreno] [PATCH] drm/msm/dpu: add DSC range checking during resource reservation

2023-04-12 Thread Marijn Suijten
On 2023-04-11 18:50:24, Abhinav Kumar wrote: > > > On 4/11/2023 6:06 PM, Dmitry Baryshkov wrote: > > On 12/04/2023 01:32, Abhinav Kumar wrote: > >> Hi Marijn > >> > >> On 4/11/2023 3:24 PM, Marijn Suijten wrote: > >>> Again, don't forget to include previous reviewers in cc, please :) > >>> > >>>

Re: [Freedreno] [PATCH] drm/msm/dpu: add DSC range checking during resource reservation

2023-04-11 Thread Abhinav Kumar
On 4/11/2023 6:06 PM, Dmitry Baryshkov wrote: On 12/04/2023 01:32, Abhinav Kumar wrote: Hi Marijn On 4/11/2023 3:24 PM, Marijn Suijten wrote: Again, don't forget to include previous reviewers in cc, please :) On 2023-04-11 14:09:40, Kuogee Hsieh wrote: Perform DSC range checking to make

Re: [Freedreno] [PATCH] drm/msm/dpu: add DSC range checking during resource reservation

2023-04-11 Thread Dmitry Baryshkov
On 12/04/2023 01:32, Abhinav Kumar wrote: Hi Marijn On 4/11/2023 3:24 PM, Marijn Suijten wrote: Again, don't forget to include previous reviewers in cc, please :) On 2023-04-11 14:09:40, Kuogee Hsieh wrote: Perform DSC range checking to make sure correct DSC is requested before reserve

Re: [Freedreno] [PATCH] drm/msm/dpu: add DSC range checking during resource reservation

2023-04-11 Thread Abhinav Kumar
Hi Marijn On 4/11/2023 3:24 PM, Marijn Suijten wrote: Again, don't forget to include previous reviewers in cc, please :) On 2023-04-11 14:09:40, Kuogee Hsieh wrote: Perform DSC range checking to make sure correct DSC is requested before reserve resource for it. This isn't performing any

Re: [PATCH] drm/msm/dpu: add DSC range checking during resource reservation

2023-04-11 Thread Marijn Suijten
Again, don't forget to include previous reviewers in cc, please :) On 2023-04-11 14:09:40, Kuogee Hsieh wrote: > Perform DSC range checking to make sure correct DSC is requested before > reserve resource for it. This isn't performing any range checking for resource reservations / requests: this

Re: [PATCH] drm/msm/dpu: add DSC range checking during resource reservation

2023-04-11 Thread Dmitry Baryshkov
On 12/04/2023 00:09, Kuogee Hsieh wrote: Perform DSC range checking to make sure correct DSC is requested before reserve resource for it. Fixes: c985d7bb64ff ("drm/msm/disp/dpu1: Add DSC support in RM") $ git log -p -1 c985d7bb64ff fatal: ambiguous argument 'c985d7bb64ff': unknown revision or

Re: [PATCH] drm/msm/dpu: add DSC range checking during resource reservation

2023-04-11 Thread Abhinav Kumar
On 4/11/2023 2:09 PM, Kuogee Hsieh wrote: Perform DSC range checking to make sure correct DSC is requested before reserve resource for it. Fixes: c985d7bb64ff ("drm/msm/disp/dpu1: Add DSC support in RM") I cannot find any fixes tag with this hash. This is the right one. Fixes:

[PATCH] drm/msm/dpu: add DSC range checking during resource reservation

2023-04-11 Thread Kuogee Hsieh
Perform DSC range checking to make sure correct DSC is requested before reserve resource for it. Fixes: c985d7bb64ff ("drm/msm/disp/dpu1: Add DSC support in RM") Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 10 +- 1 file changed, 9 insertions(+), 1