Re: [PATCH] drm/simpledrm: Only advertise formats that are supported

2022-10-28 Thread Thomas Zimmermann
Hi Am 28.10.22 um 12:04 schrieb Ville Syrjälä: On Thu, Oct 27, 2022 at 01:08:24PM +0200, Thomas Zimmermann wrote: I trust you when you say that ->XRGB is not enough. But although I've read your replies, I still don't understand why this switch is necessary. Why don't we call

Re: [PATCH] drm/simpledrm: Only advertise formats that are supported

2022-10-28 Thread Ville Syrjälä
On Thu, Oct 27, 2022 at 01:08:24PM +0200, Thomas Zimmermann wrote: > I trust you when you say that ->XRGB is not enough. But > although I've read your replies, I still don't understand why this > switch is necessary. > > Why don't we call drm_fb_build_fourcc_list() with the native >

Re: [PATCH] drm/simpledrm: Only advertise formats that are supported

2022-10-28 Thread Michel Dänzer
On 2022-10-27 12:53, Hector Martin wrote: > > Q: Why not just add a conversion from XRGB2101010 to XRGB? > A: Because that would only fix KDE, and would make it slower vs. not > advertising XRGB2101010 at all (double conversions, plus kernel > conversion can be slower). Plus, it doesn't make

Re: [PATCH] drm/simpledrm: Only advertise formats that are supported

2022-10-27 Thread Thomas Zimmermann
Hi Am 27.10.22 um 14:22 schrieb Pekka Paalanen: On Thu, 27 Oct 2022 13:08:24 +0200 Thomas Zimmermann wrote: Hi Am 27.10.22 um 12:13 schrieb Hector Martin: Until now, simpledrm unconditionally advertised all formats that can be supported natively as conversions. However, we don't actually

Re: [PATCH] drm/simpledrm: Only advertise formats that are supported

2022-10-27 Thread Hector Martin
On 27/10/2022 20.08, Thomas Zimmermann wrote: > We currently have two DRM drivers that call drm_fb_build_fourcc_list(): > simpledrm and ofdrm. I've been very careful to keep the format selection > in sync between them. (That's the reason why the helper exists at all.) > If the drivers start to

Re: [PATCH] drm/simpledrm: Only advertise formats that are supported

2022-10-27 Thread Pekka Paalanen
On Thu, 27 Oct 2022 13:08:24 +0200 Thomas Zimmermann wrote: > Hi > > Am 27.10.22 um 12:13 schrieb Hector Martin: > > Until now, simpledrm unconditionally advertised all formats that can be > > supported natively as conversions. However, we don't actually have a > > full conversion matrix of

Re: [PATCH] drm/simpledrm: Only advertise formats that are supported

2022-10-27 Thread Thomas Zimmermann
Hi Am 27.10.22 um 12:13 schrieb Hector Martin: Until now, simpledrm unconditionally advertised all formats that can be supported natively as conversions. However, we don't actually have a full conversion matrix of helpers. Although the list is arguably provided to userspace in precedence order,

Re: [PATCH] drm/simpledrm: Only advertise formats that are supported

2022-10-27 Thread Hector Martin
On 27/10/2022 19.13, Hector Martin wrote: > Until now, simpledrm unconditionally advertised all formats that can be > supported natively as conversions. However, we don't actually have a > full conversion matrix of helpers. Although the list is arguably > provided to userspace in precedence order,

[PATCH] drm/simpledrm: Only advertise formats that are supported

2022-10-27 Thread Hector Martin
Until now, simpledrm unconditionally advertised all formats that can be supported natively as conversions. However, we don't actually have a full conversion matrix of helpers. Although the list is arguably provided to userspace in precedence order, userspace can pick something out-of-order (and