Re: [PATCH] fbdev: tgafb: Fix potential divide by zero

2023-03-09 Thread Helge Deller
On 3/9/23 08:53, Jani Nikula wrote: On Wed, 08 Mar 2023, Helge Deller wrote: On 3/7/23 14:08, harperchen wrote: fb_set_var would by called when user invokes ioctl with cmd FBIOPUT_VSCREENINFO. User-provided data would finally reach tgafb_check_var. In case var->pixclock is assigned to zero,

Re: [PATCH] fbdev: tgafb: Fix potential divide by zero

2023-03-08 Thread Jani Nikula
On Wed, 08 Mar 2023, Helge Deller wrote: > On 3/7/23 14:08, harperchen wrote: >> fb_set_var would by called when user invokes ioctl with cmd >> FBIOPUT_VSCREENINFO. User-provided data would finally reach >> tgafb_check_var. In case var->pixclock is assigned to zero, >> divide by zero would occur

Re: [PATCH] fbdev: tgafb: Fix potential divide by zero

2023-03-08 Thread Wei Chen
Dear Helge, Thank you for the kind words. My real name is Wei Chen. Please apply this patch to fbdev git tree if it is correct. Best, Wei On Thu, 9 Mar 2023 at 06:05, Helge Deller wrote: > > On 3/7/23 14:08, harperchen wrote: > > fb_set_var would by called when user invokes ioctl with cmd > >

Re: [PATCH] fbdev: tgafb: Fix potential divide by zero

2023-03-08 Thread Helge Deller
On 3/7/23 14:08, harperchen wrote: fb_set_var would by called when user invokes ioctl with cmd FBIOPUT_VSCREENINFO. User-provided data would finally reach tgafb_check_var. In case var->pixclock is assigned to zero, divide by zero would occur when checking whether reciprocal of var->pixclock is

[PATCH] fbdev: tgafb: Fix potential divide by zero

2023-03-07 Thread harperchen
fb_set_var would by called when user invokes ioctl with cmd FBIOPUT_VSCREENINFO. User-provided data would finally reach tgafb_check_var. In case var->pixclock is assigned to zero, divide by zero would occur when checking whether reciprocal of var->pixclock is too high. Similar crashes have