Re: [PATCH 02/11] drm/bridge: tc358768: Fix bit updates

2023-08-16 Thread Tomi Valkeinen
On 15/08/2023 20:21, Maxim Schwalm wrote: On 14.08.23 08:34, Tomi Valkeinen wrote: On 13/08/2023 03:23, Maxim Schwalm wrote: Hi, On 11.08.23 19:02, Tomi Valkeinen wrote: On 11/08/2023 19:23, Péter Ujfalusi wrote: On 04/08/2023 13:44, Tomi Valkeinen wrote: The driver has a few places

Re: [PATCH 02/11] drm/bridge: tc358768: Fix bit updates

2023-08-16 Thread Tomi Valkeinen
On 15/08/2023 20:21, Maxim Schwalm wrote: On 14.08.23 08:34, Tomi Valkeinen wrote: On 13/08/2023 03:23, Maxim Schwalm wrote: Hi, On 11.08.23 19:02, Tomi Valkeinen wrote: On 11/08/2023 19:23, Péter Ujfalusi wrote: On 04/08/2023 13:44, Tomi Valkeinen wrote: The driver has a few places

Re: [PATCH 02/11] drm/bridge: tc358768: Fix bit updates

2023-08-16 Thread Maxim Schwalm
On 14.08.23 08:34, Tomi Valkeinen wrote: > On 13/08/2023 03:23, Maxim Schwalm wrote: >> Hi, >> >> On 11.08.23 19:02, Tomi Valkeinen wrote: >>> On 11/08/2023 19:23, Péter Ujfalusi wrote: On 04/08/2023 13:44, Tomi Valkeinen wrote: > The driver has a few places where it does: >

Re: [PATCH 02/11] drm/bridge: tc358768: Fix bit updates

2023-08-14 Thread Maxim Schwalm
Hi, On 11.08.23 19:02, Tomi Valkeinen wrote: > On 11/08/2023 19:23, Péter Ujfalusi wrote: >> >> >> On 04/08/2023 13:44, Tomi Valkeinen wrote: >>> The driver has a few places where it does: >>> >>> if (thing_is_enabled_in_config) >>> update_thing_bit_in_hw() >>> >>> This means that if the

Re: [PATCH 02/11] drm/bridge: tc358768: Fix bit updates

2023-08-14 Thread Tomi Valkeinen
On 13/08/2023 03:23, Maxim Schwalm wrote: Hi, On 11.08.23 19:02, Tomi Valkeinen wrote: On 11/08/2023 19:23, Péter Ujfalusi wrote: On 04/08/2023 13:44, Tomi Valkeinen wrote: The driver has a few places where it does: if (thing_is_enabled_in_config) update_thing_bit_in_hw() This

Re: [PATCH 02/11] drm/bridge: tc358768: Fix bit updates

2023-08-11 Thread Tomi Valkeinen
On 11/08/2023 19:23, Péter Ujfalusi wrote: On 04/08/2023 13:44, Tomi Valkeinen wrote: The driver has a few places where it does: if (thing_is_enabled_in_config) update_thing_bit_in_hw() This means that if the thing is _not_ enabled, the bit never gets cleared. This affects the

Re: [PATCH 02/11] drm/bridge: tc358768: Fix bit updates

2023-08-11 Thread Péter Ujfalusi
On 04/08/2023 13:44, Tomi Valkeinen wrote: > The driver has a few places where it does: > > if (thing_is_enabled_in_config) > update_thing_bit_in_hw() > > This means that if the thing is _not_ enabled, the bit never gets > cleared. This affects the h/vsyncs and continuous DSI clock

[PATCH 02/11] drm/bridge: tc358768: Fix bit updates

2023-08-04 Thread Tomi Valkeinen
The driver has a few places where it does: if (thing_is_enabled_in_config) update_thing_bit_in_hw() This means that if the thing is _not_ enabled, the bit never gets cleared. This affects the h/vsyncs and continuous DSI clock bits. Fix the driver to always update the bit. Fixes: