Re: [PATCH 04/12] drm/client: Add a FIXME around crtc->mode usage

2024-04-05 Thread Ville Syrjälä
On Fri, Apr 05, 2024 at 06:32:46AM +0300, Dmitry Baryshkov wrote: > On Thu, Apr 04, 2024 at 11:33:28PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > crtc->mode is legacy junk and shouldn't really be used with > > atomic drivers. > > > > Most (all?) atomic drivers do end up still

Re: [PATCH 04/12] drm/client: Add a FIXME around crtc->mode usage

2024-04-04 Thread Dmitry Baryshkov
On Thu, Apr 04, 2024 at 11:33:28PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > crtc->mode is legacy junk and shouldn't really be used with > atomic drivers. > > Most (all?) atomic drivers do end up still calling > drm_atomic_helper_update_legacy_modeset_state() at some > point, so

[PATCH 04/12] drm/client: Add a FIXME around crtc->mode usage

2024-04-04 Thread Ville Syrjala
From: Ville Syrjälä crtc->mode is legacy junk and shouldn't really be used with atomic drivers. Most (all?) atomic drivers do end up still calling drm_atomic_helper_update_legacy_modeset_state() at some point, so crtc->mode does still get populated, and this does work for now. But eventually