RE: [PATCH 08/27] habanalabs: add info when FD released while device still in use

2023-02-20 Thread Tomer Tayar
On Thu, Feb 20, 2023 at 17:55 Stanislaw Gruszka wrote: > On Fri, Feb 17, 2023 at 11:34:39AM +, Tomer Tayar wrote: > > > > > Ok, just place replace compose_device_in_use_info() with snprintf(). > > > I don't think you need custom implementation of snprintf(). > > > >

Re: [PATCH 08/27] habanalabs: add info when FD released while device still in use

2023-02-20 Thread Stanislaw Gruszka
On Fri, Feb 17, 2023 at 11:34:39AM +, Tomer Tayar wrote: > > > Ok, just place replace compose_device_in_use_info() with snprintf(). > > I don't think you need custom implementation of snprintf(). > > compose_device_in_use_info() was added to handle in a single place the > snprintf() return

RE: [PATCH 08/27] habanalabs: add info when FD released while device still in use

2023-02-17 Thread Tomer Tayar
On Thu, Feb 16, 2023 at 17:05 Stanislaw Gruszka wrote: > On Thu, Feb 16, 2023 at 04:21:48PM +0200, Oded Gabbay wrote: > > On Thu, Feb 16, 2023 at 2:25 PM Stanislaw Gruszka > > wrote: > > > > > > On Sun, Feb 12, 2023 at 10:44:35PM +0200, Oded Gabbay wrote: > > > > From: Tomer Tayar > > > > > >

Re: [PATCH 08/27] habanalabs: add info when FD released while device still in use

2023-02-16 Thread Stanislaw Gruszka
On Thu, Feb 16, 2023 at 04:21:48PM +0200, Oded Gabbay wrote: > On Thu, Feb 16, 2023 at 2:25 PM Stanislaw Gruszka > wrote: > > > > On Sun, Feb 12, 2023 at 10:44:35PM +0200, Oded Gabbay wrote: > > > From: Tomer Tayar > > > > > > When user closes the device file descriptor, it is checked whether

Re: [PATCH 08/27] habanalabs: add info when FD released while device still in use

2023-02-16 Thread Oded Gabbay
On Thu, Feb 16, 2023 at 2:25 PM Stanislaw Gruszka wrote: > > On Sun, Feb 12, 2023 at 10:44:35PM +0200, Oded Gabbay wrote: > > From: Tomer Tayar > > > > When user closes the device file descriptor, it is checked whether the > > device is still in use, and a message is printed if it is. > > I

Re: [PATCH 08/27] habanalabs: add info when FD released while device still in use

2023-02-16 Thread Stanislaw Gruszka
On Sun, Feb 12, 2023 at 10:44:35PM +0200, Oded Gabbay wrote: > From: Tomer Tayar > > When user closes the device file descriptor, it is checked whether the > device is still in use, and a message is printed if it is. I guess this is only for debugging your user-space component? Because kernel

[PATCH 08/27] habanalabs: add info when FD released while device still in use

2023-02-12 Thread Oded Gabbay
From: Tomer Tayar When user closes the device file descriptor, it is checked whether the device is still in use, and a message is printed if it is. To make this message more informative, add to this print also the reason due to which the device is considered as in use. The possible reasons which