Re: [PATCH 1/3] drm/simpledrm: Bind to OF framebuffers in /chosen

2021-11-30 Thread Rob Herring
On Tue, Nov 30, 2021 at 12:45 AM Javier Martinez Canillas wrote: > > > > > > > > > Simpledrm is just a driver, but this is platform setup code. Why is this > > > > code located here and not under arch/ or drivers/firmware/? > > > > > > Agreed. Creating platform devices is something for platform

Re: [PATCH 1/3] drm/simpledrm: Bind to OF framebuffers in /chosen

2021-11-30 Thread Javier Martinez Canillas
Hello Thomas, On Tue, Nov 30, 2021 at 9:31 AM Thomas Zimmermann wrote: > Am 30.11.21 um 07:44 schrieb Javier Martinez Canillas: [snip] > > > > I think that instead it could be done in the sysfb_create_simplefb() > > function [0], which already creates the "simple-framebuffer" device > > for

Re: [PATCH 1/3] drm/simpledrm: Bind to OF framebuffers in /chosen

2021-11-30 Thread Thomas Zimmermann
Hi Am 30.11.21 um 07:44 schrieb Javier Martinez Canillas: Simpledrm is just a driver, but this is platform setup code. Why is this code located here and not under arch/ or drivers/firmware/? Agreed. Creating platform devices is something for platform code and not really a DRM driver. I

Re: [PATCH 1/3] drm/simpledrm: Bind to OF framebuffers in /chosen

2021-11-29 Thread Javier Martinez Canillas
> > > > > > Simpledrm is just a driver, but this is platform setup code. Why is this > > > code located here and not under arch/ or drivers/firmware/? > > > Agreed. Creating platform devices is something for platform code and not really a DRM driver. > > > I know that other drivers do similar

Re: [PATCH 1/3] drm/simpledrm: Bind to OF framebuffers in /chosen

2021-11-29 Thread Rob Herring
On Fri, Nov 19, 2021 at 9:24 PM Hector Martin wrote: > > On 18/11/2021 18.19, Thomas Zimmermann wrote: > > Hi > > > > Am 17.11.21 um 15:58 schrieb Hector Martin: > >> @@ -897,5 +898,21 @@ static struct platform_driver > >> simpledrm_platform_driver = { > >> > >>

Re: [PATCH 1/3] drm/simpledrm: Bind to OF framebuffers in /chosen

2021-11-29 Thread Thomas Zimmermann
Hi Am 20.11.21 um 04:23 schrieb Hector Martin: On 18/11/2021 18.19, Thomas Zimmermann wrote: Hi Am 17.11.21 um 15:58 schrieb Hector Martin: @@ -897,5 +898,21 @@ static struct platform_driver simpledrm_platform_driver = {    module_platform_driver(simpledrm_platform_driver); +static int

Re: [PATCH 1/3] drm/simpledrm: Bind to OF framebuffers in /chosen

2021-11-19 Thread Hector Martin
On 18/11/2021 18.19, Thomas Zimmermann wrote: Hi Am 17.11.21 um 15:58 schrieb Hector Martin: @@ -897,5 +898,21 @@ static struct platform_driver simpledrm_platform_driver = { module_platform_driver(simpledrm_platform_driver); +static int __init simpledrm_init(void) +{ + struct

Re: [PATCH 1/3] drm/simpledrm: Bind to OF framebuffers in /chosen

2021-11-18 Thread Thomas Zimmermann
Hi Am 17.11.21 um 15:58 schrieb Hector Martin: This matches the simplefb behavior; these nodes are not matched by the standard OF machinery. This fixes a regression when simpledrm replaces simeplefb. Signed-off-by: Hector Martin --- drivers/gpu/drm/tiny/simpledrm.c | 17 +

[PATCH 1/3] drm/simpledrm: Bind to OF framebuffers in /chosen

2021-11-17 Thread Hector Martin
This matches the simplefb behavior; these nodes are not matched by the standard OF machinery. This fixes a regression when simpledrm replaces simeplefb. Signed-off-by: Hector Martin --- drivers/gpu/drm/tiny/simpledrm.c | 17 + 1 file changed, 17 insertions(+) diff --git