Re: [PATCH 4/5] drm/vmwgfx: Fix crtc's atomic check conditional

2024-04-09 Thread Martin Krastev
On Wed, Apr 3, 2024 at 2:28 AM Zack Rusin wrote: > > The conditional was supposed to prevent enabling of a crtc state > without a set primary plane. Accidently it also prevented disabling > crtc state with a set primary plane. Neither is correct. > > Fix the conditional and just driver-warn when

Re: [PATCH 4/5] drm/vmwgfx: Fix crtc's atomic check conditional

2024-04-05 Thread Ian Forbes
Makes sense. Reviewed-by: Ian Forbes On Tue, Apr 2, 2024 at 6:28 PM Zack Rusin wrote: > > The conditional was supposed to prevent enabling of a crtc state > without a set primary plane. Accidently it also prevented disabling > crtc state with a set primary plane. Neither is correct. > > Fix

[PATCH 4/5] drm/vmwgfx: Fix crtc's atomic check conditional

2024-04-02 Thread Zack Rusin
The conditional was supposed to prevent enabling of a crtc state without a set primary plane. Accidently it also prevented disabling crtc state with a set primary plane. Neither is correct. Fix the conditional and just driver-warn when a crtc state has been enabled without a primary plane which