Re: [PATCH RFC 01/18] rust: drm: ioctl: Add DRM ioctl abstraction

2023-04-13 Thread Daniel Vetter
On Tue, Mar 07, 2023 at 11:25:26PM +0900, Asahi Lina wrote: > DRM drivers need to be able to declare which driver-specific ioctls they > support. This abstraction adds the required types and a helper macro to > generate the ioctl definition inside the DRM driver. > > Note that this macro is not

Re: [PATCH RFC 01/18] rust: drm: ioctl: Add DRM ioctl abstraction

2023-03-09 Thread Asahi Lina
On 10/03/2023 05.39, Karol Herbst wrote: > On Thu, Mar 9, 2023 at 9:24 PM Faith Ekstrand > wrote: >> >> On Thu, 2023-03-09 at 15:04 +0900, Asahi Lina wrote: >>> On 08/03/2023 02.34, Björn Roy Baron wrote: > +// SAFETY: This is just the ioctl > argument, which

Re: [PATCH RFC 01/18] rust: drm: ioctl: Add DRM ioctl abstraction

2023-03-09 Thread Karol Herbst
On Thu, Mar 9, 2023 at 9:24 PM Faith Ekstrand wrote: > > On Thu, 2023-03-09 at 15:04 +0900, Asahi Lina wrote: > > On 08/03/2023 02.34, Björn Roy Baron wrote: > > > > +// SAFETY: This is just the ioctl > > > > argument, which hopefully has the right type > > > > +

Re: [PATCH RFC 01/18] rust: drm: ioctl: Add DRM ioctl abstraction

2023-03-09 Thread Faith Ekstrand
On Thu, 2023-03-09 at 15:04 +0900, Asahi Lina wrote: > On 08/03/2023 02.34, Björn Roy Baron wrote: > > > +    // SAFETY: This is just the ioctl > > > argument, which hopefully has the right type > > > +    // (we've done our best checking the > > >

Re: [PATCH RFC 01/18] rust: drm: ioctl: Add DRM ioctl abstraction

2023-03-09 Thread Maíra Canal
On 3/9/23 03:15, Dave Airlie wrote: On Thu, 9 Mar 2023 at 15:32, Asahi Lina wrote: On 08/03/2023 00.32, Maíra Canal wrote: On 3/7/23 11:25, Asahi Lina wrote: DRM drivers need to be able to declare which driver-specific ioctls they support. This abstraction adds the required types and a

Re: [PATCH RFC 01/18] rust: drm: ioctl: Add DRM ioctl abstraction

2023-03-08 Thread Dave Airlie
On Thu, 9 Mar 2023 at 15:32, Asahi Lina wrote: > > On 08/03/2023 00.32, Maíra Canal wrote: > > On 3/7/23 11:25, Asahi Lina wrote: > >> DRM drivers need to be able to declare which driver-specific ioctls they > >> support. This abstraction adds the required types and a helper macro to > >>

Re: [PATCH RFC 01/18] rust: drm: ioctl: Add DRM ioctl abstraction

2023-03-08 Thread Asahi Lina
On 08/03/2023 02.34, Björn Roy Baron wrote: >> +// SAFETY: This is just the ioctl argument, >> which hopefully has the right type >> +// (we've done our best checking the size). > > In the rust tree there is the ReadableFromBytes [1] trait

Re: [PATCH RFC 01/18] rust: drm: ioctl: Add DRM ioctl abstraction

2023-03-08 Thread Asahi Lina
On 08/03/2023 00.32, Maíra Canal wrote: > On 3/7/23 11:25, Asahi Lina wrote: >> DRM drivers need to be able to declare which driver-specific ioctls they >> support. This abstraction adds the required types and a helper macro to >> generate the ioctl definition inside the DRM driver. >> >> Note

Re: [PATCH RFC 01/18] rust: drm: ioctl: Add DRM ioctl abstraction

2023-03-08 Thread Björn Roy Baron
--- Original Message --- On Tuesday, March 7th, 2023 at 15:25, Asahi Lina wrote: > DRM drivers need to be able to declare which driver-specific ioctls they > support. This abstraction adds the required types and a helper macro to > generate the ioctl definition inside the DRM driver. >

Re: [PATCH RFC 01/18] rust: drm: ioctl: Add DRM ioctl abstraction

2023-03-07 Thread Maíra Canal
On 3/7/23 11:25, Asahi Lina wrote: DRM drivers need to be able to declare which driver-specific ioctls they support. This abstraction adds the required types and a helper macro to generate the ioctl definition inside the DRM driver. Note that this macro is not usable until further bits of the

Re: [PATCH RFC 01/18] rust: drm: ioctl: Add DRM ioctl abstraction

2023-03-07 Thread Karol Herbst
On Tue, Mar 7, 2023 at 3:48 PM Karol Herbst wrote: > > On Tue, Mar 7, 2023 at 3:27 PM Asahi Lina wrote: > > > > DRM drivers need to be able to declare which driver-specific ioctls they > > support. This abstraction adds the required types and a helper macro to > > generate the ioctl definition

Re: [PATCH RFC 01/18] rust: drm: ioctl: Add DRM ioctl abstraction

2023-03-07 Thread Karol Herbst
On Tue, Mar 7, 2023 at 3:27 PM Asahi Lina wrote: > > DRM drivers need to be able to declare which driver-specific ioctls they > support. This abstraction adds the required types and a helper macro to > generate the ioctl definition inside the DRM driver. > > Note that this macro is not usable

[PATCH RFC 01/18] rust: drm: ioctl: Add DRM ioctl abstraction

2023-03-07 Thread Asahi Lina
DRM drivers need to be able to declare which driver-specific ioctls they support. This abstraction adds the required types and a helper macro to generate the ioctl definition inside the DRM driver. Note that this macro is not usable until further bits of the abstraction are in place (but it will