Re: [PATCH V2] drm/vkms: Add vblank events simulated by hrtimers

2018-07-05 Thread Daniel Vetter
On Thu, Jul 5, 2018 at 6:45 PM, Chris Wilson wrote: > Quoting Rodrigo Siqueira (2018-07-05 17:28:20) >> Hi and thanks for all the feedback, I will work on the suggestions you sent, >> but I have some doubts: >> >> On 07/05, Chris Wilson wrote: >> > Quoting Daniel Vetter (2018-07-05 09:20:13) >> >

Re: [PATCH V2] drm/vkms: Add vblank events simulated by hrtimers

2018-07-05 Thread Rodrigo Siqueira
Now I got it! Really thanks for the help. I will prepare a V3. On Thu, Jul 5, 2018 at 1:45 PM, Chris Wilson wrote: > Quoting Rodrigo Siqueira (2018-07-05 17:28:20) > > Hi and thanks for all the feedback, I will work on the suggestions you > sent, > > but I have some doubts: > > > > On 07/05,

Re: [PATCH V2] drm/vkms: Add vblank events simulated by hrtimers

2018-07-05 Thread Chris Wilson
Quoting Rodrigo Siqueira (2018-07-05 17:28:20) > Hi and thanks for all the feedback, I will work on the suggestions you sent, > but I have some doubts: > > On 07/05, Chris Wilson wrote: > > Quoting Daniel Vetter (2018-07-05 09:20:13) > > > On Thu, Jul 05, 2018 at 12:48:43AM -0300, Rodrigo

Re: [PATCH V2] drm/vkms: Add vblank events simulated by hrtimers

2018-07-05 Thread Rodrigo Siqueira
Hi and thanks for all the feedback, I will work on the suggestions you sent, but I have some doubts: On 07/05, Chris Wilson wrote: > Quoting Daniel Vetter (2018-07-05 09:20:13) > > On Thu, Jul 05, 2018 at 12:48:43AM -0300, Rodrigo Siqueira wrote: > > > + ktime_t current_timestamp; > > > + > >

Re: [PATCH V2] drm/vkms: Add vblank events simulated by hrtimers

2018-07-05 Thread Chris Wilson
Quoting Daniel Vetter (2018-07-05 09:20:13) > On Thu, Jul 05, 2018 at 12:48:43AM -0300, Rodrigo Siqueira wrote: > > + ktime_t current_timestamp; > > + > > + hrtimer_init(>vblank_hrtimer, CLOCK_MONOTONIC, HRTIMER_MODE_REL); > > Can't we use absolute timer mode here? That avoids all the

Re: [PATCH V2] drm/vkms: Add vblank events simulated by hrtimers

2018-07-05 Thread Daniel Vetter
On Thu, Jul 05, 2018 at 12:48:43AM -0300, Rodrigo Siqueira wrote: > This commit adds regular vblank events simulated through hrtimers, which > is a feature required by VKMS to mimic real hardware. Notice that > keeping the periodicity as close as possible to the one specified in > user space

[PATCH V2] drm/vkms: Add vblank events simulated by hrtimers

2018-07-04 Thread Rodrigo Siqueira
This commit adds regular vblank events simulated through hrtimers, which is a feature required by VKMS to mimic real hardware. Notice that keeping the periodicity as close as possible to the one specified in user space represents a vital constraint. In this sense, the callback function implements