Re: [PATCH v2 0/2] Fixes for omapdrm console

2024-02-27 Thread Thomas Zimmermann
Hi Am 27.02.24 um 11:19 schrieb Tony Lindgren: * Tony Lindgren [240227 11:47]: * Thomas Zimmermann [240227 09:16]: I just realized the fb_deferred_io_mmap() is already exported. So please use it instead of duplicating the code in omapdrm. [1]

Re: [PATCH v2 0/2] Fixes for omapdrm console

2024-02-27 Thread Tony Lindgren
* Tony Lindgren [240227 11:47]: > * Thomas Zimmermann [240227 09:16]: > > I just realized the fb_deferred_io_mmap() is already exported. So please use > > it instead of duplicating the code in omapdrm. > > > > [1] > >

Re: [PATCH v2 0/2] Fixes for omapdrm console

2024-02-27 Thread Tony Lindgren
* Thomas Zimmermann [240227 09:16]: > I just realized the fb_deferred_io_mmap() is already exported. So please use > it instead of duplicating the code in omapdrm. > > [1] > https://elixir.bootlin.com/linux/v6.7/source/drivers/video/fbdev/core/fb_defio.c#L237 Yeah I have now: static int

Re: [PATCH v2 0/2] Fixes for omapdrm console

2024-02-27 Thread Thomas Zimmermann
Hi Am 27.02.24 um 09:01 schrieb Tony Lindgren: * Thomas Zimmermann [240227 07:56]: Am 27.02.24 um 08:06 schrieb Tony Lindgren: * Tony Lindgren [240226 13:26]: * Thomas Zimmermann [240226 09:10]: Am 26.02.24 um 10:01 schrieb Tomi Valkeinen: On 26/02/2024 10:26, Tomi Valkeinen wrote: How

Re: [PATCH v2 0/2] Fixes for omapdrm console

2024-02-27 Thread Tony Lindgren
* Thomas Zimmermann [240227 07:56]: > Am 27.02.24 um 08:06 schrieb Tony Lindgren: > > * Tony Lindgren [240226 13:26]: > > > * Thomas Zimmermann [240226 09:10]: > > > > Am 26.02.24 um 10:01 schrieb Tomi Valkeinen: > > > > > On 26/02/2024 10:26, Tomi Valkeinen wrote: > > > > > > How is it broken?

Re: [PATCH v2 0/2] Fixes for omapdrm console

2024-02-26 Thread Thomas Zimmermann
Hi Am 27.02.24 um 08:06 schrieb Tony Lindgren: * Tony Lindgren [240226 13:26]: * Thomas Zimmermann [240226 09:10]: Am 26.02.24 um 10:01 schrieb Tomi Valkeinen: On 26/02/2024 10:26, Tomi Valkeinen wrote: How is it broken? I don't usually use the console (or fbdev) but enabling it now, it

Re: [PATCH v2 0/2] Fixes for omapdrm console

2024-02-26 Thread Tony Lindgren
* Tony Lindgren [240226 13:26]: > * Thomas Zimmermann [240226 09:10]: > > Am 26.02.24 um 10:01 schrieb Tomi Valkeinen: > > > On 26/02/2024 10:26, Tomi Valkeinen wrote: > > > > How is it broken? I don't usually use the console (or fbdev) but > > > > enabling it now, it seems to work fine for me,

Re: [PATCH v2 0/2] Fixes for omapdrm console

2024-02-26 Thread Tony Lindgren
* Thomas Zimmermann [240226 09:10]: > Hi > > Am 26.02.24 um 10:01 schrieb Tomi Valkeinen: > > On 26/02/2024 10:26, Tomi Valkeinen wrote: > > > Hi Tony, > > > > > > On 25/02/2024 08:46, Tony Lindgren wrote: > > > > Here are two fixes for omapdrm console. > > > > > > How is it broken? I don't

Re: [PATCH v2 0/2] Fixes for omapdrm console

2024-02-26 Thread Thomas Zimmermann
Hi Am 26.02.24 um 10:01 schrieb Tomi Valkeinen: On 26/02/2024 10:26, Tomi Valkeinen wrote: Hi Tony, On 25/02/2024 08:46, Tony Lindgren wrote: Here are two fixes for omapdrm console. How is it broken? I don't usually use the console (or fbdev) but enabling it now, it seems to work fine for

Re: [PATCH v2 0/2] Fixes for omapdrm console

2024-02-26 Thread Tomi Valkeinen
On 26/02/2024 10:26, Tomi Valkeinen wrote: Hi Tony, On 25/02/2024 08:46, Tony Lindgren wrote: Here are two fixes for omapdrm console. How is it broken? I don't usually use the console (or fbdev) but enabling it now, it seems to work fine for me, on DRA76 EVM with HDMI output. After

Re: [PATCH v2 0/2] Fixes for omapdrm console

2024-02-26 Thread Tomi Valkeinen
Hi Tony, On 25/02/2024 08:46, Tony Lindgren wrote: Here are two fixes for omapdrm console. How is it broken? I don't usually use the console (or fbdev) but enabling it now, it seems to work fine for me, on DRA76 EVM with HDMI output. Tomi Regards, Tony Changes since v1: - Add

Re: [PATCH v2 0/2] Fixes for omapdrm console

2024-02-26 Thread Thomas Zimmermann
Hi, looks good. For the series: Reviewed-by: Thomas Zimmermann Am 25.02.24 um 07:46 schrieb Tony Lindgren: Here are two fixes for omapdrm console. Regards, Tony Changes since v1: - Add FB_GEN_DEFAULT_DEFERRED_DMAMEM_OPS to use with FB_DEFAULT_DEFERRED_OPS as suggested by Thomas Tony

[PATCH v2 0/2] Fixes for omapdrm console

2024-02-24 Thread Tony Lindgren
Here are two fixes for omapdrm console. Regards, Tony Changes since v1: - Add FB_GEN_DEFAULT_DEFERRED_DMAMEM_OPS to use with FB_DEFAULT_DEFERRED_OPS as suggested by Thomas Tony Lindgren (2): drm/omapdrm: Fix console by implementing fb_dirty drm/omapdrm: Fix console with deferred ops