Re: [PATCH v2 4/8] drm/mipi-dsi: Introduce mipi_dsi_*_write_seq_multi()

2024-05-06 Thread Linus Walleij
On Mon, Apr 29, 2024 at 4:26 PM Doug Anderson wrote: > So I guess I'd say that I ended up being pretty happy with the > "context" even if it does feel a little over engineered and I'd argue > to keep it that way. That being said, if you feel strongly about it > then we can perhaps get others to

Re: [PATCH v2 4/8] drm/mipi-dsi: Introduce mipi_dsi_*_write_seq_multi()

2024-05-01 Thread Dmitry Baryshkov
On Wed, 1 May 2024 at 18:49, Doug Anderson wrote: > > Hi, > > On Mon, Apr 29, 2024 at 8:39 AM Jani Nikula > wrote: > > > > On Mon, 29 Apr 2024, Doug Anderson wrote: > > > Hi, > > > > > > On Mon, Apr 29, 2024 at 2:38 AM Neil Armstrong > > > wrote: > > >> > > >> > +/** > > >> > + * struct

Re: [PATCH v2 4/8] drm/mipi-dsi: Introduce mipi_dsi_*_write_seq_multi()

2024-05-01 Thread Doug Anderson
Hi, On Mon, Apr 29, 2024 at 8:39 AM Jani Nikula wrote: > > On Mon, 29 Apr 2024, Doug Anderson wrote: > > Hi, > > > > On Mon, Apr 29, 2024 at 2:38 AM Neil Armstrong > > wrote: > >> > >> > +/** > >> > + * struct mipi_dsi_multi_context - Context to call multiple MIPI DSI > >> > funcs in a row >

Re: [PATCH v2 4/8] drm/mipi-dsi: Introduce mipi_dsi_*_write_seq_multi()

2024-04-29 Thread Jani Nikula
On Mon, 29 Apr 2024, Doug Anderson wrote: > Hi, > > On Mon, Apr 29, 2024 at 2:38 AM Neil Armstrong > wrote: >> >> > +/** >> > + * struct mipi_dsi_multi_context - Context to call multiple MIPI DSI >> > funcs in a row >> > + * @dsi: Pointer to the MIPI DSI device >> > + * @accum_err: Storage for

Re: [PATCH v2 4/8] drm/mipi-dsi: Introduce mipi_dsi_*_write_seq_multi()

2024-04-29 Thread Doug Anderson
Hi, On Mon, Apr 29, 2024 at 2:38 AM Neil Armstrong wrote: > > > +/** > > + * struct mipi_dsi_multi_context - Context to call multiple MIPI DSI funcs > > in a row > > + * @dsi: Pointer to the MIPI DSI device > > + * @accum_err: Storage for the accumulated error over the multiple calls. > > Init

Re: [PATCH v2 4/8] drm/mipi-dsi: Introduce mipi_dsi_*_write_seq_multi()

2024-04-29 Thread Doug Anderson
Hi, On Fri, Apr 26, 2024 at 11:33 PM Sam Ravnborg wrote: > > > --- > > Right now this patch introduces two new functions in > > drm_mipi_dsi.c. Alternatively we could have changed the prototype of > > the "chatty" functions and made the deprecated macros adapt to the new > > prototype. While

Re: [PATCH v2 4/8] drm/mipi-dsi: Introduce mipi_dsi_*_write_seq_multi()

2024-04-29 Thread Neil Armstrong
Hello Mister Anderson, On 27/04/2024 01:58, Douglas Anderson wrote: The current mipi_dsi_*_write_seq() macros are non-intutitive because they contain a hidden "return" statement that will return out of the _caller_ of the macro. Let's mark them as deprecated and instead introduce some new

Re: [PATCH v2 4/8] drm/mipi-dsi: Introduce mipi_dsi_*_write_seq_multi()

2024-04-27 Thread Sam Ravnborg
Hi Douglas. On Fri, Apr 26, 2024 at 04:58:37PM -0700, Douglas Anderson wrote: > The current mipi_dsi_*_write_seq() macros are non-intutitive because > they contain a hidden "return" statement that will return out of the > _caller_ of the macro. Let's mark them as deprecated and instead >

[PATCH v2 4/8] drm/mipi-dsi: Introduce mipi_dsi_*_write_seq_multi()

2024-04-26 Thread Douglas Anderson
The current mipi_dsi_*_write_seq() macros are non-intutitive because they contain a hidden "return" statement that will return out of the _caller_ of the macro. Let's mark them as deprecated and instead introduce some new macros that are more intuitive. These new macros are less optimal when an