Re: [PATCH v4] drm/ioctl: Add a ioctl to label GEM objects

2019-10-22 Thread Daniel Stone
Hey, On Tue, 22 Oct 2019 at 11:30, Daniel Vetter wrote: > On Tue, Oct 22, 2019 at 10:58:02AM +0200, Rohan Garg wrote: > > This approach also future proof's us to be able to label any handles, not > > just > > GEM handle. > > I don't expect we'll ever merge any non-gem drivers in the future

Re: [PATCH v4] drm/ioctl: Add a ioctl to label GEM objects

2019-10-22 Thread Daniel Vetter
On Tue, Oct 22, 2019 at 10:58:02AM +0200, Rohan Garg wrote: > Hey Daniel > On lunes, 14 de octubre de 2019 10:59:38 (CEST) Daniel Vetter wrote: > > On Fri, Oct 11, 2019 at 04:30:09PM +0200, Rohan Garg wrote: > > > DRM_IOCTL_DUMB_SET_LABEL lets you label GEM objects, making it > > > easier to debug

Re: [PATCH v4] drm/ioctl: Add a ioctl to label GEM objects

2019-10-22 Thread Rohan Garg
Hey On viernes, 11 de octubre de 2019 19:09:52 (CEST) Daniel Stone wrote: > Hi Rohan, > > On Fri, 11 Oct 2019 at 15:30, Rohan Garg wrote: > > DRM_IOCTL_DUMB_SET_LABEL lets you label GEM objects, making it > > easier to debug issues in userspace applications. > > I'm not sure if this was pointed

Re: [PATCH v4] drm/ioctl: Add a ioctl to label GEM objects

2019-10-22 Thread Rohan Garg
Hi Thomas On viernes, 11 de octubre de 2019 19:55:36 (CEST) Thomas Zimmermann wrote: > Hi > > Am 11.10.19 um 19:09 schrieb Daniel Stone: > > Hi Rohan, > > > > On Fri, 11 Oct 2019 at 15:30, Rohan Garg wrote: > >> DRM_IOCTL_DUMB_SET_LABEL lets you label GEM objects, making it > >> easier to debug

Re: [PATCH v4] drm/ioctl: Add a ioctl to label GEM objects

2019-10-22 Thread Rohan Garg
Hey Daniel On lunes, 14 de octubre de 2019 10:59:38 (CEST) Daniel Vetter wrote: > On Fri, Oct 11, 2019 at 04:30:09PM +0200, Rohan Garg wrote: > > DRM_IOCTL_DUMB_SET_LABEL lets you label GEM objects, making it > > easier to debug issues in userspace applications. > > > > Changes in v2: > > -

Re: [PATCH v4] drm/ioctl: Add a ioctl to label GEM objects

2019-10-14 Thread Daniel Vetter
On Fri, Oct 11, 2019 at 04:30:09PM +0200, Rohan Garg wrote: > DRM_IOCTL_DUMB_SET_LABEL lets you label GEM objects, making it > easier to debug issues in userspace applications. > > Changes in v2: > - Hoist the IOCTL up into the drm_driver framework > > Changes in v3: > - Introduce a

Re: [PATCH v4] drm/ioctl: Add a ioctl to label GEM objects

2019-10-14 Thread Daniel Vetter
On Fri, Oct 11, 2019 at 07:55:36PM +0200, Thomas Zimmermann wrote: > Hi > > Am 11.10.19 um 19:09 schrieb Daniel Stone: > > Hi Rohan, > > > > On Fri, 11 Oct 2019 at 15:30, Rohan Garg wrote: > > > DRM_IOCTL_DUMB_SET_LABEL lets you label GEM objects, making it > > > easier to debug issues in

Re: [PATCH v4] drm/ioctl: Add a ioctl to label GEM objects

2019-10-12 Thread Dan Carpenter
Hi Rohan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [cannot apply to v5.4-rc2 next-20191011] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to

Re: [PATCH v4] drm/ioctl: Add a ioctl to label GEM objects

2019-10-11 Thread Thomas Zimmermann
Hi Am 11.10.19 um 19:09 schrieb Daniel Stone: Hi Rohan, On Fri, 11 Oct 2019 at 15:30, Rohan Garg wrote: DRM_IOCTL_DUMB_SET_LABEL lets you label GEM objects, making it easier to debug issues in userspace applications. I'm not sure if this was pointed out already, but dumb buffers != GEM

Re: [PATCH v4] drm/ioctl: Add a ioctl to label GEM objects

2019-10-11 Thread Boris Brezillon
Hello Rohan, On Fri, 11 Oct 2019 16:30:09 +0200 Rohan Garg wrote: > DRM_IOCTL_DUMB_SET_LABEL lets you label GEM objects, making it > easier to debug issues in userspace applications. > > Changes in v2: > - Hoist the IOCTL up into the drm_driver framework > > Changes in v3: > - Introduce a

Re: [PATCH v4] drm/ioctl: Add a ioctl to label GEM objects

2019-10-11 Thread Daniel Stone
Hi Rohan, On Fri, 11 Oct 2019 at 15:30, Rohan Garg wrote: > DRM_IOCTL_DUMB_SET_LABEL lets you label GEM objects, making it > easier to debug issues in userspace applications. I'm not sure if this was pointed out already, but dumb buffers != GEM buffers. GEM buffers _can_ be dumb, but might not

[PATCH v4] drm/ioctl: Add a ioctl to label GEM objects

2019-10-11 Thread Rohan Garg
DRM_IOCTL_DUMB_SET_LABEL lets you label GEM objects, making it easier to debug issues in userspace applications. Changes in v2: - Hoist the IOCTL up into the drm_driver framework Changes in v3: - Introduce a drm_gem_set_label for drivers to use internally in order to label a GEM object