Re: [PATCH v4 2/7] drm/panel: himax-hx83102: Break out as separate driver

2024-05-08 Thread Doug Anderson
Hi, On Wed, May 8, 2024 at 4:52 AM cong yang wrote: > > > > +static int starry_himax83102_j02_init(struct hx83102 *ctx) > > > +{ > > > + struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi }; > > > + > > > + hx83102_enable_extended_cmds(ctx, true); > > > +

Re: [PATCH v4 2/7] drm/panel: himax-hx83102: Break out as separate driver

2024-05-08 Thread cong yang
Hi, Doug Anderson 于2024年5月8日周三 07:35写道: > > Hi, > > On Tue, May 7, 2024 at 6:53 AM Cong Yang > wrote: > > > > +static int hx83102_enable_extended_cmds(struct hx83102 *ctx, bool enable) > > +{ > > + struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi }; > > + > > + if (enable)

Re: [PATCH v4 2/7] drm/panel: himax-hx83102: Break out as separate driver

2024-05-07 Thread Doug Anderson
Hi, On Tue, May 7, 2024 at 6:53 AM Cong Yang wrote: > > +static int hx83102_enable_extended_cmds(struct hx83102 *ctx, bool enable) > +{ > + struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi }; > + > + if (enable) > + mipi_dsi_dcs_write_seq_multi(_ctx,

[PATCH v4 2/7] drm/panel: himax-hx83102: Break out as separate driver

2024-05-07 Thread Cong Yang
The Starry HX83102 based mipi panel should never have been part of the boe tv101wum driver. Discussion with Doug and Linus in V1 [1], we need a separate driver to enable the hx83102 controller. In hx83102 driver, add DSI commands as macros. So it can add some panels with same control model in the