Re: [PATCH] drm/scheduler: Fix UAF in drm_sched_fence_get_timeline_name

2023-04-06 Thread Asahi Lina
On 06/04/2023 18.48, Daniel Vetter wrote: On Thu, Apr 06, 2023 at 06:27:27PM +0900, Asahi Lina wrote: On 06/04/2023 18.15, Asahi Lina wrote: On 06/04/2023 18.06, Christian König wrote: Am 06.04.23 um 10:49 schrieb Asahi Lina: On 06/04/2023 17.29, Christian König wrote: Am 05.04.23 um 18:34

Re: [PATCH] drm/scheduler: Fix UAF in drm_sched_fence_get_timeline_name

2023-04-06 Thread Daniel Vetter
On Thu, Apr 06, 2023 at 06:27:27PM +0900, Asahi Lina wrote: > On 06/04/2023 18.15, Asahi Lina wrote: > > On 06/04/2023 18.06, Christian König wrote: > > > Am 06.04.23 um 10:49 schrieb Asahi Lina: > > > > On 06/04/2023 17.29, Christian König wrote: > > > > > Am 05.04.23 um 18:34 schrieb Asahi Lina:

Re: [PATCH] drm/scheduler: Fix UAF in drm_sched_fence_get_timeline_name

2023-04-06 Thread Asahi Lina
On 06/04/2023 18.15, Asahi Lina wrote: On 06/04/2023 18.06, Christian König wrote: Am 06.04.23 um 10:49 schrieb Asahi Lina: On 06/04/2023 17.29, Christian König wrote: Am 05.04.23 um 18:34 schrieb Asahi Lina: A signaled scheduler fence can outlive its scheduler, since fences are

Re: [PATCH] drm/scheduler: Fix UAF in drm_sched_fence_get_timeline_name

2023-04-06 Thread Asahi Lina
On 06/04/2023 18.06, Christian König wrote: Am 06.04.23 um 10:49 schrieb Asahi Lina: On 06/04/2023 17.29, Christian König wrote: Am 05.04.23 um 18:34 schrieb Asahi Lina: A signaled scheduler fence can outlive its scheduler, since fences are independently reference counted. Well that is

Re: [PATCH] drm/scheduler: Fix UAF in drm_sched_fence_get_timeline_name

2023-04-06 Thread Christian König
Am 06.04.23 um 10:49 schrieb Asahi Lina: On 06/04/2023 17.29, Christian König wrote: Am 05.04.23 um 18:34 schrieb Asahi Lina: A signaled scheduler fence can outlive its scheduler, since fences are independently reference counted. Well that is actually not correct. Schedulers are supposed to

Re: [PATCH] drm/scheduler: Fix UAF in drm_sched_fence_get_timeline_name

2023-04-06 Thread Asahi Lina
On 06/04/2023 17.29, Christian König wrote: Am 05.04.23 um 18:34 schrieb Asahi Lina: A signaled scheduler fence can outlive its scheduler, since fences are independently reference counted. Well that is actually not correct. Schedulers are supposed to stay around until the hw they have been

Re: [PATCH] drm/scheduler: Fix UAF in drm_sched_fence_get_timeline_name

2023-04-06 Thread Daniel Vetter
On Thu, Apr 06, 2023 at 10:29:57AM +0200, Christian König wrote: > Am 05.04.23 um 18:34 schrieb Asahi Lina: > > A signaled scheduler fence can outlive its scheduler, since fences are > > independently reference counted. > > Well that is actually not correct. Schedulers are supposed to stay around

Re: [PATCH] drm/scheduler: Fix UAF in drm_sched_fence_get_timeline_name

2023-04-06 Thread Christian König
Am 05.04.23 um 18:34 schrieb Asahi Lina: A signaled scheduler fence can outlive its scheduler, since fences are independently reference counted. Well that is actually not correct. Schedulers are supposed to stay around until the hw they have been driving is no longer present. E.g. the

Re: [PATCH] drm/scheduler: Fix UAF in drm_sched_fence_get_timeline_name

2023-04-05 Thread Luben Tuikov
On 2023-04-05 12:34, Asahi Lina wrote: > A signaled scheduler fence can outlive its scheduler, since fences are > independently reference counted. Therefore, we can't reference the > scheduler in the get_timeline_name() implementation. > > Fixes oopses on `cat /sys/kernel/debug/dma_buf/bufinfo`