Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-04-05 Thread Daniel Vetter
On Wed, Apr 05, 2023 at 04:14:11PM +0200, Christian König wrote: > Am 05.04.23 um 15:40 schrieb Daniel Vetter: > > On Tue, Mar 07, 2023 at 11:25:35PM +0900, Asahi Lina wrote: > > > Some hardware may require more complex resource utilization accounting > > > than the simple job count supported by

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-04-05 Thread Christian König
Am 05.04.23 um 15:40 schrieb Daniel Vetter: On Tue, Mar 07, 2023 at 11:25:35PM +0900, Asahi Lina wrote: Some hardware may require more complex resource utilization accounting than the simple job count supported by drm_sched internally. Add a can_run_job callback to allow drivers to implement

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-04-05 Thread Daniel Vetter
On Tue, Mar 07, 2023 at 11:25:35PM +0900, Asahi Lina wrote: > Some hardware may require more complex resource utilization accounting > than the simple job count supported by drm_sched internally. Add a > can_run_job callback to allow drivers to implement more logic before > deciding whether to run

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-03-16 Thread Daniel Vetter
On Wed, Mar 08, 2023 at 04:19:17PM +0100, Karol Herbst wrote: > On Wed, Mar 8, 2023 at 4:09 PM Christian König > wrote: > > > > Am 08.03.23 um 15:43 schrieb Karol Herbst: > > > [SNIP] > > > "further"? There was no discussion at all, > > > > Yeah, well that is exactly what I wanted to archive. >

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-03-10 Thread Asahi Lina
On 10/03/2023 03.50, Faith Ekstrand wrote: > Jumping in here quick... (Sorry, I was out yesterday and was ignoring > my e-mail on Tuesday so I could finally type some compiler code.) > > On Thu, 2023-03-09 at 18:14 +0900, Asahi Lina wrote: >> On 09/03/2023 17.05, Christian König wrote: >>> Am

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-03-09 Thread Faith Ekstrand
Jumping in here quick... (Sorry, I was out yesterday and was ignoring my e-mail on Tuesday so I could finally type some compiler code.) On Thu, 2023-03-09 at 18:14 +0900, Asahi Lina wrote: > On 09/03/2023 17.05, Christian König wrote: > > Am 09.03.23 um 07:30 schrieb Asahi Lina: > > > On

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-03-09 Thread Asahi Lina
On 09/03/2023 17.05, Christian König wrote: > Am 09.03.23 um 07:30 schrieb Asahi Lina: >> On 09/03/2023 05.14, Christian König wrote: I think you mean wake_up_interruptible(). That would be drm_sched_job_done(), on the fence callback when a job completes, which as I keep saying is

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-03-09 Thread Christian König
Am 09.03.23 um 07:30 schrieb Asahi Lina: On 09/03/2023 05.14, Christian König wrote: I think you mean wake_up_interruptible(). That would be drm_sched_job_done(), on the fence callback when a job completes, which as I keep saying is the same logic used for hw_rq_count/hw_submission_limit

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-03-08 Thread Asahi Lina
On 09/03/2023 05.14, Christian König wrote: >> I think you mean wake_up_interruptible(). That would be >> drm_sched_job_done(), on the fence callback when a job completes, which >> as I keep saying is the same logic used for >> hw_rq_count/hw_submission_limit tracking. > > As the documentation to

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-03-08 Thread Christian König
Am 08.03.23 um 20:45 schrieb Asahi Lina: On 09/03/2023 04.12, Christian König wrote: Am 08.03.23 um 20:05 schrieb Asahi Lina: [SNIP] Well it's not the better way, it's the only way that works. I have to admit that my bet on your intentions was wrong, but even that use case doesn't work

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-03-08 Thread Asahi Lina
On 09/03/2023 04.12, Christian König wrote: > Am 08.03.23 um 20:05 schrieb Asahi Lina: >> [SNIP] >>> Well it's not the better way, it's the only way that works. >>> >>> I have to admit that my bet on your intentions was wrong, but even that >>> use case doesn't work correctly. >>> >>> See when

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-03-08 Thread Christian König
Am 08.03.23 um 20:05 schrieb Asahi Lina: [SNIP] Well it's not the better way, it's the only way that works. I have to admit that my bet on your intentions was wrong, but even that use case doesn't work correctly. See when your callback returns false it is perfectly possible that all hw fences

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-03-08 Thread Asahi Lina
On 09/03/2023 02.57, Christian König wrote: > Am 08.03.23 um 17:44 schrieb Asahi Lina: >> On 09/03/2023 00.30, Christian König wrote: >>> Am 08.03.23 um 15:53 schrieb Asahi Lina: [SNIP] > The background is that core memory management requires that signaling a > fence only depends on

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-03-08 Thread Christian König
Am 08.03.23 um 17:44 schrieb Asahi Lina: On 09/03/2023 00.30, Christian König wrote: Am 08.03.23 um 15:53 schrieb Asahi Lina: [SNIP] The background is that core memory management requires that signaling a fence only depends on signaling other fences and hardware progress and nothing else.

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-03-08 Thread Asahi Lina
On 09/03/2023 00.30, Christian König wrote: > Am 08.03.23 um 15:53 schrieb Asahi Lina: >> [SNIP] >>> The background is that core memory management requires that signaling a >>> fence only depends on signaling other fences and hardware progress and >>> nothing else. Otherwise you immediately run

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-03-08 Thread Christian König
Am 08.03.23 um 15:53 schrieb Asahi Lina: [SNIP] The background is that core memory management requires that signaling a fence only depends on signaling other fences and hardware progress and nothing else. Otherwise you immediately run into problems because of circle dependencies or what we call

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-03-08 Thread Karol Herbst
On Wed, Mar 8, 2023 at 4:09 PM Christian König wrote: > > Am 08.03.23 um 15:43 schrieb Karol Herbst: > > [SNIP] > > "further"? There was no discussion at all, > > Yeah, well that is exactly what I wanted to archive. > > > you just started off like > > that. If you think somebody misses that

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-03-08 Thread Christian König
Am 08.03.23 um 15:43 schrieb Karol Herbst: [SNIP] "further"? There was no discussion at all, Yeah, well that is exactly what I wanted to archive. you just started off like that. If you think somebody misses that connection, you can point out to documentation/videos whatever so the

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-03-08 Thread Asahi Lina
On 08/03/2023 19.00, Christian König wrote: > Am 08.03.23 um 10:41 schrieb Asahi Lina: >> On 08/03/2023 17.46, Christian König wrote: >>> Am 07.03.23 um 15:25 schrieb Asahi Lina: Some hardware may require more complex resource utilization accounting than the simple job count supported by

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-03-08 Thread Karol Herbst
On Wed, Mar 8, 2023 at 2:47 PM Christian König wrote: > > Am 08.03.23 um 13:39 schrieb Karol Herbst: > > On Wed, Mar 8, 2023 at 9:46 AM Christian König > > wrote: > >> Am 07.03.23 um 15:25 schrieb Asahi Lina: > >>> Some hardware may require more complex resource utilization accounting > >>>

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-03-08 Thread Christian König
Am 08.03.23 um 13:39 schrieb Karol Herbst: On Wed, Mar 8, 2023 at 9:46 AM Christian König wrote: Am 07.03.23 um 15:25 schrieb Asahi Lina: Some hardware may require more complex resource utilization accounting than the simple job count supported by drm_sched internally. Add a can_run_job

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-03-08 Thread Karol Herbst
On Wed, Mar 8, 2023 at 9:46 AM Christian König wrote: > > Am 07.03.23 um 15:25 schrieb Asahi Lina: > > Some hardware may require more complex resource utilization accounting > > than the simple job count supported by drm_sched internally. Add a > > can_run_job callback to allow drivers to

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-03-08 Thread Christian König
Am 08.03.23 um 10:41 schrieb Asahi Lina: On 08/03/2023 17.46, Christian König wrote: Am 07.03.23 um 15:25 schrieb Asahi Lina: Some hardware may require more complex resource utilization accounting than the simple job count supported by drm_sched internally. Add a can_run_job callback to allow

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-03-08 Thread Asahi Lina
On 08/03/2023 17.46, Christian König wrote: > Am 07.03.23 um 15:25 schrieb Asahi Lina: >> Some hardware may require more complex resource utilization accounting >> than the simple job count supported by drm_sched internally. Add a >> can_run_job callback to allow drivers to implement more logic

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-03-08 Thread Christian König
Am 07.03.23 um 15:25 schrieb Asahi Lina: Some hardware may require more complex resource utilization accounting than the simple job count supported by drm_sched internally. Add a can_run_job callback to allow drivers to implement more logic before deciding whether to run a GPU job. Well