Re: drivers/gpu/drm/bridge/fsl-ldb.c:101: possible loss of information.

2023-03-09 Thread Laurent Pinchart
se ; > jernej.skra...@gmail.com ; airl...@gmail.com > ; dan...@ffwll.ch ; > dri-devel@lists.freedesktop.org ; > linux-ker...@vger.kernel.org > Subject: Re: drivers/gpu/drm/bridge/fsl-ldb.c:101: possible loss of > information. >   > Hi David, > > On Thu, Mar 09, 202

Re: drivers/gpu/drm/bridge/fsl-ldb.c:101: possible loss of information.

2023-03-09 Thread David Binderman
com ; neil.armstr...@linaro.org ; rf...@kernel.org ; jo...@kwiboo.se ; jernej.skra...@gmail.com ; airl...@gmail.com ; dan...@ffwll.ch ; dri-devel@lists.freedesktop.org ; linux-ker...@vger.kernel.org Subject: Re: drivers/gpu/drm/bridge/fsl-ldb.c:101: possible loss of information.   Hi David, On

Re: drivers/gpu/drm/bridge/fsl-ldb.c:101: possible loss of information.

2023-03-09 Thread Laurent Pinchart
Hi David, On Thu, Mar 09, 2023 at 07:59:34AM +, David Binderman wrote: > Hello there Laurent, > > >We could, but I don't think it will make any difference in practice as > >the maximum pixel clock frequency supported by the SoC is 80MHz (per > >LVDS channel). That would result in a 560MHz

Re: drivers/gpu/drm/bridge/fsl-ldb.c:101: possible loss of information.

2023-03-08 Thread David Binderman
Hello there Laurent, >We could, but I don't think it will make any difference in practice as >the maximum pixel clock frequency supported by the SoC is 80MHz (per >LVDS channel). That would result in a 560MHz frequency returned by this >function, well below the 31 bits limit. Thanks for your

Re: drivers/gpu/drm/bridge/fsl-ldb.c:101: possible loss of information.

2023-03-08 Thread Laurent Pinchart
On Tue, Mar 07, 2023 at 04:45:24PM +, David Binderman wrote: > Hello there, > > I just ran the static analyser "cppcheck" over the source code of > linux-6.2-rc1. It said: > > linux-6.3-rc1/drivers/gpu/drm/bridge/fsl-ldb.c:101:3: style: int > result is returned as long value. If the return

drivers/gpu/drm/bridge/fsl-ldb.c:101: possible loss of information.

2023-03-07 Thread David Binderman
Hello there, I just ran the static analyser "cppcheck" over the source code of linux-6.2-rc1. It said: linux-6.3-rc1/drivers/gpu/drm/bridge/fsl-ldb.c:101:3: style: int result is returned as long value. If the return value is long to avoid loss of information, then you have loss of