Re: [PATCH v4 01/17] drm/connector: Convert DRM_MODE_COLORIMETRY to enum

2023-03-08 Thread Pekka Paalanen
On Tue, 7 Mar 2023 10:29:34 -0500 Harry Wentland wrote: > This allows us to use strongly typed arguments. > > v2: > - Bring NO_DATA back > - Provide explicit enum values > > v4: Drop unnecessary '&' from kerneldoc (emersion) > > Signed-off-by: Harry Wentland > Reviewed-by: Simon Ser > >

Re: [PATCH v3 14/17] drm/amd/display: Add debugfs for testing output colorspace

2023-03-08 Thread Pekka Paalanen
On Tue, 7 Mar 2023 10:11:04 -0500 Harry Wentland wrote: > In order to IGT test colorspace we'll want to print > the currently enabled colorspace on a stream. We add > a new debugfs to do so, using the same scheme as > current bpc reporting. > > This might also come in handy when debugging

[PATCH v4 2/5] drm/i915/gt: Add intel_context_timeline_is_locked helper

2023-03-08 Thread Andi Shyti
We have: - intel_context_timeline_lock() - intel_context_timeline_unlock() In the next patches we will also need: - intel_context_timeline_is_locked() Add it. Signed-off-by: Andi Shyti Cc: sta...@vger.kernel.org --- drivers/gpu/drm/i915/gt/intel_context.h | 6 ++ 1 file changed, 6

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-03-08 Thread Asahi Lina
On 08/03/2023 17.46, Christian König wrote: > Am 07.03.23 um 15:25 schrieb Asahi Lina: >> Some hardware may require more complex resource utilization accounting >> than the simple job count supported by drm_sched internally. Add a >> can_run_job callback to allow drivers to implement more logic

[PATCH v4 3/5] drm/i915: Create the locked version of the request create

2023-03-08 Thread Andi Shyti
Make version of the request creation that doesn't hold any lock. Signed-off-by: Andi Shyti Cc: sta...@vger.kernel.org --- drivers/gpu/drm/i915/i915_request.c | 43 +++-- drivers/gpu/drm/i915/i915_request.h | 2 ++ 2 files changed, 31 insertions(+), 14 deletions(-) diff

[PATCH v4 5/5] drm/i915/gt: Make sure that errors are propagated through request chains

2023-03-08 Thread Andi Shyti
Currently, when we perform operations such as clearing or copying large blocks of memory, we generate multiple requests that are executed in a chain. However, if one of these requests fails, we may not realize it unless it happens to be the last request in the chain. This is because errors are

[PATCH v4 0/5] Fix error propagation amongst request

2023-03-08 Thread Andi Shyti
Hi, This series of two patches fixes the issue introduced in cf586021642d80 ("drm/i915/gt: Pipelined page migration") where, as reported by Matt, in a chain of requests an error is reported only if happens in the last request. However Chris noticed that without ensuring exclusivity in the

[PATCH v4 1/5] drm/i915: Throttle for ringspace prior to taking the timeline mutex

2023-03-08 Thread Andi Shyti
From: Chris Wilson Before taking exclusive ownership of the ring for emitting the request, wait for space in the ring to become available. This allows others to take the timeline->mutex to make forward progresses while userspace is blocked. In particular, this allows regular clients to issue

[PATCH v4 4/5] drm/i915: Create the locked version of the request add

2023-03-08 Thread Andi Shyti
i915_request_add() assumes that the timeline is locked whtn the function is called. Before exiting it releases the lock. But in the next commit we have one case where releasing the timeline mutex is not necessary and we don't want that. Make a new i915_request_add_locked() version of the function

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-03-08 Thread Christian König
Am 08.03.23 um 10:41 schrieb Asahi Lina: On 08/03/2023 17.46, Christian König wrote: Am 07.03.23 um 15:25 schrieb Asahi Lina: Some hardware may require more complex resource utilization accounting than the simple job count supported by drm_sched internally. Add a can_run_job callback to allow

Re: [PATCH] fbdev: Fix incorrect page mapping clearance at fb_deferred_io_release()

2023-03-08 Thread Takashi Iwai
On Wed, 08 Mar 2023 10:08:24 +0100, Patrik Jakobsson wrote: > > On Wed, Mar 8, 2023 at 7:36 AM Takashi Iwai wrote: > > > > The recent fix for the deferred I/O by the commit > > 3efc61d95259 ("fbdev: Fix invalid page access after closing deferred I/O > > devices") > > caused a regression when

Re: [PATCH v3 05/17] drm/connector: Use common colorspace_names array

2023-03-08 Thread Pekka Paalanen
On Tue, 7 Mar 2023 10:10:55 -0500 Harry Wentland wrote: > We an use bitfields to track the support ones for HDMI > and DP. This allows us to print colorspaces in a consistent > manner without needing to know whether we're dealing with > DP or HDMI. > > Signed-off-by: Harry Wentland > Cc: Pekka

Re: [PATCH v2 1/2] dt-bindings: display/panel: Add Lenovo NT36523W BOE panel

2023-03-08 Thread Konrad Dybcio
On 7.03.2023 23:08, Linus Walleij wrote: > On Tue, Mar 7, 2023 at 2:26 PM Konrad Dybcio wrote: > >> Add bindings for the 2000x1200px IPS panel found on Lenovo Tab P11/ >> XiaoXin Pad devices. >> >> Reviewed-by: Rob Herring >> Signed-off-by: Konrad Dybcio > > (...) >> +$id: >>

[6.3][regression] commit a4e771729a51168bc36317effaa9962e336d4f5e lead to flood kernel logs with warning messages "at kernel/workqueue.c:3167 __flush_work+0x472/0x500"

2023-03-08 Thread Mikhail Gavrilov
Hi, I didn't faced to issue drm_bridge_hpd_enable+0x94/0x9c [drm] but fixing this issue leads to warning messages on my laptop ASUS ROG Strix G15 Advantage Edition G513QY-HQ007 which has two AMD GPU. Discrete Radeon 6800M and integrated in CPU Cezanne Vega 8. I found bad commit by bisecting: ❯

Re: [PATCH v3 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-08 Thread Konrad Dybcio
On 8.03.2023 12:53, Jianhua Lu wrote: > On Wed, Mar 08, 2023 at 12:13:53PM +0100, Konrad Dybcio wrote: >> >> >> On 8.03.2023 05:37, Jianhua Lu wrote: >>> Add a driver for panels using the Novatek NT36523 display driver IC. >>> >>> Signed-off-by: Jianhua Lu >>> --- >>> Changes in v3: >>> -

Re: [PATCH v2 06/10] drm/display/dsc: split DSC 1.2 and DSC 1.1 (pre-SCR) parameters

2023-03-08 Thread Dmitry Baryshkov
On Wed, 8 Mar 2023 at 12:14, Jani Nikula wrote: > > On Tue, 07 Mar 2023, Dmitry Baryshkov wrote: > > The array of rc_parameters contains a mixture of parameters from DSC 1.1 > > and DSC 1.2 standards. Split these tow configuration arrays in > > preparation to adding more configuration data. > >

[PATCH v4 1/4] video: fbdev: atyfb: only use ioremap_uc() on i386 and ia64

2023-03-08 Thread Baoquan He
From: Arnd Bergmann ioremap_uc() is only meaningful on old x86-32 systems with the PAT extension, and on ia64 with its slightly unconventional ioremap() behavior, everywhere else this is the same as ioremap() anyway. Change the only driver that still references ioremap_uc() to only do so on

Re: [PATCH v2 3/7] drm/ttm: Use the BIT macro for the TTM_TT_FLAGs

2023-03-08 Thread Christian König
Am 07.03.23 um 15:46 schrieb Thomas Hellström: New code is recommended to use the BIT macro instead of the explicit shifts. Change the older defines so that we can keep the style consistent with upcoming changes. v2: - Also change the value of the _PRIV_POPULATED bit (Christian König)

Re: [PATCH v2 4/7] drm/ttm: Unexport ttm_global_swapout()

2023-03-08 Thread Christian König
Am 07.03.23 um 15:46 schrieb Thomas Hellström: Unexport ttm_global_swapout() since it is not used outside of TTM. Signed-off-by: Thomas Hellström Reviewed-by: Christian König --- drivers/gpu/drm/ttm/ttm_device.c | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [PATCH] fbdev: Fix incorrect page mapping clearance at fb_deferred_io_release()

2023-03-08 Thread Patrik Jakobsson
On Wed, Mar 8, 2023 at 7:36 AM Takashi Iwai wrote: > > The recent fix for the deferred I/O by the commit > 3efc61d95259 ("fbdev: Fix invalid page access after closing deferred I/O > devices") > caused a regression when the same fb device is opened/closed while > it's being used. It resulted

Re: [PATCH v2 06/10] drm/display/dsc: split DSC 1.2 and DSC 1.1 (pre-SCR) parameters

2023-03-08 Thread Jani Nikula
On Tue, 07 Mar 2023, Dmitry Baryshkov wrote: > The array of rc_parameters contains a mixture of parameters from DSC 1.1 > and DSC 1.2 standards. Split these tow configuration arrays in > preparation to adding more configuration data. > > Signed-off-by: Dmitry Baryshkov > --- >

Re: [PATCH v13 05/10] drm/bridge: anx7625: Check for Type-C during panel registration

2023-03-08 Thread Pin-yen Lin
HI Andy, On Mon, Mar 6, 2023 at 7:52 PM Andy Shevchenko wrote: > > On Fri, Mar 03, 2023 at 10:33:45PM +0800, Pin-yen Lin wrote: > > The output port endpoints can be connected to USB-C connectors. > > Running drm_of_find_panel_or_bridge() with such endpoints leads to > > a continuous return value

Re: [PATCH 2/2] drm/i915/pmu: Use correct requested freq for SLPC

2023-03-08 Thread Tvrtko Ursulin
On 08/03/2023 05:36, Dixit, Ashutosh wrote: On Mon, 06 Mar 2023 03:10:24 -0800, Tvrtko Ursulin wrote: Hi Tvrtko, On 04/03/2023 01:27, Ashutosh Dixit wrote: SLPC does not use 'struct intel_rps'. Use UNSLICE_RATIO bits from Would it be more accurate to say 'SLPC does not use

Re: [PATCH v3 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-08 Thread Konrad Dybcio
On 8.03.2023 05:37, Jianhua Lu wrote: > Add a driver for panels using the Novatek NT36523 display driver IC. > > Signed-off-by: Jianhua Lu > --- > Changes in v3: > - Refactor source code > > Changes in v2: > - Refactor and clean up source code This is a veeery vague changelog, akin to

Re: [PATCH] habanalabs: Drop redundant pci_enable_pcie_error_reporting()

2023-03-08 Thread Oded Gabbay
On Tue, Mar 7, 2023 at 10:27 PM Bjorn Helgaas wrote: > > From: Bjorn Helgaas > > pci_enable_pcie_error_reporting() enables the device to send ERR_* > Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is > native"), the PCI core does this for all devices during enumeration,

Re: [PATCH v2 06/10] drm/display/dsc: split DSC 1.2 and DSC 1.1 (pre-SCR) parameters

2023-03-08 Thread Jani Nikula
On Wed, 08 Mar 2023, Dmitry Baryshkov wrote: > On Wed, 8 Mar 2023 at 12:14, Jani Nikula wrote: >> >> On Tue, 07 Mar 2023, Dmitry Baryshkov wrote: >> > The array of rc_parameters contains a mixture of parameters from DSC 1.1 >> > and DSC 1.2 standards. Split these tow configuration arrays in >>

RE: [PATCH 02/13] backlight: adp5520_bl: Convert to platform remove callback returning void

2023-03-08 Thread Hennerich, Michael
> -Original Message- > From: Uwe Kleine-König > Sent: Mittwoch, 8. März 2023 08:40 > To: Hennerich, Michael ; Lee Jones > ; Daniel Thompson ; Jingoo > Han ; Helge Deller > Cc: dri-devel@lists.freedesktop.org; linux-fb...@vger.kernel.org; > ker...@pengutronix.de > Subject: [PATCH 02/13]

Re: [PATCH v2 5/7] drm/ttm: Don't print error message if eviction was interrupted

2023-03-08 Thread Christian König
Am 07.03.23 um 15:46 schrieb Thomas Hellström: Avoid printing an error message if eviction was interrupted by, for example, the user pressing CTRL-C. That may happen if eviction is waiting for something, like for example a free batch-buffer. Signed-off-by: Thomas Hellström Reviewed-by:

Re: [PATCH v3 09/17] drm/amd/display: Register Colorspace property for DP and HDMI

2023-03-08 Thread Pekka Paalanen
On Tue, 7 Mar 2023 10:10:59 -0500 Harry Wentland wrote: > We want compositors to be able to set the output > colorspace on DP and HDMI outputs, based on the > caps reported from the receiver via EDID. > > Signed-off-by: Harry Wentland > Cc: Pekka Paalanen > Cc: Sebastian Wick > Cc:

Re: [PATCH] drm/msm: Initialize mode_config earlier

2023-03-08 Thread Johan Hovold
On Thu, Mar 02, 2023 at 03:17:04PM -0800, Bjorn Andersson wrote: > On Wed, Mar 01, 2023 at 02:58:50PM +0100, Johan Hovold wrote: > > So after debugging this issue a third time, I can conclude that it is > > still very much present in 6.2. > > > > It appears you looked at the linux-next tree when

Re: [PATCH v6 1/4] drm/rockchip: vop: limit maximium resolution to hardware capabilities

2023-03-08 Thread Sascha Hauer
On Tue, Mar 07, 2023 at 11:21:16PM +0100, Heiko Stübner wrote: > Hi Sascha, > > Am Donnerstag, 16. Februar 2023, 11:24:44 CET schrieb Sascha Hauer: > > The different VOP variants support different maximum resolutions. Reject > > resolutions that are not supported by a specific variant. > > > >

Re: [PATCH 1/2] drm/i915/pmu: Use only freq bits for falling back to requested freq

2023-03-08 Thread Tvrtko Ursulin
On 08/03/2023 05:36, Dixit, Ashutosh wrote: On Mon, 06 Mar 2023 03:04:40 -0800, Tvrtko Ursulin wrote: Hi Tvrtko, On 04/03/2023 01:27, Ashutosh Dixit wrote: On newer generations, the GEN12_RPSTAT1 register contains more than freq information, e.g. see GEN12_VOLTAGE_MASK. Therefore use

RE: [PATCH 3/7] drm/i915: Adding the new registers for DSC

2023-03-08 Thread Shankar, Uma
> -Original Message- > From: Kandpal, Suraj > Sent: Wednesday, February 22, 2023 11:02 AM > To: dri-devel@lists.freedesktop.org; intel-...@lists.freedesktop.org > Cc: Shankar, Uma ; Nautiyal, Ankit K > ; Kandpal, Suraj ; > Kulkarni, > Vandita > Subject: [PATCH 3/7] drm/i915: Adding

RE: [PATCH v2 5/7] drm/i915/display: Fill in native_420 field

2023-03-08 Thread Shankar, Uma
> -Original Message- > From: Kandpal, Suraj > Sent: Friday, March 3, 2023 11:05 AM > To: dri-devel@lists.freedesktop.org; intel-...@lists.freedesktop.org > Cc: Shankar, Uma ; Nautiyal, Ankit K > ; Kandpal, Suraj ; Jani > Nikula > > Subject: [PATCH v2 5/7] drm/i915/display: Fill in

RE: [Intel-gfx] [PATCH 3/7] drm/i915: Adding the new registers for DSC

2023-03-08 Thread Shankar, Uma
> -Original Message- > From: Jani Nikula > Sent: Wednesday, March 8, 2023 4:57 PM > To: Shankar, Uma ; Kandpal, Suraj > ; dri-devel@lists.freedesktop.org; intel- > g...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 3/7] drm/i915: Adding the new registers for > DSC > > On

[PATCH] drm/amd/display: remove legacy fields of dc_plane_cap struct

2023-03-08 Thread David Tadokoro
The fields blends_with_above and blends_with_below of struct dc_plane_cap (defined in dc/dc.h) are boolean and set to true by default. All instances of a dc_plane_cap maintain the default values of both. Also, there is only one if statement that checks those fields and there would be the same

[PATCH] drm/amd/display: add prefix to amdgpu_dm_crtc.h functions

2023-03-08 Thread David Tadokoro
Some amdgpu_dm_crtc.h functions didn't have names that indicated where they were declared. To better filter results in debug tools like ftrace, prefix these functions with 'amdgpu_dm_crtc_'. Signed-off-by: David Tadokoro --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 32

Re: [PATCH RFC 02/18] rust: drm: Add Device and Driver abstractions

2023-03-08 Thread Björn Roy Baron
--- Original Message --- On Tuesday, March 7th, 2023 at 15:25, Asahi Lina wrote: > Add the initial abstractions for DRM drivers and devices. These go > together in one commit since they are fairly tightly coupled types. > > A few things have been stubbed out, to be implemented as

Re: [PATCH RFC 01/18] rust: drm: ioctl: Add DRM ioctl abstraction

2023-03-08 Thread Björn Roy Baron
--- Original Message --- On Tuesday, March 7th, 2023 at 15:25, Asahi Lina wrote: > DRM drivers need to be able to declare which driver-specific ioctls they > support. This abstraction adds the required types and a helper macro to > generate the ioctl definition inside the DRM driver. >

Re: [PATCH] MAINTAINERS: orphan SIS FRAMEBUFFER DRIVER

2023-03-08 Thread Thomas Winischhofer
Confirm. /Thomas On 08.03.23 08:19, Lukas Bulwahn wrote: > This was triggered by the fact that the webpage: > > http://www.winischhofer.net/linuxsisvga.shtml > > cannot be reached anymore. > > Thomas Winischhofer is still reachable at the given email address, but he > has not been active

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-03-08 Thread Christian König
Am 07.03.23 um 15:25 schrieb Asahi Lina: Some hardware may require more complex resource utilization accounting than the simple job count supported by drm_sched internally. Add a can_run_job callback to allow drivers to implement more logic before deciding whether to run a GPU job. Well

Re: [PATCH v3 06/17] drm/connector: Print connector colorspace in state debugfs

2023-03-08 Thread Pekka Paalanen
On Tue, 7 Mar 2023 10:10:56 -0500 Harry Wentland wrote: > v3: Fix kerneldocs (kernel test robot) > > Signed-off-by: Harry Wentland > Cc: Pekka Paalanen > Cc: Sebastian Wick > Cc: vitaly.pros...@amd.com > Cc: Uma Shankar > Cc: Ville Syrjälä > Cc: Joshua Ashton > Cc: Jani Nikula > Cc:

Re: [PATCH RFC 11/18] drm/scheduler: Clean up jobs when the scheduler is torn down

2023-03-08 Thread Christian König
Am 08.03.23 um 10:57 schrieb Maarten Lankhorst: On 2023-03-07 15:25, Asahi Lina wrote: drm_sched_fini() currently leaves any pending jobs dangling, which causes segfaults and other badness when job completion fences are signaled after the scheduler is torn down. Explicitly detach all jobs

Re: [PATCH 02/11] drm: rcar-du: remove R-Car H3 ES1.* workarounds

2023-03-08 Thread Kieran Bingham
Hi Wolfram, Quoting Wolfram Sang (2023-03-07 16:30:30) > R-Car H3 ES1.* was only available to an internal development group and > needed a lot of quirks and workarounds. These become a maintenance > burden now, so our development group decided to remove upstream support > and disable booting for

RE: [PATCH 4/7] drm/i915: Enable YCbCr420 for VDSC

2023-03-08 Thread Shankar, Uma
> -Original Message- > From: Kandpal, Suraj > Sent: Wednesday, February 22, 2023 11:02 AM > To: dri-devel@lists.freedesktop.org; intel-...@lists.freedesktop.org > Cc: Shankar, Uma ; Nautiyal, Ankit K > ; Kandpal, Suraj ; > Kulkarni, > Vandita > Subject: [PATCH 4/7] drm/i915: Enable

Re: [Intel-gfx] [PATCH 3/7] drm/i915: Adding the new registers for DSC

2023-03-08 Thread Jani Nikula
On Wed, 08 Mar 2023, "Shankar, Uma" wrote: >> -Original Message- >> From: Kandpal, Suraj >> Sent: Wednesday, February 22, 2023 11:02 AM >> To: dri-devel@lists.freedesktop.org; intel-...@lists.freedesktop.org >> Cc: Shankar, Uma ; Nautiyal, Ankit K >> ; Kandpal, Suraj ; >> Kulkarni, >>

Re: [regression] RPI4B drm vc4: no crtc or sizes since 5.17 (works in 5.16; and still broken in at least 6.1)

2023-03-08 Thread Maxime Ripard
Hi, On Tue, Mar 07, 2023 at 05:10:16PM +, Dave Stevenson wrote: > On Tue, 7 Mar 2023 at 16:25, AL13N wrote: > > AL13N schreef op 2023-03-06 17:34: > > > I have a RPI4B connected on 2nd HDMI port (furthest away from power) > > > to a 4K TV, which works until 5.16, from 5.17 there is no X (or

Re: [PATCH v3 5/7] drm/msm/hdmi: stop using drm_bridge_connector_en/disable_hpd()

2023-03-08 Thread Dmitry Baryshkov
On Wed, 8 Mar 2023 at 12:20, Johan Hovold wrote: > > On Wed, Nov 02, 2022 at 09:07:03PM +0300, Dmitry Baryshkov wrote: > > The functionality of drm_bridge_connector_enable_hpd() and > > drm_bridge_connector_disable_hpd() is provided automatically by the > > drm_kms_poll helpers. Stop calling

Re: [PATCH RFC 06/18] rust: drm: gem: shmem: Add DRM shmem helper abstraction

2023-03-08 Thread Maíra Canal
On 3/7/23 11:25, Asahi Lina wrote: The DRM shmem helper includes common code useful for drivers which allocate GEM objects as anonymous shmem. Add a Rust abstraction for this. Drivers can choose the raw GEM implementation or the shmem layer, depending on their needs. Signed-off-by: Asahi Lina

Re: [PATCH v3 02/17] drm/connector: Add enum documentation to drm_colorspace

2023-03-08 Thread Pekka Paalanen
On Tue, 7 Mar 2023 10:10:52 -0500 Harry Wentland wrote: > From: Joshua Ashton > > To match the other enums, and add more information about these values. > > v2: > - Specify where an enum entry comes from > - Clarify DEFAULT and NO_DATA behavior > - BT.2020 CYCC is "constant luminance" > -

Re: [PATCH v2 6/7] drm/ttm: Reduce the number of used allocation orders for TTM pages

2023-03-08 Thread Christian König
Am 07.03.23 um 15:46 schrieb Thomas Hellström: When swapping out, we will split multi-order pages both in order to move them to the swap-cache and to be able to return memory to the swap cache as soon as possible on a page-by-page basis. Reduce the page max order to the system PMD size, as we

Re: [PATCH RFC 11/18] drm/scheduler: Clean up jobs when the scheduler is torn down

2023-03-08 Thread Maarten Lankhorst
On 2023-03-07 15:25, Asahi Lina wrote: drm_sched_fini() currently leaves any pending jobs dangling, which causes segfaults and other badness when job completion fences are signaled after the scheduler is torn down. Explicitly detach all jobs from their completion callbacks and free them. This

Re: [PATCH v3 5/7] drm/msm/hdmi: stop using drm_bridge_connector_en/disable_hpd()

2023-03-08 Thread Johan Hovold
On Wed, Nov 02, 2022 at 09:07:03PM +0300, Dmitry Baryshkov wrote: > The functionality of drm_bridge_connector_enable_hpd() and > drm_bridge_connector_disable_hpd() is provided automatically by the > drm_kms_poll helpers. Stop calling these functions manually. I stumbled over this one when

Re: [PATCH v13 03/10] drm/display: Add Type-C switch helpers

2023-03-08 Thread Pin-yen Lin
Hi Andy, Thanks for the review. On Mon, Mar 6, 2023 at 7:49 PM Andy Shevchenko wrote: > > On Fri, Mar 03, 2023 at 10:33:43PM +0800, Pin-yen Lin wrote: > > Add helpers to register and unregister Type-C "switches" for bridges > > capable of switching their output between two downstream devices. >

Re: [PATCH v2 2/2] gpu/drm/panel: Add Lenovo NT36523W BOE panel

2023-03-08 Thread Konrad Dybcio
On 7.03.2023 23:18, Linus Walleij wrote: > On Tue, Mar 7, 2023 at 2:26 PM Konrad Dybcio wrote: > >> Introduce support for the BOE panel with a NT36523W touch/driver IC >> found on some Lenovo Tab P11 devices. It's a 2000x1200, 24bit RGB >> MIPI DSI panel with integrated DCS-controlled

Re: [PATCH v2 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-08 Thread Konrad Dybcio
On 8.03.2023 01:45, Jianhua Lu wrote: > On Tue, Mar 07, 2023 at 11:34:55PM +0100, Linus Walleij wrote: >> Hi Jianhua, >> >> thanks for your patch! >> >> It appears Konrad is working on a very similar driver, so I suggest merging >> them into one Novatek NT36523 driver. >> >> Possibly we can fix

RE: [PATCH 6/7] drm/i915/vdsc: Check slice design requirement

2023-03-08 Thread Shankar, Uma
> -Original Message- > From: Kandpal, Suraj > Sent: Wednesday, February 22, 2023 11:02 AM > To: dri-devel@lists.freedesktop.org; intel-...@lists.freedesktop.org > Cc: Shankar, Uma ; Nautiyal, Ankit K > ; Kandpal, Suraj > Subject: [PATCH 6/7] drm/i915/vdsc: Check slice design

Re: [PATCH 0/7] Enable YCbCr420 format for VDSC

2023-03-08 Thread Jani Nikula
On Wed, 22 Feb 2023, Suraj Kandpal wrote: > This patch series aims to enable the YCbCr420 format > for DSC. Changes are mostly compute params related for > hdmi,dp and dsi along with the addition of new rc_tables > for native_420 and corresponding changes to macros used to > fetch them. > There

Re: [PATCH 00/13] backlight: Convert to platform remove callback returning void

2023-03-08 Thread Daniel Thompson
On Wed, Mar 08, 2023 at 08:39:32AM +0100, Uwe Kleine-König wrote: > Uwe Kleine-König (13): > backlight: aat2870_bl: Convert to platform remove callback returning > void > backlight: adp5520_bl: Convert to platform remove callback returning > void > backlight: cr_bllcd: Convert to

[PATCH 1/2] drm/amdgpu: add flag to enable/disable poll in suspend/resume path

2023-03-08 Thread Guchun Chen
Some amd asics having reliable hotplug support don't call drm_kms_helper_poll_init in driver init sequence. However, due to the unified suspend/resume path for all asics, because the output_poll_work->func is not set for these asics, a warning arrives when suspending. [ 90.656049] [

[PATCH 2/2] drm/probe_helper: warning on poll_enabled for issue catching

2023-03-08 Thread Guchun Chen
In order to catch issues in other drivers to ensure proper call sequence of polling function. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2411 Fixes: a4e771729a51("drm/probe_helper: sort out poll_running vs poll_enabled") Reported-by: Bert Karwatzki Suggested-by: Dmitry Baryshkov

Re: [PATCH v13 07/10] drm/bridge: anx7625: Register Type C mode switches

2023-03-08 Thread Pin-yen Lin
Hi Andy, Thanks for the review. On Mon, Mar 6, 2023 at 7:55 PM Andy Shevchenko wrote: > > On Fri, Mar 03, 2023 at 10:33:47PM +0800, Pin-yen Lin wrote: > > Register USB Type-C mode switches when the "mode-switch" property and > > relevant ports are available in Device Tree. Configure the

Re: [PATCH v13 10/10] drm/bridge: it6505: Register Type C mode switches

2023-03-08 Thread Pin-yen Lin
Hi Andy, Thanks for the review. On Mon, Mar 6, 2023 at 8:03 PM Andy Shevchenko wrote: > > On Fri, Mar 03, 2023 at 10:33:50PM +0800, Pin-yen Lin wrote: > > Register USB Type-C mode switches when the "mode-switch" property and > > relevant port are available in Device Tree. Configure the

Re: [PATCH v2 6/7] drm/ttm: Reduce the number of used allocation orders for TTM pages

2023-03-08 Thread Thomas Hellström
On 3/8/23 10:15, Christian König wrote: Am 07.03.23 um 15:46 schrieb Thomas Hellström: When swapping out, we will split multi-order pages both in order to move them to the swap-cache and to be able to return memory to the swap cache as soon as possible on a page-by-page basis. Reduce the page

Re: [PATCH] fbdev: Fix incorrect page mapping clearance at fb_deferred_io_release()

2023-03-08 Thread Patrik Jakobsson
On Wed, Mar 8, 2023 at 10:14 AM Takashi Iwai wrote: > > On Wed, 08 Mar 2023 10:08:24 +0100, > Patrik Jakobsson wrote: > > > > On Wed, Mar 8, 2023 at 7:36 AM Takashi Iwai wrote: > > > > > > The recent fix for the deferred I/O by the commit > > > 3efc61d95259 ("fbdev: Fix invalid page access

Re: [PATCH v3 15/17] drm/amd/display: Add default case for output_color_space switch

2023-03-08 Thread Pekka Paalanen
On Tue, 7 Mar 2023 10:11:05 -0500 Harry Wentland wrote: > Signed-off-by: Harry Wentland > Cc: Pekka Paalanen > Cc: Sebastian Wick > Cc: vitaly.pros...@amd.com > Cc: Joshua Ashton > Cc: dri-devel@lists.freedesktop.org > Cc: amd-...@lists.freedesktop.org > Reviewed-By: Joshua Ashton Hi,

Re: [RFC] drm/amd/display: Pass proper parent for DM backlight device registration

2023-03-08 Thread Hans de Goede
Hi, On 2/15/23 12:38, Hans de Goede wrote: > The parent for the backlight device should be the drm-connector object, > not the PCI device. > > Userspace relies on this to be able to detect which backlight class device > to use on hybrid gfx devices where there may be multiple native (raw) >

Re: [PATCH] fbdev: Fix incorrect page mapping clearance at fb_deferred_io_release()

2023-03-08 Thread kernel test robot
Hi Takashi, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v6.3-rc1 next-20230308] [cannot apply to drm-misc/drm-misc-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch

RE: [PATCH 2/7] drm/i915/dp: Check if DSC supports the given output_format

2023-03-08 Thread Shankar, Uma
> -Original Message- > From: Kandpal, Suraj > Sent: Wednesday, February 22, 2023 11:02 AM > To: dri-devel@lists.freedesktop.org; intel-...@lists.freedesktop.org > Cc: Shankar, Uma ; Nautiyal, Ankit K > > Subject: [PATCH 2/7] drm/i915/dp: Check if DSC supports the given >

Re: [PATCH 0/7] Enable YCbCr420 format for VDSC

2023-03-08 Thread Dmitry Baryshkov
On 08/03/2023 13:30, Jani Nikula wrote: On Wed, 22 Feb 2023, Suraj Kandpal wrote: This patch series aims to enable the YCbCr420 format for DSC. Changes are mostly compute params related for hdmi,dp and dsi along with the addition of new rc_tables for native_420 and corresponding changes to

Re: [PATCH 2/2] drm/probe_helper: warning on poll_enabled for issue catching

2023-03-08 Thread Jani Nikula
On Wed, 08 Mar 2023, Guchun Chen wrote: > In order to catch issues in other drivers to ensure proper call > sequence of polling function. > > Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2411 > Fixes: a4e771729a51("drm/probe_helper: sort out poll_running vs poll_enabled") How does an

Re: [PATCH v3 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-08 Thread Jianhua Lu
On Wed, Mar 08, 2023 at 01:33:39PM +0100, Konrad Dybcio wrote: > > phy-type: > description: D-PHY (default) or C-PHY mode > enum: [ 10, 11 ] > default: 10 > > try setting that to 11 under your DSI PHYs (or one? not sure). I already used phy-type = before, this equate to

Re: [PATCH v2 2/7] drm/ttm/pool: Fix ttm_pool_alloc error path

2023-03-08 Thread Thomas Hellström
On 3/8/23 09:48, Christian König wrote: Am 07.03.23 um 15:46 schrieb Thomas Hellström: When hitting an error, the error path forgot to unmap dma mappings and could call set_pages_wb() on already uncached pages. Fix this by introducing a common __ttm_pool_free() function that does the right

Re: [PATCH v3 00/17] Enable Colorspace connector property in amdgpu

2023-03-08 Thread Pekka Paalanen
On Tue, 7 Mar 2023 10:10:50 -0500 Harry Wentland wrote: > This patchset is based on Joshua's previous patchset [1], as well > as my previous patchset [2]. > > It is > - enabling support for the colorspace property in amdgpu, as well as > - allowing drivers to specify the supported set of

Re: [PATCH] MAINTAINERS: orphan SIS FRAMEBUFFER DRIVER

2023-03-08 Thread Thomas Zimmermann
Am 08.03.23 um 08:19 schrieb Lukas Bulwahn: This was triggered by the fact that the webpage: http://www.winischhofer.net/linuxsisvga.shtml cannot be reached anymore. Thomas Winischhofer is still reachable at the given email address, but he has not been active since 2005. Mark the SIS

[PATCH v2] fbdev: Fix incorrect page mapping clearance at fb_deferred_io_release()

2023-03-08 Thread Takashi Iwai
The recent fix for the deferred I/O by the commit 3efc61d95259 ("fbdev: Fix invalid page access after closing deferred I/O devices") caused a regression when the same fb device is opened/closed while it's being used. It resulted in a frozen screen even if something is redrawn there after the

RE: [PATCH 1/7] drm/dp_helper: Add helper to check DSC support with given o/p format

2023-03-08 Thread Shankar, Uma
> -Original Message- > From: Kandpal, Suraj > Sent: Wednesday, February 22, 2023 11:02 AM > To: dri-devel@lists.freedesktop.org; intel-...@lists.freedesktop.org > Cc: Shankar, Uma ; Nautiyal, Ankit K > > Subject: [PATCH 1/7] drm/dp_helper: Add helper to check DSC support with given >

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-03-08 Thread Karol Herbst
On Wed, Mar 8, 2023 at 9:46 AM Christian König wrote: > > Am 07.03.23 um 15:25 schrieb Asahi Lina: > > Some hardware may require more complex resource utilization accounting > > than the simple job count supported by drm_sched internally. Add a > > can_run_job callback to allow drivers to

Re: [Intel-gfx] [PULL] drm-intel-next

2023-03-08 Thread Rodrigo Vivi
On Tue, Mar 07, 2023 at 05:00:01PM -0500, Rodrigo Vivi wrote: > Hi Dave and Daniel, > > Here goes our first pull request towards 6.3. You know, I meant 6.4. :) Thank you Joonas for noticing that. > > drm-intel-next-2023-03-07: > > Cross-subsystem Changes: > - MEI patches to fix

Re: [Intel-gfx] [Intel-xe] [PATCH] drm/xe/display: Do not use i915 frontbuffer tracking implementation

2023-03-08 Thread Ville Syrjälä
On Wed, Mar 08, 2023 at 01:47:12PM +0100, Maarten Lankhorst wrote: > > On 2023-03-06 21:58, Ville Syrjälä wrote: > > On Mon, Mar 06, 2023 at 09:23:50PM +0100, Maarten Lankhorst wrote: > >> Hey, > >> > >> On 2023-03-06 16:23, Souza, Jose wrote: > >>> On Mon, 2023-03-06 at 15:16 +0100, Maarten

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-03-08 Thread Christian König
Am 08.03.23 um 13:39 schrieb Karol Herbst: On Wed, Mar 8, 2023 at 9:46 AM Christian König wrote: Am 07.03.23 um 15:25 schrieb Asahi Lina: Some hardware may require more complex resource utilization accounting than the simple job count supported by drm_sched internally. Add a can_run_job

Re: [PATCH v2 2/7] drm/ttm/pool: Fix ttm_pool_alloc error path

2023-03-08 Thread Christian König
Am 07.03.23 um 15:46 schrieb Thomas Hellström: When hitting an error, the error path forgot to unmap dma mappings and could call set_pages_wb() on already uncached pages. Fix this by introducing a common __ttm_pool_free() function that does the right thing. v2: - Simplify __ttm_pool_free()

Re: [PATCH v3 03/17] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-03-08 Thread Pekka Paalanen
On Tue, 7 Mar 2023 10:10:53 -0500 Harry Wentland wrote: > From: Joshua Ashton > > Userspace has no way of controlling or knowing the pixel encoding > currently, so there is no way for it to ever get the right values here. > > When we do add pixel_encoding control from userspace,we can pick

Re: [PATCH 9/9] drm: move ttm_execbuf_util into vmwgfx

2023-03-08 Thread Christian König
Am 08.03.23 um 06:14 schrieb Zack Rusin: On Tue, 2023-02-28 at 09:34 +0100, Christian König wrote: VMWGFX is the only remaining user of this and should probably moved over to drm_exec when it starts using GEM as well. Is this because vmwgfx piggybacks buffer-id relocations on top of ttm

Re: [PATCH v3 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-08 Thread Jianhua Lu
On Wed, Mar 08, 2023 at 12:13:53PM +0100, Konrad Dybcio wrote: > > > On 8.03.2023 05:37, Jianhua Lu wrote: > > Add a driver for panels using the Novatek NT36523 display driver IC. > > > > Signed-off-by: Jianhua Lu > > --- > > Changes in v3: > > - Refactor source code > > > > Changes in v2:

Re: [Intel-gfx] [Intel-xe] [PATCH] drm/xe/display: Do not use i915 frontbuffer tracking implementation

2023-03-08 Thread Maarten Lankhorst
On 2023-03-06 21:58, Ville Syrjälä wrote: On Mon, Mar 06, 2023 at 09:23:50PM +0100, Maarten Lankhorst wrote: Hey, On 2023-03-06 16:23, Souza, Jose wrote: On Mon, 2023-03-06 at 15:16 +0100, Maarten Lankhorst wrote: As a fallback if we decide not to merge the frontbuffer tracking, allow i915

Re: [PATCH 0/7] Enable YCbCr420 format for VDSC

2023-03-08 Thread Jani Nikula
On Wed, 08 Mar 2023, Dmitry Baryshkov wrote: > On 08/03/2023 13:30, Jani Nikula wrote: >> On Wed, 22 Feb 2023, Suraj Kandpal wrote: >>> This patch series aims to enable the YCbCr420 format >>> for DSC. Changes are mostly compute params related for >>> hdmi,dp and dsi along with the addition of

[PATCH] drm/amd/display: remove unused variable available

2023-03-08 Thread Tom Rix
With gcc and W=1, there is this error drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dp_dpia_bw.c:297:13: error: variable ‘available’ set but not used [-Werror=unused-but-set-variable] 297 | int available = 0; | ^ Since available is unused,

Re: [PATCH] dt-bindings: Fix SPI and I2C bus node names in examples

2023-03-08 Thread Rob Herring
On Tue, 28 Feb 2023 15:54:33 -0600, Rob Herring wrote: > SPI and I2C bus node names are expected to be "spi" or "i2c", > respectively, with nothing else, a unit-address, or a '-N' index. A > pattern of 'spi0' or 'i2c0' or similar has crept in. Fix all these > cases. Mostly scripted with the

Re: [PATCH] drm/format_helper: Add Kunit tests for drm_fb_xrgb8888_to_mono()

2023-03-08 Thread Arthur Grillo Queiroz Cabral
On 07/03/23 18:55, Javier Martinez Canillas wrote: > Javier Martinez Canillas writes: > > [...] > >> >>> +static size_t conversion_buf_size_mono(unsigned int dst_pitch, const >>> struct drm_rect *clip) >>> +{ >>> + if (!dst_pitch) { >>> + unsigned int linepixels =

[PATCH v16 12/16] drm: bridge: Generalize Exynos-DSI driver into a Samsung DSIM bridge

2023-03-08 Thread Jagan Teki
Samsung MIPI DSIM controller is common DSI IP that can be used in various SoCs like Exynos, i.MX8M Mini/Nano. In order to access this DSI controller between various platform SoCs, the ideal way to incorporate this in the drm stack is via the drm bridge driver. We already have a consolidated code

[PATCH v16 13/16] dt-bindings: display: exynos: dsim: Add NXP i.MX8M Mini/Nano support

2023-03-08 Thread Jagan Teki
Samsung MIPI DSIM bridge can also be found in i.MX8M Mini/Nano SoC. Add dt-bingings for it. Reviewed-by: Marek Vasut Acked-by: Rob Herring Signed-off-by: Jagan Teki --- Changes for v16, v15, v13: - none Changes for v12: - collect RB from Marek Changes for v11, v10, v9: - none Changes for v8:

[PATCH v16 14/16] drm: bridge: samsung-dsim: Add i.MX8M Mini/Nano support

2023-03-08 Thread Jagan Teki
Samsung MIPI DSIM master can also be found in i.MX8M Mini/Nano SoC. Add compatible and associated driver_data for it. Reviewed-by: Marek Vasut Reviewed-by: Frieder Schrempf Acked-by: Robert Foss Reviewed-by: Laurent Pinchart Signed-off-by: Marek Szyprowski Signed-off-by: Jagan Teki ---

[PATCH v16 08/16] drm: exynos: dsi: Add input_bus_flags

2023-03-08 Thread Jagan Teki
LCDIF-DSIM glue logic inverts the HS/VS/DE signals and expecting the i.MX8M Mini/Nano DSI host to add additional Data Enable signal active low (DE_LOW). This makes the valid data transfer on each horizontal line. So, add additional bus flags DE_LOW setting via input_bus_flags for i.MX8M Mini/Nano

[PATCH v16 09/16] drm: exynos: dsi: Add atomic_get_input_bus_fmts

2023-03-08 Thread Jagan Teki
Finding the right input bus format throughout the pipeline is hard so add atomic_get_input_bus_fmts callback and initialize with the proper input format from list of supported output formats. This format can be used in pipeline for negotiating bus format between the DSI-end of this bridge and the

[PATCH v16 05/16] drm: exynos: dsi: Introduce hw_type platform data

2023-03-08 Thread Jagan Teki
Samsung MIPI DSIM controller is common DSI IP that can be used in various SoCs like Exynos, i.MX8M Mini/Nano/Plus. Add hw_type enum via platform_data so that accessing the different controller data between various platforms becomes easy and meaningful. Tested-by: Marek Szyprowski Reviewed-by:

[PATCH v16 06/16] drm: exynos: dsi: Handle proper host initialization

2023-03-08 Thread Jagan Teki
From: Marek Szyprowski Host transfer() in the DSI master will invoke only when the DSI commands are sent from DSI devices like DSI Panel or DSI bridges and this host the transfer wouldn't invoke for I2C-based-DSI bridge drivers. Handling DSI host initialization in transfer calls misses the

[PATCH v16 10/16] drm: exynos: dsi: Consolidate component and bridge

2023-03-08 Thread Jagan Teki
DSI host registration, attach and detach operations are quite different for the component and bridge-based DRM drivers.  Supporting generic bridge driver to use both component and bridge based DRM drivers can be tricky and would require additional host related operation hooks. Add host operation

[PATCH v16 11/16] drm: exynos: dsi: Add host helper for te_irq_handler

2023-03-08 Thread Jagan Teki
IRQ handler for te-gpio seems to be common across DSIM host. However, Exynos is handling this via CRTC drivers but there is no clear evidence on how the same has been handled in i.MX8MM. Keeping the handler as-it-is can be a viable option but adding DSIM bridge core in upcoming patches is not

[PATCH v16 07/16] drm: exynos: dsi: Add atomic check

2023-03-08 Thread Jagan Teki
Look like an explicit fixing up of mode_flags is required for DSIM IP present in i.MX8M Mini/Nano SoCs. At least the LCDIF + DSIM needs active low sync polarities in order to correlate the correct sync flags of the surrounding components in the chain to make sure the whole pipeline can work

  1   2   3   >