Re: [PATCH] drm: adv7511: Fix low refresh rate register for ADV7533/5

2023-07-14 Thread Nuno Sá
Hey Alex, On Thu, 2023-07-13 at 17:19 -0300, Fabio Estevam wrote: > On Wed, May 17, 2023 at 4:08 AM Alexandru Ardelean wrote: > > > > From: Bogdan Togorean > > > > For ADV7533 and ADV7535 low refresh rate is selected using > > bits [3:2] of 0x4a main register. > > So depending on ADV model

[PATCH] drm/amdgpu/discovery: open brace '{' following struct go on the same line

2023-07-14 Thread sunran001
Fix the checkpatch error as open brace '{' following struct should go on the same line. Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/include/discovery.h | 33 + 1 file changed, 11 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/amd/include/discovery.h

Re: [PATCH v3 1/2] drm/mediatek: Fix iommu fault by swapping FBs after updating plane state

2023-07-14 Thread 胡俊光

Re: [PATCH] dma-buf/dma-resv: Stop leaking on krealloc() failure

2023-07-14 Thread Christian König
Am 13.07.23 um 21:47 schrieb Ville Syrjala: From: Ville Syrjälä Currently dma_resv_get_fences() will leak the previously allocated array if the fence iteration got restarted and the krealloc_array() fails. Free the old array by hand, and make sure we still clear the returned *fences so the

Re: [PATCH v3 2/2] drm/mediatek: Fix iommu fault during crtc enabling

2023-07-14 Thread 胡俊光

Re: [PATCH 0/2] eventfd: simplify signal helpers

2023-07-14 Thread Christian Brauner
On Thu, Jul 13, 2023 at 11:10:54AM -0600, Alex Williamson wrote: > On Thu, 13 Jul 2023 12:05:36 +0200 > Christian Brauner wrote: > > > Hey everyone, > > > > This simplifies the eventfd_signal() and eventfd_signal_mask() helpers > > by removing the count argument which is effectively unused. >

[PATCH] fbdev: fbmem: mark registered_fb static

2023-07-14 Thread Min-Hua Chen
Mark registered_fb, num_registered_fb, fbcon_registered_fb, and fbcon_num_registered_fb static to fix the following sparse warnings: drivers/video/fbdev/core/fbmem.c:51:16: sparse: warning: symbol 'registered_fb' was not declared. Should it be static? drivers/video/fbdev/core/fbmem.c:52:5:

[PATCH v3 01/18] drm: Remove flag FBINFO_DEFAULT from fbdev emulation

2023-07-14 Thread Thomas Zimmermann
The flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v2: * fix

[PATCH v3 00/18] fbdev: Remove FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT flags

2023-07-14 Thread Thomas Zimmermann
Remove the unused flags FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT from fbdev and drivers, as briefly discussed at [1]. Both flags were maybe useful when fbdev had special handling for driver modules. With commit 376b3ff54c9a ("fbdev: Nuke FBINFO_MODULE"), they are both 0 and have no further effect.

[PATCH v3 12/18] staging: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers

2023-07-14 Thread Thomas Zimmermann
The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v2: *

[PATCH] drm/amd/amd_shared.h: remove spaces after '*'

2023-07-14 Thread sunran001
Fix four occurrences of the checkpatch.pl error: ERROR: trailing whitespace Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/include/amd_shared.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/include/amd_shared.h

Re: [PATCH v2 0/3] Galaxy S2 (i9100) panel updates v2

2023-07-14 Thread Paul Cercueil
Patches 1/3 and 2/3 applied to drm-misc-next. I'll resend patch 3/3 as standalone. Cheers, -Paul Le samedi 08 juillet 2023 à 10:40 +0200, Paul Cercueil a écrit : > Hi, > > Follow-up on my patchset that fixes the display of the Samsung Galaxy > S2 > when running PostmarketOS. > > The first two

Re: [PATCH 00/17] drm: rename various struct members "dev" -> "drm"

2023-07-14 Thread Uwe Kleine-König
Hello Maxime, On Thu, Jul 13, 2023 at 05:47:54PM +0200, Maxime Ripard wrote: > So, on the record, we have 1 drm-misc maintainer, 1 intel GPU > maintainer, 1 amdgpu/radeon/dma-buf maintainer and one former drm-misc > maintainer pretty much against, or at best skeptical. And you don't have So now

[Bug 217664] Laptop doesnt wake up from suspend mode.

2023-07-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217664 --- Comment #4 from popus_czy_to_ty (pentelja...@o2.pl) --- stripped part, might be interesting? https://pastebin.com/MgpCf7Xf -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee

Re: [PATCH v2] drm/msm/dsi: Enable DATABUS_WIDEN for DSI command mode

2023-07-14 Thread Dmitry Baryshkov
On 14/07/2023 03:21, Jessica Zhang wrote: DSI 6G v2.5.x+ and DPU 7.x+ support a data-bus widen mode that allows DSI sm8250 has widebus support in DP and thus in DPU, according to the published DT. Thus the 'DPU 7.x+' is not fully correct. to send 48 bits of compressed data per pclk instead

Re: [PATCH v2 5/6] drm/amdgpu: Log IBs and ring name at coredump

2023-07-14 Thread Christian König
Am 13.07.23 um 23:32 schrieb André Almeida: Log the IB addresses used by the hung job along with the stuck ring name. Note that due to nested IBs, the one that caused the reset itself may be in not listed address. Signed-off-by: André Almeida --- drivers/gpu/drm/amd/amdgpu/amdgpu.h|

[PATCH 3/3] drm/scheduler: Clean up jobs when the scheduler is torn down.

2023-07-14 Thread Asahi Lina
drm_sched_fini() currently leaves any pending jobs dangling, which causes segfaults and other badness when job completion fences are signaled after the scheduler is torn down. Explicitly detach all jobs from their completion callbacks and free them. This makes it possible to write a sensible safe

[PATCH 2/3] drm/scheduler: Fix UAF in drm_sched_fence_get_timeline_name

2023-07-14 Thread Asahi Lina
A signaled scheduler fence can outlive its scheduler, since fences are independencly reference counted. Therefore, we can't reference the scheduler in the get_timeline_name() implementation. Fixes oopses on `cat /sys/kernel/debug/dma_buf/bufinfo` when shared dma-bufs reference fences from GPU

[PATCH 0/3] DRM scheduler documentation & bug fixes

2023-07-14 Thread Asahi Lina
(-) --- base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5 change-id: 20230714-drm-sched-fixes-94bea043bbe7 Thank you, ~~ Lina

[PATCH 1/3] drm/scheduler: Add more documentation

2023-07-14 Thread Asahi Lina
Document the implied lifetime rules of the scheduler (or at least the intended ones), as well as the expectations of how resource acquisition should be handled. Signed-off-by: Asahi Lina --- drivers/gpu/drm/scheduler/sched_main.c | 58 -- 1 file changed, 55

[PATCH] drm/amd: open brace '{' following struct go on the same line

2023-07-14 Thread sunran001
Fix the checkpatch error as open brace '{' following struct should go on the same line. Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/include/yellow_carp_offset.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/include/yellow_carp_offset.h

Re: [PATCH 2/2] drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet

2023-07-14 Thread Amit Pundir
On Thu, 13 Jul 2023 at 23:58, Marek Vasut wrote: > > On 7/13/23 20:09, Abhinav Kumar wrote: > > > > > > On 7/12/2023 10:41 AM, Marek Vasut wrote: > >> On 7/9/23 03:03, Abhinav Kumar wrote: > >>> > >>> > >>> On 7/7/2023 1:47 AM, Neil Armstrong wrote: > On 07/07/2023 09:18, Neil Armstrong

[PATCH] drm/amd: add missing spaces after ',' and remove spaces before ','

2023-07-14 Thread sunran001
Add missing spaces and remove spaces to clear checkpatch errors. ERROR: space prohibited before that ',' (ctx:WxV) ERROR: space required after that ',' (ctx:VxV) Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/include/atom-bits.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH v2 2/6] drm/amdgpu: Allocate coredump memory in a nonblocking way

2023-07-14 Thread Christian König
Am 13.07.23 um 23:32 schrieb André Almeida: During a GPU reset, a normal memory reclaim could block to reclaim memory. Giving that coredump is a best effort mechanism, it shouldn't disturb the reset path. Change its memory allocation flag to a nonblocking one. Signed-off-by: André Almeida

Re: [PATCH] drm/ssd130x: Fix an oops when attempting to update a disabled plane

2023-07-14 Thread Geert Uytterhoeven
Hi Javier, On Thu, Jul 13, 2023 at 6:32 PM Javier Martinez Canillas wrote: > Geert reports that the following NULL pointer dereference happens for him > after commit 49d7d581ceaf ("drm/ssd130x: Don't allocate buffers on each > plane update"): > > [drm] Initialized ssd130x 1.0.0 20220131 for

[PATCH] drm/amd: open brace '{' following struct go on the same line

2023-07-14 Thread sunran001
Fix the checkpatch error as open brace '{' following struct should go on the same line. Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/include/atomfirmwareid.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/include/atomfirmwareid.h

Re: [PATCH] drm/radeon: ERROR: "(foo*)" should be "(foo *)"

2023-07-14 Thread Christian König
Am 14.07.23 um 07:35 schrieb shijie...@208suo.com: Fix one occurrence of the checkpatch.pl error: ERROR: "(foo*)" should be "(foo *)" It's nice to see all those little typos fixed, but I'm not sure how feasible it is to send patches for each type individually. Maybe just merge them together

Re: [PATCH v3 3/4] drm/mediatek: Add casting before assign

2023-07-14 Thread 林睿祥

Re: [PATCH v2 3/6] drm/amdgpu: Rework coredump to use memory dynamically

2023-07-14 Thread Christian König
Am 13.07.23 um 23:32 schrieb André Almeida: Instead of storing coredump information inside amdgpu_device struct, move if to a proper separated struct and allocate it dynamically. This will make it easier to further expand the logged information. Signed-off-by: André Almeida --- v2: Replace

[PATCH] drm/nouveau/fifo:Fix Nineteen occurrences of the gk104.c error: ERROR: space prohibited before that ':' (ctx:WxW) ERROR: : trailing statements should be on next line

2023-07-14 Thread huzhi001
Signed-off-by: ZhiHu --- .../gpu/drm/nouveau/nvkm/engine/fifo/gk104.c | 40 ++- 1 file changed, 29 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gk104.c b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gk104.c index d8a4d773a58c..b99e0a7c96bb

Re: [Freedreno] [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

2023-07-14 Thread Uwe Kleine-König
On Thu, Jul 13, 2023 at 10:41:45AM -0400, Sean Paul wrote: > On Thu, Jul 13, 2023 at 9:04 AM Uwe Kleine-König > > But even with the one-patch-per-rename approach I'd consider the > > renaming a net win, because ease of understanding code has a big value. > > It's value is not so easy measurable as

[PATCH] drm/radeon: ERROR: "(foo*)" should be "(foo *)"

2023-07-14 Thread shijie001
Fix one occurrence of the checkpatch.pl error: ERROR: "(foo*)" should be "(foo *)" Signed-off-by: Jie Shi --- drivers/gpu/drm/radeon/uvd_v1_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/uvd_v1_0.c b/drivers/gpu/drm/radeon/uvd_v1_0.c index

[PATCH] drm/radeon: ERROR: that open brace { should be on the previous line

2023-07-14 Thread shijie001
Fix eight occurrences of the checkpatch.pl error: ERROR: that open brace { should be on the previous line ERROR: space prohibited before that close parenthesis ')' ERROR: spaces required around that '?' (ctx:VxW) Signed-off-by: Jie Shi --- drivers/gpu/drm/radeon/sumo_dpm.c | 18

[PATCH] drm/radeon: ERROR: open brace '{' following struct go on the same line

2023-07-14 Thread shijie001
Fix seventeen occurrences of the checkpatch.pl error: ERROR: open brace '{' following struct go on the same line Signed-off-by: Jie Shi --- drivers/gpu/drm/radeon/smu7_discrete.h | 51 +- 1 file changed, 17 insertions(+), 34 deletions(-) diff --git

[PATCH] drm/nouveau/fifo:Fix Nineteen occurrences of the gk104.c error: ERROR: : trailing statements should be on next line

2023-07-14 Thread huzhi001
Signed-off-by: ZhiHu --- .../gpu/drm/nouveau/nvkm/engine/fifo/gk104.c | 40 ++- 1 file changed, 29 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gk104.c b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gk104.c index d8a4d773a58c..b99e0a7c96bb

Re: [Freedreno] [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

2023-07-14 Thread Tvrtko Ursulin
On 13/07/2023 16:09, Thomas Zimmermann wrote: Hi Am 13.07.23 um 16:41 schrieb Sean Paul: On Thu, Jul 13, 2023 at 9:04 AM Uwe Kleine-König wrote: hello Sean, On Wed, Jul 12, 2023 at 02:31:02PM -0400, Sean Paul wrote: I'd really prefer this patch (series or single) is not accepted. This

[PATCH] drm/nouveau/fifo:Fix Nineteen occurrences of the gk104.c error: ERROR: : trailing statements should be on next line

2023-07-14 Thread huzhi001
Signed-off-by: ZhiHu --- .../gpu/drm/nouveau/nvkm/engine/fifo/gk104.c | 40 ++- 1 file changed, 29 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gk104.c b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gk104.c index d8a4d773a58c..b99e0a7c96bb

Re: [Freedreno] [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

2023-07-14 Thread Thomas Zimmermann
Hi Am 13.07.23 um 16:41 schrieb Sean Paul: On Thu, Jul 13, 2023 at 9:04 AM Uwe Kleine-König wrote: hello Sean, On Wed, Jul 12, 2023 at 02:31:02PM -0400, Sean Paul wrote: I'd really prefer this patch (series or single) is not accepted. This will cause problems for everyone cherry-picking

[PATCH] drm/radeon: ERROR: space prohibited before that ', ' (ctx:WxV)

2023-07-14 Thread shijie001
Fix two occurrences of the checkpatch.pl error: ERROR: space prohibited before that ',' (ctx:WxV) ERROR: space required after that ',' (ctx:WxV) Signed-off-by: Jie Shi --- drivers/gpu/drm/radeon/atom-bits.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] drm/nouveau/fifo:Fix Nineteen occurrences of the gk104.c error: ERROR: space prohibited before that ':' (ctx:WxW) ERROR: trailing statements should be on next line ERROR: space prohibited befo

2023-07-14 Thread huzhi001
Fix Nineteen occurrences of the checkpatch.pl error: ERROR: space prohibited before that ':' (ctx:WxW) ERROR: trailing statements should be on next line ERROR: space prohibited before that ':' (ctx:WxW) ERROR: trailing statements should be on next line ERROR: space prohibited before that ':'

Re: [Freedreno] [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

2023-07-14 Thread Maxime Ripard
On Thu, Jul 13, 2023 at 04:14:55PM +0100, Tvrtko Ursulin wrote: > > On 13/07/2023 16:09, Thomas Zimmermann wrote: > > Hi > > > > Am 13.07.23 um 16:41 schrieb Sean Paul: > > > On Thu, Jul 13, 2023 at 9:04 AM Uwe Kleine-König > > > wrote: > > > > > > > > hello Sean, > > > > > > > > On Wed, Jul

[PATCH] drm/radeon: ERROR: open brace '{' following function definitions go on the next line

2023-07-14 Thread shijie001
Fix four occurrences of the checkpatch.pl error: ERROR: open brace '{' following function definitions go on the next line Signed-off-by: Jie Shi --- drivers/gpu/drm/radeon/radeon_atpx_handler.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git

Re: [Freedreno] [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

2023-07-14 Thread Sean Paul
On Thu, Jul 13, 2023 at 9:04 AM Uwe Kleine-König wrote: > > hello Sean, > > On Wed, Jul 12, 2023 at 02:31:02PM -0400, Sean Paul wrote: > > I'd really prefer this patch (series or single) is not accepted. This > > will cause problems for everyone cherry-picking patches to a > > downstream kernel

[PATCH] drm/radeon: ERROR: spaces required around that '+=' (ctx:VxV)

2023-07-14 Thread shijie001
Fix two occurrences of the checkpatch.pl error: ERROR: spaces required around that '+=' (ctx:VxV) Signed-off-by: Jie Shi --- drivers/gpu/drm/radeon/r100.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/r100.c b/drivers/gpu/drm/radeon/r100.c index

[PATCH] drm/nouveau/fifo:Fix Nineteen occurrences of the gk104.c error: ERROR: space prohibited before that ':' (ctx:WxW) ERROR: trailing statements should be on next line ERROR: space prohibited befo

2023-07-14 Thread huzhi001
Signed-off-by: ZhiHu --- .../gpu/drm/nouveau/nvkm/engine/fifo/gk104.c | 40 ++- 1 file changed, 29 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gk104.c b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/gk104.c index d8a4d773a58c..b99e0a7c96bb

[PATCH] drm/radeon/dpm: ERROR: open brace '{' following enum go on the same line

2023-07-14 Thread shijie001
Fix four occurrences of the checkpatch.pl error: ERROR: open brace '{' following enum go on the same line Signed-off-by: Jie Shi --- drivers/gpu/drm/radeon/ni_dpm.h | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/radeon/ni_dpm.h

Re: [Freedreno] [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

2023-07-14 Thread Uwe Kleine-König
hello Sean, On Wed, Jul 12, 2023 at 02:31:02PM -0400, Sean Paul wrote: > I'd really prefer this patch (series or single) is not accepted. This > will cause problems for everyone cherry-picking patches to a > downstream kernel (LTS or distro tree). I usually wouldn't expect > sympathy here, but

Re: [Linaro-mm-sig] Re: [PATCH v3] misc: sram: Add DMA-BUF Heap exporting of SRAM areas

2023-07-14 Thread Christian König
Am 13.07.23 um 21:28 schrieb Greg Kroah-Hartman: On Thu, Jul 13, 2023 at 02:13:16PM -0500, Andrew Davis wrote: This new export type exposes to userspace the SRAM area as a DMA-BUF Heap, this allows for allocations of DMA-BUFs that can be consumed by various DMA-BUF supporting devices. What

[PATCH v3 18/18] fbdev: Document that framebuffer_alloc() returns zero'ed data

2023-07-14 Thread Thomas Zimmermann
Most fbdev drivers depend on framebuffer_alloc() to initialize the allocated memory to 0. Document this guarantee. v3: * slightly reword the sentence (Miguel) Suggested-by: Miguel Ojeda Signed-off-by: Thomas Zimmermann Reviewed-by: Miguel Ojeda Cc: Helge Deller ---

[PATCH v3 11/18] media: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers

2023-07-14 Thread Thomas Zimmermann
The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by kzalloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v2: * fix commit

[PATCH v3 15/18] fbdev/atafb: Remove flag FBINFO_FLAG_DEFAULT

2023-07-14 Thread Thomas Zimmermann
The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by a static declaration. So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v2: *

Re: [PATCH v7 5/8] drm/bridge: sii902x: Support format negotiation hooks

2023-07-14 Thread Javier Martinez Canillas
Aradhya Bhatia writes: Hello Aradhya, > Hi Sam, > [...] >> >> It would be even better to walk through other implementations of >> get_input_bus_fmts and update them accordingly. >> >> Again, sorry for being late here. Feel free to ignore if you already >> moved on with something else. >> >

[PATCH v3 14/18] fbdev: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers

2023-07-14 Thread Thomas Zimmermann
The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v2: *

[PATCH v3 08/18] sh: mach-sh7763rdp: Assign FB_MODE_IS_UNKNOWN to struct fb_videomode.flag

2023-07-14 Thread Thomas Zimmermann
Assign FB_MODE_IS_UNKNOWN to sh7763fb_videomode.flag instead of FBINFO_FLAG_DEFAULT. Both are 0, so the stored value does not change. FBINFO_FLAG_DEFAULT is a flag for a framebuffer in struct fb_info. Flags for videomodes are prefixed with FB_MODE_. v3: * include board name in commit

[PATCH v3 05/18] fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers

2023-07-14 Thread Thomas Zimmermann
The flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v2: * fix

[PATCH v3 04/18] fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers

2023-07-14 Thread Thomas Zimmermann
The flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by devm_kzalloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v2: * fix commit

[PATCH v3 07/18] vfio-mdev: Remove flag FBINFO_DEFAULT from fbdev sample driver

2023-07-14 Thread Thomas Zimmermann
The flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v2: * fix

[PATCH v3 10/18] hid/picolcd: Remove flag FBINFO_FLAG_DEFAULT from fbdev driver

2023-07-14 Thread Thomas Zimmermann
The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v2: *

[PATCH v3 02/18] fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers

2023-07-14 Thread Thomas Zimmermann
The flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by a static declaration. So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v2: * fix

[PATCH v3 03/18] fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers

2023-07-14 Thread Thomas Zimmermann
The flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by kzalloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v2: * fix commit

[PATCH v3 06/18] fbdev/fsl-diu-fb: Remove flag FBINFO_DEFAULT

2023-07-14 Thread Thomas Zimmermann
The flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by dmam_alloc_coherent(__GFP_ZERO). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v2:

Re: [PATCH v2 4/6] drm/amdgpu: Limit info in coredump for kernel threads

2023-07-14 Thread Christian König
Am 13.07.23 um 23:32 schrieb André Almeida: If a kernel thread caused the reset, the information available to be logged will be limited, so return early in the dump function. Why? The register values and vram lost state should still be valid. Christian. Signed-off-by: André Almeida ---

[PATCH v3 17/18] fbdev: Remove FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT

2023-07-14 Thread Thomas Zimmermann
Remove the unused flags FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT. No functional changes. Signed-off-by: Thomas Zimmermann Acked-by: Sam Ravnborg Cc: Helge Deller --- include/linux/fb.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/linux/fb.h b/include/linux/fb.h index

[PATCH v3 13/18] fbdev: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers

2023-07-14 Thread Thomas Zimmermann
The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by kzalloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v2: * fix commit

[PATCH v3 09/18] auxdisplay: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers

2023-07-14 Thread Thomas Zimmermann
The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v2: *

[PATCH v3 16/18] fbdev/pxafb: Remove flag FBINFO_FLAG_DEFAULT

2023-07-14 Thread Thomas Zimmermann
The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by devm_kzalloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v2: * fix

Re: [PATCH] drm/ssd130x: Fix an oops when attempting to update a disabled plane

2023-07-14 Thread Javier Martinez Canillas
Geert Uytterhoeven writes: Hello Geert, > Hi Javier, > > On Thu, Jul 13, 2023 at 6:32 PM Javier Martinez Canillas > wrote: >> Geert reports that the following NULL pointer dereference happens for him >> after commit 49d7d581ceaf ("drm/ssd130x: Don't allocate buffers on each >> plane update"):

[PATCH v4 07/17] drm/imagination: Add GPU ID parsing and firmware loading

2023-07-14 Thread Sarah Walker
Read the GPU ID register at probe time and select the correct features/quirks/enhancements. Use the GPU ID to form the firmware file name and load the firmware. The features/quirks/enhancements arrays are currently hardcoded in the driver for the supported GPUs. We are looking at moving this

[PATCH v4 03/17] drm/imagination/uapi: Add PowerVR driver UAPI

2023-07-14 Thread Sarah Walker
Add the UAPI implementation for the PowerVR driver. Signed-off-by: Sarah Walker --- MAINTAINERS|1 + include/uapi/drm/pvr_drm.h | 1304 2 files changed, 1305 insertions(+) create mode 100644 include/uapi/drm/pvr_drm.h diff --git

[PATCH v4 04/17] drm/imagination: Add skeleton PowerVR driver

2023-07-14 Thread Sarah Walker
This adds the basic skeleton of the driver. The driver registers itself with DRM on probe. Ioctl handlers are currently implemented as stubs. Changes since v3: - Clarify supported GPU generations in driver description - Use drm_dev_unplug() when removing device - Change from_* and to_* functions

[PATCH v4 05/17] drm/imagination: Get GPU resources

2023-07-14 Thread Sarah Walker
Acquire clock and register resources, and enable/map as appropriate. Changes since v3: - Remove regulator resource (not used on supported platform) - Use devm helpers - Use devm_clk_get_optional() for optional clocks - Don't prepare clocks on resource acquisition - Drop

[PATCH v4 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-07-14 Thread Sarah Walker
Add the device tree binding documentation for the Series AXE GPU used in TI AM62 SoCs. Changes since v3: - Remove oneOf in compatible property - Remove power-supply (not used on AM62) Changes since v2: - Add commit message description - Remove mt8173-gpu support (not currently supported) - Drop

Re: [PATCH 3/5] drm/amdkfd: use vma_is_stack() and vma_is_heap()

2023-07-14 Thread Vlastimil Babka
On 7/12/23 18:24, Felix Kuehling wrote: > Allocations in the heap and stack tend to be small, with several > allocations sharing the same page. Sharing the same page for different > allocations with different access patterns leads to thrashing when we > migrate data back and forth on GPU and

Re: [PATCH 3/5] drm/amdkfd: use vma_is_stack() and vma_is_heap()

2023-07-14 Thread Felix Kuehling
Am 2023-07-14 um 10:26 schrieb Vlastimil Babka: On 7/12/23 18:24, Felix Kuehling wrote: Allocations in the heap and stack tend to be small, with several allocations sharing the same page. Sharing the same page for different allocations with different access patterns leads to thrashing when we

[PATCH v4 10/17] drm/imagination: Implement firmware infrastructure and META FW support

2023-07-14 Thread Sarah Walker
The infrastructure includes parsing of the firmware image, initialising FW-side structures, handling the kernel and firmware command ringbuffers and starting & stopping the firmware processor. This patch also adds the necessary support code for the META firmware processor. Changes since v3: -

[PATCH v4 12/17] drm/imagination: Implement free list and HWRT create and destroy ioctls

2023-07-14 Thread Sarah Walker
Implement ioctls to create and destroy free lists and HWRT datasets. Free lists are used for GPU-side memory allocation during geometry processing. HWRT datasets are the FW-side structures representing render targets. Changes since v3: - Support free list grow requests from FW - Use

[PATCH v4 15/17] drm/imagination: Add firmware trace to debugfs

2023-07-14 Thread Sarah Walker
Firmware trace is exposed at /sys/debug/dri//pvr_fw/trace_0. Trace is enabled via the group mask at /sys/debug/dri//pvr_params/fw_trace_mask. Changes since v3: - Use drm_dev_{enter,exit} Signed-off-by: Sarah Walker --- drivers/gpu/drm/imagination/Makefile | 4 +

Re: [RFC PATCH 3/3] drm/file: drop DRM_MINOR_CONTROL

2023-07-14 Thread Thomas Zimmermann
Hi Am 14.07.23 um 16:37 schrieb Simon Ser: On Friday, July 14th, 2023 at 16:28, Thomas Zimmermann wrote: Hi Simon Am 14.07.23 um 12:46 schrieb Simon Ser: This entry should never be used by the kernel. Record the historical context in a comment. Signed-off-by: Simon Ser Cc: Christian

Re: [PATCH 0/2] eventfd: simplify signal helpers

2023-07-14 Thread Jason Gunthorpe
On Fri, Jul 14, 2023 at 09:05:21AM +0200, Christian Brauner wrote: > I have no skin in the game aside from having to drop this conversion > which I'm fine to do if there are actually users for this btu really, > that looks a lot like abusing an api that really wasn't designed for > this. Yeah, I

Re: [PATCH 1/5 v4] accel/qaic: tighten bounds checking in encode_message()

2023-07-14 Thread Jeffrey Hugo
On 7/14/2023 5:41 AM, Pranjal Ramajor Asha Kanojiya wrote: On 7/11/2023 1:50 PM, Dan Carpenter wrote: There are several issues in this code.  The check at the start of the loop: if (user_len >= user_msg->len) { This check does not ensure that we have enough space for the trans_hdr (8

[PATCH] gpu/host1x: Explicitly include correct DT includes

2023-07-14 Thread Rob Herring
The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result,

[PATCH] fb: Explicitly include correct DT includes

2023-07-14 Thread Rob Herring
The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result,

[PATCH] backlight: qcom-wled: Explicitly include correct DT includes

2023-07-14 Thread Rob Herring
The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result,

Re: [PATCH 2/3] drm/scheduler: Fix UAF in drm_sched_fence_get_timeline_name

2023-07-14 Thread Christian König
Am 14.07.23 um 11:44 schrieb Asahi Lina: On 14/07/2023 17.43, Christian König wrote: Am 14.07.23 um 10:21 schrieb Asahi Lina: A signaled scheduler fence can outlive its scheduler, since fences are independencly reference counted. Therefore, we can't reference the scheduler in the

Re: [PATCH 1/3] drm/scheduler: Add more documentation

2023-07-14 Thread Asahi Lina
On 14/07/2023 18.47, Christian König wrote: Am 14.07.23 um 11:39 schrieb Asahi Lina: On 14/07/2023 17.40, Christian König wrote: Am 14.07.23 um 10:21 schrieb Asahi Lina: Document the implied lifetime rules of the scheduler (or at least the intended ones), as well as the expectations of how

Re: [PATCH 2/3] drm/scheduler: Fix UAF in drm_sched_fence_get_timeline_name

2023-07-14 Thread Christian König
Am 14.07.23 um 11:49 schrieb Asahi Lina: On 14/07/2023 17.43, Christian König wrote: Am 14.07.23 um 10:21 schrieb Asahi Lina: A signaled scheduler fence can outlive its scheduler, since fences are independencly reference counted. Therefore, we can't reference the scheduler in the

Re: [RFC 2/2] drm/i915: Remove PAT hack from i915_gem_object_can_bypass_llc

2023-07-14 Thread Tvrtko Ursulin
On 14/07/2023 06:43, Yang, Fei wrote: From: Tvrtko Ursulin According to the comment in i915_gem_object_can_bypass_llc the purpose of the function is to return false if the platform/object has a caching mode where GPU can bypass the LLC. So far the only platforms which allegedly can do this

Re: [PATCH] drm: support up to 128 drm devices

2023-07-14 Thread Simon Ser
(cc Daniel Vetter and Pekka because this change has uAPI repercussions) On Friday, June 30th, 2023 at 13:56, James Zhu wrote: > From: Christian König > > This makes room for up to 128 DRM devices. > > Signed-off-by: Christian König > Signed-off-by: James Zhu > --- >

Re: [PATCH 8/8] drm/ssd130x: Switch preferred_bpp/depth to 1

2023-07-14 Thread Javier Martinez Canillas
Geert Uytterhoeven writes: > The native display format is R1. Hence change the preferred_depth and > preferred_bpp to 1, to avoid the overhead of using XR24 and the > associated conversions when using fbdev emulation and its text console. > > Signed-off-by: Geert Uytterhoeven > ---

[PATCH 2/2] drm/amdgpu: Enabling FW workaround through shared memory for VCN 4

2023-07-14 Thread sguttula
This patch will enable VCN FW workaround using DRM KEY INJECT WORKAROUND method, which is helping in fixing the secure playback. Signed-off-by: sguttula --- Changes in v2: -updated commit message as per veera's feedback --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 9 +

[PATCH 2/3] drm/file: use explicit values for enum drm_minor_type

2023-07-14 Thread Simon Ser
This makes it clearer that the values cannot be changed because they are ABI. Signed-off-by: Simon Ser Cc: Christian König Cc: James Zhu Cc: Marek Olšák Cc: Daniel Vetter --- include/drm/drm_file.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 1/3] drm/drv: use enum drm_minor_type when appropriate

2023-07-14 Thread Simon Ser
This makes it easier to figure out what the "type" variable can be set to when reading the implementation of these functions. Signed-off-by: Simon Ser Cc: Christian König Cc: James Zhu Cc: Marek Olšák Cc: Daniel Vetter --- drivers/gpu/drm/drm_drv.c | 8 1 file changed, 4

[RFC PATCH 3/3] drm/file: drop DRM_MINOR_CONTROL

2023-07-14 Thread Simon Ser
This entry should never be used by the kernel. Record the historical context in a comment. Signed-off-by: Simon Ser Cc: Christian König Cc: James Zhu Cc: Marek Olšák Cc: Daniel Vetter --- include/drm/drm_file.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 5/8] drm/client: Convert drm_mode_create_dumb() to drm_mode_addfb2()

2023-07-14 Thread Simon Ser
On Thursday, July 13th, 2023 at 15:17, Geert Uytterhoeven wrote: > Currently drm_client_buffer_addfb() uses the legacy drm_mode_addfb(), > which uses bpp and depth to guess the wanted buffer format. > However, drm_client_buffer_addfb() already knows the exact buffer > format, so there is no

[PATCH v4] drm/syncobj: add IOCTL to register an eventfd

2023-07-14 Thread Simon Ser
Introduce a new DRM_IOCTL_SYNCOBJ_EVENTFD IOCTL which signals an eventfd from a syncobj. This is useful for Wayland compositors to handle wait-before-submit. Wayland clients can send a timeline point to the compositor before the point has materialized yet, then compositors can wait for the point

Re: [PATCH 6/8] drm/fb-helper: Pass buffer format via drm_fb_helper_surface_size

2023-07-14 Thread Geert Uytterhoeven
Hi Javier, On Fri, Jul 14, 2023 at 12:25 PM Javier Martinez Canillas wrote: > Geert Uytterhoeven writes: > > drm_fb_helper_single_fb_probe() first calls drm_fb_helper_find_sizes(), > > followed by drm_fbdev_generic_helper_fb_probe(): > > - The former tries to find a suitable buffer format,

Re: [PATCH 1/5 v4] accel/qaic: tighten bounds checking in encode_message()

2023-07-14 Thread Pranjal Ramajor Asha Kanojiya
On 7/11/2023 1:50 PM, Dan Carpenter wrote: There are several issues in this code. The check at the start of the loop: if (user_len >= user_msg->len) { This check does not ensure that we have enough space for the trans_hdr (8 bytes). Instead the check needs to be: if

Re: [PATCH 4/8] drm/ssd130x: Add support for DRM_FORMAT_R1

2023-07-14 Thread Geert Uytterhoeven
Hi Javier, On Fri, Jul 14, 2023 at 2:35 PM Javier Martinez Canillas wrote: > Geert Uytterhoeven writes: > > On Fri, Jul 14, 2023 at 12:14 PM Javier Martinez Canillas > > wrote: > >> Geert Uytterhoeven writes: > >> Thanks a lot for your patch, this has been on my TODO for some time! > >> > >>

Re: [PATCH v3 04/17] drm/imagination: Add skeleton PowerVR driver

2023-07-14 Thread Frank Binns
Hi Maxime, Thank you for your feedback (comments below). On Fri, 2023-07-07 at 14:46 +0200, Maxime Ripard wrote: > Hi, > > [I just noticed I dropped the Cc list, resending] > > Thanks for contributing this driver, it's awesome to see it moving > forward. > > And congrats on the documentation

Re: [PATCH v3 05/17] drm/imagination: Get GPU resources

2023-07-14 Thread Frank Binns
Hi Maxime, On Fri, 2023-07-07 at 14:47 +0200, Maxime Ripard wrote: > On Tue, Jun 13, 2023 at 03:47:48PM +0100, Sarah Walker wrote: > > Acquire clock, regulator and register resources, and enable/map as > > appropriate. > > > > Signed-off-by: Sarah Walker > > --- > >

  1   2   3   >