[PATCH] drm/radeon: ERROR: "foo * bar" should be "foo *bar"

2023-07-21 Thread sunran001
Fix two occurrences of the checkpatch.pl error: ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Ran Sun --- drivers/gpu/drm/radeon/atom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/atom.c b/drivers/gpu/drm/radeon/atom.c index

Patch "drm/ttm: Don't leak a resource on swapout move error" has been added to the 6.1-stable tree

2023-07-21 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/ttm: Don't leak a resource on swapout move error to the 6.1-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Patch "drm/ttm: Don't leak a resource on eviction error" has been added to the 6.4-stable tree

2023-07-21 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/ttm: Don't leak a resource on eviction error to the 6.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Patch "drm/ttm: Don't leak a resource on swapout move error" has been added to the 6.4-stable tree

2023-07-21 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/ttm: Don't leak a resource on swapout move error to the 6.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Re: [v7,2/9] drm/i915: Add the has_aux_ccs device property

2023-07-21 Thread Andi Shyti
Hi Janusz, On Fri, Jul 21, 2023 at 09:25:03AM +, Krzysztofik, Janusz wrote: > Hi Andy, > > On Thursday, 20 July 2023 23:07:30 CEST Andi Shyti wrote: > > We always assumed that a device might either have AUX or FLAT > > CCS, but this is an approximation that is not always true > > If there

Re: [Intel-gfx] [PATCH v7 6/9] drm/i915/gt: Refactor intel_emit_pipe_control_cs() in a single function

2023-07-21 Thread Andrzej Hajda
On 20.07.2023 23:07, Andi Shyti wrote: Just a trivial refactoring for reducing the number of code duplicate. This will come at handy in the next commits. Signed-off-by: Andi Shyti Cc: # v5.8+ --- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 44 +--- 1 file changed, 23

Re: [Intel-gfx] [PATCH v7 5/9] drm/i915/gt: Enable the CCS_FLUSH bit in the pipe control

2023-07-21 Thread Andi Shyti
Hi Nirmoy, On Fri, Jul 21, 2023 at 12:05:10PM +0200, Andrzej Hajda wrote: > On 20.07.2023 23:07, Andi Shyti wrote: > > Enable the CCS_FLUSH bit 13 in the control pipe for render and > > compute engines in platforms starting from Meteor Lake (BSPEC > > 43904 and 47112). > > > > Fixes:

Re: [Intel-gfx] [PATCH v7 5/9] drm/i915/gt: Enable the CCS_FLUSH bit in the pipe control

2023-07-21 Thread Andi Shyti
Hi Andrzej, > > diff --git a/drivers/gpu/drm/i915/gt/gen8_engine_cs.c > > b/drivers/gpu/drm/i915/gt/gen8_engine_cs.c > > index 7566c89d9def3..9d050b9a19194 100644 > > --- a/drivers/gpu/drm/i915/gt/gen8_engine_cs.c > > +++ b/drivers/gpu/drm/i915/gt/gen8_engine_cs.c > > @@ -218,6 +218,13 @@ int

Re: [PATCH 2/3] drm/scheduler: Fix UAF in drm_sched_fence_get_timeline_name

2023-07-21 Thread Asahi Lina
On 18/07/2023 14.45, Luben Tuikov wrote: On 2023-07-17 22:35, Asahi Lina wrote: On 18/07/2023 00.55, Christian König wrote: Am 15.07.23 um 16:14 schrieb aly...@rosenzweig.io: 15 July 2023 at 00:03, "Luben Tuikov" wrote: On 2023-07-14 05:57, Christian König wrote: Am 14.07.23 um 11:49

Re: [v7,5/9] drm/i915/gt: Enable the CCS_FLUSH bit in the pipe control

2023-07-21 Thread Andi Shyti
Hi Janusz, > > Enable the CCS_FLUSH bit 13 in the control pipe for render and > > compute engines in platforms starting from Meteor Lake (BSPEC > > 43904 and 47112). > > > > Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all > > engines") > > I'm not sure why you think that

[PATCH] drm/i915: Use the i915_vma_flush_writes helper

2023-07-21 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We can use the existing helper in flush_write_domain() and save some lines of code. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_domain.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

Re: [PATCH v1 1/1] drm/i915: Move abs_diff() to math.h

2023-07-21 Thread Andy Shevchenko
On Fri, Jul 21, 2023 at 04:42:35PM +0300, Andy Shevchenko wrote: > abs_diff() belongs to math.h. Move it there. > This will allow others to use it. Sorry, forgot omap-serial case. Will be v2 soon. -- With Best Regards, Andy Shevchenko

[PATCH v4] drm/ssd130x: Allocate buffers in the plane's .atomic_check callback

2023-07-21 Thread Javier Martinez Canillas
Geert reports that the following NULL pointer dereference happens for him after commit 49d7d581ceaf ("drm/ssd130x: Don't allocate buffers on each plane update"): [drm] Initialized ssd130x 1.0.0 20220131 for 0-003c on minor 0 ssd130x-i2c 0-003c: [drm] surface width(128), height(32), bpp(1)

Re: [PATCH v2 2/9] vgacon: rework screen_info #ifdef checks

2023-07-21 Thread Khalid Aziz
On 7/19/23 6:39 AM, Arnd Bergmann wrote: From: Arnd Bergmann On non-x86 architectures, the screen_info variable is generally only used for the VGA console where supported, and in some cases the EFI framebuffer or vga16fb. Now that we have a definite list of which architectures actually use it

Re: [Intel-gfx] [PATCH v7 5/9] drm/i915/gt: Enable the CCS_FLUSH bit in the pipe control

2023-07-21 Thread Andrzej Hajda
On 20.07.2023 23:07, Andi Shyti wrote: Enable the CCS_FLUSH bit 13 in the control pipe for render and compute engines in platforms starting from Meteor Lake (BSPEC 43904 and 47112). Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Signed-off-by: Andi Shyti Cc:

Re: [PATCH v3 2/2] gpu: host1x: Stop open-coding of_device_uevent()

2023-07-21 Thread Thierry Reding
On Thu, Jun 22, 2023 at 11:32:14PM +0200, Miquel Raynal wrote: > There is apparently no reasons to open-code of_device_uevent() besides: > - The helper receives a struct device while we want to use the of_node > member of the struct device *parent*. > - of_device_uevent() could not be called by

Re: [PATCH v3] drm/i915: Refactor PAT/object cache handling

2023-07-21 Thread Tvrtko Ursulin
On 21/07/2023 05:28, Yang, Fei wrote: [snip] @@ -27,15 +28,8 @@ static bool gpu_write_needs_clflush(struct drm_i915_gem_object *obj) The code change here looks accurate, but while we're here, I have a side question about this function in general...it was originally introduced in commit

[PATCH v1 1/1] drm/i915: Move abs_diff() to math.h

2023-07-21 Thread Andy Shevchenko
abs_diff() belongs to math.h. Move it there. This will allow others to use it. Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 1 + drivers/gpu/drm/i915/display/intel_dpll_mgr.h | 7 --- drivers/gpu/ipu-v3/ipu-image-convert.c| 14 ++

Re: [PATCH v2 1/9] vgacon: rework Kconfig dependencies

2023-07-21 Thread Khalid Aziz
On 7/19/23 6:39 AM, Arnd Bergmann wrote: From: Arnd Bergmann The list of dependencies here is phrased as an opt-out, but this is missing a lot of architectures that don't actually support VGA consoles, and some of the entries are stale: - powerpc used to support VGA consoles in the old

Re: [PATCH v2 5/9] vgacon: remove screen_info dependency

2023-07-21 Thread Khalid Aziz
On 7/19/23 6:39 AM, Arnd Bergmann wrote: From: Arnd Bergmann The vga console driver is fairly self-contained, and only used by architectures that explicitly initialize the screen_info settings. Chance every instance that picks the vga console by setting conswitchp to call a function instead,

Re: [PATCH v5 05/11] drm/amdgpu: Use RMW accessors for changing LNKCTL

2023-07-21 Thread Ilpo Järvinen
On Thu, 20 Jul 2023, Bjorn Helgaas wrote: > On Mon, Jul 17, 2023 at 03:04:57PM +0300, Ilpo Järvinen wrote: > > Don't assume that only the driver would be accessing LNKCTL. ASPM > > policy changes can trigger write to LNKCTL outside of driver's control. > > And in the case of upstream bridge, the

Re: [PATCH v2 6/9] vgacon: clean up global screen_info instances

2023-07-21 Thread Khalid Aziz
On 7/19/23 6:39 AM, Arnd Bergmann wrote: From: Arnd Bergmann To prepare for completely separating the VGA console screen_info from the one used in EFI/sysfb, rename the vgacon instances and make them local as much as possible. ia64 and arm both have confurations with vgacon and efi, but the

Re: [PATCH v2 3/4] selinux: use vma_is_initial_stack() and vma_is_initial_heap()

2023-07-21 Thread Paul Moore
On Thu, Jul 20, 2023 at 4:28 AM Kefeng Wang wrote: > On 2023/7/19 23:25, Paul Moore wrote: > > On Wed, Jul 19, 2023 at 6:23 AM Kefeng Wang > > wrote: > >> On 2023/7/19 17:02, Christian Göttsche wrote: > >>> On Wed, 19 Jul 2023 at 09:40, Kefeng Wang > >>> wrote: > > Use the helpers

Re: [Intel-gfx] [PATCH v7 2/9] drm/i915: Add the has_aux_ccs device property

2023-07-21 Thread Andi Shyti
Hi Andrzej, On Fri, Jul 21, 2023 at 11:41:22AM +0200, Andrzej Hajda wrote: > On 20.07.2023 23:07, Andi Shyti wrote: > > We always assumed that a device might either have AUX or FLAT > > CCS, but this is an approximation that is not always true as it > > requires some further per device checks. >

Re: [Intel-gfx] [PATCH v7 5/9] drm/i915/gt: Enable the CCS_FLUSH bit in the pipe control

2023-07-21 Thread Andrzej Hajda
On 20.07.2023 23:07, Andi Shyti wrote: Enable the CCS_FLUSH bit 13 in the control pipe for render and compute engines in platforms starting from Meteor Lake (BSPEC 43904 and 47112). Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Signed-off-by: Andi Shyti Cc:

Re: [v7,5/9] drm/i915/gt: Enable the CCS_FLUSH bit in the pipe control

2023-07-21 Thread Krzysztofik, Janusz
Hi Andi, On Thursday, 20 July 2023 23:07:33 CEST Andi Shyti wrote: > Enable the CCS_FLUSH bit 13 in the control pipe for render and > compute engines in platforms starting from Meteor Lake (BSPEC > 43904 and 47112). > > Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all >

Re: [PATCH 6/9] drm/verisilicon: Add drm crtc funcs

2023-07-21 Thread Keith Zhao
On 2023/6/30 19:55, Thomas Zimmermann wrote: > Hi > > Am 02.06.23 um 09:40 schrieb Keith Zhao: >> Add crtc driver which implements crtc related operation functions. >> >> Signed-off-by: Keith Zhao >> --- >>   drivers/gpu/drm/verisilicon/Makefile  |   1 + >>  

Re: [PATCH 6/9] drm/verisilicon: Add drm crtc funcs

2023-07-21 Thread Sam Ravnborg
Hi Keith, On Fri, Jul 21, 2023 at 07:57:24PM +0800, Keith Zhao wrote: > >> + > >> +struct vs_crtc_funcs { > >> +    void (*enable)(struct device *dev, struct drm_crtc *crtc); > >> +    void (*disable)(struct device *dev, struct drm_crtc *crtc); > >> +    bool (*mode_fixup)(struct device *dev, > >>

Re: [PATCH v2] backlight: gpio_backlight: Drop output gpio direction check for initial power state

2023-07-21 Thread Daniel Thompson
On Fri, Jul 21, 2023 at 07:31:37AM +, Ying Liu wrote: > If gpio pin is in input state but backlight is currently off due to > default pull downs, then initial power state is set to FB_BLANK_UNBLANK > in DT boot mode with phandle link and the backlight is effectively > turned on in

Re: [v7,2/9] drm/i915: Add the has_aux_ccs device property

2023-07-21 Thread Krzysztofik, Janusz
Hi Andy, On Thursday, 20 July 2023 23:07:30 CEST Andi Shyti wrote: > We always assumed that a device might either have AUX or FLAT > CCS, but this is an approximation that is not always true If there exists a device that can have CCSs that fall into either none or both of those categories then

[PATCH] drm/bridge: Add debugfs print for bridge chains

2023-07-21 Thread Tomi Valkeinen
(struct drm_minor *minor); +#endif + #endif --- base-commit: c7a472297169156252a50d76965eb36b081186e2 change-id: 20230721-drm-bridge-chain-debugfs-0bbc1522f57a Best regards, -- Tomi Valkeinen

Re: [Intel-gfx] [PATCH v7 2/9] drm/i915: Add the has_aux_ccs device property

2023-07-21 Thread Andrzej Hajda
On 20.07.2023 23:07, Andi Shyti wrote: We always assumed that a device might either have AUX or FLAT CCS, but this is an approximation that is not always true as it requires some further per device checks. Add the "has_aux_ccs" flag in the intel_device_info structure in order to have a per

[GIT PULL] fbdev fixes and cleanups for v6.5-rc3

2023-07-21 Thread Helge Deller
Hi Linus, please pull some fbdev fixes & cleanups for kernel 6.5-rc3. Just the usual bunch of code cleanups in various drivers, this time mostly in vgacon and imxfb. Thanks! Helge -- The following changes since commit 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5: Linux 6.5-rc1

[PATCH] drm/radeon: ERROR: "foo * bar" should be "foo *bar"

2023-07-21 Thread sunran001
Fix two occurrences of the checkpatch.pl error: ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Jianghui Xu --- drivers/gpu/drm/radeon/atom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/atom.c b/drivers/gpu/drm/radeon/atom.c index

Re: [PATCH v4] drm: adv7511: Fix low refresh rate register for ADV7533/5

2023-07-21 Thread Robert Foss
On Wed, 19 Jul 2023 09:01:43 +0300, Alexandru Ardelean wrote: > From: Bogdan Togorean > > For ADV7533 and ADV7535 low refresh rate is selected using > bits [3:2] of 0x4a main register. > So depending on ADV model write 0xfb or 0x4a register. > > > [...] Applied, thanks! [1/1] drm: adv7511:

Re: [v7, 7/9] drm/i915/gt: Ensure memory quiesced before invalidation for all engines

2023-07-21 Thread Krzysztofik, Janusz
Hi Andi, On Thursday, 20 July 2023 23:07:35 CEST Andi Shyti wrote: > Commit af9e423a8aae You can't use this commit ID, it is invalid (the patch you are referring to belongs to your series, then is not available in any official repository, hence no stable commit ID yet). > ("drm/i915/gt:

[Bug 217692] New: amdgpu crashes on resume from standby - amdgpu-reset-dev drm_sched_job_timedout

2023-07-21 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217692 Bug ID: 217692 Summary: amdgpu crashes on resume from standby - amdgpu-reset-dev drm_sched_job_timedout Product: Drivers Version: 2.5 Hardware: AMD OS:

[PATCH v3] backlight: gpio_backlight: Drop output gpio direction check for initial power state

2023-07-21 Thread Ying Liu
If gpio pin is in input state but backlight is currently off due to default pull downs, then initial power state is set to FB_BLANK_UNBLANK in DT boot mode with phandle link and the backlight is effectively turned on in gpio_backlight_probe(), which is undesirable according to patch description of

[PATCH v4] backlight: gpio_backlight: Drop output GPIO direction check for initial power state

2023-07-21 Thread Ying Liu
If GPIO pin is in input state but backlight is currently off due to default pull downs, then initial power state is set to FB_BLANK_UNBLANK in DT boot mode with phandle link and the backlight is effectively turned on in gpio_backlight_probe(), which is undesirable according to patch description of

Re: [Intel-gfx] [PATCH v7 6/9] drm/i915/gt: Refactor intel_emit_pipe_control_cs() in a single function

2023-07-21 Thread Andi Shyti
On Fri, Jul 21, 2023 at 12:10:48PM +0200, Andrzej Hajda wrote: > On 20.07.2023 23:07, Andi Shyti wrote: > > Just a trivial refactoring for reducing the number of code > > duplicate. This will come at handy in the next commits. > > > > Signed-off-by: Andi Shyti > > Cc: # v5.8+ > > --- > >

Re: [v7,9/9] drm/i915/gt: Support aux invalidation on all engines

2023-07-21 Thread Krzysztofik, Janusz
Hi Andi, On Thursday, 20 July 2023 23:07:37 CEST Andi Shyti wrote: > Perform some refactoring with the purpose of keeping in one > single place all the operations around the aux table > invalidation. > > With this refactoring add more engines where the invalidation > should be performed. > >

Re: [PATCH] drm/syncobj: add DRM_IOCTL_SYNCOBJ_IMPORT/EXPORT_SYNC_FILE

2023-07-21 Thread Simon Ser
I had a look at the IGT and I'm not sure about the approach. It seems like the patch replaces occurrences of the old FLAGS_IMPORT_SYNC_FILE and FLAGS_EXPORT_SYNC_FILE plus TRANSFER with the new IOCTLs. However we still want to test the functionality of that old codepath: we need to continue to

[PATCH v2] backlight: gpio_backlight: Drop output gpio direction check for initial power state

2023-07-21 Thread Ying Liu
If gpio pin is in input state but backlight is currently off due to default pull downs, then initial power state is set to FB_BLANK_UNBLANK in DT boot mode with phandle link and the backlight is effectively turned on in gpio_backlight_probe(), which is undesirable according to patch description of

Re: [PATCH 1/1] drm/imx/ipuv-v3: Fix front porch adjustment upon hactive aligning

2023-07-21 Thread Alexander Stein
Hi, Am Mittwoch, 3. Mai 2023, 13:14:56 CEST schrieb Alexander Stein: > When hactive is not aligned to 8 pixels, it is aligned accordingly and > hfront porch needs to be reduced the same amount. Unfortunately the front > porch is set to the difference rather than reducing it. There are some >

Re: [PATCH v3 3/3] drm/komeda: Fix IS_ERR() vs NULL check in komeda_component_get_avail_scaler()

2023-07-21 Thread Liviu Dudau
Hi Gaosheng, On Fri, Jul 14, 2023 at 09:48:20AM +0800, Gaosheng Cui wrote: > The komeda_pipeline_get_state() returns an ERR_PTR() on failure, we should > use IS_ERR() to check the return value. > > Fixes: 502932a03fce ("drm/komeda: Add the initial scaler support for CORE") > Signed-off-by:

[Bug 217690] consistent amdgpu failures on Lenovo ThinkPad Z16: "[drm:amdgpu_dm_process_dmub_aux_transfer_sync [amdgpu]] *ERROR* wait_for_completion_timeout timeout!"

2023-07-21 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217690 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED

Re: [v7,9/9] drm/i915/gt: Support aux invalidation on all engines

2023-07-21 Thread Andi Shyti
Hi Janusz, > > diff --git a/drivers/gpu/drm/i915/gt/gen8_engine_cs.c > > b/drivers/gpu/drm/i915/gt/gen8_engine_cs.c > > index 3ded597f002a2..30fb4e0af6134 100644 > > --- a/drivers/gpu/drm/i915/gt/gen8_engine_cs.c > > +++ b/drivers/gpu/drm/i915/gt/gen8_engine_cs.c > > @@ -165,9 +165,36 @@ static

Patch "drm/ttm: Don't leak a resource on swapout move error" has been added to the 5.15-stable tree

2023-07-21 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/ttm: Don't leak a resource on swapout move error to the 5.15-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Re: [PATCH v2 1/9] vgacon: rework Kconfig dependencies

2023-07-21 Thread Arnd Bergmann
On Fri, Jul 21, 2023, at 06:59, Michael Ellerman wrote: > Arnd Bergmann writes: >> From: Arnd Bergmann >> >> The list of dependencies here is phrased as an opt-out, but this is missing >> a lot of architectures that don't actually support VGA consoles, and some >> of the entries are stale: >> >>

Re: [PATCH v3] backlight: gpio_backlight: Drop output gpio direction check for initial power state

2023-07-21 Thread Andy Shevchenko
On Fri, Jul 21, 2023 at 11:58 AM Ying Liu wrote: > > If gpio pin is in input state but backlight is currently off due to GPIO > default pull downs, then initial power state is set to FB_BLANK_UNBLANK > in DT boot mode with phandle link and the backlight is effectively > turned on in

Re: [PATCH] gpu/host1x: Explicitly include correct DT includes

2023-07-21 Thread Thierry Reding
On Fri, Jul 14, 2023 at 11:45:49AM -0600, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each

[PATCH -next] drm/fb-helper: Remove unused inline function drm_fb_helper_defio_init()

2023-07-21 Thread YueHaibing
Since commit 8e86dee02253 ("drm/fb-helper: Remove drm_fb_helper_defio_init() and update docs") this inline helper not used anymore. Signed-off-by: YueHaibing --- include/drm/drm_fb_helper.h | 5 - 1 file changed, 5 deletions(-) diff --git a/include/drm/drm_fb_helper.h

Re: [PATCH v3 1/2] dt-bindings: display: add bindings for pcd8544 displays

2023-07-21 Thread Viktar Simanenka
On Fri, Jul 21, 2023 at 11:42 AM Krzysztof Kozlowski wrote: > > On 20/07/2023 14:40, Viktar Simanenka wrote: > > +allOf: > > + - $ref: panel/panel-common.yaml# > > This is not a panel, is it? I can't clearly tell the difference between LCD display and panel. I've added panel-common because of

[PATCH] drm: bridge: dw_hdmi: Add cec suspend/resume functions

2023-07-21 Thread Sandor Yu
CEC interrupt status/mask and logical address registers will be reset when device enter suspend. It will cause cec fail to work after device resume. Add CEC suspend/resume functions, reinitialize logical address registers and restore interrupt status/mask registers after resume. Signed-off-by:

Re: [v7, 7/9] drm/i915/gt: Ensure memory quiesced before invalidation for all engines

2023-07-21 Thread Andi Shyti
Hi Janusz, On Fri, Jul 21, 2023 at 12:10:22PM +, Krzysztofik, Janusz wrote: > Hi Andi, > > On Thursday, 20 July 2023 23:07:35 CEST Andi Shyti wrote: > > Commit af9e423a8aae > > You can't use this commit ID, it is invalid (the patch you are referring to > belongs to your series, then is

[PATCH] drm/amd/display: set stream gamut remap matrix to MPC for DCN3+

2023-07-21 Thread Melissa Wen
dc->caps.color.mpc.gamut_remap says there is a post-blending color block for gamut remap matrix for DCN3 HW family and newer versions. However, those drivers still follow DCN10 programming that remap stream gamut_remap_matrix to DPP (pre-blending). To enable pre-blending and post-blending

[PATCH v2 1/1] drm/i915: Move abs_diff() to math.h

2023-07-21 Thread Andy Shevchenko
abs_diff() belongs to math.h. Move it there. This will allow others to use it. Signed-off-by: Andy Shevchenko --- v2: better header location on ipu-v3, converted omap-serial as well drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 1 + drivers/gpu/drm/i915/display/intel_dpll_mgr.h | 7 ---

Re: [PATCH v4] drm/ssd130x: Allocate buffers in the plane's .atomic_check callback

2023-07-21 Thread Maxime Ripard
On Fri, 21 Jul 2023 09:09:50 +0200, Javier Martinez Canillas wrote: > Geert reports that the following NULL pointer dereference happens for him > after commit 49d7d581ceaf ("drm/ssd130x: Don't allocate buffers on each > plane update"): > > [drm] Initialized ssd130x 1.0.0 20220131 for 0-003c

[RESEND 2/2] drm: fsl-dcu: enable PIXCLK on LS1021A

2023-07-21 Thread Alexander Stein
From: Matthias Schiffer The PIXCLK needs to be enabled in SCFG before accessing certain DCU registers, or the access will hang. Signed-off-by: Matthias Schiffer Signed-off-by: Alexander Stein --- drivers/gpu/drm/fsl-dcu/Kconfig | 1 + drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 14

[RESEND 1/2] drm: fsl-dcu: Use dev_err_probe

2023-07-21 Thread Alexander Stein
fsl_dcu_drm_modeset_init can return -EPROBE_DEFER, so use dev_err_probe to remove an invalid error message and add it to deferral description. Signed-off-by: Alexander Stein --- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

Re: [PATCH v3 1/2] dt-bindings: display: add bindings for pcd8544 displays

2023-07-21 Thread Krzysztof Kozlowski
On 20/07/2023 14:40, Viktar Simanenka wrote: > Add device tree binding documentation for PCD8544 LCD display controller. > > Signed-off-by: Viktar Simanenka > --- > v3:add a little more description to the exposed vendor properties >add commit message finally > v2 link: >

Re: [PATCH 5/9] drm/verisilicon: Add mode config funcs

2023-07-21 Thread Keith Zhao
On 2023/6/21 19:04, Thomas Zimmermann wrote: > Hi Keith > > Am 02.06.23 um 09:40 schrieb Keith Zhao: >> Add mode setting functions for JH7110 SoC. >> >> Signed-off-by: Keith Zhao >> --- >>   drivers/gpu/drm/verisilicon/Makefile |   1 + >>   drivers/gpu/drm/verisilicon/vs_drv.c |   3 + > >>  

Re: [PATCH] drm: Explicitly include correct DT includes

2023-07-21 Thread Thierry Reding
On Fri, Jul 14, 2023 at 11:45:34AM -0600, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each

Re: [PATCH v4] backlight: gpio_backlight: Drop output GPIO direction check for initial power state

2023-07-21 Thread a...@kernel.org
On Fri, Jul 21, 2023 at 09:29:03AM +, Ying Liu wrote: > If GPIO pin is in input state but backlight is currently off due to > default pull downs, then initial power state is set to FB_BLANK_UNBLANK > in DT boot mode with phandle link and the backlight is effectively > turned on in

Re: [PATCH v4] backlight: gpio_backlight: Drop output GPIO direction check for initial power state

2023-07-21 Thread Bartosz Golaszewski
On Fri, Jul 21, 2023 at 11:29 AM Ying Liu wrote: > > If GPIO pin is in input state but backlight is currently off due to > default pull downs, then initial power state is set to FB_BLANK_UNBLANK > in DT boot mode with phandle link and the backlight is effectively > turned on in

[PATCH v2] drm: bridge: samsung-dsim: Fix waiting for empty cmd transfer FIFO on older Exynos

2023-07-21 Thread Marek Szyprowski
Samsung DSIM used in older Exynos SoCs (like Exynos 4210, 4x12, 3250) doesn't report empty level of packer header FIFO. In case of those SoCs, use the old way of waiting for empty command tranfsfer FIFO, removed recently by commit 14806c641582 ("Drain command transfer FIFO before transfer").

Re: [v7, 6/9] drm/i915/gt: Refactor intel_emit_pipe_control_cs() in a single function

2023-07-21 Thread Krzysztofik, Janusz
Hi Andi, On Thursday, 20 July 2023 23:07:34 CEST Andi Shyti wrote: > Just a trivial refactoring for reducing the number of code > duplicate. This will come at handy in the next commits. > > Signed-off-by: Andi Shyti > Cc: # v5.8+ > --- > drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 44

Re: [PATCH 0/3] MediaTek DRM: Clean up CMDQ support and ifdefs

2023-07-21 Thread Alexandre Mergnat
On 19/07/2023 09:41, AngeloGioacchino Del Regno wrote: Il 23/06/23 14:49, Alexandre Mergnat ha scritto: On 23/06/2023 11:49, AngeloGioacchino Del Regno wrote: This series changes MediaTek CMDQ support to use the mtk-cmdq-helper functions, removing duplicated cmdq setup code in mtk-drm and

Re: [PATCH] drm/bridge: Add debugfs print for bridge chains

2023-07-21 Thread kernel test robot
Hi Tomi, kernel test robot noticed the following build errors: [auto build test ERROR on c7a472297169156252a50d76965eb36b081186e2] url: https://github.com/intel-lab-lkp/linux/commits/Tomi-Valkeinen/drm-bridge-Add-debugfs-print-for-bridge-chains/20230721-174615 base

[Bug 217692] amdgpu crashes on resume from standby - amdgpu-reset-dev drm_sched_job_timedout

2023-07-21 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217692 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED

Re: [PATCH v3] drm/i915: Refactor PAT/object cache handling

2023-07-21 Thread Matt Roper
On Thu, Jul 20, 2023 at 09:28:56PM -0700, Yang, Fei wrote: > >>> [snip] > > @@ -27,15 +28,8 @@ static bool gpu_write_needs_clflush(struct > > drm_i915_gem_object *obj) > > The code change here looks accurate, but while we're here, I have a > side question about this function

Re: [PATCH] drm/radeon: ERROR: "foo * bar" should be "foo *bar"

2023-07-21 Thread Alex Deucher
Applied. Thanks! On Fri, Jul 21, 2023 at 2:10 AM wrote: > > Fix nine occurrences of the checkpatch.pl error: > ERROR: "foo * bar" should be "foo *bar" > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/radeon/atom.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH v8 5/9] drm/i915/gt: Enable the CCS_FLUSH bit in the pipe control

2023-07-21 Thread Matt Roper
On Fri, Jul 21, 2023 at 06:15:10PM +0200, Andi Shyti wrote: > Enable the CCS_FLUSH bit 13 in the control pipe for render and > compute engines in platforms starting from Meteor Lake (BSPEC > 43904 and 47112). > > Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all > engines")

[PATCH] drm: bridge: samsung-dsim: Clean up a call to request_irq()

2023-07-21 Thread Dan Carpenter
This is calling request_threaded_irq() but the thread parameter is NULL so it's actually not a threaded irq. Which is a bit misleading. Call request_irq() instead. Signed-off-by: Dan Carpenter --- drivers/gpu/drm/bridge/samsung-dsim.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH] drm/amdgpu: open brace '{' following struct go on the same line

2023-07-21 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Jul 20, 2023 at 11:32 PM wrote: > > ERROR: open brace '{' following struct go on the same line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/inc/amdgpu_pm.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git

[PATCH v8 4/9] drm/i915/gt: Rename flags with bit_group_X according to the datasheet

2023-07-21 Thread Andi Shyti
In preparation of the next patch align with the datasheet (BSPEC 47112) with the naming of the pipe control set of flag values. The variable "flags" in gen12_emit_flush_rcs() is applied as a set of flags called Bit Group 1. Define also the Bit Group 0 as bit_group_0 where currently only

[PATCH v8 5/9] drm/i915/gt: Enable the CCS_FLUSH bit in the pipe control

2023-07-21 Thread Andi Shyti
Enable the CCS_FLUSH bit 13 in the control pipe for render and compute engines in platforms starting from Meteor Lake (BSPEC 43904 and 47112). Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Signed-off-by: Andi Shyti Cc: Jonathan Cavitt Cc: Nirmoy Das Cc: #

[PATCH v8 9/9] drm/i915/gt: Support aux invalidation on all engines

2023-07-21 Thread Andi Shyti
Perform some refactoring with the purpose of keeping in one single place all the operations around the aux table invalidation. With this refactoring add more engines where the invalidation should be performed. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines")

[PATCH v8 8/9] drm/i915/gt: Poll aux invalidation register bit on invalidation

2023-07-21 Thread Andi Shyti
From: Jonathan Cavitt For platforms that use Aux CCS, wait for aux invalidation to complete by checking the aux invalidation register bit is cleared. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Signed-off-by: Jonathan Cavitt Signed-off-by: Andi Shyti Cc:

[PATCH v8 7/9] drm/i915/gt: Ensure memory quiesced before invalidation for all engines

2023-07-21 Thread Andi Shyti
Commit af9e423a8aae ("drm/i915/gt: Ensure memory quiesced before invalidation") has made sure that the memory is quiesced before invalidating the AUX CCS table. Do it for all the other engines and not just RCS. Signed-off-by: Andi Shyti Cc: Jonathan Cavitt Cc: Matt Roper Cc: # v5.8+ ---

[PATCH v8 6/9] drm/i915/gt: Refactor intel_emit_pipe_control_cs() in a single function

2023-07-21 Thread Andi Shyti
Just a trivial refactoring for reducing the number of code duplicate. This will come at handy in the next commits. Meantime, propagate the error to the above layers if we fail to emit the pipe control. Signed-off-by: Andi Shyti Cc: # v5.8+ --- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 47

[PATCH v8 3/9] drm/i915/gt: Ensure memory quiesced before invalidation

2023-07-21 Thread Andi Shyti
From: Jonathan Cavitt All memory traffic must be quiesced before requesting an aux invalidation on platforms that use Aux CCS. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Signed-off-by: Jonathan Cavitt Signed-off-by: Andi Shyti Cc: # v5.8+ Reviewed-by:

Re: [PATCH v2] drm/syncobj: add DRM_IOCTL_SYNCOBJ_IMPORT/EXPORT_SYNC_FILE

2023-07-21 Thread Simon Ser
Reviewed-by: Simon Ser

Re: [PATCH] accel/qaic: Fix slicing memory leak

2023-07-21 Thread Markus Elfring
> Slicing configuration data from user is stored in a temporary buffer > which should be freed unconditionally. Are imperative change descriptions still preferred? See also:

Re: (subset) [PATCH v2 0/4] video: backlight: lp855x: modernize bindings

2023-07-21 Thread Thierry Reding
From: Thierry Reding On Fri, 19 May 2023 20:07:24 +0200, Artur Weber wrote: > Convert TI LP855X backlight controller bindings from TXT to YAML and, > while we're at it, rework some of the code related to PWM handling. > Also correct existing DTS files to avoid introducing new dtb_check >

Re: [PATCH] MAINTAINERS: Update Alain Volmat's email address for drm/sti

2023-07-21 Thread Philippe CORNU
On 4/19/23 08:33, Patrice CHOTARD wrote: Hi Alain On 4/16/23 22:27, Alain Volmat wrote: Update my email address for maintainer of the STi DRM driver. Signed-off-by: Alain Volmat --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS

[PATCH] drm/modes: Fix division by zero error

2023-07-21 Thread Ziqi Zhao
In the bug reported by Syzbot, the variable `den == (1 << 22)` and `mode->vscan == (1 << 10)`, causing the multiplication to overflow and accidentally make `den == 0`. To prevent any chance of overflow, we replace `num` and `den` with 64-bit unsigned integers, and explicitly check if the divisor

Re: [PATCH] drm/syncobj: add DRM_IOCTL_SYNCOBJ_IMPORT/EXPORT_SYNC_FILE

2023-07-21 Thread Erik Kurzinger
That's a fair point. With my IGT patch I don't think we would have coverage of the old path any more. I'll try to fix that somehow, and I think your suggestion of including some "invalid" cases is also a good one. Anyway, apart from that I've posted a v2 of the kernel patch addressing your

[PATCH] drm/i915/guc/slpc: Restore efficient freq earlier

2023-07-21 Thread Vinay Belgaumkar
This should be done before the soft min/max frequencies are restored. When we disable the "Ignore efficient frequency" flag, GuC does not actually bring the requested freq down to RPn. Specifically, this scenario- - ignore efficient freq set to true - reduce min to RPn (from efficient) - suspend

Re: [PATCH 1/2] drm/v3d: Avoid -Wconstant-logical-operand in nsecs_to_jiffies_timeout()

2023-07-21 Thread Nick Desaulniers
On Tue, Jul 18, 2023 at 2:44 PM Nathan Chancellor wrote: > > A proposed update to clang's -Wconstant-logical-operand to warn when the > left hand side is a constant shows the following instance in > nsecs_to_jiffies_timeout() when NSEC_PER_SEC is not a multiple of HZ, > such as CONFIG_HZ=300: > >

Re: [PATCH v2 2/2] drm/bridge: tc358767: give VSDELAY some positive value

2023-07-21 Thread Marek Vasut
On 7/21/23 18:53, Lucas Stach wrote: From: David Jander The documentation is not clear about how this delay works. Empirical tests have shown that with a VSDELAY of 0, the first scanline is not properly formatted in the output stream when DSI->DP mode is used. The calculation spreadsheets from

Re: [PATCH v2] drm: bridge: samsung-dsim: Fix waiting for empty cmd transfer FIFO on older Exynos

2023-07-21 Thread Marek Vasut
On 7/21/23 13:28, Marek Szyprowski wrote: Samsung DSIM used in older Exynos SoCs (like Exynos 4210, 4x12, 3250) doesn't report empty level of packer header FIFO. In case of those SoCs, use the old way of waiting for empty command tranfsfer FIFO, removed recently by commit 14806c641582 ("Drain

Re: [PATCH v5 05/11] drm/amdgpu: Use RMW accessors for changing LNKCTL

2023-07-21 Thread Alex Deucher
On Fri, Jul 21, 2023 at 4:18 AM Ilpo Järvinen wrote: > > On Thu, 20 Jul 2023, Bjorn Helgaas wrote: > > > On Mon, Jul 17, 2023 at 03:04:57PM +0300, Ilpo Järvinen wrote: > > > Don't assume that only the driver would be accessing LNKCTL. ASPM > > > policy changes can trigger write to LNKCTL outside

Re: [PATCH] drm/amd/pm: open brace '{' following struct go on the same line

2023-07-21 Thread Alex Deucher
This applied properly. Applied. Thanks! Alex On Thu, Jul 20, 2023 at 11:27 PM wrote: > > ERROR: open brace '{' following struct go on the same line > > Signed-off-by: Ran Sun > --- > .../gpu/drm/amd/pm/inc/smu_v13_0_0_pptable.h | 21 +++ > 1 file changed, 7 insertions(+),

[PATCH v2 2/2] drm/bridge: tc358767: give VSDELAY some positive value

2023-07-21 Thread Lucas Stach
From: David Jander The documentation is not clear about how this delay works. Empirical tests have shown that with a VSDELAY of 0, the first scanline is not properly formatted in the output stream when DSI->DP mode is used. The calculation spreadsheets from Toshiba seem to always make this value

[PATCH v2 1/2] drm/bridge: tc358767: increase PLL lock time delay

2023-07-21 Thread Lucas Stach
From: David Jander The PLL often fails to lock with this delay. The new value was determined by trial and error increasing the delay bit by bit until the error did not occurr anymore even after several tries. Then double that value was taken as the minimum delay to be safe. Signed-off-by: David

[PATCH 6.1 155/223] drm/ttm: Dont leak a resource on swapout move error

2023-07-21 Thread Greg Kroah-Hartman
From: Thomas Hellström commit a590f03d8de7c4cb7ce4916dc7f2fd10711faabe upstream. If moving the bo to system for swapout failed, we were leaking a resource. Fix. Fixes: bfa3357ef9ab ("drm/ttm: allocate resource object instead of embedding it v2") Cc: Christian König Cc: "Christian König" Cc:

[PATCH v2] drm/bridge: Add debugfs print for bridge chains

2023-07-21 Thread Tomi Valkeinen
when !CONFIG_OF - Link to v1: https://lore.kernel.org/r/20230721-drm-bridge-chain-debugfs-v1-1-8614ff7e8...@ideasonboard.com --- drivers/gpu/drm/drm_bridge.c | 50 +++ drivers/gpu/drm/drm_debugfs.c | 3 +++ include/drm/drm_bridge.h | 5 + 3 files

[PATCH v8 1/9] drm/i915/gt: Cleanup aux invalidation registers

2023-07-21 Thread Andi Shyti
Fix the 'NV' definition postfix that is supposed to be INV. Take the chance to also order properly the registers based on their address and call the GEN12_GFX_CCS_AUX_INV address as GEN12_CCS_AUX_INV like all the other similar registers. Remove also VD1, VD3 and VE1 registers that don't exist

[PATCH v8 2/9] drm/i915: Add the gen12_needs_ccs_aux_inv helper

2023-07-21 Thread Andi Shyti
We always assumed that a device might either have AUX or FLAT CCS, but this is an approximation that is not always true, e.g. PVC represents an exception. Set the basis for future finer selection by implementing a boolean gen12_needs_ccs_aux_inv() function that tells whether aux invalidation is

  1   2   >