Re: [PATCH 59/59] drm/ttm: rename ttm_mem_reg to ttm_resource.

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 21:41, Christian König wrote: > > Am 04.08.20 um 04:56 schrieb Dave Airlie: > > From: Dave Airlie > > > > This name better reflects what the object does. I didn't rename > > all the pointers it seemed too messy. > > > > Signed-off-by: Dave Airlie > > Acked-by: Christian

Re: [PATCH 58/59] drm/ttm: rename ttm_mem_type_manager -> ttm_resource_manager.

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 21:41, Christian König wrote: > > Am 04.08.20 um 04:56 schrieb Dave Airlie: > > From: Dave Airlie > > > > This name makes a lot more sense, since these are about managing > > driver resources rather than just memory ranges. > > > > Signed-off-by: Dave Airlie > > Acked-by:

Re: [PATCH 57/59] drm/ttm: rename bo manager to range manager.

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 21:40, Christian König wrote: > > Am 04.08.20 um 04:56 schrieb Dave Airlie: > > From: Dave Airlie > > > > The generic manager is called the range manager now, rename > > the file and some internals. > > > > Signed-off-by: Dave Airlie > > Reviewed-by: Christian König

Re: [PATCH 56/59] drm/ttm: add a wrapper for checking if manager is in use

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 21:38, Christian König wrote: > > Am 04.08.20 um 04:56 schrieb Dave Airlie: > > From: Dave Airlie > > > > This converts vmwgfx over to using an interface to set the > > in use and check the in use flag. > > > > Signed-off-by: Dave Airlie > > Reviewed-by: Christian König

Re: [PATCH 55/59] drm/ttm: drop type manager has_type

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 21:38, Christian König wrote: > > Am 04.08.20 um 04:56 schrieb Dave Airlie: > > From: Dave Airlie > > > > under driver control, this flag isn't needed anymore, > > remove the API that used to access it, and consoldiate > > with the used api. > > > > Signed-off-by: Dave

Re: [PATCH 53/59] drm/ttm: drop man->bdev link.

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 12:58, Dave Airlie wrote: > > From: Dave Airlie > > This link isn't needed anymore, drop it from the init interface. > > Signed-off-by: Dave Airlie Reviewed-by: Ben Skeggs > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 2 +- >

Re: [PATCH 54/59] drm/ttm: drop list of memory managers from device. (v2)

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 21:37, Christian König wrote: > > Am 04.08.20 um 04:56 schrieb Dave Airlie: > > From: Dave Airlie > > > > The driver now controls these, the core just controls the system > > memory one. > > > > v2: init sysman explicitly and assign it as a driver manager > > to simplify

Re: [PATCH 51/59] drm/ttm: drop priv pointer in memory manager

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 12:58, Dave Airlie wrote: > > From: Dave Airlie > > This isn't needed anymore by any drivers. > > Reviewed-by: Christian König > Signed-off-by: Dave Airlie Reviewed-by: Ben Skeggs > --- > include/drm/ttm/ttm_bo_driver.h | 2 -- > 1 file changed, 2 deletions(-) > > diff

Re: [PATCH 50/59] drm/nouveau/ttm: move to driver allocated manager

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 12:58, Dave Airlie wrote: > > From: Dave Airlie > > Signed-off-by: Dave Airlie Reviewed-by: Ben Skeggs > --- > drivers/gpu/drm/nouveau/nouveau_ttm.c | 45 +++ > 1 file changed, 32 insertions(+), 13 deletions(-) > > diff --git

Re: [PATCH 47/59] drm/ttm: move range manager to subclassed driver allocation

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 12:58, Dave Airlie wrote: > > From: Dave Airlie > > Reviewed-by: Christian König > Signed-off-by: Dave Airlie Reviewed-by: Ben Skeggs > --- > drivers/gpu/drm/ttm/ttm_bo_manager.c | 31 +--- > 1 file changed, 19 insertions(+), 12 deletions(-) > >

Re: [PATCH 46/59] drm/ttm: make ttm_range_man_init/takedown take type + args

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 21:35, Christian König wrote: > > Am 04.08.20 um 04:56 schrieb Dave Airlie: > > From: Dave Airlie > > > > This makes it easier to move these to a driver allocated system > > > > Signed-off-by: Dave Airlie > > Reviewed-by: Christian König Reviewed-by: Ben Skeggs > > >

Re: [PATCH 44/59] drm/ttm: allow drivers to provide their own manager subclasses

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 21:30, Christian König wrote: > > Am 04.08.20 um 04:56 schrieb Dave Airlie: > > From: Dave Airlie > > > > This will get removed eventually and all drivers will use this. > > > > Signed-off-by: Dave Airlie > > Reviewed-by: Christian König Reviewed-by: Ben Skeggs > > >

Re: [PATCH 43/59] drm/ttm: rename manager variable to make sure wrapper is used.

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 21:30, Christian König wrote: > > Am 04.08.20 um 04:56 schrieb Dave Airlie: > > From: Dave Airlie > > > > Other users of this should notice this change and switch to wrapper. > > > > Signed-off-by: Dave Airlie > > Reviewed-by: Christian König Reviewed-by: Ben Skeggs > >

Re: [PATCH 36/59] drm/ttm: add wrapper to get manager from bdev.

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 21:25, Christian König wrote: > > Am 04.08.20 um 04:56 schrieb Dave Airlie: > > From: Dave Airlie > > > > This will allow different abstractions later. > > > > Signed-off-by: Dave Airlie > > Acked-by: Christian König Reviewed-by: Ben Skeggs > > > --- > >

Re: [PATCH 39/59] drm/nouveau/ttm: use wrapper to access memory managers

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 12:58, Dave Airlie wrote: > > From: Dave Airlie > > Signed-off-by: Dave Airlie Reviewed-by: Ben Skeggs > --- > drivers/gpu/drm/nouveau/nouveau_ttm.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nouveau_ttm.c >

Re: [PATCH 35/59] drm/ttm: make TTM responsible for cleaning system only.

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 12:58, Dave Airlie wrote: > > From: Dave Airlie > > Drivers should all be cleaning up their memory managers > themselves now, so let the core just clean the system one up. > > Remove the legacy cleaning interface. > > Reviewed-by: Christian König > Signed-off-by: Dave

Re: [PATCH 34/59] drm/ttm: remove range manager legacy takedown path

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 12:58, Dave Airlie wrote: > > From: Dave Airlie > > Now all drivers have been converted, drop the non-driver path. > > Reviewed-by: Christian König > Signed-off-by: Dave Airlie Reviewed-by: Ben Skeggs > --- > drivers/gpu/drm/ttm/ttm_bo_manager.c | 28

Re: [PATCH 30/59] drm/nouveau: use new cleanup paths

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 12:58, Dave Airlie wrote: > > From: Dave Airlie > > Signed-off-by: Dave Airlie Reviewed-by: Ben Skeggs > --- > drivers/gpu/drm/nouveau/nouveau_ttm.c | 41 --- > 1 file changed, 30 insertions(+), 11 deletions(-) > > diff --git

Re: [PATCH 26/59] drm/ttm: start allowing drivers to use new takedown path (v2)

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 21:20, Christian König wrote: > > Am 04.08.20 um 04:55 schrieb Dave Airlie: > > From: Dave Airlie > > > > Allow the takedown path callback to be optional as well. > > > > v2: use fini for range manager > > Signed-off-by: Dave Airlie > > Reviewed-by: Christian König

Re: [PATCH 25/59] drm/ttm: make some inline helper functions for cleanup paths. (v2)

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 21:18, Christian König wrote: > > Am 04.08.20 um 04:55 schrieb Dave Airlie: > > From: Dave Airlie > > > > The disable path is just temporary for now, it will be dropped once has_type > > is gone in a later patch. > > > > v2: add docs. > > rename to ttm_mem_type_manager

Re: [PATCH 24/59] drm/ttm: pass man around instead of mem_type in some places

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 12:57, Dave Airlie wrote: > > From: Dave Airlie > > This makes it easier to cleanup things > > Reviewed-by: Christian König > Signed-off-by: Dave Airlie Reviewed-by: Ben Skeggs > --- > drivers/gpu/drm/ttm/ttm_bo.c | 14 ++ > 1 file changed, 6 insertions(+),

Re: [PATCH 23/59] drm/ttm: purge old manager init path.

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 12:57, Dave Airlie wrote: > > From: Dave Airlie > > Reviewed-by: Christian König > Signed-off-by: Dave Airlie Reviewed-by: Ben Skeggs > --- > drivers/gpu/drm/ttm/ttm_bo.c | 19 -- > drivers/gpu/drm/ttm/ttm_bo_manager.c | 29

Re: [PATCH 22/59] drm/ttm: convert system manager init to new code.

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 12:57, Dave Airlie wrote: > > From: Dave Airlie > > Remove the exit path, since this can't fail now. > > Reviewed-by: Christian König > Signed-off-by: Dave Airlie Reviewed-by: Ben Skeggs > --- > drivers/gpu/drm/ttm/ttm_bo.c | 30 +- > 1 file

Re: [PATCH 19/59] drm/nouveau: use new memory manager init paths

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 12:57, Dave Airlie wrote: > > From: Dave Airlie > > Signed-off-by: Dave Airlie Reviewed-by: Ben Skeggs > --- > drivers/gpu/drm/nouveau/nouveau_ttm.c | 43 --- > 1 file changed, 19 insertions(+), 24 deletions(-) > > diff --git

Re: [PATCH 09/59] drm/nouveau/ttm: don't fill in blank ttm debug callback

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 12:57, Dave Airlie wrote: > > From: Dave Airlie > > Acked-by: Christian König > Signed-off-by: Dave Airlie Reviewed-by: Ben Skeggs > --- > drivers/gpu/drm/nouveau/nouveau_ttm.c | 9 - > 1 file changed, 9 deletions(-) > > diff --git

Re: [PATCH 08/59] drm/ttm: export memory type debug entrypoint.

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 20:35, Christian König wrote: > > Am 04.08.20 um 04:55 schrieb Dave Airlie: > > From: Dave Airlie > > > > As suggested on review, just export the memory type debug for > > drivers to use, while also making the debug callback optional > > (don't need to test for system as it

Re: [PATCH 06/59] drm/ttm: use a helper for unlocked moves to the lru tail

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 20:34, Christian König wrote: > > Am 04.08.20 um 04:55 schrieb Dave Airlie: > > From: Dave Airlie > > > > The pattern was repeated a few times, just make an inline for it. > > > > Signed-off-by: Dave Airlie > > Reviewed-by: Christian König Reviewed-by: Ben Skeggs > > >

Re: [PATCH 03/59] nouveau: use ttm populate mapping functions. (v2)

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 12:57, Dave Airlie wrote: > > From: Dave Airlie > > Instead of rolling driver copies of them. > > v2: cleanup return handling (Ben) > Signed-off-by: Dave Airlie Reviewed-by: Ben Skeggs > --- > drivers/gpu/drm/nouveau/nouveau_bo.c | 38 ++-- > 1

Re: linux-next: manual merge of the kspp tree with the drm-misc tree

2020-08-04 Thread Stephen Rothwell
Hi all, On Fri, 3 Jul 2020 14:35:50 +1000 Stephen Rothwell wrote: > > Today's linux-next merge of the kspp tree got a conflict in: > > drivers/gpu/drm/drm_edid.c > > between commit: > > 948de84233d3 ("drm : Insert blank lines after declarations.") > > from the drm-misc tree and commit:

Re: [PATCH v4 1/6] dt-bindings: mediatek: add mt7623 display-nodes

2020-08-04 Thread Chun-Kuang Hu
Frank Wunderlich 於 2020年8月5日 週三 上午12:56寫道: > > From: Frank Wunderlich > > mt7623 uses mt2701/mt8173 for drm, but have own compatibles Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Frank Wunderlich > --- > .../devicetree/bindings/display/mediatek/mediatek,disp.txt| 2 +- >

Re: [PATCH v4 2/6] drm/mediatek: add ddp routing for mt7623

2020-08-04 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月5日 週三 上午12:56寫道: > > From: Frank Wunderlich > > on BPi-R2/mt7623 main-path have to be routed to DPI0 (hdmi) instead of DSI0 > using compatible "mt7623-mmsys" already defined in dts Reviewed-by: Chun-Kuang Hu > > Signed-off-by: Frank Wunderlich > --- >

Re: [PATCH] drm/amd/display: Fix wrong return value in dm_update_plane_state()

2020-08-04 Thread Alex Deucher
On Mon, Aug 3, 2020 at 4:21 AM Tianjia Zhang wrote: > > On an error exit path, a negative error code should be returned > instead of a positive return value. > > Fixes: 9e869063b0021 ("drm/amd/display: Move iteration out of > dm_update_planes") > Cc: Leo Li > Signed-off-by: Tianjia Zhang

[Bug 208811] AMDGPU on-load null pointer dereference

2020-08-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208811 --- Comment #6 from R0b0t1 (s...@aeam.us) --- To clarify, there is one machine with an APU (3700U) and one machine with a GPU (RX 5700XT). I have a machine with an older Picasso APU that works on 5.4.48. I am unsure if it is a regression, but I

[Bug 208811] AMDGPU on-load null pointer dereference

2020-08-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208811 --- Comment #5 from R0b0t1 (s...@aeam.us) --- Created attachment 290777 --> https://bugzilla.kernel.org/attachment.cgi?id=290777=edit dmesg 5.4.48 APU -- You are receiving this mail because: You are watching the assignee of the bug.

[Bug 208811] AMDGPU on-load null pointer dereference

2020-08-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208811 --- Comment #4 from R0b0t1 (s...@aeam.us) --- Created attachment 290775 --> https://bugzilla.kernel.org/attachment.cgi?id=290775=edit dmesg 5.4.48 GPU -- You are receiving this mail because: You are watching the assignee of the bug.

[Bug 208811] AMDGPU on-load null pointer dereference

2020-08-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208811 --- Comment #3 from R0b0t1 (s...@aeam.us) --- Created attachment 290773 --> https://bugzilla.kernel.org/attachment.cgi?id=290773=edit dmesg 5.8 APU -- You are receiving this mail because: You are watching the assignee of the bug.

[Bug 208811] AMDGPU on-load null pointer dereference

2020-08-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208811 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC|

[PATCH 5/8] drm/amd/display: Refactor surface tiling setup.

2020-08-04 Thread Bas Nieuwenhuizen
Prepare for inserting modifiers based configuration, while sharing a bunch of DCC validation & initializing the device-based configuration. Signed-off-by: Bas Nieuwenhuizen --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 209 ++ 1 file changed, 116 insertions(+), 93

[PATCH 8/8] drm/amd/display: Expose modifiers.

2020-08-04 Thread Bas Nieuwenhuizen
This expose modifier support on GFX9+. Only modifiers that can be rendered on the current GPU are added. This is to reduce the number of modifiers exposed. The HW could expose more, but the best mechanism to decide what to expose without an explosion in modifiers is still to be decided, and in

[PATCH 4/8] drm/fourcc: Add AMD DRM modifiers.

2020-08-04 Thread Bas Nieuwenhuizen
This adds modifiers for GFX9+ AMD GPUs. As the modifiers need a lot of parameters I split things out in getters and setters. - Advantage: simplifies the code a lot - Disadvantage: Makes it harder to check that you're setting all the required fields. The tiling modes seem to

[PATCH 7/8] drm/amd/display: Add formats for DCC with 2/3 planes.

2020-08-04 Thread Bas Nieuwenhuizen
For DCC we will use 2/3 planes to avoid X rendering to the frontbuffer with DCC compressed images. To make this work with the core KMS validation we need to add extra formats with the extra planes. However, due to flexibility we set bpp = 0 for the extra planes and do the validation ourselves.

[PATCH 2/8] drm/amd: Init modifier field of helper fb.

2020-08-04 Thread Bas Nieuwenhuizen
Otherwise the field ends up being used uninitialized when enabling modifiers, failing validation with high likelihood. Signed-off-by: Bas Nieuwenhuizen --- drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 3/8] drm/amd/display: Honor the offset for plane 0.

2020-08-04 Thread Bas Nieuwenhuizen
With modifiers I'd like to support non-dedicated buffers for images. Signed-off-by: Bas Nieuwenhuizen --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

[PATCH 1/8] drm/amd/display: Do not silently accept DCC for multiplane formats.

2020-08-04 Thread Bas Nieuwenhuizen
Silently accepting it could result in corruption. Signed-off-by: Bas Nieuwenhuizen --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

[PATCH 6/8] drm/amd/display: Set DC options from modifiers.

2020-08-04 Thread Bas Nieuwenhuizen
This sets the DC tiling options from the modifier, if modifiers are used for the FB. This patch by itself does not expose the support yet though. There is not much validation yet to limit the scope of this patch, but the current validation is at the same level as the BO metadata path.

[PATCH 0/8] amd/display: Add GFX9+ modifier support.

2020-08-04 Thread Bas Nieuwenhuizen
This adds modifier support to radeonsi. It has been tested on - VEGA10, RAVEN, NAVI14 - weston, sway, X with xf86-video-amdgpu (i.e. legacy path still works) and includes some basic testing of the layout code. The main goal is to keep it somewhat simple and regression free, so on the display

Re: [PATCH v1 14/22] drm/panel: sony-acx424akp: Backlight update

2020-08-04 Thread Linus Walleij
On Sun, Aug 2, 2020 at 1:07 PM Sam Ravnborg wrote: > - Use get method to read brightness > - Use drm_panel support for backlight > - This drops enable/disable operations as they are no longer needed. > The enable/disable operations had some backlight related comments > that are no

Re: [PATCH v1 08/22] drm/panel: novatek-nt35510: Backlight update

2020-08-04 Thread Linus Walleij
On Sun, Aug 2, 2020 at 1:07 PM Sam Ravnborg wrote: > - Replace direct access to backlight_properties with > backlight_get_brightness(). > - Drop debug printout > - Use macro for initialization > > Signed-off-by: Sam Ravnborg > Cc: Linus Walleij > Cc: Thierry Reding > Cc: Sam Ravnborg

[Bug 208811] AMDGPU on-load null pointer dereference

2020-08-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208811 --- Comment #1 from R0b0t1 (s...@aeam.us) --- 5.4.48 [ 77.383336] [drm] amdgpu kernel modesetting enabled. [ 77.383382] amdgpu :03:00.0: remove_conflicting_pci_framebuffers: bar 0: 0xe000 -> 0xefff [ 77.383383] amdgpu

Re: SOLVED, gma500: monitor-dependent failure to boot FB console (psbdrmfb)

2020-08-04 Thread Thierry Moreau
Good news: Solved by upgrading the kernel from 4.19.48 to 4.19.136 (the latest in the 4.19 series). Thanks for the hint that the work on gma500 has, in a sense, come to an end, reminding me that the latest kernel tarballs come with a long history of bug chasing efforts. Another strange

[Bug 208811] New: AMDGPU on-load null pointer dereference

2020-08-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208811 Bug ID: 208811 Summary: AMDGPU on-load null pointer dereference Product: Drivers Version: 2.5 Kernel Version: 5.8.0 Hardware: Intel OS: Linux Tree: Mainline

Re: [PATCH 0/3] drm/amd/display: Constify static resource_funcs

2020-08-04 Thread Alex Deucher
Applied the series. Thanks! Alex On Tue, Aug 4, 2020 at 4:08 PM Rikard Falkeborn wrote: > > Constify a couple of instances of resource_funcs that are never > modified to allow the compiler to put it in read-only memory. > > The other drivers in drivers/gpu/drm/amd/display/dc already have >

Re: [PATCH 2/2] dmabuf/tracing: Add dma-buf trace events

2020-08-04 Thread Daniel Vetter
On Tue, Aug 4, 2020 at 12:28 AM Al Viro wrote: > > On Mon, Aug 03, 2020 at 09:22:53AM -0700, Suren Baghdasaryan wrote: > > On Mon, Aug 3, 2020 at 9:12 AM Matthew Wilcox wrote: > > > > > > On Mon, Aug 03, 2020 at 09:00:00AM -0700, Suren Baghdasaryan wrote: > > > > On Mon, Aug 3, 2020 at 8:41 AM

[Bug 203905] amdgpu:actual_brightness has unreal/wrong value

2020-08-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=203905 --- Comment #11 from Alexander Monakov (amona...@gmail.com) --- v2 patch: https://lore.kernel.org/lkml/20200804201313.6464-1-amona...@ispras.ru/ -- You are receiving this mail because: You are watching the assignee of the bug.

Re: [PATCH v1 03/22] backlight: Add get/set operations for brightness/power properties

2020-08-04 Thread Sam Ravnborg
Hi Daniel et al. On Tue, Aug 04, 2020 at 06:43:30PM +0200, dan...@ffwll.ch wrote: > On Sun, Aug 02, 2020 at 01:06:17PM +0200, Sam Ravnborg wrote: > > Add get and set operations to incapsualte access to backlight properties. > > > > One easy win is that the get/set operatiosn can be used when

Re: [v1] drm/msm/dpu: update reservations in commit path

2020-08-04 Thread Rob Clark
On Tue, Aug 4, 2020 at 4:32 AM Kalyan Thota wrote: > > DPU resources reserved in the atomic_check path gets unwinded > during modeset operation before commit happens in a non seamless > transition. > > Update the reservations in the commit path to avoid resource > failures. Secondly have dummy

Re: [PATCH 8/8] modules: inherit TAINT_PROPRIETARY_MODULE

2020-08-04 Thread daniel
On Thu, Jul 30, 2020 at 08:10:27AM +0200, Christoph Hellwig wrote: > If a TAINT_PROPRIETARY_MODULE exports symbol, inherit the taint flag > for all modules importing these symbols, and don't allow loading > symbols from TAINT_PROPRIETARY_MODULE modules if the module previously > imported gplonly

Re: Aw: Re: [PATCH v4 6/6] arm: dts: mt7623: add display subsystem related device nodes

2020-08-04 Thread David Woodhouse
On Tue, 2020-08-04 at 19:40 +0200, Frank Wunderlich wrote: > > Gesendet: Dienstag, 04. August 2020 um 19:24 Uhr > > Von: "David Woodhouse" > > > + mipi_tx0: mipi-dphy@1001 { > > > + compatible = "mediatek,mt7623-mipi-tx", > > > + "mediatek,mt2701-mipi-tx"; > > > +

NAK: [PATCH][next] drm/amd/display: fix spelling mistake "Usupported" -> "Unsupported"

2020-08-04 Thread Colin Ian King
On 04/08/2020 18:34, Colin King wrote: > From: Colin Ian King > > There are spelling mistakes in two DRM_ERROR error messages. Fix them. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >

[PATCH][next] drm/amd/display: fix spelling mistake "Usupported" -> "Unsupported"

2020-08-04 Thread Colin King
From: Colin Ian King There are spelling mistakes in two DRM_ERROR error messages. Fix them. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH RFC v6 0/6] Add Unisoc's drm kms module

2020-08-04 Thread Rob Herring
On Tue, Jul 28, 2020 at 4:12 AM Daniel Vetter wrote: > > On Tue, Jul 28, 2020 at 12:08 PM Kevin Tang wrote: > > > > From: Kevin Tang > > Hm still no ack for dt bindings? We need that for merging. If it's not sent to the DT list so it gets into patchwork that's never going to happen. Nor are

Re: [PATCH v4 6/6] arm: dts: mt7623: add display subsystem related device nodes

2020-08-04 Thread David Woodhouse
On Tue, 2020-08-04 at 18:55 +0200, Frank Wunderlich wrote: > From: Ryder Lee > > Add display subsystem related device nodes for MT7623. > > Cc: CK Hu > Signed-off-by: chunhui dai > Signed-off-by: Bibby Hsieh > Signed-off-by: Ryder Lee > Signed-off-by: Frank Wunderlich > Tested-by: Frank

Re: [PATCH v4 1/6] dt-bindings: mediatek: add mt7623 display-nodes

2020-08-04 Thread Rob Herring
On Tue, Aug 4, 2020 at 11:19 AM Frank Wunderlich wrote: > > CC Rob Herring and devicetree-list Resend or it is not in my patchwork queue. But this is simple enough: Acked-by: Rob Herring > > > Gesendet: Dienstag, 04. August 2020 um 18:55 Uhr > > Von: "Frank Wunderlich" > > An:

Re: gma500: monitor-dependent failure to boot FB console (psbdrmfb)

2020-08-04 Thread daniel
On Tue, Aug 04, 2020 at 01:43:29AM +, Thierry Moreau wrote: > Dear kernel / GPU enthusiasts! > > This list is listed in the kernel MAINTAINERS file for GMA500 GPU kernel > module. Just to avoid disappointment later on: For the gma500 driver it's essentially unmaintained, but we do take

Re: [PATCH v1 15/22] drm/panel: sony-acx565akm: Backlight update

2020-08-04 Thread daniel
On Sun, Aug 02, 2020 at 01:06:29PM +0200, Sam Ravnborg wrote: > - Use backlight_get_brightness() helper > - Use backlight_is_blank() helper > - Use macro for initialization > - Drop direct access to backlight properties > - Use the devm_ variant for registering backlight device, and drop > all

Re: [PATCH v1 10/22] drm/panel: raydium-rm67191: Backlight update

2020-08-04 Thread daniel
On Sun, Aug 02, 2020 at 01:06:24PM +0200, Sam Ravnborg wrote: > - Replace direct access to backlight_properties with > backlight_get_brightness(). > - Use macro for initialization > > Signed-off-by: Sam Ravnborg > Cc: Robert Chiras > Cc: Thierry Reding > Cc: Sam Ravnborg > --- >

Re: [PATCH v1 06/22] drm/panel: asus-z00t-tm5p5-n35596: Backlight update

2020-08-04 Thread daniel
On Sun, Aug 02, 2020 at 01:06:20PM +0200, Sam Ravnborg wrote: > Update backlight to use macro for initialization and the > backlight_get_brightness() operation to simply the update operation. > > Signed-off-by: Sam Ravnborg > Cc: Konrad Dybcio > Cc: Thierry Reding > Cc: Sam Ravnborg > --- >

Re: [RFC PATCH v1 0/22] backlight: add init macros and accessors

2020-08-04 Thread daniel
On Sun, Aug 02, 2020 at 01:06:14PM +0200, Sam Ravnborg wrote: > The backlight drivers uses several different patterns when registering > a backlight: > > - Register backlight and assign properties later > - Define a local backlight_properties variable and use memset > - Define a const

Re: [PATCH v1 03/22] backlight: Add get/set operations for brightness/power properties

2020-08-04 Thread daniel
On Sun, Aug 02, 2020 at 01:06:17PM +0200, Sam Ravnborg wrote: > Add get and set operations to incapsualte access to backlight properties. > > One easy win is that the get/set operatiosn can be used when backlight > is not included in the configuration, resulting in simpler code with > less

Re: [PATCH] drm/vkms: guarantee vblank when capturing crc

2020-08-04 Thread daniel
On Sat, Aug 01, 2020 at 03:49:29PM -0300, Melissa Wen wrote: > VKMS needs vblank interrupts enabled to capture CRC. When vblank is > disabled, tests like kms_cursor_crc and kms_pipe_crc_basic getting stuck > waiting for a capture that will not occur until vkms wakes up. This > patch ensures that

Re: [Intel-gfx] [PATCH 11/66] drm/i915: Preallocate stashes for vma page-directories

2020-08-04 Thread Daniel Vetter
On Tue, Aug 4, 2020 at 4:08 PM Chris Wilson wrote: > > Quoting Thomas Hellström (Intel) (2020-07-30 13:28:19) > > > > On 7/28/20 4:50 PM, Chris Wilson wrote: > > > > > > It's in the user critical path (the shortest path to perform their > > > sequence of operations), but it's before the dma-fence

Re: [PATCH] drm: fix drm_dp_mst_port refcount leaks in drm_dp_mst_allocate_vcpi

2020-08-04 Thread Lyude Paul
Heh, I remember this being mentioned to me way back but completely forgot to ever go fix it. Thanks for the patch! Reviewed-by: Lyude Paul This is missing a Fixes: tag though: Fixes: 1e797f556c61 ("drm/dp: Split drm_dp_mst_allocate_vcpi") Cc: # v4.12+ So I will go ahead and add that,

Re: Re: [PATCH v3 5/5] arm: dts: mt7623: add display subsystem related device nodes

2020-08-04 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月4日 週二 下午11:23寫道: > > Hi > > Except mmsys (i added in Patch #1) all mt7623-compatibles are not defined in > code and fallback (mt2701-x/mt8173-x) is used. If i add it in dt-binding, it > should be added in code too, right? or should i remove mt7623

Re: [PATCH 2/3] arm64: dts: sc7180: add bus clock to mdp node for sc7180 target

2020-08-04 Thread Rob Clark
On Thu, Jul 16, 2020 at 4:36 AM Kalyan Thota wrote: > > From: Krishna Manikandan > > Move the bus clock to mdp device node,in order > to facilitate bus band width scaling on sc7180 > target. > > The parent device MDSS will not vote for bus bw, > instead the vote will be triggered by mdp device >

Re: [PATCH 1/3] arm64: dts: sc7180: add interconnect bindings for display

2020-08-04 Thread Rob Clark
On Thu, Jul 16, 2020 at 4:36 AM Kalyan Thota wrote: > > From: Krishna Manikandan > > This change adds the interconnect bindings to the > MDSS node. This will establish Display to DDR path > for bus bandwidth voting. > > Changes in v2: > - Change in commit message(Matthias Kaehlcke) > >

Re: [PATCH 3/3] drm/msm/dpu: add support for clk and bw scaling for display

2020-08-04 Thread Rob Clark
On Thu, Jul 16, 2020 at 4:36 AM Kalyan Thota wrote: > > This change adds support to scale src clk and bandwidth as > per composition requirements. > > Interconnect registration for bw has been moved to mdp > device node from mdss to facilitate the scaling. > > Changes in v1: > - Address armv7

Re: Re: [PATCH v3 1/5] drm: mediatek: add ddp routing for mt7623

2020-08-04 Thread Chun-Kuang Hu
Frank Wunderlich 於 2020年8月4日 週二 下午10:44寫道: > > Hi, > > > Gesendet: Dienstag, 04. August 2020 um 16:34 Uhr > > Von: "Chun-Kuang Hu" > > > > -static const enum mtk_ddp_comp_id mt2712_mtk_ddp_main[] = { > > > +static enum mtk_ddp_comp_id mt2712_mtk_ddp_main[] = { > > > > Why do you remove 'const'?

Re: [PATCH v3 5/5] arm: dts: mt7623: add display subsystem related device nodes

2020-08-04 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月4日 週二 下午7:00寫道: > > From: Ryder Lee > > Add display subsystem related device nodes for MT7623. > > Cc: CK Hu > Signed-off-by: chunhui dai > Signed-off-by: Bibby Hsieh > Signed-off-by: Ryder Lee > Signed-off-by: Frank Wunderlich > Tested-by: Frank

Re: [PATCHv2 0/4] Subject: panel-dsi-cm: update bindings

2020-08-04 Thread Tomi Valkeinen
Hi Sebastian, On 16/07/2020 15:57, Sebastian Reichel wrote: > The cleanup series for omapdrm's DSI code got too big. Reviewing > this is not fun and the same goes for keeping track of the change > requests. Let's do the cleanup in smaller steps instead. This is > the first batch, which updates

Re: [PATCH 4/9] drm/msm/dsi: Add phy configuration for SDM630/636/660

2020-08-04 Thread Rob Clark
On Tue, Aug 4, 2020 at 5:09 AM Vinod Koul wrote: > > On 03-08-20, 09:06, Rob Clark wrote: > > On Mon, Aug 3, 2020 at 4:00 AM Vinod Koul wrote: > > > > > > On 26-07-20, 13:12, Konrad Dybcio wrote: > > > > These SoCs make use of the 14nm phy, but at different > > > > addresses than other 14nm

Re: [PATCH v3 4/5] drm/mediatek: dpi/dsi: change the getting possible_crtc way

2020-08-04 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月4日 週二 下午7:00寫道: > > From: Jitao Shi > > For current mediatek dsi encoder, its possible crtc is fixed in crtc > 0, and mediatek dpi encoder's possible crtc is fixed in crtc 1. In > some SoC the possible crtc is not fixed in this case, so call >

Re: [PATCH v3 3/5] drm: Add get_possible_crtc API for dpi, dsi

2020-08-04 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月4日 週二 下午7:00寫道: > > From: Stu Hsieh > > For current mediatek dsi encoder, its possible crtc is fixed in crtc > 0, and mediatek dpi encoder's possible crtc is fixed in crtc 1. In > some SoC the possible crtc is not fixed in this case, so search > pipeline

Re: [PATCH v3 1/5] drm: mediatek: add ddp routing for mt7623

2020-08-04 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月4日 週二 下午7:00寫道: > > From: Frank Wunderlich > > on BPi-R2/mt7623 main-path have to be routed to DPI0 (hdmi) instead of DSI0 > using compatible "mt7623-mmsys" already defined in dts > > Signed-off-by: Frank Wunderlich > --- >

Re: [PATCH v2 10/24] virtio_gpu: correct tags for config space fields

2020-08-04 Thread Cornelia Huck
On Mon, 3 Aug 2020 16:59:18 -0400 "Michael S. Tsirkin" wrote: > Since gpu is a modern-only device, > tag config space fields as having little endian-ness. > > Signed-off-by: Michael S. Tsirkin > --- > include/uapi/linux/virtio_gpu.h | 8 > 1 file changed, 4 insertions(+), 4

Re: [RFC][PATCH] regulator: rpi-panel: Add regulator/backlight driver for RPi panel

2020-08-04 Thread Mark Brown
On Tue, Aug 04, 2020 at 12:29:49AM +0200, Marek Vasut wrote: > On 8/3/20 9:48 PM, Mark Brown wrote: > > OK, basically I've got no real objection from a regulator point of view > > - it's not ideal but not the end of the world. > Then, how shall we proceed ? Submitting the patch properly with

[Bug 208333] Black screen with Kernel 5.8 rc1/2/3/4 with Nvidia Gtx 760 driver nouveau

2020-08-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208333 --- Comment #12 from Roberto Guerrini (robyguerr...@yahoo.it) --- With official Kernel 5.8 the bug is solved Good Work -- You are receiving this mail because: You are watching the assignee of the bug.

Re: [PATCH 13/59] drm/ttm: split the mm manager init code (v2)

2020-08-04 Thread Christian König
Am 04.08.20 um 13:07 schrieb Christian König: Am 04.08.20 um 04:55 schrieb Dave Airlie: From: Dave Airlie This will allow the driver to control the ordering here better. Eventually the old path will be removed. v2: add docs for new APIs. rename new path to

Re: [PATCH] vt: defer kfree() of vc_screenbuf in vc_do_resize()

2020-08-04 Thread Greg Kroah-Hartman
On Tue, Aug 04, 2020 at 08:15:43PM +0900, Tetsuo Handa wrote: > Do you think this approach is acceptable? Or, do we need to modify > set_origin() ? > > On 2020/07/29 23:57, Tetsuo Handa wrote: > > syzbot is reporting UAF bug in set_origin() from vc_do_resize() [1], for > > vc_do_resize() calls

[PULL] drm-misc-fixes

2020-08-04 Thread Thomas Zimmermann
Hi Dave and Daniel, here's this week's PR for drm-misc-fixes. A number of small driver and HW fixes, one in TTM, one in docs. Three of the patches don't have a Fixes tag, which a find concerning. Best regards Thomas drm-misc-fixes-2020-08-04: * backmerge from drm-fixes at v5.8-rc7 * add

Re: [PATCH] drm: omapdrm: Delete surplus GPIO includes

2020-08-04 Thread Tomi Valkeinen
On 27/06/2020 01:06, Linus Walleij wrote: > The OMAP DRM driver includes into the two > hdmi4.c and hdmi5.c files but does not use any symbols from > these files. Drop the includes. > > Cc: Tomi Valkeinen > Cc: Tony Lindgren > Cc: Jyri Sarha > Signed-off-by: Linus Walleij > --- >

Re: [PATCH v2] drm/omap: force runtime PM suspend on system suspend

2020-08-04 Thread Tomi Valkeinen
Hi, On 17/07/2020 19:28, Tony Lindgren wrote: > * Tomi Valkeinen [200618 09:53]: >> Use SET_LATE_SYSTEM_SLEEP_PM_OPS in DSS submodules to force runtime PM >> suspend and resume. >> >> We use suspend late version so that omapdrm's system suspend callback is >> called first, as that will disable

Re: [PATCH 4/9] drm/msm/dsi: Add phy configuration for SDM630/636/660

2020-08-04 Thread Vinod Koul
On 03-08-20, 09:06, Rob Clark wrote: > On Mon, Aug 3, 2020 at 4:00 AM Vinod Koul wrote: > > > > On 26-07-20, 13:12, Konrad Dybcio wrote: > > > These SoCs make use of the 14nm phy, but at different > > > addresses than other 14nm units. > > > > > > Signed-off-by: Konrad Dybcio > > > --- > > >

Re: [PATCH 59/59] drm/ttm: rename ttm_mem_reg to ttm_resource.

2020-08-04 Thread Christian König
Am 04.08.20 um 04:56 schrieb Dave Airlie: From: Dave Airlie This name better reflects what the object does. I didn't rename all the pointers it seemed too messy. Signed-off-by: Dave Airlie Acked-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 6 +--

Re: [PATCH 58/59] drm/ttm: rename ttm_mem_type_manager -> ttm_resource_manager.

2020-08-04 Thread Christian König
Am 04.08.20 um 04:56 schrieb Dave Airlie: From: Dave Airlie This name makes a lot more sense, since these are about managing driver resources rather than just memory ranges. Signed-off-by: Dave Airlie Acked-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c| 2 +-

Re: [PATCH 57/59] drm/ttm: rename bo manager to range manager.

2020-08-04 Thread Christian König
Am 04.08.20 um 04:56 schrieb Dave Airlie: From: Dave Airlie The generic manager is called the range manager now, rename the file and some internals. Signed-off-by: Dave Airlie Reviewed-by: Christian König --- drivers/gpu/drm/ttm/Makefile | 2 +-

Re: [PATCH 56/59] drm/ttm: add a wrapper for checking if manager is in use

2020-08-04 Thread Christian König
Am 04.08.20 um 04:56 schrieb Dave Airlie: From: Dave Airlie This converts vmwgfx over to using an interface to set the in use and check the in use flag. Signed-off-by: Dave Airlie Reviewed-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_ttm.c | 1 -

Re: [PATCH 55/59] drm/ttm: drop type manager has_type

2020-08-04 Thread Christian König
Am 04.08.20 um 04:56 schrieb Dave Airlie: From: Dave Airlie under driver control, this flag isn't needed anymore, remove the API that used to access it, and consoldiate with the used api. Signed-off-by: Dave Airlie Reviewed-by: Christian König ---

Re: [PATCH 54/59] drm/ttm: drop list of memory managers from device. (v2)

2020-08-04 Thread Christian König
Am 04.08.20 um 04:56 schrieb Dave Airlie: From: Dave Airlie The driver now controls these, the core just controls the system memory one. v2: init sysman explicitly and assign it as a driver manager to simplify the lookup sequence. Signed-off-by: Dave Airlie Reviewed-by: Christian König

Re: [PATCH 46/59] drm/ttm: make ttm_range_man_init/takedown take type + args

2020-08-04 Thread Christian König
Am 04.08.20 um 04:56 schrieb Dave Airlie: From: Dave Airlie This makes it easier to move these to a driver allocated system Signed-off-by: Dave Airlie Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 15 +--- drivers/gpu/drm/drm_gem_vram_helper.c |

Re: [PATCH 45/59] drm/amdgpu/ttm: use bo manager subclassing for vram/gtt mgrs

2020-08-04 Thread Christian König
Am 04.08.20 um 04:56 schrieb Dave Airlie: From: Dave Airlie Reviewed-by: Christian König Signed-off-by: Dave Airlie This one is already reviewed and can stay like this, but I had one more idea for further cleanups, see below. --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 35

  1   2   >