[PATCH v3 1/3] drm/i915/guc: Fix missing ecodes

2023-03-10 Thread John . C . Harrison
From: John Harrison Error captures are tagged with an 'ecode'. This is a pseduo-unique magic number that is meant to distinguish similar seeming bugs with different underlying signatures. It is a combination of two ring state registers. Unfortunately, the register state being used is only valid

[PATCH v3 3/3] drm/i915: Include timeline seqno in error capture

2023-03-10 Thread John . C . Harrison
From: John Harrison The seqno value actually written out to memory is no longer in the regular HWSP. Instead, it is now in its own private timeline buffer. Thus, it is no longer visible in an error capture. So, explicitly read the value and include that in the capture. v2: %d -> %u (Alan)

[PATCH v3 0/3] More error capture improvements

2023-03-10 Thread John . C . Harrison
From: John Harrison Ecodes got lost with the switch to GuC based register lists. Put them back. Seqno values got lost with the switch to per context timelines. Put those back too. v2: Rework the timeline patch to just read the single seqno value rather than copying the entire object (Daniele)

[PATCH v3 2/3] drm/i915/guc: Clean up of register capture search

2023-03-10 Thread John . C . Harrison
From: John Harrison The comparison in the search for a matching register capture node was not the most readable. It was also assuming that a zero GuC id means invalid, which it does not. So remove one invalid term, one redundant term and re-format to keep each term on a single line, and only one

RE: [PATCH v3 2/2] drm/probe_helper: warning on poll_enabled for issue catching

2023-03-10 Thread Chen, Guchun
> -Original Message- > From: Jani Nikula > Sent: Friday, March 10, 2023 8:05 PM > To: Chen, Guchun ; amd- > g...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Deucher, > Alexander ; Zhang, Hawking > ; dmitry.barysh...@linaro.org; > spassw...@web.de; m...@fireburn.co.uk > Cc:

Re: [PATCH RFC 02/18] rust: drm: Add Device and Driver abstractions

2023-03-10 Thread Boqun Feng
On Tue, Mar 07, 2023 at 11:25:27PM +0900, Asahi Lina wrote: > Add the initial abstractions for DRM drivers and devices. These go > together in one commit since they are fairly tightly coupled types. > > A few things have been stubbed out, to be implemented as further bits of > the DRM subsystem

Re: [PATCH] fbdev: Use of_property_present() for testing DT property presence

2023-03-10 Thread kernel test robot
#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Rob-Herring/fbdev-Use-of_property_present-for-testing-DT-property-presence/20230310-225754 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link: https://lore.kernel.org/r/20230310144729.1545943-1-robh

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Allow for very slow GuC loading

2023-03-10 Thread John Harrison
On 3/3/2023 11:20, Ceraolo Spurio, Daniele wrote: On 2/17/2023 3:47 PM, john.c.harri...@intel.com wrote: From: John Harrison A failure to load the GuC is occasionally observed where the GuC log actually showed that the GuC had loaded just fine. The implication being that the load just took

[PATCH] drm/i915/guc: Disable PL1 power limit when loading GuC firmware

2023-03-10 Thread Ashutosh Dixit
On dGfx, the PL1 power limit being enabled and set to a low value results in a low GPU operating freq. It also negates the freq raise operation which is done before GuC firmware load. As a result GuC firmware load can time out. Such timeouts were seen in the GL #8062 bug below (where the PL1 power

Re: [PATCH] drm/mipi-dsi: Add a mipi_dual_dsi_dcs_write_seq() macro

2023-03-10 Thread Linus Walleij
(CC Javier) On Fri, Mar 10, 2023 at 2:52 PM Jani Nikula wrote: > >> > + for (i = 0; i < ARRAY_SIZE(dsi); i++)\ > >> > + mipi_dsi_dcs_write_seq(dsi[i], cmd, seq);\ > >> > >> This ignores errors. > > mipi_dsi_dcs_write_seq is also a macro,

Re: [PATCH v2 1/2] drm/format-helper: Add Kunit tests for drm_fb_xrgb8888_to_mono()

2023-03-10 Thread kernel test robot
Hi Arthur, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.3-rc1 next-20230310

Re: [PATCH v4 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-10 Thread Linus Walleij
On Fri, Mar 10, 2023 at 7:35 PM Jianhua Lu wrote: > On Fri, Mar 10, 2023 at 07:10:21PM +0100, Konrad Dybcio wrote: > > > > > +#define mipi_dsi_dual_dcs_write_seq(dsi0, dsi1, cmd, seq...)\ > > > + do { \ > > > +

Re: [RFC v2 0/6] drm/amd/display: Pass proper parent for DM backlight device v2

2023-03-10 Thread Rodrigo Siqueira Jordao
Hi Hans, Which AMD device do you have available for testing this series? P.s.: If you have a new version of this series, could you also Cc me? Thanks for your patchset. Siqueira On 3/8/23 14:58, Hans de Goede wrote: Hi All, Here is version 2 of my patch series to pass the proper parent

[PATCH v2 2/2] drm/format-helper: Make "destination_pitch" test case usable for the monochrome case

2023-03-10 Thread Arthur Grillo
This test case uses an arbitrary pitch size, different of the default one, to test if the conversions methods obey. Change the "destination_pitch" colors to change the monochrome expected result from being just zeros, as this makes the arbitrary pitch use unusable. Signed-off-by: Arthur Grillo

[PATCH v2 1/2] drm/format-helper: Add Kunit tests for drm_fb_xrgb8888_to_mono()

2023-03-10 Thread Arthur Grillo
Extend the existing test cases to test the conversion from XRGB to monochromatic. Signed-off-by: Arthur Grillo --- .../gpu/drm/tests/drm_format_helper_test.c| 62 +++ 1 file changed, 62 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_format_helper_test.c

[PATCH v2 0/2] drm/format-helper: Add Kunit tests for drm_fb_xrgb8888_to_mono()

2023-03-10 Thread Arthur Grillo
This patchset aims to insert a unit test for the conversion from XRGB to monochromatic. Previously this was a single patch, but as the changes grew from v1 to v2, I thought it would be better to split it in two. Thanks for reviewing! Best regards, ~Arthur Grillo --- v1->v2:

Re: [PATCH drm-next v2 00/16] [RFC] DRM GPUVA Manager & Nouveau VM_BIND UAPI

2023-03-10 Thread Danilo Krummrich
On 3/10/23 18:25, Boris Brezillon wrote: Hi Danilo, On Fri, 10 Mar 2023 17:45:58 +0100 Danilo Krummrich wrote: Hi Boris, On Thu, 9 Mar 2023 10:12:43 +0100 Boris Brezillon wrote: Ok, so I just noticed you only have one bind queue per drm_file (cli->sched_entity), and jobs are executed

Re: [PATCH v3] dma-buf: cma_heap: Check for device max segment size when attaching

2023-03-10 Thread Andrew Davis
On 3/6/23 8:48 PM, John Stultz wrote: On Mon, Mar 6, 2023 at 8:52 AM Andrew Davis wrote: Although there is usually not such a limitation (and when there is it is often only because the driver forgot to change the super small default), it is still correct here to break scatterlist element into

Re: [PATCH RFC 02/18] rust: drm: Add Device and Driver abstractions

2023-03-10 Thread Boqun Feng
On Tue, Mar 07, 2023 at 11:25:27PM +0900, Asahi Lina wrote: [...] > + > +// SAFETY: `Device` only holds a pointer to a C device, which is safe to be > used from any thread. > +unsafe impl Send for Device {} > + > +// SAFETY: `Device` only holds a pointer to a C device, references to which > are

[PATCH v2] drm/amd/display: use a more accurate check in dm_helpers_dp_read_dpcd()

2023-03-10 Thread Hamza Mahfooz
We should be checking if drm_dp_dpcd_read() returns the size that we are asking it to read instead of just checking if it is greater than zero. So, compare the return value of drm_dp_dpcd_read() to the requested read size. Signed-off-by: Hamza Mahfooz --- v2: drop the WARN_ON(). ---

Re: [PATCH v4 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-10 Thread Jianhua Lu
On Fri, Mar 10, 2023 at 07:10:21PM +0100, Konrad Dybcio wrote: > > > +#define mipi_dsi_dual_dcs_write_seq(dsi0, dsi1, cmd, seq...)\ > > + do { \ > > + mipi_dsi_dcs_write_seq(dsi0, cmd, seq); \ > > +

Re: [PATCH v4 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-10 Thread Konrad Dybcio
On 10.03.2023 14:21, Jianhua Lu wrote: > Add a driver for panels using the Novatek NT36523 display driver IC. > > Signed-off-by: Jianhua Lu > --- > Changes in v4: > - add multiple modes support > - use dev_err_probe helper > - fix dsi_info type string > - reimplement

Re: [PATCH v4 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-10 Thread Jianhua Lu
On Fri, Mar 10, 2023 at 09:21:44PM +0800, Jianhua Lu wrote: > Add a driver for panels using the Novatek NT36523 display driver IC. ... > + > +static int nt36523_get_modes(struct drm_panel *panel, > +struct drm_connector *connector) > +{ > + struct panel_info *pinfo

Re: [PATCH] drm/amd/display: use a more accurate check in dm_helpers_dp_read_dpcd()

2023-03-10 Thread Ville Syrjälä
On Fri, Mar 10, 2023 at 07:48:04PM +0200, Ville Syrjälä wrote: > On Thu, Mar 09, 2023 at 04:30:27PM -0500, Hamza Mahfooz wrote: > > We should be checking if drm_dp_dpcd_read() returns the size that we are > > asking it to read instead of just checking if it is greater than zero. > > Also, we

Re: [PATCH] drm/amd/display: use a more accurate check in dm_helpers_dp_read_dpcd()

2023-03-10 Thread Ville Syrjälä
On Thu, Mar 09, 2023 at 04:30:27PM -0500, Hamza Mahfooz wrote: > We should be checking if drm_dp_dpcd_read() returns the size that we are > asking it to read instead of just checking if it is greater than zero. > Also, we should WARN_ON() here since this condition is only ever met, if > there is

Re: [PATCH] drm/amd/display: use a more accurate check in dm_helpers_dp_read_dpcd()

2023-03-10 Thread Rodrigo Siqueira Jordao
On 3/9/23 14:30, Hamza Mahfooz wrote: We should be checking if drm_dp_dpcd_read() returns the size that we are asking it to read instead of just checking if it is greater than zero. Also, we should WARN_ON() here since this condition is only ever met, if there is an issue worth investigating.

Re: [PATCH v10 01/15] dma-buf/dma-fence: Add deadline awareness

2023-03-10 Thread Rob Clark
On Fri, Mar 10, 2023 at 7:45 AM Jonas Ådahl wrote: > > On Wed, Mar 08, 2023 at 07:52:52AM -0800, Rob Clark wrote: > > From: Rob Clark > > > > Add a way to hint to the fence signaler of an upcoming deadline, such as > > vblank, which the fence waiter would prefer not to miss. This is to aid > >

Re: [git pull] drm fixes for 6.3-rc2

2023-03-10 Thread pr-tracker-bot
The pull request you sent on Fri, 10 Mar 2023 14:44:33 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-03-10 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/b0d14d2aaf7d4b36b44f5a09955ebdf9eef4b0f8 Thank you! -- Deet-doot-dot, I am a bot.

Re: [PATCH drm-next v2 00/16] [RFC] DRM GPUVA Manager & Nouveau VM_BIND UAPI

2023-03-10 Thread Boris Brezillon
Hi Danilo, On Fri, 10 Mar 2023 17:45:58 +0100 Danilo Krummrich wrote: > Hi Boris, > > On 3/9/23 10:48, Boris Brezillon wrote: > > On Thu, 9 Mar 2023 10:12:43 +0100 > > Boris Brezillon wrote: > > > >> Hi Danilo, > >> > >> On Fri, 17 Feb 2023 14:44:06 +0100 > >> Danilo Krummrich wrote: > >>

Re: [PATCH v4 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-10 Thread Neil Armstrong
Hi, On 10/03/2023 14:21, Jianhua Lu wrote: Add a driver for panels using the Novatek NT36523 display driver IC. Signed-off-by: Jianhua Lu --- Changes in v4: - add multiple modes support - use dev_err_probe helper - fix dsi_info type string - reimplement

Re: [PATCH drm-next v2 00/16] [RFC] DRM GPUVA Manager & Nouveau VM_BIND UAPI

2023-03-10 Thread Danilo Krummrich
Hi Boris, On 3/9/23 10:48, Boris Brezillon wrote: On Thu, 9 Mar 2023 10:12:43 +0100 Boris Brezillon wrote: Hi Danilo, On Fri, 17 Feb 2023 14:44:06 +0100 Danilo Krummrich wrote: Changes in V2: == Nouveau: - Reworked the Nouveau VM_BIND UAPI to avoid memory allocations

Re: [PATCH] drm: Use of_property_present() for testing DT property presence

2023-03-10 Thread Dmitry Baryshkov
On 10/03/2023 16:47, Rob Herring wrote: It is preferred to use typed property access functions (i.e. of_property_read_ functions) rather than low-level of_get_property/of_find_property functions for reading properties. As part of this, convert of_get_property/of_find_property calls to the

Re: [PATCH] drm/amdgpu: resove reboot exception for si oland

2023-03-10 Thread Lazar, Lijo
[AMD Official Use Only - General] I recall that there was a previous discussion around this and that time we found that the range is already set earlier during DPM enablement. The suspected root cause was enable/disable of thermal alert within this call to set range again. Thanks, Lijo

Re: [PATCH v10 01/15] dma-buf/dma-fence: Add deadline awareness

2023-03-10 Thread Jonas Ådahl
On Wed, Mar 08, 2023 at 07:52:52AM -0800, Rob Clark wrote: > From: Rob Clark > > Add a way to hint to the fence signaler of an upcoming deadline, such as > vblank, which the fence waiter would prefer not to miss. This is to aid > the fence signaler in making power management decisions, like

Re: [PATCH] drm/amdgpu: resove reboot exception for si oland

2023-03-10 Thread Alex Deucher
On Fri, Mar 10, 2023 at 3:18 AM Chen, Guchun wrote: > > > > -Original Message- > > From: amd-gfx On Behalf Of > > Zhenneng Li > > Sent: Friday, March 10, 2023 3:40 PM > > To: Deucher, Alexander > > Cc: David Airlie ; Pan, Xinhui ; > > linux-ker...@vger.kernel.org;

Re: [PATCH] drm: Use of_property_present() for testing DT property presence

2023-03-10 Thread Laurent Pinchart
Hi Rob, Thank you for the patch. On Fri, Mar 10, 2023 at 08:47:05AM -0600, Rob Herring wrote: > It is preferred to use typed property access functions (i.e. > of_property_read_ functions) rather than low-level > of_get_property/of_find_property functions for reading properties. As > part of

Re: [PATCH] drm: Use of_property_read_bool() for boolean properties

2023-03-10 Thread Laurent Pinchart
Hi Rob, Thank you for the patch. On Fri, Mar 10, 2023 at 08:47:05AM -0600, Rob Herring wrote: > It is preferred to use typed property access functions (i.e. > of_property_read_ functions) rather than low-level > of_get_property/of_find_property functions for reading properties. > Convert reading

[PATCH] fbdev: Use of_property_read_bool() for boolean properties

2023-03-10 Thread Rob Herring
It is preferred to use typed property access functions (i.e. of_property_read_ functions) rather than low-level of_get_property/of_find_property functions for reading properties. Convert reading boolean properties to to of_property_read_bool(). Signed-off-by: Rob Herring ---

[PATCH] fbdev: Use of_property_present() for testing DT property presence

2023-03-10 Thread Rob Herring
It is preferred to use typed property access functions (i.e. of_property_read_ functions) rather than low-level of_get_property/of_find_property functions for reading properties. As part of this, convert of_get_property/of_find_property calls to the recently added of_property_present() helper when

[PATCH] backlight: as3711: Use of_property_read_bool() for boolean properties

2023-03-10 Thread Rob Herring
It is preferred to use typed property access functions (i.e. of_property_read_ functions) rather than low-level of_get_property/of_find_property functions for reading properties. Convert reading boolean properties to to of_property_read_bool(). Signed-off-by: Rob Herring ---

[PATCH] backlight: hx8357: Use of_property_present() for testing DT property presence

2023-03-10 Thread Rob Herring
It is preferred to use typed property access functions (i.e. of_property_read_ functions) rather than low-level of_get_property/of_find_property functions for reading properties. As part of this, convert of_get_property/of_find_property calls to the recently added of_property_present() helper when

[PATCH] drm: Use of_property_present() for testing DT property presence

2023-03-10 Thread Rob Herring
It is preferred to use typed property access functions (i.e. of_property_read_ functions) rather than low-level of_get_property/of_find_property functions for reading properties. As part of this, convert of_get_property/of_find_property calls to the recently added of_property_present() helper when

[PATCH] drm: Use of_property_read_bool() for boolean properties

2023-03-10 Thread Rob Herring
It is preferred to use typed property access functions (i.e. of_property_read_ functions) rather than low-level of_get_property/of_find_property functions for reading properties. Convert reading boolean properties to to of_property_read_bool(). Signed-off-by: Rob Herring ---

Re: [PATCH v2] fbdev: Fix incorrect page mapping clearance at fb_deferred_io_release()

2023-03-10 Thread Thomas Zimmermann
Added to drm-misc-fixes. Thanks a lot for the patch. Am 08.03.23 um 11:50 schrieb Takashi Iwai: The recent fix for the deferred I/O by the commit 3efc61d95259 ("fbdev: Fix invalid page access after closing deferred I/O devices") caused a regression when the same fb device is opened/closed

[PATCH 6.1 188/200] drm/display/dp_mst: Add drm_atomic_get_old_mst_topology_state()

2023-03-10 Thread Greg Kroah-Hartman
From: Imre Deak commit 9ffdb67af0ee625ae127711845532f670cc6a4e7 upstream. Add a function to get the old MST topology state, required by a follow-up i915 patch. While at it clarify the code comment of drm_atomic_get_new_mst_topology_state() and add _new prefix to the new state pointer to remind

Re: [regression] RPI4B drm vc4: no crtc or sizes since 5.17 (works in 5.16; and still broken in at least 6.1)

2023-03-10 Thread AL13N
Dave Stevenson schreef op 2023-03-10 14:10: On Fri, 10 Mar 2023 at 12:59, AL13N wrote: I donno if this is related or not, but since 6.1 has v3d, i'm assuming the opengl compositor will be faster and not draw too much cpu? I did try youtube video, but that on 1080p fullscreen, takes all the

[PATCH 6.1 068/200] drm/i915: move a Kconfig symbol to unbreak the menu presentation

2023-03-10 Thread Greg Kroah-Hartman
From: Randy Dunlap [ Upstream commit 0b93efca3659f6d55ed31cff6722dca5f6e4d6e2 ] Inserting a Kconfig symbol that does not have a dependency (DRM_I915_GVT) into a list of other symbols that do have a dependency (on DRM_I915) breaks the driver menu presentation in 'make *config'. Relocate the

[PATCH 6.2 206/211] drm/display/dp_mst: Handle old/new payload states in drm_dp_remove_payload()

2023-03-10 Thread Greg Kroah-Hartman
From: Imre Deak commit e761cc20946a0094df71cb31a565a6a0d03bd8be upstream. Atm, drm_dp_remove_payload() uses the same payload state to both get the vc_start_slot required for the payload removal DPCD message and to deduct time_slots from vc_start_slot of all payloads after the one being removed.

[PATCH 6.2 201/211] drm/display/dp_mst: Add drm_atomic_get_old_mst_topology_state()

2023-03-10 Thread Greg Kroah-Hartman
From: Imre Deak commit 9ffdb67af0ee625ae127711845532f670cc6a4e7 upstream. Add a function to get the old MST topology state, required by a follow-up i915 patch. While at it clarify the code comment of drm_atomic_get_new_mst_topology_state() and add _new prefix to the new state pointer to remind

[PATCH 6.2 075/211] drm/i915: move a Kconfig symbol to unbreak the menu presentation

2023-03-10 Thread Greg Kroah-Hartman
From: Randy Dunlap [ Upstream commit 0b93efca3659f6d55ed31cff6722dca5f6e4d6e2 ] Inserting a Kconfig symbol that does not have a dependency (DRM_I915_GVT) into a list of other symbols that do have a dependency (on DRM_I915) breaks the driver menu presentation in 'make *config'. Relocate the

Re: [PATCH 01/22] drm/fbdev-dma: Implement fbdev emulation for GEM DMA helpers

2023-03-10 Thread Thomas Zimmermann
Hi Javier, thanks for your review. Am 09.03.23 um 12:04 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Implement fbdev emulation that is optimized for drivers that use DMA helpers. The buffers may no tbe moveable, may not require damage "may not be" Is may the correct verb

Re: [PATCH] drm/mipi-dsi: Add a mipi_dual_dsi_dcs_write_seq() macro

2023-03-10 Thread Jani Nikula
On Fri, 10 Mar 2023, Jianhua Lu wrote: > On Fri, Mar 10, 2023 at 01:54:18PM +0200, Jani Nikula wrote: >> On Fri, 10 Mar 2023, Jianhua Lu wrote: >> > The panels with two dsi connected (sync dual dsi mode) need to transmit >> > dcs command to the two dsi host simultaneously, let's add >> >

Re: [PATCH] drm/virtio: Enable fb damage clips property for the primary plane

2023-03-10 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Thomas, > Hi Javier > > Am 10.03.23 um 13:59 schrieb Javier Martinez Canillas: >> Christian Hergert reports that the driver doesn't enable the property and >> that leads to always doing a full plane update, even when the driver does >> support damage clipping for

Re: [PATCH] drm/mcde: Do not use dirty GEM FB handling

2023-03-10 Thread Thomas Zimmermann
Hi Am 09.03.23 um 09:24 schrieb Linus Walleij: This driver has no way to handle damage, the reason the drm_gem_fb_create_with_dirty() was used was because I had the ambition that the driver would only send out updates to DSI command displays whenever something changed, so as to minimize

[PATCH v4 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-10 Thread Jianhua Lu
Add a driver for panels using the Novatek NT36523 display driver IC. Signed-off-by: Jianhua Lu --- Changes in v4: - add multiple modes support - use dev_err_probe helper - fix dsi_info type string - reimplement mipi_dsi_dual_dcs_write_seq() macro Changes in v3: - Refactor source code

[PATCH v4 1/2] dt-bindings: display: panel: Add Novatek NT36523 bindings

2023-03-10 Thread Jianhua Lu
Novatek NT36523 is a display driver IC used to drive DSI panels. Signed-off-by: Jianhua Lu Reviewed-by: Krzysztof Kozlowski --- No changes in v4 Changes in v3: - pick up Krzysztof's R-b - remove vddpos and vddneg supply Changes in v2: - Drop unnecessary description - dsi0 -> dsi -

Re: [PATCH] drm/virtio: Enable fb damage clips property for the primary plane

2023-03-10 Thread Thomas Zimmermann
Hi Javier Am 10.03.23 um 13:59 schrieb Javier Martinez Canillas: Christian Hergert reports that the driver doesn't enable the property and that leads to always doing a full plane update, even when the driver does support damage clipping for the primary plane. Don't enable it for the cursor

Re: [regression] RPI4B drm vc4: no crtc or sizes since 5.17 (works in 5.16; and still broken in at least 6.1)

2023-03-10 Thread Dave Stevenson
On Fri, 10 Mar 2023 at 12:59, AL13N wrote: > > > I donno if this is related or not, but since 6.1 has v3d, i'm assuming > the opengl compositor will be faster and not draw too much cpu? > > I did try youtube video, but that on 1080p fullscreen, takes all the CPU > and seems to have dropped frames

Re: [regression] RPI4B drm vc4: no crtc or sizes since 5.17 (works in 5.16; and still broken in at least 6.1)

2023-03-10 Thread AL13N
AL13N schreef op 2023-03-10 13:38: Dave Stevenson schreef op 2023-03-09 13:59: On Wed, 8 Mar 2023 at 22:46, AL13N wrote: AL13N schreef op 2023-03-08 22:16: > Maxime Ripard schreef op 2023-03-08 13:35: >> Hi, >> >> On Tue, Mar 07, 2023 at 05:10:16PM +, Dave Stevenson wrote: >>> On Tue, 7

[PATCH] drm/virtio: Enable fb damage clips property for the primary plane

2023-03-10 Thread Javier Martinez Canillas
Christian Hergert reports that the driver doesn't enable the property and that leads to always doing a full plane update, even when the driver does support damage clipping for the primary plane. Don't enable it for the cursor plane, because its .atomic_update callback doesn't handle damage clips.

Re: [regression] RPI4B drm vc4: no crtc or sizes since 5.17 (works in 5.16; and still broken in at least 6.1)

2023-03-10 Thread Dave Stevenson
On Fri, 10 Mar 2023 at 09:10, AL13N wrote: > > Dave Stevenson schreef op 2023-03-09 13:59: > > On Wed, 8 Mar 2023 at 22:46, AL13N wrote: > >> > >> AL13N schreef op 2023-03-08 22:16: > >> > Maxime Ripard schreef op 2023-03-08 13:35: > >> >> Hi, > >> >> > >> >> On Tue, Mar 07, 2023 at 05:10:16PM

Re: [PATCH v2 000/101] fbdev: Fix memory leak in option parsing

2023-03-10 Thread Thomas Zimmermann
Hi Geert Am 10.03.23 um 09:24 schrieb Geert Uytterhoeven: Hi Thomas, On Thu, Mar 9, 2023 at 5:02 PM Thomas Zimmermann wrote: Introduce struct option_iter and helpers to parse command-line options with comma-separated key-value pairs. Then convert fbdev drivers to the new interface. Fixes a

Re: [regression] RPI4B drm vc4: no crtc or sizes since 5.17 (works in 5.16; and still broken in at least 6.1)

2023-03-10 Thread AL13N
Dave Stevenson schreef op 2023-03-09 13:59: On Wed, 8 Mar 2023 at 22:46, AL13N wrote: AL13N schreef op 2023-03-08 22:16: > Maxime Ripard schreef op 2023-03-08 13:35: >> Hi, >> >> On Tue, Mar 07, 2023 at 05:10:16PM +, Dave Stevenson wrote: >>> On Tue, 7 Mar 2023 at 16:25, AL13N wrote: >>>

Re: [PATCH v2 001/101] lib: Add option iterator

2023-03-10 Thread Thomas Zimmermann
Hi Am 10.03.23 um 09:21 schrieb Geert Uytterhoeven: Hi Thomas, On Thu, Mar 9, 2023 at 5:02 PM Thomas Zimmermann wrote: Add struct option_iter and helpers that walk over individual options of an option string. Add documentation. Kernel parameters often have the format of

Re: [PATCH v2 061/101] fbdev/ps3fb: Duplicate video-mode option string

2023-03-10 Thread Thomas Zimmermann
Hi Geert Am 10.03.23 um 09:18 schrieb Geert Uytterhoeven: Hi Thomas, On Thu, Mar 9, 2023 at 5:02 PM Thomas Zimmermann wrote: Assume that the driver does not own the option string or its substrings and hence duplicate the option string for the video mode. Allocate the copy's memory with

Re: [PATCH] drm/mipi-dsi: Add a mipi_dual_dsi_dcs_write_seq() macro

2023-03-10 Thread Jianhua Lu
On Fri, Mar 10, 2023 at 01:54:18PM +0200, Jani Nikula wrote: > On Fri, 10 Mar 2023, Jianhua Lu wrote: > > The panels with two dsi connected (sync dual dsi mode) need to transmit > > dcs command to the two dsi host simultaneously, let's add > > mipi_dual_dsi_dcs_write_seq() macro for this kind of

Re: [PATCH v2] fbdev: Fix incorrect page mapping clearance at fb_deferred_io_release()

2023-03-10 Thread Patrik Jakobsson
On Wed, Mar 8, 2023 at 11:50 AM Takashi Iwai wrote: > > The recent fix for the deferred I/O by the commit > 3efc61d95259 ("fbdev: Fix invalid page access after closing deferred I/O > devices") > caused a regression when the same fb device is opened/closed while > it's being used. It resulted

Re: [PATCH v3 2/2] drm/probe_helper: warning on poll_enabled for issue catching

2023-03-10 Thread Jani Nikula
On Fri, 10 Mar 2023, Guchun Chen wrote: > In order to catch issues in other drivers to ensure proper call > sequence of polling function. > > v2: drop Fixes tag in commit message > > Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2411 > Reported-by: Bert Karwatzki > Suggested-by: Dmitry

Re: [PATCH] drm/mipi-dsi: Add a mipi_dual_dsi_dcs_write_seq() macro

2023-03-10 Thread Jani Nikula
On Fri, 10 Mar 2023, Jianhua Lu wrote: > The panels with two dsi connected (sync dual dsi mode) need to transmit > dcs command to the two dsi host simultaneously, let's add > mipi_dual_dsi_dcs_write_seq() macro for this kind of panels. If we were to add a helper for this case, it should be a

Patch "drm/display/dp_mst: Handle old/new payload states in drm_dp_remove_payload()" has been added to the 6.2-stable tree

2023-03-10 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/display/dp_mst: Handle old/new payload states in drm_dp_remove_payload() to the 6.2-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename

Re: [PATCH v2] drm/format-helper: Make conversion_buf_size() support sub-byte pixel fmts

2023-03-10 Thread Javier Martinez Canillas
Javier Martinez Canillas writes: > There are DRM fourcc formats that have pixels smaller than a byte, but the > conversion_buf_size() function assumes that pixels are a multiple of bytes > and use the struct drm_format_info .cpp field to calculate the dst_pitch. > > Instead, calculate it by

Patch "drm/display/dp_mst: Add drm_atomic_get_old_mst_topology_state()" has been added to the 6.2-stable tree

2023-03-10 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/display/dp_mst: Add drm_atomic_get_old_mst_topology_state() to the 6.2-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch

Patch "drm/display/dp_mst: Add drm_atomic_get_old_mst_topology_state()" has been added to the 6.1-stable tree

2023-03-10 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/display/dp_mst: Add drm_atomic_get_old_mst_topology_state() to the 6.1-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch

[PATCH] drm/mipi-dsi: Add a mipi_dual_dsi_dcs_write_seq() macro

2023-03-10 Thread Jianhua Lu
The panels with two dsi connected (sync dual dsi mode) need to transmit dcs command to the two dsi host simultaneously, let's add mipi_dual_dsi_dcs_write_seq() macro for this kind of panels. Signed-off-by: Jianhua Lu --- include/drm/drm_mipi_dsi.h | 15 +++ 1 file changed, 15

Re: [PATCH 1/9] drm: execution context for GEM buffers v3

2023-03-10 Thread Intel
Hi Christian On 2/28/23 09:33, Christian König wrote: This adds the infrastructure for an execution context for GEM buffers which is similar to the existinc TTMs execbuf util and intended to replace it in the long term. The basic functionality is that we abstracts the necessary loop to lock

Re: linux-6.2-rc4+ hangs on poweroff/reboot: Bisected

2023-03-10 Thread Karol Herbst
On Fri, Mar 10, 2023 at 10:26 AM Chris Clayton wrote: > > Hi. > > Is it likely that this fix will be sumbmitted to mainline during the ongoing > 6.3 development cycle? > yes, it's already pushed to drm-misc-fixed, which then will go into the current devel cycle. I just don't know when it's the

Re: [PATCH v4 5/5] drm/i915/gt: Make sure that errors are propagated through request chains

2023-03-10 Thread Matthew Auld
On 08/03/2023 09:41, Andi Shyti wrote: Currently, when we perform operations such as clearing or copying large blocks of memory, we generate multiple requests that are executed in a chain. However, if one of these requests fails, we may not realize it unless it happens to be the last request in

Re: [PATCH v3 0/8] QAIC accel driver

2023-03-10 Thread Stanislaw Gruszka
On Mon, Mar 06, 2023 at 02:33:55PM -0700, Jeffrey Hugo wrote: > This series introduces a driver under the accel subsystem (QAIC - > Qualcomm AIC) for the Qualcomm Cloud AI 100 product (AIC100). AIC100 is > a PCIe adapter card that hosts a dedicated machine learning inference > accelerator.

Re: [PATCH RFC 11/18] drm/scheduler: Clean up jobs when the scheduler is torn down

2023-03-10 Thread Asahi Lina
On 10/03/2023 04.59, Faith Ekstrand wrote: > On Thu, 2023-03-09 at 18:43 +0900, Asahi Lina wrote: >> On 09/03/2023 17.42, Christian König wrote: >>> Long story short: Don't do this! This is what the Windows drivers >>> have >>> been doing and it creates tons of problems. > > Yeah, we tried to do

[PATCH v2] drm/i915/mtl: Disable stolen memory backed FB for A0

2023-03-10 Thread Nirmoy Das
Stolen memory is not usable for MTL A0 stepping beyond certain access size and we have no control over userspace access size of /dev/fb which can be backed by stolen memory. So disable stolen memory backed fb by setting i915->dsm.usable_size to zero. v2: remove hsdes reference and fix commit

Re: [regression] RPI4B drm vc4: no crtc or sizes since 5.17 (works in 5.16; and still broken in at least 6.1)

2023-03-10 Thread AL13N
AL13N schreef op 2023-03-10 10:10: Dave Stevenson schreef op 2023-03-09 13:59: On Wed, 8 Mar 2023 at 22:46, AL13N wrote: AL13N schreef op 2023-03-08 22:16: > Maxime Ripard schreef op 2023-03-08 13:35: >> Hi, >> >> On Tue, Mar 07, 2023 at 05:10:16PM +, Dave Stevenson wrote: >>> On Tue, 7

Re: [PATCH v3 2/2] drm/panel: Add driver for Novatek NT36523

2023-03-10 Thread Jianhua Lu
On Thu, Mar 09, 2023 at 11:37:17PM +0100, Konrad Dybcio wrote: > > [...] > = of_graph_get_remote_node(dsi->dev.of_node, 1, -1); > > + if (!dsi1) { > > + dev_err(dev, "cannot get secondary DSI > > node.\n"); > > + return

Re: linux-6.2-rc4+ hangs on poweroff/reboot: Bisected

2023-03-10 Thread Chris Clayton
Hi. Is it likely that this fix will be sumbmitted to mainline during the ongoing 6.3 development cycle? Chris On 20/02/2023 22:16, Ben Skeggs wrote: > On Mon, 20 Feb 2023 at 21:27, Karol Herbst wrote: >> >> On Mon, Feb 20, 2023 at 11:51 AM Chris Clayton >> wrote: >>> >>> >>> >>> On

[PATCH v6 2/2] drm/i915: add guard page to ggtt->error_capture

2023-03-10 Thread Andrzej Hajda
Write-combining memory allows speculative reads by CPU. ggtt->error_capture is WC mapped to CPU, so CPU/MMU can try to prefetch memory beyond the error_capture, ie it tries to read memory pointed by next PTE in GGTT. If this PTE points to invalid address DMAR errors will occur. This behaviour was

[PATCH v6 1/2] drm/i915/gt: introduce vm->scratch_range callback

2023-03-10 Thread Andrzej Hajda
The callback will be responsible for setting scratch page PTEs for specified range. In contrast to clear_range it cannot be optimized to nop. It will be used by code adding guard pages. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/gt/intel_ggtt.c | 23 +++

[PATCH v6 0/2] drm/i915: add guard page to ggtt->error_capture

2023-03-10 Thread Andrzej Hajda
This patch tries to diminish plague of DMAR read errors present in CI for ADL*, RPL*, DG2 platforms, see for example [1] (grep DMAR). CI is usually tolerant for these errors, so the scale of the problem is not really visible. To show it I have counted lines containing DMAR read errors in dmesgs

Re: [PATCH v8 1/3] drm/mediatek: Refactor pixel format logic

2023-03-10 Thread AngeloGioacchino Del Regno
Il 09/03/23 22:04, Justin Green ha scritto: Add an DDP component interface for querying pixel format support and move list of supported pixel formats into DDP components instead of mtk_drm_plane.c Tested by running Chrome on an MT8195. Signed-off-by: Justin Green Reviewed-by:

Re: [PATCH v8 2/3] drm/mediatek: Add support for AR30 and BA30 overlays

2023-03-10 Thread AngeloGioacchino Del Regno
Il 09/03/23 22:06, Justin Green ha scritto: Add the ability for the Mediatek DRM driver to control the bit depth register. If the DTS indicates the device supports 10-bit overlays and the current format has a fourcc of AR30, BA30, or RA30, we set the bit depth register to 10 bit. The next patch

Re: [PATCH v8 3/3] drm/mediatek: Enable AR30 and BA30 overlays on MT8195

2023-03-10 Thread AngeloGioacchino Del Regno
Il 09/03/23 22:04, Justin Green ha scritto: Modify the overlay driver data for MT8195 to enable bit depth control and enable support for AR30 and BA30 framebuffer formats. This patch in combination with the previous two patches in the series will allow MT8195 devices to scanout AR30 and BA30

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-03-10 Thread Asahi Lina
On 10/03/2023 03.50, Faith Ekstrand wrote: > Jumping in here quick... (Sorry, I was out yesterday and was ignoring > my e-mail on Tuesday so I could finally type some compiler code.) > > On Thu, 2023-03-09 at 18:14 +0900, Asahi Lina wrote: >> On 09/03/2023 17.05, Christian König wrote: >>> Am

Re: [regression] RPI4B drm vc4: no crtc or sizes since 5.17 (works in 5.16; and still broken in at least 6.1)

2023-03-10 Thread AL13N
Dave Stevenson schreef op 2023-03-09 13:59: On Wed, 8 Mar 2023 at 22:46, AL13N wrote: AL13N schreef op 2023-03-08 22:16: > Maxime Ripard schreef op 2023-03-08 13:35: >> Hi, >> >> On Tue, Mar 07, 2023 at 05:10:16PM +, Dave Stevenson wrote: >>> On Tue, 7 Mar 2023 at 16:25, AL13N wrote: >>>

Re: [PATCH] drm/meson: dw-hdmi: Fix devm_regulator_*get_enable*() conversion again

2023-03-10 Thread Neil Armstrong
On 09/03/2023 16:24, Marek Szyprowski wrote: devm_regulator_get_enable_optional() returns -ENODEV if requested optional regulator is not present. Adjust code for that, because in the 67d0a30128c9 I've incorrectly assumed that it also returns 0 when regulator is not present. Reported-by: Ricardo

Re: [PATCH 01/21] dt-bindings: display: mediatek: aal: add binding for MT8365 SoC

2023-03-10 Thread Krzysztof Kozlowski
On 09/03/2023 15:22, Alexandre Mergnat wrote: > Display Adaptive Ambient Light for MT8365 is compatible with another SoC. > Then, add MT8365 binding along with MT8183 SoC. > > Signed-off-by: Alexandre Mergnat Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 15/21] dt-bindings: soc: mediatek: add display mutex for MT8365 SoC

2023-03-10 Thread Krzysztof Kozlowski
On 09/03/2023 15:23, Alexandre Mergnat wrote: > Add compatible for the MT8365 SoC. > > Signed-off-by: Alexandre Mergnat > --- > Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git >

Re: [PATCH 13/21] dt-bindings: pwm: add binding for mt8365 SoC

2023-03-10 Thread Krzysztof Kozlowski
On 09/03/2023 15:23, Alexandre Mergnat wrote: > Display PWM for MT8365 is compatible with MT8183. Then, add MT8365 binding > along with MT8183 SoC. > Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 10/21] dt-bindings: display: mediatek: rdma: add binding for MT8365 SoC

2023-03-10 Thread Krzysztof Kozlowski
On 09/03/2023 15:22, Alexandre Mergnat wrote: > Display Data Path Read DMA for MT8365 is compatible with another SoC. > Then, add MT8365 binding along with MT8183 SoC. > > Signed-off-by: Alexandre Mergnat Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 09/21] dt-bindings: display: mediatek: ovl: add binding for MT8365 SoC

2023-03-10 Thread Krzysztof Kozlowski
On 09/03/2023 15:22, Alexandre Mergnat wrote: > Display Overlay for MT8365 is compatible with another SoC. > Then, add MT8365 binding along with MT8192 SoC. > > Signed-off-by: Alexandre Mergnat Best regards, Krzysztof

Re: [PATCH 08/21] dt-bindings: display: mediatek: gamma: add binding for MT8365 SoC

2023-03-10 Thread Krzysztof Kozlowski
On 09/03/2023 15:22, Alexandre Mergnat wrote: > Display GAMMA for MT8365 is compatible with another SoC. > Then, add MT8365 binding along with MT8183 SoC. > > Signed-off-by: Alexandre Mergnat Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 07/21] dt-bindings: display: mediatek: dpi: add binding for MT8365

2023-03-10 Thread Krzysztof Kozlowski
On 09/03/2023 15:22, Alexandre Mergnat wrote: > From: Fabien Parent > > DPI for MT8365 is compatible with MT8192 but requires an additional > clock. Modify the documentation to requires this clock only on MT8365 SoCs. > > Signed-off-by: Fabien Parent > Signed-off-by: Alexandre Mergnat > --- >

Re: [PATCH 05/21] dt-bindings: display: mediatek: dsi: add binding for MT8365 SoC

2023-03-10 Thread Krzysztof Kozlowski
On 09/03/2023 15:22, Alexandre Mergnat wrote: > Display Serial Interface for MT8365 is compatible with another SoC. > Then, add MT8365 binding along with MT8183 SoC. > > Signed-off-by: Alexandre Mergnat > --- > .../bindings/display/mediatek/mediatek,dsi.yaml | 19 > --- >

  1   2   >