RE: [EXT] Re: [PATCH v6 5/8] drm: bridge: Cadence: Add MHDP8501 HDMI driver

2023-06-18 Thread Alexander Stein
Hi Sandor, Am Montag, 19. Juni 2023, 05:11:02 CEST schrieb Sandor Yu: > Hi Alexander, > > Thanks for your comments, > > > > -Original Message- > > From: Alexander Stein > > Sent: 2023年6月16日 17:30 > > To: andrzej.ha...@intel.com; neil.armstr...@linaro.org; > > robert.f...@linaro.org;

Re: [PATCH v7 2/8] PCI/VGA: Deal only with VGA class devices

2023-06-18 Thread Sui Jingfeng
Hi, On 2023/6/19 11:02, Maciej W. Rozycki wrote: On Tue, 13 Jun 2023, Sui Jingfeng wrote: Deal only with the VGA devcie(pdev->class == 0x0300), so replace the Typo here: s/devcie/device/. Thanks a lot, pci_get_subsys() function with pci_get_class(). Filter the non-PCI display

Re: [14/14] drm/ast: Merge config and chip detection

2023-06-18 Thread Sui Jingfeng
Hi, On 2023/6/16 21:52, Thomas Zimmermann wrote: Detection of the configuration mode and the chipset model are linked to each other. They don't  has a strong relationship,  chipset model detection should the first function to be run(should be run early). chipset model detection should only

Re: [PATCH v7 2/8] PCI/VGA: Deal only with VGA class devices

2023-06-18 Thread Maciej W. Rozycki
On Tue, 13 Jun 2023, Sui Jingfeng wrote: > Deal only with the VGA devcie(pdev->class == 0x0300), so replace the Typo here: s/devcie/device/. > pci_get_subsys() function with pci_get_class(). Filter the non-PCI display > device(pdev->class != 0x0300) out. There no need to process the

RE: [EXT] Re: [PATCH v6 5/8] drm: bridge: Cadence: Add MHDP8501 HDMI driver

2023-06-18 Thread Sandor Yu
Hi Alexander, Thanks for your comments, > -Original Message- > From: Alexander Stein > Sent: 2023年6月16日 17:30 > To: andrzej.ha...@intel.com; neil.armstr...@linaro.org; > robert.f...@linaro.org; laurent.pinch...@ideasonboard.com; > jo...@kwiboo.se; jernej.skra...@gmail.com;

RE: [EXT] Re: [PATCH v6 2/8] dt-bindings: display: bridge: Add Cadence MHDP8501 HDMI and DP

2023-06-18 Thread Sandor Yu
Hi Alexander, Thanks for your comments, > -Original Message- > From: Alexander Stein > Sent: 2023年6月16日 17:32 > To: andrzej.ha...@intel.com; neil.armstr...@linaro.org; > robert.f...@linaro.org; laurent.pinch...@ideasonboard.com; > jo...@kwiboo.se; jernej.skra...@gmail.com;

RE: [EXT] Re: [PATCH v6 6/8] dt-bindings: phy: Add Freescale iMX8MQ DP and HDMI PHY

2023-06-18 Thread Sandor Yu
Hi Alexander, Thanks for your comments, > -Original Message- > From: Alexander Stein > Sent: 2023年6月16日 17:35 > To: andrzej.ha...@intel.com; neil.armstr...@linaro.org; > robert.f...@linaro.org; laurent.pinch...@ideasonboard.com; > jo...@kwiboo.se; jernej.skra...@gmail.com;

Re: [13/14] drm/ast: Move widescreen- and tx-chip detection into separate helpers

2023-06-18 Thread Sui Jingfeng
Hi, Split ast_detect_chip() into three functions made it more clear. As tx-chip is typicality  suffer from changed, and it is a choice of the PCB board designer. tx-chip belong to the output, which chip identify and wide screen support is a capability of the chip itself, once the chip is

Re: [PATCH V3 7/7] drm/amd/pm: enable Wifi RFI mitigation feature support for SMU13.0.7

2023-06-18 Thread Mario Limonciello
On 6/16/23 01:57, Evan Quan wrote: Fulfill the SMU13.0.7 support for Wifi RFI mitigation feature. Signed-off-by: Evan Quan Reviewed-by: Mario Limonciello --- .../drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 59 +++ 1 file changed, 59 insertions(+) diff --git

Re: [PATCH V3 6/7] drm/amd/pm: enable Wifi RFI mitigation feature support for SMU13.0.0

2023-06-18 Thread Mario Limonciello
On 6/16/23 01:57, Evan Quan wrote: Fulfill the SMU13.0.0 support for Wifi RFI mitigation feature. Signed-off-by: Evan Quan Reviewed-by: Mario Limonciello --- drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 3 + drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h | 3 +-

Re: [PATCH v7 2/8] PCI/VGA: Deal only with VGA class devices

2023-06-18 Thread Sui Jingfeng
On 2023/6/18 20:11, Sui Jingfeng wrote: And screen_info is more about video specifci thing. screen_info is something more about video specific thing.

Re: [PATCH V3 5/7] drm/amd/pm: add flood detection for wbrf events

2023-06-18 Thread Mario Limonciello
On 6/16/23 01:57, Evan Quan wrote: To protect PMFW from being overloaded. Signed-off-by: Evan Quan Reviewed-by: Mario Limonciello --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 28 --- drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 7 + 2 files changed, 31

Re: [PATCH V3 4/7] drm/amd/pm: setup the framework to support Wifi RFI mitigation feature

2023-06-18 Thread Mario Limonciello
On 6/16/23 01:57, Evan Quan wrote: With WBRF feature supported, as a driver responding to the frequencies, amdgpu driver is able to do shadow pstate switching to mitigate possible interference(between its (G-)DDR memory clocks and local radio module frequency bands used by Wifi 6/6e/7). To make

Re: [PATCH V3 3/7] drm/amd/pm: update driver_if and ppsmc headers for coming wbrf feature

2023-06-18 Thread Mario Limonciello
On 6/16/23 01:57, Evan Quan wrote: Add those data structures to support Wifi RFI mitigation feature. Signed-off-by: Evan Quan Reviewed-by: Mario Limonciello --- .../pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_0.h | 14 +- .../pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_7.h |

Re: [PATCH V3 2/7] wifi: mac80211: Add support for ACPI WBRF

2023-06-18 Thread Mario Limonciello
On 6/16/23 01:57, Evan Quan wrote: From: Mario Limonciello To support AMD's WBRF interference mitigation mechanism, Wifi adapters utilized in the system must register the frequencies in use(or unregister those frequencies no longer used) via the dedicated APCI calls. So that, other drivers

Re: [PATCH v7 2/8] PCI/VGA: Deal only with VGA class devices

2023-06-18 Thread Sui Jingfeng
Hi, On 2023/6/18 20:11, Sui Jingfeng wrote: call back to use if successful Call back to us if the drm device driver bound to the PCI GPU successfully

Re: [PATCH V3 1/7] drivers/acpi: Add support for Wifi band RF mitigations

2023-06-18 Thread Mario Limonciello
On 6/16/23 01:57, Evan Quan wrote: From: Mario Limonciello Due to electrical and mechanical constraints in certain platform designs there may be likely interference of relatively high-powered harmonics of the (G-)DDR memory clocks with local radio module frequency bands used by Wifi 6/6e/7.

Re: [08/14] drm/ast: Set up release action right after enabling MMIO

2023-06-18 Thread Sui Jingfeng
Hi, Tested with ast2400 On 2023/6/16 21:52, Thomas Zimmermann wrote: Ast sets up a managed release of the MMIO access flags. Move this code next to the MMIO access code, so that it runs if other errors occur during the device initialization. Signed-off-by: Thomas Zimmermann Tested-by:

linux-next: manual merge of the drm tree with Linus' tree

2023-06-18 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/amd/amdgpu/amdgpu_object.c between commit: 34e5a54327dc ("Revert "drm/amdgpu: remove TOPDOWN flags when allocating VRAM in large bar system"") from Linus' tree and commit: 7f6db89418f9 ("drm/amdgpu:

[pull] drm/msm: drm-msm-next-2023-06-18 for v6.5

2023-06-18 Thread Rob Clark
Hi Dave, This is the pull for v6.5, see below for description. It includes a back-merge of drm-next for DSC helpers. Sorry it is somewhat late, I was out of town last week. (resend without all the back-merge commits in the msg) The following changes since commit

[PATCH v4 1/2] drm/fourcc: Add NV20 and NV30 YUV formats

2023-06-18 Thread Jonas Karlman
DRM_FORMAT_NV20 and DRM_FORMAT_NV30 formats is the 2x1 and non-subsampled variant of NV15, a 10-bit 2-plane YUV format that has no padding between components. Instead, luminance and chrominance samples are grouped into 4s so that each group is packed into an integer number of bytes: = UVUV =

[PATCH v4 2/2] drm/rockchip: vop: Add NV15, NV20 and NV30 support

2023-06-18 Thread Jonas Karlman
Add support for displaying 10-bit 4:2:0 and 4:2:2 formats produced by the Rockchip Video Decoder on RK322X, RK3288, RK3328 and RK3399. Also add support for 10-bit 4:4:4 format while at it. V4: Rework RK3328/RK3399 win0/1 data to not affect RK3368 V2: Added NV30 support Signed-off-by: Jonas

[PATCH v4 0/2] drm/rockchip: vop: Add NV15, NV20 and NV30 support

2023-06-18 Thread Jonas Karlman
This series add support for displaying 10-bit 4:2:0 and 4:2:2 formats produced by the Rockchip Video Decoder on RK322X, RK3288, RK3328, RK3368 and RK3399. Also include 10-bit 4:4:4 support since VOP can support that also. First patch adds new fourcc 10-bit YUV formats with 4:2:2/4:4:4

[PATCH] video/hdmi: Reorder fields in 'struct hdmi_avi_infoframe'

2023-06-18 Thread Christophe JAILLET
Group some variables based on their sizes to reduce hole and avoid padding. On x86_64, this shrinks the size of 'struct hdmi_avi_infoframe' from 68 to 60 bytes. It saves a few bytes of memory and is more cache-line friendly. This also reduces the union hdmi_infoframe the same way.

Re: [PATCH v2] drm/i915: Replace kmap() with kmap_local_page()

2023-06-18 Thread Ira Weiny
Sumitra Sharma wrote: > kmap() has been deprecated in favor of the kmap_local_page() > due to high cost, restricted mapping space, the overhead of a > global lock for synchronization, and making the process sleep > in the absence of free slots. > > kmap_local_page() is faster than kmap() and

Re: [PATCH] drm: bridge: dw-mipi-dsi: Fix enable/disable of DSI controller

2023-06-18 Thread Julian
Tested-by: Julian Fairfax On 17.06.23 17:06, Ondřej Jirman wrote: > From: Ondrej Jirman > > Before this patch, booting to Linux VT and doing a simple: > >echo 2 > /sys/class/graphics/fb0/blank >echo 0 > /sys/class/graphics/fb0/blank > > would result in failures to re-enable the panel.

Re: [PATCH v2 2/6] dt-bindings: display: st7789v: bound the number of Rx data lines

2023-06-18 Thread Miquel Raynal
Hello Maxime, max...@cerno.tech wrote on Sun, 18 Jun 2023 16:37:58 +0200: > Hi, > > On Fri, Jun 16, 2023 at 06:32:51PM +0200, Miquel Raynal wrote: > > The ST7789V LCD controller supports regular SPI wiring, as well as no Rx > > data line at all. The operating system needs to know whether it can

Re: [PATCH 2/2] drm/panel: simple: Add support for Mitsubishi AA084XE01

2023-06-18 Thread Sam Ravnborg
Hi Miquel, On Fri, Jun 16, 2023 at 06:45:24PM +0200, Miquel Raynal wrote: > From: Thomas Weber > > Add support for the Mitsubishi AA084XE01 panel which is an 8.4 inch XGA > TFT-LCD module for industrial use. > > Link: https://www.mouser.fr/datasheet/2/274/aa084xe01_e-364171.pdf >

Re: [PATCH v2 6/6] drm/panel: sitronix-st7789v: Check display ID

2023-06-18 Thread Maxime Ripard
On Fri, 16 Jun 2023 18:32:55 +0200, Miquel Raynal wrote: > A very basic debugging rule when a device is connected for the first > time is to access a read-only register which contains known data in > order to ensure the communication protocol is properly working. This > driver lacked any read

Re: [PATCH v2 5/6] drm/panel: sitronix-st7789v: Add EDT ET028013DMA panel support

2023-06-18 Thread Maxime Ripard
On Fri, 16 Jun 2023 18:32:54 +0200, Miquel Raynal wrote: > This panel from Emerging Display Technologies Corporation features an > ST7789V2 LCD controller panel inside which is almost identical to what > the Sitronix panel driver supports. > > In practice, the module physical size is specific,

Re: [PATCH v2 4/6] drm/panel: sitronix-st7789v: Clarify a definition

2023-06-18 Thread Maxime Ripard
On Fri, 16 Jun 2023 18:32:53 +0200, Miquel Raynal wrote: > The Sitronix datasheet explains BIT(1) of the RGBCTRL register as the > DOTCLK/PCLK edge used to sample the data lines: > > “0” The data is input on the positive edge of DOTCLK > “1” The data is input on the negative edge

Re: [PATCH v2 3/6] drm/panel: sitronix-st7789v: Use 9 bits per spi word by default

2023-06-18 Thread Maxime Ripard
On Fri, 16 Jun 2023 18:32:52 +0200, Miquel Raynal wrote: > The Sitronix controller expects 9-bit words, provide this as default at > probe time rather than specifying this in each and every access. > > Signed-off-by: Miquel Raynal > Reviewed-by: Sam Ravnborg > > [ ... ] Acked-by: Maxime

Re: [PATCH v2 2/6] dt-bindings: display: st7789v: bound the number of Rx data lines

2023-06-18 Thread Maxime Ripard
Hi, On Fri, Jun 16, 2023 at 06:32:51PM +0200, Miquel Raynal wrote: > The ST7789V LCD controller supports regular SPI wiring, as well as no Rx > data line at all. The operating system needs to know whether it can read > registers from the device or not. Let's detail this specific design >

Re: [PATCH v2 1/6] dt-bindings: display: st7789v: Add the edt,et028013dma panel compatible

2023-06-18 Thread Maxime Ripard
On Fri, 16 Jun 2023 18:32:50 +0200, Miquel Raynal wrote: > The ST7789V LCD controller is also embedded in the ET028013DMA > panel. Add a compatible string to describe this other panel. > > Signed-off-by: Miquel Raynal Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v7 2/8] PCI/VGA: Deal only with VGA class devices

2023-06-18 Thread Sui Jingfeng
Hi, On 2023/6/16 22:34, Alex Deucher wrote: On Fri, Jun 16, 2023 at 10:22 AM Sui Jingfeng wrote: On 2023/6/16 21:41, Alex Deucher wrote: On Fri, Jun 16, 2023 at 3:11 AM Sui Jingfeng wrote: Hi, On 2023/6/16 05:11, Alex Deucher wrote: On Wed, Jun 14, 2023 at 6:50 AM Sui Jingfeng wrote:

[PATCH v2 3/3] drm/amd/display: Implement the retrieval of checksum_region's CRC data

2023-06-18 Thread Alan Liu
Retrieve and store checksum_region's CRC data from the DC hardware in vline0 irq handler. A new function amdgpu_dm_crtc_update_checksum_region_crc() is implemented and hooked to CRTC callback for updating the latest CRC values to the checksum CRC blob. Signed-off-by: Alan Liu ---

[PATCH v2 2/3] drm/amd/display: Create checksum_region properties and handle new region update

2023-06-18 Thread Alan Liu
This commit creates checksum_region properties at CRTC initialization, and update the new region during the atomic atomic. A new function amdgpu_dm_crtc_set_secure_display_crc_source() is implemented to control the state of CRC engine of DC hardware. Signed-off-by: Alan Liu ---

[PATCH v2 0/3] Checksum Region with new CRTC properties

2023-06-18 Thread Alan Liu
Dear DRM development community, We'd like to introduce the implementation of the new crtc properties. First of all, please let me introduce the problem we try to address. With the popularity of electric vehicles, the car vendors have increasing requirement for ensuring the integrity of the

[PATCH v2 1/3] drm: Introduce CRTC checksum region and CRC properties

2023-06-18 Thread Alan Liu
Introduce per-CRTC properties: CHECKSUM_REGION and CHECKSUM_CRC. Userspace can configure a region by setting the region property and retrieve the CRC values from the CRC property to validate the content of the region. Apon userspace submits the 4 coordinate values with checksum_region_enable

Re: [13/14] drm/ast: Move widescreen- and tx-chip detection into separate helpers

2023-06-18 Thread Sui Jingfeng
Hi, "widescreen-" -> "widescreen" On 2023/6/16 21:52, Thomas Zimmermann wrote: Split ast_detect_chip() into three functions and call them one by one. The new functions detect the transmitter chip and widescreen support. This will allow for further refactoring. Signed-off-by: Thomas

[PATCH v2 2/2] ARM: tegra: transformers: add connector node

2023-06-18 Thread Svyatoslav Ryhel
All ASUS Transformers have micro-HDMI connector directly available. After Tegra HDMI got bridge/connector support, we should use connector framework for proper HW description. Tested-by: Andreas Westman Dorcsak # ASUS TF T30 Tested-by: Robert Eckelmann # ASUS TF101 T20 Tested-by: Svyatoslav

[PATCH v2 1/2] drm/tegra: output: hdmi: Support bridge/connector

2023-06-18 Thread Svyatoslav Ryhel
From: Maxim Schwalm Some Tegra device-trees may specify a video output graph, which involves MHL bridge/simple bridge and/or connector framework. This patch adds support for the bridge/connector attached to the HDMI output, allowing us to model the hardware properly. Inspired by: 29efdc2

[PATCH v2 0/2] Support bridge/connector by Tegra HDMI

2023-06-18 Thread Svyatoslav Ryhel
This patch adds support for the bridge/connector attached to the HDMI output, allowing to model the hardware properly. It keeps backwards compatibility with existing bindings and is required by devices which have a simple or MHL bridge connected to HDMI output like ASUS P1801-T or LG P880/P895 or

Re: [PATCH v2 3/4] drm/mediatek: Add casting before assign

2023-06-18 Thread 林睿祥
Hi Angelo, Thanks for the reviews. On Wed, 2023-06-14 at 10:43 +0200, AngeloGioacchino Del Regno wrote: External email : Please do not click links or open attachments until you have verified the sender or the content. Il 13/06/23 13:32, Jason-JH.Lin ha scritto: > 1. Add casting before assign

Re: [Intel-xe] [RFC PATCH 1/1] drm/xe: Introduce function pointers for MMIO functions

2023-06-18 Thread Oded Gabbay
On Thu, Jun 15, 2023 at 7:34 PM Matt Roper wrote: > > On Thu, Jun 15, 2023 at 04:04:18PM +0300, Oded Gabbay wrote: > > On Thu, Jun 15, 2023 at 3:01 AM Matt Roper > > wrote: > > > > > > On Mon, Jun 12, 2023 at 06:31:57PM +0200, Francois Dugast wrote: > > > > On Thu, Jun 08, 2023 at 10:35:29AM

Re: [Intel-xe] [RFC PATCH 1/1] drm/xe: Introduce function pointers for MMIO functions

2023-06-18 Thread Oded Gabbay
On Thu, Jun 15, 2023 at 7:34 PM Matt Roper wrote: > > On Thu, Jun 15, 2023 at 04:04:18PM +0300, Oded Gabbay wrote: > > On Thu, Jun 15, 2023 at 3:01 AM Matt Roper > > wrote: > > > > > > On Mon, Jun 12, 2023 at 06:31:57PM +0200, Francois Dugast wrote: > > > > On Thu, Jun 08, 2023 at 10:35:29AM

Re: [PATCH v2 4/4] drm/mediatek: Fix dereference before null check

2023-06-18 Thread 林睿祥
Hi Angelo, On Wed, 2023-06-14 at 10:43 +0200, AngeloGioacchino Del Regno wrote: External email : Please do not click links or open attachments until you have verified the sender or the content. Il 13/06/23 13:32, Jason-JH.Lin ha scritto: > Null-checking state suggests that it may be null, but

Re: patches dropped from drm-misc-next [Was: Re: [PATCH 00/53] drm: Convert to platform remove callback returning] void

2023-06-18 Thread Doug Anderson
Hi, On Sat, Jun 17, 2023 at 9:15 AM Uwe Kleine-König wrote: > > [expanding recipents by the other affected persons] > > On Thu, Jun 08, 2023 at 09:08:15AM -0700, Doug Anderson wrote: > > On Thu, Jun 1, 2023 at 8:40 AM Uwe Kleine-König > > wrote: > > > > > > Hello, > > > > > > On Sun, May 07,

Re: [Intel-gfx] [PATCH] drm/i915: Call page_address() on page acquired with GFP_KERNEL flag

2023-06-18 Thread Sumitra Sharma
On Wed, Jun 14, 2023 at 05:30:25PM +0200, Thomas Hellström (Intel) wrote: > > On 6/14/23 15:22, Tvrtko Ursulin wrote: > > > > On 14/06/2023 13:35, Sumitra Sharma wrote: > > > Pages allocated with GFP_KERNEL cannot come from Highmem. > > > That is why there is no need to call kmap() on them. >

patches dropped from drm-misc-next [Was: Re: [PATCH 00/53] drm: Convert to platform remove callback returning] void

2023-06-18 Thread Uwe Kleine-König
[expanding recipents by the other affected persons] On Thu, Jun 08, 2023 at 09:08:15AM -0700, Doug Anderson wrote: > On Thu, Jun 1, 2023 at 8:40 AM Uwe Kleine-König > wrote: > > > > Hello, > > > > On Sun, May 07, 2023 at 06:25:23PM +0200, Uwe Kleine-König wrote: > > > this patch series adapts

Re: [PATCH] drm: bridge: dw-mipi-dsi: Fix enable/disable of DSI controller

2023-06-18 Thread Julian Fairfax
Tested-by: Julian Fairfax

Re: patches dropped from drm-misc-next [Was: Re: [PATCH 00/53] drm: Convert to platform remove callback returning] void

2023-06-18 Thread Chen-Yu Tsai
On Sun, Jun 18, 2023 at 12:13 AM Uwe Kleine-König wrote: > > [expanding recipents by the other affected persons] > > On Thu, Jun 08, 2023 at 09:08:15AM -0700, Doug Anderson wrote: > > On Thu, Jun 1, 2023 at 8:40 AM Uwe Kleine-König > > wrote: > > > > > > Hello, > > > > > > On Sun, May 07, 2023

[PATCH v2] drm/i915: Replace kmap() with kmap_local_page()

2023-06-18 Thread Sumitra Sharma
kmap() has been deprecated in favor of the kmap_local_page() due to high cost, restricted mapping space, the overhead of a global lock for synchronization, and making the process sleep in the absence of free slots. kmap_local_page() is faster than kmap() and offers thread-local and CPU-local

Re: [PATCH 2/3] dt-bindings: backlight: lm3630a: add entries to control boost frequency

2023-06-18 Thread Maximilian Weigand
Hi, On 17.06.23 19:42, Krzysztof Kozlowski wrote: > On 17/06/2023 18:34, Heiko Stübner wrote: >> Am Samstag, 17. Juni 2023, 12:12:17 CEST schrieb Krzysztof Kozlowski: >>> On 14/06/2023 21:08, Maximilian Weigand wrote: From: Maximilian Weigand Add 'ti,boost_use_1mhz' to switch

Re: [PATCH v2] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO

2023-06-18 Thread Sui Jingfeng
Hi, On 2023/6/18 04:41, Paul Cercueil wrote: Hi, Le samedi 17 juin 2023 à 21:48 +0200, Sam Ravnborg a écrit : Hi Paul, On Sat, Jun 17, 2023 at 09:13:37PM +0200, Paul Cercueil wrote: Hi, Le mercredi 07 juin 2023 à 19:06 +0800, Sui Jingfeng a écrit : Otherwise its failed to pass basic